@sprigr/apps-fleet-conventions 0.1.0 → 0.2.0

package/dist/index.d.ts

@@ -173,6 +173,41 @@ declare function isUnactionableRuling(body: string): boolean;
  * sample), as does anything not opening with the reviewer's own prefix.
  */
 declare function isMalformedVerdictPost(body: string): boolean;
+/**
+ * POST-TIME ONLY: this body would post but be INVISIBLE to the reader.
+ *
+ * `isMalformedVerdictPost` fails open when a verdict's `VERDICT:` line sits
+ * beyond `VERDICT_STATEMENT_WINDOW` (800) chars, which is exactly how the two
+ * #12926 duplicate-verdict pairs got through: the reviewer posted a long-form
+ * verdict whose ruling landed thousands of chars down (platform#157,
+ * `VERDICT:` at offset 2467) or placed the identity prefix ABOVE the machine
+ * marker (platform#148). Both carried the marker, both failed
+ * `TECH_LEAD_VERDICT_FORM_RE`, both posted, and the merge gate / router / the
+ * review-gate then saw no verdict — so the reviewer had to repost a canonical
+ * copy, producing the duplicate. A long-form REQUEST_CHANGES is worse: it is
+ * absent to the merge gate (reads as "no verdict") until someone reposts it.
+ *
+ * This predicate is the reader's complement with NO window, for the one shape
+ * the window cannot safely cover: a body that opens as the reviewer's OWN
+ * comment (`REVIEWER_ANCHOR_RE`, which a `[dev-fixer]` note quoting a verdict
+ * does not match) and carries the machine marker. The marker is the safe
+ * signal — by contract only a real verdict carries it, and prose that merely
+ * QUOTES a verdict never does — so a marker-carrying reviewer body the reader
+ * cannot parse is an invisible verdict wherever its ruling sits, and
+ * tag-before-marker is caught the same way (the marker is still present).
+ *
+ * For a MARKER-LESS reviewer body it defers to `isMalformedVerdictPost`'s
+ * 800-char window unchanged: that window exists so a long reviewer consult
+ * that QUOTES `VERDICT:` deep in its prose still posts (#6484 / #7653), and
+ * dropping it here would refuse those. So a marker-less deep quote under the
+ * reviewer's own anchor keeps posting, exactly as today.
+ *
+ * (Narrower than one reading of the #12926 fix sketch, which would refuse any
+ * reviewer-anchored body with a `VERDICT:` ANYWHERE: that re-introduces the
+ * deep-quote regression the window was added to prevent. The marker clause
+ * catches every observed #12926 case without it.)
+ */
+declare function wouldPostInvisibleVerdict(body: string): boolean;
 /** The head SHA a verdict names, from whichever form it used. */
 declare function verdictNamedSha(body: string): string | undefined;
 
@@ -241,4 +276,4 @@ declare function shardParityForAgentSlug(slug: string | null | undefined): Shard
  */
 declare function isInShard(issueNumber: number, parity: ShardParity): boolean;
 
-export { FLEET_SHARD_OWNERS, type ShardParity, TECH_LEAD_VERDICT_FORM_RE, TECH_LEAD_VERDICT_RE, type TechLeadRuling, type TechLeadVerdict, VERDICT_MARKER_RE, VERDICT_MARKER_STRIP_RE, isInShard, isMalformedVerdictPost, isUnactionableRuling, isUnparsedVerdictShaped, issueShardParity, normalizeVerdictRuling, parseAnchoredVerdictRuling, parseTechLeadVerdict, shardParityForAgentSlug, verdictNamedSha };
+export { FLEET_SHARD_OWNERS, type ShardParity, TECH_LEAD_VERDICT_FORM_RE, TECH_LEAD_VERDICT_RE, type TechLeadRuling, type TechLeadVerdict, VERDICT_MARKER_RE, VERDICT_MARKER_STRIP_RE, isInShard, isMalformedVerdictPost, isUnactionableRuling, isUnparsedVerdictShaped, issueShardParity, normalizeVerdictRuling, parseAnchoredVerdictRuling, parseTechLeadVerdict, shardParityForAgentSlug, verdictNamedSha, wouldPostInvisibleVerdict };

package/dist/index.js

@@ -28,6 +28,12 @@ function isMalformedVerdictPost(body) {
   if (!/VERDICT:/i.test(body.slice(0, VERDICT_STATEMENT_WINDOW))) return false;
   return !TECH_LEAD_VERDICT_FORM_RE.test(body);
 }
+function wouldPostInvisibleVerdict(body) {
+  if (TECH_LEAD_VERDICT_FORM_RE.test(body)) return false;
+  if (!REVIEWER_ANCHOR_RE.test(body)) return false;
+  if (VERDICT_MARKER_RE.test(body)) return true;
+  return isMalformedVerdictPost(body);
+}
 var VERDICT_HEAD_SHA_PATTERNS = [
   // Canonical machine marker. seed-fleet-agents.ts mandates it as the FIRST
   // line of every verdict ("<!-- verdict sha=<7-char head SHA> -->") and calls
@@ -85,5 +91,6 @@ export {
   parseAnchoredVerdictRuling,
   parseTechLeadVerdict,
   shardParityForAgentSlug,
-  verdictNamedSha
+  verdictNamedSha,
+  wouldPostInvisibleVerdict
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sprigr/apps-fleet-conventions",
-  "version": "0.1.0",
+  "version": "0.2.0",
   "description": "Sprigr dev-fleet GitHub comment conventions: tech-lead verdict parsing and the odd/even issue shard rule",
   "type": "module",
   "main": "./dist/index.js",