@sprigr/apps-app-sdk 0.19.0 → 0.20.0

package/README.md

@@ -99,8 +99,9 @@ Three platform tiers, and they are not substitutes for each other. Full guide: [
 - `undoEnvelope({...})` throws on a blank field. The platform drops the whole envelope on a blank and mints nothing, silently.
 - `refuseWithoutForce(name, handler, opts)` / `archiveOfferRefusal(...)`: a delete refuses once and offers the vendor's native archive unless `force: true`.
 - `buildConfirmationPolicy({ irreversible, always, rules })` declares a dispatcher's policy beside its action registry; `checkConfirmationPolicy({ policy, registry, ungated, requiredInput })` returns every silent failure (dead rule, `(unset)` placeholder, money threshold, unclassified write) for a one-line test.
+- **Ask once when T1 and T2 both gate an action.** Pass `approval: { covered, conditional }` to `buildConfirmationPolicy` (or `deriveConfirmationPolicy`) and to `checkConfirmationPolicy`: `covered` is your approval spec keys (`Object.keys(APPROVAL_SPECS)`), `conditional` the covered actions your app sends through the gate only under a condition of its own (simpro's `GATE_ONLY_WHEN`), `[]` when there are none. Both are required. Each covered, unconditional, gated action gets `attended: 'approval_card'`, and the platform then skips the confirmation on a turn with a person on it, so the card is the only prompt; unattended runs still confirm. The builder never marks a conditional action, and the check fails a key that no spec covers or that sits on a conditional action (no prompt at all on a call that skips the card), a covered unconditional action without one (it asks twice), and a `conditional` entry with no spec. For flat `requireApproval` tools, run `attendedFindings(tool, rule, { covered, conditional })` over each tool-level rule. Needs a platform with sprigr-team decision 0167; an older one ignores the key and keeps asking twice.
 - `runUndoApply(args, { env, journal, specs, pin })` is the body of your `internal: true` reverse tool: load, re-pin to the journalled connection, restore, drop. `pin` may hand `restore` a different type from the env (a per-actor token state), may throw (`connection_unavailable`) or return null to refuse (`connection_mismatch`); a restore that throws is `restore_failed` and the copy is kept; a successful restore may return `newId`, `notRestored`, `extra` (spread into the payload) and `note` (appended after the fidelity sentence).
 - `safeCapture(scope, name, id, read)` and `offerUndo({ journal, entity, id, before, connection, fidelity, resource, describe, warning })`: the capture-then-offer halves for a write that is not behind an approval card (a dispatcher `update_*` action). `requireApproval` uses the same two on its granted pass.
-- `sprigr-check-write-protection` (bin): every destructive-by-name tool or enumerated dispatcher action must carry a policy, or a reason in `apps/<app>/write-protection.json`; ratchets on `tools/write-protection-baseline.json`.
+- `sprigr-check-write-protection` (bin): every destructive-by-name tool or enumerated dispatcher action must carry a policy, or a reason in `apps/<app>/write-protection.json`; ratchets on `tools/write-protection-baseline.json`. It also refuses an `attended` key with any value other than `'approval_card'`, or on a rule that gates nothing (never baselined).
 
 **Never offer `_undo` for money or messages.** Refunds, captures, cancellations, sent mail: the approval gate is the only control there.

package/bin/check-write-protection.mjs

@@ -93,6 +93,33 @@ export function scanManifest(manifest) {
   return out;
 }
 
+/**
+ * Malformed `attended` keys (sprigr-team decision 0167), as `tool` or
+ * `tool:action` findings. Not baselined: no app may ship one.
+ *
+ * A manifest cannot say whether an approval card really covers the action,
+ * because the specs are code. That half is `checkConfirmationPolicy` /
+ * `attendedFindings` with `approvalCovered`, in the app's own test. What a
+ * manifest CAN show is a key the platform would ignore (any value but
+ * 'approval_card', so the person is quietly asked twice) and a key on a rule
+ * that gates nothing (so there is no confirmation for it to step aside from,
+ * which means it was written by hand).
+ */
+export function scanAttended(manifest) {
+  const out = [];
+  const check = (label, rule) => {
+    if (!rule || typeof rule !== 'object' || !('attended' in rule)) return;
+    if (rule.attended !== 'approval_card') out.push(`${label}: attended must be 'approval_card', got ${JSON.stringify(rule.attended)}`);
+    else if (!isGatedRule(rule)) out.push(`${label}: attended on a rule with no always or when, so it gates nothing`);
+  };
+  for (const tool of manifest.tools || []) {
+    if (!tool || !tool.confirmation || typeof tool.confirmation !== 'object') continue;
+    check(tool.name, tool.confirmation);
+    for (const [a, rule] of Object.entries(tool.confirmation.actions || {})) check(`${tool.name}:${a}`, rule);
+  }
+  return out;
+}
+
 /** Apply the app's allowlist. Returns { violations, stale, unreasoned }. */
 export function applyAllowlist(violations, allowlist) {
   const allow = (allowlist && allowlist.allow) || {};
@@ -151,6 +178,7 @@ export function run(argv, cwd = process.cwd()) {
     const allowlist = existsSync(allowPath) ? readJson(allowPath) : null;
     const raw = scanManifest(manifest);
     const { violations, stale, unreasoned } = applyAllowlist(raw, allowlist);
+    for (const f of scanAttended(manifest)) failures.push(`${slug}: ${f}`);
     for (const k of unreasoned) failures.push(`${slug}: write-protection.json allow entry "${k}" has no reason`);
     for (const k of stale) failures.push(`${slug}: write-protection.json allow entry "${k}" is stale (no longer destructive-and-ungated); remove it`);
 

package/dist/index.d.ts

@@ -1453,6 +1453,18 @@ interface ConfirmRule {
     describe?: string;
     /** Appends "which cannot be undone" so the model cannot undersell it. */
     irreversible?: boolean;
+    /**
+     * `'approval_card'`: this action's human-approval card (an approval spec)
+     * covers it whenever a person is on the turn, so the platform skips the
+     * confirmation there and the person is asked once, by the card. Unattended
+     * runs still confirm. Never hand-write it: pass `approval: { covered,
+     * conditional }` to `buildConfirmationPolicy` / `deriveConfirmationPolicy`
+     * so it follows the specs, and to `checkConfirmationPolicy` so a stale or
+     * conditionally gated key fails the test.
+     * Needs a platform with sprigr-team decision 0167; an older one ignores it
+     * and keeps asking twice.
+     */
+    attended?: 'approval_card';
 }
 interface ConfirmCondition {
     count: string;
@@ -2021,6 +2033,34 @@ interface PolicySource {
     always?: Record<string, string>;
     /** Full rules, for thresholds and anything the two maps above cannot express. */
     rules?: Record<string, ConfirmRule>;
+    /**
+     * Which actions an approval card covers; see {@link ApprovalCoverage}. Each
+     * covered action that also has a rule here, and is not `conditional`, gets
+     * `attended: 'approval_card'`, so the person is asked once on an attended
+     * turn (the card) instead of twice.
+     */
+    approval?: ApprovalCoverage;
+}
+/**
+ * Which actions an approval card covers, for deriving and checking
+ * `attended: 'approval_card'` (sprigr-team decision 0167).
+ *
+ * Both fields are required on purpose. The SDK can see an app's approval
+ * specs but not any condition the app wraps around the gate (simpro sends its
+ * deletes to the gate only with `force: true`), and an action marked attended
+ * whose call skips the card would skip the confirmation too: no prompt at all.
+ * So every app states its conditional actions, `[]` when it has none, and the
+ * builder and the check refuse to mark them.
+ */
+interface ApprovalCoverage {
+    /** Every action with an approval spec: the keys of the specs object you hand to the gate. */
+    covered: Iterable<string>;
+    /**
+     * Covered actions the app sends through the gate only under a condition of
+     * its own (simpro's `GATE_ONLY_WHEN`). Never marked attended; they keep the
+     * confirmation. Pass `[]` when every covered action always reaches the gate.
+     */
+    conditional: Iterable<string>;
 }
 /** Build a sorted `{ actions }` policy. An action named in two groups throws. */
 declare function buildConfirmationPolicy(src: PolicySource): ConfirmationPolicy;
@@ -2053,7 +2093,23 @@ interface PolicyCheckInput {
      */
     nestedUnderInput?: boolean;
     moneyFields?: readonly string[];
+    /**
+     * Which actions an approval card covers. With it, the check fails a rule
+     * carrying `attended: 'approval_card'` on an action no spec covers or that
+     * the app gates conditionally (either way the key removes the person's only
+     * prompt), a covered, unconditional, gated action that lacks the key (it asks
+     * twice), and a `conditional` entry with no spec. Without it, any `attended`
+     * key is itself a finding, because nothing can vouch for it.
+     */
+    approval?: ApprovalCoverage;
 }
+/**
+ * Findings for one rule's `attended` key against the approval coverage.
+ * Exported for apps whose gated tools are flat (`requireApproval`) rather than
+ * one dispatcher: run it over each tool-level rule with the tool names the
+ * specs cover and the ones gated conditionally.
+ */
+declare function attendedFindings(name: string, rule: ConfirmRule, coverage: ApprovalCoverage | null): string[];
 /**
  * Every way a policy can be wrong without erroring, as a list of findings.
  * An app's test is `expect(checkConfirmationPolicy(...)).toEqual([])`.
@@ -2233,6 +2289,8 @@ interface DerivePolicyOptions {
     exempt?: readonly string[];
     /** Explicit rules that win over the verb table (e.g. a hand-written describe). */
     overrides?: Readonly<Record<string, ConfirmRule>>;
+    /** Which actions an approval card covers; see `ApprovalCoverage`. */
+    approval?: ApprovalCoverage;
 }
 interface DerivedPolicy {
     policy: ConfirmationPolicy & {
@@ -3149,4 +3207,4 @@ interface ExecutionContextLike {
 }
 type HandlerFn<TArgs, TResult> = (args: TArgs, env: Record<string, unknown>, ctx?: ExecutionContextLike) => Promise<TResult>;
 
-export { ACTOR_RETIRED_HOOK_TOOL, ACTOR_RETIRE_REASONS, APPROVAL_GRANTED_KEY, APPROVAL_PREVIEW_MAX, APP_FILES_ROOT, APP_OWNER_SEGMENT, type Actor, type ActorRetireReason, type ActorRetired, type ActorRetiredHookBody, type ActorRetiredResult, type AppApprovalEnvelope, type AppFileListItem, type AppFileUrlArgs, type AppFileUrlResult, type AppFilesEnv, type AppToolEffectsDeclaration, type AppUndoEnvelope, type ApplyPoliciesOptions, type ApprovalGateOptions, type ApprovalSpec, type ArchiveOfferOptions, type ArchiveOfferRefusal, type CallerKeyResolution, type CaptureJournal, type ConfirmCondition, type ConfirmRule, type ConfirmationPolicy, type ConnectCompleteRequest, type ConnectCompleteResult, type D1Like, type D1PreparedStatementLike, DATA_PARTIAL_UPDATE_PATH, DEFAULT_EMIT_TIMEOUT_MS, DEFAULT_LOG_TIMEOUT_MS, DEFAULT_MAX_FILE_BYTES, DEFAULT_MONEY_FIELDS, DEFAULT_WRITE_PREFIXES, type DerivePolicyOptions, type DerivedPolicy, type DispatcherApprovalGate, type DispatcherApprovalOptions, type EmitMarketplaceEventOptions, type EmitResult, type EmitTransport, type EventArgs, type ExecutionContextLike, type FetchFileResult, type FetchWithRetryOptions, type GetAppFileResult, type HandlerFn, INBOX_SEND_CONTRACT_V1, type InboxAddress, type InboxAppendRequest, type InboxAppendResult, type InboxChannelDeclaration, type InboxFoldersRequest, type InboxFoldersResult, type InboxOwner, type InboxSendConnection, type InboxSendHandlerImpl, InboxSendRefusal, type InboxSendSupports, type InboxSendV1Args, type InboxSendV1Result, type InstallBridge, InvalidUndoEnvelopeError, type JournalRowLike, type LogToPlatformOptions, type ManifestDispatchBlock, type ManifestLike, type ManifestToolLike, type MarketplaceEventEmitOpts, type MarketplaceEventSourceIntegration, NotConnectedError, type OAuthBouncerSignals, type OAuthState, type OfferUndoArgs, type PartialUpdateDataOptions, type PlatformHostEnv, type PolicyCheckInput, type PolicySource, type PutAppFileArgs, type PutAppFileResult, type PutAppFileStreamArgs, type RequireApprovalOptions, type ResolveViewerOptions, type RestoreResult, type RestoreSpec, SPRIGR_DATA_MAX_OBJECTS_PER_CALL, SPRIGR_LOG_LEVELS, SPRIGR_LOG_LIMITS, type ScheduleArgs, type SprigrDataAggregationCell, type SprigrDataAggregationResult, type SprigrDataAggregationSpec, type SprigrDataApi, type SprigrDataImportOpts, type SprigrDataIndexOpts, type SprigrDataPartialUpdateBody, type SprigrDataPartialUpdateOpts, type SprigrDataPartialUpdateResult, type SprigrDataPatch, type SprigrDataSearchOpts, type SprigrDataSearchResult, SprigrDataValidationError, type SprigrFilesApi, type SprigrFilesApiWithEdit, type SprigrFilesCreateInput, type SprigrFilesCreateResult, type SprigrFilesEditInput, type SprigrFilesEditResult, type SprigrFilesJobResult, type SprigrFilesListItem, type SprigrFilesListResult, type SprigrInboxApi, type SprigrLogEntry, type SprigrLogFn, type SprigrLogLevel, type SprigrLogResult, SprigrLogValidationError, type SyncedAttachment, type SyncedMessage, type ToolArgs, type ToolHandler, type ToolResult, type ToolWrapperOptions, UNIT_SEP, type UndoApplyOptions, type UndoApplyResult, type UndoCaptureSpec, type UndoFidelity, VIEWER_ANONYMOUS, VIEWER_CONTEXT_HEADER, VIEWER_PLATFORM_USER_ID_HEADER, VIEWER_ROLE_HEADER, VIEWER_USER_ID_HEADER, type VerbRule, type ViewerContext, type ViewerContextFailure, type ViewerContextVerification, type ViewerEnv, type WebhookArgs, type WfpBridgeEnv, type WfpEmitReply, actorKey, actorRetiredHook, actorTool, agentFileKeyFromUrl, appFileUrl, appKeyFromCallerKey, applyConfirmationPolicies, approvalHash, approvalPreview, approvalRecipients, archiveOfferRefusal, base64ToBytes, buildConfirmationPolicy, buildMarketplaceWebhookUrl, buildPartialUpdateBody, bytesToBase64, callerKeyRefusal, canEmit, canLog, canPartialUpdate, checkConfirmationPolicy, commonDestructiveVerbs, connectComplete, connectDisconnect, constantTimeEqual, createMarketplaceEmitter, createToolWrappers, decodeState, defineInboxSendHandler, deleteAppFile, deriveConfirmationPolicy, describeMissingBridge, dispatcherApproval, emitMarketplaceEvent, encodeState, fetchFileAsBase64, fetchFileBytes, fetchWithRetry, fullWarning, getAppFile, hmacSha256Hex, installTokenPost, isNotConnectedError, isStagingHost, listAppFiles, logToPlatform, manifestIsFresh, offerUndo, overlaySprigr, ownerFromActorKey, parseActor, parseActorRetiredArgs, partialUpdateData, putAppFile, putAppFileStream, randomHex, readableStoredKey, recreatedWarning, refuseWithoutForce, requireApproval, resolveInstallBridge, resolveOAuthBouncerBase, resolveOAuthBouncerCallbackUrl, resolvePlatformWebhookBase, resolveViewerContext, resolveViewerUserId, runUndoApply, safeCapture, seq, serializeManifest, set, tool, undoEnvelope, validateLogEntries, validateLogEntry, verifyViewerToken, withSprigrEmitFallback, withSprigrInboxFallback, withSprigrLogFallback };
+export { ACTOR_RETIRED_HOOK_TOOL, ACTOR_RETIRE_REASONS, APPROVAL_GRANTED_KEY, APPROVAL_PREVIEW_MAX, APP_FILES_ROOT, APP_OWNER_SEGMENT, type Actor, type ActorRetireReason, type ActorRetired, type ActorRetiredHookBody, type ActorRetiredResult, type AppApprovalEnvelope, type AppFileListItem, type AppFileUrlArgs, type AppFileUrlResult, type AppFilesEnv, type AppToolEffectsDeclaration, type AppUndoEnvelope, type ApplyPoliciesOptions, type ApprovalCoverage, type ApprovalGateOptions, type ApprovalSpec, type ArchiveOfferOptions, type ArchiveOfferRefusal, type CallerKeyResolution, type CaptureJournal, type ConfirmCondition, type ConfirmRule, type ConfirmationPolicy, type ConnectCompleteRequest, type ConnectCompleteResult, type D1Like, type D1PreparedStatementLike, DATA_PARTIAL_UPDATE_PATH, DEFAULT_EMIT_TIMEOUT_MS, DEFAULT_LOG_TIMEOUT_MS, DEFAULT_MAX_FILE_BYTES, DEFAULT_MONEY_FIELDS, DEFAULT_WRITE_PREFIXES, type DerivePolicyOptions, type DerivedPolicy, type DispatcherApprovalGate, type DispatcherApprovalOptions, type EmitMarketplaceEventOptions, type EmitResult, type EmitTransport, type EventArgs, type ExecutionContextLike, type FetchFileResult, type FetchWithRetryOptions, type GetAppFileResult, type HandlerFn, INBOX_SEND_CONTRACT_V1, type InboxAddress, type InboxAppendRequest, type InboxAppendResult, type InboxChannelDeclaration, type InboxFoldersRequest, type InboxFoldersResult, type InboxOwner, type InboxSendConnection, type InboxSendHandlerImpl, InboxSendRefusal, type InboxSendSupports, type InboxSendV1Args, type InboxSendV1Result, type InstallBridge, InvalidUndoEnvelopeError, type JournalRowLike, type LogToPlatformOptions, type ManifestDispatchBlock, type ManifestLike, type ManifestToolLike, type MarketplaceEventEmitOpts, type MarketplaceEventSourceIntegration, NotConnectedError, type OAuthBouncerSignals, type OAuthState, type OfferUndoArgs, type PartialUpdateDataOptions, type PlatformHostEnv, type PolicyCheckInput, type PolicySource, type PutAppFileArgs, type PutAppFileResult, type PutAppFileStreamArgs, type RequireApprovalOptions, type ResolveViewerOptions, type RestoreResult, type RestoreSpec, SPRIGR_DATA_MAX_OBJECTS_PER_CALL, SPRIGR_LOG_LEVELS, SPRIGR_LOG_LIMITS, type ScheduleArgs, type SprigrDataAggregationCell, type SprigrDataAggregationResult, type SprigrDataAggregationSpec, type SprigrDataApi, type SprigrDataImportOpts, type SprigrDataIndexOpts, type SprigrDataPartialUpdateBody, type SprigrDataPartialUpdateOpts, type SprigrDataPartialUpdateResult, type SprigrDataPatch, type SprigrDataSearchOpts, type SprigrDataSearchResult, SprigrDataValidationError, type SprigrFilesApi, type SprigrFilesApiWithEdit, type SprigrFilesCreateInput, type SprigrFilesCreateResult, type SprigrFilesEditInput, type SprigrFilesEditResult, type SprigrFilesJobResult, type SprigrFilesListItem, type SprigrFilesListResult, type SprigrInboxApi, type SprigrLogEntry, type SprigrLogFn, type SprigrLogLevel, type SprigrLogResult, SprigrLogValidationError, type SyncedAttachment, type SyncedMessage, type ToolArgs, type ToolHandler, type ToolResult, type ToolWrapperOptions, UNIT_SEP, type UndoApplyOptions, type UndoApplyResult, type UndoCaptureSpec, type UndoFidelity, VIEWER_ANONYMOUS, VIEWER_CONTEXT_HEADER, VIEWER_PLATFORM_USER_ID_HEADER, VIEWER_ROLE_HEADER, VIEWER_USER_ID_HEADER, type VerbRule, type ViewerContext, type ViewerContextFailure, type ViewerContextVerification, type ViewerEnv, type WebhookArgs, type WfpBridgeEnv, type WfpEmitReply, actorKey, actorRetiredHook, actorTool, agentFileKeyFromUrl, appFileUrl, appKeyFromCallerKey, applyConfirmationPolicies, approvalHash, approvalPreview, approvalRecipients, archiveOfferRefusal, attendedFindings, base64ToBytes, buildConfirmationPolicy, buildMarketplaceWebhookUrl, buildPartialUpdateBody, bytesToBase64, callerKeyRefusal, canEmit, canLog, canPartialUpdate, checkConfirmationPolicy, commonDestructiveVerbs, connectComplete, connectDisconnect, constantTimeEqual, createMarketplaceEmitter, createToolWrappers, decodeState, defineInboxSendHandler, deleteAppFile, deriveConfirmationPolicy, describeMissingBridge, dispatcherApproval, emitMarketplaceEvent, encodeState, fetchFileAsBase64, fetchFileBytes, fetchWithRetry, fullWarning, getAppFile, hmacSha256Hex, installTokenPost, isNotConnectedError, isStagingHost, listAppFiles, logToPlatform, manifestIsFresh, offerUndo, overlaySprigr, ownerFromActorKey, parseActor, parseActorRetiredArgs, partialUpdateData, putAppFile, putAppFileStream, randomHex, readableStoredKey, recreatedWarning, refuseWithoutForce, requireApproval, resolveInstallBridge, resolveOAuthBouncerBase, resolveOAuthBouncerCallbackUrl, resolvePlatformWebhookBase, resolveViewerContext, resolveViewerUserId, runUndoApply, safeCapture, seq, serializeManifest, set, tool, undoEnvelope, validateLogEntries, validateLogEntry, verifyViewerToken, withSprigrEmitFallback, withSprigrInboxFallback, withSprigrLogFallback };

package/dist/index.js

@@ -1367,6 +1367,13 @@ async function runUndoApply(args, opts) {
 }
 
 // src/write-protection/confirmation-policy.ts
+function coverageSets(c) {
+  if (!c) return null;
+  if (c.covered == null || c.conditional == null) {
+    throw new Error("approval coverage needs both `covered` and `conditional` (pass [] when no action is gated conditionally)");
+  }
+  return { covered: new Set(c.covered), conditional: new Set(c.conditional) };
+}
 function buildConfirmationPolicy(src) {
   const actions = {};
   const put = (name, rule, group) => {
@@ -1376,6 +1383,10 @@ function buildConfirmationPolicy(src) {
   for (const [name, describe] of Object.entries(src.irreversible ?? {})) put(name, { always: true, describe, irreversible: true }, "irreversible");
   for (const [name, describe] of Object.entries(src.always ?? {})) put(name, { always: true, describe }, "always");
   for (const [name, rule] of Object.entries(src.rules ?? {})) put(name, rule, "rules");
+  const cov = coverageSets(src.approval);
+  for (const name of cov?.covered ?? []) {
+    if (actions[name] && !cov?.conditional.has(name)) actions[name] = { ...actions[name], attended: "approval_card" };
+  }
   return { actions: Object.fromEntries(Object.entries(actions).sort(([a], [b]) => a.localeCompare(b))) };
 }
 var DEFAULT_WRITE_PREFIXES = [
@@ -1479,6 +1490,22 @@ var PLACEHOLDER = /\{([a-zA-Z0-9_.]+)\}/g;
 function conditions(rule) {
   return !rule.when ? [] : Array.isArray(rule.when) ? rule.when : [rule.when];
 }
+function attendedFindings(name, rule, coverage) {
+  const cov = coverageSets(coverage ?? void 0);
+  const out = [];
+  const attended = rule.attended;
+  const gated = rule.always === true || conditions(rule).length > 0;
+  if (attended !== void 0 && attended !== "approval_card") {
+    out.push(`${name}: attended must be 'approval_card' (got ${JSON.stringify(attended)}); the platform ignores anything else`);
+  } else if (attended === "approval_card") {
+    if (!cov) out.push(`${name}: attended: 'approval_card' cannot be checked; pass approval: { covered, conditional }`);
+    else if (!cov.covered.has(name)) out.push(`${name}: attended: 'approval_card' but no approval spec covers it, so it removes the only prompt`);
+    else if (cov.conditional.has(name)) out.push(`${name}: attended: 'approval_card' on a conditionally gated action, so a call that skips the card gets no prompt at all`);
+  } else if (cov?.covered.has(name) && !cov.conditional.has(name) && gated) {
+    out.push(`${name}: an approval spec covers it but the rule lacks attended: 'approval_card', so it asks twice`);
+  }
+  return out;
+}
 function checkConfirmationPolicy(input) {
   const registry = new Set(input.registry);
   const ungated = input.ungated ?? [];
@@ -1486,8 +1513,13 @@ function checkConfirmationPolicy(input) {
   const nested = input.nestedUnderInput ?? true;
   const money = new Set(input.moneyFields ?? DEFAULT_MONEY_FIELDS);
   const actions = input.policy.actions ?? {};
+  const cov = coverageSets(input.approval);
   const out = [];
+  for (const name of cov?.conditional ?? []) {
+    if (!cov?.covered.has(name)) out.push(`approval.conditional: "${name}" has no approval spec (not in covered)`);
+  }
   for (const [name, rule] of Object.entries(actions)) {
+    out.push(...attendedFindings(name, rule, input.approval ?? null));
     if (!registry.has(name)) out.push(`dead rule: "${name}" is not in the registry, so it gates nothing`);
     if (!rule.always && conditions(rule).length === 0) out.push(`${name}: rule says nothing (no always, no when)`);
     if (!rule.describe || !rule.describe.trim()) out.push(`${name}: describe missing`);
@@ -1596,7 +1628,7 @@ function deriveConfirmationPolicy(registry, opts) {
     }
     if (!hit) unmatched.push(name);
   }
-  const policy = buildConfirmationPolicy({ irreversible, always, rules: overrides });
+  const policy = buildConfirmationPolicy({ irreversible, always, rules: overrides, approval: opts.approval });
   return { policy, ungated, unmatched };
 }
 function commonDestructiveVerbs(subject) {
@@ -1833,6 +1865,7 @@ export {
   approvalPreview,
   approvalRecipients,
   archiveOfferRefusal,
+  attendedFindings,
   base64ToBytes,
   buildConfirmationPolicy,
   buildMarketplaceWebhookUrl,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sprigr/apps-app-sdk",
-  "version": "0.19.0",
+  "version": "0.20.0",
   "type": "module",
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",