@spree/dashboard-core 0.13.1 → 1.0.0-beta.1

package/src/plugin.ts

@@ -31,6 +31,7 @@
 //       ],
 //     })
 
+import i18n from 'i18next'
 import type { CustomFieldComponent } from './lib/custom-field-components'
 import { customFieldComponents } from './lib/custom-field-components'
 import type { FormFieldRegistration } from './lib/form-fields-registry'
@@ -126,6 +127,21 @@ export interface DashboardPluginConfig {
    * custom-fields card renders it.
    */
   customFieldComponents?: Record<string, CustomFieldComponent>
+  /**
+   * Translations for the plugin's own copy, keyed by language tag:
+   *
+   *     locales: {
+   *       en: { admin: { types: { promotion_rule: { wishlist: { name: 'Wishlist' } } } } },
+   *       de: { admin: { types: { promotion_rule: { wishlist: { name: 'Wunschliste' } } } } },
+   *     }
+   *
+   * Merged into the base namespace, so a plugin adds keys without dropping
+   * the dashboard's own. This is where a gem that registers a Ruby rule,
+   * calculator or requirement kind puts the name merchants read: without it
+   * the dashboard falls back to the English label the API sends, which is
+   * resolved in the store's locale rather than the admin's.
+   */
+  locales?: Record<string, Record<string, unknown>>
 }
 
 /**
@@ -156,6 +172,19 @@ export function defineDashboardPlugin(config: DashboardPluginConfig): void {
     }
   }
 
+  // Before anything else: a nav entry or table column registered below may
+  // read a key this plugin ships.
+  if (config.locales) {
+    for (const [language, resources] of Object.entries(config.locales)) {
+      safely(
+        (lng: string, bundle: Record<string, unknown>) =>
+          i18n.addResourceBundle(lng, 'translation', bundle, true, true),
+        language,
+        resources,
+      )
+    }
+  }
+
   if (config.nav) {
     const m: NavMutations = Array.isArray(config.nav) ? { add: config.nav } : config.nav
     // add before addChildren so a plugin can add a parent then nest under it.

package/src/products/add-video-dialog.tsx

@@ -0,0 +1,100 @@
+import { isSupportedVideoUrl } from '@spree/dashboard-core'
+import {
+  Button,
+  Dialog,
+  DialogBody,
+  DialogContent,
+  DialogFooter,
+  DialogHeader,
+  DialogTitle,
+  Field,
+  FieldDescription,
+  FieldError,
+  FieldLabel,
+  Input,
+} from '@spree/dashboard-ui'
+import { type FormEvent, useState } from 'react'
+import { useTranslation } from 'react-i18next'
+
+interface Props {
+  open: boolean
+  onOpenChange: (open: boolean) => void
+  onAdd: (url: string) => void
+}
+
+// Collects a YouTube or Vimeo link. The same check runs again on the server,
+// so this is here to tell the merchant straight away rather than after a save.
+export function AddVideoDialog({ open, onOpenChange, onAdd }: Props) {
+  const { t } = useTranslation()
+  const [url, setUrl] = useState('')
+  const [touched, setTouched] = useState(false)
+
+  const invalid = touched && url.trim().length > 0 && !isSupportedVideoUrl(url)
+
+  const close = () => {
+    setUrl('')
+    setTouched(false)
+    onOpenChange(false)
+  }
+
+  // This dialog renders inside the product form, so the submit must be stopped
+  // here — letting it bubble would save the whole product.
+  const submit = (event: FormEvent<HTMLFormElement>) => {
+    event.preventDefault()
+    event.stopPropagation()
+    setTouched(true)
+    if (!isSupportedVideoUrl(url)) return
+    onAdd(url.trim())
+    close()
+  }
+
+  return (
+    <Dialog
+      open={open}
+      onOpenChange={(next) => {
+        if (!next) close()
+      }}
+    >
+      <DialogContent>
+        <DialogHeader>
+          <DialogTitle>{t('admin.products.media.add_video_title')}</DialogTitle>
+        </DialogHeader>
+
+        <form onSubmit={submit} className="contents">
+          <DialogBody>
+            <Field>
+              <FieldLabel htmlFor="external-video-url">
+                {t('admin.fields.media.external_video_url.label')}
+              </FieldLabel>
+              <Input
+                id="external-video-url"
+                value={url}
+                autoFocus
+                aria-invalid={invalid || undefined}
+                placeholder={t('admin.fields.media.external_video_url.placeholder')}
+                onChange={(e) => setUrl(e.target.value)}
+                onBlur={() => setTouched(true)}
+              />
+              {invalid ? (
+                <FieldError>{t('admin.products.media.video_url_invalid')}</FieldError>
+              ) : (
+                <FieldDescription>
+                  {t('admin.fields.media.external_video_url.help')}
+                </FieldDescription>
+              )}
+            </Field>
+          </DialogBody>
+
+          <DialogFooter>
+            <Button type="button" variant="outline" onClick={close}>
+              {t('admin.actions.cancel')}
+            </Button>
+            <Button type="submit" disabled={url.trim().length === 0}>
+              {t('admin.products.media.add_video_submit')}
+            </Button>
+          </DialogFooter>
+        </form>
+      </DialogContent>
+    </Dialog>
+  )
+}

package/src/products/bulk-variants-dialog.tsx

@@ -0,0 +1,301 @@
+import type { ProductFormValues, VariantFormValues } from '@spree/dashboard-core'
+import { useCountries, useCountryDisplayName } from '@spree/dashboard-core'
+import {
+  type BulkVariantsChange,
+  type BulkVariantsRow,
+  BulkVariantsTable,
+  Button,
+  Dialog,
+  DialogBody,
+  DialogContent,
+  DialogHeader,
+  DialogTitle,
+} from '@spree/dashboard-ui'
+import { useCallback, useEffect, useMemo, useRef } from 'react'
+import { type UseFormReturn, useWatch } from 'react-hook-form'
+import { useTranslation } from 'react-i18next'
+import { cartonSize } from './carton-size'
+import { normalizeCustomsDescription, normalizeHsCode } from './normalize-customs'
+import {
+  useFormCartonPackageTypes as useCartonPackageTypes,
+  useFormOptionTypes as useOptionTypes,
+  useFormTaxCategories as useTaxCategories,
+} from './use-product-form-data'
+import { composeOptionsText } from './variants-matrix'
+
+const WEIGHT_UNITS = ['g', 'kg', 'lb', 'oz'] as const
+const DIMENSION_UNITS = ['mm', 'cm', 'in'] as const
+
+interface Props {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  form: UseFormReturn<ProductFormValues, any, any>
+  open: boolean
+  onOpenChange: (open: boolean) => void
+}
+
+/**
+ * Full-page bulk variant editor: a spreadsheet of every per-variant field
+ * from the variant edit sheet (SKU, barcode, shipping measurements + units,
+ * availability, tax category) across all of a product's variants at once.
+ * Selection, copy/paste, and drag-fill come from the shared DataGrid.
+ *
+ * Form-backed like the edit sheet: cells read from and write to the parent
+ * product form's `variants[]`, so Done keeps the edits in form state (the
+ * product Save button commits them) and Cancel restores the snapshot taken
+ * when the dialog opened. Closing via Esc/overlay/X cancels, mirroring the
+ * sheet.
+ */
+export function BulkVariantsDialog({ form, open, onOpenChange }: Props) {
+  const { t } = useTranslation()
+  const variants = useWatch({ control: form.control, name: 'variants' }) ?? []
+  const { data: optionTypesData } = useOptionTypes()
+  const optionTypes = useMemo(() => optionTypesData?.data ?? [], [optionTypesData])
+  const { data: taxCategoriesResponse } = useTaxCategories()
+  const taxCategories = taxCategoriesResponse?.data ?? []
+  const { data: cartonTypesResponse } = useCartonPackageTypes()
+  const cartonTypes = cartonTypesResponse?.data ?? []
+  const { countries } = useCountries()
+  const countryName = useCountryDisplayName()
+
+  // ISO codes as values — customs data must survive the countries table, and
+  // a country record id would not.
+  const countryOptions = useMemo(
+    () =>
+      countries.map((country) => ({
+        value: country.iso,
+        label: countryName({ iso: country.iso, iso3: country.iso3, name: country.name }),
+      })),
+    [countries, countryName],
+  )
+
+  // Snapshot the variants when the dialog opens so Cancel can restore them.
+  // Deep-clone — `form.getValues` returns references into RHF's internal
+  // state, and cell edits mutate them in place (same trap the edit sheet
+  // documents).
+  const snapshotRef = useRef<VariantFormValues[] | null>(null)
+  useEffect(() => {
+    if (!open) return
+    snapshotRef.current = structuredClone(form.getValues('variants') ?? []) as VariantFormValues[]
+  }, [open, form])
+
+  const handleCancel = useCallback(() => {
+    const snapshot = snapshotRef.current
+    if (snapshot) {
+      // Restore element-by-element via resetField so each variant's dirty
+      // bit clears too (the edit sheet's Cancel does the same). The bulk
+      // editor never adds or removes rows, so indices are stable.
+      snapshot.forEach((value, index) => {
+        form.resetField(`variants.${index}`, { defaultValue: value })
+      })
+    }
+    snapshotRef.current = null
+    onOpenChange(false)
+  }, [form, onOpenChange])
+
+  const handleDone = useCallback(() => {
+    snapshotRef.current = null
+    onOpenChange(false)
+  }, [onOpenChange])
+
+  const rows = useMemo<BulkVariantsRow[]>(
+    () =>
+      variants.map((v, idx) => ({
+        id: `variant:${idx}`,
+        variantLabel: v.options.length > 0 ? composeOptionsText(v.options, optionTypes) : null,
+        sku: v.sku ?? null,
+        barcode: v.barcode ?? null,
+        weight: v.weight != null ? String(v.weight) : null,
+        weightUnit: v.weight_unit ?? null,
+        height: v.height != null ? String(v.height) : null,
+        width: v.width != null ? String(v.width) : null,
+        depth: v.depth != null ? String(v.depth) : null,
+        dimensionsUnit: v.dimensions_unit ?? null,
+        preorderable: !!v.preorderable,
+        backorderLimit: v.backorder_limit != null ? String(v.backorder_limit) : null,
+        taxCategoryId: v.tax_category_id ?? null,
+        hsCode: v.hs_code ?? null,
+        countryOfOrigin: v.country_of_origin ?? null,
+        customsDescription: v.customs_description ?? null,
+        unitsPerCarton: v.units_per_carton ?? null,
+        cartonPackageTypeId: v.carton_package_type_id ?? null,
+        cartonWeight: v.carton_weight != null ? String(v.carton_weight) : null,
+        cartonsPerPallet: v.cartons_per_pallet != null ? String(v.cartons_per_pallet) : null,
+      })),
+    [variants, optionTypes],
+  )
+
+  const handleChange = useCallback(
+    (rowId: string, change: BulkVariantsChange) => {
+      if (!rowId.startsWith('variant:')) return
+      const idx = Number.parseInt(rowId.slice('variant:'.length), 10)
+      if (Number.isNaN(idx)) return
+      const set = (path: Parameters<typeof form.setValue>[0], value: unknown) =>
+        form.setValue(path, value as never, { shouldDirty: true })
+
+      switch (change.field) {
+        case 'sku':
+          set(`variants.${idx}.sku`, change.value)
+          break
+        case 'barcode':
+          set(`variants.${idx}.barcode`, change.value)
+          break
+        case 'weightUnit':
+          set(`variants.${idx}.weight_unit`, change.value)
+          break
+        case 'dimensionsUnit':
+          set(`variants.${idx}.dimensions_unit`, change.value)
+          break
+        case 'taxCategoryId':
+          set(`variants.${idx}.tax_category_id`, change.value)
+          break
+        case 'hsCode':
+          set(`variants.${idx}.hs_code`, normalizeHsCode(change.value))
+          break
+        case 'countryOfOrigin':
+          // Already an ISO code — SelectCell resolves pasted country names
+          // against the option list before committing.
+          set(`variants.${idx}.country_of_origin`, change.value)
+          break
+        case 'customsDescription':
+          set(`variants.${idx}.customs_description`, normalizeCustomsDescription(change.value))
+          break
+        case 'cartonPackageTypeId':
+          set(`variants.${idx}.carton_package_type_id`, change.value)
+          break
+        // Counts are held as typed strings so an unusable entry can be
+        // reported rather than silently coerced away.
+        case 'unitsPerCarton':
+          set(`variants.${idx}.units_per_carton`, change.value)
+          break
+        case 'cartonsPerPallet':
+          set(`variants.${idx}.cartons_per_pallet`, change.value)
+          break
+        case 'cartonWeight': {
+          if (change.value == null || change.value.trim() === '') {
+            set(`variants.${idx}.carton_weight`, null)
+            break
+          }
+          const parsed = Number(change.value.trim().replace(',', '.'))
+          if (!Number.isFinite(parsed) || parsed < 0) break
+          set(`variants.${idx}.carton_weight`, parsed)
+          break
+        }
+        case 'preorderable':
+          set(`variants.${idx}.preorderable`, change.value)
+          break
+        case 'backorderLimit': {
+          if (change.value == null || change.value.trim() === '') {
+            set(`variants.${idx}.backorder_limit`, null)
+            break
+          }
+          const parsed = Number(change.value.trim().replace(',', '.'))
+          if (!Number.isFinite(parsed) || parsed < 0) break
+          set(`variants.${idx}.backorder_limit`, Math.trunc(parsed))
+          break
+        }
+        default: {
+          // weight / height / width / depth — decimals. Accept a comma
+          // decimal (the cell ships raw input); ignore anything that doesn't
+          // parse to a non-negative number rather than mangling it.
+          if (change.value == null || change.value.trim() === '') {
+            set(`variants.${idx}.${change.field}`, null)
+            break
+          }
+          const parsed = Number(change.value.trim().replace(',', '.'))
+          if (!Number.isFinite(parsed) || parsed < 0) break
+          set(`variants.${idx}.${change.field}`, parsed)
+          break
+        }
+      }
+    },
+    [form],
+  )
+
+  const unitOptions = (units: readonly string[]) => units.map((u) => ({ value: u, label: u }))
+
+  return (
+    <Dialog open={open} onOpenChange={(next) => (next ? onOpenChange(true) : handleCancel())} modal>
+      <DialogContent
+        // Edge-to-edge minus a 3-unit gutter, same overrides as the bulk
+        // price dialog (see BulkPriceEditorDialog for why each is needed).
+        className="!inset-3 !w-auto !max-w-none !translate-x-0 !translate-y-0 flex flex-col p-0"
+        style={{ maxHeight: 'none' }}
+        showCloseButton={false}
+      >
+        <DialogHeader className="flex flex-row items-center justify-between gap-3 space-y-0 border-b p-3">
+          <DialogTitle className="truncate">
+            {t('admin.products.variants.bulk_edit.title')}
+          </DialogTitle>
+          <div className="flex items-center gap-2">
+            <Button type="button" size="sm" variant="outline" onClick={handleCancel}>
+              {t('admin.actions.cancel')}
+            </Button>
+            <Button type="button" size="sm" onClick={handleDone}>
+              {t('admin.actions.done')}
+            </Button>
+          </div>
+        </DialogHeader>
+        {/* No gutter: the body holds nothing but the grid, so padding only
+            narrows the space the columns have to fit in and leaves the
+            table's own border floating inside the dialog's.
+
+            `DialogBody` already scrolls on y and bounds its own height, so
+            the grid inside it has something to size against and stays the one
+            element that scrolls sideways. Do not add an overflow utility
+            here: the base class sets the `overflow-y` longhand, which a bare
+            `overflow-hidden` does not override at equal specificity. */}
+        <DialogBody className="min-h-0 flex-1 p-0">
+          <BulkVariantsTable
+            rows={rows}
+            onChange={handleChange}
+            weightUnitOptions={unitOptions(WEIGHT_UNITS)}
+            dimensionUnitOptions={unitOptions(DIMENSION_UNITS)}
+            taxCategoryOptions={
+              taxCategories.length > 0
+                ? taxCategories.map((c) => ({ value: c.id, label: c.name }))
+                : undefined
+            }
+            countryOptions={countryOptions.length > 0 ? countryOptions : undefined}
+            cartonOptions={
+              cartonTypes.length > 0
+                ? cartonTypes.map((carton) => ({
+                    value: carton.id,
+                    // The name stays the label: a pasted column matches on it.
+                    label: carton.name,
+                    hint: cartonSize(carton) ?? undefined,
+                  }))
+                : undefined
+            }
+            labels={{
+              variant: t('admin.pages.products.price_lists.edit_prices.columns.variant'),
+              sku: t('admin.fields.variant.sku.label'),
+              barcode: t('admin.fields.variant.barcode.label'),
+              weight: t('admin.fields.variant.weight.label'),
+              weightUnit: t('admin.fields.variant.weight_unit.label'),
+              height: t('admin.fields.variant.height.label'),
+              width: t('admin.fields.variant.width.label'),
+              depth: t('admin.fields.variant.depth.label'),
+              dimensionsUnit: t('admin.fields.variant.dimensions_unit.label'),
+              preorderable: t('admin.fields.variant.preorderable.label'),
+              backorderLimit: t('admin.fields.variant.backorder_limit.label'),
+              taxCategory: t('admin.fields.tax_category_id.label'),
+              hsCode: t('admin.fields.variant.hs_code.label'),
+              countryOfOrigin: t('admin.fields.variant.country_of_origin.label'),
+              customsDescription: t('admin.fields.variant.customs_description.label'),
+              unitsPerCarton: t('admin.fields.variant.units_per_carton.label'),
+              cartonPackageType: t('admin.fields.variant.carton_package_type_id.label'),
+              cartonWeight: t('admin.fields.variant.carton_weight.label'),
+              cartonsPerPallet: t('admin.fields.variant.cartons_per_pallet.label'),
+              variantDefault: t('admin.products.variants.default_variant'),
+              unitDefault: t('admin.products.variants.bulk_edit.unset'),
+              taxCategoryNone: t('admin.products.variants.sheet.tax_category_placeholder'),
+              countryOfOriginNone: t('admin.products.variants.bulk_edit.unset'),
+              cartonPackageTypeNone: t('admin.products.variants.bulk_edit.unset'),
+              gridAriaLabel: t('admin.products.variants.bulk_edit.grid_aria'),
+            }}
+          />
+        </DialogBody>
+      </DialogContent>
+    </Dialog>
+  )
+}

package/src/products/carton-size.test.ts

@@ -0,0 +1,51 @@
+import { describe, expect, it } from 'vitest'
+import { cartonSize } from './carton-size'
+
+describe('cartonSize', () => {
+  it('reads back the way a merchant would write it', () => {
+    expect(
+      cartonSize({
+        id: '1',
+        name: 'Large',
+        length: '60.0',
+        width: '40.0',
+        height: '40.0',
+        dimensions_unit: 'cm',
+      }),
+    ).toBe('60 × 40 × 40 cm')
+  })
+
+  it('keeps a real decimal', () => {
+    expect(
+      cartonSize({
+        id: '1',
+        name: 'Small',
+        length: '12.5',
+        width: '9.0',
+        height: '4.25',
+        dimensions_unit: 'in',
+      }),
+    ).toBe('12.5 × 9 × 4.25 in')
+  })
+
+  // Half a box is not a size — better to say nothing than "60 × × cm".
+  it('says nothing when a measurement is missing', () => {
+    expect(
+      cartonSize({
+        id: '1',
+        name: 'Partial',
+        length: '60.0',
+        width: null,
+        height: '40.0',
+        dimensions_unit: 'cm',
+      }),
+    ).toBeNull()
+    expect(cartonSize({ id: '1', name: 'Bare' })).toBeNull()
+  })
+
+  it('omits an absent unit rather than trailing a space', () => {
+    expect(cartonSize({ id: '1', name: 'Unitless', length: '10', width: '10', height: '10' })).toBe(
+      '10 × 10 × 10',
+    )
+  })
+})

package/src/products/carton-size.ts

@@ -0,0 +1,20 @@
+import type { PanelPackageType } from '../api-client'
+
+/**
+ * A carton's size, as the merchant recorded it — for telling two similarly
+ * named cartons apart wherever one is chosen.
+ *
+ * Null unless all three measurements are there: half a box is not a size. The
+ * unit travels with the numbers because the same three read as inches rather
+ * than centimeters describe a box sixteen times the volume.
+ */
+export function cartonSize(carton: PanelPackageType): string | null {
+  const { length, width, height, dimensions_unit } = carton
+  if (length == null || width == null || height == null) return null
+
+  // Decimals arrive as strings, so `60.0` would read back as a precision the
+  // merchant never typed.
+  const trim = (value: string) => String(Number(value))
+
+  return `${trim(length)} × ${trim(width)} × ${trim(height)} ${dimensions_unit ?? ''}`.trim()
+}

package/src/products/currency-parts.ts

@@ -0,0 +1,21 @@
+// Resolve a currency code into its symbol + decimal separator under the
+// current locale, with a safe fallback for unknown/invalid currencies.
+// Shared between the server-backed BulkPriceEditor and the form-backed
+// ProductBulkPriceEditor.
+export function currencyParts(
+  currencyCode: string,
+  locale: string,
+): { symbol: string; decimal: string } {
+  try {
+    const parts = new Intl.NumberFormat(locale, {
+      style: 'currency',
+      currency: currencyCode,
+    }).formatToParts(1234.56)
+    return {
+      symbol: parts.find((p) => p.type === 'currency')?.value ?? currencyCode,
+      decimal: parts.find((p) => p.type === 'decimal')?.value ?? '.',
+    }
+  } catch {
+    return { symbol: currencyCode, decimal: '.' }
+  }
+}