@sports-alliance/sports-lib 6.1.12 → 6.1.14

package/lib/cjs/activities/activity.js

@@ -41,7 +41,8 @@ class Activity extends duration_class_abstract_1.DurationClassAbstract {
         this.name = name;
     }
     createStream(type) {
-        return new stream_1.Stream(type, Array(activity_utilities_1.ActivityUtilities.getDataLength(this.startDate, this.endDate)).fill(null));
+        const stream = new stream_1.Stream(type, Array(activity_utilities_1.ActivityUtilities.getDataLength(this.startDate, this.endDate)).fill(null));
+        return stream;
     }
     addDataToStream(type, date, value) {
         this.getStreamData(type)[this.getDateIndex(date)] = value;
@@ -49,7 +50,7 @@ class Activity extends duration_class_abstract_1.DurationClassAbstract {
     }
     addStream(stream) {
         if (this.streams.find(activityStream => activityStream.type === stream.type)) {
-            throw new Error(`Duplicate type of stream when adding ${stream.type} to activity ${this.getID()}`);
+            throw new Error(`Duplicate type of stream when adding ${stream.type} to activity ${this.getID()} `);
         }
         this.streams.push(stream);
         return this;
@@ -101,7 +102,7 @@ class Activity extends duration_class_abstract_1.DurationClassAbstract {
     getStream(streamType) {
         const find = this.streams.find(stream => stream.type === streamType);
         if (!find) {
-            throw Error(`No stream found with type ${streamType}`);
+            throw Error(`No stream found with type ${streamType} `);
         }
         return find;
     }

package/lib/cjs/events/adapters/importers/fit/importer.fit.d.ts

@@ -13,6 +13,7 @@ export declare class EventImporterFIT {
      * Generate streams samples based on lengths on an activity
      * When based on lengths, an activity do not provides sample under records object
      * @param sessionObject
+     * @param options
      * @private
      */
     private static generateSamplesFromLengths;

package/lib/cjs/events/adapters/importers/fit/importer.fit.js

@@ -272,7 +272,7 @@ class EventImporterFIT {
                         // Note: this is how Strava generate streams for this kind of activities
                         const isLengthsBased = this.isLengthsBased(sessionObject);
                         const samples = isLengthsBased
-                            ? this.generateSamplesFromLengths(sessionObject)
+                            ? this.generateSamplesFromLengths(sessionObject, options)
                             : fitDataObject.records.filter((record) => {
                                 return record.timestamp >= activity.startDate && record.timestamp <= activity.endDate;
                             });
@@ -351,9 +351,10 @@ class EventImporterFIT {
      * Generate streams samples based on lengths on an activity
      * When based on lengths, an activity do not provides sample under records object
      * @param sessionObject
+     * @param options
      * @private
      */
-    static generateSamplesFromLengths(sessionObject) {
+    static generateSamplesFromLengths(sessionObject, options) {
         if (!this.isLengthsBased(sessionObject)) {
             throw new parsing_event_lib_error_1.ParsingEventLibError('Trying to get samples from activities lengths, but no lengths is available');
         }
@@ -370,12 +371,18 @@ class EventImporterFIT {
                 lap.lengths.forEach((length) => {
                     // Resolve start/end date of current length
                     const lengthStartDate = length.start_time;
-                    const lengthEndDate = new Date(lengthStartDate.getTime() + (length.total_timer_time || length.total_elapsed_time || 0) * 1000);
+                    const lengthDuration = (length.total_timer_time || length.total_elapsed_time || 0);
+                    const lengthEndDate = new Date(lengthStartDate.getTime() + lengthDuration * 1000);
+                    // We check if length is valid comparing to max activity duration
+                    if (lengthDuration > options.maxActivityDurationDays * 24 * 60 * 60) {
+                        return;
+                    }
                     if (lengthEndDate.getTime() <= lengthStartDate.getTime()) {
                         return;
                     }
                     // Generate a stream from length start date to end date filled by null values
-                    let lengthStream = Array(activity_utilities_1.ActivityUtilities.getDataLength(lengthStartDate, lengthEndDate)).fill(null);
+                    const streamLength = activity_utilities_1.ActivityUtilities.getDataLength(lengthStartDate, lengthEndDate);
+                    let lengthStream = Array(streamLength).fill(null);
                     // Define distance step to be used for distance stream
                     const lengthStepSize = lengthMeters / (lengthStream.length - 1);
                     // Generate the length stream based on data we have on current length

package/lib/cjs/events/adapters/importers/fit/importer.fit.oom.spec.d.ts

@@ -0,0 +1 @@
+export {};

package/lib/cjs/events/adapters/importers/fit/importer.fit.oom.spec.js

@@ -0,0 +1,60 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    Object.defineProperty(o, k2, { enumerable: true, get: function() { return m[k]; } });
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || function (mod) {
+    if (mod && mod.__esModule) return mod;
+    var result = {};
+    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
+    __setModuleDefault(result, mod);
+    return result;
+};
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+const fs = __importStar(require("fs"));
+const path = __importStar(require("path"));
+const importer_fit_1 = require("./importer.fit");
+describe('EventImporterFIT OOM Reproduction', () => {
+    const oomSamplesDir = path.resolve(__dirname, '../../../../../samples/fit/oom');
+    it('should parse OOM sample fit files', () => __awaiter(void 0, void 0, void 0, function* () {
+        if (!fs.existsSync(oomSamplesDir)) {
+            console.warn(`OOM Samples directory not found at ${oomSamplesDir}. Skipping reproduction.`);
+            return;
+        }
+        const files = fs.readdirSync(oomSamplesDir).filter(f => f.endsWith('.fit'));
+        for (const file of files) {
+            console.log(`>>> START Processing ${file}`);
+            const filePath = path.join(oomSamplesDir, file);
+            const fileBuffer = fs.readFileSync(filePath);
+            const arrayBuffer = fileBuffer.buffer.slice(fileBuffer.byteOffset, fileBuffer.byteOffset + fileBuffer.byteLength);
+            console.log(`Testing file: ${file} (${fileBuffer.length} bytes)`);
+            try {
+                const event = yield importer_fit_1.EventImporterFIT.getFromArrayBuffer(arrayBuffer, undefined, file);
+                expect(event).toBeDefined();
+                console.log(`✅ Successfully parsed ${file}`);
+            }
+            catch (error) {
+                console.error(`❌ Failed to parse ${file}:`, error);
+                // We don't necessarily want to throw here if we want to test all files
+            }
+            console.log(`<<< END Processing ${file}`);
+        }
+    }), 100000); // 100s timeout as these might take time if they are huge
+});

package/lib/cjs/events/adapters/importers/suunto/importer.suunto.json.js

@@ -153,7 +153,7 @@ class EventImporterSuuntoJSON {
             // Create the activities
             const activities = activityStartEventSamples.map((activityStartEventSample, index) => {
                 const activity = new activity_1.Activity(new Date(activityStartEventSample.TimeISO8601), activityStartEventSamples.length - 1 === index
-                    ? new Date(stopEventSample ? stopEventSample.TimeISO8601 : eventJSONObject.DeviceLog.Header.TimeISO8601)
+                    ? new Date(stopEventSample ? stopEventSample.TimeISO8601 : (eventJSONObject.DeviceLog.Header.TimeISO8601 || eventJSONObject.DeviceLog.Header.DateTime))
                     : new Date(activityStartEventSamples[index + 1].TimeISO8601), activity_types_1.ActivityTypes[(importer_suunto_activity_ids_1.ImporterSuuntoActivityIds[activityStartEventSample.Events[0].Activity.ActivityType])], creator, options);
                 // Set the end date to the stop event time if the activity is the last or the only one else set it on the next itery time
                 // Create the stats these are a 1:1 ref arrays

package/lib/esm/activities/activity.js

@@ -38,7 +38,8 @@ export class Activity extends DurationClassAbstract {
         this.name = name;
     }
     createStream(type) {
-        return new Stream(type, Array(ActivityUtilities.getDataLength(this.startDate, this.endDate)).fill(null));
+        const stream = new Stream(type, Array(ActivityUtilities.getDataLength(this.startDate, this.endDate)).fill(null));
+        return stream;
     }
     addDataToStream(type, date, value) {
         this.getStreamData(type)[this.getDateIndex(date)] = value;
@@ -46,7 +47,7 @@ export class Activity extends DurationClassAbstract {
     }
     addStream(stream) {
         if (this.streams.find(activityStream => activityStream.type === stream.type)) {
-            throw new Error(`Duplicate type of stream when adding ${stream.type} to activity ${this.getID()}`);
+            throw new Error(`Duplicate type of stream when adding ${stream.type} to activity ${this.getID()} `);
         }
         this.streams.push(stream);
         return this;
@@ -98,7 +99,7 @@ export class Activity extends DurationClassAbstract {
     getStream(streamType) {
         const find = this.streams.find(stream => stream.type === streamType);
         if (!find) {
-            throw Error(`No stream found with type ${streamType}`);
+            throw Error(`No stream found with type ${streamType} `);
         }
         return find;
     }

package/lib/esm/events/adapters/importers/fit/importer.fit.d.ts

@@ -13,6 +13,7 @@ export declare class EventImporterFIT {
      * Generate streams samples based on lengths on an activity
      * When based on lengths, an activity do not provides sample under records object
      * @param sessionObject
+     * @param options
      * @private
      */
     private static generateSamplesFromLengths;

package/lib/esm/events/adapters/importers/fit/importer.fit.js

@@ -266,7 +266,7 @@ export class EventImporterFIT {
                         // Note: this is how Strava generate streams for this kind of activities
                         const isLengthsBased = this.isLengthsBased(sessionObject);
                         const samples = isLengthsBased
-                            ? this.generateSamplesFromLengths(sessionObject)
+                            ? this.generateSamplesFromLengths(sessionObject, options)
                             : fitDataObject.records.filter((record) => {
                                 return record.timestamp >= activity.startDate && record.timestamp <= activity.endDate;
                             });
@@ -345,9 +345,10 @@ export class EventImporterFIT {
      * Generate streams samples based on lengths on an activity
      * When based on lengths, an activity do not provides sample under records object
      * @param sessionObject
+     * @param options
      * @private
      */
-    static generateSamplesFromLengths(sessionObject) {
+    static generateSamplesFromLengths(sessionObject, options) {
         if (!this.isLengthsBased(sessionObject)) {
             throw new ParsingEventLibError('Trying to get samples from activities lengths, but no lengths is available');
         }
@@ -364,12 +365,18 @@ export class EventImporterFIT {
                 lap.lengths.forEach((length) => {
                     // Resolve start/end date of current length
                     const lengthStartDate = length.start_time;
-                    const lengthEndDate = new Date(lengthStartDate.getTime() + (length.total_timer_time || length.total_elapsed_time || 0) * 1000);
+                    const lengthDuration = (length.total_timer_time || length.total_elapsed_time || 0);
+                    const lengthEndDate = new Date(lengthStartDate.getTime() + lengthDuration * 1000);
+                    // We check if length is valid comparing to max activity duration
+                    if (lengthDuration > options.maxActivityDurationDays * 24 * 60 * 60) {
+                        return;
+                    }
                     if (lengthEndDate.getTime() <= lengthStartDate.getTime()) {
                         return;
                     }
                     // Generate a stream from length start date to end date filled by null values
-                    let lengthStream = Array(ActivityUtilities.getDataLength(lengthStartDate, lengthEndDate)).fill(null);
+                    const streamLength = ActivityUtilities.getDataLength(lengthStartDate, lengthEndDate);
+                    let lengthStream = Array(streamLength).fill(null);
                     // Define distance step to be used for distance stream
                     const lengthStepSize = lengthMeters / (lengthStream.length - 1);
                     // Generate the length stream based on data we have on current length

package/lib/esm/events/adapters/importers/fit/importer.fit.oom.spec.d.ts

@@ -0,0 +1 @@
+export {};

package/lib/esm/events/adapters/importers/fit/importer.fit.oom.spec.js

@@ -0,0 +1,39 @@
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+import * as fs from 'fs';
+import * as path from 'path';
+import { EventImporterFIT } from './importer.fit';
+describe('EventImporterFIT OOM Reproduction', () => {
+    const oomSamplesDir = path.resolve(__dirname, '../../../../../samples/fit/oom');
+    it('should parse OOM sample fit files', () => __awaiter(void 0, void 0, void 0, function* () {
+        if (!fs.existsSync(oomSamplesDir)) {
+            console.warn(`OOM Samples directory not found at ${oomSamplesDir}. Skipping reproduction.`);
+            return;
+        }
+        const files = fs.readdirSync(oomSamplesDir).filter(f => f.endsWith('.fit'));
+        for (const file of files) {
+            console.log(`>>> START Processing ${file}`);
+            const filePath = path.join(oomSamplesDir, file);
+            const fileBuffer = fs.readFileSync(filePath);
+            const arrayBuffer = fileBuffer.buffer.slice(fileBuffer.byteOffset, fileBuffer.byteOffset + fileBuffer.byteLength);
+            console.log(`Testing file: ${file} (${fileBuffer.length} bytes)`);
+            try {
+                const event = yield EventImporterFIT.getFromArrayBuffer(arrayBuffer, undefined, file);
+                expect(event).toBeDefined();
+                console.log(`✅ Successfully parsed ${file}`);
+            }
+            catch (error) {
+                console.error(`❌ Failed to parse ${file}:`, error);
+                // We don't necessarily want to throw here if we want to test all files
+            }
+            console.log(`<<< END Processing ${file}`);
+        }
+    }), 100000); // 100s timeout as these might take time if they are huge
+});

package/lib/esm/events/adapters/importers/suunto/importer.suunto.json.js

@@ -150,7 +150,7 @@ export class EventImporterSuuntoJSON {
             // Create the activities
             const activities = activityStartEventSamples.map((activityStartEventSample, index) => {
                 const activity = new Activity(new Date(activityStartEventSample.TimeISO8601), activityStartEventSamples.length - 1 === index
-                    ? new Date(stopEventSample ? stopEventSample.TimeISO8601 : eventJSONObject.DeviceLog.Header.TimeISO8601)
+                    ? new Date(stopEventSample ? stopEventSample.TimeISO8601 : (eventJSONObject.DeviceLog.Header.TimeISO8601 || eventJSONObject.DeviceLog.Header.DateTime))
                     : new Date(activityStartEventSamples[index + 1].TimeISO8601), ActivityTypes[(ImporterSuuntoActivityIds[activityStartEventSample.Events[0].Activity.ActivityType])], creator, options);
                 // Set the end date to the stop event time if the activity is the last or the only one else set it on the next itery time
                 // Create the stats these are a 1:1 ref arrays

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sports-alliance/sports-lib",
-  "version": "6.1.12",
+  "version": "6.1.14",
   "description": "A Library to for importing / exporting and processing GPX, TCX, FIT and JSON files from services such as Strava, Movescount, Garmin, Polar etc",
   "keywords": [
     "gpx",

package/reproduce_oom.ts

@@ -0,0 +1,35 @@
+import * as fs from 'fs';
+import * as path from 'path';
+import { EventImporterFIT } from './src/events/adapters/importers/fit/importer.fit';
+
+async function reproduce() {
+    const oomSamplesDir = path.resolve(__dirname, 'samples/fit/oom');
+
+    if (!fs.existsSync(oomSamplesDir)) {
+        console.warn(`OOM Samples directory not found at ${oomSamplesDir}.`);
+        return;
+    }
+
+    const files = fs.readdirSync(oomSamplesDir).filter(f => f.endsWith('.fit'));
+
+    for (const file of files) {
+        process.stdout.write(`>>> START Processing ${file}\n`);
+        const filePath = path.join(oomSamplesDir, file);
+        const fileBuffer = fs.readFileSync(filePath);
+        const arrayBuffer = fileBuffer.buffer.slice(fileBuffer.byteOffset, fileBuffer.byteOffset + fileBuffer.byteLength);
+
+        console.log(`Testing file: ${file} (${fileBuffer.length} bytes)`);
+        try {
+            const event = await EventImporterFIT.getFromArrayBuffer(arrayBuffer, undefined, file);
+            console.log(`✅ Successfully parsed ${file}`);
+        } catch (error) {
+            console.error(`❌ Failed to parse ${file}:`, error);
+        }
+        process.stdout.write(`<<< END Processing ${file}\n`);
+    }
+}
+
+reproduce().catch(err => {
+    console.error('FATAL ERROR:', err);
+    process.exit(1);
+});