@spooky-sync/core 0.0.1-canary.362 → 0.0.1-canary.364

package/dist/index.js

@@ -3650,8 +3650,8 @@ function trimHistory(history, cap) {
 
 //#endregion
 //#region src/modules/devtools/index.ts
-const CORE_VERSION = "0.0.1-canary.362";
-const WASM_VERSION = "0.0.1-canary.362";
+const CORE_VERSION = "0.0.1-canary.364";
+const WASM_VERSION = "0.0.1-canary.364";
 const SURREAL_VERSION = "3.1.0";
 var DevToolsService = class DevToolsService {
 	version = CORE_VERSION;
@@ -14018,7 +14018,7 @@ var AuthService = class {
 		const info = this.impersonation;
 		if (!info) return;
 		if (!opts.serverEnded) try {
-			await this.remote.query("RETURN fn::_00_impersonate::stop($session)", { session: info.session });
+			await this.remote.query("RETURN fn::_00_impersonate::stop($sid)", { sid: info.session });
 		} catch (error) {
 			this.logger.warn({
 				error,
@@ -14228,7 +14228,7 @@ var AuthService = class {
 		if (impersonating) {
 			this.endedImpersonationTarget = impersonating.target;
 			try {
-				await this.remote.query("RETURN fn::_00_impersonate::stop($session)", { session: impersonating.session });
+				await this.remote.query("RETURN fn::_00_impersonate::stop($sid)", { sid: impersonating.session });
 			} catch (_e) {}
 		}
 		await this.persistenceClient.remove(ORIGIN_TOKEN_KEY);
@@ -17609,7 +17609,7 @@ function createTabsCoordinator(config, s, host) {
 	return new TabsCoordinator({
 		tabId: s.tabId,
 		fingerprint: computeTabsFingerprint({
-			coreVersion: "0.0.1-canary.362",
+			coreVersion: "0.0.1-canary.364",
 			schemaHash: hash53(config.schemaSurql),
 			endpoint: config.database.endpoint ?? "",
 			namespace: config.database.namespace,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@spooky-sync/core",
-  "version": "0.0.1-canary.362",
+  "version": "0.0.1-canary.364",
   "type": "module",
   "sideEffects": false,
   "main": "./dist/index.js",
@@ -75,8 +75,8 @@
     }
   },
   "dependencies": {
-    "@spooky-sync/query-builder": "0.0.1-canary.362",
-    "@spooky-sync/ssp-wasm": "0.0.1-canary.362",
+    "@spooky-sync/query-builder": "0.0.1-canary.364",
+    "@spooky-sync/ssp-wasm": "0.0.1-canary.364",
     "@sqlite.org/sqlite-wasm": "3.53.0-build1",
     "@surrealdb/wasm": "^3.1.0",
     "@surrealdb/wasm-native": "^3.3.4",

package/src/modules/auth/impersonation.integration.test.ts

@@ -64,8 +64,8 @@ DEFINE FUNCTION fn::_00_impersonate::start($target: string, $reason: string) {
   UPSERT _00_impersonation:s1 SET target = type::record($target), admin = $auth.id, reason = $reason, ended_at = NONE;
   RETURN { token: $test_imp_token, session: '_00_impersonation:s1' };
 } PERMISSIONS FULL;
-DEFINE FUNCTION fn::_00_impersonate::stop($session: string) {
-  UPDATE type::record($session) SET ended_at = time::now();
+DEFINE FUNCTION fn::_00_impersonate::stop($session_id: string) {
+  UPDATE type::record($session_id) SET ended_at = time::now();
   RETURN NONE;
 } PERMISSIONS FULL;
 DEFINE FUNCTION fn::_00_impersonate::renew() {
@@ -149,6 +149,10 @@ describe('impersonation on the SurrealDB-WASM engine', () => {
     expect(String(auth.currentUser.id)).toBe('user:alice');
     expect(store.get('sp00ky_auth_token')).toBe(adminToken);
     expect(store.has(ORIGIN_TOKEN_KEY)).toBe(false);
+    // The server session ended too. Binding the id as `session` (a protected
+    // variable) failed silently here, and only the token's expiry ended it.
+    const [ended] = await db.query<[unknown]>('SELECT VALUE ended_at FROM ONLY _00_impersonation:s1');
+    expect(ended).toBeTruthy();
   });
 
   it('an explicit stop racing a server-ended stop still returns to the admin', async () => {

package/src/modules/auth/impersonation.test.ts

@@ -49,7 +49,7 @@ function makeServer(opts: { refuse?: Set<string>; unreachable?: boolean } = {})
     }
     if (sql.includes('fn::_00_impersonate::current')) return [state.ended ? null : { session: '_00_impersonation:s1' }];
     if (sql.includes('fn::_00_impersonate::stop')) {
-      state.stops.push(vars?.session);
+      state.stops.push(vars?.sid);
       state.ended = true;
       return [null];
     }

package/src/modules/auth/index.ts

@@ -382,7 +382,7 @@ export class AuthService<S extends SchemaStructure> {
     if (!info) return;
     if (!opts.serverEnded) {
       try {
-        await this.remote.query('RETURN fn::_00_impersonate::stop($session)', { session: info.session });
+        await this.remote.query('RETURN fn::_00_impersonate::stop($sid)', { sid: info.session });
       } catch (error) {
         // The token expires on its own; the local switch below is what matters.
         this.logger.warn(
@@ -659,8 +659,8 @@ export class AuthService<S extends SchemaStructure> {
     if (impersonating) {
       this.endedImpersonationTarget = impersonating.target;
       try {
-        await this.remote.query('RETURN fn::_00_impersonate::stop($session)', {
-          session: impersonating.session,
+        await this.remote.query('RETURN fn::_00_impersonate::stop($sid)', {
+          sid: impersonating.session,
         });
       } catch (_e) {
         // The token expires on its own.