@spooky-sync/core 0.0.1-canary.124 → 0.0.1-canary.126

package/dist/index.js

@@ -1178,7 +1178,8 @@ function bind(ctx, value) {
 	return `$${name}`;
 }
 function renderComparisonSurql(c, ctx) {
-	const right = c.paramRef ? `$${c.paramRef}` : bind(ctx, c.value);
+	const rawRight = c.paramRef ? `$${c.paramRef}` : bind(ctx, c.value);
+	const right = c.field === "id" ? `type::record(<string> ${rawRight})` : rawRight;
 	return c.swap ? `${right} ${c.op} ${c.field}` : `${c.field} ${c.op} ${right}`;
 }
 /** Render a WHERE conjunction (AND of comparisons / OR-groups) to SurrealQL. */
@@ -5100,8 +5101,8 @@ function parseBackendInfo(raw) {
 
 //#endregion
 //#region src/modules/devtools/index.ts
-const CORE_VERSION = "0.0.1-canary.124";
-const WASM_VERSION = "0.0.1-canary.124";
+const CORE_VERSION = "0.0.1-canary.126";
+const WASM_VERSION = "0.0.1-canary.126";
 const SURREAL_VERSION = "3.0.3";
 var DevToolsService = class {
 	eventsHistory = [];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@spooky-sync/core",
-  "version": "0.0.1-canary.124",
+  "version": "0.0.1-canary.126",
   "type": "module",
   "main": "./dist/index.js",
   "types": "./dist/index.d.ts",
@@ -59,8 +59,8 @@
     }
   },
   "dependencies": {
-    "@spooky-sync/query-builder": "0.0.1-canary.124",
-    "@spooky-sync/ssp-wasm": "0.0.1-canary.124",
+    "@spooky-sync/query-builder": "0.0.1-canary.126",
+    "@spooky-sync/ssp-wasm": "0.0.1-canary.126",
     "@sqlite.org/sqlite-wasm": "3.53.0-build1",
     "@surrealdb/wasm": "^3.0.3",
     "fast-json-patch": "^3.1.1",

package/src/services/database/plan-render.test.ts

@@ -42,6 +42,54 @@ describe('renderBaseSelectSurql', () => {
   });
 });
 
+// Regression guard for the "authors + comments don't load" class: any filter on
+// a RecordId column (`id`) must coerce its string value with
+// `type::record(<string> …)`. On SurrealDB `id = "thread:x"` (string) never
+// matches a RecordId, so a base select filtered by id resolves EMPTY and its
+// whole `.related()` subtree (author, comments) loads nothing. The string-based
+// MemStore in relation-resolver.test.ts can't catch this (it compares keys as
+// strings), so these assert the rendered SurrealQL directly — both the parent
+// (base select) and child (relation fetch) sides.
+describe('record-id coercion (authors/comments loading regression)', () => {
+  it('coerces a base-select `id = <value>` filter to a record id', () => {
+    const plan: QueryPlan = { table: 'thread', where: [{ field: 'id', op: '=', value: 'thread:abc' }] };
+    const { sql, vars } = renderBaseSelectSurql(plan);
+    expect(sql).toBe('SELECT * FROM thread WHERE id = type::record(<string> $__p0);');
+    expect(vars).toEqual({ __p0: 'thread:abc' });
+  });
+
+  it('coerces a base-select `id = $paramRef` filter (the ThreadDetail path)', () => {
+    const plan: QueryPlan = { table: 'thread', where: [{ field: 'id', op: '=', value: undefined, paramRef: 'id' }] };
+    const { sql } = renderBaseSelectSurql(plan, { id: 'thread:abc' });
+    expect(sql).toBe('SELECT * FROM thread WHERE id = type::record(<string> $id);');
+  });
+
+  it('does NOT coerce non-id fields (plain string/bool columns stay literal)', () => {
+    const plan: QueryPlan = {
+      table: 'thread',
+      where: [{ field: 'title', op: '=', value: 'hi' }, { field: 'published', op: '=', value: true }],
+    };
+    const { sql } = renderBaseSelectSurql(plan);
+    expect(sql).toBe('SELECT * FROM thread WHERE title = $__p0 AND published = $__p1;');
+  });
+
+  it('coerces `id` inside an OR group too', () => {
+    const plan: QueryPlan = {
+      table: 'thread',
+      where: [{ or: [{ field: 'id', op: '=', value: 'thread:a' }, { field: 'id', op: '=', value: 'thread:b' }] }],
+    };
+    const { sql } = renderBaseSelectSurql(plan);
+    expect(sql).toBe(
+      'SELECT * FROM thread WHERE (id = type::record(<string> $__p0) OR id = type::record(<string> $__p1));'
+    );
+  });
+
+  it('relation fetch coerces its matchField keys (the .118 fix — kept locked)', () => {
+    const { sql } = renderRelationFetchSurql({ table: 'user', matchField: 'id', keys: ['user:1'] });
+    expect(sql).toContain('id IN $__keys.map(|$__k| type::record(<string> $__k))');
+  });
+});
+
 describe('renderRelationFetchSurql', () => {
   it('builds a WHERE ... IN $__keys batch fetch, omitting LIMIT', () => {
     const { sql, vars } = renderRelationFetchSurql({

package/src/services/database/plan-render.ts

@@ -26,7 +26,16 @@ function bind(ctx: RenderCtx, value: unknown): string {
 }
 
 function renderComparisonSurql(c: WhereComparison, ctx: RenderCtx): string {
-  const right = c.paramRef ? `$${c.paramRef}` : bind(ctx, c.value);
+  const rawRight = c.paramRef ? `$${c.paramRef}` : bind(ctx, c.value);
+  // `id` is a RecordId, but correlation/filter values arrive as record-id
+  // STRINGS (e.g. "thread:abc"). On SurrealDB `id = "thread:abc"` never matches
+  // (string ≠ record), so a base select filtered by id (e.g. the ThreadDetail
+  // query `… FROM thread WHERE id = $id`) resolves empty — and its whole
+  // `.related()` subtree (author, comments) then loads nothing. Coerce with
+  // `type::record(<string> …)` (idempotent if already a RecordId), mirroring
+  // renderRelationFetchSurql's matchField coercion.
+  const right =
+    c.field === 'id' ? `type::record(<string> ${rawRight})` : rawRight;
   return c.swap ? `${right} ${c.op} ${c.field}` : `${c.field} ${c.op} ${right}`;
 }