@splunk/visualizations 26.3.0 → 26.4.1

package/common/withDashboardViz.js

@@ -430,19 +430,21 @@ var largestTriangleThreeBuckets = function largestTriangleThreeBuckets(data, thr
  */
 
 
-var strictlyCoerceYColumn = function strictlyCoerceYColumn(column) {
-  // Splunk charting allows for numbers in formats such as negative hex that
+var strictlyCoerceYColumn = function strictlyCoerceYColumn(column, options) {
+  var isNullCoercionEnabled = options.nullValueDisplay === 'zero'; // Splunk charting allows for numbers in formats such as negative hex that
   // Number() does not support and also allows loose coercion of hex numbers (but not other formats)
   // We want to identify columns which contain at least one value that can be loosely coerced
+
   var canLooselyCoerceSomeValues = column.findIndex(function (value) {
-    return (0, numberUtils_1.startsWithNumber)("".concat(value));
+    return (0, numberUtils_1.startsWithNumber)("".concat(value)) || isNullCoercionEnabled && value === null;
   }) >= 0; // If not all values in column can be strictly coerced to a number, we do not downsample
 
   var coercedColumn = [];
   var canDownsampleColumn = !column.some(function (value) {
-    var coercedValue = Number(value); // if it can't be parsed or isn't safe, fail
+    var coercedValue = Number(value);
+    var coerceValueToZero = isNullCoercionEnabled && value === null; // if it can't be parsed or isn't safe, fail
 
-    if (Number.isNaN(coercedValue) || coercedValue <= Number.MIN_SAFE_INTEGER || coercedValue >= Number.MAX_SAFE_INTEGER || typeof value !== 'string' && typeof value !== 'number') {
+    if (Number.isNaN(coercedValue) || coercedValue <= Number.MIN_SAFE_INTEGER || coercedValue >= Number.MAX_SAFE_INTEGER || typeof value !== 'string' && typeof value !== 'number' && !coerceValueToZero) {
       return true;
     } // save value and continue to next
 
@@ -523,8 +525,7 @@ var calculateDownsamplingThreshold = function calculateDownsamplingThreshold(_re
       dataSources = _ref3.dataSources,
       selectChartEvent = _ref3.selectChartEvent,
       width = _ref3.width,
-      xField = _ref3.xField,
-      y2Fields = _ref3.y2Fields;
+      xField = _ref3.xField;
 
   var _a, _b, _c;
 
@@ -561,14 +562,7 @@ var calculateDownsamplingThreshold = function calculateDownsamplingThreshold(_re
     });
     var lastIndex = fullSeries.findIndex(function (x) {
       return downsampledSeries[endXIndex] === x;
-    }); // For charts with categorical x-axis (charts with an xField that isn't _time), do not support
-    // re-calculating downsampling threshold if the chart is zoomed in until SPL-259458 is fixed
-    // Also do not support re-calculating downsampling threshold for zoomed-in charts with y2
-    // until SPL-259611 is fixed
-
-    if (xField !== '_time' || (y2Fields === null || y2Fields === void 0 ? void 0 : y2Fields.length)) {
-      return firstIndex === 0 && lastIndex === fullSeries.length - 1 ? width : null;
-    }
+    });
 
     if (firstIndex >= 0 && lastIndex >= 0 && firstIndex <= lastIndex) {
       return (0, exports.calculateThresholdOnRangeSelect)({
@@ -618,7 +612,7 @@ var isColumnStrictlyIncreasing = function isColumnStrictlyIncreasing(column, fie
  */
 
 
-var tryToCoerceAllDisplayedFields = function tryToCoerceAllDisplayedFields(ds, xField, yFields, fieldTypes) {
+var tryToCoerceAllDisplayedFields = function tryToCoerceAllDisplayedFields(ds, xField, yFields, fieldTypes, options) {
   var xColumn = [];
   var yColumns = [];
   var canDownsample = !ds.data.fields.some(function (field, index) {
@@ -632,7 +626,7 @@ var tryToCoerceAllDisplayedFields = function tryToCoerceAllDisplayedFields(ds, x
     if (fieldName === xField) {
       xColumn = strictlyCoerceXColumn(column, fieldType);
     } else if (yFields.has(fieldName)) {
-      var _strictlyCoerceYColum = strictlyCoerceYColumn(ds.data.columns[index]),
+      var _strictlyCoerceYColum = strictlyCoerceYColumn(ds.data.columns[index], options),
           coercedColumn = _strictlyCoerceYColum.coercedColumn,
           canLooselyCoerceSomeValues = _strictlyCoerceYColum.canLooselyCoerceSomeValues,
           canDownsampleColumn = _strictlyCoerceYColum.canDownsampleColumn; // do not perform downsampling if a column can possibly be displayed but cannot
@@ -722,7 +716,7 @@ var downsampleDataSources = function downsampleDataSources(_ref4) {
     return dataSources;
   }
 
-  var _tryToCoerceAllDispla = tryToCoerceAllDisplayedFields(primaryDS, xField, nonInternalYFields, fieldTypes),
+  var _tryToCoerceAllDispla = tryToCoerceAllDisplayedFields(primaryDS, xField, nonInternalYFields, fieldTypes, options),
       xColumn = _tryToCoerceAllDispla.xColumn,
       yColumns = _tryToCoerceAllDispla.yColumns;
 
@@ -1305,7 +1299,7 @@ var withFixedSizeContainer = function withFixedSizeContainer(Viz) {
 
     return React.createElement(FixSizeItem, {
       "data-test": "fix-size-item",
-      "data-splunk-visualization-version": "26.3.0 - a1ef240a6",
+      "data-splunk-visualization-version": "26.4.1 - 2b7482c08",
       width: width,
       height: height,
       backgroundColor: backgroundColor
@@ -2120,7 +2114,7 @@ var Cover = styled_components_1.default.div.withConfig({
   componentId: "sc-1gsbnxb-0"
 })(["position:absolute;left:0;right:0;top:0;bottom:0;"]);
 var Blocker = styled_components_1.default.div.attrs({
-  'data-splunk-visualization-version': "26.3.0 - a1ef240a6"
+  'data-splunk-visualization-version': "26.4.1 - 2b7482c08"
 }).withConfig({
   displayName: "withEditModeCover__Blocker",
   componentId: "sc-1gsbnxb-1"
@@ -2327,7 +2321,10 @@ var dataUtils_1 = __webpack_require__(25);
 
 var usePrevious_1 = __webpack_require__(31);
 
-var useGetXAndYFields_1 = __webpack_require__(121);
+var useGetXAndYFields_1 = __webpack_require__(121); // Options properties which impact/require re-downsample on change.
+
+
+var downsampleVizOptionProperties = ['nullValueDisplay'];
 
 var useDownsampleDataSources = function useDownsampleDataSources(_ref) {
   var dataSources = _ref.dataSources,
@@ -2341,8 +2338,15 @@ var useDownsampleDataSources = function useDownsampleDataSources(_ref) {
     options: options,
     context: context,
     dataSources: dataSources
-  });
-  var previousXAndYFieldsWithTypes = (0, usePrevious_1.default)(xAndYFieldsWithTypes);
+  }); // Extract viz options that impact downsampling.
+
+  var downsampleVizOptions = (0, react_1.useMemo)(function () {
+    return (0, lodash_1.pick)(options, downsampleVizOptionProperties);
+  }, [options]);
+  var downsampleDSOptions = (0, react_1.useMemo)(function () {
+    return Object.assign(Object.assign({}, downsampleVizOptions), xAndYFieldsWithTypes);
+  }, [xAndYFieldsWithTypes, downsampleVizOptions]);
+  var previousDownsampleDSOptions = (0, usePrevious_1.default)(downsampleDSOptions);
   var previousDataSources = (0, usePrevious_1.default)(dataSources);
   var previousThreshold = (0, usePrevious_1.default)(threshold);
 
@@ -2350,7 +2354,7 @@ var useDownsampleDataSources = function useDownsampleDataSources(_ref) {
     return isDownsamplingEnabled ? (0, dataUtils_1.downsampleDataSources)({
       dataSources: dataSources,
       threshold: threshold,
-      options: xAndYFieldsWithTypes
+      options: downsampleDSOptions
     }) : dataSources;
   }),
       _ref3 = _slicedToArray(_ref2, 2),
@@ -2378,7 +2382,7 @@ var useDownsampleDataSources = function useDownsampleDataSources(_ref) {
       return;
     }
 
-    if ((0, lodash_1.isEqual)(previousXAndYFieldsWithTypes, xAndYFieldsWithTypes) && previousDataSources === dataSources && previousThreshold === threshold) {
+    if ((0, lodash_1.isEqual)(previousDownsampleDSOptions, downsampleDSOptions) && previousDataSources === dataSources && previousThreshold === threshold) {
       return;
     } // Debounce the downsampling so we don't have to downsample and execute DSL multiple times
     // while the viz is being resized
@@ -2386,10 +2390,10 @@ var useDownsampleDataSources = function useDownsampleDataSources(_ref) {
 
     debouncedDownsampleDataSources({
       dataSources: dataSources,
-      options: xAndYFieldsWithTypes,
+      options: downsampleDSOptions,
       threshold: threshold
     }); // need to detect if this runs as part of the initial render
-  }, [dataSources, debouncedDownsampleDataSources, xAndYFieldsWithTypes, threshold, isDownsamplingEnabled, previousXAndYFieldsWithTypes, previousDataSources, previousThreshold]);
+  }, [dataSources, downsampleDSOptions, debouncedDownsampleDataSources, xAndYFieldsWithTypes, threshold, isDownsamplingEnabled, previousDataSources, previousThreshold, previousDownsampleDSOptions]);
   return downsampledDataSources;
 };