@splitsoftware/splitio 10.16.1 → 10.16.2-rc.0

package/CHANGES.txt

@@ -1,3 +1,7 @@
+10.17.0 (January XXX, 2022)
+ - Added Attribute binding feature to allow to optionally keep user attributes loaded within the SDK, along with the user ID, for easier usage when requesting flag.
+ - Bugfixing - Fixed issue returning dynamic configs if treatment name contains a dot (".")
+
 10.16.1 (October 25, 2021)
  - Updated some internal modules to optimize the time efficiency of split evaluations (i.e., `getTreatment(s)` method calls).
  - Updated some dependencies for vulnerability fixes (ioredis, @babel/cli, eslint, eslint-plugin-compat).

package/CONTRIBUTORS-GUIDE.md

@@ -7,18 +7,19 @@ Split SDK is an open source project and we welcome feedback and contribution. Th
 ### Development process
 
 1. Fork the repository and create a topic branch from `development` branch. Please use a descriptive name for your branch.
-2. While developing, use descriptive messages in your commits. Avoid short or meaningless sentences like: "fix bug".
-3. Make sure to add tests for both positive and negative cases.
-4. If your changes have any impact on the public API, make sure you update the TypeScript delcarations as well as it's related test file.
-5. Run the linter script of the project and fix any issues you find.
-6. Run the build script and make sure it runs with no errors.
-7. Run all tests and make sure there are no failures.
-8. Run the TypeScript declarations tests and make sure it compiles correctly.
-9. `git push` your changes to GitHub within your topic branch.
-10. Open a Pull Request(PR) from your forked repo and into the `development` branch of the original repository.
-11. When creating your PR, please fill out all the fields of the PR template, as applicable, for the project.
-12. Check for conflicts once the pull request is created to make sure your PR can be merged cleanly into `development`.
-13. Keep an eye out for any feedback or comments from Split's SDK team.
+2. Run `nvm use` to ensure that you are using the right npm and node version, and `npm install` to have the dependencies up to date. 
+3. While developing, use descriptive messages in your commits. Avoid short or meaningless sentences like: "fix bug".
+4. Make sure to add tests for both positive and negative cases.
+5. If your changes have any impact on the public API, make sure you update the TypeScript delcarations as well as it's related test file.
+6. Run the linter script of the project and fix any issues you find.
+7. Run the build script and make sure it runs with no errors.
+8. Run all tests and make sure there are no failures.
+9. Run the TypeScript declarations tests and make sure it compiles correctly.
+10. `git push` your changes to GitHub within your topic branch.
+11. Open a Pull Request(PR) from your forked repo and into the `development` branch of the original repository.
+12. When creating your PR, please fill out all the fields of the PR template, as applicable, for the project.
+13. Check for conflicts once the pull request is created to make sure your PR can be merged cleanly into `development`.
+14. Keep an eye out for any feedback or comments from Split's SDK team.
 
 ### Building the SDK
 

package/es/client/attributesDecoration.js

@@ -0,0 +1,116 @@
+import ClientInputValidationLayer from './inputValidation';
+import AttributesCacheInMemory from '../storage/AttributesCache/InMemory';
+import { validateAttributesDeep } from '../utils/inputValidation/attributes';
+import logFactory from '../utils/logger';
+import objectAssign from 'object-assign';
+var log = logFactory('splitio-client');
+/**
+ * Add in memory attributes storage methods and combine them with any attribute received from the getTreatment/s call 
+ */
+
+export default function ClientAttributesDecorationLayer(context, isKeyBinded, isTTBinded) {
+  var client = ClientInputValidationLayer(context, isKeyBinded, isTTBinded);
+  var attributeStorage = new AttributesCacheInMemory(); // Keep a reference to the original methods
+
+  var clientGetTreatment = client.getTreatment;
+  var clientGetTreatmentWithConfig = client.getTreatmentWithConfig;
+  var clientGetTreatments = client.getTreatments;
+  var clientGetTreatmentsWithConfig = client.getTreatmentsWithConfig;
+  /**
+   * Add an attribute to client's in memory attributes storage
+   * 
+   * @param {string} attributeName Attrinute name
+   * @param {string, number, boolean, list} attributeValue Attribute value
+   * @returns {boolean} true if the attribute was stored and false otherways
+   */
+
+  client.setAttribute = function (attributeName, attributeValue) {
+    var attribute = {};
+    attribute[attributeName] = attributeValue;
+    if (!validateAttributesDeep(attribute)) return false;
+    log.debug("stored " + attributeValue + " for attribute " + attributeName);
+    return attributeStorage.setAttribute(attributeName, attributeValue);
+  };
+  /**
+   * Returns the attribute with the given key
+   * 
+   * @param {string} attributeName Attribute name
+   * @returns {Object} Attribute with the given key
+   */
+
+
+  client.getAttribute = function (attributeName) {
+    log.debug("retrieved attribute " + attributeName);
+    return attributeStorage.getAttribute(attributeName + '');
+  };
+  /**
+   * Add to client's in memory attributes storage the attributes in 'attributes'
+   * 
+   * @param {Object} attributes Object with attributes to store
+   * @returns true if attributes were stored an false otherways
+   */
+
+
+  client.setAttributes = function (attributes) {
+    if (!validateAttributesDeep(attributes)) return false;
+    return attributeStorage.setAttributes(attributes);
+  };
+  /**
+   * Return all the attributes stored in client's in memory attributes storage
+   * 
+   * @returns {Object} returns all the stored attributes
+   */
+
+
+  client.getAttributes = function () {
+    return attributeStorage.getAll();
+  };
+  /**
+   * Removes from client's in memory attributes storage the attribute with the given key
+   * 
+   * @param {string} attributeName 
+   * @returns {boolean} true if attribute was removed and false otherways
+   */
+
+
+  client.removeAttribute = function (attributeName) {
+    log.debug("removed attribute " + attributeName);
+    return attributeStorage.removeAttribute(attributeName + '');
+  };
+  /**
+   * Remove all the stored attributes in the client's in memory attribute storage
+   */
+
+
+  client.clearAttributes = function () {
+    return attributeStorage.clear();
+  };
+
+  client.getTreatment = function (maybeKey, maybeSplit, maybeAttributes) {
+    return clientGetTreatment(maybeKey, maybeSplit, combineAttributes(maybeAttributes));
+  };
+
+  client.getTreatmentWithConfig = function (maybeKey, maybeSplit, maybeAttributes) {
+    return clientGetTreatmentWithConfig(maybeKey, maybeSplit, combineAttributes(maybeAttributes));
+  };
+
+  client.getTreatments = function (maybeKey, maybeSplits, maybeAttributes) {
+    return clientGetTreatments(maybeKey, maybeSplits, combineAttributes(maybeAttributes));
+  };
+
+  client.getTreatmentsWithConfig = function (maybeKey, maybeSplits, maybeAttributes) {
+    return clientGetTreatmentsWithConfig(maybeKey, maybeSplits, combineAttributes(maybeAttributes));
+  };
+
+  function combineAttributes(maybeAttributes) {
+    var storedAttributes = attributeStorage.getAll();
+
+    if (Object.keys(storedAttributes).length > 0) {
+      return objectAssign({}, storedAttributes, maybeAttributes);
+    }
+
+    return maybeAttributes;
+  }
+
+  return client;
+}

package/es/client/browser.js

@@ -1,5 +1,5 @@
 import { get } from '../utils/lang';
-import ClientWithInputValidationLayer from './inputValidation';
+import ClientAttributesDecorationLayer from './attributesDecoration';
 import { LOCALHOST_MODE } from '../utils/constants';
 import { validateKey, validateTrafficType } from '../utils/inputValidation';
 
@@ -25,7 +25,7 @@ function BrowserClientFactory(context) {
     trackBindings.push(tt);
   }
 
-  var client = ClientWithInputValidationLayer(context, true, trackBindings.length > 1);
+  var client = ClientAttributesDecorationLayer(context, true, trackBindings.length > 1);
   client.isBrowserClient = true; // In the browser land, we can bind the key and the traffic type (if provided)
 
   client.getTreatment = client.getTreatment.bind(client, settings.core.key);

package/es/engine/evaluator/index.js

@@ -16,7 +16,6 @@ limitations under the License.
 import Engine from '../';
 import thenable from '../../utils/promise/thenable';
 import * as LabelsConstants from '../../utils/labels';
-import { get } from '../../utils/lang';
 import { CONTROL } from '../../utils/constants';
 var treatmentException = {
   treatment: CONTROL,
@@ -74,18 +73,18 @@ function getEvaluation(stringifiedSplit, key, attributes, storage) {
   if (stringifiedSplit) {
     var splitJSON = JSON.parse(stringifiedSplit);
     var split = Engine.parse(splitJSON, storage);
-    evaluation = split.getTreatment(key, attributes, evaluateFeature); // If the storage is async, evaluation and changeNumber will return a thenable
+    evaluation = split.getTreatment(key, attributes, evaluateFeature); // If the storage is async and the evaluated split uses segment, evaluation is thenable
 
     if (thenable(evaluation)) {
       return evaluation.then(function (result) {
         result.changeNumber = split.getChangeNumber();
-        result.config = get(splitJSON, "configurations." + result.treatment, null);
+        result.config = splitJSON.configurations && splitJSON.configurations[result.treatment] || null;
         return result;
       });
     } else {
       evaluation.changeNumber = split.getChangeNumber(); // Always sync and optional
 
-      evaluation.config = get(splitJSON, "configurations." + evaluation.treatment, null);
+      evaluation.config = splitJSON.configurations && splitJSON.configurations[evaluation.treatment] || null;
     }
   }
 

package/es/storage/AttributesCache/InMemory.js

@@ -0,0 +1,84 @@
+import objectAssign from 'object-assign';
+
+var AttributesCacheInMemory = /*#__PURE__*/function () {
+  function AttributesCacheInMemory() {
+    this.attributesCache = {};
+  }
+  /**
+   * Create or update the value for the given attribute
+   * 
+   * @param {string} attributeName attribute name
+   * @param {Object} attributeValue attribute value
+   * @returns {boolean} the attribute was stored 
+   */
+
+
+  var _proto = AttributesCacheInMemory.prototype;
+
+  _proto.setAttribute = function setAttribute(attributeName, attributeValue) {
+    this.attributesCache[attributeName] = attributeValue;
+    return true;
+  }
+  /**
+   * Retrieves the value of a given attribute
+   * 
+   * @param {string} attributeName attribute name
+   * @returns {Object?} stored attribute value
+   */
+  ;
+
+  _proto.getAttribute = function getAttribute(attributeName) {
+    return this.attributesCache[attributeName];
+  }
+  /**
+   * Create or update all the given attributes
+   * 
+   * @param {[string, Object]} attributes attributes to create or update
+   * @returns {boolean} attributes were stored
+   */
+  ;
+
+  _proto.setAttributes = function setAttributes(attributes) {
+    this.attributesCache = objectAssign(this.attributesCache, attributes);
+    return true;
+  }
+  /**
+   * Retrieve the full attributes map
+   * 
+   * @returns {Map<string, Object>} stored attributes
+   */
+  ;
+
+  _proto.getAll = function getAll() {
+    return this.attributesCache;
+  }
+  /**
+   * Removes a given attribute from the map
+   * 
+   * @param {string} attributeName attribute to remove
+   * @returns {boolean} attribute removed
+   */
+  ;
+
+  _proto.removeAttribute = function removeAttribute(attributeName) {
+    if (Object.keys(this.attributesCache).indexOf(attributeName) >= 0) {
+      delete this.attributesCache[attributeName];
+      return true;
+    }
+
+    return false;
+  }
+  /**
+   * Clears all attributes stored in the SDK
+   * 
+   */
+  ;
+
+  _proto.clear = function clear() {
+    this.attributesCache = {};
+  };
+
+  return AttributesCacheInMemory;
+}();
+
+export default AttributesCacheInMemory;

package/es/utils/inputValidation/attribute.js

@@ -0,0 +1,22 @@
+import { isString, numberIsFinite, isBoolean } from '../lang';
+import logFactory from '../logger';
+var log = logFactory('');
+export function validateAttribute(attributeKey, attributeValue, method) {
+  if (!isString(attributeKey) || attributeKey.length === 0) {
+    log.warn(method + ": you passed an invalid attribute name, attribute name must be a non-empty string.");
+    return false;
+  }
+
+  var isStringVal = isString(attributeValue);
+  var isFiniteVal = numberIsFinite(attributeValue);
+  var isBoolVal = isBoolean(attributeValue);
+  var isArrayVal = Array.isArray(attributeValue);
+
+  if (!(isStringVal || isFiniteVal || isBoolVal || isArrayVal)) {
+    // If it's not of valid type.
+    log.warn(method + ": you passed an invalid attribute value for " + attributeKey + ". Acceptable types are: string, number, boolean and array of strings.");
+    return false;
+  }
+
+  return true;
+}

package/es/utils/inputValidation/attributes.js

@@ -1,5 +1,6 @@
 import { isObject } from '../lang';
 import logFactory from '../logger';
+import { validateAttribute } from './attribute';
 var log = logFactory('');
 export function validateAttributes(maybeAttrs, method) {
   // Attributes are optional
@@ -7,4 +8,12 @@ export function validateAttributes(maybeAttrs, method) {
     return maybeAttrs;
   log.error(method + ": attributes must be a plain object.");
   return false;
+}
+export function validateAttributesDeep(maybeAttributes, method) {
+  if (!validateAttributes(maybeAttributes, method)) return false;
+  var result = true;
+  Object.keys(maybeAttributes).forEach(function (attributeKey) {
+    if (!validateAttribute(attributeKey, maybeAttributes[attributeKey], method)) result = false;
+  });
+  return result;
 }

package/es/utils/settings/index.js

@@ -25,7 +25,7 @@ import validateSplitFilters from '../inputValidation/splitFilters';
 import { API } from '../../utils/logger';
 import { STANDALONE_MODE, STORAGE_MEMORY, CONSUMER_MODE, OPTIMIZED } from '../../utils/constants';
 import validImpressionsMode from './impressionsMode';
-var version = '10.16.1';
+var version = '10.16.2-rc.0';
 var eventsEndpointMatcher = /^\/(testImpressions|metrics|events)/;
 var authEndpointMatcher = /^\/v2\/auth/;
 var streamingEndpointMatcher = /^\/(sse|event-stream)/;

package/lib/client/attributesDecoration.js

@@ -0,0 +1,128 @@
+"use strict";
+
+var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
+
+exports.__esModule = true;
+exports.default = ClientAttributesDecorationLayer;
+
+var _inputValidation = _interopRequireDefault(require("./inputValidation"));
+
+var _InMemory = _interopRequireDefault(require("../storage/AttributesCache/InMemory"));
+
+var _attributes = require("../utils/inputValidation/attributes");
+
+var _logger = _interopRequireDefault(require("../utils/logger"));
+
+var _objectAssign = _interopRequireDefault(require("object-assign"));
+
+var log = (0, _logger.default)('splitio-client');
+/**
+ * Add in memory attributes storage methods and combine them with any attribute received from the getTreatment/s call 
+ */
+
+function ClientAttributesDecorationLayer(context, isKeyBinded, isTTBinded) {
+  var client = (0, _inputValidation.default)(context, isKeyBinded, isTTBinded);
+  var attributeStorage = new _InMemory.default(); // Keep a reference to the original methods
+
+  var clientGetTreatment = client.getTreatment;
+  var clientGetTreatmentWithConfig = client.getTreatmentWithConfig;
+  var clientGetTreatments = client.getTreatments;
+  var clientGetTreatmentsWithConfig = client.getTreatmentsWithConfig;
+  /**
+   * Add an attribute to client's in memory attributes storage
+   * 
+   * @param {string} attributeName Attrinute name
+   * @param {string, number, boolean, list} attributeValue Attribute value
+   * @returns {boolean} true if the attribute was stored and false otherways
+   */
+
+  client.setAttribute = function (attributeName, attributeValue) {
+    var attribute = {};
+    attribute[attributeName] = attributeValue;
+    if (!(0, _attributes.validateAttributesDeep)(attribute)) return false;
+    log.debug("stored " + attributeValue + " for attribute " + attributeName);
+    return attributeStorage.setAttribute(attributeName, attributeValue);
+  };
+  /**
+   * Returns the attribute with the given key
+   * 
+   * @param {string} attributeName Attribute name
+   * @returns {Object} Attribute with the given key
+   */
+
+
+  client.getAttribute = function (attributeName) {
+    log.debug("retrieved attribute " + attributeName);
+    return attributeStorage.getAttribute(attributeName + '');
+  };
+  /**
+   * Add to client's in memory attributes storage the attributes in 'attributes'
+   * 
+   * @param {Object} attributes Object with attributes to store
+   * @returns true if attributes were stored an false otherways
+   */
+
+
+  client.setAttributes = function (attributes) {
+    if (!(0, _attributes.validateAttributesDeep)(attributes)) return false;
+    return attributeStorage.setAttributes(attributes);
+  };
+  /**
+   * Return all the attributes stored in client's in memory attributes storage
+   * 
+   * @returns {Object} returns all the stored attributes
+   */
+
+
+  client.getAttributes = function () {
+    return attributeStorage.getAll();
+  };
+  /**
+   * Removes from client's in memory attributes storage the attribute with the given key
+   * 
+   * @param {string} attributeName 
+   * @returns {boolean} true if attribute was removed and false otherways
+   */
+
+
+  client.removeAttribute = function (attributeName) {
+    log.debug("removed attribute " + attributeName);
+    return attributeStorage.removeAttribute(attributeName + '');
+  };
+  /**
+   * Remove all the stored attributes in the client's in memory attribute storage
+   */
+
+
+  client.clearAttributes = function () {
+    return attributeStorage.clear();
+  };
+
+  client.getTreatment = function (maybeKey, maybeSplit, maybeAttributes) {
+    return clientGetTreatment(maybeKey, maybeSplit, combineAttributes(maybeAttributes));
+  };
+
+  client.getTreatmentWithConfig = function (maybeKey, maybeSplit, maybeAttributes) {
+    return clientGetTreatmentWithConfig(maybeKey, maybeSplit, combineAttributes(maybeAttributes));
+  };
+
+  client.getTreatments = function (maybeKey, maybeSplits, maybeAttributes) {
+    return clientGetTreatments(maybeKey, maybeSplits, combineAttributes(maybeAttributes));
+  };
+
+  client.getTreatmentsWithConfig = function (maybeKey, maybeSplits, maybeAttributes) {
+    return clientGetTreatmentsWithConfig(maybeKey, maybeSplits, combineAttributes(maybeAttributes));
+  };
+
+  function combineAttributes(maybeAttributes) {
+    var storedAttributes = attributeStorage.getAll();
+
+    if (Object.keys(storedAttributes).length > 0) {
+      return (0, _objectAssign.default)({}, storedAttributes, maybeAttributes);
+    }
+
+    return maybeAttributes;
+  }
+
+  return client;
+}

package/lib/client/browser.js

@@ -7,11 +7,11 @@ exports.default = void 0;
 
 var _lang = require("../utils/lang");
 
-var _inputValidation = _interopRequireDefault(require("./inputValidation"));
+var _attributesDecoration = _interopRequireDefault(require("./attributesDecoration"));
 
 var _constants = require("../utils/constants");
 
-var _inputValidation2 = require("../utils/inputValidation");
+var _inputValidation = require("../utils/inputValidation");
 
 function BrowserClientFactory(context) {
   var _client$track;
@@ -23,19 +23,19 @@ function BrowserClientFactory(context) {
   if (settings.mode === _constants.LOCALHOST_MODE && maybeKey === undefined) {
     settings.core.key = 'localhost_key';
   } else {
-    settings.core.key = (0, _inputValidation2.validateKey)(maybeKey, 'Client instantiation');
+    settings.core.key = (0, _inputValidation.validateKey)(maybeKey, 'Client instantiation');
   } // Key is also binded to the .track method. Same thing happens with trafficType but only if present on configs. (not required)
 
 
   var trackBindings = [settings.core.key];
 
   if (maybeTT !== undefined) {
-    var tt = (0, _inputValidation2.validateTrafficType)(maybeTT, 'Client instantiation');
+    var tt = (0, _inputValidation.validateTrafficType)(maybeTT, 'Client instantiation');
     settings.core.trafficType = tt;
     trackBindings.push(tt);
   }
 
-  var client = (0, _inputValidation.default)(context, true, trackBindings.length > 1);
+  var client = (0, _attributesDecoration.default)(context, true, trackBindings.length > 1);
   client.isBrowserClient = true; // In the browser land, we can bind the key and the traffic type (if provided)
 
   client.getTreatment = client.getTreatment.bind(client, settings.core.key);

package/lib/engine/evaluator/index.js

@@ -14,8 +14,6 @@ var _thenable = _interopRequireDefault(require("../../utils/promise/thenable"));
 
 var LabelsConstants = _interopRequireWildcard(require("../../utils/labels"));
 
-var _lang = require("../../utils/lang");
-
 var _constants = require("../../utils/constants");
 
 /**
@@ -93,18 +91,18 @@ function getEvaluation(stringifiedSplit, key, attributes, storage) {
 
     var split = _.default.parse(splitJSON, storage);
 
-    evaluation = split.getTreatment(key, attributes, evaluateFeature); // If the storage is async, evaluation and changeNumber will return a thenable
+    evaluation = split.getTreatment(key, attributes, evaluateFeature); // If the storage is async and the evaluated split uses segment, evaluation is thenable
 
     if ((0, _thenable.default)(evaluation)) {
       return evaluation.then(function (result) {
         result.changeNumber = split.getChangeNumber();
-        result.config = (0, _lang.get)(splitJSON, "configurations." + result.treatment, null);
+        result.config = splitJSON.configurations && splitJSON.configurations[result.treatment] || null;
         return result;
       });
     } else {
       evaluation.changeNumber = split.getChangeNumber(); // Always sync and optional
 
-      evaluation.config = (0, _lang.get)(splitJSON, "configurations." + evaluation.treatment, null);
+      evaluation.config = splitJSON.configurations && splitJSON.configurations[evaluation.treatment] || null;
     }
   }
 

package/lib/storage/AttributesCache/InMemory.js

@@ -0,0 +1,92 @@
+"use strict";
+
+var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
+
+exports.__esModule = true;
+exports.default = void 0;
+
+var _objectAssign = _interopRequireDefault(require("object-assign"));
+
+var AttributesCacheInMemory = /*#__PURE__*/function () {
+  function AttributesCacheInMemory() {
+    this.attributesCache = {};
+  }
+  /**
+   * Create or update the value for the given attribute
+   * 
+   * @param {string} attributeName attribute name
+   * @param {Object} attributeValue attribute value
+   * @returns {boolean} the attribute was stored 
+   */
+
+
+  var _proto = AttributesCacheInMemory.prototype;
+
+  _proto.setAttribute = function setAttribute(attributeName, attributeValue) {
+    this.attributesCache[attributeName] = attributeValue;
+    return true;
+  }
+  /**
+   * Retrieves the value of a given attribute
+   * 
+   * @param {string} attributeName attribute name
+   * @returns {Object?} stored attribute value
+   */
+  ;
+
+  _proto.getAttribute = function getAttribute(attributeName) {
+    return this.attributesCache[attributeName];
+  }
+  /**
+   * Create or update all the given attributes
+   * 
+   * @param {[string, Object]} attributes attributes to create or update
+   * @returns {boolean} attributes were stored
+   */
+  ;
+
+  _proto.setAttributes = function setAttributes(attributes) {
+    this.attributesCache = (0, _objectAssign.default)(this.attributesCache, attributes);
+    return true;
+  }
+  /**
+   * Retrieve the full attributes map
+   * 
+   * @returns {Map<string, Object>} stored attributes
+   */
+  ;
+
+  _proto.getAll = function getAll() {
+    return this.attributesCache;
+  }
+  /**
+   * Removes a given attribute from the map
+   * 
+   * @param {string} attributeName attribute to remove
+   * @returns {boolean} attribute removed
+   */
+  ;
+
+  _proto.removeAttribute = function removeAttribute(attributeName) {
+    if (Object.keys(this.attributesCache).indexOf(attributeName) >= 0) {
+      delete this.attributesCache[attributeName];
+      return true;
+    }
+
+    return false;
+  }
+  /**
+   * Clears all attributes stored in the SDK
+   * 
+   */
+  ;
+
+  _proto.clear = function clear() {
+    this.attributesCache = {};
+  };
+
+  return AttributesCacheInMemory;
+}();
+
+var _default = AttributesCacheInMemory;
+exports.default = _default;

package/lib/utils/inputValidation/attribute.js

@@ -0,0 +1,32 @@
+"use strict";
+
+var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
+
+exports.__esModule = true;
+exports.validateAttribute = validateAttribute;
+
+var _lang = require("../lang");
+
+var _logger = _interopRequireDefault(require("../logger"));
+
+var log = (0, _logger.default)('');
+
+function validateAttribute(attributeKey, attributeValue, method) {
+  if (!(0, _lang.isString)(attributeKey) || attributeKey.length === 0) {
+    log.warn(method + ": you passed an invalid attribute name, attribute name must be a non-empty string.");
+    return false;
+  }
+
+  var isStringVal = (0, _lang.isString)(attributeValue);
+  var isFiniteVal = (0, _lang.numberIsFinite)(attributeValue);
+  var isBoolVal = (0, _lang.isBoolean)(attributeValue);
+  var isArrayVal = Array.isArray(attributeValue);
+
+  if (!(isStringVal || isFiniteVal || isBoolVal || isArrayVal)) {
+    // If it's not of valid type.
+    log.warn(method + ": you passed an invalid attribute value for " + attributeKey + ". Acceptable types are: string, number, boolean and array of strings.");
+    return false;
+  }
+
+  return true;
+}