@splitsoftware/splitio-commons 3.1.1-rc.10 → 3.1.1-rc.12

package/cjs/storages/pluggable/RBSegmentsCachePluggable.js

@@ -34,7 +34,7 @@ var RBSegmentsCachePluggable = /** @class */ (function () {
                 return _this.wrapper.set(key, stringifiedNewRBSegment).then(function () { return true; });
             })),
             Promise.all(toRemove.map(function (toRemove) {
-                var key = _this.keys.buildRBSegmentKey(toRemove.name);
+                var key = _this.keys.buildRBSegmentKey(toRemove);
                 return _this.wrapper.del(key);
             }))
         ]).then(function (_a) {
@@ -43,7 +43,9 @@ var RBSegmentsCachePluggable = /** @class */ (function () {
         });
     };
     RBSegmentsCachePluggable.prototype.setChangeNumber = function (changeNumber) {
-        return this.wrapper.set(this.keys.buildRBSegmentsTillKey(), changeNumber + '');
+        if (changeNumber !== undefined) {
+            return this.wrapper.set(this.keys.buildRBSegmentsTillKey(), changeNumber + '');
+        }
     };
     RBSegmentsCachePluggable.prototype.getChangeNumber = function () {
         var _this = this;

package/cjs/storages/pluggable/index.js

@@ -3,7 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.PluggableStorage = void 0;
 var tslib_1 = require("tslib");
 var KeyBuilderSS_1 = require("../KeyBuilderSS");
-var SplitsCachePluggable_1 = require("./SplitsCachePluggable");
+var DefinitionsCachePluggable_1 = require("./DefinitionsCachePluggable");
 var SegmentsCachePluggable_1 = require("./SegmentsCachePluggable");
 var ImpressionsCachePluggable_1 = require("./ImpressionsCachePluggable");
 var EventsCachePluggable_1 = require("./EventsCachePluggable");
@@ -106,7 +106,7 @@ function PluggableStorage(options) {
             return e; // Propagate error for shared clients
         });
         return {
-            splits: new SplitsCachePluggable_1.SplitsCachePluggable(log, keys, wrapper, settings.sync.__splitFiltersValidation),
+            definitions: new DefinitionsCachePluggable_1.DefinitionsCachePluggable(log, keys, wrapper, settings.sync.__splitFiltersValidation),
             rbSegments: new RBSegmentsCachePluggable_1.RBSegmentsCachePluggable(log, keys, wrapper),
             segments: new SegmentsCachePluggable_1.SegmentsCachePluggable(log, keys, wrapper),
             impressions: isPartialConsumer ? new ImpressionsCacheInMemory_1.ImpressionsCacheInMemory(impressionsQueueSize) : new ImpressionsCachePluggable_1.ImpressionsCachePluggable(log, keys.buildImpressionsKey(), wrapper, metadata),

package/cjs/storages/setRolloutPlan.js

@@ -24,12 +24,12 @@ exports.validateRolloutPlan = validateRolloutPlan;
  * Otherwise, the storage is handled as a server-side storage (segments is an instance of SegmentsCache).
  */
 function setRolloutPlan(log, rolloutPlan, storage, matchingKey) {
-    var splits = storage.splits, rbSegments = storage.rbSegments, segments = storage.segments, largeSegments = storage.largeSegments;
+    var definitions = storage.definitions, rbSegments = storage.rbSegments, segments = storage.segments, largeSegments = storage.largeSegments;
     var _a = rolloutPlan.splitChanges, ff = _a.ff, rbs = _a.rbs;
     log.debug("storage: set feature flags and segments".concat(matchingKey ? " for key ".concat(matchingKey) : ''));
-    if (splits && ff) {
-        splits.clear();
-        splits.update(ff.d || [], [], ff.t);
+    if (definitions && ff) {
+        definitions.clear();
+        definitions.update(ff.d || [], [], ff.t);
     }
     if (rbSegments && rbs) {
         rbSegments.clear();

package/cjs/storages/utils.js

@@ -28,6 +28,7 @@ function impressionsToJSON(impressions, metadata) {
                 m: impression.time,
                 pt: impression.pt,
                 properties: impression.properties
+                // @TODO set entityType
             }
         };
         return JSON.stringify(impressionWithMetadata);

package/cjs/sync/offline/syncTasks/fromObjectSyncTask.js

@@ -10,7 +10,7 @@ var constants_3 = require("../../../logger/constants");
  * Offline equivalent of `splitChangesUpdaterFactory`
  */
 function fromObjectUpdaterFactory(splitsParser, storage, readiness, settings) {
-    var log = settings.log, splitsCache = storage.splits;
+    var log = settings.log, definitions = storage.definitions;
     var startingUp = true;
     return function objectUpdater() {
         var splits = [];
@@ -39,16 +39,16 @@ function fromObjectUpdaterFactory(splitsParser, storage, readiness, settings) {
                 });
             });
             return Promise.all([
-                splitsCache.clear(),
-                splitsCache.update(splits, [], Date.now())
+                definitions.clear(),
+                definitions.update(splits, [], Date.now())
             ]).then(function () {
-                readiness.splits.emit(constants_2.SDK_SPLITS_ARRIVED, { type: constants_2.FLAGS_UPDATE, names: [] });
+                readiness.definitions.emit(constants_2.SDK_DEFINITIONS_ARRIVED, { type: constants_2.FLAGS_UPDATE, names: [] });
                 if (startingUp) {
                     startingUp = false;
                     Promise.resolve(storage.validateCache ? storage.validateCache() : { initialCacheLoad: true /* Fallback: assume initial load when validateCache doesn't exist */ }).then(function (cacheMetadata) {
                         // Emits SDK_READY_FROM_CACHE
                         if (!cacheMetadata.initialCacheLoad) {
-                            readiness.splits.emit(constants_2.SDK_SPLITS_CACHE_LOADED, cacheMetadata);
+                            readiness.definitions.emit(constants_2.SDK_DEFINITIONS_CACHE_LOADED, cacheMetadata);
                         }
                         // Emits SDK_READY
                         readiness.segments.emit(constants_2.SDK_SEGMENTS_ARRIVED, { type: constants_2.SEGMENTS_UPDATE, names: [] });

package/cjs/sync/polling/fetchers/splitChangesFetcher.js

@@ -10,16 +10,25 @@ var PROXY_CHECK_INTERVAL_MILLIS_SS = 24 * PROXY_CHECK_INTERVAL_MILLIS_CS; // 24
 function sdkEndpointOverridden(settings) {
     return settings.urls.sdk !== settingsValidation_1.base.urls.sdk;
 }
+function isSplitChangesLegacyResponse(data) {
+    return data.splits != null;
+}
+function partitionByStatus(items, till, since) {
+    var updated = [], removed = [];
+    items.forEach(function (item) { return item.status === 'ARCHIVED' ? removed.push(item.name) : updated.push(item); });
+    return { updated: updated, removed: removed, till: till, since: since !== null && since !== void 0 ? since : undefined };
+}
 /**
  * Factory of SplitChanges fetcher.
  * SplitChanges fetcher is a wrapper around `splitChanges` API service that parses the response and handle errors.
  */
 // @TODO breaking: drop support for Split Proxy below v5.10.0 and simplify the implementation
-function splitChangesFetcherFactory(fetchSplitChanges, settings, storage) {
+function splitChangesFetcherFactory(params) {
+    var fetchSplitChanges = params.serviceApi.fetchSplitChanges, settings = params.settings, storage = params.storage;
     var log = settings.log;
     var PROXY_CHECK_INTERVAL_MILLIS = (0, key_1.checkIfServerSide)(settings) ? PROXY_CHECK_INTERVAL_MILLIS_SS : PROXY_CHECK_INTERVAL_MILLIS_CS;
     var lastProxyCheckTimestamp;
-    return function splitChangesFetcher(since, noCache, till, rbSince, 
+    function splitChangesFetcher(since, noCache, till, rbSince, 
     // Optional decorator for `fetchSplitChanges` promise, such as timeout or time tracker
     decorator) {
         // Recheck proxy
@@ -30,7 +39,7 @@ function splitChangesFetcherFactory(fetchSplitChanges, settings, storage) {
             .catch(function (err) {
             // Handle proxy error with spec 1.3
             if ((!err.statusCode || err.statusCode === 400) && sdkEndpointOverridden(settings) && settings.sync.flagSpecVersion === constants_1.FLAG_SPEC_VERSION) {
-                log.error(constants_2.LOG_PREFIX_SYNC_SPLITS + 'Proxy error detected. Retrying with spec 1.2. If you are using Split Proxy, please upgrade to latest version');
+                log.error(constants_2.LOG_PREFIX_SYNC + 'Proxy error detected. Retrying with spec 1.2. If you are using Split Proxy, please upgrade to latest version');
                 lastProxyCheckTimestamp = Date.now();
                 settings.sync.flagSpecVersion = '1.2'; // fallback to 1.2 spec
                 return fetchSplitChanges(since, noCache, till); // retry request without rbSince
@@ -43,27 +52,27 @@ function splitChangesFetcherFactory(fetchSplitChanges, settings, storage) {
             .then(function (resp) { return resp.json(); })
             .then(function (data) {
             // Using flag spec version 1.2 or below
-            if (data.splits) {
-                return {
-                    ff: {
-                        d: data.splits,
-                        s: data.since,
-                        t: data.till
-                    }
-                };
+            if (isSplitChangesLegacyResponse(data)) {
+                return { d: partitionByStatus(data.splits || [], data.till, data.since) };
             }
             // Proxy recovery
             if (lastProxyCheckTimestamp) {
-                log.info(constants_2.LOG_PREFIX_SYNC_SPLITS + 'Proxy error recovered');
+                log.info(constants_2.LOG_PREFIX_SYNC + 'Proxy error recovered');
                 lastProxyCheckTimestamp = undefined;
                 return splitChangesFetcher(-1, undefined, undefined, -1)
                     .then(function (splitChangesResponse) {
-                    return Promise.all([storage.splits.clear(), storage.rbSegments.clear()])
+                    return Promise.all([storage.definitions.clear(), storage.rbSegments.clear()])
                         .then(function () { return splitChangesResponse; });
                 });
             }
-            return data;
+            var ff = data.ff, rbs = data.rbs;
+            return {
+                d: (ff === null || ff === void 0 ? void 0 : ff.d) ? partitionByStatus(ff.d, ff.t, ff.s) : undefined,
+                rbs: (rbs === null || rbs === void 0 ? void 0 : rbs.d) ? partitionByStatus(rbs.d, rbs.t, rbs.s) : undefined,
+            };
         });
-    };
+    }
+    splitChangesFetcher.type = 'feature flags';
+    return splitChangesFetcher;
 }
 exports.splitChangesFetcherFactory = splitChangesFetcherFactory;

package/cjs/sync/polling/pollingManagerCS.js

@@ -3,98 +3,103 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.pollingManagerCSFactory = void 0;
 var lang_1 = require("../../utils/lang");
 var mySegmentsSyncTask_1 = require("./syncTasks/mySegmentsSyncTask");
-var splitsSyncTask_1 = require("./syncTasks/splitsSyncTask");
+var definitionsSyncTask_1 = require("./syncTasks/definitionsSyncTask");
 var key_1 = require("../../utils/key");
 var constants_1 = require("../../readiness/constants");
 var constants_2 = require("../../logger/constants");
-var AbstractSplitsCacheSync_1 = require("../../storages/AbstractSplitsCacheSync");
+var AbstractDefinitionsCacheSync_1 = require("../../storages/AbstractDefinitionsCacheSync");
+var splitChangesFetcher_1 = require("./fetchers/splitChangesFetcher");
 /**
  * Expose start / stop mechanism for polling data from services.
  * For client-side API with multiple clients.
  */
-function pollingManagerCSFactory(params) {
-    var splitApi = params.splitApi, storage = params.storage, readiness = params.readiness, settings = params.settings;
-    var log = settings.log;
-    var splitsSyncTask = (0, splitsSyncTask_1.splitsSyncTaskFactory)(splitApi.fetchSplitChanges, storage, readiness, settings, true);
-    // Map of matching keys to their corresponding MySegmentsSyncTask.
-    var mySegmentsSyncTasks = {};
-    var matchingKey = (0, key_1.getMatching)(settings.core.key);
-    var mySegmentsSyncTask = add(matchingKey, readiness, storage);
-    function startMySegmentsSyncTasks() {
-        (0, lang_1.forOwn)(mySegmentsSyncTasks, function (mySegmentsSyncTask) {
-            mySegmentsSyncTask.start();
-        });
-    }
-    function stopMySegmentsSyncTasks() {
-        (0, lang_1.forOwn)(mySegmentsSyncTasks, function (mySegmentsSyncTask) {
-            if (mySegmentsSyncTask.isRunning())
-                mySegmentsSyncTask.stop();
-        });
-    }
-    // smart pausing
-    readiness.splits.on(constants_1.SDK_SPLITS_ARRIVED, function () {
-        if (!splitsSyncTask.isRunning())
-            return; // noop if not doing polling
-        var usingSegments = (0, AbstractSplitsCacheSync_1.usesSegmentsSync)(storage);
-        if (usingSegments !== mySegmentsSyncTask.isRunning()) {
-            log.info(constants_2.POLLING_SMART_PAUSING, [usingSegments ? 'ON' : 'OFF']);
-            if (usingSegments) {
-                startMySegmentsSyncTasks();
-            }
-            else {
-                stopMySegmentsSyncTasks();
-            }
-        }
-    });
-    function add(matchingKey, readiness, storage) {
-        var mySegmentsSyncTask = (0, mySegmentsSyncTask_1.mySegmentsSyncTaskFactory)(splitApi.fetchMemberships, storage, readiness, settings, matchingKey);
-        // smart ready
-        function smartReady(metadata) {
-            if (!readiness.isReady() && !(0, AbstractSplitsCacheSync_1.usesSegmentsSync)(storage))
-                readiness.segments.emit(constants_1.SDK_SEGMENTS_ARRIVED, metadata);
+function pollingManagerCSFactory(definitionFetcherFactory) {
+    if (definitionFetcherFactory === void 0) { definitionFetcherFactory = splitChangesFetcher_1.splitChangesFetcherFactory; }
+    return function (params) {
+        var serviceApi = params.serviceApi, storage = params.storage, readiness = params.readiness, settings = params.settings;
+        var log = settings.log;
+        var definitionChangesFetcher = definitionFetcherFactory(params);
+        var definitionsSyncTask = (0, definitionsSyncTask_1.definitionsSyncTaskFactory)(definitionChangesFetcher, storage, readiness, settings);
+        // Map of matching keys to their corresponding MySegmentsSyncTask.
+        var mySegmentsSyncTasks = {};
+        var matchingKey = (0, key_1.getMatching)(settings.core.key);
+        var mySegmentsSyncTask = add(matchingKey, readiness, storage);
+        function startMySegmentsSyncTasks() {
+            (0, lang_1.forOwn)(mySegmentsSyncTasks, function (mySegmentsSyncTask) {
+                mySegmentsSyncTask.start();
+            });
         }
-        if (!(0, AbstractSplitsCacheSync_1.usesSegmentsSync)(storage))
-            setTimeout(smartReady, 0);
-        else
-            readiness.splits.once(constants_1.SDK_SPLITS_ARRIVED, smartReady);
-        mySegmentsSyncTasks[matchingKey] = mySegmentsSyncTask;
-        return mySegmentsSyncTask;
-    }
-    return {
-        splitsSyncTask: splitsSyncTask,
-        segmentsSyncTask: mySegmentsSyncTask,
-        // Start periodic fetching (polling)
-        start: function () {
-            log.info(constants_2.POLLING_START);
-            splitsSyncTask.start();
-            if ((0, AbstractSplitsCacheSync_1.usesSegmentsSync)(storage))
-                startMySegmentsSyncTasks();
-        },
-        // Stop periodic fetching (polling)
-        stop: function () {
-            log.info(constants_2.POLLING_STOP);
-            if (splitsSyncTask.isRunning())
-                splitsSyncTask.stop();
-            stopMySegmentsSyncTasks();
-        },
-        // Used by SyncManager to know if running in polling mode.
-        isRunning: splitsSyncTask.isRunning,
-        // fetch splits and segments
-        syncAll: function () {
-            var promises = [splitsSyncTask.execute()];
+        function stopMySegmentsSyncTasks() {
             (0, lang_1.forOwn)(mySegmentsSyncTasks, function (mySegmentsSyncTask) {
-                promises.push(mySegmentsSyncTask.execute());
+                if (mySegmentsSyncTask.isRunning())
+                    mySegmentsSyncTask.stop();
             });
-            return Promise.all(promises);
-        },
-        // Support for handling mySegments sync of multiple clients
-        add: add,
-        remove: function (matchingKey) {
-            delete mySegmentsSyncTasks[matchingKey];
-        },
-        get: function (matchingKey) {
-            return mySegmentsSyncTasks[matchingKey];
         }
+        // smart pausing
+        readiness.definitions.on(constants_1.SDK_DEFINITIONS_ARRIVED, function () {
+            if (!definitionsSyncTask.isRunning())
+                return; // noop if not doing polling
+            var usingSegments = (0, AbstractDefinitionsCacheSync_1.usesSegmentsSync)(storage);
+            if (usingSegments !== mySegmentsSyncTask.isRunning()) {
+                log.info(constants_2.POLLING_SMART_PAUSING, [usingSegments ? 'ON' : 'OFF']);
+                if (usingSegments) {
+                    startMySegmentsSyncTasks();
+                }
+                else {
+                    stopMySegmentsSyncTasks();
+                }
+            }
+        });
+        function add(matchingKey, readiness, storage) {
+            var mySegmentsSyncTask = (0, mySegmentsSyncTask_1.mySegmentsSyncTaskFactory)(serviceApi.fetchMemberships, storage, readiness, settings, matchingKey);
+            // smart ready
+            function smartReady(metadata) {
+                if (!readiness.isReady() && !(0, AbstractDefinitionsCacheSync_1.usesSegmentsSync)(storage))
+                    readiness.segments.emit(constants_1.SDK_SEGMENTS_ARRIVED, metadata);
+            }
+            if (!(0, AbstractDefinitionsCacheSync_1.usesSegmentsSync)(storage))
+                setTimeout(smartReady, 0);
+            else
+                readiness.definitions.once(constants_1.SDK_DEFINITIONS_ARRIVED, smartReady);
+            mySegmentsSyncTasks[matchingKey] = mySegmentsSyncTask;
+            return mySegmentsSyncTask;
+        }
+        return {
+            definitionsSyncTask: definitionsSyncTask,
+            segmentsSyncTask: mySegmentsSyncTask,
+            // Start periodic fetching (polling)
+            start: function () {
+                log.info(constants_2.POLLING_START);
+                definitionsSyncTask.start();
+                if ((0, AbstractDefinitionsCacheSync_1.usesSegmentsSync)(storage))
+                    startMySegmentsSyncTasks();
+            },
+            // Stop periodic fetching (polling)
+            stop: function () {
+                log.info(constants_2.POLLING_STOP);
+                if (definitionsSyncTask.isRunning())
+                    definitionsSyncTask.stop();
+                stopMySegmentsSyncTasks();
+            },
+            // Used by SyncManager to know if running in polling mode.
+            isRunning: definitionsSyncTask.isRunning,
+            // fetch definitions and segments
+            syncAll: function () {
+                var promises = [definitionsSyncTask.execute()];
+                (0, lang_1.forOwn)(mySegmentsSyncTasks, function (mySegmentsSyncTask) {
+                    promises.push(mySegmentsSyncTask.execute());
+                });
+                return Promise.all(promises);
+            },
+            // Support for handling mySegments sync of multiple clients
+            add: add,
+            remove: function (matchingKey) {
+                delete mySegmentsSyncTasks[matchingKey];
+            },
+            get: function (matchingKey) {
+                return mySegmentsSyncTasks[matchingKey];
+            }
+        };
     };
 }
 exports.pollingManagerCSFactory = pollingManagerCSFactory;

package/cjs/sync/polling/pollingManagerSS.js

@@ -1,49 +1,57 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.pollingManagerSSFactory = void 0;
-var splitsSyncTask_1 = require("./syncTasks/splitsSyncTask");
+var definitionsSyncTask_1 = require("./syncTasks/definitionsSyncTask");
 var segmentsSyncTask_1 = require("./syncTasks/segmentsSyncTask");
 var constants_1 = require("../../logger/constants");
+var segmentChangesFetcher_1 = require("./fetchers/segmentChangesFetcher");
+var splitChangesFetcher_1 = require("./fetchers/splitChangesFetcher");
 /**
  * Expose start / stop mechanism for pulling data from services.
  */
-function pollingManagerSSFactory(params) {
-    var splitApi = params.splitApi, storage = params.storage, readiness = params.readiness, settings = params.settings;
-    var log = settings.log;
-    var splitsSyncTask = (0, splitsSyncTask_1.splitsSyncTaskFactory)(splitApi.fetchSplitChanges, storage, readiness, settings);
-    var segmentsSyncTask = (0, segmentsSyncTask_1.segmentsSyncTaskFactory)(splitApi.fetchSegmentChanges, storage, readiness, settings);
-    return {
-        splitsSyncTask: splitsSyncTask,
-        segmentsSyncTask: segmentsSyncTask,
-        // Start periodic fetching (polling)
-        start: function () {
-            log.info(constants_1.POLLING_START);
-            log.debug(constants_1.LOG_PREFIX_SYNC_POLLING + "Splits will be refreshed each ".concat(settings.scheduler.featuresRefreshRate, " millis"));
-            log.debug(constants_1.LOG_PREFIX_SYNC_POLLING + "Segments will be refreshed each ".concat(settings.scheduler.segmentsRefreshRate, " millis"));
-            var startingUp = splitsSyncTask.start();
-            if (startingUp) {
-                startingUp.then(function () {
-                    if (splitsSyncTask.isRunning())
-                        segmentsSyncTask.start();
+function pollingManagerSSFactory(definitionFetcherFactory, segmentFetcherFactory) {
+    if (definitionFetcherFactory === void 0) { definitionFetcherFactory = splitChangesFetcher_1.splitChangesFetcherFactory; }
+    if (segmentFetcherFactory === void 0) { segmentFetcherFactory = function (params) { return (0, segmentChangesFetcher_1.segmentChangesFetcherFactory)(params.serviceApi.fetchSegmentChanges); }; }
+    return function (params) {
+        var storage = params.storage, readiness = params.readiness, settings = params.settings;
+        var log = settings.log;
+        var definitionChangesFetcher = definitionFetcherFactory(params);
+        var segmentChangesFetcher = segmentFetcherFactory(params);
+        var segmentsSyncTask = (0, segmentsSyncTask_1.segmentsSyncTaskFactory)(segmentChangesFetcher, storage, readiness, settings);
+        var definitionsSyncTask = (0, definitionsSyncTask_1.definitionsSyncTaskFactory)(definitionChangesFetcher, storage, readiness, settings, segmentsSyncTask);
+        return {
+            definitionsSyncTask: definitionsSyncTask,
+            segmentsSyncTask: segmentsSyncTask,
+            // Start periodic fetching (polling)
+            start: function () {
+                log.info(constants_1.POLLING_START);
+                log.debug(constants_1.LOG_PREFIX_SYNC_POLLING + "".concat(definitionChangesFetcher.type, " will be refreshed each ").concat(settings.scheduler.featuresRefreshRate, " millis"));
+                log.debug(constants_1.LOG_PREFIX_SYNC_POLLING + "segments will be refreshed each ".concat(settings.scheduler.segmentsRefreshRate, " millis"));
+                var startingUp = definitionsSyncTask.start();
+                if (startingUp) {
+                    startingUp.then(function () {
+                        if (definitionsSyncTask.isRunning())
+                            segmentsSyncTask.start();
+                    });
+                }
+            },
+            // Stop periodic fetching (polling)
+            stop: function () {
+                log.info(constants_1.POLLING_STOP);
+                if (definitionsSyncTask.isRunning())
+                    definitionsSyncTask.stop();
+                if (segmentsSyncTask.isRunning())
+                    segmentsSyncTask.stop();
+            },
+            // Used by SyncManager to know if running in polling mode.
+            isRunning: definitionsSyncTask.isRunning,
+            syncAll: function () {
+                // fetch definitions and segments. There is no need to catch this promise (`DefinitionChangesUpdater` is always resolved with a boolean value)
+                return definitionsSyncTask.execute().then(function () {
+                    return segmentsSyncTask.execute();
                 });
             }
-        },
-        // Stop periodic fetching (polling)
-        stop: function () {
-            log.info(constants_1.POLLING_STOP);
-            if (splitsSyncTask.isRunning())
-                splitsSyncTask.stop();
-            if (segmentsSyncTask.isRunning())
-                segmentsSyncTask.stop();
-        },
-        // Used by SyncManager to know if running in polling mode.
-        isRunning: splitsSyncTask.isRunning,
-        syncAll: function () {
-            // fetch splits and segments. There is no need to catch this promise (`SplitChangesUpdater` is always resolved with a boolean value)
-            return splitsSyncTask.execute().then(function () {
-                return segmentsSyncTask.execute();
-            });
-        }
+        };
     };
 }
 exports.pollingManagerSSFactory = pollingManagerSSFactory;

package/cjs/sync/polling/syncTasks/definitionsSyncTask.js

@@ -0,0 +1,13 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.definitionsSyncTaskFactory = void 0;
+var syncTask_1 = require("../../syncTask");
+var definitionChangesUpdater_1 = require("../updaters/definitionChangesUpdater");
+/**
+ * Creates a sync task that periodically executes a `definitionChangesUpdater` task
+ */
+function definitionsSyncTaskFactory(definitionChangesFetcher, storage, readiness, settings, segmentsSyncTask // undefined for client-side
+) {
+    return (0, syncTask_1.syncTaskFactory)(settings.log, (0, definitionChangesUpdater_1.definitionChangesUpdaterFactory)(settings.log, definitionChangesFetcher, storage, settings.sync.__splitFiltersValidation, readiness.definitions, settings.startup.requestTimeoutBeforeReady, settings.startup.retriesOnFailureBeforeReady, segmentsSyncTask), settings.scheduler.featuresRefreshRate, 'definitionChangesUpdater');
+}
+exports.definitionsSyncTaskFactory = definitionsSyncTaskFactory;

package/cjs/sync/polling/syncTasks/segmentsSyncTask.js

@@ -2,12 +2,11 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.segmentsSyncTaskFactory = void 0;
 var syncTask_1 = require("../../syncTask");
-var segmentChangesFetcher_1 = require("../fetchers/segmentChangesFetcher");
 var segmentChangesUpdater_1 = require("../updaters/segmentChangesUpdater");
 /**
  * Creates a sync task that periodically executes a `segmentChangesUpdater` task
  */
-function segmentsSyncTaskFactory(fetchSegmentChanges, storage, readiness, settings) {
-    return (0, syncTask_1.syncTaskFactory)(settings.log, (0, segmentChangesUpdater_1.segmentChangesUpdaterFactory)(settings.log, (0, segmentChangesFetcher_1.segmentChangesFetcherFactory)(fetchSegmentChanges), storage.segments, readiness, settings.startup.requestTimeoutBeforeReady, settings.startup.retriesOnFailureBeforeReady), settings.scheduler.segmentsRefreshRate, 'segmentChangesUpdater');
+function segmentsSyncTaskFactory(segmentChangesFetcher, storage, readiness, settings) {
+    return (0, syncTask_1.syncTaskFactory)(settings.log, (0, segmentChangesUpdater_1.segmentChangesUpdaterFactory)(settings.log, segmentChangesFetcher, storage.segments, readiness, settings.startup.requestTimeoutBeforeReady, settings.startup.retriesOnFailureBeforeReady), settings.scheduler.segmentsRefreshRate, 'segmentChangesUpdater');
 }
 exports.segmentsSyncTaskFactory = segmentsSyncTaskFactory;