@splitsoftware/splitio-commons 3.1.1-rc.1 → 3.1.1-rc.10

package/esm/storages/inRedis/{DefinitionsCacheInRedis.js → SplitsCacheInRedis.js}

@@ -1,7 +1,7 @@
 import { __extends, __spreadArray } from "tslib";
 import { isFiniteNumber, isNaNNumber } from '../../utils/lang';
 import { LOG_PREFIX } from './constants';
-import { AbstractDefinitionsCacheAsync } from '../AbstractDefinitionsCacheAsync';
+import { AbstractSplitsCacheAsync } from '../AbstractSplitsCacheAsync';
 import { returnDifference } from '../../utils/lang/sets';
 /**
  * Discard errors for an answer of multiple operations.
@@ -14,17 +14,17 @@ function processPipelineAnswer(results) {
     }, []) : [];
 }
 /**
- * IDefinitionsCacheAsync implementation that stores definitions in Redis.
+ * ISplitsCacheAsync implementation that stores split definitions in Redis.
  * Supported by Node.js
  */
-var DefinitionsCacheInRedis = /** @class */ (function (_super) {
-    __extends(DefinitionsCacheInRedis, _super);
-    function DefinitionsCacheInRedis(log, keys, redis, splitFiltersValidation) {
+var SplitsCacheInRedis = /** @class */ (function (_super) {
+    __extends(SplitsCacheInRedis, _super);
+    function SplitsCacheInRedis(log, keys, redis, splitFiltersValidation) {
         var _this = _super.call(this) || this;
         _this.log = log;
         _this.redis = redis;
         _this.keys = keys;
-        _this.setsFilter = splitFiltersValidation ? splitFiltersValidation.groupedFilters.bySet : [];
+        _this.flagSetsFilter = splitFiltersValidation ? splitFiltersValidation.groupedFilters.bySet : [];
         // There is no need to listen for redis 'error' event, because in that case ioredis calls will be rejected and handled by redis storage adapters.
         // But it is done just to avoid getting the ioredis message `Unhandled error event`.
         _this.redis.on('error', function (e) {
@@ -35,104 +35,104 @@ var DefinitionsCacheInRedis = /** @class */ (function (_super) {
         });
         return _this;
     }
-    DefinitionsCacheInRedis.prototype._decrementCounts = function (definition) {
+    SplitsCacheInRedis.prototype._decrementCounts = function (split) {
         var _this = this;
-        var ttKey = this.keys.buildTrafficTypeKey(definition.trafficTypeName);
+        var ttKey = this.keys.buildTrafficTypeKey(split.trafficTypeName);
         return this.redis.decr(ttKey).then(function (count) {
             if (count === 0)
                 return _this.redis.del(ttKey);
         });
     };
-    DefinitionsCacheInRedis.prototype._incrementCounts = function (definition) {
-        var ttKey = this.keys.buildTrafficTypeKey(definition.trafficTypeName);
+    SplitsCacheInRedis.prototype._incrementCounts = function (split) {
+        var ttKey = this.keys.buildTrafficTypeKey(split.trafficTypeName);
         return this.redis.incr(ttKey);
     };
-    DefinitionsCacheInRedis.prototype._updateSets = function (definitionName, setsOfRemovedDefinition, setsOfAddedDefinition) {
+    SplitsCacheInRedis.prototype._updateFlagSets = function (featureFlagName, flagSetsOfRemovedFlag, flagSetsOfAddedFlag) {
         var _this = this;
-        var removeFromSets = returnDifference(setsOfRemovedDefinition, setsOfAddedDefinition);
-        var addToSets = returnDifference(setsOfAddedDefinition, setsOfRemovedDefinition);
-        if (this.setsFilter.length > 0) {
-            addToSets = addToSets.filter(function (set) {
-                return _this.setsFilter.some(function (filterSet) { return filterSet === set; });
+        var removeFromFlagSets = returnDifference(flagSetsOfRemovedFlag, flagSetsOfAddedFlag);
+        var addToFlagSets = returnDifference(flagSetsOfAddedFlag, flagSetsOfRemovedFlag);
+        if (this.flagSetsFilter.length > 0) {
+            addToFlagSets = addToFlagSets.filter(function (flagSet) {
+                return _this.flagSetsFilter.some(function (filterFlagSet) { return filterFlagSet === flagSet; });
             });
         }
-        var items = [definitionName];
-        return Promise.all(__spreadArray(__spreadArray([], removeFromSets.map(function (setName) { return _this.redis.srem(_this.keys.buildSetKey(setName), items); }), true), addToSets.map(function (setName) { return _this.redis.sadd(_this.keys.buildSetKey(setName), items); }), true));
+        var items = [featureFlagName];
+        return Promise.all(__spreadArray(__spreadArray([], removeFromFlagSets.map(function (flagSetName) { return _this.redis.srem(_this.keys.buildFlagSetKey(flagSetName), items); }), true), addToFlagSets.map(function (flagSetName) { return _this.redis.sadd(_this.keys.buildFlagSetKey(flagSetName), items); }), true));
     };
     /**
-     * Add a given definition.
+     * Add a given split.
      * The returned promise is resolved when the operation success
      * or rejected if it fails (e.g., redis operation fails)
      */
-    DefinitionsCacheInRedis.prototype.add = function (definition) {
+    SplitsCacheInRedis.prototype.addSplit = function (split) {
         var _this = this;
-        var name = definition.name;
-        var definitionKey = this.keys.buildDefinitionKey(name);
-        return this.redis.get(definitionKey).then(function (definitionFromStorage) {
+        var name = split.name;
+        var splitKey = this.keys.buildSplitKey(name);
+        return this.redis.get(splitKey).then(function (splitFromStorage) {
             // handling parsing error
-            var parsedPreviousDefinition, stringifiedNewDefinition;
+            var parsedPreviousSplit, stringifiedNewSplit;
             try {
-                parsedPreviousDefinition = definitionFromStorage ? JSON.parse(definitionFromStorage) : undefined;
-                stringifiedNewDefinition = JSON.stringify(definition);
+                parsedPreviousSplit = splitFromStorage ? JSON.parse(splitFromStorage) : undefined;
+                stringifiedNewSplit = JSON.stringify(split);
             }
             catch (e) {
                 throw new Error('Error parsing feature flag definition: ' + e);
             }
-            return _this.redis.set(definitionKey, stringifiedNewDefinition).then(function () {
+            return _this.redis.set(splitKey, stringifiedNewSplit).then(function () {
                 // avoid unnecessary increment/decrement operations
-                if (parsedPreviousDefinition && parsedPreviousDefinition.trafficTypeName === definition.trafficTypeName)
+                if (parsedPreviousSplit && parsedPreviousSplit.trafficTypeName === split.trafficTypeName)
                     return;
                 // update traffic type counts
-                return _this._incrementCounts(definition).then(function () {
-                    if (parsedPreviousDefinition)
-                        return _this._decrementCounts(parsedPreviousDefinition);
+                return _this._incrementCounts(split).then(function () {
+                    if (parsedPreviousSplit)
+                        return _this._decrementCounts(parsedPreviousSplit);
                 });
-            }).then(function () { return _this._updateSets(name, parsedPreviousDefinition && parsedPreviousDefinition.sets, definition.sets); });
+            }).then(function () { return _this._updateFlagSets(name, parsedPreviousSplit && parsedPreviousSplit.sets, split.sets); });
         }).then(function () { return true; });
     };
     /**
-     * Remove a given definition.
-     * The returned promise is resolved when the operation success, with true or false indicating if the definition existed (and was removed) or not.
+     * Remove a given split.
+     * The returned promise is resolved when the operation success, with true or false indicating if the split existed (and was removed) or not.
      * or rejected if it fails (e.g., redis operation fails).
      */
-    DefinitionsCacheInRedis.prototype.remove = function (name) {
+    SplitsCacheInRedis.prototype.removeSplit = function (name) {
         var _this = this;
-        return this.get(name).then(function (definition) {
-            if (definition) {
-                return _this._decrementCounts(definition).then(function () { return _this._updateSets(name, definition.sets); });
+        return this.getSplit(name).then(function (split) {
+            if (split) {
+                return _this._decrementCounts(split).then(function () { return _this._updateFlagSets(name, split.sets); });
             }
         }).then(function () {
-            return _this.redis.del(_this.keys.buildDefinitionKey(name)).then(function (status) { return status === 1; });
+            return _this.redis.del(_this.keys.buildSplitKey(name)).then(function (status) { return status === 1; });
         });
     };
     /**
-     * Get definition or null if it's not defined.
+     * Get split definition or null if it's not defined.
      * Returned promise is rejected if redis operation fails.
      */
-    DefinitionsCacheInRedis.prototype.get = function (name) {
+    SplitsCacheInRedis.prototype.getSplit = function (name) {
         if (this.redisError) {
             this.log.error(LOG_PREFIX + this.redisError);
             return Promise.reject(this.redisError);
         }
-        return this.redis.get(this.keys.buildDefinitionKey(name))
-            .then(function (maybeDefinition) { return maybeDefinition && JSON.parse(maybeDefinition); });
+        return this.redis.get(this.keys.buildSplitKey(name))
+            .then(function (maybeSplit) { return maybeSplit && JSON.parse(maybeSplit); });
     };
     /**
      * Set till number.
      * The returned promise is resolved when the operation success,
      * or rejected if it fails.
      */
-    DefinitionsCacheInRedis.prototype.setChangeNumber = function (changeNumber) {
-        return this.redis.set(this.keys.buildDefinitionsTillKey(), changeNumber + '').then(function (status) { return status === 'OK'; });
+    SplitsCacheInRedis.prototype.setChangeNumber = function (changeNumber) {
+        return this.redis.set(this.keys.buildSplitsTillKey(), changeNumber + '').then(function (status) { return status === 'OK'; });
     };
     /**
      * Get till number or -1 if it's not defined.
      * The returned promise is resolved with the changeNumber or -1 if it doesn't exist or a redis operation fails.
      * The promise will never be rejected.
      */
-    DefinitionsCacheInRedis.prototype.getChangeNumber = function () {
+    SplitsCacheInRedis.prototype.getChangeNumber = function () {
         var _this = this;
-        return this.redis.get(this.keys.buildDefinitionsTillKey()).then(function (value) {
+        return this.redis.get(this.keys.buildSplitsTillKey()).then(function (value) {
             var i = parseInt(value, 10);
             return isNaNNumber(i) ? -1 : i;
         }).catch(function (e) {
@@ -141,44 +141,44 @@ var DefinitionsCacheInRedis = /** @class */ (function (_super) {
         });
     };
     /**
-     * Get list of all definitions.
-     * The returned promise is resolved with the list of definitions,
+     * Get list of all split definitions.
+     * The returned promise is resolved with the list of split definitions,
      * or rejected if redis operation fails.
      */
     // @TODO we need to benchmark which is the maximun number of commands we could pipeline without kill redis performance.
-    DefinitionsCacheInRedis.prototype.getAll = function () {
+    SplitsCacheInRedis.prototype.getAll = function () {
         var _this = this;
-        return this.redis.keys(this.keys.searchPatternForDefinitionKeys())
+        return this.redis.keys(this.keys.searchPatternForSplitKeys())
             .then(function (listOfKeys) { return _this.redis.pipeline(listOfKeys.map(function (k) { return ['get', k]; })).exec(); })
             .then(processPipelineAnswer)
-            .then(function (definitions) { return definitions.map(function (definition) {
-            return JSON.parse(definition);
+            .then(function (splitDefinitions) { return splitDefinitions.map(function (splitDefinition) {
+            return JSON.parse(splitDefinition);
         }); });
     };
     /**
-     * Get list of definition names.
-     * The returned promise is resolved with the list of names,
+     * Get list of split names.
+     * The returned promise is resolved with the list of split names,
      * or rejected if redis operation fails.
      */
-    DefinitionsCacheInRedis.prototype.getNames = function () {
+    SplitsCacheInRedis.prototype.getSplitNames = function () {
         var _this = this;
-        return this.redis.keys(this.keys.searchPatternForDefinitionKeys()).then(function (listOfKeys) { return listOfKeys.map(_this.keys.extractKey); });
+        return this.redis.keys(this.keys.searchPatternForSplitKeys()).then(function (listOfKeys) { return listOfKeys.map(_this.keys.extractKey); });
     };
     /**
-     * Get list of definition names related to a given list of set names.
-     * The returned promise is resolved with the list of names per set,
+     * Get list of feature flag names related to a given list of flag set names.
+     * The returned promise is resolved with the list of feature flag names per flag set,
      * or rejected if the pipelined redis operation fails (e.g., timeout).
     */
-    DefinitionsCacheInRedis.prototype.getNamesBySets = function (sets) {
+    SplitsCacheInRedis.prototype.getNamesByFlagSets = function (flagSets) {
         var _this = this;
-        return this.redis.pipeline(sets.map(function (set) { return ['smembers', _this.keys.buildSetKey(set)]; })).exec()
+        return this.redis.pipeline(flagSets.map(function (flagSet) { return ['smembers', _this.keys.buildFlagSetKey(flagSet)]; })).exec()
             .then(function (results) { return results ? results.map(function (_a, index) {
             var e = _a[0], value = _a[1];
             if (e === null)
                 return value;
-            _this.log.error(LOG_PREFIX + "Could not read result from get members of set ".concat(sets[index], " due to an error: ").concat(e));
+            _this.log.error(LOG_PREFIX + "Could not read result from get members of flag set ".concat(flagSets[index], " due to an error: ").concat(e));
         }) : []; })
-            .then(function (namesBySets) { return namesBySets.map(function (namesBySet) { return new Set(namesBySet); }); });
+            .then(function (namesByFlagSets) { return namesByFlagSets.map(function (namesByFlagSet) { return new Set(namesByFlagSet); }); });
     };
     /**
      * Check traffic type existence.
@@ -186,7 +186,7 @@ var DefinitionsCacheInRedis = /** @class */ (function (_super) {
      * In case of redis operation failure, the promise resolves with a true value, assuming that the TT might exist.
      * It will never be rejected.
      */
-    DefinitionsCacheInRedis.prototype.trafficTypeExists = function (trafficType) {
+    SplitsCacheInRedis.prototype.trafficTypeExists = function (trafficType) {
         var _this = this;
         // If there is a number there should be > 0, otherwise the TT is considered as not existent.
         return this.redis.get(this.keys.buildTrafficTypeKey(trafficType))
@@ -207,34 +207,34 @@ var DefinitionsCacheInRedis = /** @class */ (function (_super) {
         });
     };
     // @TODO remove or implement. It is not being used.
-    DefinitionsCacheInRedis.prototype.clear = function () {
+    SplitsCacheInRedis.prototype.clear = function () {
         return Promise.resolve();
     };
     /**
-     * Fetches multiple definitions.
+     * Fetches multiple splits definitions.
      * Returned promise is rejected if redis operation fails.
      */
-    DefinitionsCacheInRedis.prototype.getMany = function (names) {
+    SplitsCacheInRedis.prototype.getSplits = function (names) {
         var _a;
         var _this = this;
         if (this.redisError) {
             this.log.error(LOG_PREFIX + this.redisError);
             return Promise.reject(this.redisError);
         }
-        var keys = names.map(function (name) { return _this.keys.buildDefinitionKey(name); });
-        return (_a = this.redis).mget.apply(_a, keys).then(function (stringifiedDefinitions) {
-            var definitions = {};
+        var keys = names.map(function (name) { return _this.keys.buildSplitKey(name); });
+        return (_a = this.redis).mget.apply(_a, keys).then(function (splitDefinitions) {
+            var splits = {};
             names.forEach(function (name, idx) {
-                var definition = stringifiedDefinitions[idx];
-                definitions[name] = definition && JSON.parse(definition);
+                var split = splitDefinitions[idx];
+                splits[name] = split && JSON.parse(split);
             });
-            return Promise.resolve(definitions);
+            return Promise.resolve(splits);
         })
             .catch(function (e) {
             _this.log.error(LOG_PREFIX + "Could not grab feature flags due to an error: ".concat(e, "."));
             return Promise.reject(e);
         });
     };
-    return DefinitionsCacheInRedis;
-}(AbstractDefinitionsCacheAsync));
-export { DefinitionsCacheInRedis };
+    return SplitsCacheInRedis;
+}(AbstractSplitsCacheAsync));
+export { SplitsCacheInRedis };

package/esm/storages/inRedis/index.js

@@ -1,6 +1,6 @@
 import { validatePrefix } from '../KeyBuilder';
 import { KeyBuilderSS } from '../KeyBuilderSS';
-import { DefinitionsCacheInRedis } from './DefinitionsCacheInRedis';
+import { SplitsCacheInRedis } from './SplitsCacheInRedis';
 import { SegmentsCacheInRedis } from './SegmentsCacheInRedis';
 import { ImpressionsCacheInRedis } from './ImpressionsCacheInRedis';
 import { EventsCacheInRedis } from './EventsCacheInRedis';
@@ -45,7 +45,7 @@ export function InRedisStorage(options) {
             telemetry.recordConfig();
         });
         return {
-            definitions: new DefinitionsCacheInRedis(log, keys, redisClient, settings.sync.__splitFiltersValidation),
+            splits: new SplitsCacheInRedis(log, keys, redisClient, settings.sync.__splitFiltersValidation),
             rbSegments: new RBSegmentsCacheInRedis(log, keys, redisClient),
             segments: new SegmentsCacheInRedis(log, keys, redisClient),
             impressions: new ImpressionsCacheInRedis(log, keys.buildImpressionsKey(), redisClient, metadata),

package/esm/storages/pluggable/RBSegmentsCachePluggable.js

@@ -31,7 +31,7 @@ var RBSegmentsCachePluggable = /** @class */ (function () {
                 return _this.wrapper.set(key, stringifiedNewRBSegment).then(function () { return true; });
             })),
             Promise.all(toRemove.map(function (toRemove) {
-                var key = _this.keys.buildRBSegmentKey(toRemove);
+                var key = _this.keys.buildRBSegmentKey(toRemove.name);
                 return _this.wrapper.del(key);
             }))
         ]).then(function (_a) {

package/esm/storages/pluggable/SplitsCachePluggable.js

@@ -0,0 +1,209 @@
+import { __extends, __spreadArray } from "tslib";
+import { isFiniteNumber, isNaNNumber } from '../../utils/lang';
+import { LOG_PREFIX } from './constants';
+import { AbstractSplitsCacheAsync } from '../AbstractSplitsCacheAsync';
+import { returnDifference } from '../../utils/lang/sets';
+/**
+ * ISplitsCacheAsync implementation for pluggable storages.
+ */
+var SplitsCachePluggable = /** @class */ (function (_super) {
+    __extends(SplitsCachePluggable, _super);
+    /**
+     * Create a SplitsCache that uses a storage wrapper.
+     * @param log -  Logger instance.
+     * @param keys -  Key builder.
+     * @param wrapper -  Adapted wrapper storage.
+     */
+    function SplitsCachePluggable(log, keys, wrapper, splitFiltersValidation) {
+        var _this = _super.call(this) || this;
+        _this.log = log;
+        _this.keys = keys;
+        _this.wrapper = wrapper;
+        _this.flagSetsFilter = splitFiltersValidation ? splitFiltersValidation.groupedFilters.bySet : [];
+        return _this;
+    }
+    SplitsCachePluggable.prototype._decrementCounts = function (split) {
+        var _this = this;
+        var ttKey = this.keys.buildTrafficTypeKey(split.trafficTypeName);
+        return this.wrapper.decr(ttKey).then(function (count) {
+            if (count === 0)
+                return _this.wrapper.del(ttKey);
+        });
+    };
+    SplitsCachePluggable.prototype._incrementCounts = function (split) {
+        var ttKey = this.keys.buildTrafficTypeKey(split.trafficTypeName);
+        return this.wrapper.incr(ttKey);
+    };
+    SplitsCachePluggable.prototype._updateFlagSets = function (featureFlagName, flagSetsOfRemovedFlag, flagSetsOfAddedFlag) {
+        var _this = this;
+        var removeFromFlagSets = returnDifference(flagSetsOfRemovedFlag, flagSetsOfAddedFlag);
+        var addToFlagSets = returnDifference(flagSetsOfAddedFlag, flagSetsOfRemovedFlag);
+        if (this.flagSetsFilter.length > 0) {
+            addToFlagSets = addToFlagSets.filter(function (flagSet) {
+                return _this.flagSetsFilter.some(function (filterFlagSet) { return filterFlagSet === flagSet; });
+            });
+        }
+        var items = [featureFlagName];
+        return Promise.all(__spreadArray(__spreadArray([], removeFromFlagSets.map(function (flagSetName) { return _this.wrapper.removeItems(_this.keys.buildFlagSetKey(flagSetName), items); }), true), addToFlagSets.map(function (flagSetName) { return _this.wrapper.addItems(_this.keys.buildFlagSetKey(flagSetName), items); }), true));
+    };
+    /**
+     * Add a given split.
+     * The returned promise is resolved when the operation success
+     * or rejected if it fails (e.g., wrapper operation fails)
+     */
+    SplitsCachePluggable.prototype.addSplit = function (split) {
+        var _this = this;
+        var name = split.name;
+        var splitKey = this.keys.buildSplitKey(name);
+        return this.wrapper.get(splitKey).then(function (splitFromStorage) {
+            // handling parsing error
+            var parsedPreviousSplit, stringifiedNewSplit;
+            try {
+                parsedPreviousSplit = splitFromStorage ? JSON.parse(splitFromStorage) : undefined;
+                stringifiedNewSplit = JSON.stringify(split);
+            }
+            catch (e) {
+                throw new Error('Error parsing feature flag definition: ' + e);
+            }
+            return _this.wrapper.set(splitKey, stringifiedNewSplit).then(function () {
+                // avoid unnecessary increment/decrement operations
+                if (parsedPreviousSplit && parsedPreviousSplit.trafficTypeName === split.trafficTypeName)
+                    return;
+                // update traffic type counts
+                return _this._incrementCounts(split).then(function () {
+                    if (parsedPreviousSplit)
+                        return _this._decrementCounts(parsedPreviousSplit);
+                });
+            }).then(function () { return _this._updateFlagSets(name, parsedPreviousSplit && parsedPreviousSplit.sets, split.sets); });
+        }).then(function () { return true; });
+    };
+    /**
+     * Remove a given split.
+     * The returned promise is resolved when the operation success, with a boolean indicating if the split existed or not.
+     * or rejected if it fails (e.g., wrapper operation fails).
+     */
+    SplitsCachePluggable.prototype.removeSplit = function (name) {
+        var _this = this;
+        return this.getSplit(name).then(function (split) {
+            if (split) {
+                return _this._decrementCounts(split).then(function () { return _this._updateFlagSets(name, split.sets); });
+            }
+        }).then(function () {
+            return _this.wrapper.del(_this.keys.buildSplitKey(name));
+        });
+    };
+    /**
+     * Get split.
+     * The returned promise is resolved with the split definition or null if it's not defined,
+     * or rejected if wrapper operation fails.
+     */
+    SplitsCachePluggable.prototype.getSplit = function (name) {
+        return this.wrapper.get(this.keys.buildSplitKey(name))
+            .then(function (maybeSplit) { return maybeSplit && JSON.parse(maybeSplit); });
+    };
+    /**
+     * Get list of splits.
+     * The returned promise is resolved with a map of split names to their split definition or null if it's not defined,
+     * or rejected if wrapper operation fails.
+     */
+    SplitsCachePluggable.prototype.getSplits = function (names) {
+        var _this = this;
+        var keys = names.map(function (name) { return _this.keys.buildSplitKey(name); });
+        return this.wrapper.getMany(keys).then(function (splitDefinitions) {
+            var splits = {};
+            names.forEach(function (name, idx) {
+                var split = splitDefinitions[idx];
+                splits[name] = split && JSON.parse(split);
+            });
+            return Promise.resolve(splits);
+        });
+    };
+    /**
+     * Get list of all split definitions.
+     * The returned promise is resolved with the list of split definitions,
+     * or rejected if wrapper operation fails.
+     */
+    SplitsCachePluggable.prototype.getAll = function () {
+        var _this = this;
+        return this.wrapper.getKeysByPrefix(this.keys.buildSplitKeyPrefix())
+            .then(function (listOfKeys) { return _this.wrapper.getMany(listOfKeys); })
+            .then(function (splitDefinitions) { return splitDefinitions.map(function (splitDefinition) {
+            return JSON.parse(splitDefinition);
+        }); });
+    };
+    /**
+     * Get list of split names.
+     * The returned promise is resolved with the list of split names,
+     * or rejected if wrapper operation fails.
+     */
+    SplitsCachePluggable.prototype.getSplitNames = function () {
+        var _this = this;
+        return this.wrapper.getKeysByPrefix(this.keys.buildSplitKeyPrefix()).then(function (listOfKeys) { return listOfKeys.map(_this.keys.extractKey); });
+    };
+    /**
+     * Get list of feature flag names related to a given list of flag set names.
+     * The returned promise is resolved with the list of feature flag names per flag set.
+     * It never rejects (If there is a wrapper error for some flag set, an empty set is returned for it).
+     */
+    SplitsCachePluggable.prototype.getNamesByFlagSets = function (flagSets) {
+        var _this = this;
+        return Promise.all(flagSets.map(function (flagSet) {
+            var flagSetKey = _this.keys.buildFlagSetKey(flagSet);
+            return _this.wrapper.getItems(flagSetKey).catch(function () { return []; });
+        })).then(function (namesByFlagSets) { return namesByFlagSets.map(function (namesByFlagSet) { return new Set(namesByFlagSet); }); });
+    };
+    /**
+     * Check traffic type existence.
+     * The returned promise is resolved with a boolean indicating whether the TT exist or not.
+     * In case of wrapper operation failures, the promise resolves with a true value, assuming that the TT might exist.
+     * It will never be rejected.
+     */
+    SplitsCachePluggable.prototype.trafficTypeExists = function (trafficType) {
+        var _this = this;
+        // If there is a number there should be > 0, otherwise the TT is considered as not existent.
+        return this.wrapper.get(this.keys.buildTrafficTypeKey(trafficType))
+            .then(function (ttCount) {
+            if (ttCount === null)
+                return false; // if entry doesn't exist, means that TT doesn't exist
+            ttCount = parseInt(ttCount, 10);
+            if (!isFiniteNumber(ttCount) || ttCount < 0) {
+                _this.log.info(LOG_PREFIX + "Could not validate traffic type existence of ".concat(trafficType, " due to data corruption of some sorts."));
+                return false;
+            }
+            return ttCount > 0;
+        }).catch(function (e) {
+            _this.log.error(LOG_PREFIX + "Could not validate traffic type existence of ".concat(trafficType, " due to an error: ").concat(e, "."));
+            // If there is an error, bypass the validation so the event can get tracked.
+            return true;
+        });
+    };
+    /**
+     * Set till number.
+     * The returned promise is resolved when the operation success,
+     * or rejected if it fails (e.g., wrapper operation fails).
+     */
+    SplitsCachePluggable.prototype.setChangeNumber = function (changeNumber) {
+        return this.wrapper.set(this.keys.buildSplitsTillKey(), changeNumber + '');
+    };
+    /**
+     * Get till number or -1 if it's not defined.
+     * The returned promise is resolved with the changeNumber or -1 if it doesn't exist or a wrapper operation fails.
+     * The promise will never be rejected.
+     */
+    SplitsCachePluggable.prototype.getChangeNumber = function () {
+        var _this = this;
+        return this.wrapper.get(this.keys.buildSplitsTillKey()).then(function (value) {
+            var i = parseInt(value, 10);
+            return isNaNNumber(i) ? -1 : i;
+        }).catch(function (e) {
+            _this.log.error(LOG_PREFIX + 'Could not retrieve changeNumber from storage. Error: ' + e);
+            return -1;
+        });
+    };
+    // @TODO implement if required by DataLoader or producer mode
+    SplitsCachePluggable.prototype.clear = function () {
+        return Promise.resolve(true);
+    };
+    return SplitsCachePluggable;
+}(AbstractSplitsCacheAsync));
+export { SplitsCachePluggable };

package/esm/storages/pluggable/index.js

@@ -1,6 +1,6 @@
 import { __assign } from "tslib";
 import { KeyBuilderSS } from '../KeyBuilderSS';
-import { DefinitionsCachePluggable } from './DefinitionsCachePluggable';
+import { SplitsCachePluggable } from './SplitsCachePluggable';
 import { SegmentsCachePluggable } from './SegmentsCachePluggable';
 import { ImpressionsCachePluggable } from './ImpressionsCachePluggable';
 import { EventsCachePluggable } from './EventsCachePluggable';
@@ -103,7 +103,7 @@ export function PluggableStorage(options) {
             return e; // Propagate error for shared clients
         });
         return {
-            definitions: new DefinitionsCachePluggable(log, keys, wrapper, settings.sync.__splitFiltersValidation),
+            splits: new SplitsCachePluggable(log, keys, wrapper, settings.sync.__splitFiltersValidation),
             rbSegments: new RBSegmentsCachePluggable(log, keys, wrapper),
             segments: new SegmentsCachePluggable(log, keys, wrapper),
             impressions: isPartialConsumer ? new ImpressionsCacheInMemory(impressionsQueueSize) : new ImpressionsCachePluggable(log, keys.buildImpressionsKey(), wrapper, metadata),

package/esm/storages/setRolloutPlan.js

@@ -20,12 +20,12 @@ export function validateRolloutPlan(log, settings) {
  * Otherwise, the storage is handled as a server-side storage (segments is an instance of SegmentsCache).
  */
 export function setRolloutPlan(log, rolloutPlan, storage, matchingKey) {
-    var definitions = storage.definitions, rbSegments = storage.rbSegments, segments = storage.segments, largeSegments = storage.largeSegments;
+    var splits = storage.splits, rbSegments = storage.rbSegments, segments = storage.segments, largeSegments = storage.largeSegments;
     var _a = rolloutPlan.splitChanges, ff = _a.ff, rbs = _a.rbs;
     log.debug("storage: set feature flags and segments".concat(matchingKey ? " for key ".concat(matchingKey) : ''));
-    if (definitions && ff) {
-        definitions.clear();
-        definitions.update(ff.d || [], [], ff.t);
+    if (splits && ff) {
+        splits.clear();
+        splits.update(ff.d || [], [], ff.t);
     }
     if (rbSegments && rbs) {
         rbSegments.clear();

package/esm/storages/utils.js

@@ -24,7 +24,6 @@ export function impressionsToJSON(impressions, metadata) {
                 m: impression.time,
                 pt: impression.pt,
                 properties: impression.properties
-                // @TODO set entityType
             }
         };
         return JSON.stringify(impressionWithMetadata);

package/esm/sync/offline/syncTasks/fromObjectSyncTask.js

@@ -1,13 +1,13 @@
 import { forOwn } from '../../../utils/lang';
 import { syncTaskFactory } from '../../syncTask';
 import { CONTROL } from '../../../utils/constants';
-import { SDK_DEFINITIONS_ARRIVED, SDK_SEGMENTS_ARRIVED, SDK_DEFINITIONS_CACHE_LOADED, FLAGS_UPDATE, SEGMENTS_UPDATE } from '../../../readiness/constants';
+import { SDK_SPLITS_ARRIVED, SDK_SEGMENTS_ARRIVED, SDK_SPLITS_CACHE_LOADED, FLAGS_UPDATE, SEGMENTS_UPDATE } from '../../../readiness/constants';
 import { SYNC_OFFLINE_DATA, ERROR_SYNC_OFFLINE_LOADING } from '../../../logger/constants';
 /**
  * Offline equivalent of `splitChangesUpdaterFactory`
  */
 export function fromObjectUpdaterFactory(splitsParser, storage, readiness, settings) {
-    var log = settings.log, definitions = storage.definitions;
+    var log = settings.log, splitsCache = storage.splits;
     var startingUp = true;
     return function objectUpdater() {
         var splits = [];
@@ -36,16 +36,16 @@ export function fromObjectUpdaterFactory(splitsParser, storage, readiness, setti
                 });
             });
             return Promise.all([
-                definitions.clear(),
-                definitions.update(splits, [], Date.now())
+                splitsCache.clear(),
+                splitsCache.update(splits, [], Date.now())
             ]).then(function () {
-                readiness.definitions.emit(SDK_DEFINITIONS_ARRIVED, { type: FLAGS_UPDATE, names: [] });
+                readiness.splits.emit(SDK_SPLITS_ARRIVED, { type: FLAGS_UPDATE, names: [] });
                 if (startingUp) {
                     startingUp = false;
                     Promise.resolve(storage.validateCache ? storage.validateCache() : { initialCacheLoad: true /* Fallback: assume initial load when validateCache doesn't exist */ }).then(function (cacheMetadata) {
                         // Emits SDK_READY_FROM_CACHE
                         if (!cacheMetadata.initialCacheLoad) {
-                            readiness.definitions.emit(SDK_DEFINITIONS_CACHE_LOADED, cacheMetadata);
+                            readiness.splits.emit(SDK_SPLITS_CACHE_LOADED, cacheMetadata);
                         }
                         // Emits SDK_READY
                         readiness.segments.emit(SDK_SEGMENTS_ARRIVED, { type: SEGMENTS_UPDATE, names: [] });