@splitsoftware/splitio-commons 3.1.1-rc.0 → 3.1.1-rc.10

package/esm/sync/polling/fetchers/splitChangesFetcher.js

@@ -1,31 +1,22 @@
 import { FLAG_SPEC_VERSION } from '../../../utils/constants';
 import { base } from '../../../utils/settingsValidation';
-import { LOG_PREFIX_SYNC } from '../../../logger/constants';
+import { LOG_PREFIX_SYNC_SPLITS } from '../../../logger/constants';
 import { checkIfServerSide } from '../../../utils/key';
 var PROXY_CHECK_INTERVAL_MILLIS_CS = 60 * 60 * 1000; // 1 hour in Client Side
 var PROXY_CHECK_INTERVAL_MILLIS_SS = 24 * PROXY_CHECK_INTERVAL_MILLIS_CS; // 24 hours in Server Side
 function sdkEndpointOverridden(settings) {
     return settings.urls.sdk !== base.urls.sdk;
 }
-function isSplitChangesLegacyResponse(data) {
-    return data.splits != null;
-}
-function partitionByStatus(items, till, since) {
-    var updated = [], removed = [];
-    items.forEach(function (item) { return item.status === 'ARCHIVED' ? removed.push(item.name) : updated.push(item); });
-    return { updated: updated, removed: removed, till: till, since: since };
-}
 /**
  * Factory of SplitChanges fetcher.
  * SplitChanges fetcher is a wrapper around `splitChanges` API service that parses the response and handle errors.
  */
 // @TODO breaking: drop support for Split Proxy below v5.10.0 and simplify the implementation
-export function splitChangesFetcherFactory(params) {
-    var fetchSplitChanges = params.serviceApi.fetchSplitChanges, settings = params.settings, storage = params.storage;
+export function splitChangesFetcherFactory(fetchSplitChanges, settings, storage) {
     var log = settings.log;
     var PROXY_CHECK_INTERVAL_MILLIS = checkIfServerSide(settings) ? PROXY_CHECK_INTERVAL_MILLIS_SS : PROXY_CHECK_INTERVAL_MILLIS_CS;
     var lastProxyCheckTimestamp;
-    function splitChangesFetcher(since, noCache, till, rbSince, 
+    return function splitChangesFetcher(since, noCache, till, rbSince, 
     // Optional decorator for `fetchSplitChanges` promise, such as timeout or time tracker
     decorator) {
         // Recheck proxy
@@ -36,7 +27,7 @@ export function splitChangesFetcherFactory(params) {
             .catch(function (err) {
             // Handle proxy error with spec 1.3
             if ((!err.statusCode || err.statusCode === 400) && sdkEndpointOverridden(settings) && settings.sync.flagSpecVersion === FLAG_SPEC_VERSION) {
-                log.error(LOG_PREFIX_SYNC + 'Proxy error detected. Retrying with spec 1.2. If you are using Split Proxy, please upgrade to latest version');
+                log.error(LOG_PREFIX_SYNC_SPLITS + 'Proxy error detected. Retrying with spec 1.2. If you are using Split Proxy, please upgrade to latest version');
                 lastProxyCheckTimestamp = Date.now();
                 settings.sync.flagSpecVersion = '1.2'; // fallback to 1.2 spec
                 return fetchSplitChanges(since, noCache, till); // retry request without rbSince
@@ -49,26 +40,26 @@ export function splitChangesFetcherFactory(params) {
             .then(function (resp) { return resp.json(); })
             .then(function (data) {
             // Using flag spec version 1.2 or below
-            if (isSplitChangesLegacyResponse(data)) {
-                return { d: partitionByStatus(data.splits || [], data.till, data.since) };
+            if (data.splits) {
+                return {
+                    ff: {
+                        d: data.splits,
+                        s: data.since,
+                        t: data.till
+                    }
+                };
             }
             // Proxy recovery
             if (lastProxyCheckTimestamp) {
-                log.info(LOG_PREFIX_SYNC + 'Proxy error recovered');
+                log.info(LOG_PREFIX_SYNC_SPLITS + 'Proxy error recovered');
                 lastProxyCheckTimestamp = undefined;
                 return splitChangesFetcher(-1, undefined, undefined, -1)
                     .then(function (splitChangesResponse) {
-                    return Promise.all([storage.definitions.clear(), storage.rbSegments.clear()])
+                    return Promise.all([storage.splits.clear(), storage.rbSegments.clear()])
                         .then(function () { return splitChangesResponse; });
                 });
             }
-            var ff = data.ff, rbs = data.rbs;
-            return {
-                d: (ff === null || ff === void 0 ? void 0 : ff.d) ? partitionByStatus(ff.d, ff.t, ff.s) : undefined,
-                rbs: (rbs === null || rbs === void 0 ? void 0 : rbs.d) ? partitionByStatus(rbs.d, rbs.t, rbs.s) : undefined,
-            };
+            return data;
         });
-    }
-    splitChangesFetcher.type = 'feature flags';
-    return splitChangesFetcher;
+    };
 }

package/esm/sync/polling/pollingManagerCS.js

@@ -1,18 +1,18 @@
 import { forOwn } from '../../utils/lang';
 import { mySegmentsSyncTaskFactory } from './syncTasks/mySegmentsSyncTask';
-import { definitionsSyncTaskFactory } from './syncTasks/definitionsSyncTask';
+import { splitsSyncTaskFactory } from './syncTasks/splitsSyncTask';
 import { getMatching } from '../../utils/key';
-import { SDK_DEFINITIONS_ARRIVED, SDK_SEGMENTS_ARRIVED } from '../../readiness/constants';
+import { SDK_SPLITS_ARRIVED, SDK_SEGMENTS_ARRIVED } from '../../readiness/constants';
 import { POLLING_SMART_PAUSING, POLLING_START, POLLING_STOP } from '../../logger/constants';
-import { usesSegmentsSync } from '../../storages/AbstractDefinitionsCacheSync';
+import { usesSegmentsSync } from '../../storages/AbstractSplitsCacheSync';
 /**
  * Expose start / stop mechanism for polling data from services.
  * For client-side API with multiple clients.
  */
-export function pollingManagerCSFactory(params, definitionChangesFetcher) {
-    var serviceApi = params.serviceApi, storage = params.storage, readiness = params.readiness, settings = params.settings;
+export function pollingManagerCSFactory(params) {
+    var splitApi = params.splitApi, storage = params.storage, readiness = params.readiness, settings = params.settings;
     var log = settings.log;
-    var definitionsSyncTask = definitionsSyncTaskFactory(definitionChangesFetcher, storage, readiness, settings);
+    var splitsSyncTask = splitsSyncTaskFactory(splitApi.fetchSplitChanges, storage, readiness, settings, true);
     // Map of matching keys to their corresponding MySegmentsSyncTask.
     var mySegmentsSyncTasks = {};
     var matchingKey = getMatching(settings.core.key);
@@ -29,8 +29,8 @@ export function pollingManagerCSFactory(params, definitionChangesFetcher) {
         });
     }
     // smart pausing
-    readiness.definitions.on(SDK_DEFINITIONS_ARRIVED, function () {
-        if (!definitionsSyncTask.isRunning())
+    readiness.splits.on(SDK_SPLITS_ARRIVED, function () {
+        if (!splitsSyncTask.isRunning())
             return; // noop if not doing polling
         var usingSegments = usesSegmentsSync(storage);
         if (usingSegments !== mySegmentsSyncTask.isRunning()) {
@@ -44,7 +44,7 @@ export function pollingManagerCSFactory(params, definitionChangesFetcher) {
         }
     });
     function add(matchingKey, readiness, storage) {
-        var mySegmentsSyncTask = mySegmentsSyncTaskFactory(serviceApi.fetchMemberships, storage, readiness, settings, matchingKey);
+        var mySegmentsSyncTask = mySegmentsSyncTaskFactory(splitApi.fetchMemberships, storage, readiness, settings, matchingKey);
         // smart ready
         function smartReady(metadata) {
             if (!readiness.isReady() && !usesSegmentsSync(storage))
@@ -53,32 +53,32 @@ export function pollingManagerCSFactory(params, definitionChangesFetcher) {
         if (!usesSegmentsSync(storage))
             setTimeout(smartReady, 0);
         else
-            readiness.definitions.once(SDK_DEFINITIONS_ARRIVED, smartReady);
+            readiness.splits.once(SDK_SPLITS_ARRIVED, smartReady);
         mySegmentsSyncTasks[matchingKey] = mySegmentsSyncTask;
         return mySegmentsSyncTask;
     }
     return {
-        definitionsSyncTask: definitionsSyncTask,
+        splitsSyncTask: splitsSyncTask,
         segmentsSyncTask: mySegmentsSyncTask,
         // Start periodic fetching (polling)
         start: function () {
             log.info(POLLING_START);
-            definitionsSyncTask.start();
+            splitsSyncTask.start();
             if (usesSegmentsSync(storage))
                 startMySegmentsSyncTasks();
         },
         // Stop periodic fetching (polling)
         stop: function () {
             log.info(POLLING_STOP);
-            if (definitionsSyncTask.isRunning())
-                definitionsSyncTask.stop();
+            if (splitsSyncTask.isRunning())
+                splitsSyncTask.stop();
             stopMySegmentsSyncTasks();
         },
         // Used by SyncManager to know if running in polling mode.
-        isRunning: definitionsSyncTask.isRunning,
-        // fetch definitions and segments
+        isRunning: splitsSyncTask.isRunning,
+        // fetch splits and segments
         syncAll: function () {
-            var promises = [definitionsSyncTask.execute()];
+            var promises = [splitsSyncTask.execute()];
             forOwn(mySegmentsSyncTasks, function (mySegmentsSyncTask) {
                 promises.push(mySegmentsSyncTask.execute());
             });

package/esm/sync/polling/pollingManagerSS.js

@@ -1,26 +1,26 @@
-import { definitionsSyncTaskFactory } from './syncTasks/definitionsSyncTask';
+import { splitsSyncTaskFactory } from './syncTasks/splitsSyncTask';
 import { segmentsSyncTaskFactory } from './syncTasks/segmentsSyncTask';
 import { POLLING_START, POLLING_STOP, LOG_PREFIX_SYNC_POLLING } from '../../logger/constants';
 /**
  * Expose start / stop mechanism for pulling data from services.
  */
-export function pollingManagerSSFactory(params, definitionChangesFetcher, segmentChangesFetcher) {
-    var storage = params.storage, readiness = params.readiness, settings = params.settings;
+export function pollingManagerSSFactory(params) {
+    var splitApi = params.splitApi, storage = params.storage, readiness = params.readiness, settings = params.settings;
     var log = settings.log;
-    var segmentsSyncTask = segmentsSyncTaskFactory(segmentChangesFetcher, storage, readiness, settings);
-    var definitionsSyncTask = definitionsSyncTaskFactory(definitionChangesFetcher, storage, readiness, settings, segmentsSyncTask);
+    var splitsSyncTask = splitsSyncTaskFactory(splitApi.fetchSplitChanges, storage, readiness, settings);
+    var segmentsSyncTask = segmentsSyncTaskFactory(splitApi.fetchSegmentChanges, storage, readiness, settings);
     return {
-        definitionsSyncTask: definitionsSyncTask,
+        splitsSyncTask: splitsSyncTask,
         segmentsSyncTask: segmentsSyncTask,
         // Start periodic fetching (polling)
         start: function () {
             log.info(POLLING_START);
-            log.debug(LOG_PREFIX_SYNC_POLLING + "".concat(definitionChangesFetcher.type, " will be refreshed each ").concat(settings.scheduler.featuresRefreshRate, " millis"));
-            log.debug(LOG_PREFIX_SYNC_POLLING + "segments will be refreshed each ".concat(settings.scheduler.segmentsRefreshRate, " millis"));
-            var startingUp = definitionsSyncTask.start();
+            log.debug(LOG_PREFIX_SYNC_POLLING + "Splits will be refreshed each ".concat(settings.scheduler.featuresRefreshRate, " millis"));
+            log.debug(LOG_PREFIX_SYNC_POLLING + "Segments will be refreshed each ".concat(settings.scheduler.segmentsRefreshRate, " millis"));
+            var startingUp = splitsSyncTask.start();
             if (startingUp) {
                 startingUp.then(function () {
-                    if (definitionsSyncTask.isRunning())
+                    if (splitsSyncTask.isRunning())
                         segmentsSyncTask.start();
                 });
             }
@@ -28,16 +28,16 @@ export function pollingManagerSSFactory(params, definitionChangesFetcher, segmen
         // Stop periodic fetching (polling)
         stop: function () {
             log.info(POLLING_STOP);
-            if (definitionsSyncTask.isRunning())
-                definitionsSyncTask.stop();
+            if (splitsSyncTask.isRunning())
+                splitsSyncTask.stop();
             if (segmentsSyncTask.isRunning())
                 segmentsSyncTask.stop();
         },
         // Used by SyncManager to know if running in polling mode.
-        isRunning: definitionsSyncTask.isRunning,
+        isRunning: splitsSyncTask.isRunning,
         syncAll: function () {
-            // fetch definitions and segments. There is no need to catch this promise (`DefinitionChangesUpdater` is always resolved with a boolean value)
-            return definitionsSyncTask.execute().then(function () {
+            // fetch splits and segments. There is no need to catch this promise (`SplitChangesUpdater` is always resolved with a boolean value)
+            return splitsSyncTask.execute().then(function () {
                 return segmentsSyncTask.execute();
             });
         }

package/esm/sync/polling/syncTasks/segmentsSyncTask.js

@@ -1,8 +1,9 @@
 import { syncTaskFactory } from '../../syncTask';
+import { segmentChangesFetcherFactory } from '../fetchers/segmentChangesFetcher';
 import { segmentChangesUpdaterFactory } from '../updaters/segmentChangesUpdater';
 /**
  * Creates a sync task that periodically executes a `segmentChangesUpdater` task
  */
-export function segmentsSyncTaskFactory(segmentChangesFetcher, storage, readiness, settings) {
-    return syncTaskFactory(settings.log, segmentChangesUpdaterFactory(settings.log, segmentChangesFetcher, storage.segments, readiness, settings.startup.requestTimeoutBeforeReady, settings.startup.retriesOnFailureBeforeReady), settings.scheduler.segmentsRefreshRate, 'segmentChangesUpdater');
+export function segmentsSyncTaskFactory(fetchSegmentChanges, storage, readiness, settings) {
+    return syncTaskFactory(settings.log, segmentChangesUpdaterFactory(settings.log, segmentChangesFetcherFactory(fetchSegmentChanges), storage.segments, readiness, settings.startup.requestTimeoutBeforeReady, settings.startup.retriesOnFailureBeforeReady), settings.scheduler.segmentsRefreshRate, 'segmentChangesUpdater');
 }

package/esm/sync/polling/syncTasks/splitsSyncTask.js

@@ -0,0 +1,9 @@
+import { syncTaskFactory } from '../../syncTask';
+import { splitChangesFetcherFactory } from '../fetchers/splitChangesFetcher';
+import { splitChangesUpdaterFactory } from '../updaters/splitChangesUpdater';
+/**
+ * Creates a sync task that periodically executes a `splitChangesUpdater` task
+ */
+export function splitsSyncTaskFactory(fetchSplitChanges, storage, readiness, settings, isClientSide) {
+    return syncTaskFactory(settings.log, splitChangesUpdaterFactory(settings.log, splitChangesFetcherFactory(fetchSplitChanges, settings, storage), storage, settings.sync.__splitFiltersValidation, readiness.splits, settings.startup.requestTimeoutBeforeReady, settings.startup.retriesOnFailureBeforeReady, isClientSide), settings.scheduler.featuresRefreshRate, 'splitChangesUpdater');
+}

package/esm/sync/polling/updaters/mySegmentsUpdater.js

@@ -1,8 +1,8 @@
 import { timeout } from '../../../utils/promise/timeout';
 import { SDK_SEGMENTS_ARRIVED, SEGMENTS_UPDATE } from '../../../readiness/constants';
-import { SYNC_FETCH_RETRY } from '../../../logger/constants';
+import { SYNC_MYSEGMENTS_FETCH_RETRY } from '../../../logger/constants';
 import { MEMBERSHIPS_LS_UPDATE } from '../../streaming/constants';
-import { usesSegmentsSync } from '../../../storages/AbstractDefinitionsCacheSync';
+import { usesSegmentsSync } from '../../../storages/AbstractSplitsCacheSync';
 /**
  * factory of MySegments updater, a task that:
  *  - fetches mySegments using `mySegmentsFetcher`
@@ -53,7 +53,7 @@ export function mySegmentsUpdaterFactory(log, mySegmentsFetcher, storage, segmen
         return updaterPromise.catch(function (error) {
             if (startingUp && retriesOnFailureBeforeReady > retry) {
                 retry += 1;
-                log.warn(SYNC_FETCH_RETRY, ['memberships', retry, error]);
+                log.warn(SYNC_MYSEGMENTS_FETCH_RETRY, [retry, error]);
                 return _mySegmentsUpdater(retry); // no need to forward `segmentList` and `noCache` params
             }
             else {

package/esm/sync/polling/updaters/segmentChangesUpdater.js

@@ -1,5 +1,5 @@
 import { SDK_SEGMENTS_ARRIVED, SEGMENTS_UPDATE } from '../../../readiness/constants';
-import { LOG_PREFIX_INSTANTIATION, LOG_PREFIX_SYNC } from '../../../logger/constants';
+import { LOG_PREFIX_INSTANTIATION, LOG_PREFIX_SYNC_SEGMENTS } from '../../../logger/constants';
 import { timeout } from '../../../utils/promise/timeout';
 /**
  * Factory of SegmentChanges updater, a task that:
@@ -20,7 +20,7 @@ export function segmentChangesUpdaterFactory(log, segmentChangesFetcher, segment
         return promise;
     }
     function updateSegment(segmentName, noCache, till, fetchOnlyNew, retries) {
-        log.debug("".concat(LOG_PREFIX_SYNC, "Processing segment ").concat(segmentName));
+        log.debug("".concat(LOG_PREFIX_SYNC_SEGMENTS, "Processing segment ").concat(segmentName));
         var sincePromise = Promise.resolve(segments.getChangeNumber(segmentName));
         return sincePromise.then(function (since) {
             // if fetchOnlyNew flag, avoid processing already fetched segments
@@ -28,14 +28,14 @@ export function segmentChangesUpdaterFactory(log, segmentChangesFetcher, segment
                 false :
                 segmentChangesFetcher(since || -1, segmentName, noCache, till, _promiseDecorator).then(function (changes) {
                     return Promise.all(changes.map(function (x) {
-                        log.debug("".concat(LOG_PREFIX_SYNC, "Processing ").concat(segmentName, " with till = ").concat(x.till, ". Added: ").concat(x.added.length, ". Removed: ").concat(x.removed.length));
+                        log.debug("".concat(LOG_PREFIX_SYNC_SEGMENTS, "Processing ").concat(segmentName, " with till = ").concat(x.till, ". Added: ").concat(x.added.length, ". Removed: ").concat(x.removed.length));
                         return segments.update(segmentName, x.added, x.removed, x.till);
                     })).then(function (updates) {
                         return updates.some(function (update) { return update; });
                     });
                 }).catch(function (error) {
                     if (retries) {
-                        log.warn("".concat(LOG_PREFIX_SYNC, "Retrying fetch of segment ").concat(segmentName, " (attempt #").concat(retries, "). Reason: ").concat(error));
+                        log.warn("".concat(LOG_PREFIX_SYNC_SEGMENTS, "Retrying fetch of segment ").concat(segmentName, " (attempt #").concat(retries, "). Reason: ").concat(error));
                         return updateSegment(segmentName, noCache, till, fetchOnlyNew, retries - 1);
                     }
                     throw error;
@@ -54,7 +54,7 @@ export function segmentChangesUpdaterFactory(log, segmentChangesFetcher, segment
      * @param till - till target for the provided segmentName, for CDN bypass.
      */
     return function segmentChangesUpdater(fetchOnlyNew, segmentName, noCache, till) {
-        log.debug("".concat(LOG_PREFIX_SYNC, "Started segments update"));
+        log.debug("".concat(LOG_PREFIX_SYNC_SEGMENTS, "Started segments update"));
         // If not a segment name provided, read list of available segments names to be updated.
         var segmentsPromise = Promise.resolve(segmentName ? [segmentName] : segments.getRegisteredSegments());
         return segmentsPromise.then(function (segmentNames) {
@@ -63,7 +63,7 @@ export function segmentChangesUpdaterFactory(log, segmentChangesFetcher, segment
                 // if at least one segment fetch succeeded, mark segments ready
                 if (shouldUpdateFlags.some(function (update) { return update; }) || readyOnAlreadyExistentState) {
                     readyOnAlreadyExistentState = false;
-                    if (readiness && !fetchOnlyNew) {
+                    if (readiness) {
                         var metadata = {
                             type: SEGMENTS_UPDATE,
                             names: []
@@ -84,7 +84,7 @@ export function segmentChangesUpdaterFactory(log, segmentChangesFetcher, segment
                 log.error("".concat(LOG_PREFIX_INSTANTIATION, ": you passed a client-side type authorizationKey, please grab an SDK Key from Harness FME UI that is of type server-side."));
             }
             else {
-                log.warn("".concat(LOG_PREFIX_SYNC, "Error while doing fetch of segments. ").concat(error));
+                log.warn("".concat(LOG_PREFIX_SYNC_SEGMENTS, "Error while doing fetch of segments. ").concat(error));
             }
             return false;
         });

package/esm/sync/polling/updaters/{definitionChangesUpdater.js → splitChangesUpdater.js}

@@ -1,10 +1,20 @@
 import { timeout } from '../../../utils/promise/timeout';
-import { SDK_DEFINITIONS_ARRIVED, FLAGS_UPDATE, SEGMENTS_UPDATE, CONFIGS_UPDATE } from '../../../readiness/constants';
-import { SYNC_FETCH, SYNC_UPDATE, SYNC_FETCH_FAILS, SYNC_FETCH_RETRY } from '../../../logger/constants';
+import { SDK_SPLITS_ARRIVED, FLAGS_UPDATE, SEGMENTS_UPDATE } from '../../../readiness/constants';
+import { SYNC_SPLITS_FETCH, SYNC_SPLITS_UPDATE, SYNC_RBS_UPDATE, SYNC_SPLITS_FETCH_FAILS, SYNC_SPLITS_FETCH_RETRY } from '../../../logger/constants';
 import { startsWith } from '../../../utils/lang';
 import { IN_RULE_BASED_SEGMENT, IN_SEGMENT, RULE_BASED_SEGMENT, STANDARD_SEGMENT } from '../../../utils/constants';
 import { setToArray } from '../../../utils/lang/sets';
 import { SPLIT_UPDATE } from '../../streaming/constants';
+// Checks that all registered segments have been fetched (changeNumber !== -1 for every segment).
+// Returns a promise that could be rejected.
+// @TODO review together with Segments and MySegments storage APIs
+function checkAllSegmentsExist(segments) {
+    var registeredSegments = Promise.resolve(segments.getRegisteredSegments());
+    return registeredSegments.then(function (segmentNames) {
+        return Promise.all(segmentNames.map(function (segmentName) { return segments.getChangeNumber(segmentName); }))
+            .then(function (changeNumbers) { return changeNumbers.every(function (changeNumber) { return changeNumber !== undefined; }); });
+    });
+}
 /**
  * Collect segments from a raw FF or RBS definition.
  * Exported for testing purposes.
@@ -33,117 +43,110 @@ export function parseSegments(ruleEntity, matcherType) {
     return segments;
 }
 /**
- * If there are defined filters and one definition doesn't match with them, its status is changed to 'ARCHIVE' to avoid storing it
+ * If there are defined filters and one feature flag doesn't match with them, its status is changed to 'ARCHIVE' to avoid storing it
  * If there is `bySet` filter, `byName` and `byPrefix` filters are ignored
  *
- * @param definition - definition to be evaluated
+ * @param featureFlag - feature flag to be evaluated
  * @param filters - splitFiltersValidation bySet | byName
  */
-function matchFilters(definition, filters) {
+function matchFilters(featureFlag, filters) {
     var _a = filters.groupedFilters, setsFilter = _a.bySet, namesFilter = _a.byName, prefixFilter = _a.byPrefix;
     if (setsFilter.length > 0)
-        return definition.sets && definition.sets.some(function (definitionSet) { return setsFilter.indexOf(definitionSet) > -1; });
+        return featureFlag.sets && featureFlag.sets.some(function (featureFlagSet) { return setsFilter.indexOf(featureFlagSet) > -1; });
     var namesFilterConfigured = namesFilter.length > 0;
     var prefixFilterConfigured = prefixFilter.length > 0;
     if (!namesFilterConfigured && !prefixFilterConfigured)
         return true;
-    var matchNames = namesFilterConfigured && namesFilter.indexOf(definition.name) > -1;
-    var matchPrefix = prefixFilterConfigured && prefixFilter.some(function (prefix) { return startsWith(definition.name, prefix); });
+    var matchNames = namesFilterConfigured && namesFilter.indexOf(featureFlag.name) > -1;
+    var matchPrefix = prefixFilterConfigured && prefixFilter.some(function (prefix) { return startsWith(featureFlag.name, prefix); });
     return matchNames || matchPrefix;
 }
 /**
- * Given the list of definitions from /splitChanges or /configs endpoint, it returns the mutations,
- * i.e., an object with added definitions, removed definitions, and used segments.
+ * Given the list of splits from /splitChanges endpoint, it returns the mutations,
+ * i.e., an object with added splits, removed splits and used segments.
  * Exported for testing purposes.
  */
-export function computeMutation(update, segments, filters) {
-    return update.updated.reduce(function (accum, ruleEntity) {
-        if (!filters || matchFilters(ruleEntity, filters)) {
-            accum.updated.push(ruleEntity);
+export function computeMutation(rules, segments, filters) {
+    return rules.reduce(function (accum, ruleEntity) {
+        if (ruleEntity.status !== 'ARCHIVED' && (!filters || matchFilters(ruleEntity, filters))) {
+            accum.added.push(ruleEntity);
             parseSegments(ruleEntity).forEach(function (segmentName) {
                 segments.add(segmentName);
             });
         }
         else {
-            accum.removed.push(ruleEntity.name);
+            accum.removed.push(ruleEntity);
         }
         accum.names.push(ruleEntity.name);
         return accum;
-    }, { updated: [], removed: update.removed, names: update.removed.slice() });
-}
-function convertInstantUpdateToDefinitionChanges(instantUpdate) {
-    var payload = instantUpdate.payload, changeNumber = instantUpdate.changeNumber;
-    return payload.status === 'ARCHIVED' ?
-        { till: changeNumber, updated: [], removed: [payload.name] } :
-        { till: changeNumber, updated: [payload], removed: [] };
+    }, { added: [], removed: [], names: [] });
 }
 /**
- * Factory of DefinitionChanges updater, a task that:
- *  - fetches definition changes using `definitionChangesFetcher`
- *  - updates definitions storage
- *  - uses `definitionsEventEmitter` to emit events related to definition data updates
+ * factory of SplitChanges updater, a task that:
+ *  - fetches split changes using `splitChangesFetcher`
+ *  - updates `splitsCache`
+ *  - uses `splitsEventEmitter` to emit events related to split data updates
  *
  * @param log -  Logger instance
- * @param definitionChangesFetcher -  Fetcher of `/splitChanges` or `/configs`
- * @param definitions -  Definitions storage, with sync or async methods
+ * @param splitChangesFetcher -  Fetcher of `/splitChanges`
+ * @param splits -  Splits storage, with sync or async methods
  * @param segments -  Segments storage, with sync or async methods
- * @param definitionsEventEmitter -  Optional readiness manager. Not required for synchronizer or producer mode.
+ * @param splitsEventEmitter -  Optional readiness manager. Not required for synchronizer or producer mode.
  * @param requestTimeoutBeforeReady -  How long the updater will wait for the request to timeout. Default 0, i.e., never timeout.
- * @param retriesOnFailureBeforeReady -  How many retries on `/splitChanges` or `/configs` we the updater do in case of failure or timeout. Default 0, i.e., no retries.
+ * @param retriesOnFailureBeforeReady -  How many retries on `/splitChanges` we the updater do in case of failure or timeout. Default 0, i.e., no retries.
  */
-export function definitionChangesUpdaterFactory(log, definitionChangesFetcher, storage, splitFiltersValidation, definitionsEventEmitter, requestTimeoutBeforeReady, retriesOnFailureBeforeReady, segmentsSyncTask // undefined for client-side
-) {
+export function splitChangesUpdaterFactory(log, splitChangesFetcher, storage, splitFiltersValidation, splitsEventEmitter, requestTimeoutBeforeReady, retriesOnFailureBeforeReady, isClientSide) {
     if (requestTimeoutBeforeReady === void 0) { requestTimeoutBeforeReady = 0; }
     if (retriesOnFailureBeforeReady === void 0) { retriesOnFailureBeforeReady = 0; }
-    var definitions = storage.definitions, rbSegments = storage.rbSegments, segments = storage.segments;
+    var splits = storage.splits, rbSegments = storage.rbSegments, segments = storage.segments;
     var startingUp = true;
-    /** timeout decorator for `definitionChangesFetcher` promise  */
+    /** timeout decorator for `splitChangesFetcher` promise  */
     function _promiseDecorator(promise) {
         if (startingUp && requestTimeoutBeforeReady)
             promise = timeout(requestTimeoutBeforeReady, promise);
         return promise;
     }
     /**
-     * DefinitionChanges updater returns a promise that resolves with a `false` boolean value if it fails to fetch definitions or synchronize them with the storage.
+     * SplitChanges updater returns a promise that resolves with a `false` boolean value if it fails to fetch splits or synchronize them with the storage.
      * Returned promise will not be rejected.
      *
      * @param noCache - true to revalidate data to fetch
      * @param till - query param to bypass CDN requests
      */
-    return function definitionChangesUpdater(noCache, till, instantUpdate) {
+    return function splitChangesUpdater(noCache, till, instantUpdate) {
         /**
-         * @param since - current changeNumber at definitionsCache
+         * @param since - current changeNumber at splitsCache
          * @param retry - current number of retry attempts
          */
-        function _definitionChangesUpdater(sinces, retry) {
+        function _splitChangesUpdater(sinces, retry) {
             if (retry === void 0) { retry = 0; }
             var since = sinces[0], rbSince = sinces[1];
-            log.debug(SYNC_FETCH, [definitionChangesFetcher.type, since, rbSince]);
+            log.debug(SYNC_SPLITS_FETCH, sinces);
             return Promise.resolve(instantUpdate ?
                 instantUpdate.type === SPLIT_UPDATE ?
-                    // IFFU edge case: a change to definition that adds an IN_RULE_BASED_SEGMENT matcher that is not present yet
+                    // IFFU edge case: a change to a flag that adds an IN_RULE_BASED_SEGMENT matcher that is not present yet
                     Promise.resolve(rbSegments.contains(parseSegments(instantUpdate.payload, IN_RULE_BASED_SEGMENT))).then(function (contains) {
                         return contains ?
-                            { d: convertInstantUpdateToDefinitionChanges(instantUpdate) } :
-                            definitionChangesFetcher(since, noCache, till, rbSince, _promiseDecorator);
+                            { ff: { d: [instantUpdate.payload], t: instantUpdate.changeNumber } } :
+                            splitChangesFetcher(since, noCache, till, rbSince, _promiseDecorator);
                     }) :
-                    { rbs: convertInstantUpdateToDefinitionChanges(instantUpdate) } :
-                definitionChangesFetcher(since, noCache, till, rbSince, _promiseDecorator))
-                .then(function (definitionChanges) {
+                    { rbs: { d: [instantUpdate.payload], t: instantUpdate.changeNumber } } :
+                splitChangesFetcher(since, noCache, till, rbSince, _promiseDecorator))
+                .then(function (splitChanges) {
                 var usedSegments = new Set();
-                var updatedDefinitions = [];
+                var updatedFlags = [];
                 var ffUpdate = false;
-                if (definitionChanges.d) {
-                    var _a = computeMutation(definitionChanges.d, usedSegments, splitFiltersValidation), updated = _a.updated, removed = _a.removed, names = _a.names;
-                    updatedDefinitions = names;
-                    log.debug(SYNC_UPDATE, [definitionChangesFetcher.type, updated.length, removed.length]);
-                    ffUpdate = definitions.update(updated, removed, definitionChanges.d.till);
+                if (splitChanges.ff) {
+                    var _a = computeMutation(splitChanges.ff.d || [], usedSegments, splitFiltersValidation), added = _a.added, removed = _a.removed, names = _a.names;
+                    updatedFlags = names;
+                    log.debug(SYNC_SPLITS_UPDATE, [added.length, removed.length]);
+                    ffUpdate = splits.update(added, removed, splitChanges.ff.t);
                 }
                 var rbsUpdate = false;
-                if (definitionChanges.rbs) {
-                    var _b = computeMutation(definitionChanges.rbs, usedSegments), updated = _b.updated, removed = _b.removed;
-                    log.debug(SYNC_UPDATE, ['rule-based segments', updated.length, removed.length]);
-                    rbsUpdate = rbSegments.update(updated, removed, definitionChanges.rbs.till);
+                if (splitChanges.rbs) {
+                    var _b = computeMutation(splitChanges.rbs.d || [], usedSegments), added = _b.added, removed = _b.removed;
+                    log.debug(SYNC_RBS_UPDATE, [added.length, removed.length]);
+                    rbsUpdate = rbSegments.update(added, removed, splitChanges.rbs.t);
                 }
                 return Promise.all([ffUpdate, rbsUpdate,
                     // @TODO if at least 1 segment fetch fails due to 404 and other segments are updated in the storage, SDK_UPDATE is not emitted
@@ -153,18 +156,18 @@ export function definitionChangesUpdaterFactory(log, definitionChangesFetcher, s
                     if (storage.save)
                         storage.save();
                     startingUp = false;
-                    if (definitionsEventEmitter) {
-                        // To emit SDK_DEFINITIONS_ARRIVED for server-side SDK, we must wait for all registered segments to be fetched
-                        return Promise.resolve(!definitionsEventEmitter.definitionsArrived || ((ffChanged || rbsChanged) && (!segmentsSyncTask || segmentsSyncTask.execute(true))))
+                    if (splitsEventEmitter) {
+                        // To emit SDK_SPLITS_ARRIVED for server-side SDK, we must check that all registered segments have been fetched
+                        return Promise.resolve(!splitsEventEmitter.splitsArrived || ((ffChanged || rbsChanged) && (isClientSide || checkAllSegmentsExist(segments))))
                             .catch(function () { return false; } /** noop. just to handle a possible `checkAllSegmentsExist` rejection, before emitting SDK event */)
                             .then(function (emitSplitsArrivedEvent) {
                             // emit SDK events
                             if (emitSplitsArrivedEvent) {
                                 var metadata = {
-                                    type: updatedDefinitions.length > 0 ? definitionChangesFetcher.type === 'configs' ? CONFIGS_UPDATE : FLAGS_UPDATE : SEGMENTS_UPDATE,
-                                    names: updatedDefinitions.length > 0 ? updatedDefinitions : []
+                                    type: updatedFlags.length > 0 ? FLAGS_UPDATE : SEGMENTS_UPDATE,
+                                    names: updatedFlags.length > 0 ? updatedFlags : []
                                 };
-                                definitionsEventEmitter.emit(SDK_DEFINITIONS_ARRIVED, metadata);
+                                splitsEventEmitter.emit(SDK_SPLITS_ARRIVED, metadata);
                             }
                             return true;
                         });
@@ -175,17 +178,17 @@ export function definitionChangesUpdaterFactory(log, definitionChangesFetcher, s
                 .catch(function (error) {
                 if (startingUp && retriesOnFailureBeforeReady > retry) {
                     retry += 1;
-                    log.warn(SYNC_FETCH_RETRY, [definitionChangesFetcher.type, retry, error]);
-                    return _definitionChangesUpdater(sinces, retry);
+                    log.warn(SYNC_SPLITS_FETCH_RETRY, [retry, error]);
+                    return _splitChangesUpdater(sinces, retry);
                 }
                 else {
                     startingUp = false;
-                    log.warn(SYNC_FETCH_FAILS, [definitionChangesFetcher.type, error]);
+                    log.warn(SYNC_SPLITS_FETCH_FAILS, [error]);
                 }
                 return false;
             });
         }
         // `getChangeNumber` never rejects or throws error
-        return Promise.all([definitions.getChangeNumber(), rbSegments.getChangeNumber()]).then(_definitionChangesUpdater);
+        return Promise.all([splits.getChangeNumber(), rbSegments.getChangeNumber()]).then(_splitChangesUpdater);
     };
 }

package/esm/sync/streaming/AuthClient/index.js

@@ -5,7 +5,7 @@ import { hash } from '../../../utils/murmur3/murmur3';
 /**
  * Factory of authentication function.
  *
- * @param fetchAuth - `ServiceApi.fetchAuth` endpoint
+ * @param fetchAuth - `SplitAPI.fetchAuth` endpoint
  */
 export function authenticateFactory(fetchAuth) {
     /**

package/esm/sync/streaming/SSEHandler/NotificationKeeper.js

@@ -1,5 +1,5 @@
 import { CONNECTION_ESTABLISHED, DISABLED, ENABLED, OCCUPANCY_PRI, OCCUPANCY_SEC, PAUSED, STREAMING_STATUS } from '../../../utils/constants';
-import { ControlType, PUSH_SUBSYSTEM_UP, PUSH_NON_RETRYABLE_ERROR, PUSH_SUBSYSTEM_DOWN } from '../constants';
+import { ControlType, PUSH_SUBSYSTEM_UP, PUSH_NONRETRYABLE_ERROR, PUSH_SUBSYSTEM_DOWN } from '../constants';
 var CONTROL_CHANNEL_REGEXS = [/control_pri$/, /control_sec$/];
 var STREAMING_EVENT_TYPES = [OCCUPANCY_PRI, OCCUPANCY_SEC];
 /**
@@ -70,7 +70,7 @@ export function notificationKeeperFactory(pushEmitter, telemetryTracker) {
                         c.cTime = timestamp;
                         if (controlType === ControlType.STREAMING_DISABLED) {
                             telemetryTracker.streamingEvent(STREAMING_STATUS, DISABLED);
-                            pushEmitter.emit(PUSH_NON_RETRYABLE_ERROR);
+                            pushEmitter.emit(PUSH_NONRETRYABLE_ERROR);
                         }
                         else if (hasPublishers) {
                             if (controlType === ControlType.STREAMING_PAUSED && hasResumed) {

package/esm/sync/streaming/SSEHandler/index.js

@@ -1,6 +1,6 @@
 import { errorParser, messageParser } from './NotificationParser';
 import { notificationKeeperFactory } from './NotificationKeeper';
-import { PUSH_RETRYABLE_ERROR, PUSH_NON_RETRYABLE_ERROR, OCCUPANCY, CONTROL, SEGMENT_UPDATE, SPLIT_KILL, SPLIT_UPDATE, MEMBERSHIPS_MS_UPDATE, MEMBERSHIPS_LS_UPDATE, RB_SEGMENT_UPDATE } from '../constants';
+import { PUSH_RETRYABLE_ERROR, PUSH_NONRETRYABLE_ERROR, OCCUPANCY, CONTROL, SEGMENT_UPDATE, SPLIT_KILL, SPLIT_UPDATE, MEMBERSHIPS_MS_UPDATE, MEMBERSHIPS_LS_UPDATE, RB_SEGMENT_UPDATE } from '../constants';
 import { STREAMING_PARSING_ERROR_FAILS, ERROR_STREAMING_SSE, STREAMING_PARSING_MESSAGE_FAILS, STREAMING_NEW_MESSAGE } from '../../../logger/constants';
 import { ABLY_ERROR, NON_REQUESTED, SSE_CONNECTION_ERROR } from '../../../utils/constants';
 /**
@@ -48,7 +48,7 @@ export function SSEHandlerFactory(log, pushEmitter, telemetryTracker) {
                 pushEmitter.emit(PUSH_RETRYABLE_ERROR);
             }
             else {
-                pushEmitter.emit(PUSH_NON_RETRYABLE_ERROR);
+                pushEmitter.emit(PUSH_NONRETRYABLE_ERROR);
             }
         },
         /* NotificationProcessor */