@splitsoftware/splitio-commons 2.2.1-rc.4 → 2.2.1-rc.5

package/CHANGES.txt

@@ -1,4 +1,4 @@
-2.3.0 (May XXX, 2025)
+2.3.0 (May 12, 2025)
  - Added support for targeting rules based on rule-based segments.
  - Updated the Redis storage to:
     - Avoid lazy require of the `ioredis` dependency when the SDK is initialized, and

package/cjs/evaluator/matchers/rbsegment.js

@@ -11,6 +11,8 @@ function ruleBasedSegmentMatcherContext(segmentName, storage, log) {
         var matchingKey = (0, key_1.getMatching)(key);
         function matchConditions(rbsegment) {
             var conditions = rbsegment.conditions || [];
+            if (!conditions.length)
+                return false;
             var evaluator = (0, parser_1.parser)(log, conditions, storage);
             var evaluation = evaluator((0, key_1.keyParser)(key), undefined, undefined, undefined, attributes, splitEvaluator);
             return (0, thenable_1.thenable)(evaluation) ?

package/cjs/services/splitHttpClient.js

@@ -4,6 +4,7 @@ exports.splitHttpClientFactory = void 0;
 var objectAssign_1 = require("../utils/lang/objectAssign");
 var constants_1 = require("../logger/constants");
 var decorateHeaders_1 = require("./decorateHeaders");
+var timeout_1 = require("../utils/promise/timeout");
 var messageNoFetch = 'Global fetch API is not available.';
 /**
  * Factory of Split HTTP clients, which are HTTP clients with predefined headers for Split endpoints.
@@ -43,7 +44,8 @@ function splitHttpClientFactory(settings, _a) {
             // https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#Checking_that_the_fetch_was_successful
             .then(function (response) {
             if (!response.ok) {
-                return response.text().then(function (message) { return Promise.reject({ response: response, message: message }); });
+                // timeout after 100ms because `text()` promise doesn't settle in some implementations and cases (e.g. no content)
+                return (0, timeout_1.timeout)(100, response.text()).then(function (message) { return Promise.reject({ response: response, message: message }); }, function () { return Promise.reject({ response: response }); });
             }
             latencyTracker();
             return response;

package/cjs/sync/polling/fetchers/splitChangesFetcher.js

@@ -6,7 +6,7 @@ var settingsValidation_1 = require("../../../utils/settingsValidation");
 var constants_2 = require("../../../logger/constants");
 var PROXY_CHECK_INTERVAL_MILLIS_CS = 60 * 60 * 1000; // 1 hour in Client Side
 var PROXY_CHECK_INTERVAL_MILLIS_SS = 24 * PROXY_CHECK_INTERVAL_MILLIS_CS; // 24 hours in Server Side
-function sdkEndpointOverriden(settings) {
+function sdkEndpointOverridden(settings) {
     return settings.urls.sdk !== settingsValidation_1.base.urls.sdk;
 }
 /**
@@ -28,8 +28,8 @@ function splitChangesFetcherFactory(fetchSplitChanges, settings, storage) {
         var splitsPromise = fetchSplitChanges(since, noCache, till, settings.sync.flagSpecVersion === constants_1.FLAG_SPEC_VERSION ? rbSince : undefined)
             // Handle proxy error with spec 1.3
             .catch(function (err) {
-            if (err.statusCode === 400 && sdkEndpointOverriden(settings) && settings.sync.flagSpecVersion === constants_1.FLAG_SPEC_VERSION) {
-                log.error(constants_2.LOG_PREFIX_SYNC_SPLITS + 'Proxy error detected. If you are using Split Proxy, please upgrade to latest version');
+            if (err.statusCode === 400 && sdkEndpointOverridden(settings) && settings.sync.flagSpecVersion === constants_1.FLAG_SPEC_VERSION) {
+                log.error(constants_2.LOG_PREFIX_SYNC_SPLITS + 'Proxy error detected. Retrying with spec 1.2. If you are using Split Proxy, please upgrade to latest version');
                 lastProxyCheckTimestamp = Date.now();
                 settings.sync.flagSpecVersion = '1.2'; // fallback to 1.2 spec
                 return fetchSplitChanges(since, noCache, till); // retry request without rbSince

package/esm/evaluator/matchers/rbsegment.js

@@ -8,6 +8,8 @@ export function ruleBasedSegmentMatcherContext(segmentName, storage, log) {
         var matchingKey = getMatching(key);
         function matchConditions(rbsegment) {
             var conditions = rbsegment.conditions || [];
+            if (!conditions.length)
+                return false;
             var evaluator = parser(log, conditions, storage);
             var evaluation = evaluator(keyParser(key), undefined, undefined, undefined, attributes, splitEvaluator);
             return thenable(evaluation) ?

package/esm/services/splitHttpClient.js

@@ -1,6 +1,7 @@
 import { objectAssign } from '../utils/lang/objectAssign';
 import { ERROR_HTTP, ERROR_CLIENT_CANNOT_GET_READY } from '../logger/constants';
 import { decorateHeaders, removeNonISO88591 } from './decorateHeaders';
+import { timeout } from '../utils/promise/timeout';
 var messageNoFetch = 'Global fetch API is not available.';
 /**
  * Factory of Split HTTP clients, which are HTTP clients with predefined headers for Split endpoints.
@@ -40,7 +41,8 @@ export function splitHttpClientFactory(settings, _a) {
             // https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#Checking_that_the_fetch_was_successful
             .then(function (response) {
             if (!response.ok) {
-                return response.text().then(function (message) { return Promise.reject({ response: response, message: message }); });
+                // timeout after 100ms because `text()` promise doesn't settle in some implementations and cases (e.g. no content)
+                return timeout(100, response.text()).then(function (message) { return Promise.reject({ response: response, message: message }); }, function () { return Promise.reject({ response: response }); });
             }
             latencyTracker();
             return response;

package/esm/sync/polling/fetchers/splitChangesFetcher.js

@@ -3,7 +3,7 @@ import { base } from '../../../utils/settingsValidation';
 import { LOG_PREFIX_SYNC_SPLITS } from '../../../logger/constants';
 var PROXY_CHECK_INTERVAL_MILLIS_CS = 60 * 60 * 1000; // 1 hour in Client Side
 var PROXY_CHECK_INTERVAL_MILLIS_SS = 24 * PROXY_CHECK_INTERVAL_MILLIS_CS; // 24 hours in Server Side
-function sdkEndpointOverriden(settings) {
+function sdkEndpointOverridden(settings) {
     return settings.urls.sdk !== base.urls.sdk;
 }
 /**
@@ -25,8 +25,8 @@ export function splitChangesFetcherFactory(fetchSplitChanges, settings, storage)
         var splitsPromise = fetchSplitChanges(since, noCache, till, settings.sync.flagSpecVersion === FLAG_SPEC_VERSION ? rbSince : undefined)
             // Handle proxy error with spec 1.3
             .catch(function (err) {
-            if (err.statusCode === 400 && sdkEndpointOverriden(settings) && settings.sync.flagSpecVersion === FLAG_SPEC_VERSION) {
-                log.error(LOG_PREFIX_SYNC_SPLITS + 'Proxy error detected. If you are using Split Proxy, please upgrade to latest version');
+            if (err.statusCode === 400 && sdkEndpointOverridden(settings) && settings.sync.flagSpecVersion === FLAG_SPEC_VERSION) {
+                log.error(LOG_PREFIX_SYNC_SPLITS + 'Proxy error detected. Retrying with spec 1.2. If you are using Split Proxy, please upgrade to latest version');
                 lastProxyCheckTimestamp = Date.now();
                 settings.sync.flagSpecVersion = '1.2'; // fallback to 1.2 spec
                 return fetchSplitChanges(since, noCache, till); // retry request without rbSince

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@splitsoftware/splitio-commons",
-  "version": "2.2.1-rc.4",
+  "version": "2.2.1-rc.5",
   "description": "Split JavaScript SDK common components",
   "main": "cjs/index.js",
   "module": "esm/index.js",

package/src/dtos/types.ts

@@ -210,8 +210,8 @@ export interface IRBSegment {
   status: 'ACTIVE' | 'ARCHIVED',
   conditions?: ISplitCondition[],
   excluded?: {
-    keys?: string[],
-    segments?: IExcludedSegment[]
+    keys?: string[] | null,
+    segments?: IExcludedSegment[] | null
   }
 }
 

package/src/evaluator/matchers/rbsegment.ts

@@ -15,6 +15,9 @@ export function ruleBasedSegmentMatcherContext(segmentName: string, storage: ISt
 
     function matchConditions(rbsegment: IRBSegment) {
       const conditions = rbsegment.conditions || [];
+
+      if (!conditions.length) return false;
+
       const evaluator = parser(log, conditions, storage);
 
       const evaluation = evaluator(

package/src/services/splitHttpClient.ts

@@ -4,6 +4,7 @@ import { ERROR_HTTP, ERROR_CLIENT_CANNOT_GET_READY } from '../logger/constants';
 import { ISettings } from '../types';
 import { IPlatform } from '../sdkFactory/types';
 import { decorateHeaders, removeNonISO88591 } from './decorateHeaders';
+import { timeout } from '../utils/promise/timeout';
 
 const messageNoFetch = 'Global fetch API is not available.';
 
@@ -45,7 +46,8 @@ export function splitHttpClientFactory(settings: ISettings, { getOptions, getFet
       // https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch#Checking_that_the_fetch_was_successful
       .then(response => {
         if (!response.ok) {
-          return response.text().then(message => Promise.reject({ response, message }));
+          // timeout after 100ms because `text()` promise doesn't settle in some implementations and cases (e.g. no content)
+          return timeout(100, response.text()).then(message => Promise.reject({ response, message }), () => Promise.reject({ response }));
         }
         latencyTracker();
         return response;

package/src/sync/polling/fetchers/splitChangesFetcher.ts

@@ -10,7 +10,7 @@ import { LOG_PREFIX_SYNC_SPLITS } from '../../../logger/constants';
 const PROXY_CHECK_INTERVAL_MILLIS_CS = 60 * 60 * 1000; // 1 hour in Client Side
 const PROXY_CHECK_INTERVAL_MILLIS_SS = 24 * PROXY_CHECK_INTERVAL_MILLIS_CS; // 24 hours in Server Side
 
-function sdkEndpointOverriden(settings: ISettings) {
+function sdkEndpointOverridden(settings: ISettings) {
   return settings.urls.sdk !== base.urls.sdk;
 }
 
@@ -42,8 +42,8 @@ export function splitChangesFetcherFactory(fetchSplitChanges: IFetchSplitChanges
     let splitsPromise = fetchSplitChanges(since, noCache, till, settings.sync.flagSpecVersion === FLAG_SPEC_VERSION ? rbSince : undefined)
       // Handle proxy error with spec 1.3
       .catch((err) => {
-        if (err.statusCode === 400 && sdkEndpointOverriden(settings) && settings.sync.flagSpecVersion === FLAG_SPEC_VERSION) {
-          log.error(LOG_PREFIX_SYNC_SPLITS + 'Proxy error detected. If you are using Split Proxy, please upgrade to latest version');
+        if (err.statusCode === 400 && sdkEndpointOverridden(settings) && settings.sync.flagSpecVersion === FLAG_SPEC_VERSION) {
+          log.error(LOG_PREFIX_SYNC_SPLITS + 'Proxy error detected. Retrying with spec 1.2. If you are using Split Proxy, please upgrade to latest version');
           lastProxyCheckTimestamp = Date.now();
           settings.sync.flagSpecVersion = '1.2'; // fallback to 1.2 spec
           return fetchSplitChanges(since, noCache, till); // retry request without rbSince