@splitsoftware/splitio-commons 2.2.0 → 2.2.1-rc.1

package/cjs/storages/inMemory/InMemoryStorageCS.js

@@ -9,6 +9,7 @@ var ImpressionCountsCacheInMemory_1 = require("./ImpressionCountsCacheInMemory")
 var constants_1 = require("../../utils/constants");
 var TelemetryCacheInMemory_1 = require("./TelemetryCacheInMemory");
 var UniqueKeysCacheInMemoryCS_1 = require("./UniqueKeysCacheInMemoryCS");
+var RBSegmentsCacheInMemory_1 = require("./RBSegmentsCacheInMemory");
 /**
  * InMemory storage factory for standalone client-side SplitFactory
  *
@@ -17,10 +18,12 @@ var UniqueKeysCacheInMemoryCS_1 = require("./UniqueKeysCacheInMemoryCS");
 function InMemoryStorageCSFactory(params) {
     var _a = params.settings, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize, __splitFiltersValidation = _a.sync.__splitFiltersValidation;
     var splits = new SplitsCacheInMemory_1.SplitsCacheInMemory(__splitFiltersValidation);
+    var rbSegments = new RBSegmentsCacheInMemory_1.RBSegmentsCacheInMemory();
     var segments = new MySegmentsCacheInMemory_1.MySegmentsCacheInMemory();
     var largeSegments = new MySegmentsCacheInMemory_1.MySegmentsCacheInMemory();
     var storage = {
         splits: splits,
+        rbSegments: rbSegments,
         segments: segments,
         largeSegments: largeSegments,
         impressions: new ImpressionsCacheInMemory_1.ImpressionsCacheInMemory(impressionsQueueSize),
@@ -33,6 +36,7 @@ function InMemoryStorageCSFactory(params) {
         shared: function () {
             return {
                 splits: this.splits,
+                rbSegments: this.rbSegments,
                 segments: new MySegmentsCacheInMemory_1.MySegmentsCacheInMemory(),
                 largeSegments: new MySegmentsCacheInMemory_1.MySegmentsCacheInMemory(),
                 impressions: this.impressions,

package/cjs/storages/inMemory/RBSegmentsCacheInMemory.js

@@ -0,0 +1,61 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RBSegmentsCacheInMemory = void 0;
+var sets_1 = require("../../utils/lang/sets");
+var AbstractSplitsCacheSync_1 = require("../AbstractSplitsCacheSync");
+var RBSegmentsCacheInMemory = /** @class */ (function () {
+    function RBSegmentsCacheInMemory() {
+        this.cache = {};
+        this.changeNumber = -1;
+        this.segmentsCount = 0;
+    }
+    RBSegmentsCacheInMemory.prototype.clear = function () {
+        this.cache = {};
+        this.changeNumber = -1;
+        this.segmentsCount = 0;
+    };
+    RBSegmentsCacheInMemory.prototype.update = function (toAdd, toRemove, changeNumber) {
+        var _this = this;
+        this.changeNumber = changeNumber;
+        var updated = toAdd.map(function (toAdd) { return _this.add(toAdd); }).some(function (result) { return result; });
+        return toRemove.map(function (toRemove) { return _this.remove(toRemove.name); }).some(function (result) { return result; }) || updated;
+    };
+    RBSegmentsCacheInMemory.prototype.add = function (rbSegment) {
+        var name = rbSegment.name;
+        var previous = this.get(name);
+        if (previous && (0, AbstractSplitsCacheSync_1.usesSegments)(previous))
+            this.segmentsCount--;
+        this.cache[name] = rbSegment;
+        if ((0, AbstractSplitsCacheSync_1.usesSegments)(rbSegment))
+            this.segmentsCount++;
+        return true;
+    };
+    RBSegmentsCacheInMemory.prototype.remove = function (name) {
+        var rbSegment = this.get(name);
+        if (!rbSegment)
+            return false;
+        delete this.cache[name];
+        if ((0, AbstractSplitsCacheSync_1.usesSegments)(rbSegment))
+            this.segmentsCount--;
+        return true;
+    };
+    RBSegmentsCacheInMemory.prototype.getNames = function () {
+        return Object.keys(this.cache);
+    };
+    RBSegmentsCacheInMemory.prototype.get = function (name) {
+        return this.cache[name] || null;
+    };
+    RBSegmentsCacheInMemory.prototype.contains = function (names) {
+        var namesArray = (0, sets_1.setToArray)(names);
+        var namesInStorage = this.getNames();
+        return namesArray.every(function (name) { return namesInStorage.indexOf(name) !== -1; });
+    };
+    RBSegmentsCacheInMemory.prototype.getChangeNumber = function () {
+        return this.changeNumber;
+    };
+    RBSegmentsCacheInMemory.prototype.usesSegments = function () {
+        return this.segmentsCount > 0;
+    };
+    return RBSegmentsCacheInMemory;
+}());
+exports.RBSegmentsCacheInMemory = RBSegmentsCacheInMemory;

package/cjs/storages/inRedis/RBSegmentsCacheInRedis.js

@@ -0,0 +1,64 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RBSegmentsCacheInRedis = void 0;
+var lang_1 = require("../../utils/lang");
+var constants_1 = require("./constants");
+var sets_1 = require("../../utils/lang/sets");
+var RBSegmentsCacheInRedis = /** @class */ (function () {
+    function RBSegmentsCacheInRedis(log, keys, redis) {
+        this.log = log;
+        this.keys = keys;
+        this.redis = redis;
+    }
+    RBSegmentsCacheInRedis.prototype.get = function (name) {
+        return this.redis.get(this.keys.buildRBSegmentKey(name))
+            .then(function (maybeRBSegment) { return maybeRBSegment && JSON.parse(maybeRBSegment); });
+    };
+    RBSegmentsCacheInRedis.prototype.getNames = function () {
+        var _this = this;
+        return this.redis.keys(this.keys.searchPatternForRBSegmentKeys()).then(function (listOfKeys) { return listOfKeys.map(_this.keys.extractKey); });
+    };
+    RBSegmentsCacheInRedis.prototype.contains = function (names) {
+        var namesArray = (0, sets_1.setToArray)(names);
+        return this.getNames().then(function (namesInStorage) {
+            return namesArray.every(function (name) { return namesInStorage.includes(name); });
+        });
+    };
+    RBSegmentsCacheInRedis.prototype.update = function (toAdd, toRemove, changeNumber) {
+        var _this = this;
+        return Promise.all([
+            this.setChangeNumber(changeNumber),
+            Promise.all(toAdd.map(function (toAdd) {
+                var key = _this.keys.buildRBSegmentKey(toAdd.name);
+                var stringifiedNewRBSegment = JSON.stringify(toAdd);
+                return _this.redis.set(key, stringifiedNewRBSegment).then(function () { return true; });
+            })),
+            Promise.all(toRemove.map(function (toRemove) {
+                var key = _this.keys.buildRBSegmentKey(toRemove.name);
+                return _this.redis.del(key).then(function (status) { return status === 1; });
+            }))
+        ]).then(function (_a) {
+            var added = _a[1], removed = _a[2];
+            return added.some(function (result) { return result; }) || removed.some(function (result) { return result; });
+        });
+    };
+    RBSegmentsCacheInRedis.prototype.setChangeNumber = function (changeNumber) {
+        return this.redis.set(this.keys.buildRBSegmentsTillKey(), changeNumber + '').then(function (status) { return status === 'OK'; });
+    };
+    RBSegmentsCacheInRedis.prototype.getChangeNumber = function () {
+        var _this = this;
+        return this.redis.get(this.keys.buildRBSegmentsTillKey()).then(function (value) {
+            var i = parseInt(value, 10);
+            return (0, lang_1.isNaNNumber)(i) ? -1 : i;
+        }).catch(function (e) {
+            _this.log.error(constants_1.LOG_PREFIX + 'Could not retrieve changeNumber from storage. Error: ' + e);
+            return -1;
+        });
+    };
+    // @TODO implement if required by DataLoader or producer mode
+    RBSegmentsCacheInRedis.prototype.clear = function () {
+        return Promise.resolve();
+    };
+    return RBSegmentsCacheInRedis;
+}());
+exports.RBSegmentsCacheInRedis = RBSegmentsCacheInRedis;

package/cjs/storages/inRedis/index.js

@@ -12,6 +12,7 @@ var TelemetryCacheInRedis_1 = require("./TelemetryCacheInRedis");
 var UniqueKeysCacheInRedis_1 = require("./UniqueKeysCacheInRedis");
 var ImpressionCountsCacheInRedis_1 = require("./ImpressionCountsCacheInRedis");
 var utils_1 = require("../utils");
+var RBSegmentsCacheInRedis_1 = require("./RBSegmentsCacheInRedis");
 /**
  * InRedis storage factory for consumer server-side SplitFactory, that uses `Ioredis` Redis client for Node.js
  * @see {@link https://www.npmjs.com/package/ioredis}
@@ -40,6 +41,7 @@ function InRedisStorage(options) {
         });
         return {
             splits: new SplitsCacheInRedis_1.SplitsCacheInRedis(log, keys, redisClient, settings.sync.__splitFiltersValidation),
+            rbSegments: new RBSegmentsCacheInRedis_1.RBSegmentsCacheInRedis(log, keys, redisClient),
             segments: new SegmentsCacheInRedis_1.SegmentsCacheInRedis(log, keys, redisClient),
             impressions: new ImpressionsCacheInRedis_1.ImpressionsCacheInRedis(log, keys.buildImpressionsKey(), redisClient, metadata),
             impressionCounts: impressionCountsCache,

package/cjs/storages/pluggable/RBSegmentsCachePluggable.js

@@ -0,0 +1,64 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RBSegmentsCachePluggable = void 0;
+var lang_1 = require("../../utils/lang");
+var constants_1 = require("./constants");
+var sets_1 = require("../../utils/lang/sets");
+var RBSegmentsCachePluggable = /** @class */ (function () {
+    function RBSegmentsCachePluggable(log, keys, wrapper) {
+        this.log = log;
+        this.keys = keys;
+        this.wrapper = wrapper;
+    }
+    RBSegmentsCachePluggable.prototype.get = function (name) {
+        return this.wrapper.get(this.keys.buildRBSegmentKey(name))
+            .then(function (maybeRBSegment) { return maybeRBSegment && JSON.parse(maybeRBSegment); });
+    };
+    RBSegmentsCachePluggable.prototype.getNames = function () {
+        var _this = this;
+        return this.wrapper.getKeysByPrefix(this.keys.buildRBSegmentKeyPrefix()).then(function (listOfKeys) { return listOfKeys.map(_this.keys.extractKey); });
+    };
+    RBSegmentsCachePluggable.prototype.contains = function (names) {
+        var namesArray = (0, sets_1.setToArray)(names);
+        return this.getNames().then(function (namesInStorage) {
+            return namesArray.every(function (name) { return namesInStorage.includes(name); });
+        });
+    };
+    RBSegmentsCachePluggable.prototype.update = function (toAdd, toRemove, changeNumber) {
+        var _this = this;
+        return Promise.all([
+            this.setChangeNumber(changeNumber),
+            Promise.all(toAdd.map(function (toAdd) {
+                var key = _this.keys.buildRBSegmentKey(toAdd.name);
+                var stringifiedNewRBSegment = JSON.stringify(toAdd);
+                return _this.wrapper.set(key, stringifiedNewRBSegment).then(function () { return true; });
+            })),
+            Promise.all(toRemove.map(function (toRemove) {
+                var key = _this.keys.buildRBSegmentKey(toRemove.name);
+                return _this.wrapper.del(key);
+            }))
+        ]).then(function (_a) {
+            var added = _a[1], removed = _a[2];
+            return added.some(function (result) { return result; }) || removed.some(function (result) { return result; });
+        });
+    };
+    RBSegmentsCachePluggable.prototype.setChangeNumber = function (changeNumber) {
+        return this.wrapper.set(this.keys.buildRBSegmentsTillKey(), changeNumber + '');
+    };
+    RBSegmentsCachePluggable.prototype.getChangeNumber = function () {
+        var _this = this;
+        return this.wrapper.get(this.keys.buildRBSegmentsTillKey()).then(function (value) {
+            var i = parseInt(value, 10);
+            return (0, lang_1.isNaNNumber)(i) ? -1 : i;
+        }).catch(function (e) {
+            _this.log.error(constants_1.LOG_PREFIX + 'Could not retrieve changeNumber from storage. Error: ' + e);
+            return -1;
+        });
+    };
+    // @TODO implement if required by DataLoader or producer mode
+    RBSegmentsCachePluggable.prototype.clear = function () {
+        return Promise.resolve();
+    };
+    return RBSegmentsCachePluggable;
+}());
+exports.RBSegmentsCachePluggable = RBSegmentsCachePluggable;

package/cjs/storages/pluggable/index.js

@@ -22,6 +22,7 @@ var UniqueKeysCacheInMemory_1 = require("../inMemory/UniqueKeysCacheInMemory");
 var UniqueKeysCacheInMemoryCS_1 = require("../inMemory/UniqueKeysCacheInMemoryCS");
 var utils_1 = require("../utils");
 var constants_2 = require("../pluggable/constants");
+var RBSegmentsCachePluggable_1 = require("./RBSegmentsCachePluggable");
 var NO_VALID_WRAPPER = 'Expecting pluggable storage `wrapper` in options, but no valid wrapper instance was provided.';
 var NO_VALID_WRAPPER_INTERFACE = 'The provided wrapper instance doesn’t follow the expected interface. Check our docs.';
 /**
@@ -105,6 +106,7 @@ function PluggableStorage(options) {
         });
         return {
             splits: new SplitsCachePluggable_1.SplitsCachePluggable(log, keys, wrapper, settings.sync.__splitFiltersValidation),
+            rbSegments: new RBSegmentsCachePluggable_1.RBSegmentsCachePluggable(log, keys, wrapper),
             segments: new SegmentsCachePluggable_1.SegmentsCachePluggable(log, keys, wrapper),
             impressions: isPartialConsumer ? new ImpressionsCacheInMemory_1.ImpressionsCacheInMemory(impressionsQueueSize) : new ImpressionsCachePluggable_1.ImpressionsCachePluggable(log, keys.buildImpressionsKey(), wrapper, metadata),
             impressionCounts: impressionCountsCache,

package/cjs/sync/polling/fetchers/splitChangesFetcher.js

@@ -1,18 +1,65 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.splitChangesFetcherFactory = void 0;
+var constants_1 = require("../../../utils/constants");
+var settingsValidation_1 = require("../../../utils/settingsValidation");
+var constants_2 = require("../../../logger/constants");
+var PROXY_CHECK_INTERVAL_MILLIS_CS = 60 * 60 * 1000; // 1 hour in Client Side
+var PROXY_CHECK_INTERVAL_MILLIS_SS = 24 * PROXY_CHECK_INTERVAL_MILLIS_CS; // 24 hours in Server Side
+function sdkEndpointOverriden(settings) {
+    return settings.urls.sdk !== settingsValidation_1.base.urls.sdk;
+}
 /**
  * Factory of SplitChanges fetcher.
  * SplitChanges fetcher is a wrapper around `splitChanges` API service that parses the response and handle errors.
  */
-function splitChangesFetcherFactory(fetchSplitChanges) {
-    return function splitChangesFetcher(since, noCache, till, 
+// @TODO breaking: drop support for Split Proxy below v5.10.0 and simplify the implementation
+function splitChangesFetcherFactory(fetchSplitChanges, settings, storage) {
+    var log = settings.log;
+    var PROXY_CHECK_INTERVAL_MILLIS = settings.core.key !== undefined ? PROXY_CHECK_INTERVAL_MILLIS_CS : PROXY_CHECK_INTERVAL_MILLIS_SS;
+    var lastProxyCheckTimestamp;
+    return function splitChangesFetcher(since, noCache, till, rbSince, 
     // Optional decorator for `fetchSplitChanges` promise, such as timeout or time tracker
     decorator) {
-        var splitsPromise = fetchSplitChanges(since, noCache, till);
+        // Recheck proxy
+        if (lastProxyCheckTimestamp && (Date.now() - lastProxyCheckTimestamp) > PROXY_CHECK_INTERVAL_MILLIS) {
+            settings.sync.flagSpecVersion = constants_1.FLAG_SPEC_VERSION;
+        }
+        var splitsPromise = fetchSplitChanges(since, noCache, till, settings.sync.flagSpecVersion === constants_1.FLAG_SPEC_VERSION ? rbSince : undefined)
+            // Handle proxy error with spec 1.3
+            .catch(function (err) {
+            if (err.statusCode === 400 && sdkEndpointOverriden(settings) && settings.sync.flagSpecVersion === constants_1.FLAG_SPEC_VERSION) {
+                log.error(constants_2.LOG_PREFIX_SYNC_SPLITS + 'Proxy error detected. If you are using Split Proxy, please upgrade to latest version');
+                lastProxyCheckTimestamp = Date.now();
+                settings.sync.flagSpecVersion = '1.2'; // fallback to 1.2 spec
+                return fetchSplitChanges(since, noCache, till); // retry request without rbSince
+            }
+            throw err;
+        });
         if (decorator)
             splitsPromise = decorator(splitsPromise);
-        return splitsPromise.then(function (resp) { return resp.json(); });
+        return splitsPromise
+            .then(function (resp) { return resp.json(); })
+            .then(function (data) {
+            // Using flag spec version 1.2
+            if (data.splits) {
+                return {
+                    ff: {
+                        d: data.splits,
+                        s: data.since,
+                        t: data.till
+                    }
+                };
+            }
+            // Proxy recovery
+            if (lastProxyCheckTimestamp) {
+                log.info(constants_2.LOG_PREFIX_SYNC_SPLITS + 'Proxy error recovered');
+                lastProxyCheckTimestamp = undefined;
+                return Promise.all([storage.splits.clear(), storage.rbSegments.clear()])
+                    .then(function () { return splitChangesFetcher(storage.splits.getChangeNumber(), undefined, undefined, storage.rbSegments.getChangeNumber()); });
+            }
+            return data;
+        });
     };
 }
 exports.splitChangesFetcherFactory = splitChangesFetcherFactory;

package/cjs/sync/polling/pollingManagerCS.js

@@ -34,10 +34,10 @@ function pollingManagerCSFactory(params) {
     readiness.splits.on(constants_1.SDK_SPLITS_ARRIVED, function () {
         if (!splitsSyncTask.isRunning())
             return; // noop if not doing polling
-        var splitsHaveSegments = storage.splits.usesSegments();
-        if (splitsHaveSegments !== mySegmentsSyncTask.isRunning()) {
-            log.info(constants_2.POLLING_SMART_PAUSING, [splitsHaveSegments ? 'ON' : 'OFF']);
-            if (splitsHaveSegments) {
+        var usingSegments = storage.splits.usesSegments() || storage.rbSegments.usesSegments();
+        if (usingSegments !== mySegmentsSyncTask.isRunning()) {
+            log.info(constants_2.POLLING_SMART_PAUSING, [usingSegments ? 'ON' : 'OFF']);
+            if (usingSegments) {
                 startMySegmentsSyncTasks();
             }
             else {
@@ -49,10 +49,10 @@ function pollingManagerCSFactory(params) {
         var mySegmentsSyncTask = (0, mySegmentsSyncTask_1.mySegmentsSyncTaskFactory)(splitApi.fetchMemberships, storage, readiness, settings, matchingKey);
         // smart ready
         function smartReady() {
-            if (!readiness.isReady() && !storage.splits.usesSegments())
+            if (!readiness.isReady() && !storage.splits.usesSegments() && !storage.rbSegments.usesSegments())
                 readiness.segments.emit(constants_1.SDK_SEGMENTS_ARRIVED);
         }
-        if (!storage.splits.usesSegments())
+        if (!storage.splits.usesSegments() && !storage.rbSegments.usesSegments())
             setTimeout(smartReady, 0);
         else
             readiness.splits.once(constants_1.SDK_SPLITS_ARRIVED, smartReady);
@@ -66,7 +66,7 @@ function pollingManagerCSFactory(params) {
         start: function () {
             log.info(constants_2.POLLING_START);
             splitsSyncTask.start();
-            if (storage.splits.usesSegments())
+            if (storage.splits.usesSegments() || storage.rbSegments.usesSegments())
                 startMySegmentsSyncTasks();
         },
         // Stop periodic fetching (polling)

package/cjs/sync/polling/syncTasks/splitsSyncTask.js

@@ -8,6 +8,6 @@ var splitChangesUpdater_1 = require("../updaters/splitChangesUpdater");
  * Creates a sync task that periodically executes a `splitChangesUpdater` task
  */
 function splitsSyncTaskFactory(fetchSplitChanges, storage, readiness, settings, isClientSide) {
-    return (0, syncTask_1.syncTaskFactory)(settings.log, (0, splitChangesUpdater_1.splitChangesUpdaterFactory)(settings.log, (0, splitChangesFetcher_1.splitChangesFetcherFactory)(fetchSplitChanges), storage, settings.sync.__splitFiltersValidation, readiness.splits, settings.startup.requestTimeoutBeforeReady, settings.startup.retriesOnFailureBeforeReady, isClientSide), settings.scheduler.featuresRefreshRate, 'splitChangesUpdater');
+    return (0, syncTask_1.syncTaskFactory)(settings.log, (0, splitChangesUpdater_1.splitChangesUpdaterFactory)(settings.log, (0, splitChangesFetcher_1.splitChangesFetcherFactory)(fetchSplitChanges, settings, storage), storage, settings.sync.__splitFiltersValidation, readiness.splits, settings.startup.requestTimeoutBeforeReady, settings.startup.retriesOnFailureBeforeReady, isClientSide), settings.scheduler.featuresRefreshRate, 'splitChangesUpdater');
 }
 exports.splitsSyncTaskFactory = splitsSyncTaskFactory;

package/cjs/sync/polling/updaters/mySegmentsUpdater.js

@@ -12,7 +12,7 @@ var constants_3 = require("../../streaming/constants");
  *  - uses `segmentsEventEmitter` to emit events related to segments data updates
  */
 function mySegmentsUpdaterFactory(log, mySegmentsFetcher, storage, segmentsEventEmitter, requestTimeoutBeforeReady, retriesOnFailureBeforeReady, matchingKey) {
-    var splits = storage.splits, segments = storage.segments, largeSegments = storage.largeSegments;
+    var splits = storage.splits, rbSegments = storage.rbSegments, segments = storage.segments, largeSegments = storage.largeSegments;
     var readyOnAlreadyExistentState = true;
     var startingUp = true;
     /** timeout and telemetry decorator for `splitChangesFetcher` promise  */
@@ -34,7 +34,7 @@ function mySegmentsUpdaterFactory(log, mySegmentsFetcher, storage, segmentsEvent
             shouldNotifyUpdate = largeSegments.resetSegments(segmentsData.ls || {}) || shouldNotifyUpdate;
         }
         // Notify update if required
-        if (splits.usesSegments() && (shouldNotifyUpdate || readyOnAlreadyExistentState)) {
+        if ((splits.usesSegments() || rbSegments.usesSegments()) && (shouldNotifyUpdate || readyOnAlreadyExistentState)) {
             readyOnAlreadyExistentState = false;
             segmentsEventEmitter.emit(constants_1.SDK_SEGMENTS_ARRIVED);
         }

package/cjs/sync/polling/updaters/segmentChangesUpdater.js

@@ -39,7 +39,7 @@ function segmentChangesUpdaterFactory(log, segmentChangesFetcher, segments, read
      * Returned promise will not be rejected.
      *
      * @param fetchOnlyNew - if true, only fetch the segments that not exists, i.e., which `changeNumber` is equal to -1.
-     * This param is used by SplitUpdateWorker on server-side SDK, to fetch new registered segments on SPLIT_UPDATE notifications.
+     * This param is used by SplitUpdateWorker on server-side SDK, to fetch new registered segments on SPLIT_UPDATE or RB_SEGMENT_UPDATE notifications.
      * @param segmentName - segment name to fetch. By passing `undefined` it fetches the list of segments registered at the storage
      * @param noCache - true to revalidate data to fetch on a SEGMENT_UPDATE notifications.
      * @param till - till target for the provided segmentName, for CDN bypass.

package/cjs/sync/polling/updaters/splitChangesUpdater.js

@@ -1,12 +1,13 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.splitChangesUpdaterFactory = exports.computeSplitsMutation = exports.parseSegments = void 0;
+exports.splitChangesUpdaterFactory = exports.computeMutation = exports.parseSegments = void 0;
 var timeout_1 = require("../../../utils/promise/timeout");
 var constants_1 = require("../../../readiness/constants");
 var constants_2 = require("../../../logger/constants");
 var lang_1 = require("../../../utils/lang");
 var constants_3 = require("../../../utils/constants");
 var sets_1 = require("../../../utils/lang/sets");
+var constants_4 = require("../../streaming/constants");
 // Checks that all registered segments have been fetched (changeNumber !== -1 for every segment).
 // Returns a promise that could be rejected.
 // @TODO review together with Segments and MySegments storage APIs
@@ -21,13 +22,14 @@ function checkAllSegmentsExist(segments) {
  * Collect segments from a raw split definition.
  * Exported for testing purposes.
  */
-function parseSegments(_a) {
-    var conditions = _a.conditions;
-    var segments = new Set();
+function parseSegments(ruleEntity, matcherType) {
+    if (matcherType === void 0) { matcherType = constants_3.IN_SEGMENT; }
+    var _a = ruleEntity, _b = _a.conditions, conditions = _b === void 0 ? [] : _b, excluded = _a.excluded;
+    var segments = new Set(excluded && excluded.segments);
     for (var i = 0; i < conditions.length; i++) {
         var matchers = conditions[i].matcherGroup.matchers;
         matchers.forEach(function (matcher) {
-            if (matcher.matcherType === constants_3.IN_SEGMENT)
+            if (matcher.matcherType === matcherType)
                 segments.add(matcher.userDefinedSegmentMatcherData.segmentName);
         });
     }
@@ -58,24 +60,21 @@ function matchFilters(featureFlag, filters) {
  * i.e., an object with added splits, removed splits and used segments.
  * Exported for testing purposes.
  */
-function computeSplitsMutation(entries, filters) {
-    var segments = new Set();
-    var computed = entries.reduce(function (accum, split) {
-        if (split.status === 'ACTIVE' && matchFilters(split, filters)) {
-            accum.added.push(split);
-            parseSegments(split).forEach(function (segmentName) {
+function computeMutation(rules, segments, filters) {
+    return rules.reduce(function (accum, ruleEntity) {
+        if (ruleEntity.status === 'ACTIVE' && (!filters || matchFilters(ruleEntity, filters))) {
+            accum.added.push(ruleEntity);
+            parseSegments(ruleEntity).forEach(function (segmentName) {
                 segments.add(segmentName);
             });
         }
         else {
-            accum.removed.push(split);
+            accum.removed.push(ruleEntity);
         }
         return accum;
-    }, { added: [], removed: [], segments: [] });
-    computed.segments = (0, sets_1.setToArray)(segments);
-    return computed;
+    }, { added: [], removed: [] });
 }
-exports.computeSplitsMutation = computeSplitsMutation;
+exports.computeMutation = computeMutation;
 /**
  * factory of SplitChanges updater, a task that:
  *  - fetches split changes using `splitChangesFetcher`
@@ -93,7 +92,7 @@ exports.computeSplitsMutation = computeSplitsMutation;
 function splitChangesUpdaterFactory(log, splitChangesFetcher, storage, splitFiltersValidation, splitsEventEmitter, requestTimeoutBeforeReady, retriesOnFailureBeforeReady, isClientSide) {
     if (requestTimeoutBeforeReady === void 0) { requestTimeoutBeforeReady = 0; }
     if (retriesOnFailureBeforeReady === void 0) { retriesOnFailureBeforeReady = 0; }
-    var splits = storage.splits, segments = storage.segments;
+    var splits = storage.splits, rbSegments = storage.rbSegments, segments = storage.segments;
     var startingUp = true;
     /** timeout decorator for `splitChangesFetcher` promise  */
     function _promiseDecorator(promise) {
@@ -108,29 +107,48 @@ function splitChangesUpdaterFactory(log, splitChangesFetcher, storage, splitFilt
      * @param noCache - true to revalidate data to fetch
      * @param till - query param to bypass CDN requests
      */
-    return function splitChangesUpdater(noCache, till, splitUpdateNotification) {
+    return function splitChangesUpdater(noCache, till, instantUpdate) {
         /**
          * @param since - current changeNumber at splitsCache
          * @param retry - current number of retry attempts
          */
-        function _splitChangesUpdater(since, retry) {
+        function _splitChangesUpdater(sinces, retry) {
             if (retry === void 0) { retry = 0; }
-            log.debug(constants_2.SYNC_SPLITS_FETCH, [since]);
-            return Promise.resolve(splitUpdateNotification ?
-                { splits: [splitUpdateNotification.payload], till: splitUpdateNotification.changeNumber } :
-                splitChangesFetcher(since, noCache, till, _promiseDecorator))
+            var since = sinces[0], rbSince = sinces[1];
+            log.debug(constants_2.SYNC_SPLITS_FETCH, sinces);
+            return Promise.resolve(instantUpdate ?
+                instantUpdate.type === constants_4.SPLIT_UPDATE ?
+                    // IFFU edge case: a change to a flag that adds an IN_RULE_BASED_SEGMENT matcher that is not present yet
+                    Promise.resolve(rbSegments.contains(parseSegments(instantUpdate.payload, constants_3.IN_RULE_BASED_SEGMENT))).then(function (contains) {
+                        return contains ?
+                            { ff: { d: [instantUpdate.payload], t: instantUpdate.changeNumber } } :
+                            splitChangesFetcher(since, noCache, till, rbSince, _promiseDecorator);
+                    }) :
+                    { rbs: { d: [instantUpdate.payload], t: instantUpdate.changeNumber } } :
+                splitChangesFetcher(since, noCache, till, rbSince, _promiseDecorator))
                 .then(function (splitChanges) {
                 startingUp = false;
-                var mutation = computeSplitsMutation(splitChanges.splits, splitFiltersValidation);
-                log.debug(constants_2.SYNC_SPLITS_UPDATE, [mutation.added.length, mutation.removed.length, mutation.segments.length]);
-                return Promise.all([
-                    splits.update(mutation.added, mutation.removed, splitChanges.till),
-                    segments.registerSegments(mutation.segments)
+                var usedSegments = new Set();
+                var ffUpdate = false;
+                if (splitChanges.ff) {
+                    var _a = computeMutation(splitChanges.ff.d, usedSegments, splitFiltersValidation), added = _a.added, removed = _a.removed;
+                    log.debug(constants_2.SYNC_SPLITS_UPDATE, [added.length, removed.length]);
+                    ffUpdate = splits.update(added, removed, splitChanges.ff.t);
+                }
+                var rbsUpdate = false;
+                if (splitChanges.rbs) {
+                    var _b = computeMutation(splitChanges.rbs.d, usedSegments), added = _b.added, removed = _b.removed;
+                    log.debug(constants_2.SYNC_RBS_UPDATE, [added.length, removed.length]);
+                    rbsUpdate = rbSegments.update(added, removed, splitChanges.rbs.t);
+                }
+                return Promise.all([ffUpdate, rbsUpdate,
+                    // @TODO if at least 1 segment fetch fails due to 404 and other segments are updated in the storage, SDK_UPDATE is not emitted
+                    segments.registerSegments((0, sets_1.setToArray)(usedSegments))
                 ]).then(function (_a) {
-                    var isThereUpdate = _a[0];
+                    var ffChanged = _a[0], rbsChanged = _a[1];
                     if (splitsEventEmitter) {
                         // To emit SDK_SPLITS_ARRIVED for server-side SDK, we must check that all registered segments have been fetched
-                        return Promise.resolve(!splitsEventEmitter.splitsArrived || (since !== splitChanges.till && isThereUpdate && (isClientSide || checkAllSegmentsExist(segments))))
+                        return Promise.resolve(!splitsEventEmitter.splitsArrived || ((ffChanged || rbsChanged) && (isClientSide || checkAllSegmentsExist(segments))))
                             .catch(function () { return false; } /** noop. just to handle a possible `checkAllSegmentsExist` rejection, before emitting SDK event */)
                             .then(function (emitSplitsArrivedEvent) {
                             // emit SDK events
@@ -147,7 +165,7 @@ function splitChangesUpdaterFactory(log, splitChangesFetcher, storage, splitFilt
                 if (startingUp && retriesOnFailureBeforeReady > retry) {
                     retry += 1;
                     log.info(constants_2.SYNC_SPLITS_FETCH_RETRY, [retry, error]);
-                    return _splitChangesUpdater(since, retry);
+                    return _splitChangesUpdater(sinces, retry);
                 }
                 else {
                     startingUp = false;
@@ -155,8 +173,8 @@ function splitChangesUpdaterFactory(log, splitChangesFetcher, storage, splitFilt
                 return false;
             });
         }
-        var sincePromise = Promise.resolve(splits.getChangeNumber()); // `getChangeNumber` never rejects or throws error
-        return sincePromise.then(_splitChangesUpdater);
+        // `getChangeNumber` never rejects or throws error
+        return Promise.all([splits.getChangeNumber(), rbSegments.getChangeNumber()]).then(_splitChangesUpdater);
     };
 }
 exports.splitChangesUpdaterFactory = splitChangesUpdaterFactory;

package/cjs/sync/streaming/SSEHandler/index.js

@@ -78,6 +78,7 @@ function SSEHandlerFactory(log, pushEmitter, telemetryTracker) {
                 case constants_1.MEMBERSHIPS_MS_UPDATE:
                 case constants_1.MEMBERSHIPS_LS_UPDATE:
                 case constants_1.SPLIT_KILL:
+                case constants_1.RB_SEGMENT_UPDATE:
                     pushEmitter.emit(parsedData.type, parsedData);
                     break;
                 /* occupancy & control events, handled by NotificationManagerKeeper */