@splitsoftware/splitio-commons 2.1.0 → 2.1.1-rc.0

package/cjs/sync/polling/updaters/segmentChangesUpdater.js

@@ -39,7 +39,7 @@ function segmentChangesUpdaterFactory(log, segmentChangesFetcher, segments, read
      * Returned promise will not be rejected.
      *
      * @param fetchOnlyNew - if true, only fetch the segments that not exists, i.e., which `changeNumber` is equal to -1.
-     * This param is used by SplitUpdateWorker on server-side SDK, to fetch new registered segments on SPLIT_UPDATE notifications.
+     * This param is used by SplitUpdateWorker on server-side SDK, to fetch new registered segments on SPLIT_UPDATE or RB_SEGMENT_UPDATE notifications.
      * @param segmentName - segment name to fetch. By passing `undefined` it fetches the list of segments registered at the storage
      * @param noCache - true to revalidate data to fetch on a SEGMENT_UPDATE notifications.
      * @param till - till target for the provided segmentName, for CDN bypass.

package/cjs/sync/polling/updaters/splitChangesUpdater.js

@@ -1,12 +1,13 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.splitChangesUpdaterFactory = exports.computeSplitsMutation = exports.parseSegments = void 0;
+exports.splitChangesUpdaterFactory = exports.computeMutation = exports.parseSegments = void 0;
 var timeout_1 = require("../../../utils/promise/timeout");
 var constants_1 = require("../../../readiness/constants");
 var constants_2 = require("../../../logger/constants");
 var lang_1 = require("../../../utils/lang");
 var constants_3 = require("../../../utils/constants");
 var sets_1 = require("../../../utils/lang/sets");
+var constants_4 = require("../../streaming/constants");
 // Checks that all registered segments have been fetched (changeNumber !== -1 for every segment).
 // Returns a promise that could be rejected.
 // @TODO review together with Segments and MySegments storage APIs
@@ -21,13 +22,14 @@ function checkAllSegmentsExist(segments) {
  * Collect segments from a raw split definition.
  * Exported for testing purposes.
  */
-function parseSegments(_a) {
-    var conditions = _a.conditions;
-    var segments = new Set();
+function parseSegments(ruleEntity, matcherType) {
+    if (matcherType === void 0) { matcherType = constants_3.IN_SEGMENT; }
+    var _a = ruleEntity, conditions = _a.conditions, excluded = _a.excluded;
+    var segments = new Set(excluded && excluded.segments);
     for (var i = 0; i < conditions.length; i++) {
         var matchers = conditions[i].matcherGroup.matchers;
         matchers.forEach(function (matcher) {
-            if (matcher.matcherType === constants_3.IN_SEGMENT)
+            if (matcher.matcherType === matcherType)
                 segments.add(matcher.userDefinedSegmentMatcherData.segmentName);
         });
     }
@@ -58,24 +60,21 @@ function matchFilters(featureFlag, filters) {
  * i.e., an object with added splits, removed splits and used segments.
  * Exported for testing purposes.
  */
-function computeSplitsMutation(entries, filters) {
-    var segments = new Set();
-    var computed = entries.reduce(function (accum, split) {
-        if (split.status === 'ACTIVE' && matchFilters(split, filters)) {
-            accum.added.push([split.name, split]);
-            parseSegments(split).forEach(function (segmentName) {
+function computeMutation(rules, segments, filters) {
+    return rules.reduce(function (accum, ruleEntity) {
+        if (ruleEntity.status === 'ACTIVE' && (!filters || matchFilters(ruleEntity, filters))) {
+            accum.added.push(ruleEntity);
+            parseSegments(ruleEntity).forEach(function (segmentName) {
                 segments.add(segmentName);
             });
         }
         else {
-            accum.removed.push(split.name);
+            accum.removed.push(ruleEntity);
         }
         return accum;
-    }, { added: [], removed: [], segments: [] });
-    computed.segments = (0, sets_1.setToArray)(segments);
-    return computed;
+    }, { added: [], removed: [] });
 }
-exports.computeSplitsMutation = computeSplitsMutation;
+exports.computeMutation = computeMutation;
 /**
  * factory of SplitChanges updater, a task that:
  *  - fetches split changes using `splitChangesFetcher`
@@ -90,9 +89,10 @@ exports.computeSplitsMutation = computeSplitsMutation;
  * @param requestTimeoutBeforeReady -  How long the updater will wait for the request to timeout. Default 0, i.e., never timeout.
  * @param retriesOnFailureBeforeReady -  How many retries on `/splitChanges` we the updater do in case of failure or timeout. Default 0, i.e., no retries.
  */
-function splitChangesUpdaterFactory(log, splitChangesFetcher, splits, segments, splitFiltersValidation, splitsEventEmitter, requestTimeoutBeforeReady, retriesOnFailureBeforeReady, isClientSide) {
+function splitChangesUpdaterFactory(log, splitChangesFetcher, storage, splitFiltersValidation, splitsEventEmitter, requestTimeoutBeforeReady, retriesOnFailureBeforeReady, isClientSide) {
     if (requestTimeoutBeforeReady === void 0) { requestTimeoutBeforeReady = 0; }
     if (retriesOnFailureBeforeReady === void 0) { retriesOnFailureBeforeReady = 0; }
+    var splits = storage.splits, rbSegments = storage.rbSegments, segments = storage.segments;
     var startingUp = true;
     /** timeout decorator for `splitChangesFetcher` promise  */
     function _promiseDecorator(promise) {
@@ -100,17 +100,6 @@ function splitChangesUpdaterFactory(log, splitChangesFetcher, splits, segments,
             promise = (0, timeout_1.timeout)(requestTimeoutBeforeReady, promise);
         return promise;
     }
-    /** Returns true if at least one split was updated */
-    function isThereUpdate(flagsChange) {
-        var added = flagsChange[1], removed = flagsChange[2];
-        // There is at least one added or modified feature flag
-        if (added && added.some(function (update) { return update; }))
-            return true;
-        // There is at least one removed feature flag
-        if (removed && removed.some(function (update) { return update; }))
-            return true;
-        return false;
-    }
     /**
      * SplitChanges updater returns a promise that resolves with a `false` boolean value if it fails to fetch splits or synchronize them with the storage.
      * Returned promise will not be rejected.
@@ -118,35 +107,48 @@ function splitChangesUpdaterFactory(log, splitChangesFetcher, splits, segments,
      * @param noCache - true to revalidate data to fetch
      * @param till - query param to bypass CDN requests
      */
-    return function splitChangesUpdater(noCache, till, splitUpdateNotification) {
+    return function splitChangesUpdater(noCache, till, instantUpdate) {
         /**
          * @param since - current changeNumber at splitsCache
          * @param retry - current number of retry attempts
          */
-        function _splitChangesUpdater(since, retry) {
+        function _splitChangesUpdater(sinces, retry) {
             if (retry === void 0) { retry = 0; }
-            log.debug(constants_2.SYNC_SPLITS_FETCH, [since]);
-            var fetcherPromise = Promise.resolve(splitUpdateNotification ?
-                { splits: [splitUpdateNotification.payload], till: splitUpdateNotification.changeNumber } :
-                splitChangesFetcher(since, noCache, till, _promiseDecorator))
+            var since = sinces[0], rbSince = sinces[1];
+            log.debug(constants_2.SYNC_SPLITS_FETCH, sinces);
+            var fetcherPromise = Promise.resolve(instantUpdate ?
+                instantUpdate.type === constants_4.SPLIT_UPDATE ?
+                    // IFFU edge case: a change to a flag that adds an IN_RULE_BASED_SEGMENT matcher that is not present yet
+                    Promise.resolve(rbSegments.contains(parseSegments(instantUpdate.payload, constants_3.IN_RULE_BASED_SEGMENT))).then(function (contains) {
+                        return contains ?
+                            { ff: { d: [instantUpdate.payload], t: instantUpdate.changeNumber } } :
+                            splitChangesFetcher(since, noCache, till, rbSince, _promiseDecorator);
+                    }) :
+                    { rbs: { d: [instantUpdate.payload], t: instantUpdate.changeNumber } } :
+                splitChangesFetcher(since, noCache, till, rbSince, _promiseDecorator))
                 .then(function (splitChanges) {
                 startingUp = false;
-                var mutation = computeSplitsMutation(splitChanges.splits, splitFiltersValidation);
-                log.debug(constants_2.SYNC_SPLITS_NEW, [mutation.added.length]);
-                log.debug(constants_2.SYNC_SPLITS_REMOVED, [mutation.removed.length]);
-                log.debug(constants_2.SYNC_SPLITS_SEGMENTS, [mutation.segments.length]);
-                // Write into storage
-                // @TODO call `setChangeNumber` only if the other storage operations have succeeded, in order to keep storage consistency
-                return Promise.all([
-                    // calling first `setChangenumber` method, to perform cache flush if split filter queryString changed
-                    splits.setChangeNumber(splitChanges.till),
-                    splits.addSplits(mutation.added),
-                    splits.removeSplits(mutation.removed),
-                    segments.registerSegments(mutation.segments)
-                ]).then(function (flagsChange) {
+                var usedSegments = new Set();
+                var ffUpdate = false;
+                if (splitChanges.ff) {
+                    var _a = computeMutation(splitChanges.ff.d, usedSegments, splitFiltersValidation), added = _a.added, removed = _a.removed;
+                    log.debug(constants_2.SYNC_SPLITS_UPDATE, [added.length, removed.length]);
+                    ffUpdate = splits.update(added, removed, splitChanges.ff.t);
+                }
+                var rbsUpdate = false;
+                if (splitChanges.rbs) {
+                    var _b = computeMutation(splitChanges.rbs.d, usedSegments), added = _b.added, removed = _b.removed;
+                    log.debug(constants_2.SYNC_RBS_UPDATE, [added.length, removed.length]);
+                    rbsUpdate = rbSegments.update(added, removed, splitChanges.rbs.t);
+                }
+                return Promise.all([ffUpdate, rbsUpdate,
+                    // @TODO if at least 1 segment fetch fails due to 404 and other segments are updated in the storage, SDK_UPDATE is not emitted
+                    segments.registerSegments((0, sets_1.setToArray)(usedSegments))
+                ]).then(function (_a) {
+                    var ffChanged = _a[0], rbsChanged = _a[1];
                     if (splitsEventEmitter) {
                         // To emit SDK_SPLITS_ARRIVED for server-side SDK, we must check that all registered segments have been fetched
-                        return Promise.resolve(!splitsEventEmitter.splitsArrived || (since !== splitChanges.till && isThereUpdate(flagsChange) && (isClientSide || checkAllSegmentsExist(segments))))
+                        return Promise.resolve(!splitsEventEmitter.splitsArrived || ((ffChanged || rbsChanged) && (isClientSide || checkAllSegmentsExist(segments))))
                             .catch(function () { return false; } /** noop. just to handle a possible `checkAllSegmentsExist` rejection, before emitting SDK event */)
                             .then(function (emitSplitsArrivedEvent) {
                             // emit SDK events
@@ -163,7 +165,7 @@ function splitChangesUpdaterFactory(log, splitChangesFetcher, splits, segments,
                 if (startingUp && retriesOnFailureBeforeReady > retry) {
                     retry += 1;
                     log.info(constants_2.SYNC_SPLITS_FETCH_RETRY, [retry, error]);
-                    return _splitChangesUpdater(since, retry);
+                    return _splitChangesUpdater(sinces, retry);
                 }
                 else {
                     startingUp = false;
@@ -180,8 +182,8 @@ function splitChangesUpdaterFactory(log, splitChangesFetcher, splits, segments,
             }
             return fetcherPromise;
         }
-        var sincePromise = Promise.resolve(splits.getChangeNumber()); // `getChangeNumber` never rejects or throws error
-        return sincePromise.then(_splitChangesUpdater);
+        // `getChangeNumber` never rejects or throws error
+        return Promise.all([splits.getChangeNumber(), rbSegments.getChangeNumber()]).then(_splitChangesUpdater);
     };
 }
 exports.splitChangesUpdaterFactory = splitChangesUpdaterFactory;

package/cjs/sync/streaming/SSEHandler/index.js

@@ -78,6 +78,7 @@ function SSEHandlerFactory(log, pushEmitter, telemetryTracker) {
                 case constants_1.MEMBERSHIPS_MS_UPDATE:
                 case constants_1.MEMBERSHIPS_LS_UPDATE:
                 case constants_1.SPLIT_KILL:
+                case constants_1.RB_SEGMENT_UPDATE:
                     pushEmitter.emit(parsedData.type, parsedData);
                     break;
                 /* occupancy & control events, handled by NotificationManagerKeeper */

package/cjs/sync/streaming/UpdateWorkers/SplitsUpdateWorker.js

@@ -1,106 +1,135 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.SplitsUpdateWorker = void 0;
-var constants_1 = require("../../../readiness/constants");
+var constants_1 = require("../../../logger/constants");
+var constants_2 = require("../../../readiness/constants");
 var Backoff_1 = require("../../../utils/Backoff");
-var constants_2 = require("../../../utils/constants");
-var constants_3 = require("./constants");
+var constants_3 = require("../../../utils/constants");
+var constants_4 = require("../constants");
+var parseUtils_1 = require("../parseUtils");
+var constants_5 = require("./constants");
 /**
  * SplitsUpdateWorker factory
  */
-function SplitsUpdateWorker(log, splitsCache, splitsSyncTask, splitsEventEmitter, telemetryTracker, segmentsSyncTask) {
-    var maxChangeNumber = 0;
-    var handleNewEvent = false;
-    var isHandlingEvent;
-    var cdnBypass;
-    var payload;
-    var backoff = new Backoff_1.Backoff(__handleSplitUpdateCall, constants_3.FETCH_BACKOFF_BASE, constants_3.FETCH_BACKOFF_MAX_WAIT);
-    function __handleSplitUpdateCall() {
-        isHandlingEvent = true;
-        if (maxChangeNumber > splitsCache.getChangeNumber()) {
-            handleNewEvent = false;
-            var splitUpdateNotification_1 = payload ? { payload: payload, changeNumber: maxChangeNumber } : undefined;
-            // fetch splits revalidating data if cached
-            splitsSyncTask.execute(true, cdnBypass ? maxChangeNumber : undefined, splitUpdateNotification_1).then(function () {
-                if (!isHandlingEvent)
-                    return; // halt if `stop` has been called
-                if (handleNewEvent) {
-                    __handleSplitUpdateCall();
-                }
-                else {
-                    if (splitUpdateNotification_1)
-                        telemetryTracker.trackUpdatesFromSSE(constants_2.SPLITS);
-                    // fetch new registered segments for server-side API. Not retrying on error
-                    if (segmentsSyncTask)
-                        segmentsSyncTask.execute(true);
-                    var attempts = backoff.attempts + 1;
-                    if (maxChangeNumber <= splitsCache.getChangeNumber()) {
-                        log.debug("Refresh completed" + (cdnBypass ? ' bypassing the CDN' : '') + " in " + attempts + " attempts.");
-                        isHandlingEvent = false;
-                        return;
-                    }
-                    if (attempts < constants_3.FETCH_BACKOFF_MAX_RETRIES) {
-                        backoff.scheduleCall();
-                        return;
-                    }
-                    if (cdnBypass) {
-                        log.debug("No changes fetched after " + attempts + " attempts with CDN bypassed.");
-                        isHandlingEvent = false;
+function SplitsUpdateWorker(log, storage, splitsSyncTask, splitsEventEmitter, telemetryTracker, segmentsSyncTask) {
+    var ff = SplitsUpdateWorker(storage.splits);
+    var rbs = SplitsUpdateWorker(storage.rbSegments);
+    function SplitsUpdateWorker(cache) {
+        var maxChangeNumber = -1;
+        var handleNewEvent = false;
+        var isHandlingEvent;
+        var cdnBypass;
+        var instantUpdate;
+        var backoff = new Backoff_1.Backoff(__handleSplitUpdateCall, constants_5.FETCH_BACKOFF_BASE, constants_5.FETCH_BACKOFF_MAX_WAIT);
+        function __handleSplitUpdateCall() {
+            isHandlingEvent = true;
+            if (maxChangeNumber > cache.getChangeNumber()) {
+                handleNewEvent = false;
+                // fetch splits revalidating data if cached
+                splitsSyncTask.execute(true, cdnBypass ? maxChangeNumber : undefined, instantUpdate).then(function () {
+                    if (!isHandlingEvent)
+                        return; // halt if `stop` has been called
+                    if (handleNewEvent) {
+                        __handleSplitUpdateCall();
                     }
                     else {
-                        backoff.reset();
-                        cdnBypass = true;
-                        __handleSplitUpdateCall();
+                        if (instantUpdate)
+                            telemetryTracker.trackUpdatesFromSSE(constants_3.SPLITS);
+                        // fetch new registered segments for server-side API. Not retrying on error
+                        if (segmentsSyncTask)
+                            segmentsSyncTask.execute(true);
+                        var attempts = backoff.attempts + 1;
+                        if (ff.isSync() && rbs.isSync()) {
+                            log.debug("Refresh completed" + (cdnBypass ? ' bypassing the CDN' : '') + " in " + attempts + " attempts.");
+                            isHandlingEvent = false;
+                            return;
+                        }
+                        if (attempts < constants_5.FETCH_BACKOFF_MAX_RETRIES) {
+                            backoff.scheduleCall();
+                            return;
+                        }
+                        if (cdnBypass) {
+                            log.debug("No changes fetched after " + attempts + " attempts with CDN bypassed.");
+                            isHandlingEvent = false;
+                        }
+                        else {
+                            backoff.reset();
+                            cdnBypass = true;
+                            __handleSplitUpdateCall();
+                        }
                     }
-                }
-            });
-        }
-        else {
-            isHandlingEvent = false;
-        }
-    }
-    /**
-     * Invoked by NotificationProcessor on SPLIT_UPDATE event
-     *
-     * @param changeNumber - change number of the SPLIT_UPDATE notification
-     */
-    function put(_a, _payload) {
-        var changeNumber = _a.changeNumber, pcn = _a.pcn;
-        var currentChangeNumber = splitsCache.getChangeNumber();
-        if (changeNumber <= currentChangeNumber || changeNumber <= maxChangeNumber)
-            return;
-        maxChangeNumber = changeNumber;
-        handleNewEvent = true;
-        cdnBypass = false;
-        payload = undefined;
-        if (_payload && currentChangeNumber === pcn) {
-            payload = _payload;
+                });
+            }
+            else {
+                isHandlingEvent = false;
+            }
         }
-        if (backoff.timeoutID || !isHandlingEvent)
-            __handleSplitUpdateCall();
-        backoff.reset();
+        return {
+            /**
+             * Invoked by NotificationProcessor on SPLIT_UPDATE or RB_SEGMENT_UPDATE event
+             *
+             * @param changeNumber - change number of the notification
+             */
+            put: function (_a, payload) {
+                var changeNumber = _a.changeNumber, pcn = _a.pcn, type = _a.type;
+                var currentChangeNumber = cache.getChangeNumber();
+                if (changeNumber <= currentChangeNumber || changeNumber <= maxChangeNumber)
+                    return;
+                maxChangeNumber = changeNumber;
+                handleNewEvent = true;
+                cdnBypass = false;
+                instantUpdate = undefined;
+                if (payload && currentChangeNumber === pcn) {
+                    instantUpdate = { payload: payload, changeNumber: changeNumber, type: type };
+                }
+                if (backoff.timeoutID || !isHandlingEvent)
+                    __handleSplitUpdateCall();
+                backoff.reset();
+            },
+            stop: function () {
+                isHandlingEvent = false;
+                backoff.reset();
+            },
+            isSync: function () {
+                return maxChangeNumber <= cache.getChangeNumber();
+            }
+        };
     }
     return {
-        put: put,
+        put: function (parsedData) {
+            if (parsedData.d && parsedData.c !== undefined) {
+                try {
+                    var payload = (0, parseUtils_1.parseFFUpdatePayload)(parsedData.c, parsedData.d);
+                    if (payload) {
+                        (parsedData.type === constants_4.RB_SEGMENT_UPDATE ? rbs : ff).put(parsedData, payload);
+                        return;
+                    }
+                }
+                catch (e) {
+                    log.warn(constants_1.STREAMING_PARSING_SPLIT_UPDATE, [parsedData.type, e]);
+                }
+            }
+            (parsedData.type === constants_4.RB_SEGMENT_UPDATE ? rbs : ff).put(parsedData);
+        },
         /**
          * Invoked by NotificationProcessor on SPLIT_KILL event
          *
-         * @param changeNumber - change number of the SPLIT_UPDATE notification
+         * @param changeNumber - change number of the notification
          * @param splitName - name of split to kill
          * @param defaultTreatment - default treatment value
          */
         killSplit: function (_a) {
             var changeNumber = _a.changeNumber, splitName = _a.splitName, defaultTreatment = _a.defaultTreatment;
-            if (splitsCache.killLocally(splitName, defaultTreatment, changeNumber)) {
+            if (storage.splits.killLocally(splitName, defaultTreatment, changeNumber)) {
                 // trigger an SDK_UPDATE if Split was killed locally
-                splitsEventEmitter.emit(constants_1.SDK_SPLITS_ARRIVED, true);
+                splitsEventEmitter.emit(constants_2.SDK_SPLITS_ARRIVED, true);
             }
             // queues the SplitChanges fetch (only if changeNumber is newer)
-            put({ changeNumber: changeNumber });
+            ff.put({ changeNumber: changeNumber });
         },
         stop: function () {
-            isHandlingEvent = false;
-            backoff.reset();
+            ff.stop();
+            rbs.stop();
         }
     };
 }

package/cjs/sync/streaming/constants.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.ControlType = exports.OCCUPANCY = exports.CONTROL = exports.SPLIT_UPDATE = exports.SPLIT_KILL = exports.SEGMENT_UPDATE = exports.MEMBERSHIPS_LS_UPDATE = exports.MEMBERSHIPS_MS_UPDATE = exports.PUSH_SUBSYSTEM_DOWN = exports.PUSH_SUBSYSTEM_UP = exports.PUSH_RETRYABLE_ERROR = exports.PUSH_NONRETRYABLE_ERROR = exports.SECONDS_BEFORE_EXPIRATION = void 0;
+exports.ControlType = exports.OCCUPANCY = exports.CONTROL = exports.RB_SEGMENT_UPDATE = exports.SPLIT_UPDATE = exports.SPLIT_KILL = exports.SEGMENT_UPDATE = exports.MEMBERSHIPS_LS_UPDATE = exports.MEMBERSHIPS_MS_UPDATE = exports.PUSH_SUBSYSTEM_DOWN = exports.PUSH_SUBSYSTEM_UP = exports.PUSH_RETRYABLE_ERROR = exports.PUSH_NONRETRYABLE_ERROR = exports.SECONDS_BEFORE_EXPIRATION = void 0;
 // time for refresh token
 exports.SECONDS_BEFORE_EXPIRATION = 600;
 // Internal SDK events, subscribed by SyncManager and PushManager
@@ -30,6 +30,7 @@ exports.MEMBERSHIPS_LS_UPDATE = 'MEMBERSHIPS_LS_UPDATE';
 exports.SEGMENT_UPDATE = 'SEGMENT_UPDATE';
 exports.SPLIT_KILL = 'SPLIT_KILL';
 exports.SPLIT_UPDATE = 'SPLIT_UPDATE';
+exports.RB_SEGMENT_UPDATE = 'RB_SEGMENT_UPDATE';
 // Control-type push notifications, handled by NotificationKeeper
 exports.CONTROL = 'CONTROL';
 exports.OCCUPANCY = 'OCCUPANCY';

package/cjs/sync/streaming/pushManager.js

@@ -46,7 +46,7 @@ function pushManagerFactory(params, pollingManager) {
     // MySegmentsUpdateWorker (client-side) are initiated in `add` method
     var segmentsUpdateWorker = userKey ? undefined : (0, SegmentsUpdateWorker_1.SegmentsUpdateWorker)(log, pollingManager.segmentsSyncTask, storage.segments);
     // For server-side we pass the segmentsSyncTask, used by SplitsUpdateWorker to fetch new segments
-    var splitsUpdateWorker = (0, SplitsUpdateWorker_1.SplitsUpdateWorker)(log, storage.splits, pollingManager.splitsSyncTask, readiness.splits, telemetryTracker, userKey ? undefined : pollingManager.segmentsSyncTask);
+    var splitsUpdateWorker = (0, SplitsUpdateWorker_1.SplitsUpdateWorker)(log, storage, pollingManager.splitsSyncTask, readiness.splits, telemetryTracker, userKey ? undefined : pollingManager.segmentsSyncTask);
     // [Only for client-side] map of hashes to user keys, to dispatch membership update events to the corresponding MySegmentsUpdateWorker
     var userKeyHashes = {};
     // [Only for client-side] map of user keys to their corresponding hash64 and MySegmentsUpdateWorkers.
@@ -182,21 +182,8 @@ function pushManagerFactory(params, pollingManager) {
     });
     /** Functions related to synchronization (Queues and Workers in the spec) */
     pushEmitter.on(constants_1.SPLIT_KILL, splitsUpdateWorker.killSplit);
-    pushEmitter.on(constants_1.SPLIT_UPDATE, function (parsedData) {
-        if (parsedData.d && parsedData.c !== undefined) {
-            try {
-                var payload = (0, parseUtils_1.parseFFUpdatePayload)(parsedData.c, parsedData.d);
-                if (payload) {
-                    splitsUpdateWorker.put(parsedData, payload);
-                    return;
-                }
-            }
-            catch (e) {
-                log.warn(constants_2.STREAMING_PARSING_SPLIT_UPDATE, [e]);
-            }
-        }
-        splitsUpdateWorker.put(parsedData);
-    });
+    pushEmitter.on(constants_1.SPLIT_UPDATE, splitsUpdateWorker.put);
+    pushEmitter.on(constants_1.RB_SEGMENT_UPDATE, splitsUpdateWorker.put);
     function handleMySegmentsUpdate(parsedData) {
         switch (parsedData.u) {
             case types_1.UpdateStrategy.BoundedFetchRequest: {

package/cjs/sync/syncManagerOnline.js

@@ -125,7 +125,7 @@ function syncManagerOnlineFactory(pollingManagerFactory, pushManagerFactory) {
                         if (pushManager) {
                             if (pollingManager.isRunning()) {
                                 // if doing polling, we must start the periodic fetch of data
-                                if (storage.splits.usesSegments())
+                                if (storage.splits.usesSegments() || storage.rbSegments.usesSegments())
                                     mySegmentsSyncTask.start();
                             }
                             else {
@@ -135,7 +135,7 @@ function syncManagerOnlineFactory(pollingManagerFactory, pushManagerFactory) {
                             }
                         }
                         else {
-                            if (storage.splits.usesSegments())
+                            if (storage.splits.usesSegments() || storage.rbSegments.usesSegments())
                                 mySegmentsSyncTask.start();
                         }
                     }

package/cjs/utils/constants/index.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.MEMBERSHIPS = exports.SEGMENT = exports.TOKEN = exports.TELEMETRY = exports.EVENTS = exports.IMPRESSIONS_COUNT = exports.IMPRESSIONS = exports.SPLITS = exports.NONE_ENUM = exports.DEBUG_ENUM = exports.OPTIMIZED_ENUM = exports.CONSUMER_PARTIAL_ENUM = exports.CONSUMER_ENUM = exports.STANDALONE_ENUM = exports.DEDUPED = exports.DROPPED = exports.QUEUED = exports.NAMES_FN_LABEL = exports.SPLITS_FN_LABEL = exports.SPLIT_FN_LABEL = exports.TRACK_FN_LABEL = exports.GET_TREATMENTS_WITH_CONFIG_BY_FLAG_SETS = exports.GET_TREATMENTS_WITH_CONFIG_BY_FLAG_SET = exports.GET_TREATMENTS_BY_FLAG_SETS = exports.GET_TREATMENTS_BY_FLAG_SET = exports.GET_TREATMENTS_WITH_CONFIG = exports.GET_TREATMENT_WITH_CONFIG = exports.GET_TREATMENTS = exports.GET_TREATMENT = exports.CONSENT_UNKNOWN = exports.CONSENT_DECLINED = exports.CONSENT_GRANTED = exports.STORAGE_PLUGGABLE = exports.STORAGE_REDIS = exports.STORAGE_LOCALSTORAGE = exports.STORAGE_MEMORY = exports.CONSUMER_PARTIAL_MODE = exports.CONSUMER_MODE = exports.PRODUCER_MODE = exports.STANDALONE_MODE = exports.LOCALHOST_MODE = exports.NONE = exports.OPTIMIZED = exports.DEBUG = exports.SPLIT_EVENT = exports.SPLIT_IMPRESSION = exports.NA = exports.UNKNOWN = exports.CONTROL_WITH_CONFIG = exports.CONTROL = void 0;
-exports.IN_LARGE_SEGMENT = exports.IN_SEGMENT = exports.FLAG_SPEC_VERSION = exports.PAUSED = exports.ENABLED = exports.DISABLED = exports.NON_REQUESTED = exports.REQUESTED = exports.POLLING = exports.STREAMING = exports.AUTH_REJECTION = exports.SYNC_MODE_UPDATE = exports.ABLY_ERROR = exports.TOKEN_REFRESH = exports.SSE_CONNECTION_ERROR = exports.STREAMING_STATUS = exports.OCCUPANCY_SEC = exports.OCCUPANCY_PRI = exports.CONNECTION_ESTABLISHED = exports.TRACK = exports.TREATMENTS_WITH_CONFIG_BY_FLAGSETS = exports.TREATMENTS_WITH_CONFIG_BY_FLAGSET = exports.TREATMENTS_BY_FLAGSETS = exports.TREATMENTS_BY_FLAGSET = exports.TREATMENTS_WITH_CONFIG = exports.TREATMENT_WITH_CONFIG = exports.TREATMENTS = exports.TREATMENT = void 0;
+exports.IN_RULE_BASED_SEGMENT = exports.IN_LARGE_SEGMENT = exports.IN_SEGMENT = exports.FLAG_SPEC_VERSION = exports.PAUSED = exports.ENABLED = exports.DISABLED = exports.NON_REQUESTED = exports.REQUESTED = exports.POLLING = exports.STREAMING = exports.AUTH_REJECTION = exports.SYNC_MODE_UPDATE = exports.ABLY_ERROR = exports.TOKEN_REFRESH = exports.SSE_CONNECTION_ERROR = exports.STREAMING_STATUS = exports.OCCUPANCY_SEC = exports.OCCUPANCY_PRI = exports.CONNECTION_ESTABLISHED = exports.TRACK = exports.TREATMENTS_WITH_CONFIG_BY_FLAGSETS = exports.TREATMENTS_WITH_CONFIG_BY_FLAGSET = exports.TREATMENTS_BY_FLAGSETS = exports.TREATMENTS_BY_FLAGSET = exports.TREATMENTS_WITH_CONFIG = exports.TREATMENT_WITH_CONFIG = exports.TREATMENTS = exports.TREATMENT = void 0;
 // Special treatments
 exports.CONTROL = 'control';
 exports.CONTROL_WITH_CONFIG = {
@@ -90,7 +90,8 @@ exports.NON_REQUESTED = 1;
 exports.DISABLED = 0;
 exports.ENABLED = 1;
 exports.PAUSED = 2;
-exports.FLAG_SPEC_VERSION = '1.2';
+exports.FLAG_SPEC_VERSION = '1.3';
 // Matcher types
 exports.IN_SEGMENT = 'IN_SEGMENT';
 exports.IN_LARGE_SEGMENT = 'IN_LARGE_SEGMENT';
+exports.IN_RULE_BASED_SEGMENT = 'IN_RULE_BASED_SEGMENT';

package/esm/evaluator/combiners/and.js

@@ -8,12 +8,8 @@ export function andCombinerContext(log, matchers) {
         log.debug(ENGINE_COMBINER_AND, [hasMatchedAll]);
         return hasMatchedAll;
     }
-    return function andCombiner() {
-        var params = [];
-        for (var _i = 0; _i < arguments.length; _i++) {
-            params[_i] = arguments[_i];
-        }
-        var matcherResults = matchers.map(function (matcher) { return matcher.apply(void 0, params); });
+    return function andCombiner(key, attributes, splitEvaluator) {
+        var matcherResults = matchers.map(function (matcher) { return matcher(key, attributes, splitEvaluator); });
         // If any matching result is a thenable we should use Promise.all
         if (findIndex(matcherResults, thenable) !== -1) {
             return Promise.all(matcherResults).then(andResults);

package/esm/evaluator/combiners/ifelseif.js

@@ -1,4 +1,4 @@
-import { findIndex } from '../../utils/lang';
+import { findIndex, isBoolean } from '../../utils/lang';
 import { thenable } from '../../utils/promise/thenable';
 import { UNSUPPORTED_MATCHER_TYPE } from '../../utils/labels';
 import { CONTROL } from '../../utils/constants';
@@ -11,12 +11,12 @@ export function ifElseIfCombinerContext(log, predicates) {
             label: UNSUPPORTED_MATCHER_TYPE
         };
     }
-    function computeTreatment(predicateResults) {
-        var len = predicateResults.length;
-        for (var i = 0; i < len; i++) {
+    function computeEvaluation(predicateResults) {
+        for (var i = 0, len = predicateResults.length; i < len; i++) {
             var evaluation = predicateResults[i];
             if (evaluation !== undefined) {
-                log.debug(ENGINE_COMBINER_IFELSEIF, [evaluation.treatment]);
+                if (!isBoolean(evaluation))
+                    log.debug(ENGINE_COMBINER_IFELSEIF, [evaluation.treatment]);
                 return evaluation;
             }
         }
@@ -30,9 +30,9 @@ export function ifElseIfCombinerContext(log, predicates) {
         var predicateResults = predicates.map(function (evaluator) { return evaluator(key, seed, trafficAllocation, trafficAllocationSeed, attributes, splitEvaluator); });
         // if we find a thenable
         if (findIndex(predicateResults, thenable) !== -1) {
-            return Promise.all(predicateResults).then(function (results) { return computeTreatment(results); });
+            return Promise.all(predicateResults).then(function (results) { return computeEvaluation(results); });
         }
-        return computeTreatment(predicateResults);
+        return computeEvaluation(predicateResults);
     }
     // if there is none predicates, then there was an error in parsing phase
     if (!Array.isArray(predicates) || predicates.length === 0) {

package/esm/evaluator/condition/index.js

@@ -4,11 +4,12 @@ import { NOT_IN_SPLIT } from '../../utils/labels';
 // Build Evaluation object if and only if matchingResult is true
 function match(log, matchingResult, bucketingKey, seed, treatments, label) {
     if (matchingResult) {
-        var treatment = getTreatment(log, bucketingKey, seed, treatments);
-        return {
-            treatment: treatment,
-            label: label
-        };
+        return treatments ? // Feature flag
+            {
+                treatment: getTreatment(log, bucketingKey, seed, treatments),
+                label: label
+            } : // Rule-based segment
+            true;
     }
     // else we should notify the engine to continue evaluating
     return undefined;

package/esm/evaluator/index.js

@@ -26,12 +26,12 @@ export function evaluateFeature(log, key, splitName, attributes, storage) {
         return treatmentException;
     }
     if (thenable(parsedSplit)) {
-        return parsedSplit.then(function (split) { return getEvaluation(log, split, key, attributes, storage); }).catch(
+        return parsedSplit.then(function (split) { return getEvaluation(log, key, split, attributes, storage); }).catch(
         // Exception on async `getSplit` storage. For example, when the storage is redis or
         // pluggable and there is a connection issue and we can't retrieve the split to be evaluated
         function () { return treatmentException; });
     }
-    return getEvaluation(log, parsedSplit, key, attributes, storage);
+    return getEvaluation(log, key, parsedSplit, attributes, storage);
 }
 export function evaluateFeatures(log, key, splitNames, attributes, storage) {
     var parsedSplits;
@@ -43,13 +43,13 @@ export function evaluateFeatures(log, key, splitNames, attributes, storage) {
         return treatmentsException(splitNames);
     }
     return thenable(parsedSplits) ?
-        parsedSplits.then(function (splits) { return getEvaluations(log, splitNames, splits, key, attributes, storage); })
+        parsedSplits.then(function (splits) { return getEvaluations(log, key, splitNames, splits, attributes, storage); })
             .catch(function () {
             // Exception on async `getSplits` storage. For example, when the storage is redis or
             // pluggable and there is a connection issue and we can't retrieve the split to be evaluated
             return treatmentsException(splitNames);
         }) :
-        getEvaluations(log, splitNames, parsedSplits, key, attributes, storage);
+        getEvaluations(log, key, splitNames, parsedSplits, attributes, storage);
 }
 export function evaluateFeaturesByFlagSets(log, key, flagSets, attributes, storage, method) {
     var storedFlagNames;
@@ -84,7 +84,7 @@ export function evaluateFeaturesByFlagSets(log, key, flagSets, attributes, stora
         }) :
         evaluate(storedFlagNames);
 }
-function getEvaluation(log, splitJSON, key, attributes, storage) {
+function getEvaluation(log, key, splitJSON, attributes, storage) {
     var evaluation = {
         treatment: CONTROL,
         label: SPLIT_NOT_FOUND,
@@ -110,11 +110,11 @@ function getEvaluation(log, splitJSON, key, attributes, storage) {
     }
     return evaluation;
 }
-function getEvaluations(log, splitNames, splits, key, attributes, storage) {
+function getEvaluations(log, key, splitNames, splits, attributes, storage) {
     var result = {};
     var thenables = [];
     splitNames.forEach(function (splitName) {
-        var evaluation = getEvaluation(log, splits[splitName], key, attributes, storage);
+        var evaluation = getEvaluation(log, key, splits[splitName], attributes, storage);
         if (thenable(evaluation)) {
             thenables.push(evaluation.then(function (res) {
                 result[splitName] = res;