@splitsoftware/splitio-commons 2.1.0-rc.2 → 2.1.1-rc.0

package/cjs/storages/inLocalStorage/RBSegmentsCacheInLocal.js

@@ -0,0 +1,117 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RBSegmentsCacheInLocal = void 0;
+var lang_1 = require("../../utils/lang");
+var sets_1 = require("../../utils/lang/sets");
+var AbstractSplitsCacheSync_1 = require("../AbstractSplitsCacheSync");
+var constants_1 = require("./constants");
+var RBSegmentsCacheInLocal = /** @class */ (function () {
+    function RBSegmentsCacheInLocal(settings, keys) {
+        this.keys = keys;
+        this.log = settings.log;
+    }
+    RBSegmentsCacheInLocal.prototype.clear = function () {
+        var _this = this;
+        this.getNames().forEach(function (name) { return _this.remove(name); });
+        localStorage.removeItem(this.keys.buildRBSegmentsTillKey());
+    };
+    RBSegmentsCacheInLocal.prototype.update = function (toAdd, toRemove, changeNumber) {
+        var _this = this;
+        this.setChangeNumber(changeNumber);
+        var updated = toAdd.map(function (toAdd) { return _this.add(toAdd); }).some(function (result) { return result; });
+        return toRemove.map(function (toRemove) { return _this.remove(toRemove.name); }).some(function (result) { return result; }) || updated;
+    };
+    RBSegmentsCacheInLocal.prototype.setChangeNumber = function (changeNumber) {
+        try {
+            localStorage.setItem(this.keys.buildRBSegmentsTillKey(), changeNumber + '');
+            localStorage.setItem(this.keys.buildLastUpdatedKey(), Date.now() + '');
+        }
+        catch (e) {
+            this.log.error(constants_1.LOG_PREFIX + e);
+        }
+    };
+    RBSegmentsCacheInLocal.prototype.updateSegmentCount = function (diff) {
+        var segmentsCountKey = this.keys.buildSplitsWithSegmentCountKey();
+        var count = (0, lang_1.toNumber)(localStorage.getItem(segmentsCountKey)) + diff;
+        // @ts-expect-error
+        if (count > 0)
+            localStorage.setItem(segmentsCountKey, count);
+        else
+            localStorage.removeItem(segmentsCountKey);
+    };
+    RBSegmentsCacheInLocal.prototype.add = function (rbSegment) {
+        try {
+            var name_1 = rbSegment.name;
+            var rbSegmentKey = this.keys.buildRBSegmentKey(name_1);
+            var rbSegmentFromLocalStorage = localStorage.getItem(rbSegmentKey);
+            var previous = rbSegmentFromLocalStorage ? JSON.parse(rbSegmentFromLocalStorage) : null;
+            localStorage.setItem(rbSegmentKey, JSON.stringify(rbSegment));
+            var usesSegmentsDiff = 0;
+            if (previous && (0, AbstractSplitsCacheSync_1.usesSegments)(previous))
+                usesSegmentsDiff--;
+            if ((0, AbstractSplitsCacheSync_1.usesSegments)(rbSegment))
+                usesSegmentsDiff++;
+            if (usesSegmentsDiff !== 0)
+                this.updateSegmentCount(usesSegmentsDiff);
+            return true;
+        }
+        catch (e) {
+            this.log.error(constants_1.LOG_PREFIX + e);
+            return false;
+        }
+    };
+    RBSegmentsCacheInLocal.prototype.remove = function (name) {
+        try {
+            var rbSegment = this.get(name);
+            if (!rbSegment)
+                return false;
+            localStorage.removeItem(this.keys.buildRBSegmentKey(name));
+            if ((0, AbstractSplitsCacheSync_1.usesSegments)(rbSegment))
+                this.updateSegmentCount(-1);
+            return true;
+        }
+        catch (e) {
+            this.log.error(constants_1.LOG_PREFIX + e);
+            return false;
+        }
+    };
+    RBSegmentsCacheInLocal.prototype.getNames = function () {
+        var len = localStorage.length;
+        var accum = [];
+        var cur = 0;
+        while (cur < len) {
+            var key = localStorage.key(cur);
+            if (key != null && this.keys.isRBSegmentKey(key))
+                accum.push(this.keys.extractKey(key));
+            cur++;
+        }
+        return accum;
+    };
+    RBSegmentsCacheInLocal.prototype.get = function (name) {
+        var item = localStorage.getItem(this.keys.buildRBSegmentKey(name));
+        return item && JSON.parse(item);
+    };
+    RBSegmentsCacheInLocal.prototype.contains = function (names) {
+        var namesArray = (0, sets_1.setToArray)(names);
+        var namesInStorage = this.getNames();
+        return namesArray.every(function (name) { return namesInStorage.indexOf(name) !== -1; });
+    };
+    RBSegmentsCacheInLocal.prototype.getChangeNumber = function () {
+        var n = -1;
+        var value = localStorage.getItem(this.keys.buildRBSegmentsTillKey());
+        if (value !== null) {
+            value = parseInt(value, 10);
+            return (0, lang_1.isNaNNumber)(value) ? n : value;
+        }
+        return n;
+    };
+    RBSegmentsCacheInLocal.prototype.usesSegments = function () {
+        var storedCount = localStorage.getItem(this.keys.buildSplitsWithSegmentCountKey());
+        var splitsWithSegmentsCount = storedCount === null ? 0 : (0, lang_1.toNumber)(storedCount);
+        return (0, lang_1.isFiniteNumber)(splitsWithSegmentsCount) ?
+            splitsWithSegmentsCount > 0 :
+            true;
+    };
+    return RBSegmentsCacheInLocal;
+}());
+exports.RBSegmentsCacheInLocal = RBSegmentsCacheInLocal;

package/cjs/storages/inLocalStorage/SplitsCacheInLocal.js

@@ -5,17 +5,21 @@ var tslib_1 = require("tslib");
 var AbstractSplitsCacheSync_1 = require("../AbstractSplitsCacheSync");
 var lang_1 = require("../../utils/lang");
 var constants_1 = require("./constants");
+var KeyBuilder_1 = require("../KeyBuilder");
 var sets_1 = require("../../utils/lang/sets");
 /**
  * ISplitsCacheSync implementation that stores split definitions in browser LocalStorage.
  */
 var SplitsCacheInLocal = /** @class */ (function (_super) {
     (0, tslib_1.__extends)(SplitsCacheInLocal, _super);
-    function SplitsCacheInLocal(settings, keys) {
+    function SplitsCacheInLocal(settings, keys, expirationTimestamp) {
         var _this = _super.call(this) || this;
         _this.keys = keys;
         _this.log = settings.log;
+        _this.storageHash = (0, KeyBuilder_1.getStorageHash)(settings);
         _this.flagSetsFilter = settings.sync.__splitFiltersValidation.groupedFilters.bySet;
+        _this._checkExpiration(expirationTimestamp);
+        _this._checkFilterQuery();
         return _this;
     }
     SplitsCacheInLocal.prototype._decrementCount = function (key) {
@@ -43,15 +47,13 @@ var SplitsCacheInLocal = /** @class */ (function (_super) {
     };
     SplitsCacheInLocal.prototype._incrementCounts = function (split) {
         try {
-            if (split) {
-                var ttKey = this.keys.buildTrafficTypeKey(split.trafficTypeName);
+            var ttKey = this.keys.buildTrafficTypeKey(split.trafficTypeName);
+            // @ts-expect-error
+            localStorage.setItem(ttKey, (0, lang_1.toNumber)(localStorage.getItem(ttKey)) + 1);
+            if ((0, AbstractSplitsCacheSync_1.usesSegments)(split)) {
+                var segmentsCountKey = this.keys.buildSplitsWithSegmentCountKey();
                 // @ts-expect-error
-                localStorage.setItem(ttKey, (0, lang_1.toNumber)(localStorage.getItem(ttKey)) + 1);
-                if ((0, AbstractSplitsCacheSync_1.usesSegments)(split)) {
-                    var segmentsCountKey = this.keys.buildSplitsWithSegmentCountKey();
-                    // @ts-expect-error
-                    localStorage.setItem(segmentsCountKey, (0, lang_1.toNumber)(localStorage.getItem(segmentsCountKey)) + 1);
-                }
+                localStorage.setItem(segmentsCountKey, (0, lang_1.toNumber)(localStorage.getItem(segmentsCountKey)) + 1);
             }
         }
         catch (e) {
@@ -63,6 +65,7 @@ var SplitsCacheInLocal = /** @class */ (function (_super) {
      * We cannot simply call `localStorage.clear()` since that implies removing user items from the storage.
      */
     SplitsCacheInLocal.prototype.clear = function () {
+        this.log.info(constants_1.LOG_PREFIX + 'Flushing Splits data from localStorage');
         // collect item keys
         var len = localStorage.length;
         var accum = [];
@@ -77,9 +80,10 @@ var SplitsCacheInLocal = /** @class */ (function (_super) {
         });
         this.hasSync = false;
     };
-    SplitsCacheInLocal.prototype.addSplit = function (name, split) {
+    SplitsCacheInLocal.prototype.addSplit = function (split) {
         try {
-            var splitKey = this.keys.buildSplitKey(name);
+            var name_1 = split.name;
+            var splitKey = this.keys.buildSplitKey(name_1);
             var splitFromLocalStorage = localStorage.getItem(splitKey);
             var previousSplit = splitFromLocalStorage ? JSON.parse(splitFromLocalStorage) : null;
             localStorage.setItem(splitKey, JSON.stringify(split));
@@ -98,6 +102,8 @@ var SplitsCacheInLocal = /** @class */ (function (_super) {
     SplitsCacheInLocal.prototype.removeSplit = function (name) {
         try {
             var split = this.getSplit(name);
+            if (!split)
+                return false;
             localStorage.removeItem(this.keys.buildSplitKey(name));
             this._decrementCounts(split);
             if (split)
@@ -114,6 +120,18 @@ var SplitsCacheInLocal = /** @class */ (function (_super) {
         return item && JSON.parse(item);
     };
     SplitsCacheInLocal.prototype.setChangeNumber = function (changeNumber) {
+        // when using a new split query, we must update it at the store
+        if (this.updateNewFilter) {
+            this.log.info(constants_1.LOG_PREFIX + 'SDK key, flags filter criteria or flags spec version was modified. Updating cache');
+            var storageHashKey = this.keys.buildHashKey();
+            try {
+                localStorage.setItem(storageHashKey, this.storageHash);
+            }
+            catch (e) {
+                this.log.error(constants_1.LOG_PREFIX + e);
+            }
+            this.updateNewFilter = false;
+        }
         try {
             localStorage.setItem(this.keys.buildSplitsTillKey(), changeNumber + '');
             // update "last updated" timestamp with current time
@@ -157,12 +175,48 @@ var SplitsCacheInLocal = /** @class */ (function (_super) {
             return true;
         var storedCount = localStorage.getItem(this.keys.buildSplitsWithSegmentCountKey());
         var splitsWithSegmentsCount = storedCount === null ? 0 : (0, lang_1.toNumber)(storedCount);
-        if ((0, lang_1.isFiniteNumber)(splitsWithSegmentsCount)) {
-            return splitsWithSegmentsCount > 0;
+        return (0, lang_1.isFiniteNumber)(splitsWithSegmentsCount) ?
+            splitsWithSegmentsCount > 0 :
+            true;
+    };
+    /**
+     * Check if the splits information is already stored in browser LocalStorage.
+     * In this function we could add more code to check if the data is valid.
+     * @override
+     */
+    SplitsCacheInLocal.prototype.checkCache = function () {
+        return this.getChangeNumber() > -1;
+    };
+    /**
+     * Clean Splits cache if its `lastUpdated` timestamp is older than the given `expirationTimestamp`,
+     *
+     * @param expirationTimestamp - if the value is not a number, data will not be cleaned
+     */
+    SplitsCacheInLocal.prototype._checkExpiration = function (expirationTimestamp) {
+        var value = localStorage.getItem(this.keys.buildLastUpdatedKey());
+        if (value !== null) {
+            value = parseInt(value, 10);
+            if (!(0, lang_1.isNaNNumber)(value) && expirationTimestamp && value < expirationTimestamp)
+                this.clear();
         }
-        else {
-            return true;
+    };
+    // @TODO eventually remove `_checkFilterQuery`. Cache should be cleared at the storage level, reusing same logic than PluggableStorage
+    SplitsCacheInLocal.prototype._checkFilterQuery = function () {
+        var storageHashKey = this.keys.buildHashKey();
+        var storageHash = localStorage.getItem(storageHashKey);
+        if (storageHash !== this.storageHash) {
+            try {
+                // mark cache to update the new query filter on first successful splits fetch
+                this.updateNewFilter = true;
+                // if there is cache, clear it
+                if (this.checkCache())
+                    this.clear();
+            }
+            catch (e) {
+                this.log.error(constants_1.LOG_PREFIX + e);
+            }
         }
+        // if the filter didn't change, nothing is done
     };
     SplitsCacheInLocal.prototype.getNamesByFlagSets = function (flagSets) {
         var _this = this;

package/cjs/storages/inLocalStorage/index.js

@@ -9,13 +9,14 @@ var KeyBuilderCS_1 = require("../KeyBuilderCS");
 var isLocalStorageAvailable_1 = require("../../utils/env/isLocalStorageAvailable");
 var SplitsCacheInLocal_1 = require("./SplitsCacheInLocal");
 var MySegmentsCacheInLocal_1 = require("./MySegmentsCacheInLocal");
+var browser_1 = require("../../utils/constants/browser");
 var InMemoryStorageCS_1 = require("../inMemory/InMemoryStorageCS");
 var constants_1 = require("./constants");
 var constants_2 = require("../../utils/constants");
 var TelemetryCacheInMemory_1 = require("../inMemory/TelemetryCacheInMemory");
 var UniqueKeysCacheInMemoryCS_1 = require("../inMemory/UniqueKeysCacheInMemoryCS");
 var key_1 = require("../../utils/key");
-var validateCache_1 = require("./validateCache");
+var RBSegmentsCacheInLocal_1 = require("./RBSegmentsCacheInLocal");
 /**
  * InLocal storage factory for standalone client-side SplitFactory
  */
@@ -31,11 +32,14 @@ function InLocalStorage(options) {
         var settings = params.settings, _a = params.settings, log = _a.log, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize;
         var matchingKey = (0, key_1.getMatching)(settings.core.key);
         var keys = new KeyBuilderCS_1.KeyBuilderCS(prefix, matchingKey);
-        var splits = new SplitsCacheInLocal_1.SplitsCacheInLocal(settings, keys);
+        var expirationTimestamp = Date.now() - browser_1.DEFAULT_CACHE_EXPIRATION_IN_MILLIS;
+        var splits = new SplitsCacheInLocal_1.SplitsCacheInLocal(settings, keys, expirationTimestamp);
+        var rbSegments = new RBSegmentsCacheInLocal_1.RBSegmentsCacheInLocal(settings, keys);
         var segments = new MySegmentsCacheInLocal_1.MySegmentsCacheInLocal(log, keys);
         var largeSegments = new MySegmentsCacheInLocal_1.MySegmentsCacheInLocal(log, (0, KeyBuilderCS_1.myLargeSegmentsKeyBuilder)(prefix, matchingKey));
         return {
             splits: splits,
+            rbSegments: rbSegments,
             segments: segments,
             largeSegments: largeSegments,
             impressions: new ImpressionsCacheInMemory_1.ImpressionsCacheInMemory(impressionsQueueSize),
@@ -43,14 +47,12 @@ function InLocalStorage(options) {
             events: new EventsCacheInMemory_1.EventsCacheInMemory(eventsQueueSize),
             telemetry: (0, TelemetryCacheInMemory_1.shouldRecordTelemetry)(params) ? new TelemetryCacheInMemory_1.TelemetryCacheInMemory(splits, segments) : undefined,
             uniqueKeys: new UniqueKeysCacheInMemoryCS_1.UniqueKeysCacheInMemoryCS(),
-            validateCache: function () {
-                return (0, validateCache_1.validateCache)(options, settings, keys, splits, segments, largeSegments);
-            },
             destroy: function () { },
             // When using shared instantiation with MEMORY we reuse everything but segments (they are customer per key).
             shared: function (matchingKey) {
                 return {
                     splits: this.splits,
+                    rbSegments: this.rbSegments,
                     segments: new MySegmentsCacheInLocal_1.MySegmentsCacheInLocal(log, new KeyBuilderCS_1.KeyBuilderCS(prefix, matchingKey)),
                     largeSegments: new MySegmentsCacheInLocal_1.MySegmentsCacheInLocal(log, (0, KeyBuilderCS_1.myLargeSegmentsKeyBuilder)(prefix, matchingKey)),
                     impressions: this.impressions,

package/cjs/storages/inMemory/InMemoryStorage.js

@@ -9,6 +9,7 @@ var ImpressionCountsCacheInMemory_1 = require("./ImpressionCountsCacheInMemory")
 var constants_1 = require("../../utils/constants");
 var TelemetryCacheInMemory_1 = require("./TelemetryCacheInMemory");
 var UniqueKeysCacheInMemory_1 = require("./UniqueKeysCacheInMemory");
+var RBSegmentsCacheInMemory_1 = require("./RBSegmentsCacheInMemory");
 /**
  * InMemory storage factory for standalone server-side SplitFactory
  *
@@ -17,9 +18,11 @@ var UniqueKeysCacheInMemory_1 = require("./UniqueKeysCacheInMemory");
 function InMemoryStorageFactory(params) {
     var _a = params.settings, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize, __splitFiltersValidation = _a.sync.__splitFiltersValidation;
     var splits = new SplitsCacheInMemory_1.SplitsCacheInMemory(__splitFiltersValidation);
+    var rbSegments = new RBSegmentsCacheInMemory_1.RBSegmentsCacheInMemory();
     var segments = new SegmentsCacheInMemory_1.SegmentsCacheInMemory();
     var storage = {
         splits: splits,
+        rbSegments: rbSegments,
         segments: segments,
         impressions: new ImpressionsCacheInMemory_1.ImpressionsCacheInMemory(impressionsQueueSize),
         impressionCounts: new ImpressionCountsCacheInMemory_1.ImpressionCountsCacheInMemory(),

package/cjs/storages/inMemory/InMemoryStorageCS.js

@@ -9,6 +9,7 @@ var ImpressionCountsCacheInMemory_1 = require("./ImpressionCountsCacheInMemory")
 var constants_1 = require("../../utils/constants");
 var TelemetryCacheInMemory_1 = require("./TelemetryCacheInMemory");
 var UniqueKeysCacheInMemoryCS_1 = require("./UniqueKeysCacheInMemoryCS");
+var RBSegmentsCacheInMemory_1 = require("./RBSegmentsCacheInMemory");
 /**
  * InMemory storage factory for standalone client-side SplitFactory
  *
@@ -17,10 +18,12 @@ var UniqueKeysCacheInMemoryCS_1 = require("./UniqueKeysCacheInMemoryCS");
 function InMemoryStorageCSFactory(params) {
     var _a = params.settings, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize, __splitFiltersValidation = _a.sync.__splitFiltersValidation;
     var splits = new SplitsCacheInMemory_1.SplitsCacheInMemory(__splitFiltersValidation);
+    var rbSegments = new RBSegmentsCacheInMemory_1.RBSegmentsCacheInMemory();
     var segments = new MySegmentsCacheInMemory_1.MySegmentsCacheInMemory();
     var largeSegments = new MySegmentsCacheInMemory_1.MySegmentsCacheInMemory();
     var storage = {
         splits: splits,
+        rbSegments: rbSegments,
         segments: segments,
         largeSegments: largeSegments,
         impressions: new ImpressionsCacheInMemory_1.ImpressionsCacheInMemory(impressionsQueueSize),
@@ -33,6 +36,7 @@ function InMemoryStorageCSFactory(params) {
         shared: function () {
             return {
                 splits: this.splits,
+                rbSegments: this.rbSegments,
                 segments: new MySegmentsCacheInMemory_1.MySegmentsCacheInMemory(),
                 largeSegments: new MySegmentsCacheInMemory_1.MySegmentsCacheInMemory(),
                 impressions: this.impressions,

package/cjs/storages/inMemory/RBSegmentsCacheInMemory.js

@@ -0,0 +1,61 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RBSegmentsCacheInMemory = void 0;
+var sets_1 = require("../../utils/lang/sets");
+var AbstractSplitsCacheSync_1 = require("../AbstractSplitsCacheSync");
+var RBSegmentsCacheInMemory = /** @class */ (function () {
+    function RBSegmentsCacheInMemory() {
+        this.cache = {};
+        this.changeNumber = -1;
+        this.segmentsCount = 0;
+    }
+    RBSegmentsCacheInMemory.prototype.clear = function () {
+        this.cache = {};
+        this.changeNumber = -1;
+        this.segmentsCount = 0;
+    };
+    RBSegmentsCacheInMemory.prototype.update = function (toAdd, toRemove, changeNumber) {
+        var _this = this;
+        this.changeNumber = changeNumber;
+        var updated = toAdd.map(function (toAdd) { return _this.add(toAdd); }).some(function (result) { return result; });
+        return toRemove.map(function (toRemove) { return _this.remove(toRemove.name); }).some(function (result) { return result; }) || updated;
+    };
+    RBSegmentsCacheInMemory.prototype.add = function (rbSegment) {
+        var name = rbSegment.name;
+        var previous = this.get(name);
+        if (previous && (0, AbstractSplitsCacheSync_1.usesSegments)(previous))
+            this.segmentsCount--;
+        this.cache[name] = rbSegment;
+        if ((0, AbstractSplitsCacheSync_1.usesSegments)(rbSegment))
+            this.segmentsCount++;
+        return true;
+    };
+    RBSegmentsCacheInMemory.prototype.remove = function (name) {
+        var rbSegment = this.get(name);
+        if (!rbSegment)
+            return false;
+        delete this.cache[name];
+        if ((0, AbstractSplitsCacheSync_1.usesSegments)(rbSegment))
+            this.segmentsCount--;
+        return true;
+    };
+    RBSegmentsCacheInMemory.prototype.getNames = function () {
+        return Object.keys(this.cache);
+    };
+    RBSegmentsCacheInMemory.prototype.get = function (name) {
+        return this.cache[name] || null;
+    };
+    RBSegmentsCacheInMemory.prototype.contains = function (names) {
+        var namesArray = (0, sets_1.setToArray)(names);
+        var namesInStorage = this.getNames();
+        return namesArray.every(function (name) { return namesInStorage.indexOf(name) !== -1; });
+    };
+    RBSegmentsCacheInMemory.prototype.getChangeNumber = function () {
+        return this.changeNumber;
+    };
+    RBSegmentsCacheInMemory.prototype.usesSegments = function () {
+        return this.segmentsCount > 0;
+    };
+    return RBSegmentsCacheInMemory;
+}());
+exports.RBSegmentsCacheInMemory = RBSegmentsCacheInMemory;

package/cjs/storages/inMemory/SplitsCacheInMemory.js

@@ -25,7 +25,8 @@ var SplitsCacheInMemory = /** @class */ (function (_super) {
         this.changeNumber = -1;
         this.segmentsCount = 0;
     };
-    SplitsCacheInMemory.prototype.addSplit = function (name, split) {
+    SplitsCacheInMemory.prototype.addSplit = function (split) {
+        var name = split.name;
         var previousSplit = this.getSplit(name);
         if (previousSplit) { // We had this Split already
             var previousTtName = previousSplit.trafficTypeName;
@@ -37,40 +38,32 @@ var SplitsCacheInMemory = /** @class */ (function (_super) {
             if ((0, AbstractSplitsCacheSync_1.usesSegments)(previousSplit))
                 this.segmentsCount--;
         }
-        if (split) {
-            // Store the Split.
-            this.splitsCache[name] = split;
-            // Update TT cache
-            var ttName = split.trafficTypeName;
-            this.ttCache[ttName] = (this.ttCache[ttName] || 0) + 1;
-            this.addToFlagSets(split);
-            // Add to segments count for the new version of the Split
-            if ((0, AbstractSplitsCacheSync_1.usesSegments)(split))
-                this.segmentsCount++;
-            return true;
-        }
-        else {
-            return false;
-        }
+        // Store the Split.
+        this.splitsCache[name] = split;
+        // Update TT cache
+        var ttName = split.trafficTypeName;
+        this.ttCache[ttName] = (this.ttCache[ttName] || 0) + 1;
+        this.addToFlagSets(split);
+        // Add to segments count for the new version of the Split
+        if ((0, AbstractSplitsCacheSync_1.usesSegments)(split))
+            this.segmentsCount++;
+        return true;
     };
     SplitsCacheInMemory.prototype.removeSplit = function (name) {
         var split = this.getSplit(name);
-        if (split) {
-            // Delete the Split
-            delete this.splitsCache[name];
-            var ttName = split.trafficTypeName;
-            this.ttCache[ttName]--; // Update tt cache
-            if (!this.ttCache[ttName])
-                delete this.ttCache[ttName];
-            this.removeFromFlagSets(split.name, split.sets);
-            // Update the segments count.
-            if ((0, AbstractSplitsCacheSync_1.usesSegments)(split))
-                this.segmentsCount--;
-            return true;
-        }
-        else {
+        if (!split)
             return false;
-        }
+        // Delete the Split
+        delete this.splitsCache[name];
+        var ttName = split.trafficTypeName;
+        this.ttCache[ttName]--; // Update tt cache
+        if (!this.ttCache[ttName])
+            delete this.ttCache[ttName];
+        this.removeFromFlagSets(split.name, split.sets);
+        // Update the segments count.
+        if ((0, AbstractSplitsCacheSync_1.usesSegments)(split))
+            this.segmentsCount--;
+        return true;
     };
     SplitsCacheInMemory.prototype.getSplit = function (name) {
         return this.splitsCache[name] || null;

package/cjs/storages/inRedis/RBSegmentsCacheInRedis.js

@@ -0,0 +1,64 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.RBSegmentsCacheInRedis = void 0;
+var lang_1 = require("../../utils/lang");
+var constants_1 = require("./constants");
+var sets_1 = require("../../utils/lang/sets");
+var RBSegmentsCacheInRedis = /** @class */ (function () {
+    function RBSegmentsCacheInRedis(log, keys, redis) {
+        this.log = log;
+        this.keys = keys;
+        this.redis = redis;
+    }
+    RBSegmentsCacheInRedis.prototype.get = function (name) {
+        return this.redis.get(this.keys.buildRBSegmentKey(name))
+            .then(function (maybeRBSegment) { return maybeRBSegment && JSON.parse(maybeRBSegment); });
+    };
+    RBSegmentsCacheInRedis.prototype.getNames = function () {
+        var _this = this;
+        return this.redis.keys(this.keys.searchPatternForRBSegmentKeys()).then(function (listOfKeys) { return listOfKeys.map(_this.keys.extractKey); });
+    };
+    RBSegmentsCacheInRedis.prototype.contains = function (names) {
+        var namesArray = (0, sets_1.setToArray)(names);
+        return this.getNames().then(function (namesInStorage) {
+            return namesArray.every(function (name) { return namesInStorage.includes(name); });
+        });
+    };
+    RBSegmentsCacheInRedis.prototype.update = function (toAdd, toRemove, changeNumber) {
+        var _this = this;
+        return Promise.all([
+            this.setChangeNumber(changeNumber),
+            Promise.all(toAdd.map(function (toAdd) {
+                var key = _this.keys.buildRBSegmentKey(toAdd.name);
+                var stringifiedNewRBSegment = JSON.stringify(toAdd);
+                return _this.redis.set(key, stringifiedNewRBSegment).then(function () { return true; });
+            })),
+            Promise.all(toRemove.map(function (toRemove) {
+                var key = _this.keys.buildRBSegmentKey(toRemove.name);
+                return _this.redis.del(key).then(function (status) { return status === 1; });
+            }))
+        ]).then(function (_a) {
+            var added = _a[1], removed = _a[2];
+            return added.some(function (result) { return result; }) || removed.some(function (result) { return result; });
+        });
+    };
+    RBSegmentsCacheInRedis.prototype.setChangeNumber = function (changeNumber) {
+        return this.redis.set(this.keys.buildRBSegmentsTillKey(), changeNumber + '').then(function (status) { return status === 'OK'; });
+    };
+    RBSegmentsCacheInRedis.prototype.getChangeNumber = function () {
+        var _this = this;
+        return this.redis.get(this.keys.buildRBSegmentsTillKey()).then(function (value) {
+            var i = parseInt(value, 10);
+            return (0, lang_1.isNaNNumber)(i) ? -1 : i;
+        }).catch(function (e) {
+            _this.log.error(constants_1.LOG_PREFIX + 'Could not retrieve changeNumber from storage. Error: ' + e);
+            return -1;
+        });
+    };
+    // @TODO implement if required by DataLoader or producer mode
+    RBSegmentsCacheInRedis.prototype.clear = function () {
+        return Promise.resolve();
+    };
+    return RBSegmentsCacheInRedis;
+}());
+exports.RBSegmentsCacheInRedis = RBSegmentsCacheInRedis;

package/cjs/storages/inRedis/SplitsCacheInRedis.js

@@ -67,8 +67,9 @@ var SplitsCacheInRedis = /** @class */ (function (_super) {
      * The returned promise is resolved when the operation success
      * or rejected if it fails (e.g., redis operation fails)
      */
-    SplitsCacheInRedis.prototype.addSplit = function (name, split) {
+    SplitsCacheInRedis.prototype.addSplit = function (split) {
         var _this = this;
+        var name = split.name;
         var splitKey = this.keys.buildSplitKey(name);
         return this.redis.get(splitKey).then(function (splitFromStorage) {
             // handling parsing error
@@ -92,18 +93,9 @@ var SplitsCacheInRedis = /** @class */ (function (_super) {
             }).then(function () { return _this._updateFlagSets(name, parsedPreviousSplit && parsedPreviousSplit.sets, split.sets); });
         }).then(function () { return true; });
     };
-    /**
-     * Add a list of splits.
-     * The returned promise is resolved when the operation success
-     * or rejected if it fails (e.g., redis operation fails)
-     */
-    SplitsCacheInRedis.prototype.addSplits = function (entries) {
-        var _this = this;
-        return Promise.all(entries.map(function (keyValuePair) { return _this.addSplit(keyValuePair[0], keyValuePair[1]); }));
-    };
     /**
      * Remove a given split.
-     * The returned promise is resolved when the operation success, with 1 or 0 indicating if the split existed or not.
+     * The returned promise is resolved when the operation success, with true or false indicating if the split existed (and was removed) or not.
      * or rejected if it fails (e.g., redis operation fails).
      */
     SplitsCacheInRedis.prototype.removeSplit = function (name) {
@@ -113,18 +105,9 @@ var SplitsCacheInRedis = /** @class */ (function (_super) {
                 return _this._decrementCounts(split).then(function () { return _this._updateFlagSets(name, split.sets); });
             }
         }).then(function () {
-            return _this.redis.del(_this.keys.buildSplitKey(name));
+            return _this.redis.del(_this.keys.buildSplitKey(name)).then(function (status) { return status === 1; });
         });
     };
-    /**
-     * Remove a list of splits.
-     * The returned promise is resolved when the operation success,
-     * or rejected if it fails (e.g., redis operation fails).
-     */
-    SplitsCacheInRedis.prototype.removeSplits = function (names) {
-        var _this = this;
-        return Promise.all(names.map(function (name) { return _this.removeSplit(name); }));
-    };
     /**
      * Get split definition or null if it's not defined.
      * Returned promise is rejected if redis operation fails.

package/cjs/storages/inRedis/constants.js

@@ -3,5 +3,5 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.TTL_REFRESH = exports.REFRESH_RATE = exports.DEFAULT_CACHE_SIZE = exports.LOG_PREFIX = void 0;
 exports.LOG_PREFIX = 'storage:redis: ';
 exports.DEFAULT_CACHE_SIZE = 30000;
-exports.REFRESH_RATE = 300000; // 300.000 ms = start after 5 mins
+exports.REFRESH_RATE = 300000; // 300000 ms = start after 5 mins
 exports.TTL_REFRESH = 3600; // 1hr

package/cjs/storages/inRedis/index.js

@@ -12,6 +12,7 @@ var TelemetryCacheInRedis_1 = require("./TelemetryCacheInRedis");
 var UniqueKeysCacheInRedis_1 = require("./UniqueKeysCacheInRedis");
 var ImpressionCountsCacheInRedis_1 = require("./ImpressionCountsCacheInRedis");
 var utils_1 = require("../utils");
+var RBSegmentsCacheInRedis_1 = require("./RBSegmentsCacheInRedis");
 /**
  * InRedis storage factory for consumer server-side SplitFactory, that uses `Ioredis` Redis client for Node.js
  * @see {@link https://www.npmjs.com/package/ioredis}
@@ -40,6 +41,7 @@ function InRedisStorage(options) {
         });
         return {
             splits: new SplitsCacheInRedis_1.SplitsCacheInRedis(log, keys, redisClient, settings.sync.__splitFiltersValidation),
+            rbSegments: new RBSegmentsCacheInRedis_1.RBSegmentsCacheInRedis(log, keys, redisClient),
             segments: new SegmentsCacheInRedis_1.SegmentsCacheInRedis(log, keys, redisClient),
             impressions: new ImpressionsCacheInRedis_1.ImpressionsCacheInRedis(log, keys.buildImpressionsKey(), redisClient, metadata),
             impressionCounts: impressionCountsCache,