@splitsoftware/splitio-commons 2.1.0-rc.1 → 2.1.0-rc.2

package/CHANGES.txt

@@ -1,8 +1,12 @@
 2.1.0 (January XX, 2025)
+ - Added `impressionsDisabled` property to SDK Manager's `SplitView` type.
  - Added two new configuration options for the SDK storage in browsers when using storage type `LOCALSTORAGE`:
     - `storage.expirationDays` to specify the validity period of the rollout cache.
     - `storage.clearOnInit` to clear the rollout cache on SDK initialization.
- - Updated SDK_READY_FROM_CACHE event when using `LOCALSTORAGE` storage type to be emitted alongside SDK_READY event in case it has not been emitted.
+ - Updated implementation of the impressions tracker and strategies to support feature flags with impressions tracking disabled.
+ - Updated SDK_READY_FROM_CACHE event when using the `LOCALSTORAGE` storage type to be emitted alongside the SDK_READY event if it has not already been emitted.
+
+2.0.3 (January 9, 2025)
  - Bugfixing - Properly handle rejected promises when using targeting rules with segment matchers in consumer modes (e.g., Redis and Pluggable storages).
 
 2.0.2 (December 3, 2024)

package/LICENSE

@@ -1,4 +1,4 @@
-Copyright © 2024 Split Software, Inc.
+Copyright © 2025 Split Software, Inc.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

package/cjs/evaluator/index.js

@@ -104,12 +104,14 @@ function getEvaluation(log, splitJSON, key, attributes, storage) {
             return evaluation.then(function (result) {
                 result.changeNumber = split_1.getChangeNumber();
                 result.config = splitJSON.configurations && splitJSON.configurations[result.treatment] || null;
+                result.impressionsDisabled = splitJSON.impressionsDisabled;
                 return result;
             });
         }
         else {
             evaluation.changeNumber = split_1.getChangeNumber(); // Always sync and optional
             evaluation.config = splitJSON.configurations && splitJSON.configurations[evaluation.treatment] || null;
+            evaluation.impressionsDisabled = splitJSON.impressionsDisabled;
         }
     }
     return evaluation;

package/cjs/listeners/browser.js

@@ -3,9 +3,8 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.BrowserSignalListener = void 0;
 var impressionsSubmitter_1 = require("../sync/submitters/impressionsSubmitter");
 var impressionCountsSubmitter_1 = require("../sync/submitters/impressionCountsSubmitter");
-var constants_1 = require("../utils/constants");
 var objectAssign_1 = require("../utils/lang/objectAssign");
-var constants_2 = require("../logger/constants");
+var constants_1 = require("../logger/constants");
 var consent_1 = require("../consent");
 var VISIBILITYCHANGE_EVENT = 'visibilitychange';
 var PAGEHIDE_EVENT = 'pagehide';
@@ -28,7 +27,7 @@ var BrowserSignalListener = /** @class */ (function () {
      * Called when SplitFactory is initialized, it adds event listeners to close streaming and flush impressions and events.
      */
     BrowserSignalListener.prototype.start = function () {
-        this.settings.log.debug(constants_2.CLEANUP_REGISTERING, [EVENT_NAME]);
+        this.settings.log.debug(constants_1.CLEANUP_REGISTERING, [EVENT_NAME]);
         if (typeof document !== 'undefined' && document.addEventListener) {
             // Flush data whenever the page is hidden or unloaded.
             document.addEventListener(VISIBILITYCHANGE_EVENT, this.flushDataIfHidden);
@@ -44,7 +43,7 @@ var BrowserSignalListener = /** @class */ (function () {
      * Called when client is destroyed, it removes event listeners.
      */
     BrowserSignalListener.prototype.stop = function () {
-        this.settings.log.debug(constants_2.CLEANUP_DEREGISTERING, [EVENT_NAME]);
+        this.settings.log.debug(constants_1.CLEANUP_DEREGISTERING, [EVENT_NAME]);
         if (typeof document !== 'undefined' && document.removeEventListener) {
             document.removeEventListener(VISIBILITYCHANGE_EVENT, this.flushDataIfHidden);
         }
@@ -63,10 +62,9 @@ var BrowserSignalListener = /** @class */ (function () {
         var _a = this.settings.urls, events = _a.events, telemetry = _a.telemetry;
         // Flush impressions & events data if there is user consent
         if ((0, consent_1.isConsentGranted)(this.settings)) {
-            var sim = this.settings.sync.impressionsMode;
             var extraMetadata = {
                 // sim stands for Sync/Split Impressions Mode
-                sim: sim === constants_1.OPTIMIZED ? constants_1.OPTIMIZED : sim === constants_1.DEBUG ? constants_1.DEBUG : constants_1.NONE
+                sim: this.settings.sync.impressionsMode
             };
             this._flushData(events + '/testImpressions/beacon', this.storage.impressions, this.serviceApi.postTestImpressionsBulk, this.fromImpressionsCollector, extraMetadata);
             this._flushData(events + '/events/beacon', this.storage.events, this.serviceApi.postEventsBulk);

package/cjs/sdkClient/client.js

@@ -33,7 +33,7 @@ function clientFactory(params) {
             var queue = [];
             var treatment = processEvaluation(evaluationResult, featureFlagName, key, attributes, withConfig, methodName, queue);
             impressionsTracker.track(queue, attributes);
-            stopTelemetryTracker(queue[0] && queue[0].label);
+            stopTelemetryTracker(queue[0] && queue[0].imp.label);
             return treatment;
         };
         var evaluation = readinessManager.isReady() || readinessManager.isReadyFromCache() ?
@@ -57,7 +57,7 @@ function clientFactory(params) {
                 treatments[featureFlagName] = processEvaluation(evaluationResults[featureFlagName], featureFlagName, key, attributes, withConfig, methodName, queue);
             });
             impressionsTracker.track(queue, attributes);
-            stopTelemetryTracker(queue[0] && queue[0].label);
+            stopTelemetryTracker(queue[0] && queue[0].imp.label);
             return treatments;
         };
         var evaluations = readinessManager.isReady() || readinessManager.isReadyFromCache() ?
@@ -83,7 +83,7 @@ function clientFactory(params) {
                 treatments[featureFlagName] = processEvaluation(evaluations[featureFlagName], featureFlagName, key, attributes, withConfig, methodName, queue);
             });
             impressionsTracker.track(queue, attributes);
-            stopTelemetryTracker(queue[0] && queue[0].label);
+            stopTelemetryTracker(queue[0] && queue[0].imp.label);
             return treatments;
         };
         var evaluations = readinessManager.isReady() || readinessManager.isReadyFromCache() ?
@@ -106,18 +106,21 @@ function clientFactory(params) {
     function processEvaluation(evaluation, featureFlagName, key, attributes, withConfig, invokingMethodName, queue) {
         var matchingKey = (0, key_1.getMatching)(key);
         var bucketingKey = (0, key_1.getBucketing)(key);
-        var treatment = evaluation.treatment, label = evaluation.label, changeNumber = evaluation.changeNumber, _a = evaluation.config, config = _a === void 0 ? null : _a;
+        var treatment = evaluation.treatment, label = evaluation.label, changeNumber = evaluation.changeNumber, _a = evaluation.config, config = _a === void 0 ? null : _a, impressionsDisabled = evaluation.impressionsDisabled;
         log.info(constants_2.IMPRESSION, [featureFlagName, matchingKey, treatment, label]);
         if ((0, splitExistence_1.validateSplitExistence)(log, readinessManager, featureFlagName, label, invokingMethodName)) {
             log.info(constants_2.IMPRESSION_QUEUEING);
             queue.push({
-                feature: featureFlagName,
-                keyName: matchingKey,
-                treatment: treatment,
-                time: Date.now(),
-                bucketingKey: bucketingKey,
-                label: label,
-                changeNumber: changeNumber
+                imp: {
+                    feature: featureFlagName,
+                    keyName: matchingKey,
+                    treatment: treatment,
+                    time: Date.now(),
+                    bucketingKey: bucketingKey,
+                    label: label,
+                    changeNumber: changeNumber,
+                },
+                disabled: impressionsDisabled
             });
         }
         if (withConfig) {

package/cjs/sdkClient/sdkClient.js

@@ -50,7 +50,7 @@ function sdkClientFactory(params, isSharedClient) {
                 (0, apiKey_1.releaseApiKey)(settings.core.authorizationKey);
                 telemetryTracker.sessionLength();
                 signalListener && signalListener.stop();
-                uniqueKeysTracker && uniqueKeysTracker.stop();
+                uniqueKeysTracker.stop();
             }
             // Stop background jobs
             syncManager && syncManager.stop();

package/cjs/sdkFactory/index.js

@@ -51,19 +51,14 @@ function sdkFactory(params) {
     var telemetryTracker = (0, telemetryTracker_1.telemetryTrackerFactory)(storage.telemetry, platform.now);
     var integrationsManager = integrationsManagerFactory && integrationsManagerFactory({ settings: settings, storage: storage, telemetryTracker: telemetryTracker });
     var observer = impressionsObserverFactory();
-    var uniqueKeysTracker = impressionsMode === constants_3.NONE ? (0, uniqueKeysTracker_1.uniqueKeysTrackerFactory)(log, storage.uniqueKeys, filterAdapterFactory && filterAdapterFactory()) : undefined;
-    var strategy;
-    switch (impressionsMode) {
-        case constants_3.OPTIMIZED:
-            strategy = (0, strategyOptimized_1.strategyOptimizedFactory)(observer, storage.impressionCounts);
-            break;
-        case constants_3.NONE:
-            strategy = (0, strategyNone_1.strategyNoneFactory)(storage.impressionCounts, uniqueKeysTracker);
-            break;
-        default:
-            strategy = (0, strategyDebug_1.strategyDebugFactory)(observer);
-    }
-    var impressionsTracker = (0, impressionsTracker_1.impressionsTrackerFactory)(settings, storage.impressions, strategy, whenInit, integrationsManager, storage.telemetry);
+    var uniqueKeysTracker = (0, uniqueKeysTracker_1.uniqueKeysTrackerFactory)(log, storage.uniqueKeys, filterAdapterFactory && filterAdapterFactory());
+    var noneStrategy = (0, strategyNone_1.strategyNoneFactory)(storage.impressionCounts, uniqueKeysTracker);
+    var strategy = impressionsMode === constants_3.OPTIMIZED ?
+        (0, strategyOptimized_1.strategyOptimizedFactory)(observer, storage.impressionCounts) :
+        impressionsMode === constants_3.DEBUG ?
+            (0, strategyDebug_1.strategyDebugFactory)(observer) :
+            noneStrategy;
+    var impressionsTracker = (0, impressionsTracker_1.impressionsTrackerFactory)(settings, storage.impressions, noneStrategy, strategy, whenInit, integrationsManager, storage.telemetry);
     var eventTracker = (0, eventTracker_1.eventTrackerFactory)(settings, storage.events, whenInit, integrationsManager, storage.telemetry);
     // splitApi is used by SyncManager and Browser signal listener
     var splitApi = splitApiFactory && splitApiFactory(settings, platform, telemetryTracker);
@@ -82,7 +77,7 @@ function sdkFactory(params) {
         // We will just log and allow for the SDK to end up throwing an SDK_TIMEOUT event for devs to handle.
         (0, apiKey_1.validateAndTrackApiKey)(log, settings.core.authorizationKey);
         readiness.init();
-        uniqueKeysTracker && uniqueKeysTracker.start();
+        uniqueKeysTracker.start();
         syncManager && syncManager.start();
         signalListener && signalListener.start();
         initCallbacks.forEach(function (cb) { return cb(); });

package/cjs/sdkManager/index.js

@@ -28,7 +28,8 @@ function objectToView(splitObject) {
         treatments: collectTreatments(splitObject),
         configs: splitObject.configurations || {},
         sets: splitObject.sets || [],
-        defaultTreatment: splitObject.defaultTreatment
+        defaultTreatment: splitObject.defaultTreatment,
+        impressionsDisabled: splitObject.impressionsDisabled === true
     };
 }
 function objectsToViews(splitObjects) {

package/cjs/storages/inLocalStorage/index.js

@@ -28,7 +28,7 @@ function InLocalStorage(options) {
             params.settings.log.warn(constants_1.LOG_PREFIX + 'LocalStorage API is unavailable. Falling back to default MEMORY storage');
             return (0, InMemoryStorageCS_1.InMemoryStorageCSFactory)(params);
         }
-        var settings = params.settings, _a = params.settings, log = _a.log, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize, impressionsMode = _a.sync.impressionsMode;
+        var settings = params.settings, _a = params.settings, log = _a.log, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize;
         var matchingKey = (0, key_1.getMatching)(settings.core.key);
         var keys = new KeyBuilderCS_1.KeyBuilderCS(prefix, matchingKey);
         var splits = new SplitsCacheInLocal_1.SplitsCacheInLocal(settings, keys);
@@ -39,10 +39,10 @@ function InLocalStorage(options) {
             segments: segments,
             largeSegments: largeSegments,
             impressions: new ImpressionsCacheInMemory_1.ImpressionsCacheInMemory(impressionsQueueSize),
-            impressionCounts: impressionsMode !== constants_2.DEBUG ? new ImpressionCountsCacheInMemory_1.ImpressionCountsCacheInMemory() : undefined,
+            impressionCounts: new ImpressionCountsCacheInMemory_1.ImpressionCountsCacheInMemory(),
             events: new EventsCacheInMemory_1.EventsCacheInMemory(eventsQueueSize),
             telemetry: (0, TelemetryCacheInMemory_1.shouldRecordTelemetry)(params) ? new TelemetryCacheInMemory_1.TelemetryCacheInMemory(splits, segments) : undefined,
-            uniqueKeys: impressionsMode === constants_2.NONE ? new UniqueKeysCacheInMemoryCS_1.UniqueKeysCacheInMemoryCS() : undefined,
+            uniqueKeys: new UniqueKeysCacheInMemoryCS_1.UniqueKeysCacheInMemoryCS(),
             validateCache: function () {
                 return (0, validateCache_1.validateCache)(options, settings, keys, splits, segments, largeSegments);
             },
@@ -57,6 +57,7 @@ function InLocalStorage(options) {
                     impressionCounts: this.impressionCounts,
                     events: this.events,
                     telemetry: this.telemetry,
+                    uniqueKeys: this.uniqueKeys,
                     destroy: function () { }
                 };
             },

package/cjs/storages/inMemory/InMemoryStorage.js

@@ -15,17 +15,17 @@ var UniqueKeysCacheInMemory_1 = require("./UniqueKeysCacheInMemory");
  * @param params - parameters required by EventsCacheSync
  */
 function InMemoryStorageFactory(params) {
-    var _a = params.settings, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize, _c = _a.sync, impressionsMode = _c.impressionsMode, __splitFiltersValidation = _c.__splitFiltersValidation;
+    var _a = params.settings, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize, __splitFiltersValidation = _a.sync.__splitFiltersValidation;
     var splits = new SplitsCacheInMemory_1.SplitsCacheInMemory(__splitFiltersValidation);
     var segments = new SegmentsCacheInMemory_1.SegmentsCacheInMemory();
     var storage = {
         splits: splits,
         segments: segments,
         impressions: new ImpressionsCacheInMemory_1.ImpressionsCacheInMemory(impressionsQueueSize),
-        impressionCounts: impressionsMode !== constants_1.DEBUG ? new ImpressionCountsCacheInMemory_1.ImpressionCountsCacheInMemory() : undefined,
+        impressionCounts: new ImpressionCountsCacheInMemory_1.ImpressionCountsCacheInMemory(),
         events: new EventsCacheInMemory_1.EventsCacheInMemory(eventsQueueSize),
         telemetry: (0, TelemetryCacheInMemory_1.shouldRecordTelemetry)(params) ? new TelemetryCacheInMemory_1.TelemetryCacheInMemory(splits, segments) : undefined,
-        uniqueKeys: impressionsMode === constants_1.NONE ? new UniqueKeysCacheInMemory_1.UniqueKeysCacheInMemory() : undefined,
+        uniqueKeys: new UniqueKeysCacheInMemory_1.UniqueKeysCacheInMemory(),
         destroy: function () { }
     };
     // @TODO revisit storage logic in localhost mode
@@ -34,10 +34,8 @@ function InMemoryStorageFactory(params) {
         var noopTrack = function () { return true; };
         storage.impressions.track = noopTrack;
         storage.events.track = noopTrack;
-        if (storage.impressionCounts)
-            storage.impressionCounts.track = noopTrack;
-        if (storage.uniqueKeys)
-            storage.uniqueKeys.track = noopTrack;
+        storage.impressionCounts.track = noopTrack;
+        storage.uniqueKeys.track = noopTrack;
     }
     return storage;
 }

package/cjs/storages/inMemory/InMemoryStorageCS.js

@@ -15,7 +15,7 @@ var UniqueKeysCacheInMemoryCS_1 = require("./UniqueKeysCacheInMemoryCS");
  * @param params - parameters required by EventsCacheSync
  */
 function InMemoryStorageCSFactory(params) {
-    var _a = params.settings, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize, _c = _a.sync, impressionsMode = _c.impressionsMode, __splitFiltersValidation = _c.__splitFiltersValidation;
+    var _a = params.settings, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize, __splitFiltersValidation = _a.sync.__splitFiltersValidation;
     var splits = new SplitsCacheInMemory_1.SplitsCacheInMemory(__splitFiltersValidation);
     var segments = new MySegmentsCacheInMemory_1.MySegmentsCacheInMemory();
     var largeSegments = new MySegmentsCacheInMemory_1.MySegmentsCacheInMemory();
@@ -24,10 +24,10 @@ function InMemoryStorageCSFactory(params) {
         segments: segments,
         largeSegments: largeSegments,
         impressions: new ImpressionsCacheInMemory_1.ImpressionsCacheInMemory(impressionsQueueSize),
-        impressionCounts: impressionsMode !== constants_1.DEBUG ? new ImpressionCountsCacheInMemory_1.ImpressionCountsCacheInMemory() : undefined,
+        impressionCounts: new ImpressionCountsCacheInMemory_1.ImpressionCountsCacheInMemory(),
         events: new EventsCacheInMemory_1.EventsCacheInMemory(eventsQueueSize),
         telemetry: (0, TelemetryCacheInMemory_1.shouldRecordTelemetry)(params) ? new TelemetryCacheInMemory_1.TelemetryCacheInMemory(splits, segments) : undefined,
-        uniqueKeys: impressionsMode === constants_1.NONE ? new UniqueKeysCacheInMemoryCS_1.UniqueKeysCacheInMemoryCS() : undefined,
+        uniqueKeys: new UniqueKeysCacheInMemoryCS_1.UniqueKeysCacheInMemoryCS(),
         destroy: function () { },
         // When using shared instantiation with MEMORY we reuse everything but segments (they are unique per key)
         shared: function () {
@@ -39,6 +39,7 @@ function InMemoryStorageCSFactory(params) {
                 impressionCounts: this.impressionCounts,
                 events: this.events,
                 telemetry: this.telemetry,
+                uniqueKeys: this.uniqueKeys,
                 destroy: function () { }
             };
         },
@@ -49,10 +50,8 @@ function InMemoryStorageCSFactory(params) {
         var noopTrack = function () { return true; };
         storage.impressions.track = noopTrack;
         storage.events.track = noopTrack;
-        if (storage.impressionCounts)
-            storage.impressionCounts.track = noopTrack;
-        if (storage.uniqueKeys)
-            storage.uniqueKeys.track = noopTrack;
+        storage.impressionCounts.track = noopTrack;
+        storage.uniqueKeys.track = noopTrack;
     }
     return storage;
 }

package/cjs/storages/inRedis/index.js

@@ -23,20 +23,18 @@ function InRedisStorage(options) {
     var RD = require('./RedisAdapter').RedisAdapter;
     var prefix = (0, KeyBuilder_1.validatePrefix)(options.prefix);
     function InRedisStorageFactory(params) {
-        var onReadyCb = params.onReadyCb, settings = params.settings, _a = params.settings, log = _a.log, impressionsMode = _a.sync.impressionsMode;
+        var onReadyCb = params.onReadyCb, settings = params.settings, log = params.settings.log;
         var metadata = (0, utils_1.metadataBuilder)(settings);
         var keys = new KeyBuilderSS_1.KeyBuilderSS(prefix, metadata);
         var redisClient = new RD(log, options.options || {});
         var telemetry = new TelemetryCacheInRedis_1.TelemetryCacheInRedis(log, keys, redisClient);
-        var impressionCountsCache = impressionsMode !== constants_1.DEBUG ? new ImpressionCountsCacheInRedis_1.ImpressionCountsCacheInRedis(log, keys.buildImpressionsCountKey(), redisClient) : undefined;
-        var uniqueKeysCache = impressionsMode === constants_1.NONE ? new UniqueKeysCacheInRedis_1.UniqueKeysCacheInRedis(log, keys.buildUniqueKeysKey(), redisClient) : undefined;
+        var impressionCountsCache = new ImpressionCountsCacheInRedis_1.ImpressionCountsCacheInRedis(log, keys.buildImpressionsCountKey(), redisClient);
+        var uniqueKeysCache = new UniqueKeysCacheInRedis_1.UniqueKeysCacheInRedis(log, keys.buildUniqueKeysKey(), redisClient);
         // subscription to Redis connect event in order to emit SDK_READY event on consumer mode
         redisClient.on('connect', function () {
             onReadyCb();
-            if (impressionCountsCache)
-                impressionCountsCache.start();
-            if (uniqueKeysCache)
-                uniqueKeysCache.start();
+            impressionCountsCache.start();
+            uniqueKeysCache.start();
             // Synchronize config
             telemetry.recordConfig();
         });
@@ -51,12 +49,10 @@ function InRedisStorage(options) {
             // When using REDIS we should:
             // 1- Disconnect from the storage
             destroy: function () {
-                var promises = [];
-                if (impressionCountsCache)
-                    promises.push(impressionCountsCache.stop());
-                if (uniqueKeysCache)
-                    promises.push(uniqueKeysCache.stop());
-                return Promise.all(promises).then(function () { redisClient.disconnect(); });
+                return Promise.all([
+                    impressionCountsCache.stop(),
+                    uniqueKeysCache.stop()
+                ]).then(function () { redisClient.disconnect(); });
                 // @TODO check that caches works as expected when redisClient is disconnected
             }
         };

package/cjs/storages/pluggable/index.js

@@ -54,30 +54,26 @@ function PluggableStorage(options) {
     validatePluggableStorageOptions(options);
     var prefix = (0, KeyBuilder_1.validatePrefix)(options.prefix);
     function PluggableStorageFactory(params) {
-        var onReadyCb = params.onReadyCb, settings = params.settings, _a = params.settings, log = _a.log, mode = _a.mode, impressionsMode = _a.sync.impressionsMode, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize;
+        var onReadyCb = params.onReadyCb, settings = params.settings, _a = params.settings, log = _a.log, mode = _a.mode, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize;
         var metadata = (0, utils_1.metadataBuilder)(settings);
         var keys = new KeyBuilderSS_1.KeyBuilderSS(prefix, metadata);
         var wrapper = (0, wrapperAdapter_1.wrapperAdapter)(log, options.wrapper);
-        var isSyncronizer = mode === undefined; // If mode is not defined, the synchronizer is running
+        var isSynchronizer = mode === undefined; // If mode is not defined, the synchronizer is running
         var isPartialConsumer = mode === constants_1.CONSUMER_PARTIAL_MODE;
-        var telemetry = (0, TelemetryCacheInMemory_1.shouldRecordTelemetry)(params) || isSyncronizer ?
+        var telemetry = (0, TelemetryCacheInMemory_1.shouldRecordTelemetry)(params) || isSynchronizer ?
             isPartialConsumer ?
                 new TelemetryCacheInMemory_1.TelemetryCacheInMemory() :
                 new TelemetryCachePluggable_1.TelemetryCachePluggable(log, keys, wrapper) :
             undefined;
-        var impressionCountsCache = impressionsMode !== constants_1.DEBUG || isSyncronizer ?
-            isPartialConsumer ?
-                new ImpressionCountsCacheInMemory_1.ImpressionCountsCacheInMemory() :
-                new ImpressionCountsCachePluggable_1.ImpressionCountsCachePluggable(log, keys.buildImpressionsCountKey(), wrapper) :
-            undefined;
-        var uniqueKeysCache = impressionsMode === constants_1.NONE || isSyncronizer ?
-            isPartialConsumer ?
-                settings.core.key === undefined ? new UniqueKeysCacheInMemory_1.UniqueKeysCacheInMemory() : new UniqueKeysCacheInMemoryCS_1.UniqueKeysCacheInMemoryCS() :
-                new UniqueKeysCachePluggable_1.UniqueKeysCachePluggable(log, keys.buildUniqueKeysKey(), wrapper) :
-            undefined;
+        var impressionCountsCache = isPartialConsumer ?
+            new ImpressionCountsCacheInMemory_1.ImpressionCountsCacheInMemory() :
+            new ImpressionCountsCachePluggable_1.ImpressionCountsCachePluggable(log, keys.buildImpressionsCountKey(), wrapper);
+        var uniqueKeysCache = isPartialConsumer ?
+            settings.core.key === undefined ? new UniqueKeysCacheInMemory_1.UniqueKeysCacheInMemory() : new UniqueKeysCacheInMemoryCS_1.UniqueKeysCacheInMemoryCS() :
+            new UniqueKeysCachePluggable_1.UniqueKeysCachePluggable(log, keys.buildUniqueKeysKey(), wrapper);
         // Connects to wrapper and emits SDK_READY event on main client
         var connectPromise = wrapper.connect().then(function () {
-            if (isSyncronizer) {
+            if (isSynchronizer) {
                 // @TODO reuse InLocalStorage::validateCache logic
                 // In standalone or producer mode, clear storage if SDK key, flags filter criteria or flags spec version was modified
                 return wrapper.get(keys.buildHashKey()).then(function (hash) {
@@ -94,9 +90,9 @@ function PluggableStorage(options) {
             }
             else {
                 // Start periodic flush of async storages if not running synchronizer (producer mode)
-                if (impressionCountsCache && impressionCountsCache.start)
+                if (impressionCountsCache.start)
                     impressionCountsCache.start();
-                if (uniqueKeysCache && uniqueKeysCache.start)
+                if (uniqueKeysCache.start)
                     uniqueKeysCache.start();
                 if (telemetry && telemetry.recordConfig)
                     telemetry.recordConfig();
@@ -117,9 +113,9 @@ function PluggableStorage(options) {
             uniqueKeys: uniqueKeysCache,
             // Stop periodic flush and disconnect the underlying storage
             destroy: function () {
-                return Promise.all(isSyncronizer ? [] : [
-                    impressionCountsCache && impressionCountsCache.stop && impressionCountsCache.stop(),
-                    uniqueKeysCache && uniqueKeysCache.stop && uniqueKeysCache.stop(),
+                return Promise.all(isSynchronizer ? [] : [
+                    impressionCountsCache.stop && impressionCountsCache.stop(),
+                    uniqueKeysCache.stop && uniqueKeysCache.stop(),
                 ]).then(function () { return wrapper.disconnect(); });
             },
             // emits SDK_READY event on shared clients and returns a reference to the storage

package/cjs/sync/submitters/impressionCountsSubmitter.js

@@ -30,9 +30,7 @@ var IMPRESSIONS_COUNT_RATE = 1800000; // 30 minutes
  */
 function impressionCountsSubmitterFactory(params) {
     var log = params.settings.log, postTestImpressionsCount = params.splitApi.postTestImpressionsCount, impressionCounts = params.storage.impressionCounts;
-    if (impressionCounts) {
-        // retry impressions counts only once.
-        return (0, submitter_1.submitterFactory)(log, postTestImpressionsCount, impressionCounts, IMPRESSIONS_COUNT_RATE, 'impression counts', fromImpressionCountsCollector, 1);
-    }
+    // retry impressions counts only once.
+    return (0, submitter_1.submitterFactory)(log, postTestImpressionsCount, impressionCounts, IMPRESSIONS_COUNT_RATE, 'impression counts', fromImpressionCountsCollector, 1);
 }
 exports.impressionCountsSubmitterFactory = impressionCountsSubmitterFactory;

package/cjs/sync/submitters/submitterManager.js

@@ -9,14 +9,11 @@ var uniqueKeysSubmitter_1 = require("./uniqueKeysSubmitter");
 function submitterManagerFactory(params) {
     var submitters = [
         (0, impressionsSubmitter_1.impressionsSubmitterFactory)(params),
-        (0, eventsSubmitter_1.eventsSubmitterFactory)(params)
+        (0, eventsSubmitter_1.eventsSubmitterFactory)(params),
+        (0, impressionCountsSubmitter_1.impressionCountsSubmitterFactory)(params),
+        (0, uniqueKeysSubmitter_1.uniqueKeysSubmitterFactory)(params)
     ];
-    var impressionCountsSubmitter = (0, impressionCountsSubmitter_1.impressionCountsSubmitterFactory)(params);
-    if (impressionCountsSubmitter)
-        submitters.push(impressionCountsSubmitter);
     var telemetrySubmitter = (0, telemetrySubmitter_1.telemetrySubmitterFactory)(params);
-    if (params.storage.uniqueKeys)
-        submitters.push((0, uniqueKeysSubmitter_1.uniqueKeysSubmitterFactory)(params));
     return {
         // `onlyTelemetry` true if SDK is created with userConsent not GRANTED
         start: function (onlyTelemetry) {

package/cjs/trackers/impressionsTracker.js

@@ -7,38 +7,37 @@ var constants_1 = require("../logger/constants");
 var constants_2 = require("../utils/constants");
 /**
  * Impressions tracker stores impressions in cache and pass them to the listener and integrations manager if provided.
- *
- * @param impressionsCache - cache to save impressions
- * @param metadata - runtime metadata (ip, hostname and version)
- * @param impressionListener - optional impression listener
- * @param integrationsManager - optional integrations manager
- * @param strategy - strategy for impressions tracking.
  */
-function impressionsTrackerFactory(settings, impressionsCache, strategy, whenInit, integrationsManager, telemetryCache) {
+function impressionsTrackerFactory(settings, impressionsCache, noneStrategy, strategy, whenInit, integrationsManager, telemetryCache) {
     var log = settings.log, impressionListener = settings.impressionListener, _a = settings.runtime, ip = _a.ip, hostname = _a.hostname, version = settings.version;
     return {
         track: function (impressions, attributes) {
             if (settings.userConsent === constants_2.CONSENT_DECLINED)
                 return;
-            var impressionsCount = impressions.length;
-            var _a = strategy.process(impressions), impressionsToStore = _a.impressionsToStore, impressionsToListener = _a.impressionsToListener, deduped = _a.deduped;
-            var impressionsToListenerCount = impressionsToListener.length;
-            if (impressionsToStore.length > 0) {
-                var res = impressionsCache.track(impressionsToStore);
+            var impressionsToStore = impressions.filter(function (_a) {
+                var imp = _a.imp, disabled = _a.disabled;
+                return disabled ?
+                    noneStrategy.process(imp) :
+                    strategy.process(imp);
+            });
+            var impressionsLength = impressions.length;
+            var impressionsToStoreLength = impressionsToStore.length;
+            if (impressionsToStoreLength) {
+                var res = impressionsCache.track(impressionsToStore.map(function (item) { return item.imp; }));
                 // If we're on an async storage, handle error and log it.
                 if ((0, thenable_1.thenable)(res)) {
                     res.then(function () {
-                        log.info(constants_1.IMPRESSIONS_TRACKER_SUCCESS, [impressionsCount]);
+                        log.info(constants_1.IMPRESSIONS_TRACKER_SUCCESS, [impressionsLength]);
                     }).catch(function (err) {
-                        log.error(constants_1.ERROR_IMPRESSIONS_TRACKER, [impressionsCount, err]);
+                        log.error(constants_1.ERROR_IMPRESSIONS_TRACKER, [impressionsLength, err]);
                     });
                 }
                 else {
                     // Record when impressionsCache is sync only (standalone mode)
                     // @TODO we are not dropping impressions on full queue yet, so DROPPED stats are not recorded
                     if (telemetryCache) {
-                        telemetryCache.recordImpressionStats(constants_2.QUEUED, impressionsToStore.length);
-                        telemetryCache.recordImpressionStats(constants_2.DEDUPED, deduped);
+                        telemetryCache.recordImpressionStats(constants_2.QUEUED, impressionsToStoreLength);
+                        telemetryCache.recordImpressionStats(constants_2.DEDUPED, impressionsLength - impressionsToStoreLength);
                     }
                 }
             }
@@ -47,7 +46,7 @@ function impressionsTrackerFactory(settings, impressionsCache, strategy, whenIni
                 var _loop_1 = function (i) {
                     var impressionData = {
                         // copy of impression, to avoid unexpected behavior if modified by integrations or impressionListener
-                        impression: (0, objectAssign_1.objectAssign)({}, impressionsToListener[i]),
+                        impression: (0, objectAssign_1.objectAssign)({}, impressions[i].imp),
                         attributes: attributes,
                         ip: ip,
                         hostname: hostname,
@@ -69,7 +68,7 @@ function impressionsTrackerFactory(settings, impressionsCache, strategy, whenIni
                         });
                     });
                 };
-                for (var i = 0; i < impressionsToListenerCount; i++) {
+                for (var i = 0; i < impressionsLength; i++) {
                     _loop_1(i);
                 }
             }

package/cjs/trackers/strategy/strategyDebug.js

@@ -5,20 +5,13 @@ exports.strategyDebugFactory = void 0;
  * Debug strategy for impressions tracker. Wraps impressions to store and adds previousTime if it corresponds
  *
  * @param impressionsObserver - impression observer. Previous time (pt property) is included in impression instances
- * @returns IStrategyResult
+ * @returns Debug strategy
  */
 function strategyDebugFactory(impressionsObserver) {
     return {
-        process: function (impressions) {
-            impressions.forEach(function (impression) {
-                // Adds previous time if it is enabled
-                impression.pt = impressionsObserver.testAndSet(impression);
-            });
-            return {
-                impressionsToStore: impressions,
-                impressionsToListener: impressions,
-                deduped: 0
-            };
+        process: function (impression) {
+            impression.pt = impressionsObserver.testAndSet(impression);
+            return true;
         }
     };
 }

package/cjs/trackers/strategy/strategyNone.js

@@ -4,25 +4,20 @@ exports.strategyNoneFactory = void 0;
 /**
  * None strategy for impressions tracker.
  *
- * @param impressionsCounter - cache to save impressions count. impressions will be deduped (OPTIMIZED mode)
+ * @param impressionCounts - cache to save impressions count. impressions will be deduped (OPTIMIZED mode)
  * @param uniqueKeysTracker - unique keys tracker in charge of tracking the unique keys per split.
- * @returns IStrategyResult
+ * @returns None strategy
  */
-function strategyNoneFactory(impressionsCounter, uniqueKeysTracker) {
+function strategyNoneFactory(impressionCounts, uniqueKeysTracker) {
     return {
-        process: function (impressions) {
-            impressions.forEach(function (impression) {
-                var now = Date.now();
-                // Increments impression counter per featureName
-                impressionsCounter.track(impression.feature, now, 1);
-                // Keep track by unique key
-                uniqueKeysTracker.track(impression.keyName, impression.feature);
-            });
-            return {
-                impressionsToStore: [],
-                impressionsToListener: impressions,
-                deduped: 0
-            };
+        process: function (impression) {
+            var now = Date.now();
+            // Increments impression counter per featureName
+            impressionCounts.track(impression.feature, now, 1);
+            // Keep track by unique key
+            uniqueKeysTracker.track(impression.keyName, impression.feature);
+            // Do not store impressions
+            return false;
         }
     };
 }