@splitsoftware/splitio-commons 1.9.2-rc.0 → 1.9.2-rc.1

package/cjs/logger/messages/warn.js

@@ -27,6 +27,7 @@ exports.codesWarn = error_1.codesError.concat([
     [c.WARN_NOT_EXISTENT_SPLIT, '%s: feature flag "%s" does not exist in this environment. Please double check what feature flags exist in the Split user interface.'],
     [c.WARN_LOWERCASE_TRAFFIC_TYPE, '%s: traffic_type_name should be all lowercase - converting string to lowercase.'],
     [c.WARN_NOT_EXISTENT_TT, '%s: traffic type "%s" does not have any corresponding feature flag in this environment, make sure you\'re tracking your events to a valid traffic type defined in the Split user interface.'],
+    [c.WARN_FLAGSET_NOT_CONFIGURED, '%s: : you passed %s wich is not part of the configured FlagSetsFilter, ignoring Flag Set.'],
     // initialization / settings validation
     [c.WARN_INTEGRATION_INVALID, c.LOG_PREFIX_SETTINGS + ': %s integration item(s) at settings is invalid. %s'],
     [c.WARN_SPLITS_FILTER_IGNORED, c.LOG_PREFIX_SETTINGS + ': feature flag filters have been configured but will have no effect if mode is not "%s", since synchronization is being deferred to an external tool.'],

package/cjs/utils/settingsValidation/splitFilters.js

@@ -180,19 +180,14 @@ function validateSplitFilters(log, maybeSplitFilters, mode) {
 }
 exports.validateSplitFilters = validateSplitFilters;
 function flagSetsAreValid(log, method, flagSets, flagSetsInConfig) {
-    var toReturn = [];
-    if (flagSets.length === 0) {
-        log.error(constants_2.ERROR_EMPTY_ARRAY, [method, 'flagSets']);
-        return toReturn;
-    }
     var sets = (0, splits_1.validateSplits)(log, flagSets, method, 'flag sets', 'flag set');
-    toReturn = sets ? sanitizeFlagSets(log, sets) : [];
+    var toReturn = sets ? sanitizeFlagSets(log, sets) : [];
     if (flagSetsInConfig.length > 0) {
         toReturn = toReturn.filter(function (flagSet) {
             if (flagSetsInConfig.indexOf(flagSet) > -1) {
                 return true;
             }
-            log.warn(constants_2.WARN_FLAGSET_NOT_CONFIGURED, [flagSet]);
+            log.warn(constants_2.WARN_FLAGSET_NOT_CONFIGURED, [method, flagSet]);
             return false;
         });
     }

package/esm/logger/messages/warn.js

@@ -23,6 +23,7 @@ export var codesWarn = codesError.concat([
     [c.WARN_NOT_EXISTENT_SPLIT, '%s: feature flag "%s" does not exist in this environment. Please double check what feature flags exist in the Split user interface.'],
     [c.WARN_LOWERCASE_TRAFFIC_TYPE, '%s: traffic_type_name should be all lowercase - converting string to lowercase.'],
     [c.WARN_NOT_EXISTENT_TT, '%s: traffic type "%s" does not have any corresponding feature flag in this environment, make sure you\'re tracking your events to a valid traffic type defined in the Split user interface.'],
+    [c.WARN_FLAGSET_NOT_CONFIGURED, '%s: : you passed %s wich is not part of the configured FlagSetsFilter, ignoring Flag Set.'],
     // initialization / settings validation
     [c.WARN_INTEGRATION_INVALID, c.LOG_PREFIX_SETTINGS + ': %s integration item(s) at settings is invalid. %s'],
     [c.WARN_SPLITS_FILTER_IGNORED, c.LOG_PREFIX_SETTINGS + ': feature flag filters have been configured but will have no effect if mode is not "%s", since synchronization is being deferred to an external tool.'],

package/esm/utils/settingsValidation/splitFilters.js

@@ -1,6 +1,6 @@
 import { STANDALONE_MODE } from '../constants';
 import { validateSplits } from '../inputValidation/splits';
-import { WARN_SPLITS_FILTER_IGNORED, WARN_SPLITS_FILTER_EMPTY, WARN_SPLITS_FILTER_INVALID, SETTINGS_SPLITS_FILTER, LOG_PREFIX_SETTINGS, ERROR_SETS_FILTER_EXCLUSIVE, WARN_SPLITS_FILTER_LOWERCASE_SET, WARN_SPLITS_FILTER_INVALID_SET, ERROR_EMPTY_ARRAY, WARN_FLAGSET_NOT_CONFIGURED } from '../../logger/constants';
+import { WARN_SPLITS_FILTER_IGNORED, WARN_SPLITS_FILTER_EMPTY, WARN_SPLITS_FILTER_INVALID, SETTINGS_SPLITS_FILTER, LOG_PREFIX_SETTINGS, ERROR_SETS_FILTER_EXCLUSIVE, WARN_SPLITS_FILTER_LOWERCASE_SET, WARN_SPLITS_FILTER_INVALID_SET, WARN_FLAGSET_NOT_CONFIGURED } from '../../logger/constants';
 import { objectAssign } from '../lang/objectAssign';
 import { find, uniq } from '../lang';
 // Split filters metadata.
@@ -176,19 +176,14 @@ export function validateSplitFilters(log, maybeSplitFilters, mode) {
     return res;
 }
 export function flagSetsAreValid(log, method, flagSets, flagSetsInConfig) {
-    var toReturn = [];
-    if (flagSets.length === 0) {
-        log.error(ERROR_EMPTY_ARRAY, [method, 'flagSets']);
-        return toReturn;
-    }
     var sets = validateSplits(log, flagSets, method, 'flag sets', 'flag set');
-    toReturn = sets ? sanitizeFlagSets(log, sets) : [];
+    var toReturn = sets ? sanitizeFlagSets(log, sets) : [];
     if (flagSetsInConfig.length > 0) {
         toReturn = toReturn.filter(function (flagSet) {
             if (flagSetsInConfig.indexOf(flagSet) > -1) {
                 return true;
             }
-            log.warn(WARN_FLAGSET_NOT_CONFIGURED, [flagSet]);
+            log.warn(WARN_FLAGSET_NOT_CONFIGURED, [method, flagSet]);
             return false;
         });
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@splitsoftware/splitio-commons",
-  "version": "1.9.2-rc.0",
+  "version": "1.9.2-rc.1",
   "description": "Split Javascript SDK common components",
   "main": "cjs/index.js",
   "module": "esm/index.js",

package/src/logger/messages/warn.ts

@@ -24,6 +24,7 @@ export const codesWarn: [number, string][] = codesError.concat([
   [c.WARN_NOT_EXISTENT_SPLIT, '%s: feature flag "%s" does not exist in this environment. Please double check what feature flags exist in the Split user interface.'],
   [c.WARN_LOWERCASE_TRAFFIC_TYPE, '%s: traffic_type_name should be all lowercase - converting string to lowercase.'],
   [c.WARN_NOT_EXISTENT_TT, '%s: traffic type "%s" does not have any corresponding feature flag in this environment, make sure you\'re tracking your events to a valid traffic type defined in the Split user interface.'],
+  [c.WARN_FLAGSET_NOT_CONFIGURED, '%s: : you passed %s wich is not part of the configured FlagSetsFilter, ignoring Flag Set.'],
   // initialization / settings validation
   [c.WARN_INTEGRATION_INVALID, c.LOG_PREFIX_SETTINGS+': %s integration item(s) at settings is invalid. %s'],
   [c.WARN_SPLITS_FILTER_IGNORED, c.LOG_PREFIX_SETTINGS+': feature flag filters have been configured but will have no effect if mode is not "%s", since synchronization is being deferred to an external tool.'],

package/src/sdkClient/clientInputValidation.ts

@@ -31,7 +31,7 @@ export function clientInputValidationDecorator<TClient extends SplitIO.IClient |
   /**
    * Avoid repeating this validations code
    */
-  function validateEvaluationParams(maybeKey: SplitIO.SplitKey, maybeFeatureFlagNameOrNames: string | string[] | undefined, maybeAttributes: SplitIO.Attributes | undefined, methodName: string, maybeFlagSetNameOrNames?: string[] | undefined) {
+  function validateEvaluationParams(maybeKey: SplitIO.SplitKey, maybeFeatureFlagNameOrNames: string | string[] | undefined, maybeAttributes: SplitIO.Attributes | undefined, methodName: string, maybeFlagSetNameOrNames?: string[]) {
     const multi = startsWith(methodName, 'getTreatments');
     const key = validateKey(log, maybeKey, methodName);
     let splitOrSplits: string | string[] | false = false;

package/src/utils/settingsValidation/splitFilters.ts

@@ -3,7 +3,7 @@ import { validateSplits } from '../inputValidation/splits';
 import { ISplitFiltersValidation } from '../../dtos/types';
 import { SplitIO } from '../../types';
 import { ILogger } from '../../logger/types';
-import { WARN_SPLITS_FILTER_IGNORED, WARN_SPLITS_FILTER_EMPTY, WARN_SPLITS_FILTER_INVALID, SETTINGS_SPLITS_FILTER, LOG_PREFIX_SETTINGS, ERROR_SETS_FILTER_EXCLUSIVE, WARN_SPLITS_FILTER_LOWERCASE_SET, WARN_SPLITS_FILTER_INVALID_SET, ERROR_EMPTY_ARRAY, WARN_FLAGSET_NOT_CONFIGURED } from '../../logger/constants';
+import { WARN_SPLITS_FILTER_IGNORED, WARN_SPLITS_FILTER_EMPTY, WARN_SPLITS_FILTER_INVALID, SETTINGS_SPLITS_FILTER, LOG_PREFIX_SETTINGS, ERROR_SETS_FILTER_EXCLUSIVE, WARN_SPLITS_FILTER_LOWERCASE_SET, WARN_SPLITS_FILTER_INVALID_SET, WARN_FLAGSET_NOT_CONFIGURED } from '../../logger/constants';
 import { objectAssign } from '../lang/objectAssign';
 import { find, uniq } from '../lang';
 
@@ -189,19 +189,14 @@ export function validateSplitFilters(log: ILogger, maybeSplitFilters: any, mode:
 }
 
 export function flagSetsAreValid(log: ILogger, method: string, flagSets: string[], flagSetsInConfig: string[]): string[] {
-  let toReturn: string[] = [];
-  if (flagSets.length === 0) {
-    log.error(ERROR_EMPTY_ARRAY, [method, 'flagSets']);
-    return toReturn;
-  }
   const sets = validateSplits(log, flagSets, method, 'flag sets', 'flag set');
-  toReturn = sets ? sanitizeFlagSets(log, sets) : [];
+  let toReturn = sets ? sanitizeFlagSets(log, sets) : [];
   if (flagSetsInConfig.length > 0) {
     toReturn = toReturn.filter(flagSet => {
       if (flagSetsInConfig.indexOf(flagSet) > -1) {
         return true;
       }
-      log.warn(WARN_FLAGSET_NOT_CONFIGURED, [flagSet]);
+      log.warn(WARN_FLAGSET_NOT_CONFIGURED, [method, flagSet]);
       return false;
     });
   }

package/cjs/myLogger.js

@@ -1,34 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.myLogger = void 0;
-// get the Console class
-// const { Console } = require('console');
-// get fs module for creating write streams
-var fs = require('fs');
-var pjson = require('../package.json');
-//@ts-ignore
-var pad = function (value) { return ('00' + value).slice(-2); };
-var getDate = function () {
-    var date = new Date();
-    return date.getFullYear() + "-" + pad(date.getMonth() + 1) + "-" + pad(date.getDate()) + "_" + pad(date.getHours()) + ":" + pad(date.getMinutes()) + ":" + pad(date.getSeconds());
-};
-//@ts-ignore
-var logToFile = function (file, msg) {
-    //@ts-ignore
-    fs.appendFileSync(file, msg + "\n", function (err) {
-        if (err) {
-            return console.log(err);
-        }
-    });
-};
-// make a new logger
-var version = pjson.version.replace('.', '').replace('.', '');
-var filePath = "logs/" + version + "_" + getDate();
-exports.myLogger = {
-    //@ts-ignore
-    log: function (msg) { return logToFile(filePath, msg); },
-    //@ts-ignore
-    logCsv: function (msg) { return logToFile(filePath + ".csv", msg); },
-    //@ts-ignore
-    logToFile: function (file, msg) { return logToFile("logs/" + file, msg); },
-};

package/esm/myLogger.js

@@ -1,31 +0,0 @@
-// get the Console class
-// const { Console } = require('console');
-// get fs module for creating write streams
-var fs = require('fs');
-var pjson = require('../package.json');
-//@ts-ignore
-var pad = function (value) { return ('00' + value).slice(-2); };
-var getDate = function () {
-    var date = new Date();
-    return date.getFullYear() + "-" + pad(date.getMonth() + 1) + "-" + pad(date.getDate()) + "_" + pad(date.getHours()) + ":" + pad(date.getMinutes()) + ":" + pad(date.getSeconds());
-};
-//@ts-ignore
-var logToFile = function (file, msg) {
-    //@ts-ignore
-    fs.appendFileSync(file, msg + "\n", function (err) {
-        if (err) {
-            return console.log(err);
-        }
-    });
-};
-// make a new logger
-var version = pjson.version.replace('.', '').replace('.', '');
-var filePath = "logs/" + version + "_" + getDate();
-export var myLogger = {
-    //@ts-ignore
-    log: function (msg) { return logToFile(filePath, msg); },
-    //@ts-ignore
-    logCsv: function (msg) { return logToFile(filePath + ".csv", msg); },
-    //@ts-ignore
-    logToFile: function (file, msg) { return logToFile("logs/" + file, msg); },
-};

package/src/myLogger.ts

@@ -1,36 +0,0 @@
-// get the Console class
-// const { Console } = require('console');
-// get fs module for creating write streams
-const fs = require('fs');
-var pjson = require('../package.json');
-
-//@ts-ignore
-const pad = (value) => ('00'+value).slice(-2);
-const getDate = () => {
-  const date = new Date();
-  return `${date.getFullYear()}-${pad(date.getMonth()+1)}-${pad(date.getDate())}_${pad(date.getHours())}:${pad(date.getMinutes())}:${pad(date.getSeconds())}`;
-};
-
-//@ts-ignore
-
-const logToFile = (file, msg) => {
-//@ts-ignore
-  fs.appendFileSync(file, `${msg}\n`, (err) => {
-    if (err) {
-      return console.log(err);
-    }
-  });
-};
-
-// make a new logger
-const version = pjson.version.replace('.','').replace('.','');
-const filePath = `logs/${version}_${getDate()}`;
-export const myLogger = {
-  //@ts-ignore
-  log: (msg) => logToFile(filePath, msg),
-  //@ts-ignore
-  logCsv: (msg) => logToFile(`${filePath}.csv`, msg),
-  //@ts-ignore
-  logToFile: (file, msg) => logToFile(`logs/${file}`, msg),
-};
-