@splitsoftware/splitio-commons 1.8.2-rc.0 → 1.8.2-rc.1

package/src/storages/inMemory/AttributesCacheInMemory.ts

@@ -1,8 +1,9 @@
+import { SplitIO } from '../../types';
 import { objectAssign } from '../../utils/lang/objectAssign';
 
 export class AttributesCacheInMemory {
 
-  private attributesCache: Record<string, Object> = {};
+  private attributesCache: Record<string, SplitIO.AttributeType> = {};
 
 
   /**
@@ -12,7 +13,7 @@ export class AttributesCacheInMemory {
    * @param {Object} attributeValue attribute value
    * @returns {boolean} the attribute was stored
    */
-  setAttribute(attributeName: string, attributeValue: Object): boolean {
+  setAttribute(attributeName: string, attributeValue: SplitIO.AttributeType) {
     this.attributesCache[attributeName] = attributeValue;
     return true;
   }
@@ -23,7 +24,7 @@ export class AttributesCacheInMemory {
    * @param {string} attributeName attribute name
    * @returns {Object?} stored attribute value
    */
-  getAttribute(attributeName: string): Object {
+  getAttribute(attributeName: string) {
     return this.attributesCache[attributeName];
   }
 
@@ -33,7 +34,7 @@ export class AttributesCacheInMemory {
    * @param {[string, Object]} attributes attributes to create or update
    * @returns {boolean} attributes were stored
    */
-  setAttributes(attributes: Record<string, Object>): boolean {
+  setAttributes(attributes: Record<string, Object>) {
     this.attributesCache = objectAssign(this.attributesCache, attributes);
     return true;
   }
@@ -43,7 +44,7 @@ export class AttributesCacheInMemory {
    *
    * @returns {Map<string, Object>} stored attributes
    */
-  getAll(): Record<string, Object> {
+  getAll() {
     return this.attributesCache;
   }
 
@@ -53,7 +54,7 @@ export class AttributesCacheInMemory {
    * @param {string} attributeName attribute to remove
    * @returns {boolean} attribute removed
    */
-  removeAttribute(attributeName: string): boolean {
+  removeAttribute(attributeName: string) {
     if (Object.keys(this.attributesCache).indexOf(attributeName) >= 0) {
       delete this.attributesCache[attributeName];
       return true;

package/src/storages/inRedis/SplitsCacheInRedis.ts

@@ -75,7 +75,7 @@ export class SplitsCacheInRedis extends AbstractSplitsCacheAsync {
         parsedPreviousSplit = splitFromStorage ? JSON.parse(splitFromStorage) : undefined;
         newStringifiedSplit = JSON.stringify(split);
       } catch (e) {
-        throw new Error('Error parsing split definition: ' + e);
+        throw new Error('Error parsing feature flag definition: ' + e);
       }
 
       return Promise.all([
@@ -247,7 +247,7 @@ export class SplitsCacheInRedis extends AbstractSplitsCacheAsync {
         return Promise.resolve(splits);
       })
       .catch(e => {
-        this.log.error(LOG_PREFIX + `Could not grab splits due to an error: ${e}.`);
+        this.log.error(LOG_PREFIX + `Could not grab feature flags due to an error: ${e}.`);
         return Promise.reject(e);
       });
   }

package/src/storages/pluggable/SplitsCachePluggable.ts

@@ -59,7 +59,7 @@ export class SplitsCachePluggable extends AbstractSplitsCacheAsync {
         parsedPreviousSplit = splitFromStorage ? JSON.parse(splitFromStorage) : undefined;
         stringifiedNewSplit = JSON.stringify(split);
       } catch (e) {
-        throw new Error('Error parsing split definition: ' + e);
+        throw new Error('Error parsing feature flag definition: ' + e);
       }
 
       return Promise.all([

package/src/sync/polling/updaters/segmentChangesUpdater.ts

@@ -98,7 +98,7 @@ export function segmentChangesUpdaterFactory(
           // If the operation is forbidden, it may be due to permissions. Destroy the SDK instance.
           // @TODO although factory status is destroyed, synchronization is not stopped
           if (readiness) readiness.destroy();
-          log.error(`${LOG_PREFIX_INSTANTIATION}: you passed a client-side type authorizationKey, please grab an Api Key from the Split web console that is of type Server-side.`);
+          log.error(`${LOG_PREFIX_INSTANTIATION}: you passed a client-side type authorizationKey, please grab an SDK Key from the Split user interface that is of type server-side.`);
         } else {
           log.warn(`${LOG_PREFIX_SYNC_SEGMENTS}Error while doing fetch of segments. ${error}`);
         }

package/src/sync/polling/updaters/splitChangesUpdater.ts

@@ -7,7 +7,6 @@ import { timeout } from '../../../utils/promise/timeout';
 import { SDK_SPLITS_ARRIVED, SDK_SPLITS_CACHE_LOADED } from '../../../readiness/constants';
 import { ILogger } from '../../../logger/types';
 import { SYNC_SPLITS_FETCH, SYNC_SPLITS_NEW, SYNC_SPLITS_REMOVED, SYNC_SPLITS_SEGMENTS, SYNC_SPLITS_FETCH_FAILS, SYNC_SPLITS_FETCH_RETRY } from '../../../logger/constants';
-import { _Map } from '../../../utils/lang/maps';
 
 type ISplitChangesUpdater = (noCache?: boolean, till?: number) => Promise<boolean>
 
@@ -52,25 +51,20 @@ interface ISplitMutations {
  * Exported for testing purposes.
  */
 export function computeSplitsMutation(entries: ISplit[]): ISplitMutations {
-  const uniqueEntries = new _Map();
-  entries.forEach(split => {
-    const prevSplit = uniqueEntries.get(split.name);
-    if (!prevSplit || prevSplit.changeNumber < split.changeNumber) uniqueEntries.set(split.name, split);
-  });
-
   const segments = new _Set<string>();
-  const computed = { added: [], removed: [], segments: [] } as ISplitMutations;
-  uniqueEntries.forEach((split) => {
+  const computed = entries.reduce((accum, split) => {
     if (split.status === 'ACTIVE') {
-      computed.added.push([split.name, split]);
+      accum.added.push([split.name, split]);
 
       parseSegments(split).forEach((segmentName: string) => {
         segments.add(segmentName);
       });
     } else {
-      computed.removed.push(split.name);
+      accum.removed.push(split.name);
     }
-  });
+
+    return accum;
+  }, { added: [], removed: [], segments: [] } as ISplitMutations);
 
   computed.segments = setToArray(segments);
 

package/src/sync/streaming/pushManager.ts

@@ -139,7 +139,7 @@ export function pushManagerFactory(
 
         log.error(ERROR_STREAMING_AUTH, [error.message]);
 
-        // Handle 4XX HTTP errors: 401 (invalid API Key) or 400 (using incorrect API Key, i.e., client-side API Key on server-side)
+        // Handle 4XX HTTP errors: 401 (invalid SDK Key) or 400 (using incorrect SDK Key, i.e., client-side SDK Key on server-side)
         if (error.statusCode >= 400 && error.statusCode < 500) {
           telemetryTracker.streamingEvent(AUTH_REJECTION);
           pushEmitter.emit(PUSH_NONRETRYABLE_ERROR);

package/src/sync/submitters/telemetrySubmitter.ts

@@ -33,8 +33,8 @@ function getActiveFactories() {
 }
 
 function getRedundantActiveFactories() {
-  return Object.keys(usedKeysMap).reduce((acum, apiKey) => {
-    return acum + usedKeysMap[apiKey] - 1;
+  return Object.keys(usedKeysMap).reduce((acum, sdkKey) => {
+    return acum + usedKeysMap[sdkKey] - 1;
   }, 0);
 }