@splitsoftware/splitio-commons 1.8.1 → 1.8.2-rc.0

package/CHANGES.txt

@@ -1,3 +1,6 @@
+1.8.2 (February 27, 2023)
+- Updated internal splitChangesUpdater module to be resilient to duplicated split definitions when fetching split changes from Split backend.
+
 1.8.1 (February 7, 2023)
 - Updated a module import to remove a trailing comma that can cause issues with some bundlers.
 

package/cjs/sync/polling/updaters/splitChangesUpdater.js

@@ -5,6 +5,7 @@ var sets_1 = require("../../../utils/lang/sets");
 var timeout_1 = require("../../../utils/promise/timeout");
 var constants_1 = require("../../../readiness/constants");
 var constants_2 = require("../../../logger/constants");
+var maps_1 = require("../../../utils/lang/maps");
 // Checks that all registered segments have been fetched (changeNumber !== -1 for every segment).
 // Returns a promise that could be rejected.
 // @TODO review together with Segments and MySegments storage APIs
@@ -38,19 +39,25 @@ exports.parseSegments = parseSegments;
  * Exported for testing purposes.
  */
 function computeSplitsMutation(entries) {
+    var uniqueEntries = new maps_1._Map();
+    entries.forEach(function (split) {
+        var prevSplit = uniqueEntries.get(split.name);
+        if (!prevSplit || prevSplit.changeNumber < split.changeNumber)
+            uniqueEntries.set(split.name, split);
+    });
     var segments = new sets_1._Set();
-    var computed = entries.reduce(function (accum, split) {
+    var computed = { added: [], removed: [], segments: [] };
+    uniqueEntries.forEach(function (split) {
         if (split.status === 'ACTIVE') {
-            accum.added.push([split.name, split]);
+            computed.added.push([split.name, split]);
             parseSegments(split).forEach(function (segmentName) {
                 segments.add(segmentName);
             });
         }
         else {
-            accum.removed.push(split.name);
+            computed.removed.push(split.name);
         }
-        return accum;
-    }, { added: [], removed: [], segments: [] });
+    });
     computed.segments = (0, sets_1.setToArray)(segments);
     return computed;
 }

package/esm/sync/polling/updaters/splitChangesUpdater.js

@@ -2,6 +2,7 @@ import { _Set, setToArray } from '../../../utils/lang/sets';
 import { timeout } from '../../../utils/promise/timeout';
 import { SDK_SPLITS_ARRIVED, SDK_SPLITS_CACHE_LOADED } from '../../../readiness/constants';
 import { SYNC_SPLITS_FETCH, SYNC_SPLITS_NEW, SYNC_SPLITS_REMOVED, SYNC_SPLITS_SEGMENTS, SYNC_SPLITS_FETCH_FAILS, SYNC_SPLITS_FETCH_RETRY } from '../../../logger/constants';
+import { _Map } from '../../../utils/lang/maps';
 // Checks that all registered segments have been fetched (changeNumber !== -1 for every segment).
 // Returns a promise that could be rejected.
 // @TODO review together with Segments and MySegments storage APIs
@@ -34,19 +35,25 @@ export function parseSegments(_a) {
  * Exported for testing purposes.
  */
 export function computeSplitsMutation(entries) {
+    var uniqueEntries = new _Map();
+    entries.forEach(function (split) {
+        var prevSplit = uniqueEntries.get(split.name);
+        if (!prevSplit || prevSplit.changeNumber < split.changeNumber)
+            uniqueEntries.set(split.name, split);
+    });
     var segments = new _Set();
-    var computed = entries.reduce(function (accum, split) {
+    var computed = { added: [], removed: [], segments: [] };
+    uniqueEntries.forEach(function (split) {
         if (split.status === 'ACTIVE') {
-            accum.added.push([split.name, split]);
+            computed.added.push([split.name, split]);
             parseSegments(split).forEach(function (segmentName) {
                 segments.add(segmentName);
             });
         }
         else {
-            accum.removed.push(split.name);
+            computed.removed.push(split.name);
         }
-        return accum;
-    }, { added: [], removed: [], segments: [] });
+    });
     computed.segments = setToArray(segments);
     return computed;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@splitsoftware/splitio-commons",
-  "version": "1.8.1",
+  "version": "1.8.2-rc.0",
   "description": "Split Javascript SDK common components",
   "main": "cjs/index.js",
   "module": "esm/index.js",
@@ -22,7 +22,7 @@
     "build": "npm run build:cjs && npm run build:esm",
     "build:esm": "rimraf esm && tsc -m es2015 --outDir esm -d true --declarationDir types",
     "build:cjs": "rimraf cjs && tsc -m CommonJS --outDir cjs",
-    "test": "jest",
+    "test": "jest --runInBand",
     "test:coverage": "jest --coverage",
     "all": "npm run check && npm run build && npm run test",
     "publish:rc": "npm run check && npm run test && npm run build && npm publish --tag rc",

package/src/sync/polling/updaters/splitChangesUpdater.ts

@@ -7,6 +7,7 @@ import { timeout } from '../../../utils/promise/timeout';
 import { SDK_SPLITS_ARRIVED, SDK_SPLITS_CACHE_LOADED } from '../../../readiness/constants';
 import { ILogger } from '../../../logger/types';
 import { SYNC_SPLITS_FETCH, SYNC_SPLITS_NEW, SYNC_SPLITS_REMOVED, SYNC_SPLITS_SEGMENTS, SYNC_SPLITS_FETCH_FAILS, SYNC_SPLITS_FETCH_RETRY } from '../../../logger/constants';
+import { _Map } from '../../../utils/lang/maps';
 
 type ISplitChangesUpdater = (noCache?: boolean, till?: number) => Promise<boolean>
 
@@ -51,20 +52,25 @@ interface ISplitMutations {
  * Exported for testing purposes.
  */
 export function computeSplitsMutation(entries: ISplit[]): ISplitMutations {
+  const uniqueEntries = new _Map();
+  entries.forEach(split => {
+    const prevSplit = uniqueEntries.get(split.name);
+    if (!prevSplit || prevSplit.changeNumber < split.changeNumber) uniqueEntries.set(split.name, split);
+  });
+
   const segments = new _Set<string>();
-  const computed = entries.reduce((accum, split) => {
+  const computed = { added: [], removed: [], segments: [] } as ISplitMutations;
+  uniqueEntries.forEach((split) => {
     if (split.status === 'ACTIVE') {
-      accum.added.push([split.name, split]);
+      computed.added.push([split.name, split]);
 
       parseSegments(split).forEach((segmentName: string) => {
         segments.add(segmentName);
       });
     } else {
-      accum.removed.push(split.name);
+      computed.removed.push(split.name);
     }
-
-    return accum;
-  }, { added: [], removed: [], segments: [] } as ISplitMutations);
+  });
 
   computed.segments = setToArray(segments);