@splitsoftware/splitio-commons 1.7.1 → 1.7.3-rc.0

package/CHANGES.txt

@@ -1,3 +1,11 @@
+1.7.3 (December 16, 2022)
+- Updated events and impressions cache in localhost mode in order to avoid memory leaks (Related to issue https://github.com/splitio/javascript-commons/issues/181).
+- Updated unique keys cache for Redis and Pluggable storages to optimize the usage of the underlying storage.
+- Updated some transitive dependencies for vulnerability fixes.
+
+1.7.2 (October 14, 2022)
+- Bugfixing - Handle `Navigator.sendBeacon` API exceptions in the browser, and fallback to regular Fetch/XHR transport in case of error.
+
 1.7.1 (October 5, 2022)
 - Updated default value of `scheduler.featuresRefreshRate` config parameter to 60 seconds.
 

package/cjs/listeners/browser.js

@@ -100,13 +100,14 @@ var BrowserSignalListener = /** @class */ (function () {
         if (!cache.isEmpty()) {
             var dataPayload = fromCacheToPayload ? fromCacheToPayload(cache.pop()) : cache.pop();
             if (!this._sendBeacon(url, dataPayload, extraMetadata)) {
-                postService(JSON.stringify(dataPayload)).catch(function () { }); // no-op just to catch a possible exception
+                postService(JSON.stringify(dataPayload)).catch(function () { }); // no-op to handle possible promise rejection
             }
         }
     };
     /**
      * _sendBeacon method.
      * Util method that check if beacon API is available, build the payload and send it.
+     * Returns true if beacon API was used successfully, false otherwise.
      */
     BrowserSignalListener.prototype._sendBeacon = function (url, data, extraMetadata) {
         // eslint-disable-next-line compat/compat
@@ -121,8 +122,13 @@ var BrowserSignalListener = /** @class */ (function () {
                 (0, objectAssign_1.objectAssign)(json, extraMetadata);
             // Stringify the payload
             var payload = JSON.stringify(json);
-            // eslint-disable-next-line compat/compat
-            return navigator.sendBeacon(url, payload);
+            // https://xgwang.me/posts/you-may-not-know-beacon/#it-may-throw-error%2C-be-sure-to-catch
+            try { // eslint-disable-next-line compat/compat
+                return navigator.sendBeacon(url, payload);
+            }
+            catch (e) {
+                return false;
+            }
         }
         return false;
     };

package/cjs/storages/inMemory/ImpressionCountsCacheInMemory.js

@@ -27,7 +27,6 @@ var ImpressionCountsCacheInMemory = /** @class */ (function () {
             this.cacheSize = this.cacheSize + amount;
             if (this.cacheSize >= this.maxStorage) {
                 this.onFullQueue();
-                this.cacheSize = 0;
             }
         }
     };
@@ -53,6 +52,7 @@ var ImpressionCountsCacheInMemory = /** @class */ (function () {
      */
     ImpressionCountsCacheInMemory.prototype.clear = function () {
         this.cache = {};
+        this.cacheSize = 0;
     };
     /**
      * Check if the cache is empty.

package/cjs/storages/inMemory/InMemoryStorage.js

@@ -18,7 +18,7 @@ function InMemoryStorageFactory(params) {
     var _a = params.settings, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize, impressionsMode = _a.sync.impressionsMode;
     var splits = new SplitsCacheInMemory_1.SplitsCacheInMemory();
     var segments = new SegmentsCacheInMemory_1.SegmentsCacheInMemory();
-    return {
+    var storage = {
         splits: splits,
         segments: segments,
         impressions: new ImpressionsCacheInMemory_1.ImpressionsCacheInMemory(impressionsQueueSize),
@@ -28,15 +28,26 @@ function InMemoryStorageFactory(params) {
         uniqueKeys: impressionsMode === constants_1.NONE ? new UniqueKeysCacheInMemory_1.UniqueKeysCacheInMemory() : undefined,
         // When using MEMORY we should clean all the caches to leave them empty
         destroy: function () {
-            var _a;
             this.splits.clear();
             this.segments.clear();
             this.impressions.clear();
             this.impressionCounts && this.impressionCounts.clear();
             this.events.clear();
-            (_a = this.uniqueKeys) === null || _a === void 0 ? void 0 : _a.clear();
+            this.uniqueKeys && this.uniqueKeys.clear();
         }
     };
+    // @TODO revisit storage logic in localhost mode
+    // No tracking data in localhost mode to avoid memory leaks
+    if (params.settings.mode === constants_1.LOCALHOST_MODE) {
+        var noopTrack = function () { return true; };
+        storage.impressions.track = noopTrack;
+        storage.events.track = noopTrack;
+        if (storage.impressionCounts)
+            storage.impressionCounts.track = noopTrack;
+        if (storage.uniqueKeys)
+            storage.uniqueKeys.track = noopTrack;
+    }
+    return storage;
 }
 exports.InMemoryStorageFactory = InMemoryStorageFactory;
 InMemoryStorageFactory.type = constants_1.STORAGE_MEMORY;

package/cjs/storages/inMemory/InMemoryStorageCS.js

@@ -18,7 +18,7 @@ function InMemoryStorageCSFactory(params) {
     var _a = params.settings, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize, impressionsMode = _a.sync.impressionsMode;
     var splits = new SplitsCacheInMemory_1.SplitsCacheInMemory();
     var segments = new MySegmentsCacheInMemory_1.MySegmentsCacheInMemory();
-    return {
+    var storage = {
         splits: splits,
         segments: segments,
         impressions: new ImpressionsCacheInMemory_1.ImpressionsCacheInMemory(impressionsQueueSize),
@@ -28,13 +28,12 @@ function InMemoryStorageCSFactory(params) {
         uniqueKeys: impressionsMode === constants_1.NONE ? new UniqueKeysCacheInMemoryCS_1.UniqueKeysCacheInMemoryCS() : undefined,
         // When using MEMORY we should clean all the caches to leave them empty
         destroy: function () {
-            var _a;
             this.splits.clear();
             this.segments.clear();
             this.impressions.clear();
             this.impressionCounts && this.impressionCounts.clear();
             this.events.clear();
-            (_a = this.uniqueKeys) === null || _a === void 0 ? void 0 : _a.clear();
+            this.uniqueKeys && this.uniqueKeys.clear();
         },
         // When using shared instanciation with MEMORY we reuse everything but segments (they are unique per key)
         shared: function () {
@@ -53,6 +52,18 @@ function InMemoryStorageCSFactory(params) {
             };
         },
     };
+    // @TODO revisit storage logic in localhost mode
+    // No tracking data in localhost mode to avoid memory leaks
+    if (params.settings.mode === constants_1.LOCALHOST_MODE) {
+        var noopTrack = function () { return true; };
+        storage.impressions.track = noopTrack;
+        storage.events.track = noopTrack;
+        if (storage.impressionCounts)
+            storage.impressionCounts.track = noopTrack;
+        if (storage.uniqueKeys)
+            storage.uniqueKeys.track = noopTrack;
+    }
+    return storage;
 }
 exports.InMemoryStorageCSFactory = InMemoryStorageCSFactory;
 InMemoryStorageCSFactory.type = constants_1.STORAGE_MEMORY;

package/cjs/storages/inMemory/UniqueKeysCacheInMemory.js

@@ -25,8 +25,8 @@ var UniqueKeysCacheInMemory = /** @class */ (function () {
     function UniqueKeysCacheInMemory(uniqueKeysQueueSize) {
         if (uniqueKeysQueueSize === void 0) { uniqueKeysQueueSize = constants_1.DEFAULT_CACHE_SIZE; }
         this.uniqueTrackerSize = 0;
-        this.maxStorage = uniqueKeysQueueSize;
         this.uniqueKeysTracker = {};
+        this.maxStorage = uniqueKeysQueueSize;
     }
     UniqueKeysCacheInMemory.prototype.setOnFullQueueCb = function (cb) {
         this.onFullQueue = cb;
@@ -43,7 +43,6 @@ var UniqueKeysCacheInMemory = /** @class */ (function () {
             this.uniqueTrackerSize++;
         }
         if (this.uniqueTrackerSize >= this.maxStorage && this.onFullQueue) {
-            this.uniqueTrackerSize = 0;
             this.onFullQueue();
         }
     };
@@ -51,6 +50,7 @@ var UniqueKeysCacheInMemory = /** @class */ (function () {
      * Clear the data stored on the cache.
      */
     UniqueKeysCacheInMemory.prototype.clear = function () {
+        this.uniqueTrackerSize = 0;
         this.uniqueKeysTracker = {};
     };
     /**
@@ -58,7 +58,7 @@ var UniqueKeysCacheInMemory = /** @class */ (function () {
      */
     UniqueKeysCacheInMemory.prototype.pop = function () {
         var data = this.uniqueKeysTracker;
-        this.uniqueKeysTracker = {};
+        this.clear();
         return fromUniqueKeysCollector(data);
     };
     /**

package/cjs/storages/inMemory/UniqueKeysCacheInMemoryCS.js

@@ -12,8 +12,8 @@ var UniqueKeysCacheInMemoryCS = /** @class */ (function () {
     function UniqueKeysCacheInMemoryCS(uniqueKeysQueueSize) {
         if (uniqueKeysQueueSize === void 0) { uniqueKeysQueueSize = constants_1.DEFAULT_CACHE_SIZE; }
         this.uniqueTrackerSize = 0;
-        this.maxStorage = uniqueKeysQueueSize;
         this.uniqueKeysTracker = {};
+        this.maxStorage = uniqueKeysQueueSize;
     }
     UniqueKeysCacheInMemoryCS.prototype.setOnFullQueueCb = function (cb) {
         this.onFullQueue = cb;
@@ -30,7 +30,6 @@ var UniqueKeysCacheInMemoryCS = /** @class */ (function () {
             this.uniqueTrackerSize++;
         }
         if (this.uniqueTrackerSize >= this.maxStorage && this.onFullQueue) {
-            this.uniqueTrackerSize = 0;
             this.onFullQueue();
         }
     };
@@ -38,6 +37,7 @@ var UniqueKeysCacheInMemoryCS = /** @class */ (function () {
      * Clear the data stored on the cache.
      */
     UniqueKeysCacheInMemoryCS.prototype.clear = function () {
+        this.uniqueTrackerSize = 0;
         this.uniqueKeysTracker = {};
     };
     /**
@@ -45,7 +45,7 @@ var UniqueKeysCacheInMemoryCS = /** @class */ (function () {
      */
     UniqueKeysCacheInMemoryCS.prototype.pop = function () {
         var data = this.uniqueKeysTracker;
-        this.uniqueKeysTracker = {};
+        this.clear();
         return this.fromUniqueKeysCollector(data);
     };
     /**

package/cjs/storages/inRedis/UniqueKeysCacheInRedis.js

@@ -24,21 +24,19 @@ var UniqueKeysCacheInRedis = /** @class */ (function (_super) {
         var featureNames = Object.keys(this.uniqueKeysTracker);
         if (!featureNames.length)
             return Promise.resolve(false);
-        var pipeline = this.redis.pipeline();
-        for (var i = 0; i < featureNames.length; i++) {
-            var featureName = featureNames[i];
-            var featureKeys = (0, sets_1.setToArray)(this.uniqueKeysTracker[featureName]);
+        var uniqueKeysArray = featureNames.map(function (featureName) {
+            var featureKeys = (0, sets_1.setToArray)(_this.uniqueKeysTracker[featureName]);
             var uniqueKeysPayload = {
                 f: featureName,
                 ks: featureKeys
             };
-            pipeline.rpush(this.key, JSON.stringify(uniqueKeysPayload));
-        }
+            return JSON.stringify(uniqueKeysPayload);
+        });
         this.clear();
-        return pipeline.exec()
+        return this.redis.rpush(this.key, uniqueKeysArray)
             .then(function (data) {
             // If this is the creation of the key on Redis, set the expiration for it in 3600 seconds.
-            if (data.length && data.length === featureNames.length) {
+            if (data === featureNames.length) {
                 return _this.redis.expire(_this.key, constants_1.TTL_REFRESH);
             }
         })

package/cjs/storages/pluggable/UniqueKeysCachePluggable.js

@@ -24,16 +24,17 @@ var UniqueKeysCachePluggable = /** @class */ (function (_super) {
         var featureNames = Object.keys(this.uniqueKeysTracker);
         if (!featureNames.length)
             return Promise.resolve(false);
-        var pipeline = featureNames.reduce(function (pipeline, featureName) {
+        var uniqueKeysArray = featureNames.map(function (featureName) {
             var featureKeys = (0, sets_1.setToArray)(_this.uniqueKeysTracker[featureName]);
             var uniqueKeysPayload = {
                 f: featureName,
                 ks: featureKeys
             };
-            return pipeline.then(function () { return _this.wrapper.pushItems(_this.key, [JSON.stringify(uniqueKeysPayload)]); });
-        }, Promise.resolve());
+            return JSON.stringify(uniqueKeysPayload);
+        });
         this.clear();
-        return pipeline.catch(function (err) {
+        return this.wrapper.pushItems(this.key, uniqueKeysArray)
+            .catch(function (err) {
             _this.log.error(constants_2.LOG_PREFIX + "Error in uniqueKeys pipeline: " + err + ".");
             return false;
         });

package/cjs/utils/settingsValidation/index.js

@@ -48,7 +48,7 @@ exports.base = {
     urls: {
         // CDN having all the information for your environment
         sdk: 'https://sdk.split.io/api',
-        // Storage for your SDK events
+        // SDK event and impression endpoints
         events: 'https://events.split.io/api',
         // SDK Auth Server
         auth: 'https://auth.split.io/api',

package/esm/listeners/browser.js

@@ -97,13 +97,14 @@ var BrowserSignalListener = /** @class */ (function () {
         if (!cache.isEmpty()) {
             var dataPayload = fromCacheToPayload ? fromCacheToPayload(cache.pop()) : cache.pop();
             if (!this._sendBeacon(url, dataPayload, extraMetadata)) {
-                postService(JSON.stringify(dataPayload)).catch(function () { }); // no-op just to catch a possible exception
+                postService(JSON.stringify(dataPayload)).catch(function () { }); // no-op to handle possible promise rejection
             }
         }
     };
     /**
      * _sendBeacon method.
      * Util method that check if beacon API is available, build the payload and send it.
+     * Returns true if beacon API was used successfully, false otherwise.
      */
     BrowserSignalListener.prototype._sendBeacon = function (url, data, extraMetadata) {
         // eslint-disable-next-line compat/compat
@@ -118,8 +119,13 @@ var BrowserSignalListener = /** @class */ (function () {
                 objectAssign(json, extraMetadata);
             // Stringify the payload
             var payload = JSON.stringify(json);
-            // eslint-disable-next-line compat/compat
-            return navigator.sendBeacon(url, payload);
+            // https://xgwang.me/posts/you-may-not-know-beacon/#it-may-throw-error%2C-be-sure-to-catch
+            try { // eslint-disable-next-line compat/compat
+                return navigator.sendBeacon(url, payload);
+            }
+            catch (e) {
+                return false;
+            }
         }
         return false;
     };

package/esm/storages/inMemory/ImpressionCountsCacheInMemory.js

@@ -24,7 +24,6 @@ var ImpressionCountsCacheInMemory = /** @class */ (function () {
             this.cacheSize = this.cacheSize + amount;
             if (this.cacheSize >= this.maxStorage) {
                 this.onFullQueue();
-                this.cacheSize = 0;
             }
         }
     };
@@ -50,6 +49,7 @@ var ImpressionCountsCacheInMemory = /** @class */ (function () {
      */
     ImpressionCountsCacheInMemory.prototype.clear = function () {
         this.cache = {};
+        this.cacheSize = 0;
     };
     /**
      * Check if the cache is empty.

package/esm/storages/inMemory/InMemoryStorage.js

@@ -3,7 +3,7 @@ import { SegmentsCacheInMemory } from './SegmentsCacheInMemory';
 import { ImpressionsCacheInMemory } from './ImpressionsCacheInMemory';
 import { EventsCacheInMemory } from './EventsCacheInMemory';
 import { ImpressionCountsCacheInMemory } from './ImpressionCountsCacheInMemory';
-import { DEBUG, NONE, STORAGE_MEMORY } from '../../utils/constants';
+import { DEBUG, LOCALHOST_MODE, NONE, STORAGE_MEMORY } from '../../utils/constants';
 import { shouldRecordTelemetry, TelemetryCacheInMemory } from './TelemetryCacheInMemory';
 import { UniqueKeysCacheInMemory } from './UniqueKeysCacheInMemory';
 /**
@@ -15,7 +15,7 @@ export function InMemoryStorageFactory(params) {
     var _a = params.settings, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize, impressionsMode = _a.sync.impressionsMode;
     var splits = new SplitsCacheInMemory();
     var segments = new SegmentsCacheInMemory();
-    return {
+    var storage = {
         splits: splits,
         segments: segments,
         impressions: new ImpressionsCacheInMemory(impressionsQueueSize),
@@ -25,14 +25,25 @@ export function InMemoryStorageFactory(params) {
         uniqueKeys: impressionsMode === NONE ? new UniqueKeysCacheInMemory() : undefined,
         // When using MEMORY we should clean all the caches to leave them empty
         destroy: function () {
-            var _a;
             this.splits.clear();
             this.segments.clear();
             this.impressions.clear();
             this.impressionCounts && this.impressionCounts.clear();
             this.events.clear();
-            (_a = this.uniqueKeys) === null || _a === void 0 ? void 0 : _a.clear();
+            this.uniqueKeys && this.uniqueKeys.clear();
         }
     };
+    // @TODO revisit storage logic in localhost mode
+    // No tracking data in localhost mode to avoid memory leaks
+    if (params.settings.mode === LOCALHOST_MODE) {
+        var noopTrack = function () { return true; };
+        storage.impressions.track = noopTrack;
+        storage.events.track = noopTrack;
+        if (storage.impressionCounts)
+            storage.impressionCounts.track = noopTrack;
+        if (storage.uniqueKeys)
+            storage.uniqueKeys.track = noopTrack;
+    }
+    return storage;
 }
 InMemoryStorageFactory.type = STORAGE_MEMORY;

package/esm/storages/inMemory/InMemoryStorageCS.js

@@ -3,7 +3,7 @@ import { MySegmentsCacheInMemory } from './MySegmentsCacheInMemory';
 import { ImpressionsCacheInMemory } from './ImpressionsCacheInMemory';
 import { EventsCacheInMemory } from './EventsCacheInMemory';
 import { ImpressionCountsCacheInMemory } from './ImpressionCountsCacheInMemory';
-import { DEBUG, NONE, STORAGE_MEMORY } from '../../utils/constants';
+import { DEBUG, LOCALHOST_MODE, NONE, STORAGE_MEMORY } from '../../utils/constants';
 import { shouldRecordTelemetry, TelemetryCacheInMemory } from './TelemetryCacheInMemory';
 import { UniqueKeysCacheInMemoryCS } from './UniqueKeysCacheInMemoryCS';
 /**
@@ -15,7 +15,7 @@ export function InMemoryStorageCSFactory(params) {
     var _a = params.settings, _b = _a.scheduler, impressionsQueueSize = _b.impressionsQueueSize, eventsQueueSize = _b.eventsQueueSize, impressionsMode = _a.sync.impressionsMode;
     var splits = new SplitsCacheInMemory();
     var segments = new MySegmentsCacheInMemory();
-    return {
+    var storage = {
         splits: splits,
         segments: segments,
         impressions: new ImpressionsCacheInMemory(impressionsQueueSize),
@@ -25,13 +25,12 @@ export function InMemoryStorageCSFactory(params) {
         uniqueKeys: impressionsMode === NONE ? new UniqueKeysCacheInMemoryCS() : undefined,
         // When using MEMORY we should clean all the caches to leave them empty
         destroy: function () {
-            var _a;
             this.splits.clear();
             this.segments.clear();
             this.impressions.clear();
             this.impressionCounts && this.impressionCounts.clear();
             this.events.clear();
-            (_a = this.uniqueKeys) === null || _a === void 0 ? void 0 : _a.clear();
+            this.uniqueKeys && this.uniqueKeys.clear();
         },
         // When using shared instanciation with MEMORY we reuse everything but segments (they are unique per key)
         shared: function () {
@@ -50,5 +49,17 @@ export function InMemoryStorageCSFactory(params) {
             };
         },
     };
+    // @TODO revisit storage logic in localhost mode
+    // No tracking data in localhost mode to avoid memory leaks
+    if (params.settings.mode === LOCALHOST_MODE) {
+        var noopTrack = function () { return true; };
+        storage.impressions.track = noopTrack;
+        storage.events.track = noopTrack;
+        if (storage.impressionCounts)
+            storage.impressionCounts.track = noopTrack;
+        if (storage.uniqueKeys)
+            storage.uniqueKeys.track = noopTrack;
+    }
+    return storage;
 }
 InMemoryStorageCSFactory.type = STORAGE_MEMORY;

package/esm/storages/inMemory/UniqueKeysCacheInMemory.js

@@ -21,8 +21,8 @@ var UniqueKeysCacheInMemory = /** @class */ (function () {
     function UniqueKeysCacheInMemory(uniqueKeysQueueSize) {
         if (uniqueKeysQueueSize === void 0) { uniqueKeysQueueSize = DEFAULT_CACHE_SIZE; }
         this.uniqueTrackerSize = 0;
-        this.maxStorage = uniqueKeysQueueSize;
         this.uniqueKeysTracker = {};
+        this.maxStorage = uniqueKeysQueueSize;
     }
     UniqueKeysCacheInMemory.prototype.setOnFullQueueCb = function (cb) {
         this.onFullQueue = cb;
@@ -39,7 +39,6 @@ var UniqueKeysCacheInMemory = /** @class */ (function () {
             this.uniqueTrackerSize++;
         }
         if (this.uniqueTrackerSize >= this.maxStorage && this.onFullQueue) {
-            this.uniqueTrackerSize = 0;
             this.onFullQueue();
         }
     };
@@ -47,6 +46,7 @@ var UniqueKeysCacheInMemory = /** @class */ (function () {
      * Clear the data stored on the cache.
      */
     UniqueKeysCacheInMemory.prototype.clear = function () {
+        this.uniqueTrackerSize = 0;
         this.uniqueKeysTracker = {};
     };
     /**
@@ -54,7 +54,7 @@ var UniqueKeysCacheInMemory = /** @class */ (function () {
      */
     UniqueKeysCacheInMemory.prototype.pop = function () {
         var data = this.uniqueKeysTracker;
-        this.uniqueKeysTracker = {};
+        this.clear();
         return fromUniqueKeysCollector(data);
     };
     /**

package/esm/storages/inMemory/UniqueKeysCacheInMemoryCS.js

@@ -9,8 +9,8 @@ var UniqueKeysCacheInMemoryCS = /** @class */ (function () {
     function UniqueKeysCacheInMemoryCS(uniqueKeysQueueSize) {
         if (uniqueKeysQueueSize === void 0) { uniqueKeysQueueSize = DEFAULT_CACHE_SIZE; }
         this.uniqueTrackerSize = 0;
-        this.maxStorage = uniqueKeysQueueSize;
         this.uniqueKeysTracker = {};
+        this.maxStorage = uniqueKeysQueueSize;
     }
     UniqueKeysCacheInMemoryCS.prototype.setOnFullQueueCb = function (cb) {
         this.onFullQueue = cb;
@@ -27,7 +27,6 @@ var UniqueKeysCacheInMemoryCS = /** @class */ (function () {
             this.uniqueTrackerSize++;
         }
         if (this.uniqueTrackerSize >= this.maxStorage && this.onFullQueue) {
-            this.uniqueTrackerSize = 0;
             this.onFullQueue();
         }
     };
@@ -35,6 +34,7 @@ var UniqueKeysCacheInMemoryCS = /** @class */ (function () {
      * Clear the data stored on the cache.
      */
     UniqueKeysCacheInMemoryCS.prototype.clear = function () {
+        this.uniqueTrackerSize = 0;
         this.uniqueKeysTracker = {};
     };
     /**
@@ -42,7 +42,7 @@ var UniqueKeysCacheInMemoryCS = /** @class */ (function () {
      */
     UniqueKeysCacheInMemoryCS.prototype.pop = function () {
         var data = this.uniqueKeysTracker;
-        this.uniqueKeysTracker = {};
+        this.clear();
         return this.fromUniqueKeysCollector(data);
     };
     /**

package/esm/storages/inRedis/UniqueKeysCacheInRedis.js

@@ -21,21 +21,19 @@ var UniqueKeysCacheInRedis = /** @class */ (function (_super) {
         var featureNames = Object.keys(this.uniqueKeysTracker);
         if (!featureNames.length)
             return Promise.resolve(false);
-        var pipeline = this.redis.pipeline();
-        for (var i = 0; i < featureNames.length; i++) {
-            var featureName = featureNames[i];
-            var featureKeys = setToArray(this.uniqueKeysTracker[featureName]);
+        var uniqueKeysArray = featureNames.map(function (featureName) {
+            var featureKeys = setToArray(_this.uniqueKeysTracker[featureName]);
             var uniqueKeysPayload = {
                 f: featureName,
                 ks: featureKeys
             };
-            pipeline.rpush(this.key, JSON.stringify(uniqueKeysPayload));
-        }
+            return JSON.stringify(uniqueKeysPayload);
+        });
         this.clear();
-        return pipeline.exec()
+        return this.redis.rpush(this.key, uniqueKeysArray)
             .then(function (data) {
             // If this is the creation of the key on Redis, set the expiration for it in 3600 seconds.
-            if (data.length && data.length === featureNames.length) {
+            if (data === featureNames.length) {
                 return _this.redis.expire(_this.key, TTL_REFRESH);
             }
         })

package/esm/storages/pluggable/UniqueKeysCachePluggable.js

@@ -21,16 +21,17 @@ var UniqueKeysCachePluggable = /** @class */ (function (_super) {
         var featureNames = Object.keys(this.uniqueKeysTracker);
         if (!featureNames.length)
             return Promise.resolve(false);
-        var pipeline = featureNames.reduce(function (pipeline, featureName) {
+        var uniqueKeysArray = featureNames.map(function (featureName) {
             var featureKeys = setToArray(_this.uniqueKeysTracker[featureName]);
             var uniqueKeysPayload = {
                 f: featureName,
                 ks: featureKeys
             };
-            return pipeline.then(function () { return _this.wrapper.pushItems(_this.key, [JSON.stringify(uniqueKeysPayload)]); });
-        }, Promise.resolve());
+            return JSON.stringify(uniqueKeysPayload);
+        });
         this.clear();
-        return pipeline.catch(function (err) {
+        return this.wrapper.pushItems(this.key, uniqueKeysArray)
+            .catch(function (err) {
             _this.log.error(LOG_PREFIX + "Error in uniqueKeys pipeline: " + err + ".");
             return false;
         });

package/esm/utils/settingsValidation/index.js

@@ -45,7 +45,7 @@ export var base = {
     urls: {
         // CDN having all the information for your environment
         sdk: 'https://sdk.split.io/api',
-        // Storage for your SDK events
+        // SDK event and impression endpoints
         events: 'https://events.split.io/api',
         // SDK Auth Server
         auth: 'https://auth.split.io/api',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@splitsoftware/splitio-commons",
-  "version": "1.7.1",
+  "version": "1.7.3-rc.0",
   "description": "Split Javascript SDK common components",
   "main": "cjs/index.js",
   "module": "esm/index.js",

package/src/listeners/browser.ts

@@ -114,7 +114,7 @@ export class BrowserSignalListener implements ISignalListener {
     if (!cache.isEmpty()) {
       const dataPayload = fromCacheToPayload ? fromCacheToPayload(cache.pop()) : cache.pop();
       if (!this._sendBeacon(url, dataPayload, extraMetadata)) {
-        postService(JSON.stringify(dataPayload)).catch(() => { }); // no-op just to catch a possible exception
+        postService(JSON.stringify(dataPayload)).catch(() => { }); // no-op to handle possible promise rejection
       }
     }
   }
@@ -122,6 +122,7 @@ export class BrowserSignalListener implements ISignalListener {
   /**
    * _sendBeacon method.
    * Util method that check if beacon API is available, build the payload and send it.
+   * Returns true if beacon API was used successfully, false otherwise.
    */
   private _sendBeacon(url: string, data: any, extraMetadata?: {}) {
     // eslint-disable-next-line compat/compat
@@ -138,8 +139,12 @@ export class BrowserSignalListener implements ISignalListener {
       // Stringify the payload
       const payload = JSON.stringify(json);
 
-      // eslint-disable-next-line compat/compat
-      return navigator.sendBeacon(url, payload);
+      // https://xgwang.me/posts/you-may-not-know-beacon/#it-may-throw-error%2C-be-sure-to-catch
+      try { // eslint-disable-next-line compat/compat
+        return navigator.sendBeacon(url, payload);
+      } catch (e) {
+        return false;
+      }
     }
     return false;
   }

package/src/storages/inMemory/ImpressionCountsCacheInMemory.ts

@@ -30,7 +30,6 @@ export class ImpressionCountsCacheInMemory implements IImpressionCountsCacheSync
       this.cacheSize = this.cacheSize + amount;
       if (this.cacheSize >= this.maxStorage) {
         this.onFullQueue();
-        this.cacheSize = 0;
       }
     }
   }
@@ -58,6 +57,7 @@ export class ImpressionCountsCacheInMemory implements IImpressionCountsCacheSync
    */
   clear() {
     this.cache = {};
+    this.cacheSize = 0;
   }
 
   /**

package/src/storages/inMemory/InMemoryStorage.ts

@@ -4,7 +4,7 @@ import { ImpressionsCacheInMemory } from './ImpressionsCacheInMemory';
 import { EventsCacheInMemory } from './EventsCacheInMemory';
 import { IStorageFactoryParams, IStorageSync } from '../types';
 import { ImpressionCountsCacheInMemory } from './ImpressionCountsCacheInMemory';
-import { DEBUG, NONE, STORAGE_MEMORY } from '../../utils/constants';
+import { DEBUG, LOCALHOST_MODE, NONE, STORAGE_MEMORY } from '../../utils/constants';
 import { shouldRecordTelemetry, TelemetryCacheInMemory } from './TelemetryCacheInMemory';
 import { UniqueKeysCacheInMemory } from './UniqueKeysCacheInMemory';
 
@@ -19,7 +19,7 @@ export function InMemoryStorageFactory(params: IStorageFactoryParams): IStorageS
   const splits = new SplitsCacheInMemory();
   const segments = new SegmentsCacheInMemory();
 
-  return {
+  const storage = {
     splits,
     segments,
     impressions: new ImpressionsCacheInMemory(impressionsQueueSize),
@@ -35,9 +35,21 @@ export function InMemoryStorageFactory(params: IStorageFactoryParams): IStorageS
       this.impressions.clear();
       this.impressionCounts && this.impressionCounts.clear();
       this.events.clear();
-      this.uniqueKeys?.clear();
+      this.uniqueKeys && this.uniqueKeys.clear();
     }
   };
+
+  // @TODO revisit storage logic in localhost mode
+  // No tracking data in localhost mode to avoid memory leaks
+  if (params.settings.mode === LOCALHOST_MODE) {
+    const noopTrack = () => true;
+    storage.impressions.track = noopTrack;
+    storage.events.track = noopTrack;
+    if (storage.impressionCounts) storage.impressionCounts.track = noopTrack;
+    if (storage.uniqueKeys) storage.uniqueKeys.track = noopTrack;
+  }
+
+  return storage;
 }
 
 InMemoryStorageFactory.type = STORAGE_MEMORY;

package/src/storages/inMemory/InMemoryStorageCS.ts

@@ -4,7 +4,7 @@ import { ImpressionsCacheInMemory } from './ImpressionsCacheInMemory';
 import { EventsCacheInMemory } from './EventsCacheInMemory';
 import { IStorageSync, IStorageFactoryParams } from '../types';
 import { ImpressionCountsCacheInMemory } from './ImpressionCountsCacheInMemory';
-import { DEBUG, NONE, STORAGE_MEMORY } from '../../utils/constants';
+import { DEBUG, LOCALHOST_MODE, NONE, STORAGE_MEMORY } from '../../utils/constants';
 import { shouldRecordTelemetry, TelemetryCacheInMemory } from './TelemetryCacheInMemory';
 import { UniqueKeysCacheInMemoryCS } from './UniqueKeysCacheInMemoryCS';
 
@@ -19,7 +19,7 @@ export function InMemoryStorageCSFactory(params: IStorageFactoryParams): IStorag
   const splits = new SplitsCacheInMemory();
   const segments = new MySegmentsCacheInMemory();
 
-  return {
+  const storage = {
     splits,
     segments,
     impressions: new ImpressionsCacheInMemory(impressionsQueueSize),
@@ -35,7 +35,7 @@ export function InMemoryStorageCSFactory(params: IStorageFactoryParams): IStorag
       this.impressions.clear();
       this.impressionCounts && this.impressionCounts.clear();
       this.events.clear();
-      this.uniqueKeys?.clear();
+      this.uniqueKeys && this.uniqueKeys.clear();
     },
 
     // When using shared instanciation with MEMORY we reuse everything but segments (they are unique per key)
@@ -56,6 +56,18 @@ export function InMemoryStorageCSFactory(params: IStorageFactoryParams): IStorag
       };
     },
   };
+
+  // @TODO revisit storage logic in localhost mode
+  // No tracking data in localhost mode to avoid memory leaks
+  if (params.settings.mode === LOCALHOST_MODE) {
+    const noopTrack = () => true;
+    storage.impressions.track = noopTrack;
+    storage.events.track = noopTrack;
+    if (storage.impressionCounts) storage.impressionCounts.track = noopTrack;
+    if (storage.uniqueKeys) storage.uniqueKeys.track = noopTrack;
+  }
+
+  return storage;
 }
 
 InMemoryStorageCSFactory.type = STORAGE_MEMORY;

package/src/storages/inMemory/UniqueKeysCacheInMemory.ts

@@ -27,11 +27,10 @@ export class UniqueKeysCacheInMemory implements IUniqueKeysCacheBase {
   protected onFullQueue?: () => void;
   private readonly maxStorage: number;
   private uniqueTrackerSize = 0;
-  protected uniqueKeysTracker: { [featureName: string]: ISet<string> };
+  protected uniqueKeysTracker: { [featureName: string]: ISet<string> } = {};
 
   constructor(uniqueKeysQueueSize = DEFAULT_CACHE_SIZE) {
     this.maxStorage = uniqueKeysQueueSize;
-    this.uniqueKeysTracker = {};
   }
 
   setOnFullQueueCb(cb: () => void) {
@@ -49,7 +48,6 @@ export class UniqueKeysCacheInMemory implements IUniqueKeysCacheBase {
       this.uniqueTrackerSize++;
     }
     if (this.uniqueTrackerSize >= this.maxStorage && this.onFullQueue) {
-      this.uniqueTrackerSize = 0;
       this.onFullQueue();
     }
   }
@@ -58,6 +56,7 @@ export class UniqueKeysCacheInMemory implements IUniqueKeysCacheBase {
    * Clear the data stored on the cache.
    */
   clear() {
+    this.uniqueTrackerSize = 0;
     this.uniqueKeysTracker = {};
   }
 
@@ -66,7 +65,7 @@ export class UniqueKeysCacheInMemory implements IUniqueKeysCacheBase {
    */
   pop() {
     const data = this.uniqueKeysTracker;
-    this.uniqueKeysTracker = {};
+    this.clear();
     return fromUniqueKeysCollector(data);
   }
 

package/src/storages/inMemory/UniqueKeysCacheInMemoryCS.ts

@@ -8,7 +8,7 @@ export class UniqueKeysCacheInMemoryCS implements IUniqueKeysCacheBase {
   private onFullQueue?: () => void;
   private readonly maxStorage: number;
   private uniqueTrackerSize = 0;
-  private uniqueKeysTracker: { [userKey: string]: ISet<string> };
+  private uniqueKeysTracker: { [userKey: string]: ISet<string> } = {};
 
   /**
    *
@@ -17,7 +17,6 @@ export class UniqueKeysCacheInMemoryCS implements IUniqueKeysCacheBase {
    */
   constructor(uniqueKeysQueueSize = DEFAULT_CACHE_SIZE) {
     this.maxStorage = uniqueKeysQueueSize;
-    this.uniqueKeysTracker = {};
   }
 
   setOnFullQueueCb(cb: () => void) {
@@ -36,7 +35,6 @@ export class UniqueKeysCacheInMemoryCS implements IUniqueKeysCacheBase {
       this.uniqueTrackerSize++;
     }
     if (this.uniqueTrackerSize >= this.maxStorage && this.onFullQueue) {
-      this.uniqueTrackerSize = 0;
       this.onFullQueue();
     }
   }
@@ -45,6 +43,7 @@ export class UniqueKeysCacheInMemoryCS implements IUniqueKeysCacheBase {
    * Clear the data stored on the cache.
    */
   clear() {
+    this.uniqueTrackerSize = 0;
     this.uniqueKeysTracker = {};
   }
 
@@ -53,7 +52,7 @@ export class UniqueKeysCacheInMemoryCS implements IUniqueKeysCacheBase {
    */
   pop() {
     const data = this.uniqueKeysTracker;
-    this.uniqueKeysTracker = {};
+    this.clear();
     return this.fromUniqueKeysCollector(data);
   }
 

package/src/storages/inRedis/UniqueKeysCacheInRedis.ts

@@ -28,22 +28,20 @@ export class UniqueKeysCacheInRedis extends UniqueKeysCacheInMemory implements I
     const featureNames = Object.keys(this.uniqueKeysTracker);
     if (!featureNames.length) return Promise.resolve(false);
 
-    const pipeline = this.redis.pipeline();
-    for (let i = 0; i < featureNames.length; i++) {
-      const featureName = featureNames[i];
+    const uniqueKeysArray = featureNames.map((featureName) => {
       const featureKeys = setToArray(this.uniqueKeysTracker[featureName]);
       const uniqueKeysPayload = {
         f: featureName,
         ks: featureKeys
       };
+      return JSON.stringify(uniqueKeysPayload);
+    });
 
-      pipeline.rpush(this.key, JSON.stringify(uniqueKeysPayload));
-    }
     this.clear();
-    return pipeline.exec()
+    return this.redis.rpush(this.key, uniqueKeysArray)
       .then(data => {
         // If this is the creation of the key on Redis, set the expiration for it in 3600 seconds.
-        if (data.length && data.length === featureNames.length) {
+        if (data === featureNames.length) {
           return this.redis.expire(this.key, TTL_REFRESH);
         }
       })

package/src/storages/pluggable/UniqueKeysCachePluggable.ts

@@ -27,21 +27,21 @@ export class UniqueKeysCachePluggable extends UniqueKeysCacheInMemory implements
     const featureNames = Object.keys(this.uniqueKeysTracker);
     if (!featureNames.length) return Promise.resolve(false);
 
-    const pipeline = featureNames.reduce<Promise<any>>((pipeline, featureName) => {
+    const uniqueKeysArray = featureNames.map((featureName) => {
       const featureKeys = setToArray(this.uniqueKeysTracker[featureName]);
       const uniqueKeysPayload = {
         f: featureName,
         ks: featureKeys
       };
-
-      return pipeline.then(() => this.wrapper.pushItems(this.key, [JSON.stringify(uniqueKeysPayload)]));
-    }, Promise.resolve());
+      return JSON.stringify(uniqueKeysPayload);
+    });
 
     this.clear();
-    return pipeline.catch(err => {
-      this.log.error(`${LOG_PREFIX}Error in uniqueKeys pipeline: ${err}.`);
-      return false;
-    });
+    return this.wrapper.pushItems(this.key, uniqueKeysArray)
+      .catch(err => {
+        this.log.error(`${LOG_PREFIX}Error in uniqueKeys pipeline: ${err}.`);
+        return false;
+      });
   }
 
 

package/src/utils/settingsValidation/index.ts

@@ -51,7 +51,7 @@ export const base = {
   urls: {
     // CDN having all the information for your environment
     sdk: 'https://sdk.split.io/api',
-    // Storage for your SDK events
+    // SDK event and impression endpoints
     events: 'https://events.split.io/api',
     // SDK Auth Server
     auth: 'https://auth.split.io/api',

package/types/listeners/browser.d.ts

@@ -35,6 +35,7 @@ export declare class BrowserSignalListener implements ISignalListener {
     /**
      * _sendBeacon method.
      * Util method that check if beacon API is available, build the payload and send it.
+     * Returns true if beacon API was used successfully, false otherwise.
      */
     private _sendBeacon;
 }

package/types/storages/pluggable/UniqueKeysCachePluggable.d.ts

@@ -9,9 +9,9 @@ export declare class UniqueKeysCachePluggable extends UniqueKeysCacheInMemory im
     private readonly refreshRate;
     private intervalId;
     constructor(log: ILogger, key: string, wrapper: IPluggableStorageWrapper, uniqueKeysQueueSize?: number, refreshRate?: number);
-    storeUniqueKeys(): Promise<any>;
+    storeUniqueKeys(): Promise<boolean | void>;
     start(): void;
-    stop(): Promise<any>;
+    stop(): Promise<boolean | void>;
     /**
      * Async consumer API, used by synchronizer.
      * @param count number of items to pop from the queue. If not provided or equal 0, all items will be popped.