@splitsoftware/splitio-commons 1.6.2-rc.5 → 1.6.2-rc.8

package/CHANGES.txt

@@ -1,3 +1,6 @@
+1.6.2 (September XXX, 2022)
+- Updated storage implementations to improve the performance of split evaluations (i.e., `getTreatment(s)` method calls) when using the default storage in memory.
+
 1.6.1 (July 22, 2022)
 - Updated GoogleAnalyticsToSplit integration to validate `autoRequire` config parameter and avoid some wrong warning logs when mapping GA hit fields to Split event properties.
 

package/cjs/evaluator/index.js

@@ -37,45 +37,44 @@ function evaluateFeature(log, key, splitName, attributes, storage) {
 }
 exports.evaluateFeature = evaluateFeature;
 function evaluateFeatures(log, key, splitNames, attributes, storage) {
-    var stringifiedSplits;
+    var parsedSplits;
     try {
-        stringifiedSplits = storage.splits.getSplits(splitNames);
+        parsedSplits = storage.splits.getSplits(splitNames);
     }
     catch (e) {
         // Exception on sync `getSplits` storage. Not possible ATM with InMemory and InLocal storages.
         return treatmentsException(splitNames);
     }
-    return ((0, thenable_1.thenable)(stringifiedSplits)) ?
-        stringifiedSplits.then(function (splits) { return getEvaluations(log, splitNames, splits, key, attributes, storage); })
+    return (0, thenable_1.thenable)(parsedSplits) ?
+        parsedSplits.then(function (splits) { return getEvaluations(log, splitNames, splits, key, attributes, storage); })
             .catch(function () {
             // Exception on async `getSplits` storage. For example, when the storage is redis or
             // pluggable and there is a connection issue and we can't retrieve the split to be evaluated
             return treatmentsException(splitNames);
         }) :
-        getEvaluations(log, splitNames, stringifiedSplits, key, attributes, storage);
+        getEvaluations(log, splitNames, parsedSplits, key, attributes, storage);
 }
 exports.evaluateFeatures = evaluateFeatures;
-function getEvaluation(log, stringifiedSplit, key, attributes, storage) {
+function getEvaluation(log, splitJSON, key, attributes, storage) {
     var evaluation = {
         treatment: constants_1.CONTROL,
         label: LabelsConstants.SPLIT_NOT_FOUND,
         config: null
     };
-    if (stringifiedSplit) {
-        var splitJSON_1 = JSON.parse(stringifiedSplit);
-        var split_1 = Engine_1.Engine.parse(log, splitJSON_1, storage);
+    if (splitJSON) {
+        var split_1 = Engine_1.Engine.parse(log, splitJSON, storage);
         evaluation = split_1.getTreatment(key, attributes, evaluateFeature);
         // If the storage is async and the evaluated split uses segment, evaluation is thenable
         if ((0, thenable_1.thenable)(evaluation)) {
             return evaluation.then(function (result) {
                 result.changeNumber = split_1.getChangeNumber();
-                result.config = splitJSON_1.configurations && splitJSON_1.configurations[result.treatment] || null;
+                result.config = splitJSON.configurations && splitJSON.configurations[result.treatment] || null;
                 return result;
             });
         }
         else {
             evaluation.changeNumber = split_1.getChangeNumber(); // Always sync and optional
-            evaluation.config = splitJSON_1.configurations && splitJSON_1.configurations[evaluation.treatment] || null;
+            evaluation.config = splitJSON.configurations && splitJSON.configurations[evaluation.treatment] || null;
         }
     }
     return evaluation;

package/cjs/integrations/ga/GaToSplit.js

@@ -16,7 +16,7 @@ var logNameMapper = 'ga-to-split:mapper';
  * @param log Logger instance.
  * @param autoRequire If true, log error when auto-require script is not detected
  */
-function providePlugin(window, pluginName, pluginConstructor, log, autoRequire) {
+function providePlugin(window, pluginName, pluginConstructor, log, autoRequire, telemetryTracker) {
     // get reference to global command queue. Init it if not defined yet.
     var gaAlias = window.GoogleAnalyticsObject || 'ga';
     window[gaAlias] = window[gaAlias] || function () {
@@ -24,10 +24,13 @@ function providePlugin(window, pluginName, pluginConstructor, log, autoRequire)
     };
     // provides the plugin for use with analytics.js.
     window[gaAlias]('provide', pluginName, pluginConstructor);
-    if (autoRequire && (!window[gaAlias].q || window[gaAlias].q.push === [].push)) {
-        // Expecting spy on ga.q push method but not found
+    var hasAutoRequire = window[gaAlias].q && window[gaAlias].q.push !== [].push;
+    if (autoRequire && !hasAutoRequire) { // Expecting spy on ga.q push method but not found
         log.error(logPrefix + 'integration is configured to autorequire the splitTracker plugin, but the necessary script does not seem to have run. Please check the docs.');
     }
+    if (telemetryTracker && hasAutoRequire) {
+        telemetryTracker.addTag('integration:ga-autorequire');
+    }
 }
 // Default mapping: object used for building the default mapper from hits to Split events
 var defaultMapping = {
@@ -163,7 +166,7 @@ exports.fixEventTypeId = fixEventTypeId;
  * @param {object} log factory logger
  */
 function GaToSplit(sdkOptions, params) {
-    var storage = params.storage, _a = params.settings, coreSettings = _a.core, log = _a.log;
+    var storage = params.storage, _a = params.settings, coreSettings = _a.core, log = _a.log, telemetryTracker = params.telemetryTracker;
     var defaultOptions = {
         prefix: exports.defaultPrefix,
         // We set default identities if key and TT are present in settings.core
@@ -249,6 +252,6 @@ function GaToSplit(sdkOptions, params) {
         return SplitTracker;
     }());
     // Register the plugin, even if config is invalid, since, if not provided, it will block `ga` command queue.
-    providePlugin(window, 'splitTracker', SplitTracker, log, sdkOptions.autoRequire === true);
+    providePlugin(window, 'splitTracker', SplitTracker, log, sdkOptions.autoRequire === true, telemetryTracker);
 }
 exports.GaToSplit = GaToSplit;

package/cjs/sdkClient/sdkClient.js

@@ -9,7 +9,7 @@ var clientInputValidation_1 = require("./clientInputValidation");
  * Creates an Sdk client, i.e., a base client with status and destroy interface
  */
 function sdkClientFactory(params, isSharedClient) {
-    var sdkReadinessManager = params.sdkReadinessManager, syncManager = params.syncManager, storage = params.storage, signalListener = params.signalListener, settings = params.settings, telemetryTracker = params.telemetryTracker;
+    var sdkReadinessManager = params.sdkReadinessManager, syncManager = params.syncManager, storage = params.storage, signalListener = params.signalListener, settings = params.settings, telemetryTracker = params.telemetryTracker, uniqueKeysTracker = params.uniqueKeysTracker;
     return (0, objectAssign_1.objectAssign)(
     // Proto-linkage of the readiness Event Emitter
     Object.create(sdkReadinessManager.sdkStatus), 
@@ -31,6 +31,8 @@ function sdkClientFactory(params, isSharedClient) {
                 // Release the API Key if it is the main client
                 if (!isSharedClient)
                     (0, apiKey_1.releaseApiKey)(settings.core.authorizationKey);
+                if (uniqueKeysTracker)
+                    uniqueKeysTracker.stop();
                 // Cleanup storage
                 return storage.destroy();
             });

package/cjs/sdkFactory/index.js

@@ -55,7 +55,8 @@ function sdkFactory(params) {
     };
     var storage = storageFactory(storageFactoryParams);
     // @TODO add support for dataloader: `if (params.dataLoader) params.dataLoader(storage);`
-    var integrationsManager = integrationsManagerFactory && integrationsManagerFactory({ settings: settings, storage: storage });
+    var telemetryTracker = (0, telemetryTracker_1.telemetryTrackerFactory)(storage.telemetry, platform.now);
+    var integrationsManager = integrationsManagerFactory && integrationsManagerFactory({ settings: settings, storage: storage, telemetryTracker: telemetryTracker });
     var observer = impressionsObserverFactory();
     var uniqueKeysTracker = storageFactoryParams.impressionsMode === constants_3.NONE ? (0, uniqueKeysTracker_1.uniqueKeysTrackerFactory)(log, storage.uniqueKeys, filterAdapterFactory && filterAdapterFactory()) : undefined;
     var strategy;
@@ -71,7 +72,6 @@ function sdkFactory(params) {
     }
     var impressionsTracker = (0, impressionsTracker_1.impressionsTrackerFactory)(settings, storage.impressions, strategy, integrationsManager, storage.telemetry);
     var eventTracker = (0, eventTracker_1.eventTrackerFactory)(settings, storage.events, integrationsManager, storage.telemetry);
-    var telemetryTracker = (0, telemetryTracker_1.telemetryTrackerFactory)(storage.telemetry, platform.now);
     // splitApi is used by SyncManager and Browser signal listener
     var splitApi = splitApiFactory && splitApiFactory(settings, platform, telemetryTracker);
     var ctx = { splitApi: splitApi, eventTracker: eventTracker, impressionsTracker: impressionsTracker, telemetryTracker: telemetryTracker, uniqueKeysTracker: uniqueKeysTracker, sdkReadinessManager: sdkReadinessManager, readiness: readiness, settings: settings, storage: storage, platform: platform };

package/cjs/sdkManager/index.js

@@ -15,15 +15,7 @@ function collectTreatments(splitObject) {
     // Then extract the treatments from the partitions
     return allTreatmentsCondition ? allTreatmentsCondition.partitions.map(function (v) { return v.treatment; }) : [];
 }
-function objectToView(json) {
-    var splitObject;
-    try {
-        // @ts-expect-error
-        splitObject = JSON.parse(json);
-    }
-    catch (e) {
-        return null;
-    }
+function objectToView(splitObject) {
     if (!splitObject)
         return null;
     return {
@@ -35,9 +27,9 @@ function objectToView(json) {
         configs: splitObject.configurations || {}
     };
 }
-function objectsToViews(jsons) {
+function objectsToViews(splitObjects) {
     var views = [];
-    jsons.forEach(function (split) {
+    splitObjects.forEach(function (split) {
         var view = objectToView(split);
         if (view)
             views.push(view);

package/cjs/storages/AbstractSplitsCacheAsync.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.AbstractSplitsCacheAsync = void 0;
+var objectAssign_1 = require("../utils/lang/objectAssign");
 /**
  * This class provides a skeletal implementation of the ISplitsCacheAsync interface
  * to minimize the effort required to implement this interface.
@@ -34,15 +35,12 @@ var AbstractSplitsCacheAsync = /** @class */ (function () {
     AbstractSplitsCacheAsync.prototype.killLocally = function (name, defaultTreatment, changeNumber) {
         var _this = this;
         return this.getSplit(name).then(function (split) {
-            if (split) {
-                var parsedSplit = JSON.parse(split);
-                if (!parsedSplit.changeNumber || parsedSplit.changeNumber < changeNumber) {
-                    parsedSplit.killed = true;
-                    parsedSplit.defaultTreatment = defaultTreatment;
-                    parsedSplit.changeNumber = changeNumber;
-                    var newSplit = JSON.stringify(parsedSplit);
-                    return _this.addSplit(name, newSplit);
-                }
+            if (split && (!split.changeNumber || split.changeNumber < changeNumber)) {
+                var newSplit = (0, objectAssign_1.objectAssign)({}, split);
+                newSplit.killed = true;
+                newSplit.defaultTreatment = defaultTreatment;
+                newSplit.changeNumber = changeNumber;
+                return _this.addSplit(name, newSplit);
             }
             return false;
         }).catch(function () { return false; });

package/cjs/storages/AbstractSplitsCacheSync.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.usesSegments = exports.AbstractSplitsCacheSync = void 0;
+var objectAssign_1 = require("../utils/lang/objectAssign");
 /**
  * This class provides a skeletal implementation of the ISplitsCacheSync interface
  * to minimize the effort required to implement this interface.
@@ -47,15 +48,12 @@ var AbstractSplitsCacheSync = /** @class */ (function () {
      */
     AbstractSplitsCacheSync.prototype.killLocally = function (name, defaultTreatment, changeNumber) {
         var split = this.getSplit(name);
-        if (split) {
-            var parsedSplit = JSON.parse(split);
-            if (!parsedSplit.changeNumber || parsedSplit.changeNumber < changeNumber) {
-                parsedSplit.killed = true;
-                parsedSplit.defaultTreatment = defaultTreatment;
-                parsedSplit.changeNumber = changeNumber;
-                var newSplit = JSON.stringify(parsedSplit);
-                return this.addSplit(name, newSplit);
-            }
+        if (split && (!split.changeNumber || split.changeNumber < changeNumber)) {
+            var newSplit = (0, objectAssign_1.objectAssign)({}, split);
+            newSplit.killed = true;
+            newSplit.defaultTreatment = defaultTreatment;
+            newSplit.changeNumber = changeNumber;
+            return this.addSplit(name, newSplit);
         }
         return false;
     };

package/cjs/storages/dataLoader.js

@@ -35,7 +35,7 @@ function dataLoaderFactory(preloadedData) {
         storage.splits.clear();
         storage.splits.setChangeNumber(since);
         // splitsData in an object where the property is the split name and the pertaining value is a stringified json of its data
-        storage.splits.addSplits(Object.keys(splitsData).map(function (splitName) { return [splitName, splitsData[splitName]]; }));
+        storage.splits.addSplits(Object.keys(splitsData).map(function (splitName) { return JSON.parse(splitsData[splitName]); }));
         // add mySegments data
         var mySegmentsData = preloadedData.mySegmentsData && preloadedData.mySegmentsData[userId];
         if (!mySegmentsData) {

package/cjs/storages/inLocalStorage/SplitsCacheInLocal.js

@@ -96,9 +96,8 @@ var SplitsCacheInLocal = /** @class */ (function (_super) {
             var splitFromLocalStorage = localStorage.getItem(splitKey);
             var previousSplit = splitFromLocalStorage ? JSON.parse(splitFromLocalStorage) : null;
             this._decrementCounts(previousSplit);
-            localStorage.setItem(splitKey, split);
-            var parsedSplit = split ? JSON.parse(split) : null;
-            this._incrementCounts(parsedSplit);
+            localStorage.setItem(splitKey, JSON.stringify(split));
+            this._incrementCounts(split);
             return true;
         }
         catch (e) {
@@ -110,8 +109,7 @@ var SplitsCacheInLocal = /** @class */ (function (_super) {
         try {
             var split = this.getSplit(name);
             localStorage.removeItem(this.keys.buildSplitKey(name));
-            var parsedSplit = JSON.parse(split);
-            this._decrementCounts(parsedSplit);
+            this._decrementCounts(split);
             return true;
         }
         catch (e) {
@@ -120,7 +118,8 @@ var SplitsCacheInLocal = /** @class */ (function (_super) {
         }
     };
     SplitsCacheInLocal.prototype.getSplit = function (name) {
-        return localStorage.getItem(this.keys.buildSplitKey(name));
+        var item = localStorage.getItem(this.keys.buildSplitKey(name));
+        return item && JSON.parse(item);
     };
     SplitsCacheInLocal.prototype.setChangeNumber = function (changeNumber) {
         // when cache is ready but using a new split query, we must clear all split data

package/cjs/storages/inMemory/SplitsCacheInMemory.js

@@ -25,9 +25,8 @@ var SplitsCacheInMemory = /** @class */ (function (_super) {
         this.splitsWithSegmentsCount = 0;
     };
     SplitsCacheInMemory.prototype.addSplit = function (name, split) {
-        var splitFromMemory = this.getSplit(name);
-        if (splitFromMemory) { // We had this Split already
-            var previousSplit = JSON.parse(splitFromMemory);
+        var previousSplit = this.getSplit(name);
+        if (previousSplit) { // We had this Split already
             if (previousSplit.trafficTypeName) {
                 var previousTtName = previousSplit.trafficTypeName;
                 this.ttCache[previousTtName]--;
@@ -38,19 +37,18 @@ var SplitsCacheInMemory = /** @class */ (function (_super) {
                 this.splitsWithSegmentsCount--;
             }
         }
-        var parsedSplit = JSON.parse(split);
-        if (parsedSplit) {
+        if (split) {
             // Store the Split.
             this.splitsCache[name] = split;
             // Update TT cache
-            var ttName = parsedSplit.trafficTypeName;
+            var ttName = split.trafficTypeName;
             if (ttName) { // safeguard
                 if (!this.ttCache[ttName])
                     this.ttCache[ttName] = 0;
                 this.ttCache[ttName]++;
             }
             // Add to segments count for the new version of the Split
-            if ((0, AbstractSplitsCacheSync_1.usesSegments)(parsedSplit))
+            if ((0, AbstractSplitsCacheSync_1.usesSegments)(split))
                 this.splitsWithSegmentsCount++;
             return true;
         }
@@ -63,15 +61,14 @@ var SplitsCacheInMemory = /** @class */ (function (_super) {
         if (split) {
             // Delete the Split
             delete this.splitsCache[name];
-            var parsedSplit = JSON.parse(split);
-            var ttName = parsedSplit.trafficTypeName;
+            var ttName = split.trafficTypeName;
             if (ttName) { // safeguard
                 this.ttCache[ttName]--; // Update tt cache
                 if (!this.ttCache[ttName])
                     delete this.ttCache[ttName];
             }
             // Update the segments count.
-            if ((0, AbstractSplitsCacheSync_1.usesSegments)(parsedSplit))
+            if ((0, AbstractSplitsCacheSync_1.usesSegments)(split))
                 this.splitsWithSegmentsCount--;
             return true;
         }

package/cjs/storages/inRedis/ImpressionCountsCacheInRedis.js

@@ -6,11 +6,13 @@ var ImpressionCountsCacheInMemory_1 = require("../inMemory/ImpressionCountsCache
 var constants_1 = require("./constants");
 var ImpressionCountsCacheInRedis = /** @class */ (function (_super) {
     (0, tslib_1.__extends)(ImpressionCountsCacheInRedis, _super);
-    function ImpressionCountsCacheInRedis(log, key, redis, impressionCountsCacheSize) {
+    function ImpressionCountsCacheInRedis(log, key, redis, impressionCountsCacheSize, refreshRate) {
+        if (refreshRate === void 0) { refreshRate = constants_1.REFRESH_RATE; }
         var _this = _super.call(this, impressionCountsCacheSize) || this;
         _this.log = log;
         _this.key = key;
         _this.redis = redis;
+        _this.refreshRate = refreshRate;
         _this.onFullQueue = function () { _this.postImpressionCountsInRedis(); };
         return _this;
     }
@@ -18,6 +20,8 @@ var ImpressionCountsCacheInRedis = /** @class */ (function (_super) {
         var _this = this;
         var counts = this.pop();
         var keys = Object.keys(counts);
+        if (!keys)
+            return Promise.resolve(false);
         var pipeline = this.redis.pipeline();
         keys.forEach(function (key) {
             pipeline.hincrby(_this.key, key, counts[key]);
@@ -31,15 +35,15 @@ var ImpressionCountsCacheInRedis = /** @class */ (function (_super) {
         })
             .catch(function (err) {
             _this.log.error(constants_1.LOG_PREFIX + "Error in impression counts pipeline: " + err + ".");
-            return false;
+            return Promise.resolve(false);
         });
     };
-    ImpressionCountsCacheInRedis.prototype.start = function (refreshRate) {
-        if (refreshRate === void 0) { refreshRate = constants_1.REFRESH_RATE; }
-        this.handle = setInterval(this.postImpressionCountsInRedis.bind(this), refreshRate);
+    ImpressionCountsCacheInRedis.prototype.start = function () {
+        this.intervalId = setInterval(this.postImpressionCountsInRedis.bind(this), this.refreshRate);
     };
     ImpressionCountsCacheInRedis.prototype.stop = function () {
-        clearInterval(this.handle);
+        clearInterval(this.intervalId);
+        return this.postImpressionCountsInRedis();
     };
     return ImpressionCountsCacheInRedis;
 }(ImpressionCountsCacheInMemory_1.ImpressionCountsCacheInMemory));

package/cjs/storages/inRedis/SplitsCacheInRedis.js

@@ -62,17 +62,17 @@ var SplitsCacheInRedis = /** @class */ (function (_super) {
         var splitKey = this.keys.buildSplitKey(name);
         return this.redis.get(splitKey).then(function (splitFromStorage) {
             // handling parsing errors
-            var parsedPreviousSplit, parsedSplit;
+            var parsedPreviousSplit, newStringifiedSplit;
             try {
                 parsedPreviousSplit = splitFromStorage ? JSON.parse(splitFromStorage) : undefined;
-                parsedSplit = JSON.parse(split);
+                newStringifiedSplit = JSON.stringify(split);
             }
             catch (e) {
                 throw new Error('Error parsing split definition: ' + e);
             }
             return Promise.all([
-                _this.redis.set(splitKey, split),
-                _this._incrementCounts(parsedSplit),
+                _this.redis.set(splitKey, newStringifiedSplit),
+                _this._incrementCounts(split),
                 // If it's an update, we decrement the traffic type of the existing split,
                 parsedPreviousSplit && _this._decrementCounts(parsedPreviousSplit)
             ]);
@@ -99,8 +99,7 @@ var SplitsCacheInRedis = /** @class */ (function (_super) {
         var _this = this;
         return this.getSplit(name).then(function (split) {
             if (split) {
-                var parsedSplit = JSON.parse(split);
-                _this._decrementCounts(parsedSplit);
+                _this._decrementCounts(split);
             }
             return _this.redis.del(_this.keys.buildSplitKey(name));
         });
@@ -123,7 +122,8 @@ var SplitsCacheInRedis = /** @class */ (function (_super) {
             this.log.error(constants_1.LOG_PREFIX + this.redisError);
             return Promise.reject(this.redisError);
         }
-        return this.redis.get(this.keys.buildSplitKey(name));
+        return this.redis.get(this.keys.buildSplitKey(name))
+            .then(function (maybeSplit) { return maybeSplit && JSON.parse(maybeSplit); });
     };
     /**
      * Set till number.
@@ -158,7 +158,12 @@ var SplitsCacheInRedis = /** @class */ (function (_super) {
      */
     SplitsCacheInRedis.prototype.getAll = function () {
         var _this = this;
-        return this.redis.keys(this.keys.searchPatternForSplitKeys()).then(function (listOfKeys) { return _this.redis.pipeline(listOfKeys.map(function (k) { return ['get', k]; })).exec(); }).then(processPipelineAnswer);
+        return this.redis.keys(this.keys.searchPatternForSplitKeys())
+            .then(function (listOfKeys) { return _this.redis.pipeline(listOfKeys.map(function (k) { return ['get', k]; })).exec(); })
+            .then(processPipelineAnswer)
+            .then(function (splitDefinitions) { return splitDefinitions.map(function (splitDefinition) {
+            return JSON.parse(splitDefinition);
+        }); });
     };
     /**
      * Get list of split names.
@@ -218,7 +223,8 @@ var SplitsCacheInRedis = /** @class */ (function (_super) {
         var keys = names.map(function (name) { return _this.keys.buildSplitKey(name); });
         return (_a = this.redis).mget.apply(_a, keys).then(function (splitDefinitions) {
             names.forEach(function (name, idx) {
-                splits[name] = splitDefinitions[idx];
+                var split = splitDefinitions[idx];
+                splits[name] = split && JSON.parse(split);
             });
             return Promise.resolve(splits);
         })

package/cjs/storages/inRedis/index.js

@@ -47,11 +47,12 @@ function InRedisStorage(options) {
             // When using REDIS we should:
             // 1- Disconnect from the storage
             destroy: function () {
-                redisClient.disconnect();
+                var promises = [];
                 if (impressionCountsCache)
-                    impressionCountsCache.stop();
+                    promises.push(impressionCountsCache.stop());
                 if (uniqueKeysCache)
-                    uniqueKeysCache.stop();
+                    promises.push(uniqueKeysCache.stop());
+                return Promise.all(promises).then(function () { redisClient.disconnect(); });
                 // @TODO check that caches works as expected when redisClient is disconnected
             }
         };

package/cjs/storages/inRedis/uniqueKeysCacheInRedis.js

@@ -8,19 +8,23 @@ var constants_1 = require("./constants");
 var constants_2 = require("./constants");
 var UniqueKeysCacheInRedis = /** @class */ (function (_super) {
     (0, tslib_1.__extends)(UniqueKeysCacheInRedis, _super);
-    function UniqueKeysCacheInRedis(log, key, redis, uniqueKeysQueueSize) {
+    function UniqueKeysCacheInRedis(log, key, redis, uniqueKeysQueueSize, refreshRate) {
         if (uniqueKeysQueueSize === void 0) { uniqueKeysQueueSize = constants_1.DEFAULT_CACHE_SIZE; }
+        if (refreshRate === void 0) { refreshRate = constants_1.REFRESH_RATE; }
         var _this = _super.call(this, uniqueKeysQueueSize) || this;
         _this.log = log;
         _this.key = key;
         _this.redis = redis;
+        _this.refreshRate = refreshRate;
         _this.onFullQueue = function () { _this.postUniqueKeysInRedis(); };
         return _this;
     }
     UniqueKeysCacheInRedis.prototype.postUniqueKeysInRedis = function () {
         var _this = this;
-        var pipeline = this.redis.pipeline();
         var featureNames = Object.keys(this.uniqueKeysTracker);
+        if (!featureNames)
+            return Promise.resolve(false);
+        var pipeline = this.redis.pipeline();
         for (var i = 0; i < featureNames.length; i++) {
             var featureName = featureNames[i];
             var featureKeys = (0, sets_1.setToArray)(this.uniqueKeysTracker[featureName]);
@@ -40,15 +44,15 @@ var UniqueKeysCacheInRedis = /** @class */ (function (_super) {
         })
             .catch(function (err) {
             _this.log.error(constants_2.LOG_PREFIX + "Error in uniqueKeys pipeline: " + err + ".");
-            return false;
+            return Promise.resolve(false);
         });
     };
-    UniqueKeysCacheInRedis.prototype.start = function (refreshRate) {
-        if (refreshRate === void 0) { refreshRate = constants_1.REFRESH_RATE; }
-        this.handle = setInterval(this.postUniqueKeysInRedis.bind(this), refreshRate);
+    UniqueKeysCacheInRedis.prototype.start = function () {
+        this.intervalId = setInterval(this.postUniqueKeysInRedis.bind(this), this.refreshRate);
     };
     UniqueKeysCacheInRedis.prototype.stop = function () {
-        clearInterval(this.handle);
+        clearInterval(this.intervalId);
+        return this.postUniqueKeysInRedis();
     };
     return UniqueKeysCacheInRedis;
 }(uniqueKeysCacheInMemory_1.UniqueKeysCacheInMemory));

package/cjs/storages/pluggable/SplitsCachePluggable.js

@@ -49,17 +49,17 @@ var SplitsCachePluggable = /** @class */ (function (_super) {
         var splitKey = this.keys.buildSplitKey(name);
         return this.wrapper.get(splitKey).then(function (splitFromStorage) {
             // handling parsing error
-            var parsedPreviousSplit, parsedSplit;
+            var parsedPreviousSplit, stringifiedNewSplit;
             try {
                 parsedPreviousSplit = splitFromStorage ? JSON.parse(splitFromStorage) : undefined;
-                parsedSplit = JSON.parse(split);
+                stringifiedNewSplit = JSON.stringify(split);
             }
             catch (e) {
                 throw new Error('Error parsing split definition: ' + e);
             }
             return Promise.all([
-                _this.wrapper.set(splitKey, split),
-                _this._incrementCounts(parsedSplit),
+                _this.wrapper.set(splitKey, stringifiedNewSplit),
+                _this._incrementCounts(split),
                 // If it's an update, we decrement the traffic type and segment count of the existing split,
                 parsedPreviousSplit && _this._decrementCounts(parsedPreviousSplit)
             ]);
@@ -83,8 +83,7 @@ var SplitsCachePluggable = /** @class */ (function (_super) {
         var _this = this;
         return this.getSplit(name).then(function (split) {
             if (split) {
-                var parsedSplit = JSON.parse(split);
-                _this._decrementCounts(parsedSplit);
+                _this._decrementCounts(split);
             }
             return _this.wrapper.del(_this.keys.buildSplitKey(name));
         });
@@ -104,7 +103,8 @@ var SplitsCachePluggable = /** @class */ (function (_super) {
      * or rejected if wrapper operation fails.
      */
     SplitsCachePluggable.prototype.getSplit = function (name) {
-        return this.wrapper.get(this.keys.buildSplitKey(name));
+        return this.wrapper.get(this.keys.buildSplitKey(name))
+            .then(function (maybeSplit) { return maybeSplit && JSON.parse(maybeSplit); });
     };
     /**
      * Get list of splits.
@@ -117,7 +117,8 @@ var SplitsCachePluggable = /** @class */ (function (_super) {
         return this.wrapper.getMany(keys).then(function (splitDefinitions) {
             var splits = {};
             names.forEach(function (name, idx) {
-                splits[name] = splitDefinitions[idx];
+                var split = splitDefinitions[idx];
+                splits[name] = split && JSON.parse(split);
             });
             return Promise.resolve(splits);
         });
@@ -129,7 +130,11 @@ var SplitsCachePluggable = /** @class */ (function (_super) {
      */
     SplitsCachePluggable.prototype.getAll = function () {
         var _this = this;
-        return this.wrapper.getKeysByPrefix(this.keys.buildSplitKeyPrefix()).then(function (listOfKeys) { return Promise.all(listOfKeys.map(_this.wrapper.get)); });
+        return this.wrapper.getKeysByPrefix(this.keys.buildSplitKeyPrefix())
+            .then(function (listOfKeys) { return _this.wrapper.getMany(listOfKeys); })
+            .then(function (splitDefinitions) { return splitDefinitions.map(function (splitDefinition) {
+            return JSON.parse(splitDefinition);
+        }); });
     };
     /**
      * Get list of split names.

package/cjs/sync/offline/syncTasks/fromObjectSyncTask.js

@@ -27,8 +27,7 @@ function fromObjectUpdaterFactory(splitsParser, storage, readiness, settings) {
             log.debug(constants_3.SYNC_OFFLINE_DATA, [JSON.stringify(splitsMock)]);
             (0, lang_1.forOwn)(splitsMock, function (val, name) {
                 splits.push([
-                    name,
-                    JSON.stringify({
+                    name, {
                         name: name,
                         status: 'ACTIVE',
                         killed: false,
@@ -37,7 +36,7 @@ function fromObjectUpdaterFactory(splitsParser, storage, readiness, settings) {
                         conditions: val.conditions || [],
                         configurations: val.configurations,
                         trafficTypeName: val.trafficTypeName
-                    })
+                    }
                 ]);
             });
             return Promise.all([

package/cjs/sync/polling/updaters/splitChangesUpdater.js

@@ -41,7 +41,7 @@ function computeSplitsMutation(entries) {
     var segments = new sets_1._Set();
     var computed = entries.reduce(function (accum, split) {
         if (split.status === 'ACTIVE') {
-            accum.added.push([split.name, JSON.stringify(split)]);
+            accum.added.push([split.name, split]);
             parseSegments(split).forEach(function (segmentName) {
                 segments.add(segmentName);
             });

package/cjs/trackers/strategy/strategyOptimized.js

@@ -17,7 +17,8 @@ function strategyOptimizedFactory(impressionsObserver, impressionsCounter) {
                 impression.pt = impressionsObserver.testAndSet(impression);
                 var now = Date.now();
                 // Increments impression counter per featureName
-                impressionsCounter.track(impression.feature, now, 1);
+                if (impression.pt)
+                    impressionsCounter.track(impression.feature, now, 1);
                 // Checks if the impression should be added in queue to be sent
                 if (!impression.pt || impression.pt < (0, time_1.truncateTimeFrame)(now)) {
                     impressionsToStore.push(impression);

package/cjs/trackers/telemetryTracker.js

@@ -49,6 +49,11 @@ function telemetryTrackerFactory(telemetryCache, now) {
                     if (e === constants_1.TOKEN_REFRESH)
                         telemetryCache.recordTokenRefreshes();
                 }
+            },
+            addTag: function (tag) {
+                // @ts-ignore
+                if (telemetryCache.addTag)
+                    telemetryCache.addTag(tag);
             }
         };
     }
@@ -59,6 +64,7 @@ function telemetryTrackerFactory(telemetryCache, now) {
             trackHttp: noopTrack,
             sessionLength: function () { },
             streamingEvent: function () { },
+            addTag: function () { }
         };
     }
 }