@splitsoftware/splitio-commons 1.3.2-rc.6 → 1.3.2-rc.7

package/CHANGES.txt

@@ -1,4 +1,4 @@
-1.4.0 (May 20, 2022)
+1.4.0 (May 24, 2022)
  - Added `scheduler.telemetryRefreshRate` property to SDK configuration, and deprecated `scheduler.metricsRefreshRate` property.
  - Updated SDK telemetry storage, metrics and updater to be more effective and send less often.
  - Bugfixing - Updated default values for `scheduler.impressionsRefreshRate` config parameter: 300s for OPTIMIZED impression mode and 60s for DEBUG impression mode.

package/cjs/utils/settingsValidation/index.js

@@ -112,16 +112,9 @@ function settingsValidation(config, validationParams) {
     scheduler.offlineRefreshRate = fromSecondsToMillis(scheduler.offlineRefreshRate);
     scheduler.eventsPushRate = fromSecondsToMillis(scheduler.eventsPushRate);
     scheduler.telemetryRefreshRate = fromSecondsToMillis(validateMinValue('telemetryRefreshRate', scheduler.telemetryRefreshRate, 60));
-    if (scheduler.impressionsRefreshRate !== exports.base.scheduler.impressionsRefreshRate) {
-        // Validate impressionsRefreshRate defined by user
-        scheduler.impressionsRefreshRate = validateMinValue('impressionsRefreshRate', scheduler.impressionsRefreshRate, withDefaults.sync.impressionsMode === constants_1.DEBUG ? 1 : 60 // Min is 1 sec for DEBUG and 60 secs for OPTIMIZED
-        );
-    }
-    else {
-        // Default impressionsRefreshRate for DEBUG mode is 60 secs
-        if (withDefaults.sync.impressionsMode === constants_1.DEBUG)
-            scheduler.impressionsRefreshRate = 60;
-    }
+    // Default impressionsRefreshRate for DEBUG mode is 60 secs
+    if ((0, lang_1.get)(config, 'scheduler.impressionsRefreshRate') === undefined && withDefaults.sync.impressionsMode === constants_1.DEBUG)
+        scheduler.impressionsRefreshRate = 60;
     scheduler.impressionsRefreshRate = fromSecondsToMillis(scheduler.impressionsRefreshRate);
     // Log deprecation for old telemetry param
     if (scheduler.metricsRefreshRate)

package/esm/utils/settingsValidation/index.js

@@ -1,4 +1,4 @@
-import { merge } from '../lang';
+import { merge, get } from '../lang';
 import { mode } from './mode';
 import { validateSplitFilters } from './splitFilters';
 import { STANDALONE_MODE, OPTIMIZED, LOCALHOST_MODE, DEBUG } from '../constants';
@@ -109,16 +109,9 @@ export function settingsValidation(config, validationParams) {
     scheduler.offlineRefreshRate = fromSecondsToMillis(scheduler.offlineRefreshRate);
     scheduler.eventsPushRate = fromSecondsToMillis(scheduler.eventsPushRate);
     scheduler.telemetryRefreshRate = fromSecondsToMillis(validateMinValue('telemetryRefreshRate', scheduler.telemetryRefreshRate, 60));
-    if (scheduler.impressionsRefreshRate !== base.scheduler.impressionsRefreshRate) {
-        // Validate impressionsRefreshRate defined by user
-        scheduler.impressionsRefreshRate = validateMinValue('impressionsRefreshRate', scheduler.impressionsRefreshRate, withDefaults.sync.impressionsMode === DEBUG ? 1 : 60 // Min is 1 sec for DEBUG and 60 secs for OPTIMIZED
-        );
-    }
-    else {
-        // Default impressionsRefreshRate for DEBUG mode is 60 secs
-        if (withDefaults.sync.impressionsMode === DEBUG)
-            scheduler.impressionsRefreshRate = 60;
-    }
+    // Default impressionsRefreshRate for DEBUG mode is 60 secs
+    if (get(config, 'scheduler.impressionsRefreshRate') === undefined && withDefaults.sync.impressionsMode === DEBUG)
+        scheduler.impressionsRefreshRate = 60;
     scheduler.impressionsRefreshRate = fromSecondsToMillis(scheduler.impressionsRefreshRate);
     // Log deprecation for old telemetry param
     if (scheduler.metricsRefreshRate)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@splitsoftware/splitio-commons",
-  "version": "1.3.2-rc.6",
+  "version": "1.3.2-rc.7",
   "description": "Split Javascript SDK common components",
   "main": "cjs/index.js",
   "module": "esm/index.js",

package/src/utils/lang/index.ts

@@ -71,7 +71,7 @@ export function forOwn<T>(obj: { [key: string]: T }, iteratee: (value: T, key: s
  * Safely retrieve the specified prop from obj. If we can't retrieve
  * that property value, we return the default value.
  */
-export function get(obj: any, prop: any, val: any): any {
+export function get(obj: any, prop: any, val?: any): any {
   let res = val;
 
   try { // No risks nor lots of checks.

package/src/utils/settingsValidation/index.ts

@@ -1,4 +1,4 @@
-import { merge } from '../lang';
+import { merge, get } from '../lang';
 import { mode } from './mode';
 import { validateSplitFilters } from './splitFilters';
 import { STANDALONE_MODE, OPTIMIZED, LOCALHOST_MODE, DEBUG } from '../constants';
@@ -131,15 +131,8 @@ export function settingsValidation(config: unknown, validationParams: ISettingsV
   scheduler.eventsPushRate = fromSecondsToMillis(scheduler.eventsPushRate);
   scheduler.telemetryRefreshRate = fromSecondsToMillis(validateMinValue('telemetryRefreshRate', scheduler.telemetryRefreshRate, 60));
 
-  if (scheduler.impressionsRefreshRate !== base.scheduler.impressionsRefreshRate) {
-    // Validate impressionsRefreshRate defined by user
-    scheduler.impressionsRefreshRate = validateMinValue('impressionsRefreshRate', scheduler.impressionsRefreshRate,
-      withDefaults.sync.impressionsMode === DEBUG ? 1 : 60 // Min is 1 sec for DEBUG and 60 secs for OPTIMIZED
-    );
-  } else {
-    // Default impressionsRefreshRate for DEBUG mode is 60 secs
-    if (withDefaults.sync.impressionsMode === DEBUG) scheduler.impressionsRefreshRate = 60;
-  }
+  // Default impressionsRefreshRate for DEBUG mode is 60 secs
+  if (get(config, 'scheduler.impressionsRefreshRate') === undefined && withDefaults.sync.impressionsMode === DEBUG) scheduler.impressionsRefreshRate = 60;
   scheduler.impressionsRefreshRate = fromSecondsToMillis(scheduler.impressionsRefreshRate);
 
   // Log deprecation for old telemetry param

package/types/utils/lang/index.d.ts

@@ -28,7 +28,7 @@ export declare function forOwn<T>(obj: {
  * Safely retrieve the specified prop from obj. If we can't retrieve
  * that property value, we return the default value.
  */
-export declare function get(obj: any, prop: any, val: any): any;
+export declare function get(obj: any, prop: any, val?: any): any;
 /**
  * Parses an array into a map of different arrays, grouping by the specified prop value.
  */