@splitsoftware/splitio-commons 1.2.1-rc.2 → 1.2.1-rc.5

package/cjs/utils/settingsValidation/consent.js

@@ -0,0 +1,16 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.validateConsent = void 0;
+var constants_1 = require("../../logger/constants");
+var constants_2 = require("../constants");
+var userConsentValues = [constants_2.CONSENT_DECLINED, constants_2.CONSENT_GRANTED, constants_2.CONSENT_UNKNOWN];
+function validateConsent(_a) {
+    var userConsent = _a.userConsent, log = _a.log;
+    if (typeof userConsent === 'string')
+        userConsent = userConsent.toUpperCase();
+    if (userConsentValues.indexOf(userConsent) > -1)
+        return userConsent;
+    log.error(constants_1.ERROR_INVALID_CONFIG_PARAM, ['userConsent', userConsentValues, constants_2.CONSENT_GRANTED]);
+    return constants_2.CONSENT_GRANTED;
+}
+exports.validateConsent = validateConsent;

package/cjs/utils/settingsValidation/impressionsMode.js

@@ -4,11 +4,11 @@ exports.validImpressionsMode = void 0;
 var constants_1 = require("../../logger/constants");
 var constants_2 = require("../constants");
 function validImpressionsMode(log, impressionsMode) {
-    impressionsMode = impressionsMode.toUpperCase();
-    if ([constants_2.DEBUG, constants_2.OPTIMIZED].indexOf(impressionsMode) === -1) {
-        log.error(constants_1.ERROR_INVALID_IMPRESSIONS_MODE, [[constants_2.DEBUG, constants_2.OPTIMIZED], constants_2.OPTIMIZED]);
-        impressionsMode = constants_2.OPTIMIZED;
-    }
-    return impressionsMode;
+    if (typeof impressionsMode === 'string')
+        impressionsMode = impressionsMode.toUpperCase();
+    if ([constants_2.DEBUG, constants_2.OPTIMIZED].indexOf(impressionsMode) > -1)
+        return impressionsMode;
+    log.error(constants_1.ERROR_INVALID_CONFIG_PARAM, ['impressionsMode', [constants_2.DEBUG, constants_2.OPTIMIZED], constants_2.OPTIMIZED]);
+    return constants_2.OPTIMIZED;
 }
 exports.validImpressionsMode = validImpressionsMode;

package/cjs/utils/settingsValidation/index.js

@@ -36,6 +36,8 @@ var base = {
         eventsPushRate: 60,
         // how many events will be queued before flushing
         eventsQueueSize: 500,
+        // how many impressions will be queued before flushing
+        impressionsQueueSize: 30000,
         // backoff base seconds to wait before re attempting to connect to push notifications
         pushRetryBackoffBase: 1,
     },
@@ -81,7 +83,7 @@ function fromSecondsToMillis(n) {
  * @param validationParams defaults and fields validators used to validate and creates a settings object from a given config
  */
 function settingsValidation(config, validationParams) {
-    var defaults = validationParams.defaults, runtime = validationParams.runtime, storage = validationParams.storage, integrations = validationParams.integrations, logger = validationParams.logger, localhost = validationParams.localhost;
+    var defaults = validationParams.defaults, runtime = validationParams.runtime, storage = validationParams.storage, integrations = validationParams.integrations, logger = validationParams.logger, localhost = validationParams.localhost, consent = validationParams.consent;
     // creates a settings object merging base, defaults and config objects.
     var withDefaults = (0, lang_1.merge)({}, base, defaults, config);
     // ensure a valid logger.
@@ -134,6 +136,9 @@ function settingsValidation(config, validationParams) {
     withDefaults.sync.__splitFiltersValidation = splitFiltersValidation;
     // ensure a valid impressionsMode
     withDefaults.sync.impressionsMode = (0, impressionsMode_1.validImpressionsMode)(log, withDefaults.sync.impressionsMode);
+    // ensure a valid user consent value
+    // @ts-ignore, modify readonly prop
+    withDefaults.userConsent = consent(withDefaults);
     return withDefaults;
 }
 exports.settingsValidation = settingsValidation;

package/cjs/utils/settingsValidation/{runtime/browser.js → runtime.js}

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.validateRuntime = void 0;
+// For client-side SDKs, machine IP and Hostname are not captured and sent to Split backend.
 function validateRuntime() {
     return {
         ip: false,

package/esm/integrations/ga/GoogleAnalyticsToSplit.js

@@ -1,7 +1,9 @@
 import { GaToSplit } from './GaToSplit';
 export function GoogleAnalyticsToSplit(options) {
     // GaToSplit integration factory
-    return function (params) {
+    function GoogleAnalyticsToSplitFactory(params) {
         return GaToSplit(options, params);
-    };
+    }
+    GoogleAnalyticsToSplitFactory.type = 'GOOGLE_ANALYTICS_TO_SPLIT';
+    return GoogleAnalyticsToSplitFactory;
 }

package/esm/integrations/ga/SplitToGoogleAnalytics.js

@@ -2,7 +2,9 @@ import { SplitToGa } from './SplitToGa';
 export function SplitToGoogleAnalytics(options) {
     if (options === void 0) { options = {}; }
     // SplitToGa integration factory
-    return function (params) {
+    function SplitToGoogleAnalyticsFactory(params) {
         return new SplitToGa(params.settings.log, options);
-    };
+    }
+    SplitToGoogleAnalyticsFactory.type = 'SPLIT_TO_GOOGLE_ANALYTICS';
+    return SplitToGoogleAnalyticsFactory;
 }

package/esm/listeners/browser.js

@@ -3,6 +3,7 @@ import { fromImpressionCountsCollector } from '../sync/submitters/impressionCoun
 import { OPTIMIZED, DEBUG } from '../utils/constants';
 import { objectAssign } from '../utils/lang/objectAssign';
 import { CLEANUP_REGISTERING, CLEANUP_DEREGISTERING } from '../logger/constants';
+import { isConsentGranted } from '../utils/consent';
 // 'unload' event is used instead of 'beforeunload', since 'unload' is not a cancelable event, so no other listeners can stop the event from occurring.
 var UNLOAD_DOM_EVENT = 'unload';
 var EVENT_NAME = 'for unload page event.';
@@ -48,15 +49,18 @@ var BrowserSignalListener = /** @class */ (function () {
     BrowserSignalListener.prototype.flushData = function () {
         if (!this.syncManager)
             return; // In consumer mode there is not sync manager and data to flush
-        var eventsUrl = this.settings.urls.events;
-        var extraMetadata = {
-            // sim stands for Sync/Split Impressions Mode
-            sim: this.settings.sync.impressionsMode === OPTIMIZED ? OPTIMIZED : DEBUG
-        };
-        this._flushData(eventsUrl + '/testImpressions/beacon', this.storage.impressions, this.serviceApi.postTestImpressionsBulk, this.fromImpressionsCollector, extraMetadata);
-        this._flushData(eventsUrl + '/events/beacon', this.storage.events, this.serviceApi.postEventsBulk);
-        if (this.storage.impressionCounts)
-            this._flushData(eventsUrl + '/testImpressions/count/beacon', this.storage.impressionCounts, this.serviceApi.postTestImpressionsCount, fromImpressionCountsCollector);
+        // Flush data if there is user consent
+        if (isConsentGranted(this.settings)) {
+            var eventsUrl = this.settings.urls.events;
+            var extraMetadata = {
+                // sim stands for Sync/Split Impressions Mode
+                sim: this.settings.sync.impressionsMode === OPTIMIZED ? OPTIMIZED : DEBUG
+            };
+            this._flushData(eventsUrl + '/testImpressions/beacon', this.storage.impressions, this.serviceApi.postTestImpressionsBulk, this.fromImpressionsCollector, extraMetadata);
+            this._flushData(eventsUrl + '/events/beacon', this.storage.events, this.serviceApi.postEventsBulk);
+            if (this.storage.impressionCounts)
+                this._flushData(eventsUrl + '/testImpressions/count/beacon', this.storage.impressionCounts, this.serviceApi.postTestImpressionsCount, fromImpressionCountsCollector);
+        }
         // Close streaming connection
         if (this.syncManager.pushManager)
             this.syncManager.pushManager.stop();
@@ -66,7 +70,7 @@ var BrowserSignalListener = /** @class */ (function () {
         if (!cache.isEmpty()) {
             var dataPayload = fromCacheToPayload ? fromCacheToPayload(cache.state()) : cache.state();
             if (!this._sendBeacon(url, dataPayload, extraMetadata)) {
-                postService(JSON.stringify(dataPayload)).catch(function () { }); // no-op just to catch a possible exceptions
+                postService(JSON.stringify(dataPayload)).catch(function () { }); // no-op just to catch a possible exception
             }
             cache.clear();
         }

package/esm/logger/constants.js

@@ -60,13 +60,14 @@ export var STREAMING_RECONNECT = 111;
 export var STREAMING_CONNECTING = 112;
 export var STREAMING_DISABLED = 113;
 export var STREAMING_DISCONNECTING = 114;
-export var SUBMITTERS_PUSH_FULL_EVENTS_QUEUE = 115;
+export var SUBMITTERS_PUSH_FULL_QUEUE = 115;
 export var SUBMITTERS_PUSH = 116;
 export var SYNC_START_POLLING = 117;
 export var SYNC_CONTINUE_POLLING = 118;
 export var SYNC_STOP_POLLING = 119;
 export var EVENTS_TRACKER_SUCCESS = 120;
 export var IMPRESSIONS_TRACKER_SUCCESS = 121;
+export var USER_CONSENT_UPDATED = 122;
 export var ENGINE_VALUE_INVALID = 200;
 export var ENGINE_VALUE_NO_ATTRIBUTES = 201;
 export var CLIENT_NO_LISTENER = 202;
@@ -112,10 +113,11 @@ export var ERROR_INVALID_KEY_OBJECT = 317;
 export var ERROR_INVALID = 318;
 export var ERROR_EMPTY = 319;
 export var ERROR_EMPTY_ARRAY = 320;
-export var ERROR_INVALID_IMPRESSIONS_MODE = 321;
+export var ERROR_INVALID_CONFIG_PARAM = 321;
 export var ERROR_HTTP = 322;
 export var ERROR_LOCALHOST_MODULE_REQUIRED = 323;
 export var ERROR_STORAGE_INVALID = 324;
+export var ERROR_NOT_BOOLEAN = 325;
 // Log prefixes (a.k.a. tags or categories)
 export var LOG_PREFIX_SETTINGS = 'settings';
 export var LOG_PREFIX_INSTANTIATION = 'Factory instantiation';

package/esm/logger/messages/error.js

@@ -12,7 +12,7 @@ export var codesError = [
     [c.ERROR_SYNC_OFFLINE_LOADING, c.LOG_PREFIX_SYNC_OFFLINE + 'There was an issue loading the mock Splits data, no changes will be applied to the current cache. %s'],
     [c.ERROR_STREAMING_SSE, c.LOG_PREFIX_SYNC_STREAMING + 'Failed to connect or error on streaming connection, with error message: %s'],
     [c.ERROR_STREAMING_AUTH, c.LOG_PREFIX_SYNC_STREAMING + 'Failed to authenticate for streaming. Error: %s.'],
-    [c.ERROR_HTTP, ' Response status is not OK. Status: %s. URL: %s. Message: %s'],
+    [c.ERROR_HTTP, 'Response status is not OK. Status: %s. URL: %s. Message: %s'],
     // client status
     [c.ERROR_CLIENT_LISTENER, 'A listener was added for %s on the SDK, which has already fired and won\'t be emitted again. The callback won\'t be executed.'],
     [c.ERROR_CLIENT_DESTROYED, '%s: Client has already been destroyed - no calls possible.'],
@@ -27,8 +27,9 @@ export var codesError = [
     [c.ERROR_INVALID, '%s: you passed an invalid %s. It must be a non-empty string.'],
     [c.ERROR_EMPTY, '%s: you passed an empty %s. It must be a non-empty string.'],
     [c.ERROR_EMPTY_ARRAY, '%s: %s must be a non-empty array.'],
+    [c.ERROR_NOT_BOOLEAN, '%s: you must provide a boolean param.'],
     // initialization / settings validation
-    [c.ERROR_INVALID_IMPRESSIONS_MODE, c.LOG_PREFIX_SETTINGS + ': you passed an invalid "impressionsMode". It should be one of the following values: %s. Defaulting to "%s" mode.'],
+    [c.ERROR_INVALID_CONFIG_PARAM, c.LOG_PREFIX_SETTINGS + ': you passed an invalid "%s" config param. It should be one of the following values: %s. Defaulting to "%s".'],
     [c.ERROR_LOCALHOST_MODULE_REQUIRED, c.LOG_PREFIX_SETTINGS + ': an invalid value was received for "sync.localhostMode" config. A valid entity should be provided for localhost mode.'],
     [c.ERROR_STORAGE_INVALID, c.LOG_PREFIX_SETTINGS + ': The provided storage is invalid.%s Fallbacking into default MEMORY storage'],
 ];

package/esm/logger/messages/info.js

@@ -12,12 +12,13 @@ export var codesInfo = codesWarn.concat([
     [c.NEW_FACTORY, ' New Split SDK instance created.'],
     [c.EVENTS_TRACKER_SUCCESS, c.LOG_PREFIX_EVENTS_TRACKER + 'Successfully queued %s'],
     [c.IMPRESSIONS_TRACKER_SUCCESS, c.LOG_PREFIX_IMPRESSIONS_TRACKER + 'Successfully stored %s impression(s).'],
+    [c.USER_CONSENT_UPDATED, 'User consent changed from %s to %s.'],
     // synchronizer
     [c.POLLING_SMART_PAUSING, c.LOG_PREFIX_SYNC_POLLING + 'Turning segments data polling %s.'],
     [c.POLLING_START, c.LOG_PREFIX_SYNC_POLLING + 'Starting polling'],
     [c.POLLING_STOP, c.LOG_PREFIX_SYNC_POLLING + 'Stopping polling'],
     [c.SYNC_SPLITS_FETCH_RETRY, c.LOG_PREFIX_SYNC_SPLITS + 'Retrying download of splits #%s. Reason: %s'],
-    [c.SUBMITTERS_PUSH_FULL_EVENTS_QUEUE, c.LOG_PREFIX_SYNC_SUBMITTERS + 'Flushing full events queue and reseting timer.'],
+    [c.SUBMITTERS_PUSH_FULL_QUEUE, c.LOG_PREFIX_SYNC_SUBMITTERS + 'Flushing full %s queue and reseting timer.'],
     [c.SUBMITTERS_PUSH, c.LOG_PREFIX_SYNC_SUBMITTERS + 'Pushing %s %s.'],
     [c.STREAMING_REFRESH_TOKEN, c.LOG_PREFIX_SYNC_STREAMING + 'Refreshing streaming token in %s seconds, and connecting streaming in %s seconds.'],
     [c.STREAMING_RECONNECT, c.LOG_PREFIX_SYNC_STREAMING + 'Attempting to reconnect streaming in %s seconds.'],
@@ -26,5 +27,5 @@ export var codesInfo = codesWarn.concat([
     [c.STREAMING_DISCONNECTING, c.LOG_PREFIX_SYNC_STREAMING + 'Disconnecting streaming.'],
     [c.SYNC_START_POLLING, c.LOG_PREFIX_SYNC_MANAGER + 'Streaming not available. Starting polling.'],
     [c.SYNC_CONTINUE_POLLING, c.LOG_PREFIX_SYNC_MANAGER + 'Streaming couldn\'t connect. Continue polling.'],
-    [c.SYNC_STOP_POLLING, c.LOG_PREFIX_SYNC_MANAGER + 'Streaming (re)connected. Syncing and stopping polling.'],
+    [c.SYNC_STOP_POLLING, c.LOG_PREFIX_SYNC_MANAGER + 'Streaming connected. Syncing and stopping polling.'],
 ]);

package/esm/sdkClient/client.js

@@ -4,20 +4,22 @@ import { getMatching, getBucketing } from '../utils/key';
 import { validateSplitExistance } from '../utils/inputValidation/splitExistance';
 import { validateTrafficTypeExistance } from '../utils/inputValidation/trafficTypeExistance';
 import { SDK_NOT_READY } from '../utils/labels';
-import { CONTROL } from '../utils/constants';
+import { CONSENT_DECLINED, CONTROL } from '../utils/constants';
 import { IMPRESSION, IMPRESSION_QUEUEING } from '../logger/constants';
 /**
  * Creator of base client with getTreatments and track methods.
  */
 // @TODO missing time tracking to collect telemetry
 export function clientFactory(params) {
-    var readinessManager = params.sdkReadinessManager.readinessManager, storage = params.storage, _a = params.settings, log = _a.log, mode = _a.mode, impressionsTracker = params.impressionsTracker, eventTracker = params.eventTracker;
+    var readinessManager = params.sdkReadinessManager.readinessManager, storage = params.storage, settings = params.settings, impressionsTracker = params.impressionsTracker, eventTracker = params.eventTracker;
+    var log = settings.log, mode = settings.mode;
     function getTreatment(key, splitName, attributes, withConfig) {
         if (withConfig === void 0) { withConfig = false; }
         var wrapUp = function (evaluationResult) {
             var queue = [];
             var treatment = processEvaluation(evaluationResult, splitName, key, attributes, withConfig, "getTreatment" + (withConfig ? 'withConfig' : ''), queue);
-            impressionsTracker.track(queue, attributes);
+            if (settings.userConsent !== CONSENT_DECLINED)
+                impressionsTracker.track(queue, attributes);
             return treatment;
         };
         var evaluation = evaluateFeature(log, key, splitName, attributes, storage);
@@ -34,7 +36,8 @@ export function clientFactory(params) {
             Object.keys(evaluationResults).forEach(function (splitName) {
                 treatments[splitName] = processEvaluation(evaluationResults[splitName], splitName, key, attributes, withConfig, "getTreatments" + (withConfig ? 'withConfig' : ''), queue);
             });
-            impressionsTracker.track(queue, attributes);
+            if (settings.userConsent !== CONSENT_DECLINED)
+                impressionsTracker.track(queue, attributes);
             return treatments;
         };
         var evaluations = evaluateFeatures(log, key, splitNames, attributes, storage);
@@ -88,7 +91,10 @@ export function clientFactory(params) {
         };
         // This may be async but we only warn, we don't actually care if it is valid or not in terms of queueing the event.
         validateTrafficTypeExistance(log, readinessManager, storage.splits, mode, trafficTypeName, 'track');
-        return eventTracker.track(eventData, size);
+        if (settings.userConsent !== CONSENT_DECLINED)
+            return eventTracker.track(eventData, size);
+        else
+            return false;
     }
     return {
         getTreatment: getTreatment,

package/esm/sdkFactory/index.js

@@ -8,11 +8,12 @@ import { createLoggerAPI } from '../logger/sdkLogger';
 import { NEW_FACTORY, RETRIEVE_MANAGER } from '../logger/constants';
 import { metadataBuilder } from '../storages/metadataBuilder';
 import { SDK_SPLITS_ARRIVED, SDK_SEGMENTS_ARRIVED } from '../readiness/constants';
+import { objectAssign } from '../utils/lang/objectAssign';
 /**
  * Modular SDK factory
  */
 export function sdkFactory(params) {
-    var settings = params.settings, platform = params.platform, storageFactory = params.storageFactory, splitApiFactory = params.splitApiFactory, syncManagerFactory = params.syncManagerFactory, SignalListener = params.SignalListener, impressionsObserverFactory = params.impressionsObserverFactory, impressionListener = params.impressionListener, integrationsManagerFactory = params.integrationsManagerFactory, sdkManagerFactory = params.sdkManagerFactory, sdkClientMethodFactory = params.sdkClientMethodFactory;
+    var settings = params.settings, platform = params.platform, storageFactory = params.storageFactory, splitApiFactory = params.splitApiFactory, extraProps = params.extraProps, syncManagerFactory = params.syncManagerFactory, SignalListener = params.SignalListener, impressionsObserverFactory = params.impressionsObserverFactory, impressionListener = params.impressionListener, integrationsManagerFactory = params.integrationsManagerFactory, sdkManagerFactory = params.sdkManagerFactory, sdkClientMethodFactory = params.sdkClientMethodFactory;
     var log = settings.log;
     // @TODO handle non-recoverable errors: not start sync, mark the SDK as destroyed, etc.
     // We will just log and allow for the SDK to end up throwing an SDK_TIMEOUT event for devs to handle.
@@ -22,6 +23,7 @@ export function sdkFactory(params) {
     var readinessManager = sdkReadinessManager.readinessManager;
     // @TODO consider passing the settings object, so that each storage access only what it needs
     var storageFactoryParams = {
+        impressionsQueueSize: settings.scheduler.impressionsQueueSize,
         eventsQueueSize: settings.scheduler.eventsQueueSize,
         optimize: shouldBeOptimized(settings),
         // ATM, only used by InLocalStorage
@@ -64,11 +66,11 @@ export function sdkFactory(params) {
     syncManager && syncManager.start();
     signalListener && signalListener.start();
     log.info(NEW_FACTORY);
-    return {
+    // @ts-ignore
+    return objectAssign({
         // Split evaluation and event tracking engine
         client: clientMethod,
         // Manager API to explore available information
-        // @ts-ignore
         manager: function () {
             log.debug(RETRIEVE_MANAGER);
             return managerInstance;
@@ -76,5 +78,5 @@ export function sdkFactory(params) {
         // Logger wrapper API
         Logger: createLoggerAPI(settings.log),
         settings: settings,
-    };
+    }, extraProps && extraProps(settings, syncManager));
 }

package/esm/sdkFactory/userConsentProps.js

@@ -0,0 +1,30 @@
+import { ERROR_NOT_BOOLEAN, USER_CONSENT_UPDATED } from '../logger/constants';
+import { CONSENT_GRANTED, CONSENT_DECLINED } from '../utils/constants';
+// Extend client-side factory instances with user consent getter/setter
+export function userConsentProps(settings, syncManager) {
+    var log = settings.log;
+    return {
+        setUserConsent: function (consent) {
+            var _a, _b;
+            // validate input param
+            if (typeof consent !== 'boolean') {
+                log.error(ERROR_NOT_BOOLEAN, ['setUserConsent']);
+                return false;
+            }
+            var newConsentStatus = consent ? CONSENT_GRANTED : CONSENT_DECLINED;
+            if (settings.userConsent !== newConsentStatus) {
+                // resume/pause submitters
+                if (consent)
+                    (_a = syncManager === null || syncManager === void 0 ? void 0 : syncManager.submitter) === null || _a === void 0 ? void 0 : _a.start();
+                else
+                    (_b = syncManager === null || syncManager === void 0 ? void 0 : syncManager.submitter) === null || _b === void 0 ? void 0 : _b.stop();
+                log.info(USER_CONSENT_UPDATED, [settings.userConsent, newConsentStatus]); // @ts-ignore, modify readonly prop
+                settings.userConsent = newConsentStatus;
+            }
+            return true;
+        },
+        getUserConsent: function () {
+            return settings.userConsent;
+        }
+    };
+}

package/esm/storages/KeyBuilderCS.js

@@ -13,9 +13,19 @@ var KeyBuilderCS = /** @class */ (function (_super) {
      * @override
      */
     KeyBuilderCS.prototype.buildSegmentNameKey = function (segmentName) {
-        return this.matchingKey + "." + this.prefix + ".segment." + segmentName;
+        return this.prefix + "." + this.matchingKey + ".segment." + segmentName;
     };
     KeyBuilderCS.prototype.extractSegmentName = function (builtSegmentKeyName) {
+        var prefix = this.prefix + "." + this.matchingKey + ".segment.";
+        if (startsWith(builtSegmentKeyName, prefix))
+            return builtSegmentKeyName.substr(prefix.length);
+    };
+    // @BREAKING: The key used to start with the matching key instead of the prefix, this was changed on version 10.17.3
+    KeyBuilderCS.prototype.buildOldSegmentNameKey = function (segmentName) {
+        return this.matchingKey + "." + this.prefix + ".segment." + segmentName;
+    };
+    // @BREAKING: The key used to start with the matching key instead of the prefix, this was changed on version 10.17.3
+    KeyBuilderCS.prototype.extractOldSegmentKey = function (builtSegmentKeyName) {
         var prefix = this.matchingKey + "." + this.prefix + ".segment.";
         if (startsWith(builtSegmentKeyName, prefix))
             return builtSegmentKeyName.substr(prefix.length);

package/esm/storages/inLocalStorage/MySegmentsCacheInLocal.js

@@ -57,9 +57,29 @@ var MySegmentsCacheInLocal = /** @class */ (function (_super) {
         var index;
         // Scan current values from localStorage
         var storedSegmentNames = Object.keys(localStorage).reduce(function (accum, key) {
-            var name = _this.keys.extractSegmentName(key);
-            if (name)
-                accum.push(name);
+            var segmentName = _this.keys.extractSegmentName(key);
+            if (segmentName) {
+                accum.push(segmentName);
+            }
+            else {
+                // @BREAKING: This is only to clean up "old" keys. Remove this whole else code block.
+                segmentName = _this.keys.extractOldSegmentKey(key);
+                if (segmentName) { // this was an old segment key, let's clean up.
+                    var newSegmentKey = _this.keys.buildSegmentNameKey(segmentName);
+                    try {
+                        // If the new format key is not there, create it.
+                        if (!localStorage.getItem(newSegmentKey) && names.indexOf(segmentName) > -1) {
+                            localStorage.setItem(newSegmentKey, DEFINED);
+                            // we are migrating a segment, let's track it.
+                            accum.push(segmentName);
+                        }
+                        localStorage.removeItem(key); // we migrated the current key, let's delete it.
+                    }
+                    catch (e) {
+                        _this.log.error(e);
+                    }
+                }
+            }
             return accum;
         }, []);
         // Extreme fast => everything is empty

package/esm/storages/inLocalStorage/index.js

@@ -30,7 +30,7 @@ export function InLocalStorage(options) {
         return {
             splits: new SplitsCacheInLocal(log, keys, expirationTimestamp, params.splitFiltersValidation),
             segments: new MySegmentsCacheInLocal(log, keys),
-            impressions: new ImpressionsCacheInMemory(),
+            impressions: new ImpressionsCacheInMemory(params.impressionsQueueSize),
             impressionCounts: params.optimize ? new ImpressionCountsCacheInMemory() : undefined,
             events: new EventsCacheInMemory(params.eventsQueueSize),
             destroy: function () {

package/esm/storages/inMemory/ImpressionsCacheInMemory.js

@@ -1,13 +1,27 @@
 var ImpressionsCacheInMemory = /** @class */ (function () {
-    function ImpressionsCacheInMemory() {
+    /**
+     *
+     * @param impressionsQueueSize number of queued impressions to call onFullQueueCb.
+     * Default value is 0, that means no maximum value, in case we want to avoid this being triggered.
+     */
+    function ImpressionsCacheInMemory(impressionsQueueSize) {
+        if (impressionsQueueSize === void 0) { impressionsQueueSize = 0; }
+        this.maxQueue = impressionsQueueSize;
         this.queue = [];
     }
+    ImpressionsCacheInMemory.prototype.setOnFullQueueCb = function (cb) {
+        this.onFullQueue = cb;
+    };
     /**
      * Store impressions in sequential order
      */
     ImpressionsCacheInMemory.prototype.track = function (data) {
         var _a;
         (_a = this.queue).push.apply(_a, data);
+        // Check if the cache queue is full and we need to flush it.
+        if (this.maxQueue > 0 && this.queue.length >= this.maxQueue && this.onFullQueue) {
+            this.onFullQueue();
+        }
     };
     /**
      * Clear the data stored on the cache.

package/esm/storages/inMemory/InMemoryStorage.js

@@ -13,7 +13,7 @@ export function InMemoryStorageFactory(params) {
     return {
         splits: new SplitsCacheInMemory(),
         segments: new SegmentsCacheInMemory(),
-        impressions: new ImpressionsCacheInMemory(),
+        impressions: new ImpressionsCacheInMemory(params.impressionsQueueSize),
         impressionCounts: params.optimize ? new ImpressionCountsCacheInMemory() : undefined,
         events: new EventsCacheInMemory(params.eventsQueueSize),
         // When using MEMORY we should clean all the caches to leave them empty

package/esm/storages/inMemory/InMemoryStorageCS.js

@@ -13,7 +13,7 @@ export function InMemoryStorageCSFactory(params) {
     return {
         splits: new SplitsCacheInMemory(),
         segments: new MySegmentsCacheInMemory(),
-        impressions: new ImpressionsCacheInMemory(),
+        impressions: new ImpressionsCacheInMemory(params.impressionsQueueSize),
         impressionCounts: params.optimize ? new ImpressionCountsCacheInMemory() : undefined,
         events: new EventsCacheInMemory(params.eventsQueueSize),
         // When using MEMORY we should clean all the caches to leave them empty

package/esm/storages/pluggable/index.js

@@ -51,7 +51,7 @@ export function PluggableStorage(options) {
     validatePluggableStorageOptions(options);
     var prefix = validatePrefix(options.prefix);
     function PluggableStorageFactory(_a) {
-        var log = _a.log, metadata = _a.metadata, onReadyCb = _a.onReadyCb, mode = _a.mode, eventsQueueSize = _a.eventsQueueSize, optimize = _a.optimize;
+        var log = _a.log, metadata = _a.metadata, onReadyCb = _a.onReadyCb, mode = _a.mode, eventsQueueSize = _a.eventsQueueSize, impressionsQueueSize = _a.impressionsQueueSize, optimize = _a.optimize;
         var keys = new KeyBuilderSS(prefix, metadata);
         var wrapper = wrapperAdapter(log, options.wrapper);
         var isPartialConsumer = mode === CONSUMER_PARTIAL_MODE;
@@ -60,7 +60,7 @@ export function PluggableStorage(options) {
         return {
             splits: new SplitsCachePluggable(log, keys, wrapper),
             segments: new SegmentsCachePluggable(log, keys, wrapper),
-            impressions: isPartialConsumer ? new ImpressionsCacheInMemory() : new ImpressionsCachePluggable(log, keys.buildImpressionsKey(), wrapper, metadata),
+            impressions: isPartialConsumer ? new ImpressionsCacheInMemory(impressionsQueueSize) : new ImpressionsCachePluggable(log, keys.buildImpressionsKey(), wrapper, metadata),
             impressionCounts: optimize ? new ImpressionCountsCacheInMemory() : undefined,
             events: isPartialConsumer ? promisifyEventsTrack(new EventsCacheInMemory(eventsQueueSize)) : new EventsCachePluggable(log, keys.buildEventsKey(), wrapper, metadata),
             // @TODO add telemetry cache when required

package/esm/sync/streaming/pushManager.js

@@ -55,6 +55,7 @@ export function pushManagerFactory(params, pollingManager) {
     // It is used to halt the `connectPush` process if it was in progress.
     var disconnected;
     // flag that indicates a PUSH_NONRETRYABLE_ERROR, condition with which starting pushManager again is ignored.
+    // true if STREAMING_DISABLED control event, or 'pushEnabled: false', or non-recoverable SSE or Auth errors.
     var disabled; // `disabled` implies `disconnected === true`
     /** PushManager functions related to initialization */
     var connectPushRetryBackoff = new Backoff(connectPush, settings.scheduler.pushRetryBackoffBase);
@@ -255,13 +256,15 @@ export function pushManagerFactory(params, pollingManager) {
     return objectAssign(
     // Expose Event Emitter functionality and Event constants
     Object.create(pushEmitter), {
-        // Stop/pause push mode
+        // Stop/pause push mode.
+        // It doesn't emit events. Neither PUSH_SUBSYSTEM_DOWN to start polling.
         stop: function () {
             disconnectPush(); // `handleNonRetryableError` cannot be used as `stop`, because it emits PUSH_SUBSYSTEM_DOWN event, which starts polling.
             if (userKey)
                 this.remove(userKey); // Necessary to properly resume streaming in client-side (e.g., RN SDK transition to foreground).
         },
-        // Start/resume push mode
+        // Start/resume push mode.
+        // It eventually emits PUSH_SUBSYSTEM_DOWN, that starts polling, or PUSH_SUBSYSTEM_UP, that executes a syncAll
         start: function () {
             // Guard condition to avoid calling `connectPush` again if the `start` method is called multiple times or if push has been disabled.
             if (disabled || disconnected === false)
@@ -272,6 +275,10 @@ export function pushManagerFactory(params, pollingManager) {
             else
                 setTimeout(connectPush); // server-side runs in next cycle as in client-side, for consistency with client-side
         },
+        // true/false if start or stop was called last respectively
+        isRunning: function () {
+            return disconnected === false;
+        },
         // [Only for client-side]
         add: function (userKey, mySegmentsSyncTask) {
             var hash = hashUserKey(userKey);

package/esm/sync/submitters/eventsSyncTask.js

@@ -1,11 +1,12 @@
 import { submitterSyncTaskFactory } from './submitterSyncTask';
-import { SUBMITTERS_PUSH_FULL_EVENTS_QUEUE } from '../../logger/constants';
+import { SUBMITTERS_PUSH_FULL_QUEUE } from '../../logger/constants';
+var DATA_NAME = 'events';
 /**
  * Sync task that periodically posts tracked events
  */
 export function eventsSyncTaskFactory(log, postEventsBulk, eventsCache, eventsPushRate, eventsFirstPushWindow, latencyTracker) {
     // don't retry events.
-    var syncTask = submitterSyncTaskFactory(log, postEventsBulk, eventsCache, eventsPushRate, 'queued events', latencyTracker);
+    var syncTask = submitterSyncTaskFactory(log, postEventsBulk, eventsCache, eventsPushRate, DATA_NAME, latencyTracker);
     // Set a timer for the first push of events,
     if (eventsFirstPushWindow > 0) {
         var stopEventPublisherTimeout_1;
@@ -19,10 +20,14 @@ export function eventsSyncTaskFactory(log, postEventsBulk, eventsCache, eventsPu
             originalStop_1();
         };
     }
-    // register eventsSubmitter to be executed when events cache is full
+    // register events submitter to be executed when events cache is full
     eventsCache.setOnFullQueueCb(function () {
-        log.info(SUBMITTERS_PUSH_FULL_EVENTS_QUEUE);
-        syncTask.execute();
+        if (syncTask.isRunning()) {
+            log.info(SUBMITTERS_PUSH_FULL_QUEUE, [DATA_NAME]);
+            syncTask.execute();
+        }
+        // If submitter is stopped (e.g., user consent declined or unknown, or app state offline), we don't send the data.
+        // Data will be sent when submitter is resumed.
     });
     return syncTask;
 }

package/esm/sync/submitters/impressionsSyncTask.js

@@ -1,5 +1,7 @@
 import { groupBy, forOwn } from '../../utils/lang';
 import { submitterSyncTaskFactory } from './submitterSyncTask';
+import { SUBMITTERS_PUSH_FULL_QUEUE } from '../../logger/constants';
+var DATA_NAME = 'impressions';
 /**
  * Converts `impressions` data from cache into request payload.
  */
@@ -32,5 +34,15 @@ export function fromImpressionsCollector(sendLabels, data) {
 export function impressionsSyncTaskFactory(log, postTestImpressionsBulk, impressionsCache, impressionsRefreshRate, sendLabels, latencyTracker) {
     if (sendLabels === void 0) { sendLabels = false; }
     // retry impressions only once.
-    return submitterSyncTaskFactory(log, postTestImpressionsBulk, impressionsCache, impressionsRefreshRate, 'impressions', latencyTracker, fromImpressionsCollector.bind(undefined, sendLabels), 1);
+    var syncTask = submitterSyncTaskFactory(log, postTestImpressionsBulk, impressionsCache, impressionsRefreshRate, DATA_NAME, latencyTracker, fromImpressionsCollector.bind(undefined, sendLabels), 1);
+    // register impressions submitter to be executed when impressions cache is full
+    impressionsCache.setOnFullQueueCb(function () {
+        if (syncTask.isRunning()) {
+            log.info(SUBMITTERS_PUSH_FULL_QUEUE, [DATA_NAME]);
+            syncTask.execute();
+        }
+        // If submitter is stopped (e.g., user consent declined or unknown, or app state offline), we don't send the data.
+        // Data will be sent when submitter is resumed.
+    });
+    return syncTask;
 }