@splitsoftware/splitio-commons 1.15.0 → 1.15.1-rc.1

package/CHANGES.txt

@@ -1,3 +1,7 @@
+1.15.1 (May 28, 2024)
+ - Updated the Redis storage to lazily import the `ioredis` dependency when the storage is created. This prevents errors when the SDK is imported or bundled in a .mjs file, as `ioredis` is a CommonJS module.
+ - Bugfixing - Restored some input validation error logs that were removed in version 1.12.0. The logs inform the user when the `getTreatment(s)` methods are called with an invalid value as feature flag name or flag set name.
+
 1.15.0 (May 13, 2024)
  - Added an optional settings validation parameter to let overwrite the default flag spec version, used by the JS Synchronizer.
 

package/cjs/sdkClient/clientInputValidation.js

@@ -17,26 +17,21 @@ function clientInputValidationDecorator(settings, client, readinessManager) {
     /**
      * Avoid repeating this validations code
      */
-    function validateEvaluationParams(maybeKey, maybeFeatureFlagNameOrNames, maybeAttributes, methodName, maybeFlagSetNameOrNames) {
-        var multi = (0, lang_1.startsWith)(methodName, constants_1.GET_TREATMENTS);
+    function validateEvaluationParams(maybeKey, maybeNameOrNames, maybeAttributes, methodName) {
         var key = (0, inputValidation_1.validateKey)(log, maybeKey, methodName);
-        var splitOrSplits = false;
-        var flagSetOrFlagSets = [];
-        if (maybeFeatureFlagNameOrNames) {
-            splitOrSplits = multi ? (0, inputValidation_1.validateSplits)(log, maybeFeatureFlagNameOrNames, methodName) : (0, inputValidation_1.validateSplit)(log, maybeFeatureFlagNameOrNames, methodName);
-        }
+        var nameOrNames = methodName.indexOf('ByFlagSet') > -1 ?
+            (0, splitFilters_1.validateFlagSets)(log, methodName, maybeNameOrNames, settings.sync.__splitFiltersValidation.groupedFilters.bySet) :
+            (0, lang_1.startsWith)(methodName, constants_1.GET_TREATMENTS) ?
+                (0, inputValidation_1.validateSplits)(log, maybeNameOrNames, methodName) :
+                (0, inputValidation_1.validateSplit)(log, maybeNameOrNames, methodName);
         var attributes = (0, inputValidation_1.validateAttributes)(log, maybeAttributes, methodName);
         var isNotDestroyed = (0, inputValidation_1.validateIfNotDestroyed)(log, readinessManager, methodName);
-        if (maybeFlagSetNameOrNames) {
-            flagSetOrFlagSets = (0, splitFilters_1.validateFlagSets)(log, methodName, maybeFlagSetNameOrNames, settings.sync.__splitFiltersValidation.groupedFilters.bySet);
-        }
-        (0, inputValidation_1.validateIfOperational)(log, readinessManager, methodName, splitOrSplits);
-        var valid = isNotDestroyed && key && (splitOrSplits || flagSetOrFlagSets.length > 0) && attributes !== false;
+        (0, inputValidation_1.validateIfOperational)(log, readinessManager, methodName, nameOrNames);
+        var valid = isNotDestroyed && key && nameOrNames && attributes !== false;
         return {
             valid: valid,
             key: key,
-            splitOrSplits: splitOrSplits,
-            flagSetOrFlagSets: flagSetOrFlagSets,
+            nameOrNames: nameOrNames,
             attributes: attributes
         };
     }
@@ -46,7 +41,7 @@ function clientInputValidationDecorator(settings, client, readinessManager) {
     function getTreatment(maybeKey, maybeFeatureFlagName, maybeAttributes) {
         var params = validateEvaluationParams(maybeKey, maybeFeatureFlagName, maybeAttributes, constants_1.GET_TREATMENT);
         if (params.valid) {
-            return client.getTreatment(params.key, params.splitOrSplits, params.attributes);
+            return client.getTreatment(params.key, params.nameOrNames, params.attributes);
         }
         else {
             return wrapResult(constants_1.CONTROL);
@@ -55,7 +50,7 @@ function clientInputValidationDecorator(settings, client, readinessManager) {
     function getTreatmentWithConfig(maybeKey, maybeFeatureFlagName, maybeAttributes) {
         var params = validateEvaluationParams(maybeKey, maybeFeatureFlagName, maybeAttributes, constants_1.GET_TREATMENT_WITH_CONFIG);
         if (params.valid) {
-            return client.getTreatmentWithConfig(params.key, params.splitOrSplits, params.attributes);
+            return client.getTreatmentWithConfig(params.key, params.nameOrNames, params.attributes);
         }
         else {
             return wrapResult((0, objectAssign_1.objectAssign)({}, constants_1.CONTROL_WITH_CONFIG));
@@ -64,58 +59,58 @@ function clientInputValidationDecorator(settings, client, readinessManager) {
     function getTreatments(maybeKey, maybeFeatureFlagNames, maybeAttributes) {
         var params = validateEvaluationParams(maybeKey, maybeFeatureFlagNames, maybeAttributes, constants_1.GET_TREATMENTS);
         if (params.valid) {
-            return client.getTreatments(params.key, params.splitOrSplits, params.attributes);
+            return client.getTreatments(params.key, params.nameOrNames, params.attributes);
         }
         else {
             var res_1 = {};
-            if (params.splitOrSplits)
-                params.splitOrSplits.forEach(function (split) { return res_1[split] = constants_1.CONTROL; });
+            if (params.nameOrNames)
+                params.nameOrNames.forEach(function (split) { return res_1[split] = constants_1.CONTROL; });
             return wrapResult(res_1);
         }
     }
     function getTreatmentsWithConfig(maybeKey, maybeFeatureFlagNames, maybeAttributes) {
         var params = validateEvaluationParams(maybeKey, maybeFeatureFlagNames, maybeAttributes, constants_1.GET_TREATMENTS_WITH_CONFIG);
         if (params.valid) {
-            return client.getTreatmentsWithConfig(params.key, params.splitOrSplits, params.attributes);
+            return client.getTreatmentsWithConfig(params.key, params.nameOrNames, params.attributes);
         }
         else {
             var res_2 = {};
-            if (params.splitOrSplits)
-                params.splitOrSplits.forEach(function (split) { return res_2[split] = (0, objectAssign_1.objectAssign)({}, constants_1.CONTROL_WITH_CONFIG); });
+            if (params.nameOrNames)
+                params.nameOrNames.forEach(function (split) { return res_2[split] = (0, objectAssign_1.objectAssign)({}, constants_1.CONTROL_WITH_CONFIG); });
             return wrapResult(res_2);
         }
     }
     function getTreatmentsByFlagSets(maybeKey, maybeFlagSets, maybeAttributes) {
-        var params = validateEvaluationParams(maybeKey, undefined, maybeAttributes, constants_1.GET_TREATMENTS_BY_FLAG_SETS, maybeFlagSets);
+        var params = validateEvaluationParams(maybeKey, maybeFlagSets, maybeAttributes, constants_1.GET_TREATMENTS_BY_FLAG_SETS);
         if (params.valid) {
-            return client.getTreatmentsByFlagSets(params.key, params.flagSetOrFlagSets, params.attributes);
+            return client.getTreatmentsByFlagSets(params.key, params.nameOrNames, params.attributes);
         }
         else {
             return wrapResult({});
         }
     }
     function getTreatmentsWithConfigByFlagSets(maybeKey, maybeFlagSets, maybeAttributes) {
-        var params = validateEvaluationParams(maybeKey, undefined, maybeAttributes, constants_1.GET_TREATMENTS_WITH_CONFIG_BY_FLAG_SETS, maybeFlagSets);
+        var params = validateEvaluationParams(maybeKey, maybeFlagSets, maybeAttributes, constants_1.GET_TREATMENTS_WITH_CONFIG_BY_FLAG_SETS);
         if (params.valid) {
-            return client.getTreatmentsWithConfigByFlagSets(params.key, params.flagSetOrFlagSets, params.attributes);
+            return client.getTreatmentsWithConfigByFlagSets(params.key, params.nameOrNames, params.attributes);
         }
         else {
             return wrapResult({});
         }
     }
     function getTreatmentsByFlagSet(maybeKey, maybeFlagSet, maybeAttributes) {
-        var params = validateEvaluationParams(maybeKey, undefined, maybeAttributes, constants_1.GET_TREATMENTS_BY_FLAG_SET, [maybeFlagSet]);
+        var params = validateEvaluationParams(maybeKey, [maybeFlagSet], maybeAttributes, constants_1.GET_TREATMENTS_BY_FLAG_SET);
         if (params.valid) {
-            return client.getTreatmentsByFlagSet(params.key, params.flagSetOrFlagSets[0], params.attributes);
+            return client.getTreatmentsByFlagSet(params.key, params.nameOrNames[0], params.attributes);
         }
         else {
             return wrapResult({});
         }
     }
     function getTreatmentsWithConfigByFlagSet(maybeKey, maybeFlagSet, maybeAttributes) {
-        var params = validateEvaluationParams(maybeKey, undefined, maybeAttributes, constants_1.GET_TREATMENTS_WITH_CONFIG_BY_FLAG_SET, [maybeFlagSet]);
+        var params = validateEvaluationParams(maybeKey, [maybeFlagSet], maybeAttributes, constants_1.GET_TREATMENTS_WITH_CONFIG_BY_FLAG_SET);
         if (params.valid) {
-            return client.getTreatmentsWithConfigByFlagSet(params.key, params.flagSetOrFlagSets[0], params.attributes);
+            return client.getTreatmentsWithConfigByFlagSet(params.key, params.nameOrNames[0], params.attributes);
         }
         else {
             return wrapResult({});

package/cjs/storages/inRedis/index.js

@@ -1,7 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.InRedisStorage = void 0;
-var RedisAdapter_1 = require("./RedisAdapter");
 var KeyBuilder_1 = require("../KeyBuilder");
 var KeyBuilderSS_1 = require("../KeyBuilderSS");
 var SplitsCacheInRedis_1 = require("./SplitsCacheInRedis");
@@ -19,12 +18,15 @@ var utils_1 = require("../utils");
  */
 function InRedisStorage(options) {
     if (options === void 0) { options = {}; }
+    // Lazy loading to prevent error when bundling or importing the SDK in a .mjs file, since ioredis is a CommonJS module.
+    // Redis storage is not supported with .mjs files.
+    var RD = require('./RedisAdapter').RedisAdapter;
     var prefix = (0, KeyBuilder_1.validatePrefix)(options.prefix);
     function InRedisStorageFactory(params) {
         var onReadyCb = params.onReadyCb, settings = params.settings, _a = params.settings, log = _a.log, impressionsMode = _a.sync.impressionsMode;
         var metadata = (0, utils_1.metadataBuilder)(settings);
         var keys = new KeyBuilderSS_1.KeyBuilderSS(prefix, metadata);
-        var redisClient = new RedisAdapter_1.RedisAdapter(log, options.options || {});
+        var redisClient = new RD(log, options.options || {});
         var telemetry = new TelemetryCacheInRedis_1.TelemetryCacheInRedis(log, keys, redisClient);
         var impressionCountsCache = impressionsMode !== constants_1.DEBUG ? new ImpressionCountsCacheInRedis_1.ImpressionCountsCacheInRedis(log, keys.buildImpressionsCountKey(), redisClient) : undefined;
         var uniqueKeysCache = impressionsMode === constants_1.NONE ? new UniqueKeysCacheInRedis_1.UniqueKeysCacheInRedis(log, keys.buildUniqueKeysKey(), redisClient) : undefined;

package/cjs/utils/settingsValidation/splitFilters.js

@@ -192,6 +192,6 @@ function validateFlagSets(log, method, flagSets, flagSetsInConfig) {
             return false;
         });
     }
-    return toReturn;
+    return toReturn.length ? toReturn : false;
 }
 exports.validateFlagSets = validateFlagSets;

package/esm/sdkClient/clientInputValidation.js

@@ -14,26 +14,21 @@ export function clientInputValidationDecorator(settings, client, readinessManage
     /**
      * Avoid repeating this validations code
      */
-    function validateEvaluationParams(maybeKey, maybeFeatureFlagNameOrNames, maybeAttributes, methodName, maybeFlagSetNameOrNames) {
-        var multi = startsWith(methodName, GET_TREATMENTS);
+    function validateEvaluationParams(maybeKey, maybeNameOrNames, maybeAttributes, methodName) {
         var key = validateKey(log, maybeKey, methodName);
-        var splitOrSplits = false;
-        var flagSetOrFlagSets = [];
-        if (maybeFeatureFlagNameOrNames) {
-            splitOrSplits = multi ? validateSplits(log, maybeFeatureFlagNameOrNames, methodName) : validateSplit(log, maybeFeatureFlagNameOrNames, methodName);
-        }
+        var nameOrNames = methodName.indexOf('ByFlagSet') > -1 ?
+            validateFlagSets(log, methodName, maybeNameOrNames, settings.sync.__splitFiltersValidation.groupedFilters.bySet) :
+            startsWith(methodName, GET_TREATMENTS) ?
+                validateSplits(log, maybeNameOrNames, methodName) :
+                validateSplit(log, maybeNameOrNames, methodName);
         var attributes = validateAttributes(log, maybeAttributes, methodName);
         var isNotDestroyed = validateIfNotDestroyed(log, readinessManager, methodName);
-        if (maybeFlagSetNameOrNames) {
-            flagSetOrFlagSets = validateFlagSets(log, methodName, maybeFlagSetNameOrNames, settings.sync.__splitFiltersValidation.groupedFilters.bySet);
-        }
-        validateIfOperational(log, readinessManager, methodName, splitOrSplits);
-        var valid = isNotDestroyed && key && (splitOrSplits || flagSetOrFlagSets.length > 0) && attributes !== false;
+        validateIfOperational(log, readinessManager, methodName, nameOrNames);
+        var valid = isNotDestroyed && key && nameOrNames && attributes !== false;
         return {
             valid: valid,
             key: key,
-            splitOrSplits: splitOrSplits,
-            flagSetOrFlagSets: flagSetOrFlagSets,
+            nameOrNames: nameOrNames,
             attributes: attributes
         };
     }
@@ -43,7 +38,7 @@ export function clientInputValidationDecorator(settings, client, readinessManage
     function getTreatment(maybeKey, maybeFeatureFlagName, maybeAttributes) {
         var params = validateEvaluationParams(maybeKey, maybeFeatureFlagName, maybeAttributes, GET_TREATMENT);
         if (params.valid) {
-            return client.getTreatment(params.key, params.splitOrSplits, params.attributes);
+            return client.getTreatment(params.key, params.nameOrNames, params.attributes);
         }
         else {
             return wrapResult(CONTROL);
@@ -52,7 +47,7 @@ export function clientInputValidationDecorator(settings, client, readinessManage
     function getTreatmentWithConfig(maybeKey, maybeFeatureFlagName, maybeAttributes) {
         var params = validateEvaluationParams(maybeKey, maybeFeatureFlagName, maybeAttributes, GET_TREATMENT_WITH_CONFIG);
         if (params.valid) {
-            return client.getTreatmentWithConfig(params.key, params.splitOrSplits, params.attributes);
+            return client.getTreatmentWithConfig(params.key, params.nameOrNames, params.attributes);
         }
         else {
             return wrapResult(objectAssign({}, CONTROL_WITH_CONFIG));
@@ -61,58 +56,58 @@ export function clientInputValidationDecorator(settings, client, readinessManage
     function getTreatments(maybeKey, maybeFeatureFlagNames, maybeAttributes) {
         var params = validateEvaluationParams(maybeKey, maybeFeatureFlagNames, maybeAttributes, GET_TREATMENTS);
         if (params.valid) {
-            return client.getTreatments(params.key, params.splitOrSplits, params.attributes);
+            return client.getTreatments(params.key, params.nameOrNames, params.attributes);
         }
         else {
             var res_1 = {};
-            if (params.splitOrSplits)
-                params.splitOrSplits.forEach(function (split) { return res_1[split] = CONTROL; });
+            if (params.nameOrNames)
+                params.nameOrNames.forEach(function (split) { return res_1[split] = CONTROL; });
             return wrapResult(res_1);
         }
     }
     function getTreatmentsWithConfig(maybeKey, maybeFeatureFlagNames, maybeAttributes) {
         var params = validateEvaluationParams(maybeKey, maybeFeatureFlagNames, maybeAttributes, GET_TREATMENTS_WITH_CONFIG);
         if (params.valid) {
-            return client.getTreatmentsWithConfig(params.key, params.splitOrSplits, params.attributes);
+            return client.getTreatmentsWithConfig(params.key, params.nameOrNames, params.attributes);
         }
         else {
             var res_2 = {};
-            if (params.splitOrSplits)
-                params.splitOrSplits.forEach(function (split) { return res_2[split] = objectAssign({}, CONTROL_WITH_CONFIG); });
+            if (params.nameOrNames)
+                params.nameOrNames.forEach(function (split) { return res_2[split] = objectAssign({}, CONTROL_WITH_CONFIG); });
             return wrapResult(res_2);
         }
     }
     function getTreatmentsByFlagSets(maybeKey, maybeFlagSets, maybeAttributes) {
-        var params = validateEvaluationParams(maybeKey, undefined, maybeAttributes, GET_TREATMENTS_BY_FLAG_SETS, maybeFlagSets);
+        var params = validateEvaluationParams(maybeKey, maybeFlagSets, maybeAttributes, GET_TREATMENTS_BY_FLAG_SETS);
         if (params.valid) {
-            return client.getTreatmentsByFlagSets(params.key, params.flagSetOrFlagSets, params.attributes);
+            return client.getTreatmentsByFlagSets(params.key, params.nameOrNames, params.attributes);
         }
         else {
             return wrapResult({});
         }
     }
     function getTreatmentsWithConfigByFlagSets(maybeKey, maybeFlagSets, maybeAttributes) {
-        var params = validateEvaluationParams(maybeKey, undefined, maybeAttributes, GET_TREATMENTS_WITH_CONFIG_BY_FLAG_SETS, maybeFlagSets);
+        var params = validateEvaluationParams(maybeKey, maybeFlagSets, maybeAttributes, GET_TREATMENTS_WITH_CONFIG_BY_FLAG_SETS);
         if (params.valid) {
-            return client.getTreatmentsWithConfigByFlagSets(params.key, params.flagSetOrFlagSets, params.attributes);
+            return client.getTreatmentsWithConfigByFlagSets(params.key, params.nameOrNames, params.attributes);
         }
         else {
             return wrapResult({});
         }
     }
     function getTreatmentsByFlagSet(maybeKey, maybeFlagSet, maybeAttributes) {
-        var params = validateEvaluationParams(maybeKey, undefined, maybeAttributes, GET_TREATMENTS_BY_FLAG_SET, [maybeFlagSet]);
+        var params = validateEvaluationParams(maybeKey, [maybeFlagSet], maybeAttributes, GET_TREATMENTS_BY_FLAG_SET);
         if (params.valid) {
-            return client.getTreatmentsByFlagSet(params.key, params.flagSetOrFlagSets[0], params.attributes);
+            return client.getTreatmentsByFlagSet(params.key, params.nameOrNames[0], params.attributes);
         }
         else {
             return wrapResult({});
         }
     }
     function getTreatmentsWithConfigByFlagSet(maybeKey, maybeFlagSet, maybeAttributes) {
-        var params = validateEvaluationParams(maybeKey, undefined, maybeAttributes, GET_TREATMENTS_WITH_CONFIG_BY_FLAG_SET, [maybeFlagSet]);
+        var params = validateEvaluationParams(maybeKey, [maybeFlagSet], maybeAttributes, GET_TREATMENTS_WITH_CONFIG_BY_FLAG_SET);
         if (params.valid) {
-            return client.getTreatmentsWithConfigByFlagSet(params.key, params.flagSetOrFlagSets[0], params.attributes);
+            return client.getTreatmentsWithConfigByFlagSet(params.key, params.nameOrNames[0], params.attributes);
         }
         else {
             return wrapResult({});

package/esm/storages/inRedis/index.js

@@ -1,4 +1,3 @@
-import { RedisAdapter } from './RedisAdapter';
 import { validatePrefix } from '../KeyBuilder';
 import { KeyBuilderSS } from '../KeyBuilderSS';
 import { SplitsCacheInRedis } from './SplitsCacheInRedis';
@@ -16,12 +15,15 @@ import { metadataBuilder } from '../utils';
  */
 export function InRedisStorage(options) {
     if (options === void 0) { options = {}; }
+    // Lazy loading to prevent error when bundling or importing the SDK in a .mjs file, since ioredis is a CommonJS module.
+    // Redis storage is not supported with .mjs files.
+    var RD = require('./RedisAdapter').RedisAdapter;
     var prefix = validatePrefix(options.prefix);
     function InRedisStorageFactory(params) {
         var onReadyCb = params.onReadyCb, settings = params.settings, _a = params.settings, log = _a.log, impressionsMode = _a.sync.impressionsMode;
         var metadata = metadataBuilder(settings);
         var keys = new KeyBuilderSS(prefix, metadata);
-        var redisClient = new RedisAdapter(log, options.options || {});
+        var redisClient = new RD(log, options.options || {});
         var telemetry = new TelemetryCacheInRedis(log, keys, redisClient);
         var impressionCountsCache = impressionsMode !== DEBUG ? new ImpressionCountsCacheInRedis(log, keys.buildImpressionsCountKey(), redisClient) : undefined;
         var uniqueKeysCache = impressionsMode === NONE ? new UniqueKeysCacheInRedis(log, keys.buildUniqueKeysKey(), redisClient) : undefined;

package/esm/utils/settingsValidation/splitFilters.js

@@ -188,5 +188,5 @@ export function validateFlagSets(log, method, flagSets, flagSetsInConfig) {
             return false;
         });
     }
-    return toReturn;
+    return toReturn.length ? toReturn : false;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@splitsoftware/splitio-commons",
-  "version": "1.15.0",
+  "version": "1.15.1-rc.1",
   "description": "Split JavaScript SDK common components",
   "main": "cjs/index.js",
   "module": "esm/index.js",

package/src/sdkClient/clientInputValidation.ts

@@ -31,29 +31,26 @@ export function clientInputValidationDecorator<TClient extends SplitIO.IClient |
   /**
    * Avoid repeating this validations code
    */
-  function validateEvaluationParams(maybeKey: SplitIO.SplitKey, maybeFeatureFlagNameOrNames: string | string[] | undefined, maybeAttributes: SplitIO.Attributes | undefined, methodName: string, maybeFlagSetNameOrNames?: string[]) {
-    const multi = startsWith(methodName, GET_TREATMENTS);
+  function validateEvaluationParams(maybeKey: SplitIO.SplitKey, maybeNameOrNames: string | string[], maybeAttributes: SplitIO.Attributes | undefined, methodName: string) {
     const key = validateKey(log, maybeKey, methodName);
-    let splitOrSplits: string | string[] | false = false;
-    let flagSetOrFlagSets: string[] = [];
-    if (maybeFeatureFlagNameOrNames) {
-      splitOrSplits = multi ? validateSplits(log, maybeFeatureFlagNameOrNames, methodName) : validateSplit(log, maybeFeatureFlagNameOrNames, methodName);
-    }
+
+    const nameOrNames = methodName.indexOf('ByFlagSet') > -1 ?
+      validateFlagSets(log, methodName, maybeNameOrNames as string[], settings.sync.__splitFiltersValidation.groupedFilters.bySet) :
+      startsWith(methodName, GET_TREATMENTS) ?
+        validateSplits(log, maybeNameOrNames, methodName) :
+        validateSplit(log, maybeNameOrNames, methodName);
+
     const attributes = validateAttributes(log, maybeAttributes, methodName);
     const isNotDestroyed = validateIfNotDestroyed(log, readinessManager, methodName);
-    if (maybeFlagSetNameOrNames) {
-      flagSetOrFlagSets = validateFlagSets(log, methodName, maybeFlagSetNameOrNames, settings.sync.__splitFiltersValidation.groupedFilters.bySet);
-    }
 
-    validateIfOperational(log, readinessManager, methodName, splitOrSplits);
+    validateIfOperational(log, readinessManager, methodName, nameOrNames);
 
-    const valid = isNotDestroyed && key && (splitOrSplits || flagSetOrFlagSets.length > 0) && attributes !== false;
+    const valid = isNotDestroyed && key && nameOrNames && attributes !== false;
 
     return {
       valid,
       key,
-      splitOrSplits,
-      flagSetOrFlagSets,
+      nameOrNames,
       attributes
     };
   }
@@ -66,7 +63,7 @@ export function clientInputValidationDecorator<TClient extends SplitIO.IClient |
     const params = validateEvaluationParams(maybeKey, maybeFeatureFlagName, maybeAttributes, GET_TREATMENT);
 
     if (params.valid) {
-      return client.getTreatment(params.key as SplitIO.SplitKey, params.splitOrSplits as string, params.attributes as SplitIO.Attributes | undefined);
+      return client.getTreatment(params.key as SplitIO.SplitKey, params.nameOrNames as string, params.attributes as SplitIO.Attributes | undefined);
     } else {
       return wrapResult(CONTROL);
     }
@@ -76,7 +73,7 @@ export function clientInputValidationDecorator<TClient extends SplitIO.IClient |
     const params = validateEvaluationParams(maybeKey, maybeFeatureFlagName, maybeAttributes, GET_TREATMENT_WITH_CONFIG);
 
     if (params.valid) {
-      return client.getTreatmentWithConfig(params.key as SplitIO.SplitKey, params.splitOrSplits as string, params.attributes as SplitIO.Attributes | undefined);
+      return client.getTreatmentWithConfig(params.key as SplitIO.SplitKey, params.nameOrNames as string, params.attributes as SplitIO.Attributes | undefined);
     } else {
       return wrapResult(objectAssign({}, CONTROL_WITH_CONFIG));
     }
@@ -86,10 +83,10 @@ export function clientInputValidationDecorator<TClient extends SplitIO.IClient |
     const params = validateEvaluationParams(maybeKey, maybeFeatureFlagNames, maybeAttributes, GET_TREATMENTS);
 
     if (params.valid) {
-      return client.getTreatments(params.key as SplitIO.SplitKey, params.splitOrSplits as string[], params.attributes as SplitIO.Attributes | undefined);
+      return client.getTreatments(params.key as SplitIO.SplitKey, params.nameOrNames as string[], params.attributes as SplitIO.Attributes | undefined);
     } else {
       const res: SplitIO.Treatments = {};
-      if (params.splitOrSplits) (params.splitOrSplits as string[]).forEach((split: string) => res[split] = CONTROL);
+      if (params.nameOrNames) (params.nameOrNames as string[]).forEach((split: string) => res[split] = CONTROL);
 
       return wrapResult(res);
     }
@@ -99,50 +96,50 @@ export function clientInputValidationDecorator<TClient extends SplitIO.IClient |
     const params = validateEvaluationParams(maybeKey, maybeFeatureFlagNames, maybeAttributes, GET_TREATMENTS_WITH_CONFIG);
 
     if (params.valid) {
-      return client.getTreatmentsWithConfig(params.key as SplitIO.SplitKey, params.splitOrSplits as string[], params.attributes as SplitIO.Attributes | undefined);
+      return client.getTreatmentsWithConfig(params.key as SplitIO.SplitKey, params.nameOrNames as string[], params.attributes as SplitIO.Attributes | undefined);
     } else {
       const res: SplitIO.TreatmentsWithConfig = {};
-      if (params.splitOrSplits) (params.splitOrSplits as string[]).forEach(split => res[split] = objectAssign({}, CONTROL_WITH_CONFIG));
+      if (params.nameOrNames) (params.nameOrNames as string[]).forEach(split => res[split] = objectAssign({}, CONTROL_WITH_CONFIG));
 
       return wrapResult(res);
     }
   }
 
   function getTreatmentsByFlagSets(maybeKey: SplitIO.SplitKey, maybeFlagSets: string[], maybeAttributes?: SplitIO.Attributes) {
-    const params = validateEvaluationParams(maybeKey, undefined, maybeAttributes, GET_TREATMENTS_BY_FLAG_SETS, maybeFlagSets);
+    const params = validateEvaluationParams(maybeKey, maybeFlagSets, maybeAttributes, GET_TREATMENTS_BY_FLAG_SETS);
 
     if (params.valid) {
-      return client.getTreatmentsByFlagSets(params.key as SplitIO.SplitKey, params.flagSetOrFlagSets as string[], params.attributes as SplitIO.Attributes | undefined);
+      return client.getTreatmentsByFlagSets(params.key as SplitIO.SplitKey, params.nameOrNames as string[], params.attributes as SplitIO.Attributes | undefined);
     } else {
       return wrapResult({});
     }
   }
 
   function getTreatmentsWithConfigByFlagSets(maybeKey: SplitIO.SplitKey, maybeFlagSets: string[], maybeAttributes?: SplitIO.Attributes) {
-    const params = validateEvaluationParams(maybeKey, undefined, maybeAttributes, GET_TREATMENTS_WITH_CONFIG_BY_FLAG_SETS, maybeFlagSets);
+    const params = validateEvaluationParams(maybeKey, maybeFlagSets, maybeAttributes, GET_TREATMENTS_WITH_CONFIG_BY_FLAG_SETS);
 
     if (params.valid) {
-      return client.getTreatmentsWithConfigByFlagSets(params.key as SplitIO.SplitKey, params.flagSetOrFlagSets as string[], params.attributes as SplitIO.Attributes | undefined);
+      return client.getTreatmentsWithConfigByFlagSets(params.key as SplitIO.SplitKey, params.nameOrNames as string[], params.attributes as SplitIO.Attributes | undefined);
     } else {
       return wrapResult({});
     }
   }
 
   function getTreatmentsByFlagSet(maybeKey: SplitIO.SplitKey, maybeFlagSet: string, maybeAttributes?: SplitIO.Attributes) {
-    const params = validateEvaluationParams(maybeKey, undefined, maybeAttributes, GET_TREATMENTS_BY_FLAG_SET, [maybeFlagSet]);
+    const params = validateEvaluationParams(maybeKey, [maybeFlagSet], maybeAttributes, GET_TREATMENTS_BY_FLAG_SET);
 
     if (params.valid) {
-      return client.getTreatmentsByFlagSet(params.key as SplitIO.SplitKey, params.flagSetOrFlagSets[0] as string, params.attributes as SplitIO.Attributes | undefined);
+      return client.getTreatmentsByFlagSet(params.key as SplitIO.SplitKey, (params.nameOrNames as string[])[0], params.attributes as SplitIO.Attributes | undefined);
     } else {
       return wrapResult({});
     }
   }
 
   function getTreatmentsWithConfigByFlagSet(maybeKey: SplitIO.SplitKey, maybeFlagSet: string, maybeAttributes?: SplitIO.Attributes) {
-    const params = validateEvaluationParams(maybeKey, undefined, maybeAttributes, GET_TREATMENTS_WITH_CONFIG_BY_FLAG_SET, [maybeFlagSet]);
+    const params = validateEvaluationParams(maybeKey, [maybeFlagSet], maybeAttributes, GET_TREATMENTS_WITH_CONFIG_BY_FLAG_SET);
 
     if (params.valid) {
-      return client.getTreatmentsWithConfigByFlagSet(params.key as SplitIO.SplitKey, params.flagSetOrFlagSets[0] as string, params.attributes as SplitIO.Attributes | undefined);
+      return client.getTreatmentsWithConfigByFlagSet(params.key as SplitIO.SplitKey, (params.nameOrNames as string[])[0], params.attributes as SplitIO.Attributes | undefined);
     } else {
       return wrapResult({});
     }

package/src/storages/inRedis/index.ts

@@ -1,4 +1,4 @@
-import { RedisAdapter } from './RedisAdapter';
+import type { RedisAdapter } from './RedisAdapter';
 import { IStorageAsync, IStorageAsyncFactory, IStorageFactoryParams } from '../types';
 import { validatePrefix } from '../KeyBuilder';
 import { KeyBuilderSS } from '../KeyBuilderSS';
@@ -23,13 +23,17 @@ export interface InRedisStorageOptions {
  */
 export function InRedisStorage(options: InRedisStorageOptions = {}): IStorageAsyncFactory {
 
+  // Lazy loading to prevent error when bundling or importing the SDK in a .mjs file, since ioredis is a CommonJS module.
+  // Redis storage is not supported with .mjs files.
+  const RD = require('./RedisAdapter').RedisAdapter;
+
   const prefix = validatePrefix(options.prefix);
 
   function InRedisStorageFactory(params: IStorageFactoryParams): IStorageAsync {
     const { onReadyCb, settings, settings: { log, sync: { impressionsMode } } } = params;
     const metadata = metadataBuilder(settings);
     const keys = new KeyBuilderSS(prefix, metadata);
-    const redisClient = new RedisAdapter(log, options.options || {});
+    const redisClient: RedisAdapter = new RD(log, options.options || {});
     const telemetry = new TelemetryCacheInRedis(log, keys, redisClient);
     const impressionCountsCache = impressionsMode !== DEBUG ? new ImpressionCountsCacheInRedis(log, keys.buildImpressionsCountKey(), redisClient) : undefined;
     const uniqueKeysCache = impressionsMode === NONE ? new UniqueKeysCacheInRedis(log, keys.buildUniqueKeysKey(), redisClient) : undefined;

package/src/utils/settingsValidation/splitFilters.ts

@@ -189,7 +189,7 @@ export function validateSplitFilters(log: ILogger, maybeSplitFilters: any, mode:
   return res;
 }
 
-export function validateFlagSets(log: ILogger, method: string, flagSets: string[], flagSetsInConfig: string[]): string[] {
+export function validateFlagSets(log: ILogger, method: string, flagSets: string[], flagSetsInConfig: string[]): string[] | false {
   const sets = validateSplits(log, flagSets, method, 'flag sets', 'flag set');
   let toReturn = sets ? sanitizeFlagSets(log, sets, method) : [];
   if (flagSetsInConfig.length > 0) {
@@ -202,5 +202,5 @@ export function validateFlagSets(log: ILogger, method: string, flagSets: string[
     });
   }
 
-  return toReturn;
+  return toReturn.length ? toReturn : false;
 }

package/types/utils/settingsValidation/splitFilters.d.ts

@@ -14,4 +14,4 @@ import { ILogger } from '../../logger/types';
  * @throws Error if the some of the grouped list of values per filter exceeds the max allowed length
  */
 export declare function validateSplitFilters(log: ILogger, maybeSplitFilters: any, mode: string): ISplitFiltersValidation;
-export declare function validateFlagSets(log: ILogger, method: string, flagSets: string[], flagSetsInConfig: string[]): string[];
+export declare function validateFlagSets(log: ILogger, method: string, flagSets: string[], flagSetsInConfig: string[]): string[] | false;