@splitsoftware/splitio-commons 1.10.1-rc.1 → 1.10.1-rc.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (4) hide show
  1. package/cjs/sync/polling/updaters/splitChangesUpdater.js +2 -4
  2. package/esm/sync/polling/updaters/splitChangesUpdater.js +2 -4
  3. package/package.json +1 -1
  4. package/src/sync/polling/updaters/splitChangesUpdater.ts +2 -3
package/cjs/sync/polling/updaters/splitChangesUpdater.js CHANGED
@@ -143,12 +143,10 @@ function splitChangesUpdaterFactory(log, splitChangesFetcher, splits, segments,
143
143
  splits.removeSplits(mutation.removed),
144
144
  segments.registerSegments(mutation.segments)
145
145
  ]).then(function (flagsChange) {
146
- var triggerSdkUpdate = update(flagsChange);
147
- if (!triggerSdkUpdate)
148
- return true;
146
+ var isThereUpdate = update(flagsChange);
149
147
  if (splitsEventEmitter) {
150
148
  // To emit SDK_SPLITS_ARRIVED for server-side SDK, we must check that all registered segments have been fetched
151
- return Promise.resolve(!splitsEventEmitter.splitsArrived || (since !== splitChanges.till && (isClientSide || checkAllSegmentsExist(segments))))
149
+ return Promise.resolve(!splitsEventEmitter.splitsArrived || (since !== splitChanges.till && isThereUpdate && (isClientSide || checkAllSegmentsExist(segments))))
152
150
  .catch(function () { return false; } /** noop. just to handle a possible `checkAllSegmentsExist` rejection, before emitting SDK event */)
153
151
  .then(function (emitSplitsArrivedEvent) {
154
152
  // emit SDK events
package/esm/sync/polling/updaters/splitChangesUpdater.js CHANGED
@@ -138,12 +138,10 @@ export function splitChangesUpdaterFactory(log, splitChangesFetcher, splits, seg
138
138
  splits.removeSplits(mutation.removed),
139
139
  segments.registerSegments(mutation.segments)
140
140
  ]).then(function (flagsChange) {
141
- var triggerSdkUpdate = update(flagsChange);
142
- if (!triggerSdkUpdate)
143
- return true;
141
+ var isThereUpdate = update(flagsChange);
144
142
  if (splitsEventEmitter) {
145
143
  // To emit SDK_SPLITS_ARRIVED for server-side SDK, we must check that all registered segments have been fetched
146
- return Promise.resolve(!splitsEventEmitter.splitsArrived || (since !== splitChanges.till && (isClientSide || checkAllSegmentsExist(segments))))
144
+ return Promise.resolve(!splitsEventEmitter.splitsArrived || (since !== splitChanges.till && isThereUpdate && (isClientSide || checkAllSegmentsExist(segments))))
147
145
  .catch(function () { return false; } /** noop. just to handle a possible `checkAllSegmentsExist` rejection, before emitting SDK event */)
148
146
  .then(function (emitSplitsArrivedEvent) {
149
147
  // emit SDK events
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@splitsoftware/splitio-commons",
3
- "version": "1.10.1-rc.1",
3
+ "version": "1.10.1-rc.2",
4
4
  "description": "Split Javascript SDK common components",
5
5
  "main": "cjs/index.js",
6
6
  "module": "esm/index.js",
package/src/sync/polling/updaters/splitChangesUpdater.ts CHANGED
@@ -174,11 +174,10 @@ export function splitChangesUpdaterFactory(
174
174
  splits.removeSplits(mutation.removed),
175
175
  segments.registerSegments(mutation.segments)
176
176
  ]).then((flagsChange) => {
177
- const triggerSdkUpdate = update(flagsChange);
178
- if (!triggerSdkUpdate) return true;
177
+ const isThereUpdate = update(flagsChange);
179
178
  if (splitsEventEmitter) {
180
179
  // To emit SDK_SPLITS_ARRIVED for server-side SDK, we must check that all registered segments have been fetched
181
- return Promise.resolve(!splitsEventEmitter.splitsArrived || (since !== splitChanges.till && (isClientSide || checkAllSegmentsExist(segments))))
180
+ return Promise.resolve(!splitsEventEmitter.splitsArrived || (since !== splitChanges.till && isThereUpdate && (isClientSide || checkAllSegmentsExist(segments))))
182
181
  .catch(() => false /** noop. just to handle a possible `checkAllSegmentsExist` rejection, before emitting SDK event */)
183
182
  .then(emitSplitsArrivedEvent => {
184
183
  // emit SDK events