@splitsoftware/splitio-commons 1.0.1-rc.6 → 1.2.1-rc.0

package/esm/logger/messages/info.js

@@ -20,10 +20,10 @@ export var codesInfo = codesWarn.concat([
     [c.SUBMITTERS_PUSH_FULL_EVENTS_QUEUE, c.LOG_PREFIX_SYNC_SUBMITTERS + 'Flushing full events queue and reseting timer.'],
     [c.SUBMITTERS_PUSH, c.LOG_PREFIX_SYNC_SUBMITTERS + 'Pushing %s %s.'],
     [c.STREAMING_REFRESH_TOKEN, c.LOG_PREFIX_SYNC_STREAMING + 'Refreshing streaming token in %s seconds, and connecting streaming in %s seconds.'],
-    [c.STREAMING_RECONNECT, c.LOG_PREFIX_SYNC_STREAMING + 'Attempting to reconnect in %s seconds.'],
-    [c.STREAMING_CONNECTING, c.LOG_PREFIX_SYNC_STREAMING + '%sConnecting to streaming.'],
+    [c.STREAMING_RECONNECT, c.LOG_PREFIX_SYNC_STREAMING + 'Attempting to reconnect streaming in %s seconds.'],
+    [c.STREAMING_CONNECTING, c.LOG_PREFIX_SYNC_STREAMING + 'Connecting streaming.'],
     [c.STREAMING_DISABLED, c.LOG_PREFIX_SYNC_STREAMING + 'Streaming is disabled for given Api key. Switching to polling mode.'],
-    [c.STREAMING_DISCONNECTING, c.LOG_PREFIX_SYNC_STREAMING + 'Disconnecting from streaming.'],
+    [c.STREAMING_DISCONNECTING, c.LOG_PREFIX_SYNC_STREAMING + 'Disconnecting streaming.'],
     [c.SYNC_START_POLLING, c.LOG_PREFIX_SYNC_MANAGER + 'Streaming not available. Starting polling.'],
     [c.SYNC_CONTINUE_POLLING, c.LOG_PREFIX_SYNC_MANAGER + 'Streaming couldn\'t connect. Continue polling.'],
     [c.SYNC_STOP_POLLING, c.LOG_PREFIX_SYNC_MANAGER + 'Streaming (re)connected. Syncing and stopping polling.'],

package/esm/sdkClient/client.js

@@ -95,6 +95,7 @@ export function clientFactory(params) {
         getTreatmentWithConfig: getTreatmentWithConfig,
         getTreatments: getTreatments,
         getTreatmentsWithConfig: getTreatmentsWithConfig,
-        track: track
+        track: track,
+        isBrowserClient: false
     };
 }

package/esm/sdkClient/clientAttributesDecoration.js

@@ -0,0 +1,104 @@
+import { AttributesCacheInMemory } from '../storages/inMemory/AttributesCacheInMemory';
+import { validateAttributesDeep } from '../utils/inputValidation/attributes';
+import { objectAssign } from '../utils/lang/objectAssign';
+/**
+ * Add in memory attributes storage methods and combine them with any attribute received from the getTreatment/s call
+ */
+export function clientAttributesDecoration(log, client) {
+    var attributeStorage = new AttributesCacheInMemory();
+    // Keep a reference to the original methods
+    var clientGetTreatment = client.getTreatment;
+    var clientGetTreatmentWithConfig = client.getTreatmentWithConfig;
+    var clientGetTreatments = client.getTreatments;
+    var clientGetTreatmentsWithConfig = client.getTreatmentsWithConfig;
+    var clientTrack = client.track;
+    function getTreatment(maybeKey, maybeSplit, maybeAttributes) {
+        return clientGetTreatment(maybeKey, maybeSplit, combineAttributes(maybeAttributes));
+    }
+    function getTreatmentWithConfig(maybeKey, maybeSplit, maybeAttributes) {
+        return clientGetTreatmentWithConfig(maybeKey, maybeSplit, combineAttributes(maybeAttributes));
+    }
+    function getTreatments(maybeKey, maybeSplits, maybeAttributes) {
+        return clientGetTreatments(maybeKey, maybeSplits, combineAttributes(maybeAttributes));
+    }
+    function getTreatmentsWithConfig(maybeKey, maybeSplits, maybeAttributes) {
+        return clientGetTreatmentsWithConfig(maybeKey, maybeSplits, combineAttributes(maybeAttributes));
+    }
+    function track(maybeKey, maybeTT, maybeEvent, maybeEventValue, maybeProperties) {
+        return clientTrack(maybeKey, maybeTT, maybeEvent, maybeEventValue, maybeProperties);
+    }
+    function combineAttributes(maybeAttributes) {
+        var storedAttributes = attributeStorage.getAll();
+        if (Object.keys(storedAttributes).length > 0) {
+            return objectAssign({}, storedAttributes, maybeAttributes);
+        }
+        return maybeAttributes;
+    }
+    return objectAssign(client, {
+        getTreatment: getTreatment,
+        getTreatmentWithConfig: getTreatmentWithConfig,
+        getTreatments: getTreatments,
+        getTreatmentsWithConfig: getTreatmentsWithConfig,
+        track: track,
+        /**
+         * Add an attribute to client's in memory attributes storage
+         *
+         * @param {string} attributeName Attrinute name
+         * @param {string, number, boolean, list} attributeValue Attribute value
+         * @returns {boolean} true if the attribute was stored and false otherways
+         */
+        setAttribute: function (attributeName, attributeValue) {
+            var attribute = {};
+            attribute[attributeName] = attributeValue;
+            if (!validateAttributesDeep(log, attribute, 'setAttribute'))
+                return false;
+            log.debug("stored " + attributeValue + " for attribute " + attributeName);
+            return attributeStorage.setAttribute(attributeName, attributeValue);
+        },
+        /**
+         * Returns the attribute with the given key
+         *
+         * @param {string} attributeName Attribute name
+         * @returns {Object} Attribute with the given key
+         */
+        getAttribute: function (attributeName) {
+            log.debug("retrieved attribute " + attributeName);
+            return attributeStorage.getAttribute(attributeName + '');
+        },
+        /**
+         * Add to client's in memory attributes storage the attributes in 'attributes'
+         *
+         * @param {Object} attributes Object with attributes to store
+         * @returns true if attributes were stored an false otherways
+         */
+        setAttributes: function (attributes) {
+            if (!validateAttributesDeep(log, attributes, 'setAttributes'))
+                return false;
+            return attributeStorage.setAttributes(attributes);
+        },
+        /**
+         * Return all the attributes stored in client's in memory attributes storage
+         *
+         * @returns {Object} returns all the stored attributes
+         */
+        getAttributes: function () {
+            return attributeStorage.getAll();
+        },
+        /**
+         * Removes from client's in memory attributes storage the attribute with the given key
+         *
+         * @param {string} attributeName
+         * @returns {boolean} true if attribute was removed and false otherways
+         */
+        removeAttribute: function (attributeName) {
+            log.debug("removed attribute " + attributeName);
+            return attributeStorage.removeAttribute(attributeName + '');
+        },
+        /**
+         * Remove all the stored attributes in the client's in memory attribute storage
+         */
+        clearAttributes: function () {
+            return attributeStorage.clear();
+        }
+    });
+}

package/esm/sdkClient/clientCS.js

@@ -1,4 +1,5 @@
 import { objectAssign } from '../utils/lang/objectAssign';
+import { clientAttributesDecoration } from './clientAttributesDecoration';
 /**
  * Decorator that binds a key and (optionally) a traffic type to client methods
  *
@@ -6,14 +7,16 @@ import { objectAssign } from '../utils/lang/objectAssign';
  * @param key validated split key
  * @param trafficType validated traffic type
  */
-export function clientCSDecorator(client, key, trafficType) {
-    return objectAssign(client, {
+export function clientCSDecorator(log, client, key, trafficType) {
+    var clientCS = clientAttributesDecoration(log, client);
+    return objectAssign(clientCS, {
         // In the client-side API, we bind a key to the client `getTreatment*` methods
-        getTreatment: client.getTreatment.bind(client, key),
-        getTreatmentWithConfig: client.getTreatmentWithConfig.bind(client, key),
-        getTreatments: client.getTreatments.bind(client, key),
-        getTreatmentsWithConfig: client.getTreatmentsWithConfig.bind(client, key),
+        getTreatment: clientCS.getTreatment.bind(clientCS, key),
+        getTreatmentWithConfig: clientCS.getTreatmentWithConfig.bind(clientCS, key),
+        getTreatments: clientCS.getTreatments.bind(clientCS, key),
+        getTreatmentsWithConfig: clientCS.getTreatmentsWithConfig.bind(clientCS, key),
         // Key is bound to the `track` method. Same thing happens with trafficType but only if provided
-        track: trafficType ? client.track.bind(client, key, trafficType) : client.track.bind(client, key)
+        track: trafficType ? clientCS.track.bind(clientCS, key, trafficType) : clientCS.track.bind(clientCS, key),
+        isBrowserClient: true
     });
 }

package/esm/sdkClient/sdkClientMethodCS.js

@@ -20,7 +20,7 @@ export function sdkClientMethodCSFactory(params) {
     // `false` value is used as binded key of the default client, but trafficType is ignored
     // @TODO handle as a non-recoverable error
     var validKey = validateKey(log, key, method);
-    var mainClientInstance = clientCSDecorator(sdkClientFactory(params), // @ts-ignore
+    var mainClientInstance = clientCSDecorator(log, sdkClientFactory(params), // @ts-ignore
     validKey);
     var parsedDefaultKey = keyParser(key);
     var defaultInstanceId = buildInstanceId(parsedDefaultKey);
@@ -55,7 +55,7 @@ export function sdkClientMethodCSFactory(params) {
             var sharedSyncManager = syncManager && sharedStorage && syncManager.shared(matchingKey, sharedSdkReadiness_1.readinessManager, sharedStorage);
             // As shared clients reuse all the storage information, we don't need to check here if we
             // will use offline or online mode. We should stick with the original decision.
-            clientInstances[instanceId] = clientCSDecorator(sdkClientFactory(objectAssign({}, params, {
+            clientInstances[instanceId] = clientCSDecorator(log, sdkClientFactory(objectAssign({}, params, {
                 sdkReadinessManager: sharedSdkReadiness_1,
                 storage: sharedStorage || storage,
                 syncManager: sharedSyncManager,

package/esm/sdkClient/sdkClientMethodCSWithTT.js

@@ -26,7 +26,7 @@ export function sdkClientMethodCSFactory(params) {
     if (trafficType !== undefined) {
         validTrafficType = validateTrafficType(log, trafficType, method);
     }
-    var mainClientInstance = clientCSDecorator(sdkClientFactory(params), // @ts-ignore
+    var mainClientInstance = clientCSDecorator(log, sdkClientFactory(params), // @ts-ignore
     validKey, validTrafficType);
     var parsedDefaultKey = keyParser(key);
     var defaultInstanceId = buildInstanceId(parsedDefaultKey, trafficType);
@@ -68,7 +68,7 @@ export function sdkClientMethodCSFactory(params) {
             var sharedSyncManager = syncManager && sharedStorage && syncManager.shared(matchingKey, sharedSdkReadiness_1.readinessManager, sharedStorage);
             // As shared clients reuse all the storage information, we don't need to check here if we
             // will use offline or online mode. We should stick with the original decision.
-            clientInstances[instanceId] = clientCSDecorator(sdkClientFactory(objectAssign({}, params, {
+            clientInstances[instanceId] = clientCSDecorator(log, sdkClientFactory(objectAssign({}, params, {
                 sdkReadinessManager: sharedSdkReadiness_1,
                 storage: sharedStorage || storage,
                 syncManager: sharedSyncManager,

package/esm/sdkFactory/index.js

@@ -29,8 +29,8 @@ export function sdkFactory(params) {
         splitFiltersValidation: settings.sync.__splitFiltersValidation,
         // ATM, only used by PluggableStorage
         mode: settings.mode,
-        // Callback used to emit SDK_READY in consumer mode, where `syncManagerFactory` is undefined
-        // or only instantiates submitters, and therefore it is not able to emit readiness events.
+        // Callback used to emit SDK_READY in consumer mode, where `syncManagerFactory` is undefined,
+        // or partial consumer mode, where it only has submitters, and therefore it doesn't emit readiness events.
         onReadyCb: function (error) {
             if (error)
                 return; // Don't emit SDK_READY if storage failed to connect. Error message is logged by wrapperAdapter

package/esm/services/splitHttpClient.js

@@ -43,7 +43,7 @@ export function splitHttpClientFactory(settings, getFetch, getOptions) {
             return response;
         })
             .catch(function (error) {
-            var resp = error.response;
+            var resp = error && error.response;
             var msg = '';
             if (resp) { // An HTTP error
                 switch (resp.status) {

package/esm/storages/inMemory/AttributesCacheInMemory.js

@@ -0,0 +1,67 @@
+import { objectAssign } from '../../utils/lang/objectAssign';
+var AttributesCacheInMemory = /** @class */ (function () {
+    function AttributesCacheInMemory() {
+        this.attributesCache = {};
+    }
+    /**
+     * Create or update the value for the given attribute
+     *
+     * @param {string} attributeName attribute name
+     * @param {Object} attributeValue attribute value
+     * @returns {boolean} the attribute was stored
+     */
+    AttributesCacheInMemory.prototype.setAttribute = function (attributeName, attributeValue) {
+        this.attributesCache[attributeName] = attributeValue;
+        return true;
+    };
+    /**
+     * Retrieves the value of a given attribute
+     *
+     * @param {string} attributeName attribute name
+     * @returns {Object?} stored attribute value
+     */
+    AttributesCacheInMemory.prototype.getAttribute = function (attributeName) {
+        return this.attributesCache[attributeName];
+    };
+    /**
+     * Create or update all the given attributes
+     *
+     * @param {[string, Object]} attributes attributes to create or update
+     * @returns {boolean} attributes were stored
+     */
+    AttributesCacheInMemory.prototype.setAttributes = function (attributes) {
+        this.attributesCache = objectAssign(this.attributesCache, attributes);
+        return true;
+    };
+    /**
+     * Retrieve the full attributes map
+     *
+     * @returns {Map<string, Object>} stored attributes
+     */
+    AttributesCacheInMemory.prototype.getAll = function () {
+        return this.attributesCache;
+    };
+    /**
+     * Removes a given attribute from the map
+     *
+     * @param {string} attributeName attribute to remove
+     * @returns {boolean} attribute removed
+     */
+    AttributesCacheInMemory.prototype.removeAttribute = function (attributeName) {
+        if (Object.keys(this.attributesCache).indexOf(attributeName) >= 0) {
+            delete this.attributesCache[attributeName];
+            return true;
+        }
+        return false;
+    };
+    /**
+     * Clears all attributes stored in the SDK
+     *
+     */
+    AttributesCacheInMemory.prototype.clear = function () {
+        this.attributesCache = {};
+        return true;
+    };
+    return AttributesCacheInMemory;
+}());
+export { AttributesCacheInMemory };

package/esm/sync/polling/updaters/splitChangesUpdater.js

@@ -133,10 +133,13 @@ export function splitChangesUpdaterFactory(log, splitChangesFetcher, splits, seg
                 }
                 return false;
             });
-            // After triggering the requests, if we have cached splits information let's notify that.
+            // After triggering the requests, if we have cached splits information let's notify that to emit SDK_READY_FROM_CACHE.
+            // Wrapping in a promise since checkCache can be async.
             if (splitsEventEmitter && startingUp) {
-                Promise.resolve(splits.checkCache()).then(function (cacheReady) { if (cacheReady)
-                    splitsEventEmitter.emit(SDK_SPLITS_CACHE_LOADED); });
+                Promise.resolve(splits.checkCache()).then(function (isCacheReady) {
+                    if (isCacheReady)
+                        splitsEventEmitter.emit(SDK_SPLITS_CACHE_LOADED);
+                });
             }
             return fetcherPromise;
         }

package/esm/sync/streaming/AuthClient/index.js

@@ -13,8 +13,7 @@ export function authenticateFactory(fetchAuth) {
      * @param {string[] | undefined} userKeys set of user Keys to track MY_SEGMENTS_CHANGES. It is undefined for server-side API.
      */
     return function authenticate(userKeys) {
-        var authPromise = fetchAuth(userKeys); // errors handled by fetchAuth service
-        return authPromise
+        return fetchAuth(userKeys)
             .then(function (resp) { return resp.json(); })
             .then(function (json) {
             if (json.token) { // empty token when `"pushEnabled": false`

package/esm/sync/streaming/pushManager.js

@@ -22,7 +22,7 @@ import { hash64 } from '../../utils/murmur3/murmur3_64';
 export function pushManagerFactory(pollingManager, storage, readiness, fetchAuth, platform, settings) {
     // `userKey` is the matching key of main client in client-side SDK.
     // It can be used to check if running on client-side or server-side SDK.
-    var userKey = settings.core.key ? getMatching(settings.core.key) : undefined; //
+    var userKey = settings.core.key ? getMatching(settings.core.key) : undefined;
     var log = settings.log;
     var sseClient;
     try {
@@ -39,7 +39,8 @@ export function pushManagerFactory(pollingManager, storage, readiness, fetchAuth
     var sseHandler = SSEHandlerFactory(log, pushEmitter);
     sseClient.setEventHandler(sseHandler);
     // init workers
-    var segmentsUpdateWorker = userKey ? new MySegmentsUpdateWorker(pollingManager.segmentsSyncTask) : new SegmentsUpdateWorker(storage.segments, pollingManager.segmentsSyncTask);
+    // MySegmentsUpdateWorker (client-side) are initiated in `add` method
+    var segmentsUpdateWorker = userKey ? undefined : new SegmentsUpdateWorker(storage.segments, pollingManager.segmentsSyncTask);
     // For server-side we pass the segmentsSyncTask, used by SplitsUpdateWorker to fetch new segments
     var splitsUpdateWorker = new SplitsUpdateWorker(storage.splits, pollingManager.splitsSyncTask, readiness.splits, userKey ? undefined : pollingManager.segmentsSyncTask);
     // [Only for client-side] map of hashes to user keys, to dispatch MY_SEGMENTS_UPDATE events to the corresponding MySegmentsUpdateWorker
@@ -47,11 +48,6 @@ export function pushManagerFactory(pollingManager, storage, readiness, fetchAuth
     // [Only for client-side] map of user keys to their corresponding hash64 and MySegmentsUpdateWorkers.
     // Hash64 is used to process MY_SEGMENTS_UPDATE_V2 events and dispatch actions to the corresponding MySegmentsUpdateWorker.
     var clients = {};
-    if (userKey) {
-        var hash = hashUserKey(userKey);
-        userKeyHashes[hash] = userKey;
-        clients[userKey] = { hash64: hash64(userKey), worker: segmentsUpdateWorker };
-    }
     // [Only for client-side] variable to flag that a new client was added. It is needed to reconnect streaming.
     var connectForNewClient = false;
     // flag that indicates if `stop/disconnectPush` was called, either by the SyncManager, when the client is destroyed, or due to a PUSH_NONRETRYABLE_ERROR error.
@@ -87,7 +83,8 @@ export function pushManagerFactory(pollingManager, storage, readiness, fetchAuth
         // Guard condition in case `stop/disconnectPush` has been called (e.g., calling SDK destroy, or app signal close/background)
         if (disconnected)
             return;
-        log.info(STREAMING_CONNECTING, [disconnected === undefined ? '' : 'Re-']);
+        // @TODO distinguish log for 'Connecting' (1st time) and 'Re-connecting'
+        log.info(STREAMING_CONNECTING);
         disconnected = false;
         var userKeys = userKey ? Object.keys(clients) : undefined;
         authenticate(userKeys).then(function (authData) {
@@ -257,33 +254,40 @@ export function pushManagerFactory(pollingManager, storage, readiness, fetchAuth
     return objectAssign(
     // Expose Event Emitter functionality and Event constants
     Object.create(pushEmitter), {
-        // Expose functionality for starting and stoping push mode:
-        stop: disconnectPush,
+        // Stop/pause push mode
+        stop: function () {
+            disconnectPush(); // `handleNonRetryableError` cannot be used as `stop`, because it emits PUSH_SUBSYSTEM_DOWN event, which starts polling.
+            if (userKey)
+                this.remove(userKey); // Necessary to properly resume streaming in client-side (e.g., RN SDK transition to foreground).
+        },
+        // Start/resume push mode
         start: function () {
             // Guard condition to avoid calling `connectPush` again if the `start` method is called multiple times or if push has been disabled.
             if (disabled || disconnected === false)
                 return;
             disconnected = false;
-            // Run in next event-loop cycle for optimization on client-side: if multiple clients are created in the same cycle than the factory, only one authentication is performed.
-            setTimeout(connectPush);
+            if (userKey)
+                this.add(userKey, pollingManager.segmentsSyncTask); // client-side
+            else
+                setTimeout(connectPush); // server-side runs in next cycle as in client-side, for consistency with client-side
         },
         // [Only for client-side]
         add: function (userKey, mySegmentsSyncTask) {
-            clients[userKey] = { hash64: hash64(userKey), worker: new MySegmentsUpdateWorker(mySegmentsSyncTask) };
             var hash = hashUserKey(userKey);
             if (!userKeyHashes[hash]) {
                 userKeyHashes[hash] = userKey;
+                clients[userKey] = { hash64: hash64(userKey), worker: new MySegmentsUpdateWorker(mySegmentsSyncTask) };
                 connectForNewClient = true; // we must reconnect on start, to listen the channel for the new user key
+                // Reconnects in case of a new client.
+                // Run in next event-loop cycle to save authentication calls
+                // in case multiple clients are created in the current cycle.
+                setTimeout(function checkForReconnect() {
+                    if (connectForNewClient) {
+                        connectForNewClient = false;
+                        connectPush();
+                    }
+                }, 0);
             }
-            // Reconnects in case of a new client.
-            // Run in next event-loop cycle to save authentication calls
-            // in case the user is creating several clients in the current cycle.
-            setTimeout(function checkForReconnect() {
-                if (connectForNewClient) {
-                    connectForNewClient = false;
-                    connectPush();
-                }
-            }, 0);
         },
         // [Only for client-side]
         remove: function (userKey) {

package/esm/sync/syncManagerOnline.js

@@ -27,12 +27,12 @@ export function syncManagerOnlineFactory(pollingManagerFactory, pushManagerFacto
         var submitter = submitterManagerFactory(settings, storage, splitApi);
         /** Sync Manager logic */
         function startPolling() {
-            if (!pollingManager.isRunning()) {
-                log.info(SYNC_START_POLLING);
-                pollingManager.start();
+            if (pollingManager.isRunning()) {
+                log.info(SYNC_CONTINUE_POLLING);
             }
             else {
-                log.info(SYNC_CONTINUE_POLLING);
+                log.info(SYNC_START_POLLING);
+                pollingManager.start();
             }
         }
         function stopPollingAndSyncAll() {
@@ -55,6 +55,9 @@ export function syncManagerOnlineFactory(pollingManagerFactory, pushManagerFacto
              * Method used to start the syncManager for the first time, or resume it after being stopped.
              */
             start: function () {
+                if (running)
+                    return;
+                running = true;
                 // start syncing splits and segments
                 if (pollingManager) {
                     if (pushManager) {
@@ -70,13 +73,16 @@ export function syncManagerOnlineFactory(pollingManagerFactory, pushManagerFacto
                     }
                 }
                 // start periodic data recording (events, impressions, telemetry).
-                submitter && submitter.start();
-                running = true;
+                if (submitter)
+                    submitter.start();
             },
             /**
              * Method used to stop/pause the syncManager.
              */
             stop: function () {
+                if (!running)
+                    return;
+                running = false;
                 // stop syncing
                 if (pushManager)
                     pushManager.stop();
@@ -85,7 +91,6 @@ export function syncManagerOnlineFactory(pollingManagerFactory, pushManagerFacto
                 // stop periodic data recording (events, impressions, telemetry).
                 if (submitter)
                     submitter.stop();
-                running = false;
             },
             isRunning: function () {
                 return running;

package/esm/utils/inputValidation/attribute.js

@@ -0,0 +1,16 @@
+import { isString, isFiniteNumber, isBoolean } from '../../utils/lang';
+export function validateAttribute(log, attributeKey, attributeValue, method) {
+    if (!isString(attributeKey) || attributeKey.length === 0) {
+        log.warn(method + ": you passed an invalid attribute name, attribute name must be a non-empty string.");
+        return false;
+    }
+    var isStringVal = isString(attributeValue);
+    var isFiniteVal = isFiniteNumber(attributeValue);
+    var isBoolVal = isBoolean(attributeValue);
+    var isArrayVal = Array.isArray(attributeValue);
+    if (!(isStringVal || isFiniteVal || isBoolVal || isArrayVal)) { // If it's not of valid type.
+        log.warn(method + ": you passed an invalid attribute value for " + attributeKey + ". Acceptable types are: string, number, boolean and array of strings.");
+        return false;
+    }
+    return true;
+}

package/esm/utils/inputValidation/attributes.js

@@ -1,4 +1,5 @@
 import { isObject } from '../lang';
+import { validateAttribute } from './attribute';
 import { ERROR_NOT_PLAIN_OBJECT } from '../../logger/constants';
 export function validateAttributes(log, maybeAttrs, method) {
     // Attributes are optional
@@ -7,3 +8,13 @@ export function validateAttributes(log, maybeAttrs, method) {
     log.error(ERROR_NOT_PLAIN_OBJECT, [method, 'attributes']);
     return false;
 }
+export function validateAttributesDeep(log, maybeAttributes, method) {
+    if (!validateAttributes(log, maybeAttributes, method))
+        return false;
+    var result = true;
+    Object.keys(maybeAttributes).forEach(function (attributeKey) {
+        if (!validateAttribute(log, attributeKey, maybeAttributes[attributeKey], method))
+            result = false;
+    });
+    return result;
+}

package/esm/utils/murmur3/legacy.js

@@ -0,0 +1,39 @@
+// Deprecated hashing function, used for split bucketing. Replaced by murmur3
+//
+// JAVA reference implementation for the hashing function.
+//
+// int h = 0;
+// for (int i = 0; i < key.length(); i++) {
+//     h = 31 * h + key.charAt(i);
+// }
+// return h ^ seed; // XOR the hash and seed
+//
+function ToInteger(x) {
+    x = Number(x);
+    return x < 0 ? Math.ceil(x) : Math.floor(x);
+}
+function modulo(a, b) {
+    return a - Math.floor(a / b) * b;
+}
+function ToUint32(x) {
+    return modulo(ToInteger(x), Math.pow(2, 32));
+}
+function ToInt32(x) {
+    var uint32 = ToUint32(x);
+    if (uint32 >= Math.pow(2, 31)) {
+        return uint32 - Math.pow(2, 32);
+    }
+    else {
+        return uint32;
+    }
+}
+export function hash(str, seed) {
+    var h = 0;
+    for (var i = 0; i < str.length; i++) {
+        h = ToInt32(ToInt32(31 * h) + str.charCodeAt(i));
+    }
+    return ToInt32(h ^ seed);
+}
+export function bucket(str, seed) {
+    return Math.abs(hash(str, seed) % 100) + 1;
+}

package/esm/utils/promise/timeout.js

@@ -3,7 +3,7 @@ export function timeout(ms, promise) {
         return promise;
     return new Promise(function (resolve, reject) {
         var tid = setTimeout(function () {
-            reject(new Error("Operation timed out because it exceeded the configured time limit of " + ms + "ms."));
+            reject(new Error("Operation timed out because it exceeded the configured time limit of " + ms + " ms."));
         }, ms);
         promise.then(function (res) {
             clearTimeout(tid);

package/esm/utils/settingsValidation/index.js

@@ -100,7 +100,7 @@ export function settingsValidation(config, validationParams) {
     // Startup periods
     startup.requestTimeoutBeforeReady = fromSecondsToMillis(startup.requestTimeoutBeforeReady);
     startup.readyTimeout = fromSecondsToMillis(startup.readyTimeout);
-    startup.eventsFirstPushWindow = fromSecondsToMillis(withDefaults.startup.eventsFirstPushWindow);
+    startup.eventsFirstPushWindow = fromSecondsToMillis(startup.eventsFirstPushWindow);
     // ensure a valid SDK mode
     // @ts-ignore, modify readonly prop
     withDefaults.mode = mode(withDefaults.core.authorizationKey, withDefaults.mode);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@splitsoftware/splitio-commons",
-  "version": "1.0.1-rc.6",
+  "version": "1.2.1-rc.0",
   "description": "Split Javascript SDK common components",
   "main": "cjs/index.js",
   "module": "esm/index.js",
@@ -64,7 +64,7 @@
     "jest-localstorage-mock": "^2.4.3",
     "js-yaml": "^3.14.0",
     "lodash": "^4.17.21",
-    "node-fetch": "^2.6.1",
+    "node-fetch": "^2.6.7",
     "redis-server": "1.2.2",
     "rimraf": "^3.0.2",
     "ts-jest": "^27.0.5",

package/src/logger/messages/info.ts

@@ -23,10 +23,10 @@ export const codesInfo: [number, string][] = codesWarn.concat([
   [c.SUBMITTERS_PUSH_FULL_EVENTS_QUEUE, c.LOG_PREFIX_SYNC_SUBMITTERS + 'Flushing full events queue and reseting timer.'],
   [c.SUBMITTERS_PUSH, c.LOG_PREFIX_SYNC_SUBMITTERS + 'Pushing %s %s.'],
   [c.STREAMING_REFRESH_TOKEN, c.LOG_PREFIX_SYNC_STREAMING + 'Refreshing streaming token in %s seconds, and connecting streaming in %s seconds.'],
-  [c.STREAMING_RECONNECT, c.LOG_PREFIX_SYNC_STREAMING + 'Attempting to reconnect in %s seconds.'],
-  [c.STREAMING_CONNECTING, c.LOG_PREFIX_SYNC_STREAMING + '%sConnecting to streaming.'],
+  [c.STREAMING_RECONNECT, c.LOG_PREFIX_SYNC_STREAMING + 'Attempting to reconnect streaming in %s seconds.'],
+  [c.STREAMING_CONNECTING, c.LOG_PREFIX_SYNC_STREAMING + 'Connecting streaming.'],
   [c.STREAMING_DISABLED, c.LOG_PREFIX_SYNC_STREAMING + 'Streaming is disabled for given Api key. Switching to polling mode.'],
-  [c.STREAMING_DISCONNECTING, c.LOG_PREFIX_SYNC_STREAMING + 'Disconnecting from streaming.'],
+  [c.STREAMING_DISCONNECTING, c.LOG_PREFIX_SYNC_STREAMING + 'Disconnecting streaming.'],
   [c.SYNC_START_POLLING, c.LOG_PREFIX_SYNC_MANAGER + 'Streaming not available. Starting polling.'],
   [c.SYNC_CONTINUE_POLLING, c.LOG_PREFIX_SYNC_MANAGER + 'Streaming couldn\'t connect. Continue polling.'],
   [c.SYNC_STOP_POLLING, c.LOG_PREFIX_SYNC_MANAGER + 'Streaming (re)connected. Syncing and stopping polling.'],

package/src/sdkClient/client.ts

@@ -123,6 +123,7 @@ export function clientFactory(params: IClientFactoryParams): SplitIO.IClient | S
     getTreatmentWithConfig,
     getTreatments,
     getTreatmentsWithConfig,
-    track
+    track,
+    isBrowserClient: false
   } as SplitIO.IClient | SplitIO.IAsyncClient;
 }