@spinnaker/google 0.1.7 → 0.1.8

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@spinnaker/google",
   "license": "Apache-2.0",
-  "version": "0.1.7",
+  "version": "0.1.8",
   "module": "dist/index.js",
   "typings": "dist/index.d.ts",
   "scripts": {
@@ -13,7 +13,7 @@
     "lib": "npm run build"
   },
   "dependencies": {
-    "@spinnaker/core": "^0.19.1",
+    "@spinnaker/core": "^0.19.2",
     "@uirouter/angularjs": "1.0.26",
     "angular": "1.6.10",
     "angular-ui-bootstrap": "2.5.0",
@@ -37,5 +37,5 @@
     "shx": "0.3.3",
     "typescript": "4.3.5"
   },
-  "gitHead": "8b967e5f649a2373d704ec1d7d9f790ab1e1802e"
+  "gitHead": "3ea12b48839ff145c4a602d489507f317b06f856"
 }

package/src/serverGroup/details/resize/resizeAutoscalingPolicy.component.js

@@ -24,33 +24,37 @@ angular
       '$scope',
       'gceAutoscalingPolicyWriter',
       function ($scope, gceAutoscalingPolicyWriter) {
-        const newPolicyBounds = ['newMinNumReplicas', 'newMaxNumReplicas'];
-        newPolicyBounds.forEach((prop) => (this.command[prop] = null));
+        // In Angular 1.7 Directive bindings were removed in the constructor, default values now must be instantiated within $onInit
+        // See https://docs.angularjs.org/guide/migration#-compile- and https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$compile
+        this.$onInit = () => {
+          const newPolicyBounds = ['newMinNumReplicas', 'newMaxNumReplicas'];
+          newPolicyBounds.forEach((prop) => (this.command[prop] = null));
 
-        angular.extend(this.formMethods, {
-          formIsValid: () =>
-            _.every([
-              _.chain(newPolicyBounds)
-                .map((bound) => this.command[bound] !== null)
-                .every()
-                .value(),
-              $scope.resizeAutoscalingPolicyForm.$valid,
-            ]),
-          submitMethod: () => {
-            return gceAutoscalingPolicyWriter.upsertAutoscalingPolicy(
-              this.application,
-              this.serverGroup,
-              {
-                minNumReplicas: this.command.newMinNumReplicas,
-                maxNumReplicas: this.command.newMaxNumReplicas,
-              },
-              {
-                reason: this.command.reason,
-                interestingHealthProviderNames: this.command.interestingHealthProviderNames,
-              },
-            );
-          },
-        });
+          angular.extend(this.formMethods, {
+            formIsValid: () =>
+              _.every([
+                _.chain(newPolicyBounds)
+                  .map((bound) => this.command[bound] !== null)
+                  .every()
+                  .value(),
+                $scope.resizeAutoscalingPolicyForm.$valid,
+              ]),
+            submitMethod: () => {
+              return gceAutoscalingPolicyWriter.upsertAutoscalingPolicy(
+                this.application,
+                this.serverGroup,
+                {
+                  minNumReplicas: this.command.newMinNumReplicas,
+                  maxNumReplicas: this.command.newMaxNumReplicas,
+                },
+                {
+                  reason: this.command.reason,
+                  interestingHealthProviderNames: this.command.interestingHealthProviderNames,
+                },
+              );
+            },
+          });
+        };
       },
     ],
   });

package/src/serverGroup/details/resize/resizeCapacity.component.js

@@ -22,21 +22,25 @@ angular
       '$scope',
       'serverGroupWriter',
       function ($scope, serverGroupWriter) {
-        this.command.newSize = null;
+        // In Angular 1.7 Directive bindings were removed in the constructor, default values now must be instantiated within $onInit
+        // See https://docs.angularjs.org/guide/migration#-compile- and https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$compile
+        this.$onInit = () => {
+          this.command.newSize = null;
 
-        angular.extend(this.formMethods, {
-          formIsValid: () => _.every([this.command.newSize !== null, $scope.resizeCapacityForm.$valid]),
-          submitMethod: () => {
-            return serverGroupWriter.resizeServerGroup(this.serverGroup, this.application, {
-              capacity: { min: this.command.newSize, max: this.command.newSize, desired: this.command.newSize },
-              serverGroupName: this.serverGroup.name,
-              targetSize: this.command.newSize,
-              region: this.serverGroup.region,
-              interestingHealthProviderNames: this.command.interestingHealthProviderNames,
-              reason: this.command.reason,
-            });
-          },
-        });
+          angular.extend(this.formMethods, {
+            formIsValid: () => _.every([this.command.newSize !== null, $scope.resizeCapacityForm.$valid]),
+            submitMethod: () => {
+              return serverGroupWriter.resizeServerGroup(this.serverGroup, this.application, {
+                capacity: { min: this.command.newSize, max: this.command.newSize, desired: this.command.newSize },
+                serverGroupName: this.serverGroup.name,
+                targetSize: this.command.newSize,
+                region: this.serverGroup.region,
+                interestingHealthProviderNames: this.command.interestingHealthProviderNames,
+                reason: this.command.reason,
+              });
+            },
+          });
+        };
       },
     ],
   });

package/src/serverGroup/details/resize/resizeServerGroup.controller.spec.js

@@ -18,13 +18,6 @@ describe('Controller: gceResizeServerGroupCtrl', function () {
     ),
   );
 
-  // https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$compile
-  beforeEach(
-    window.module(($compileProvider) => {
-      $compileProvider.preAssignBindingsEnabled(true);
-    }),
-  );
-
   beforeEach(
     window.inject(function (
       _$controller_,