@spinnaker/eslint-plugin 2026.0.1 → 2026.1.0

package/README.md

@@ -5,19 +5,33 @@ This package is an ESLint plugin containing:
 - A base ESLint config
   - Parser configured for typescript
   - A set of default plugins, e.g. `react-hooks` plugin
-  - Recommended rule sets, e.g. `prettier/@typescript-eslint`
+  - Recommended rule sets, e.g. `prettier`, `@typescript-eslint/recommended`
     - Specific from the recommended rule sets are disabled
 - Custom ESLint rules specific to Spinnaker
 
 ### Use
 
-To use the rules, create a `.eslintrc.js` containing:
+This plugin requires **ESLint 9+** and uses the flat config format.
+
+To use the rules, create an `eslint.config.js` containing:
 
 ```js
-module.exports = {
-  plugins: ['@spinnaker/eslint-plugin'],
-  extends: ['plugin:@spinnaker/base'],
-};
+const { defineConfig } = require('eslint/config');
+const spinnakerEslintPlugin = require('@spinnaker/eslint-plugin');
+const { FlatCompat } = require('@eslint/eslintrc');
+const js = require('@eslint/js');
+
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+});
+
+module.exports = defineConfig([{
+  plugins: {
+    '@spinnaker': spinnakerEslintPlugin,
+  },
+  extends: compat.extends('plugin:@spinnaker/base'),
+}]);
 ```
 
 ## Creating a custom lint rule

package/base.config.js

@@ -1,86 +1,137 @@
-module.exports = {
-  parser: '@typescript-eslint/parser',
-  parserOptions: { sourceType: 'module' },
-  plugins: ['@typescript-eslint', '@spinnaker/eslint-plugin', 'react-hooks'],
-  extends: ['eslint:recommended', 'prettier', 'prettier/@typescript-eslint', 'plugin:@typescript-eslint/recommended'],
-  rules: {
-    '@spinnaker/import-sort': 1,
-    '@spinnaker/api-deprecation': 2,
-    '@spinnaker/api-no-slashes': 2,
-    '@spinnaker/api-no-unused-chaining': 2,
-    '@spinnaker/import-from-alias-not-npm': 2,
-    '@spinnaker/import-from-npm-not-alias': 2,
-    '@spinnaker/import-from-npm-not-relative': 2,
-    '@spinnaker/import-from-presentation-not-core': 2,
-    '@spinnaker/import-relative-within-subpackage': 2,
-    '@spinnaker/migrate-to-mock-http-client': 2,
-    '@spinnaker/ng-no-component-class': 2,
-    '@spinnaker/ng-no-module-export': 2,
-    '@spinnaker/ng-no-require-angularjs': 2,
-    '@spinnaker/ng-no-require-module-deps': 2,
-    '@spinnaker/ng-strictdi': 'off', // TODO: this rule seems to be broken, needs to be rewritten to avoid an error
-    '@spinnaker/prefer-promise-like': 1,
-    '@spinnaker/react2angular-with-error-boundary': 2,
-    '@spinnaker/rest-prefer-static-strings-in-initializer': 2,
-    indent: 'off',
-    'member-ordering': 'off',
-    'no-console': ['error', { allow: ['warn', 'error'] }],
-    'no-extra-boolean-cast': 'off',
-    'no-prototype-builtins': 'off',
-    'one-var': ['error', { initialized: 'never' }],
-    'prefer-rest-params': 'off',
-    'prefer-spread': 'off',
-    // turn back on if https://github.com/eslint/eslint/issues/11899 fixes false positives
-    'require-atomic-updates': 'off',
-    'react-hooks/rules-of-hooks': 'error',
-    // turn back on after addressing all violations
-    // 'react-hooks/exhaustive-deps': 'warn',
-    '@typescript-eslint/array-type': ['error', { default: 'array-simple' }],
-    '@typescript-eslint/ban-ts-ignore': 'off',
-    '@typescript-eslint/consistent-type-imports': ['error', { prefer: 'type-imports' }],
-    '@typescript-eslint/explicit-function-return-type': 'off',
-    '@typescript-eslint/explicit-member-accessibility': 'off',
-    '@typescript-eslint/indent': 'off',
-    '@typescript-eslint/interface-name-prefix': 'off',
-    '@typescript-eslint/no-case-declarations': 'off',
-    '@typescript-eslint/no-empty-function': 'off',
-    '@typescript-eslint/no-empty-interface': 'off',
-    '@typescript-eslint/no-explicit-any': 'off',
-    '@typescript-eslint/no-object-literal-type-assertion': 'off',
-    '@typescript-eslint/no-parameter-properties': 'off',
-    '@typescript-eslint/no-this-alias': 'off',
-    '@typescript-eslint/no-triple-slash-reference': 'off',
-    '@typescript-eslint/no-unused-vars': 'off',
-    '@typescript-eslint/no-use-before-define': 'off',
-    '@typescript-eslint/no-var-requires': 'off', // TODO: turn on once all code is using ES6 imports
-    '@typescript-eslint/triple-slash-reference': 'off',
-    '@typescript-eslint/explicit-module-boundary-types': 'off',
-    '@typescript-eslint/ban-types': 'off',
-    '@typescript-eslint/ban-ts-comment': 'off',
-  },
-  overrides: [
-    {
-      files: ['*.js', '*.jsx'],
-      rules: {
-        '@typescript-eslint/no-use-before-define': 'off',
+const { globalIgnores } = require('eslint/config');
+
+const tsParser = require('@typescript-eslint/parser');
+const typescriptEslint = require('@typescript-eslint/eslint-plugin');
+const reactHooks = require('eslint-plugin-react-hooks');
+
+// Import rules directly to avoid circular dependency when this config is bundled in the plugin
+// Use a function to get rules lazily
+const getSpinnakerRules = () => require('./index.js').rules;
+
+const globals = require('globals');
+const js = require('@eslint/js');
+
+const { FlatCompat } = require('@eslint/eslintrc');
+
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+  allConfig: js.configs.all,
+});
+
+module.exports = [
+  js.configs.recommended,
+  ...compat.extends('prettier', 'plugin:@typescript-eslint/recommended'),
+  {
+    languageOptions: {
+      parser: tsParser,
+      sourceType: 'module',
+      parserOptions: {},
+
+      globals: {
+        ...globals.browser,
+        ...globals.node,
+        ...globals.jasmine,
+        angular: true,
+        $: true,
+        _: true,
       },
     },
-    {
-      files: ['*.ts', '*.tsx'],
-      rules: {
-        'no-undef': 'off', // typescript already checks this
-      },
+
+    plugins: {
+      '@typescript-eslint': typescriptEslint,
+      '@spinnaker': { rules: getSpinnakerRules() },
+      'react-hooks': { rules: reactHooks.rules },
+    },
+
+    rules: {
+      '@spinnaker/import-sort': 1,
+      '@spinnaker/api-deprecation': 2,
+      '@spinnaker/api-no-slashes': 2,
+      '@spinnaker/api-no-unused-chaining': 2,
+      '@spinnaker/import-from-alias-not-npm': 2,
+      '@spinnaker/import-from-npm-not-alias': 2,
+      '@spinnaker/import-from-npm-not-relative': 2,
+      '@spinnaker/import-from-presentation-not-core': 2,
+      '@spinnaker/import-relative-within-subpackage': 2,
+      '@spinnaker/migrate-to-mock-http-client': 2,
+      '@spinnaker/ng-no-component-class': 2,
+      '@spinnaker/ng-no-module-export': 2,
+      '@spinnaker/ng-no-require-angularjs': 2,
+      '@spinnaker/ng-no-require-module-deps': 2,
+      '@spinnaker/ng-strictdi': 'off',
+      '@spinnaker/prefer-promise-like': 1,
+      '@spinnaker/react2angular-with-error-boundary': 2,
+      '@spinnaker/rest-prefer-static-strings-in-initializer': 2,
+      indent: 'off',
+      'member-ordering': 'off',
+      'no-console': [
+        'error',
+        {
+          allow: ['warn', 'error'],
+        },
+      ],
+      'no-extra-boolean-cast': 'off',
+      'no-prototype-builtins': 'off',
+      'one-var': [
+        'error',
+        {
+          initialized: 'never',
+        },
+      ],
+      'prefer-rest-params': 'off',
+      'prefer-spread': 'off',
+      'require-atomic-updates': 'off',
+      'react-hooks/rules-of-hooks': 'error',
+      '@typescript-eslint/array-type': [
+        'error',
+        {
+          default: 'array-simple',
+        },
+      ],
+      '@typescript-eslint/ban-ts-ignore': 'off',
+      '@typescript-eslint/consistent-type-imports': [
+        'error',
+        {
+          prefer: 'type-imports',
+        },
+      ],
+      '@typescript-eslint/explicit-function-return-type': 'off',
+      '@typescript-eslint/explicit-member-accessibility': 'off',
+      '@typescript-eslint/indent': 'off',
+      '@typescript-eslint/interface-name-prefix': 'off',
+      '@typescript-eslint/no-case-declarations': 'off',
+      '@typescript-eslint/no-empty-function': 'off',
+      '@typescript-eslint/no-empty-interface': 'off',
+      '@typescript-eslint/no-explicit-any': 'off',
+      '@typescript-eslint/no-object-literal-type-assertion': 'off',
+      '@typescript-eslint/no-parameter-properties': 'off',
+      '@typescript-eslint/no-this-alias': 'off',
+      '@typescript-eslint/no-triple-slash-reference': 'off',
+      '@typescript-eslint/no-unused-vars': 'off',
+      '@typescript-eslint/no-use-before-define': 'off',
+      '@typescript-eslint/no-var-requires': 'off',
+      '@typescript-eslint/triple-slash-reference': 'off',
+      '@typescript-eslint/explicit-module-boundary-types': 'off',
+      '@typescript-eslint/ban-types': 'off',
+      '@typescript-eslint/ban-ts-comment': 'off',
+      '@typescript-eslint/no-require-imports': 'off',
+      '@typescript-eslint/no-unused-expressions': 'off',
+      '@typescript-eslint/no-empty-object-type': 'off',
+      '@typescript-eslint/no-unsafe-function-type': 'off',
     },
-  ],
-  env: {
-    browser: true,
-    node: true,
-    es6: true,
-    jasmine: true,
   },
-  globals: {
-    angular: true,
-    $: true,
-    _: true,
+  {
+    files: ['**/*.js', '**/*.jsx'],
+    rules: {
+      '@typescript-eslint/no-use-before-define': 'off',
+    },
+  },
+  {
+    files: ['**/*.ts', '**/*.tsx'],
+    rules: {
+      'no-undef': 'off',
+    },
   },
-};
+  globalIgnores(['**/*.spec.*', './template/**/*']),
+];

package/eslint-plugin.ts

@@ -17,30 +17,35 @@ import preferPromiseLike from './rules/prefer-promise-like';
 import react2angularWithErrorBoundary from './rules/react2angular-with-error-boundary';
 import restPreferStaticStringsInInitializer from './rules/rest-prefer-static-strings-in-initializer';
 
+const rules = {
+  'api-deprecation': apiDeprecation,
+  'api-no-slashes': apiNoSlashes,
+  'api-no-unused-chaining': apiNoUnusedChaining,
+  'import-from-alias-not-npm': importFromAliasNotNpm,
+  'import-from-npm-not-alias': importFromNpmNotAlias,
+  'import-from-npm-not-relative': importFromNpmNotRelative,
+  'import-from-presentation-not-core': importFromPresentationNotCore,
+  'import-relative-within-subpackage': importRelativeWithinSubpackage,
+  'import-sort': importSort,
+  'migrate-to-mock-http-client': migrateToMockHttpClient,
+  'ng-no-component-class': ngNoComponentClass,
+  'ng-no-module-export': ngNoModuleExport,
+  'ng-no-require-angularjs': ngNoRequireAngularJS,
+  'ng-no-require-module-deps': ngNoRequireModuleDeps,
+  'ng-strictdi': ngStrictDI,
+  'prefer-promise-like': preferPromiseLike,
+  'react2angular-with-error-boundary': react2angularWithErrorBoundary,
+  'rest-prefer-static-strings-in-initializer': restPreferStaticStringsInInitializer,
+};
+
 const plugin = {
-  configs: {
-    base: require('./base.config.js'),
-    none: require('./none.config.js'),
-  },
-  rules: {
-    'api-deprecation': apiDeprecation,
-    'api-no-slashes': apiNoSlashes,
-    'api-no-unused-chaining': apiNoUnusedChaining,
-    'import-from-alias-not-npm': importFromAliasNotNpm,
-    'import-from-npm-not-alias': importFromNpmNotAlias,
-    'import-from-npm-not-relative': importFromNpmNotRelative,
-    'import-from-presentation-not-core': importFromPresentationNotCore,
-    'import-relative-within-subpackage': importRelativeWithinSubpackage,
-    'import-sort': importSort,
-    'migrate-to-mock-http-client': migrateToMockHttpClient,
-    'ng-no-component-class': ngNoComponentClass,
-    'ng-no-module-export': ngNoModuleExport,
-    'ng-no-require-angularjs': ngNoRequireAngularJS,
-    'ng-no-require-module-deps': ngNoRequireModuleDeps,
-    'ng-strictdi': ngStrictDI,
-    'prefer-promise-like': preferPromiseLike,
-    'react2angular-with-error-boundary': react2angularWithErrorBoundary,
-    'rest-prefer-static-strings-in-initializer': restPreferStaticStringsInInitializer,
+  rules,
+  // Configs are loaded lazily to avoid circular dependency
+  get configs() {
+    return {
+      base: require('./base.config.js'),
+      none: require('./none.config.js'),
+    };
   },
 };
 

package/none.config.js

@@ -1,18 +1,36 @@
-module.exports = {
-  parser: '@typescript-eslint/parser',
-  parserOptions: { sourceType: 'module' },
-  plugins: ['@typescript-eslint', '@spinnaker/eslint-plugin'],
-  extends: [],
-  rules: {},
-  env: {
-    browser: true,
-    node: true,
-    es6: true,
-    jasmine: true,
+const { globalIgnores } = require('eslint/config');
+
+const tsParser = require('@typescript-eslint/parser');
+const typescriptEslint = require('@typescript-eslint/eslint-plugin');
+
+// Import rules directly to avoid circular dependency when this config is bundled in the plugin
+// Use a function to get rules lazily
+const getSpinnakerRules = () => require('./index.js').rules;
+const globals = require('globals');
+
+module.exports = [
+  {
+    languageOptions: {
+      parser: tsParser,
+      sourceType: 'module',
+      parserOptions: {},
+
+      globals: {
+        ...globals.browser,
+        ...globals.node,
+        ...globals.jasmine,
+        angular: true,
+        $: true,
+        _: true,
+      },
+    },
+
+    plugins: {
+      '@typescript-eslint': typescriptEslint,
+      '@spinnaker': { rules: getSpinnakerRules() },
+    },
+
+    rules: {},
   },
-  globals: {
-    angular: true,
-    $: true,
-    _: true,
-  },
-};
+  globalIgnores(['**/*.spec.*', './template/**/*']),
+];

package/package.json

@@ -4,7 +4,7 @@
     "type": "git",
     "url": "https://github.com/spinnaker/spinnaker.git"
   },
-  "version": "2026.0.1",
+  "version": "2026.1.0",
   "main": "index.js",
   "license": "Apache-2.0",
   "publishConfig": {
@@ -23,25 +23,29 @@
   },
   "devDependencies": {
     "@babel/preset-typescript": "^7.15.0",
-    "@types/eslint": "^7.28.0",
+    "@eslint/compat": "^2.0.2",
+    "@eslint/eslintrc": "^3.3.4",
+    "@eslint/js": "^9.39.2",
+    "@types/eslint": "9.6.1",
     "@types/estree": "*",
-    "@types/jest": "^26.0.24",
+    "@types/jest": "^29.0.0",
     "@types/lodash": "^4.14.165",
     "@types/node": "^16.4.13",
-    "@typescript-eslint/parser": "5.59.8",
-    "@typescript-eslint/types": "5.59.8",
-    "eslint": "7.32.0",
+    "@typescript-eslint/parser": "8.54.0",
+    "@typescript-eslint/types": "8.54.0",
+    "eslint": "9.39.2",
     "fast-glob": "^3.2.7",
-    "jest": "^27.0.6",
+    "globals": "^17.2.0",
+    "jest": "^29.0.0",
     "prettier": "*",
     "typescript": "5.0.4"
   },
   "peerDependencies": {
-    "@typescript-eslint/eslint-plugin": "5.59.8",
-    "@typescript-eslint/parser": "5.59.8",
-    "eslint": "7.32.0",
-    "eslint-config-prettier": "6.12.0",
-    "eslint-plugin-react-hooks": "4.1.2"
+    "@typescript-eslint/eslint-plugin": "^8.0.0",
+    "@typescript-eslint/parser": "^8.0.0",
+    "eslint": "^9.0.0",
+    "eslint-config-prettier": "^10.0.0",
+    "eslint-plugin-react-hooks": "^5.0.0 || ^7.0.0"
   },
   "peerDevDependencies": [
     "@typescript-eslint/eslint-plugin",
@@ -54,7 +58,8 @@
     "testPathIgnorePatterns": [
       "<rootDir>/template",
       "<rootDir>/rules/ng-strictdi.spec.ts"
-    ]
+    ],
+    "testEnvironment": "node"
   },
-  "gitHead": "230864a7fc8b5dfb38edb1164c7719671f7b4fa3"
+  "gitHead": "b43289872672de89234911de45d1cba0dd18373f"
 }

package/rules/api-deprecation.ts

@@ -1,5 +1,11 @@
 import type { Rule } from 'eslint';
-import type { CallExpression, ImportDeclaration, ImportSpecifier, MemberExpression, Node } from 'estree';
+import type * as ESTree from 'estree';
+
+type CallExpression = ESTree.CallExpression;
+type ImportDeclaration = ESTree.ImportDeclaration;
+type ImportSpecifier = ESTree.ImportSpecifier;
+type MemberExpression = ESTree.MemberExpression;
+type Node = ESTree.Node;
 import * as _ from 'lodash/fp';
 
 import { getImportName } from '../utils/ast';
@@ -202,7 +208,8 @@ const rule: Rule.RuleModule = {
        * - part of an xyz() call chained off a variable, e.g.: var foo = API.xyz(); foo.get()
        * @param node {CallExpression}
        */
-      CallExpression(node) {
+      CallExpression(_node: any) {
+        const node = _node as CallExpression & Rule.NodeParentExtension;
         if (node.parent.type === 'MemberExpression' || !isAPICall(context, node)) {
           return undefined;
         }

package/rules/api-no-slashes.ts

@@ -1,5 +1,9 @@
 import type { Rule } from 'eslint';
-import type { CallExpression, Identifier, Literal } from 'estree';
+import type * as ESTree from 'estree';
+
+type CallExpression = ESTree.CallExpression;
+type Identifier = ESTree.Identifier;
+type Literal = ESTree.Literal;
 import { get } from 'lodash';
 
 import { getCallingIdentifier, getVariableInScope, isMemberExpression } from '../utils/utils';
@@ -12,7 +16,8 @@ import { getCallingIdentifier, getVariableInScope, isMemberExpression } from '..
  */
 const rule = function (context: Rule.RuleContext) {
   return {
-    CallExpression: function (node: CallExpression) {
+    CallExpression: function (_node: any) {
+      const node = _node as CallExpression;
       const callee = node.callee;
       const args = node.arguments;
 

package/rules/import-from-alias-not-npm.ts

@@ -1,5 +1,4 @@
 import type { Rule } from 'eslint';
-import type { ImportDeclaration } from 'estree';
 
 import { getImportFromNpm, getSourceFileDetails } from '../utils/import-aliases';
 
@@ -18,7 +17,8 @@ const rule = function (context: Rule.RuleContext) {
   }
 
   return {
-    ImportDeclaration(node: ImportDeclaration) {
+    ImportDeclaration(_node: any) {
+      const node = _node;
       if (node.source.type !== 'Literal' || !node.source.value) {
         return;
       }

package/rules/import-from-npm-not-alias.ts

@@ -1,5 +1,4 @@
 import type { Rule } from 'eslint';
-import type { ImportDeclaration } from 'estree';
 
 import { getAliasImport, getAllSpinnakerPackages, getSourceFileDetails } from '../utils/import-aliases';
 
@@ -21,7 +20,8 @@ const rule = function (context: Rule.RuleContext) {
   const allSpinnakerPackages = getAllSpinnakerPackages(modulesPath);
 
   return {
-    ImportDeclaration: function (node: ImportDeclaration & Rule.NodeParentExtension) {
+    ImportDeclaration: function (_node: any) {
+      const node = _node;
       if (node.source.type !== 'Literal' || !node.source.value) {
         return;
       }

package/rules/import-from-npm-not-relative.ts

@@ -1,5 +1,4 @@
 import type { Rule } from 'eslint';
-import type { ImportDeclaration } from 'estree';
 
 import { getRelativeImport, getSourceFileDetails } from '../utils/import-aliases';
 
@@ -20,7 +19,8 @@ const rule = function (context: Rule.RuleContext) {
   }
 
   return {
-    ImportDeclaration: function (node: ImportDeclaration) {
+    ImportDeclaration: function (_node: any) {
+      const node = _node;
       if (node.source.type !== 'Literal' || !node.source.value) {
         return;
       }

package/rules/import-relative-within-subpackage.ts

@@ -1,5 +1,4 @@
 import type { Rule } from 'eslint';
-import type { ImportDeclaration } from 'estree';
 import path from 'path';
 
 import { getAliasImport, getAllSpinnakerPackages, getSourceFileDetails } from '../utils/import-aliases';
@@ -23,7 +22,8 @@ const rule = function (context: Rule.RuleContext) {
   const allSpinnakerPackages = getAllSpinnakerPackages(modulesPath);
 
   return {
-    ImportDeclaration: function (node: ImportDeclaration & Rule.NodeParentExtension) {
+    ImportDeclaration: function (_node: any) {
+      const node = _node;
       if (node.source.type !== 'Literal' || !node.source.value) {
         return;
       }

package/rules/migrate-to-mock-http-client.ts

@@ -1,5 +1,4 @@
 import type { Rule } from 'eslint';
-import type { FunctionExpression, ImportDeclaration, ImportSpecifier } from 'estree';
 
 import { getImportName } from '../utils/ast';
 import { getProgram } from '../utils/utils';
@@ -9,13 +8,14 @@ const ruleModule: Rule.RuleModule = {
     const text = (node) => context.getSourceCode().getText(node);
 
     return {
-      CallExpression(node) {
+      CallExpression(_node: any) {
+        const node = _node;
         /** it(() => {}) */
         const isItBlock = node.callee.type === 'Identifier' && node.callee.name === 'it';
 
         if (isItBlock) {
           const itBlockText = text(node);
-          const testFunction = node.arguments[1] as FunctionExpression;
+          const testFunction = node.arguments[1] as any;
 
           const doesFunctionIncludeHttpBackend = !!testFunction && itBlockText.includes('$httpBackend');
 
@@ -38,12 +38,10 @@ const ruleModule: Rule.RuleModule = {
                 !text(testFunction.body.body[0]).includes('mockHttpClient')
               ) {
                 const program = getProgram(node);
-                const allImports = program.body.filter(
-                  (item) => item.type === 'ImportDeclaration',
-                ) as ImportDeclaration[];
+                const allImports = program.body.filter((item) => item.type === 'ImportDeclaration') as any[];
 
                 const importSpecifiers = allImports
-                  .map((decl) => decl.specifiers as ImportSpecifier[])
+                  .map((decl) => decl.specifiers as any[])
                   .reduce((acc, x) => acc.concat(x), []);
 
                 const mockHttpClientImport = importSpecifiers.find((specifier) => {

package/rules/ng-no-component-class.ts

@@ -12,14 +12,13 @@ const findParentNodeByType = (node: Rule.Node, type: string) =>
  * @category conventions
  */
 import angularRule from '../utils/angular-rule/angular-rule';
-import { isNewExpression } from '../utils/utils';
 
 const useObjectLiteral = function (context: Rule.RuleContext) {
   return {
     'angular?component': function (callee, thisGuy) {
       const node: Rule.Node = thisGuy.node;
       const scope: Scope.Scope = thisGuy.scope;
-      if (isNewExpression(node)) {
+      if (node.type === 'NewExpression') {
         const calleeName = 'name' in node.callee ? node.callee.name : undefined;
         const fix = (fixer: Rule.RuleFixer) => {
           const variable = scope.variables.find((x) => x.name === calleeName);

package/rules/ng-no-module-export.ts

@@ -3,7 +3,6 @@
  */
 
 import type { AST, Rule } from 'eslint';
-import type { AssignmentExpression, CallExpression, MemberExpression } from 'estree';
 import { isCallExpression, isIdentifier, isMemberExpression } from '../utils/utils';
 
 const rule = function (context: Rule.RuleContext) {
@@ -20,7 +19,8 @@ const rule = function (context: Rule.RuleContext) {
   }
 
   return {
-    AssignmentExpression: function (node: AssignmentExpression) {
+    AssignmentExpression: function (_node: any) {
+      const node = _node;
       const left = node.left;
       const right = node.right;
       const isModuleExports = isModuleExportMemberExpression(left);
@@ -65,13 +65,13 @@ function getAngularModuleNameNode(node) {
   if (!isCallExpression(node)) return false;
   const callee = node.callee as Rule.Node;
 
-  function angularModuleNameNode(callExpression: CallExpression) {
+  function angularModuleNameNode(callExpression: any) {
     const isLiteral =
       callExpression.arguments && callExpression.arguments[0] && callExpression.arguments[0].type === 'Literal';
     return isLiteral ? callExpression.arguments[0] : undefined;
   }
 
-  function isChainedCallExpression(_callee: Rule.Node): _callee is MemberExpression & Rule.NodeParentExtension {
+  function isChainedCallExpression(_callee: any): boolean {
     if (isMemberExpression(_callee)) {
       return _callee.object && _callee.object.type === 'CallExpression';
     }
@@ -95,7 +95,7 @@ function getAngularModuleNameNode(node) {
   }
 
   if (isChainedCallExpression(callee)) {
-    return getAngularModuleNameNode(callee.object);
+    return getAngularModuleNameNode((callee as any).object);
   } else if (isRawModuleCall(callee)) {
     if (node.arguments && node.arguments[0] && node.arguments[0].type === 'Literal') return angularModuleNameNode(node);
   } else if (isAngularModuleCall(callee)) {

package/rules/ng-no-require-angularjs.ts

@@ -8,19 +8,17 @@
  * angular.module('mymodule', [])
  */
 import type { Rule, Scope } from 'eslint';
-import type { ImportDeclaration, MemberExpression } from 'estree';
 import { getProgram, isMemberExpression } from '../utils/utils';
 
 const rule = function (context: Rule.RuleContext) {
   return {
-    'MemberExpression[object.name="angular"][property.name="module"]': function (
-      node: MemberExpression & Rule.NodeParentExtension,
-    ) {
+    'MemberExpression[object.name="angular"][property.name="module"]': function (_node: any) {
+      const node = _node;
       const angularVar = findAngularVariable(node, context);
       const angularImport = findAngularImportStatement(node);
       // Double check that there is only a single use of 'angular' variable and that it's 'angular.module()')
       if (angularImport && angularVar && angularVar.references.length === 1) {
-        const { parent } = angularVar.references[0].identifier as Rule.Node;
+        const { parent } = angularVar.references[0].identifier as any;
         if (isMemberExpression(parent)) {
           if (
             'name' in parent.object &&
@@ -46,7 +44,7 @@ function findAngularVariable(_node, context): Scope.Variable {
   return moduleScope && moduleScope.variables.find((v) => v.name === 'angular');
 }
 
-function findAngularImportStatement(_node): ImportDeclaration {
+function findAngularImportStatement(_node): any {
   let program = _node;
   while (program && program.parent) {
     program = program.parent;
@@ -59,7 +57,7 @@ function findAngularImportStatement(_node): ImportDeclaration {
       node.source.type === 'Literal' &&
       node.source.value === 'angular'
     );
-  }) as ImportDeclaration;
+  });
 }
 
 /*
@@ -71,7 +69,7 @@ import { module } from 'angular';
 
 module('module', ['dep']);
  */
-function getFixForAngularModule(angularDotModuleNode: Rule.Node, importStatement: ImportDeclaration) {
+function getFixForAngularModule(angularDotModuleNode: Rule.Node, importStatement: any) {
   return function (fixer: Rule.RuleFixer) {
     return [
       fixer.replaceText(angularDotModuleNode, 'module'),

package/rules/ng-no-require-module-deps.ts

@@ -1,5 +1,4 @@
 import type { Rule } from 'eslint';
-import type { ArrayExpression, Node } from 'estree';
 import fs from 'fs';
 import path from 'path';
 
@@ -12,7 +11,8 @@ import path from 'path';
  */
 const rule = function (context: Rule.RuleContext) {
   return {
-    ArrayExpression: function (node: ArrayExpression) {
+    ArrayExpression: function (_node: any) {
+      const node = _node;
       if (isInAngularModuleCall(node)) {
         const requireDotNames = node.elements.map((element) => getRequireDotNameNode(element)).filter((x) => !!x);
         requireDotNames.forEach(([_node, relativePath]) => {
@@ -54,7 +54,7 @@ angular.module('module', [
   ANGULAR_UI_BOOTSTRAP
 ]);
  */
-function getFixForBareRequire(node: Node, requiredString: string) {
+function getFixForBareRequire(node: any, requiredString: string) {
   return function (fixer: Rule.RuleFixer) {
     const variableName = requiredString.replace(/[^\w_]/g, '_').toUpperCase();
     const lastImport = findLastImportStatement(node);
@@ -80,7 +80,7 @@ angular.module('module', [
   SOME_REQUIRE_STRING
 ]);
  */
-function getFixForRequireDotAnything(node: Node, requiredString: string, property: string) {
+function getFixForRequireDotAnything(node: any, requiredString: string, property: string) {
   return function (fixer: Rule.RuleFixer) {
     const variableName = requiredString
       .replace(/^[^\w_]*/g, '')
@@ -109,7 +109,7 @@ angular.module('module', [
   DEPENDENCY_SYMBOL
 ]);
  */
-function getFixForRequireDotName(node: Node, filename: string, relativePath: string) {
+function getFixForRequireDotName(node: any, filename: string, relativePath: string) {
   const modulesPath = filename.replace(/modules\/.*/, 'modules/');
 
   const path1 = path.resolve(filename, '..', relativePath);
@@ -138,7 +138,7 @@ function getFixForRequireDotName(node: Node, filename: string, relativePath: str
   }
 }
 
-function findLastImportStatement(_node: Node) {
+function findLastImportStatement(_node: any) {
   let program = _node as Rule.Node;
   while (program && program.parent) {
     program = program.parent;
@@ -153,7 +153,7 @@ function findLastImportStatement(_node: Node) {
 }
 
 // require('./some/nested/angularjs/module').name
-function getRequireDotNameNode(node: Node): [Node, string] {
+function getRequireDotNameNode(node: any): [any, string] {
   if (node.type !== 'MemberExpression') return undefined;
   if (node.property.type !== 'Identifier' || node.property.name !== 'name') return undefined;
   if (node.object.type !== 'CallExpression' || (node.object.callee as any).name !== 'require') return undefined;
@@ -164,7 +164,7 @@ function getRequireDotNameNode(node: Node): [Node, string] {
 }
 
 // require('something').anything
-function getRequireDotAnythingNode(node: Node): [Node, string, string] {
+function getRequireDotAnythingNode(node: any): [any, string, string] {
   if (node.type !== 'MemberExpression') return undefined;
   if (node.property.type !== 'Identifier') return undefined;
   if (node.object.type !== 'CallExpression' || (node.object.callee as any).name !== 'require') return undefined;
@@ -175,7 +175,7 @@ function getRequireDotAnythingNode(node: Node): [Node, string, string] {
 }
 
 // require('something')
-function getBareRequireNode(node): [Node, string] {
+function getBareRequireNode(node): [any, string] {
   if (node.type !== 'CallExpression' || node.callee.name !== 'require') return undefined;
   if (node.arguments.length !== 1 || node.arguments[0].type !== 'Literal') return undefined;
 

package/rules/ng-strictdi.ts

@@ -272,7 +272,7 @@ const rule = function (context: Rule.RuleContext) {
     'CallExpression:exit': function (node) {
       const { object, property } = node.callee;
       if (object && object.name === '$provide' && property && property.name === 'decorator') {
-        checkDi(null, { node: node.arguments[1], scope: context.getScope() });
+        checkDi(null, { node: node.arguments[1], scope: context.sourceCode.getScope(node) });
       }
     },
     AssignmentExpression: function (node) {

package/rules/prefer-promise-like.ts

@@ -1,6 +1,5 @@
 import type { TSESTree } from '@typescript-eslint/types';
 import type { Rule } from 'eslint';
-import type { ImportDeclaration } from 'estree';
 import _ from 'lodash';
 
 /**
@@ -50,7 +49,8 @@ const rule = function (context: Rule.RuleContext) {
     },
 
     // If there are any unused IPromise imports, remove them
-    ImportDeclaration: function (node: ImportDeclaration) {
+    ImportDeclaration: function (_node: any) {
+      const node = _node;
       const importIPromise = {
         type: 'ImportSpecifier',
         imported: {
@@ -66,7 +66,7 @@ const rule = function (context: Rule.RuleContext) {
       const specifiers = node.specifiers || [];
       const foundIPromiseImport = specifiers.find((s) => _.isMatch(s, importIPromise));
 
-      const variables = context.getScope().variables;
+      const variables = context.sourceCode.getScope(node).variables;
       const variable = variables.find((x) => x.defs.some((def) => def.node === foundIPromiseImport));
       const unused = variable && variable.references.length === 0;
 

package/rules/react2angular-with-error-boundary.ts

@@ -1,5 +1,4 @@
 import type { Rule } from 'eslint';
-import type { CallExpression, ImportDeclaration } from 'estree';
 import _ from 'lodash';
 import { isLiteral } from '../utils/utils';
 
@@ -9,12 +8,13 @@ import { isLiteral } from '../utils/utils';
  * @version 0.1.0
  */
 const rule = function (context: Rule.RuleContext) {
-  let coreImport: ImportDeclaration;
+  let coreImport: any;
 
   return {
     // Find an import from @spinnaker/core or core/presentation
     // This will be used to add the import for withErrorBoundary
-    ImportDeclaration: function (node: ImportDeclaration) {
+    ImportDeclaration: function (_node: any) {
+      const node = _node;
       // import { foo, bar } from 'package';
       //                           ^^^^^^^
       const from = node.source.value || '';
@@ -22,7 +22,8 @@ const rule = function (context: Rule.RuleContext) {
         coreImport = node;
       }
     },
-    CallExpression: function (node: CallExpression & Rule.NodeParentExtension) {
+    CallExpression: function (_node: any) {
+      const node = _node;
       // Find:
       // react2angular(SomeComponent, ...)
       const match = {
@@ -69,7 +70,7 @@ const rule = function (context: Rule.RuleContext) {
           },
         },
       };
-      const isComponentCallExpression = (node): node is CallExpression => _.isMatch(node, parentMatch);
+      const isComponentCallExpression = (node): node is any => _.isMatch(node, parentMatch);
 
       let componentName = `'react2angular component'`;
       const parentNode = node.parent;

package/rules/rest-prefer-static-strings-in-initializer.spec.ts

@@ -24,11 +24,5 @@ ruleTester.run('rest-prefer-static-strings-in-initializer', rule, {
       output: "REST('foo/bar').path('baz').get()",
       errors: ["Prefer REST('/foo/bar') over REST().path('foo', 'bar')"],
     },
-    {
-      // Process one path arg at a time
-      code: "REST('foo').path('bar', 'baz').get()",
-      output: "REST('foo/bar').path('baz').get()",
-      errors: ["Prefer REST('/foo/bar') over REST().path('foo', 'bar')"],
-    },
   ],
 });

package/rules/rest-prefer-static-strings-in-initializer.ts

@@ -3,7 +3,6 @@
  */
 
 import type { Rule } from 'eslint';
-import type { CallExpression, Literal } from 'estree';
 import * as _ from 'lodash/fp';
 
 import { getCallChain, getCallingIdentifierName, isLiteral } from '../utils/utils';
@@ -15,7 +14,8 @@ const ruleModule: Rule.RuleModule = {
       /**
        * Look for chains of CallExpressions that are part of a REST().path() call
        */
-      CallExpression(node: CallExpression & Rule.NodeParentExtension) {
+      CallExpression(_node: any) {
+        const node = _node;
         const callingIdentifierName = getCallingIdentifierName(node);
         if (node.parent.type === 'MemberExpression' || callingIdentifierName !== 'REST') {
           return undefined;
@@ -32,8 +32,8 @@ const ruleModule: Rule.RuleModule = {
         const restCall = callChain[0];
         const pathCall = callChain[1];
 
-        const restArg = restCall.arguments[0] as Literal;
-        const firstPathArg = pathCall.arguments[0] as Literal;
+        const restArg = restCall.arguments[0] as any;
+        const firstPathArg = pathCall.arguments[0] as any;
 
         // Only REST('literal').path('literal', ...)
         // Ignores: REST(variable) and REST().path(variable)

package/utils/angular-rule/angular-rule.js

@@ -131,7 +131,7 @@ function angularRule(ruleDefinition) {
       return {
         callExpression: callExpressionNode,
         node: findInjectedArgument(callExpressionNode),
-        scope: context.getScope(),
+        scope: context.sourceCode.getScope(callExpressionNode),
       };
     }
 
@@ -182,7 +182,7 @@ function angularRule(ruleDefinition) {
       } else if (callee.object.type === 'Identifier') {
         // var app = angular.module(); app.factory()
         //                                 ^^^^^^^
-        var scope = context.getScope();
+        var scope = context.sourceCode.getScope(callExpressionNode);
         var isAngularModule = scope.variables.some(function (variable) {
           if (callee.object.name !== variable.name) {
             return false;

package/utils/angular-rule/utils.js

@@ -559,7 +559,8 @@ function isUIRouterStateDefinition(node) {
  */
 function findIdentiferInScope(context, identifier) {
   var identifierNode = null;
-  context.getScope().variables.forEach(function (variable) {
+  var scope = context.sourceCode ? context.sourceCode.getScope(identifier) : context.getScope();
+  scope.variables.forEach(function (variable) {
     if (variable.name === identifier.name) {
       identifierNode = variable.defs[0].node;
       if (identifierNode.type === 'VariableDeclarator') {

package/utils/ast.ts

@@ -1,6 +1,4 @@
-import type { Identifier, Literal } from 'estree';
-
-export function getImportName(node: Identifier | Literal): string {
+export function getImportName(node: any): string {
   if (node.type === 'Identifier') {
     return node.name;
   }

package/utils/ruleTester.js

@@ -1,8 +1,8 @@
 const RuleTester = require('eslint').RuleTester;
 module.exports = new RuleTester({
-  parserOptions: {
-    ecmaVersion: 8,
+  languageOptions: {
+    ecmaVersion: 2017,
     sourceType: 'module',
+    parser: require('@typescript-eslint/parser'),
   },
-  parser: require.resolve('@typescript-eslint/parser'),
 });

package/utils/utils.ts

@@ -1,17 +1,17 @@
 import type { Rule, Scope } from 'eslint';
-import type {
-  CallExpression,
-  Expression,
-  Identifier,
-  Literal,
-  MemberExpression,
-  NewExpression,
-  Node,
-  Program,
-  SpreadElement,
-} from 'estree';
+import type * as ESTree from 'estree';
 import * as _ from 'lodash/fp';
 
+type Node = ESTree.Node;
+type CallExpression = ESTree.CallExpression;
+type Expression = ESTree.Expression;
+type Identifier = ESTree.Identifier;
+type Literal = ESTree.Literal;
+type MemberExpression = ESTree.MemberExpression;
+type NewExpression = ESTree.NewExpression;
+type Program = ESTree.Program;
+type SpreadElement = ESTree.SpreadElement;
+
 export const getNodeType = (obj: Node) => obj?.type;
 export const isType = <T extends Node>(type: string) => (obj: Node): obj is T => getNodeType(obj) === type;
 export const isIdentifier = isType<Identifier>('Identifier');
@@ -53,7 +53,7 @@ export function getVariableInScope(context: Rule.RuleContext, identifier: Identi
     return undefined;
   }
 
-  const { references } = context.getScope();
+  const { references } = context.sourceCode.getScope((identifier as unknown) as Rule.Node);
   const ref = references.find((r) => r.identifier.name === identifier.name);
   return ref ? ref.resolved : undefined;
 }
@@ -61,10 +61,10 @@ export function getVariableInScope(context: Rule.RuleContext, identifier: Identi
 export const getVariableInitializer = _.get('defs[0].node.init');
 
 export function getProgram(node: Node): Program {
-  let _node = node as Node & Rule.NodeParentExtension;
+  let _node = node as any;
   while (_node.parent) {
     if (_node.parent.type === 'Program') {
-      return _node.parent;
+      return _node.parent as Program;
     }
     _node = _node.parent;
   }