@spinnaker/core 2026.2.2 → 2026.3.0

package/src/pipeline/config/validation/pipelineConfig.validator.spec.ts

@@ -1,5 +1,4 @@
-import { mock } from 'angular';
-
+import '../../../bootstrap/runtimeInitializers';
 import type { ICustomValidator, IPipelineValidationResults, IValidatorConfig } from './PipelineConfigValidator';
 import { PipelineConfigValidator } from './PipelineConfigValidator';
 import { SETTINGS } from '../../../config/settings';
@@ -19,7 +18,7 @@ import type { ITargetImpedanceValidationConfig } from './targetImpedance.validat
 import Spy = jasmine.Spy;
 
 describe('pipelineConfigValidator', () => {
-  let pipeline: IPipeline, validate: () => void, validationResults: IPipelineValidationResults, $q: ng.IQService;
+  let pipeline: IPipeline, validate: () => Promise<void>, validationResults: IPipelineValidationResults;
 
   function buildPipeline(stages: any[], triggers: any[] = []): IPipeline {
     stages.forEach((stage, idx) => {
@@ -52,37 +51,28 @@ describe('pipelineConfigValidator', () => {
       label: null,
       description: null,
       key: null,
-      templateUrl: null,
-      executionDetailsUrl: null,
-      controller: null,
-      controllerAs: null,
+      executionDetailsSections: null,
       validators,
     };
   }
 
   beforeEach(() => Registry.reinitialize());
 
-  beforeEach(mock.module(require('../pipelineConfig.module').name));
-
   beforeEach(function () {
     SETTINGS.feature.fiatEnabled = true;
   });
 
   beforeEach(() => {
-    mock.inject((_$q_: ng.IQService, $rootScope: ng.IRootScopeService) => {
-      $q = _$q_;
-      validate = () => {
-        validationResults = null;
-        PipelineConfigValidator.validatePipeline(pipeline).then((result) => (validationResults = result));
-        $rootScope.$new().$digest();
-      };
-    });
+    validate = async () => {
+      validationResults = null;
+      validationResults = await PipelineConfigValidator.validatePipeline(pipeline);
+    };
   });
 
   afterEach(SETTINGS.resetToOriginal);
 
   describe('validation', () => {
-    it('performs validation against stages and triggers where declared, ignores others', () => {
+    it('performs validation against stages and triggers where declared, ignores others', async () => {
       spyOn(Registry.pipeline, 'getTriggerConfig').and.callFake((type: string) => {
         if (type === 'withTriggerValidation') {
           return buildStageTypeConfig([
@@ -113,14 +103,14 @@ describe('pipelineConfigValidator', () => {
         [{ type: 'withTriggerValidation' }, { type: 'withoutValidation' }],
       );
 
-      validate();
+      await validate();
       expect(validationResults.hasWarnings).toBe(true);
       expect(validationResults.stages.length).toBe(1);
       expect(validationResults.stages[0].messages).toEqual(['bar is required']);
       expect(validationResults.pipeline).toEqual(['boo is required']);
     });
 
-    it('executes all validators', () => {
+    it('executes all validators', async () => {
       spyOn(Registry.pipeline, 'getStageConfig').and.callFake((stage: IStage) => {
         if (stage.type === 'withValidation') {
           return buildStageTypeConfig([
@@ -142,13 +132,13 @@ describe('pipelineConfigValidator', () => {
 
       pipeline = buildPipeline([{ type: 'withValidation' }, { type: 'no-validation' }]);
 
-      validate();
+      await validate();
       expect(validationResults.hasWarnings).toBe(true);
       expect(validationResults.stages.length).toBe(1);
       expect(validationResults.stages[0].messages).toEqual(['bar is required', 'foo is also required']);
 
       pipeline.stages[0]['foo'] = 'a';
-      validate();
+      await validate();
       expect(validationResults.hasWarnings).toBe(true);
       expect(validationResults.stages[0].messages).toEqual(['bar is required']);
     });
@@ -185,8 +175,8 @@ describe('pipelineConfigValidator', () => {
         ]);
       });
 
-      it('fails if no stage/trigger is first or not preceded by declared stage type', () => {
-        validate();
+      it('fails if no stage/trigger is first or not preceded by declared stage type', async () => {
+        await validate();
         expect(validationResults.stages.length).toBe(1);
         expect(validationResults.stages[0].messages).toEqual(['need a prereq']);
 
@@ -195,14 +185,14 @@ describe('pipelineConfigValidator', () => {
           { name: 'b', type: 'withValidation', refId: 2, requisiteStageRefIds: [1] },
         ];
 
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
         expect(validationResults.stages[0].messages).toEqual(['need a prereq']);
       });
 
-      it('succeeds if preceding stage type matches', () => {
+      it('succeeds if preceding stage type matches', async () => {
         pipeline.stages[0].type = 'prereq';
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
 
         pipeline.stages = [
@@ -211,25 +201,25 @@ describe('pipelineConfigValidator', () => {
           { name: 'c', type: 'withValidation', refId: 3, requisiteStageRefIds: [2] },
         ];
 
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
       });
 
-      it('succeeds if trigger type matches', () => {
+      it('succeeds if trigger type matches', async () => {
         pipeline.stages[0].type = 'prereq';
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
 
         pipeline.stages = [{ name: 'a', type: 'withValidation', refId: 1, requisiteStageRefIds: [] }];
         pipeline.triggers = [{ type: 'prereq', enabled: true }];
 
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
       });
 
-      it('fails if no preceding stage type matches and no trigger type matches', () => {
+      it('fails if no preceding stage type matches and no trigger type matches', async () => {
         pipeline.stages[0].type = 'prereq';
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
 
         pipeline.stages = [
@@ -238,29 +228,29 @@ describe('pipelineConfigValidator', () => {
         ];
         pipeline.triggers = [{ type: 'alsoNotValidation', enabled: true }];
 
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(true);
         expect(validationResults.stages.length).toBe(1);
         expect(validationResults.stages[0].messages).toEqual(['need a prereq']);
       });
 
-      it('checks parent pipeline triggers for match', () => {
+      it('checks parent pipeline triggers for match', async () => {
         spyOn(PipelineConfigService, 'getPipelinesForApplication').and.returnValue(
-          $q.when([{ id: 'abcd', triggers: [{ type: 'prereq' }] }]) as any,
+          Promise.resolve([{ id: 'abcd', triggers: [{ type: 'prereq' }] }]) as any,
         );
 
         pipeline = buildPipeline(
           [{ type: 'withValidationIncludingParent', refId: 1 }],
           [{ type: 'pipeline', application: 'someApp', pipeline: 'abcd' }],
         );
-        validate();
+        await validate();
         expect(PipelineConfigService.getPipelinesForApplication).toHaveBeenCalledWith('someApp');
         expect(validationResults.hasWarnings).toBe(false);
       });
 
-      it('caches pipeline configs', () => {
+      it('caches pipeline configs', async () => {
         spyOn(PipelineConfigService, 'getPipelinesForApplication').and.returnValue(
-          $q.when([{ id: 'abcd', triggers: [{ type: 'prereq' }] }] as any),
+          Promise.resolve([{ id: 'abcd', triggers: [{ type: 'prereq' }] }] as any),
         );
 
         pipeline = buildPipeline(
@@ -268,16 +258,16 @@ describe('pipelineConfigValidator', () => {
           [{ type: 'pipeline', application: 'someApp2', pipeline: 'abcd' }],
         );
 
-        validate();
+        await validate();
         expect((PipelineConfigService.getPipelinesForApplication as Spy).calls.count()).toBe(1);
 
-        validate();
+        await validate();
         expect((PipelineConfigService.getPipelinesForApplication as Spy).calls.count()).toBe(1);
       });
 
-      it('fails if own stages and parent pipeline triggers do not match', () => {
+      it('fails if own stages and parent pipeline triggers do not match', async () => {
         spyOn(PipelineConfigService, 'getPipelinesForApplication').and.returnValue(
-          $q.when([
+          Promise.resolve([
             { id: 'abcd', triggers: [{ type: 'not-prereq' }] },
             { id: 'other', triggers: [{ type: 'prereq' }] },
           ] as any),
@@ -287,28 +277,39 @@ describe('pipelineConfigValidator', () => {
           [{ type: 'withValidationIncludingParent', refId: 1 }],
           [{ type: 'pipeline', application: 'someApp3', pipeline: 'abcd' }],
         );
-        validate();
+        await validate();
         expect(PipelineConfigService.getPipelinesForApplication).toHaveBeenCalledWith('someApp3');
         expect(validationResults.stages.length).toBe(1);
       });
 
-      it('does not check parent triggers unless specified in validator', () => {
+      it('rejects when loading an external parent pipeline fails', async () => {
+        const loadingError = new Error('parent pipeline unavailable');
+        spyOn(PipelineConfigService, 'getPipelinesForApplication').and.returnValue(Promise.reject(loadingError));
+        pipeline = buildPipeline(
+          [{ type: 'withValidationIncludingParent', refId: 1 }],
+          [{ type: 'pipeline', application: 'unavailableApp', pipeline: 'abcd' }],
+        );
+
+        await expectAsync(PipelineConfigValidator.validatePipeline(pipeline)).toBeRejectedWith(loadingError);
+      });
+
+      it('does not check parent triggers unless specified in validator', async () => {
         spyOn(PipelineConfigService, 'getPipelinesForApplication').and.returnValue(
-          $q.when([{ id: 'abcd', triggers: [{ type: 'prereq' }] }] as any),
+          Promise.resolve([{ id: 'abcd', triggers: [{ type: 'prereq' }] }] as any),
         );
 
         pipeline = buildPipeline(
           [{ type: 'withValidation', refId: 1 }],
           [{ type: 'pipeline', application: 'someApp', pipeline: 'abcd' }],
         );
-        validate();
+        await validate();
         expect((PipelineConfigService.getPipelinesForApplication as Spy).calls.count()).toBe(0);
         expect(validationResults.stages.length).toBe(1);
       });
     });
 
     describe('stageBeforeType', () => {
-      it('fails if no stage is first or not preceded by declared stage type', () => {
+      it('fails if no stage is first or not preceded by declared stage type', async () => {
         spyOn(Registry.pipeline, 'getStageConfig').and.callFake((stage: IStage) => {
           if (stage.type === 'withValidation') {
             return buildStageTypeConfig([
@@ -328,7 +329,7 @@ describe('pipelineConfigValidator', () => {
           { type: 'no-validation', refId: 2, requisiteStageRefIds: [] },
         ]);
 
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
         expect(validationResults.stages[0].messages).toEqual(['need a prereq']);
 
@@ -337,12 +338,12 @@ describe('pipelineConfigValidator', () => {
           { type: 'withValidation', refId: 2, requisiteStageRefIds: [1] },
         ]);
 
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
         expect(validationResults.stages[0].messages).toEqual(['need a prereq']);
 
         pipeline.stages[0].type = 'prereq';
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
 
         pipeline = buildPipeline([
@@ -351,11 +352,11 @@ describe('pipelineConfigValidator', () => {
           { type: 'withValidation', refId: 3, requisiteStageRefIds: [2] },
         ]);
 
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
       });
 
-      it('validates against multiple types if present', () => {
+      it('validates against multiple types if present', async () => {
         spyOn(Registry.pipeline, 'getStageConfig').and.callFake((stage: IStage) => {
           if (stage.type === 'withValidation') {
             return buildStageTypeConfig([
@@ -375,12 +376,12 @@ describe('pipelineConfigValidator', () => {
           { type: 'withValidation', refId: 2, requisiteStageRefIds: [1] },
         ]);
 
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
         expect(validationResults.stages[0].messages).toEqual(['need a prereq']);
 
         pipeline.stages[0].type = 'one';
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
 
         pipeline = buildPipeline([
@@ -389,7 +390,7 @@ describe('pipelineConfigValidator', () => {
           { type: 'withValidation', refId: 3, requisiteStageRefIds: [2] },
         ]);
 
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
       });
     });
@@ -419,68 +420,68 @@ describe('pipelineConfigValidator', () => {
         });
       });
 
-      it('non-nested field', () => {
+      it('non-nested field', async () => {
         pipeline = buildPipeline([{ type: 'simpleField' }]);
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
         expect(validationResults.stages[0].messages).toEqual(['need a foo']);
 
         pipeline.stages[0]['foo'] = 4;
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
 
         pipeline.stages[0]['foo'] = 0;
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
 
         pipeline.stages[0]['foo'] = '';
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
 
         pipeline.stages[0]['foo'] = null;
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
       });
 
-      it('nested field', () => {
+      it('nested field', async () => {
         pipeline = buildPipeline([{ type: 'nestedField' }]);
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
         expect(validationResults.stages[0].messages).toEqual(['need a foo.bar.baz']);
 
         pipeline.stages[0]['foo'] = 4;
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
 
         pipeline.stages[0]['foo'] = { bar: 1 };
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
 
         pipeline.stages[0]['foo'] = { bar: { baz: null } };
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
 
         pipeline.stages[0]['foo'] = { bar: { baz: '' } };
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
 
         pipeline.stages[0]['foo'] = { bar: { baz: 0 } };
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
 
         pipeline.stages[0]['foo'] = { bar: { baz: 'ok' } };
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
       });
 
-      it('empty array', () => {
+      it('empty array', async () => {
         pipeline = buildPipeline([{ type: 'simpleField', foo: [] }]);
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
         expect(validationResults.stages[0].messages).toEqual(['need a foo']);
 
         pipeline.stages[0]['foo'].push(1);
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
       });
     });
@@ -500,16 +501,16 @@ describe('pipelineConfigValidator', () => {
         });
       });
 
-      it('flags when no deploy step present', () => {
+      it('flags when no deploy step present', async () => {
         pipeline = buildPipeline([
           { type: 'targetCheck', regions: ['us-east-1'], credentials: 'test', cluster: 'deck-main' },
         ]);
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
         expect(validationResults.stages[0].messages).toEqual(['mismatch detected']);
       });
 
-      it('passes without stack or details', () => {
+      it('passes without stack or details', async () => {
         pipeline = buildPipeline([
           {
             type: 'deploy',
@@ -525,11 +526,11 @@ describe('pipelineConfigValidator', () => {
             cluster: 'deck',
           },
         ]);
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
       });
 
-      it('passes with stack', () => {
+      it('passes with stack', async () => {
         pipeline = buildPipeline([
           {
             type: 'deploy',
@@ -545,11 +546,11 @@ describe('pipelineConfigValidator', () => {
             cluster: 'deck-main',
           },
         ]);
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
       });
 
-      it('passes with freeFormDetails', () => {
+      it('passes with freeFormDetails', async () => {
         pipeline = buildPipeline([
           {
             type: 'deploy',
@@ -567,11 +568,11 @@ describe('pipelineConfigValidator', () => {
             cluster: 'deck--main',
           },
         ]);
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
       });
 
-      it('passes with stack and freeFormDetails', () => {
+      it('passes with stack and freeFormDetails', async () => {
         pipeline = buildPipeline([
           {
             type: 'deploy',
@@ -595,11 +596,11 @@ describe('pipelineConfigValidator', () => {
             cluster: 'deck-main-foo',
           },
         ]);
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
       });
 
-      it('passes single region', () => {
+      it('passes single region', async () => {
         pipeline = buildPipeline([
           {
             type: 'deploy',
@@ -615,11 +616,11 @@ describe('pipelineConfigValidator', () => {
             cluster: 'deck-main',
           },
         ]);
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
       });
 
-      it('passes multiple regions in same deploy stage', () => {
+      it('passes multiple regions in same deploy stage', async () => {
         pipeline = buildPipeline([
           {
             type: 'deploy',
@@ -638,11 +639,11 @@ describe('pipelineConfigValidator', () => {
             cluster: 'deck-main',
           },
         ]);
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
       });
 
-      it('passes multiple regions scattered across deploy stages', () => {
+      it('passes multiple regions scattered across deploy stages', async () => {
         pipeline = buildPipeline([
           {
             type: 'deploy',
@@ -663,11 +664,11 @@ describe('pipelineConfigValidator', () => {
             cluster: 'deck-main',
           },
         ]);
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
       });
 
-      it('flags credentials mismatch', () => {
+      it('flags credentials mismatch', async () => {
         pipeline = buildPipeline([
           {
             type: 'deploy',
@@ -683,12 +684,12 @@ describe('pipelineConfigValidator', () => {
             cluster: 'deck-main',
           },
         ]);
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
         expect(validationResults.stages[0].messages).toEqual(['mismatch detected']);
       });
 
-      it('flags region mismatch', () => {
+      it('flags region mismatch', async () => {
         pipeline = buildPipeline([
           {
             type: 'deploy',
@@ -704,12 +705,12 @@ describe('pipelineConfigValidator', () => {
             cluster: 'deck-main',
           },
         ]);
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
         expect(validationResults.stages[0].messages).toEqual(['mismatch detected']);
       });
 
-      it('flags cluster mismatch - no stack or freeFormDetails', () => {
+      it('flags cluster mismatch - no stack or freeFormDetails', async () => {
         pipeline = buildPipeline([
           {
             type: 'deploy',
@@ -725,12 +726,12 @@ describe('pipelineConfigValidator', () => {
             cluster: 'deck2',
           },
         ]);
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
         expect(validationResults.stages[0].messages).toEqual(['mismatch detected']);
       });
 
-      it('flags cluster mismatch on stack', () => {
+      it('flags cluster mismatch on stack', async () => {
         pipeline = buildPipeline([
           {
             type: 'deploy',
@@ -748,12 +749,12 @@ describe('pipelineConfigValidator', () => {
             cluster: 'deck-main',
           },
         ]);
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
         expect(validationResults.stages[0].messages).toEqual(['mismatch detected']);
       });
 
-      it('flags cluster mismatch on freeFormDetails', () => {
+      it('flags cluster mismatch on freeFormDetails', async () => {
         pipeline = buildPipeline([
           {
             type: 'deploy',
@@ -771,7 +772,7 @@ describe('pipelineConfigValidator', () => {
             cluster: 'deck--bar',
           },
         ]);
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
         expect(validationResults.stages[0].messages).toEqual(['mismatch detected']);
       });
@@ -797,16 +798,16 @@ describe('pipelineConfigValidator', () => {
         );
       });
 
-      it('skips validation if skipValidation method returns true', () => {
+      it('skips validation if skipValidation method returns true', async () => {
         pipeline = buildPipeline([{ name: 'skip' }]);
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
         expect(validationCalled).toBe(false);
       });
 
-      it('calls validation if skipValidation method returns false', () => {
+      it('calls validation if skipValidation method returns false', async () => {
         pipeline = buildPipeline([{ name: 'not skip' }]);
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(true);
         expect(validationResults.stages[0].messages).toEqual(['did not skip']);
         expect(validationCalled).toBe(true);
@@ -833,13 +834,13 @@ describe('pipelineConfigValidator', () => {
         });
       });
 
-      it('calls custom validator', () => {
+      it('calls custom validator', async () => {
         pipeline = buildPipeline([{ type: 'targetCheck', name: 'goodName' }]);
-        validate();
+        await validate();
         expect(validationResults.hasWarnings).toBe(false);
 
         pipeline.stages[0].name = 'bad name';
-        validate();
+        await validate();
         expect(validationResults.stages.length).toBe(1);
         expect(validationResults.stages[0].messages).toEqual(['No spaces in targetCheck stage names']);
       });
@@ -860,10 +861,10 @@ describe('pipelineConfigValidator', () => {
         return buildStageTypeConfig();
       });
 
-      spyOn(ServiceAccountReader, 'getServiceAccounts').and.returnValue($q.resolve(['my-account']));
+      spyOn(ServiceAccountReader, 'getServiceAccounts').and.returnValue(Promise.resolve(['my-account']));
     });
 
-    it('calls service account access validator', () => {
+    it('calls service account access validator', async () => {
       const trigger = {
         type: 'targetCheck',
         name: 'git trigger',
@@ -871,11 +872,11 @@ describe('pipelineConfigValidator', () => {
       } as ITriggerWithServiceAccount;
       pipeline = buildPipeline([trigger]);
 
-      validate();
+      await validate();
       expect(validationResults.hasWarnings).toBe(false);
 
       trigger.runAsUser = 'account-I-do-not-have-access-to';
-      validate();
+      await validate();
       expect(validationResults.stages.length).toBe(1);
       expect(validationResults.stages[0].messages).toEqual(['Not allowed!']);
     });