@spinnaker/core 0.19.3 → 0.20.1

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@spinnaker/core",
   "license": "Apache-2.0",
-  "version": "0.19.3",
+  "version": "0.20.1",
   "module": "dist/index.js",
   "typings": "dist/index.d.ts",
   "scripts": {
@@ -74,7 +74,7 @@
     "react-virtualized": "9.18.5",
     "react-virtualized-select": "3.1.3",
     "react2angular": "3.2.1",
-    "recoil": "0.0.10",
+    "recoil": "0.7.2",
     "rxjs": "6.6.7",
     "select2": "3.5.1",
     "select2-bootstrap-css": "1.4.6",
@@ -120,5 +120,5 @@
     "shx": "0.3.3",
     "typescript": "4.3.5"
   },
-  "gitHead": "4e2ec409f093985f4c084f8140c650f29bb9009b"
+  "gitHead": "d54989b80af2ae88d41b110bed090cd99a602608"
 }

package/src/application/config/applicationAttributes.directive.html

@@ -1,4 +1,4 @@
-<dl class="dl-horizontal" ng-if="(config.application.attributes && config.application.attributes.email)">
+<dl class="dl-horizontal" ng-if="(vm.application.attributes && vm.application.attributes.email)">
   <dt>Owner</dt>
   <dd>{{vm.application.attributes.email}}</dd>
   <dt ng-if="vm.application.attributes.appGroup">App Group <help-field key="application.group"></help-field></dt>
@@ -55,11 +55,11 @@
     <dd>{{vm.permissions}}</dd>
   </render-if-feature>
 </dl>
-<p ng-if="(!config.application.attributes || !config.application.attributes.email)">
+<p ng-if="(!vm.application.attributes || !vm.application.attributes.email)">
   This application has not been configured.
 </p>
 <button class="btn btn-link" ng-click="vm.editApplication()">
   <span class="glyphicon glyphicon-cog"></span>
-  {{ (!config.application.attributes || !config.application.attributes.email) ? "Create Application" : "Edit Application
+  {{ (!vm.application.attributes || !vm.application.attributes.email) ? "Create Application" : "Edit Application
   Attributes"}}
 </button>

package/src/application/nav/navAtoms.ts

@@ -1,7 +1,25 @@
 import { atom } from 'recoil';
-import { CollapsibleSectionStateCache } from '../../cache/collapsibleSectionStateCache';
+import { CollapsibleSectionStateCache } from '../../cache';
 
 export const verticalNavExpandedAtom = atom({
   key: 'verticalNavExpanded',
   default: !CollapsibleSectionStateCache.isSet('verticalNav') || CollapsibleSectionStateCache.isExpanded('verticalNav'),
+  effects: [
+    ({ setSelf, trigger }) => {
+      if (trigger === 'get') {
+        // Avoid expensive initialization
+        setSelf(
+          !CollapsibleSectionStateCache.isSet('verticalNav') || CollapsibleSectionStateCache.isExpanded('verticalNav'),
+        );
+      }
+      CollapsibleSectionStateCache.onChange('verticalNav', (expanded: boolean) => {
+        setSelf(expanded);
+      });
+
+      return () => {
+        // clean up
+        CollapsibleSectionStateCache.onChange('verticalNav', null);
+      };
+    },
+  ],
 });

package/src/cache/collapsibleSectionStateCache.ts

@@ -5,6 +5,7 @@ export class CollapsibleSectionStateCacheInternal {
   private cacheFactory = new CacheFactory();
   private cacheId = 'collapsibleSectionStateCache';
   private stateCache: Cache;
+  private handlers = new Map();
 
   constructor() {
     try {
@@ -31,6 +32,16 @@ export class CollapsibleSectionStateCacheInternal {
   public setExpanded(heading: string, expanded: boolean) {
     if (heading) {
       this.stateCache.put(heading, !!expanded);
+      const handler = this.handlers.get(heading);
+      if (handler) {
+        handler(!CollapsibleSectionStateCache.isSet(heading) || CollapsibleSectionStateCache.isExpanded(heading));
+      }
+    }
+  }
+
+  public onChange(heading: string, listener: Function) {
+    if (!this.handlers.get(heading)) {
+      this.handlers.set(heading, listener);
     }
   }
 }

package/src/pipeline/config/stages/bakeManifest/helm/BakeHelmConfigForm.tsx

@@ -34,6 +34,7 @@ export class BakeHelmConfigForm extends React.Component<IFormikStageConfigInject
     ArtifactTypePatterns.S3_OBJECT,
     ArtifactTypePatterns.HELM_CHART,
     ArtifactTypePatterns.HTTP_FILE,
+    ArtifactTypePatterns.ORACLE_OBJECT,
   );
 
   public componentDidMount() {

package/src/pipeline/executions/execution/ExecutionMarker.tsx

@@ -7,7 +7,7 @@ import { OrchestratedItemRunningTime } from './OrchestratedItemRunningTime';
 import type { Application } from '../../../application/application.model';
 import { SETTINGS } from '../../../config/settings';
 import { ExecutionBarLabel } from '../../config/stages/common/ExecutionBarLabel';
-import type { IExecution, IExecutionStageSummary } from '../../../domain';
+import type { IExecution, IExecutionStageSummary, IStage } from '../../../domain';
 import { logger } from '../../../utils';
 import { duration } from '../../../utils/timeFormatters';
 
@@ -94,7 +94,19 @@ export class ExecutionMarker extends React.Component<IExecutionMarkerProps, IExe
 
   public render() {
     const { stage, application, execution, active, previousStageActive, width } = this.props;
-    const stageType = (stage.activeStageType || stage.type).toLowerCase(); // support groups
+    let stageType = (stage.activeStageType || stage.type).toLowerCase(); // support groups
+    stage.stages.forEach((childStage: IStage) => {
+      if (childStage.type == 'pipeline') {
+        const childPipeline = application.executions.data.find((p: any) => p.id === childStage.context.executionId);
+        if (childPipeline != undefined) {
+          childPipeline.stages.forEach((stageToCheck: IStage) => {
+            if (stageToCheck.type == 'manualJudgment' && stageToCheck.status == 'RUNNING') {
+              stageType = 'manualjudgment';
+            }
+          });
+        }
+      }
+    });
     const pipelineStatus = this.stageStatus(stage.status.toLowerCase());
     const markerClassName = [
       stage.type !== 'group' ? 'clickable' : '',