@spinnaker/core 0.19.2 → 0.20.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@spinnaker/core",
   "license": "Apache-2.0",
-  "version": "0.19.2",
+  "version": "0.20.0",
   "module": "dist/index.js",
   "typings": "dist/index.d.ts",
   "scripts": {
@@ -74,7 +74,7 @@
     "react-virtualized": "9.18.5",
     "react-virtualized-select": "3.1.3",
     "react2angular": "3.2.1",
-    "recoil": "0.0.10",
+    "recoil": "0.7.2",
     "rxjs": "6.6.7",
     "select2": "3.5.1",
     "select2-bootstrap-css": "1.4.6",
@@ -120,5 +120,5 @@
     "shx": "0.3.3",
     "typescript": "4.3.5"
   },
-  "gitHead": "3ea12b48839ff145c4a602d489507f317b06f856"
+  "gitHead": "d5ceedd9f745e6f1156f6b5e25275cc311d4f0ab"
 }

package/src/application/config/applicationAttributes.directive.html

@@ -1,4 +1,4 @@
-<dl class="dl-horizontal" ng-if="(config.application.attributes && config.application.attributes.email)">
+<dl class="dl-horizontal" ng-if="(vm.application.attributes && vm.application.attributes.email)">
   <dt>Owner</dt>
   <dd>{{vm.application.attributes.email}}</dd>
   <dt ng-if="vm.application.attributes.appGroup">App Group <help-field key="application.group"></help-field></dt>
@@ -55,11 +55,11 @@
     <dd>{{vm.permissions}}</dd>
   </render-if-feature>
 </dl>
-<p ng-if="(!config.application.attributes || !config.application.attributes.email)">
+<p ng-if="(!vm.application.attributes || !vm.application.attributes.email)">
   This application has not been configured.
 </p>
 <button class="btn btn-link" ng-click="vm.editApplication()">
   <span class="glyphicon glyphicon-cog"></span>
-  {{ (!config.application.attributes || !config.application.attributes.email) ? "Create Application" : "Edit Application
+  {{ (!vm.application.attributes || !vm.application.attributes.email) ? "Create Application" : "Edit Application
   Attributes"}}
 </button>

package/src/application/nav/navAtoms.ts

@@ -1,7 +1,25 @@
 import { atom } from 'recoil';
-import { CollapsibleSectionStateCache } from '../../cache/collapsibleSectionStateCache';
+import { CollapsibleSectionStateCache } from '../../cache';
 
 export const verticalNavExpandedAtom = atom({
   key: 'verticalNavExpanded',
   default: !CollapsibleSectionStateCache.isSet('verticalNav') || CollapsibleSectionStateCache.isExpanded('verticalNav'),
+  effects: [
+    ({ setSelf, trigger }) => {
+      if (trigger === 'get') {
+        // Avoid expensive initialization
+        setSelf(
+          !CollapsibleSectionStateCache.isSet('verticalNav') || CollapsibleSectionStateCache.isExpanded('verticalNav'),
+        );
+      }
+      CollapsibleSectionStateCache.onChange('verticalNav', (expanded: boolean) => {
+        setSelf(expanded);
+      });
+
+      return () => {
+        // clean up
+        CollapsibleSectionStateCache.onChange('verticalNav', null);
+      };
+    },
+  ],
 });

package/src/cache/collapsibleSectionStateCache.ts

@@ -5,6 +5,7 @@ export class CollapsibleSectionStateCacheInternal {
   private cacheFactory = new CacheFactory();
   private cacheId = 'collapsibleSectionStateCache';
   private stateCache: Cache;
+  private handlers = new Map();
 
   constructor() {
     try {
@@ -31,6 +32,16 @@ export class CollapsibleSectionStateCacheInternal {
   public setExpanded(heading: string, expanded: boolean) {
     if (heading) {
       this.stateCache.put(heading, !!expanded);
+      const handler = this.handlers.get(heading);
+      if (handler) {
+        handler(!CollapsibleSectionStateCache.isSet(heading) || CollapsibleSectionStateCache.isExpanded(heading));
+      }
+    }
+  }
+
+  public onChange(heading: string, listener: Function) {
+    if (!this.handlers.get(heading)) {
+      this.handlers.set(heading, listener);
     }
   }
 }

package/src/pipeline/config/stages/bakeManifest/helm/BakeHelmConfigForm.tsx

@@ -34,6 +34,7 @@ export class BakeHelmConfigForm extends React.Component<IFormikStageConfigInject
     ArtifactTypePatterns.S3_OBJECT,
     ArtifactTypePatterns.HELM_CHART,
     ArtifactTypePatterns.HTTP_FILE,
+    ArtifactTypePatterns.ORACLE_OBJECT,
   );
 
   public componentDidMount() {

package/src/presentation/forms/validation/validators.ts

@@ -4,11 +4,15 @@ import { robotToHuman } from '../../robotToHumanFilter/robotToHuman.filter';
 import type { IValidator } from './validation';
 
 const THIS_FIELD = 'This field';
+// RCF 5322 Email Validation Regex taken from https://emailregex.com/
+const VALID_EMAIL_REGEX = new RegExp(
+  '^(([^<>()\\[\\]\\\\.,;:\\s@"]+(\\.[^<>()\\[\\]\\\\.,;:\\s@"]+)*)|(".+"))@((\\[[0-9]{1,3}\\.[0-9]{1,3}\\.[0-9]{1,3}\\.[0-9]{1,3}])|(([a-zA-Z\\-0-9]+\\.)+[a-zA-Z]{2,}))$',
+);
 
 const emailValue = (message?: string): IValidator => {
   return function emailValue(val: string, label = THIS_FIELD) {
     message = message || `${label} is not a valid email address.`;
-    return val && !/^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$/i.test(val) && message;
+    return val && !VALID_EMAIL_REGEX.test(val) && message;
   };
 };