@spinnaker/core 0.19.1 → 0.19.4

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@spinnaker/core",
   "license": "Apache-2.0",
-  "version": "0.19.1",
+  "version": "0.19.4",
   "module": "dist/index.js",
   "typings": "dist/index.d.ts",
   "scripts": {
@@ -25,9 +25,9 @@
     "@uirouter/react-hybrid": "1.0.2",
     "@uirouter/rx": "0.6.5",
     "@uirouter/visualizer": "7.2.1",
-    "angular": "1.6.10",
-    "angular-messages": "1.6.10",
-    "angular-sanitize": "1.6.10",
+    "angular": "1.8.0",
+    "angular-messages": "1.8.0",
+    "angular-sanitize": "1.8.0",
     "angular-spinner": "1.0.1",
     "angular-ui-bootstrap": "2.5.0",
     "angular-ui-sortable": "0.17.1",
@@ -120,5 +120,5 @@
     "shx": "0.3.3",
     "typescript": "4.3.5"
   },
-  "gitHead": "8b967e5f649a2373d704ec1d7d9f790ab1e1802e"
+  "gitHead": "3d37fe6b9dfe120308bf0374e7f93146b745f272"
 }

package/src/application/config/applicationAttributes.directive.html

@@ -1,4 +1,4 @@
-<dl class="dl-horizontal" ng-if="(config.application.attributes && config.application.attributes.email)">
+<dl class="dl-horizontal" ng-if="(vm.application.attributes && vm.application.attributes.email)">
   <dt>Owner</dt>
   <dd>{{vm.application.attributes.email}}</dd>
   <dt ng-if="vm.application.attributes.appGroup">App Group <help-field key="application.group"></help-field></dt>
@@ -55,11 +55,11 @@
     <dd>{{vm.permissions}}</dd>
   </render-if-feature>
 </dl>
-<p ng-if="(!config.application.attributes || !config.application.attributes.email)">
+<p ng-if="(!vm.application.attributes || !vm.application.attributes.email)">
   This application has not been configured.
 </p>
 <button class="btn btn-link" ng-click="vm.editApplication()">
   <span class="glyphicon glyphicon-cog"></span>
-  {{ (!config.application.attributes || !config.application.attributes.email) ? "Create Application" : "Edit Application
+  {{ (!vm.application.attributes || !vm.application.attributes.email) ? "Create Application" : "Edit Application
   Attributes"}}
 </button>

package/src/bootstrap/angular.config.ts

@@ -19,13 +19,10 @@ bootstrapModule.config([
   },
 ]);
 
-// Angular 1.6 defaults preAssignBindingsEnabled to false, reset to true to mimic 1.5 behavior.
-// See https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$compile
 bootstrapModule.config([
   '$compileProvider',
   ($compileProvider: ICompileProvider) => {
     $compileProvider.aHrefSanitizationWhitelist(/^\s*(https?|mailto|slack|ssh):/);
-    $compileProvider.preAssignBindingsEnabled(true);
   },
 ]);
 

package/src/forms/checkmap/checkmap.directive.spec.js

@@ -6,15 +6,19 @@ describe('Directives: checkmap', function () {
   beforeEach(window.module(require('./checkmap.directive').name));
 
   beforeEach(
-    window.inject(function ($rootScope, $compile) {
+    window.inject(function ($rootScope, $compile, $rootElement, $document) {
       this.scope = $rootScope.$new();
       this.compile = $compile;
+      this.rootElement = $rootElement;
+      this.document = $document;
     }),
   );
 
   it('updates selections when changed', function () {
     var scope = this.scope,
-      compile = this.compile;
+      compile = this.compile,
+      rootElement = this.rootElement,
+      document = this.document;
 
     scope.itemMap = {
       alphabet: ['a', 'b', 'c', 'd'],
@@ -24,6 +28,11 @@ describe('Directives: checkmap', function () {
 
     var checkmap = compile('<checkmap item-map="itemMap" selected-items="selectedItems"></checkmap>')(scope);
 
+    //Angular 1.7 introduced changes to how checkboxes listen to change events. This primarily impacted tests where components which need to be clicked now need to be appended to the document
+    // See https://docs.angularjs.org/guide/migration#-input-radio-and-input-checkbox-
+    rootElement.append(checkmap);
+    document.find('body').append(rootElement);
+
     scope.$apply();
 
     // Initial state check.

package/src/forms/mapEditor/mapEditor.component.js

@@ -28,19 +28,6 @@ angular
       function ($scope) {
         this.backingModel = [];
 
-        // Set default values for optional fields
-        this.onChange = this.onChange || angular.noop;
-        this.keyLabel = this.keyLabel || 'Key';
-        this.valueLabel = this.valueLabel || 'Value';
-        this.addButtonLabel = this.addButtonLabel || 'Add Field';
-        this.allowEmpty = this.allowEmpty || false;
-        this.labelsLeft = this.labelsLeft || false;
-        this.tableClass = this.label ? '' : 'no-border-top';
-        this.columnCount = this.labelsLeft ? 5 : 3;
-        this.model = this.model || {};
-        this.isParameterized = isString(this.model);
-        this.hiddenKeys = this.hiddenKeys || [];
-
         const modelKeys = () => Object.keys(this.model);
 
         this.addField = () => {
@@ -74,7 +61,22 @@ angular
           }
         };
 
+        // In Angular 1.7 Directive bindings were removed in the constructor, default values now must be instantiated within $onInit
+        // See https://docs.angularjs.org/guide/migration#-compile- and https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$compile
         this.$onInit = () => {
+          // Set default values for optional fields
+          this.onChange = this.onChange || angular.noop;
+          this.keyLabel = this.keyLabel || 'Key';
+          this.valueLabel = this.valueLabel || 'Value';
+          this.addButtonLabel = this.addButtonLabel || 'Add Field';
+          this.allowEmpty = this.allowEmpty || false;
+          this.labelsLeft = this.labelsLeft || false;
+          this.tableClass = this.label ? '' : 'no-border-top';
+          this.columnCount = this.labelsLeft ? 5 : 3;
+          this.model = this.model || {};
+          this.isParameterized = isString(this.model);
+          this.hiddenKeys = this.hiddenKeys || [];
+
           if (this.model && !this.isParameterized) {
             modelKeys().forEach((key) => {
               this.backingModel.push({ key: key, value: this.model[key] });

package/src/forms/mapEditor/mapEditor.component.spec.js

@@ -5,13 +5,6 @@ describe('Component: mapEditor', function () {
 
   beforeEach(window.module(require('./mapEditor.component').name));
 
-  // https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$compile
-  beforeEach(
-    window.module(($compileProvider) => {
-      $compileProvider.preAssignBindingsEnabled(true);
-    }),
-  );
-
   beforeEach(
     window.inject(function ($rootScope, $compile) {
       scope = $rootScope.$new();

package/src/pipeline/config/stages/common/stageConfigField/stageConfigField.directive.js

@@ -25,7 +25,11 @@ module(CORE_PIPELINE_CONFIG_STAGES_COMMON_STAGECONFIGFIELD_STAGECONFIGFIELD_DIRE
       fieldColumns: '@',
     },
     controller: function () {
-      this.fieldColumns = this.fieldColumns || 8;
+      // In Angular 1.7 Directive bindings were removed in the constructor, default values now must be instantiated within $onInit
+      // See https://docs.angularjs.org/guide/migration#-compile- and https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$compile
+      this.$onInit = () => {
+        this.fieldColumns = this.fieldColumns || 8;
+      };
     },
   };
 });

package/src/pipeline/config/stages/common/stageConfigField/stageConfigField.directive.spec.js

@@ -9,13 +9,6 @@ describe('Directives: stageConfigField', function () {
 
   beforeEach(window.module(require('./stageConfigField.directive').name));
 
-  // https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$compile
-  beforeEach(
-    window.module(($compileProvider) => {
-      $compileProvider.preAssignBindingsEnabled(true);
-    }),
-  );
-
   beforeEach(
     window.inject(function ($rootScope, $compile) {
       scope = $rootScope.$new();

package/src/presentation/forms/validation/validators.ts

@@ -4,11 +4,15 @@ import { robotToHuman } from '../../robotToHumanFilter/robotToHuman.filter';
 import type { IValidator } from './validation';
 
 const THIS_FIELD = 'This field';
+// RCF 5322 Email Validation Regex taken from https://emailregex.com/
+const VALID_EMAIL_REGEX = new RegExp(
+  '^(([^<>()\\[\\]\\\\.,;:\\s@"]+(\\.[^<>()\\[\\]\\\\.,;:\\s@"]+)*)|(".+"))@((\\[[0-9]{1,3}\\.[0-9]{1,3}\\.[0-9]{1,3}\\.[0-9]{1,3}])|(([a-zA-Z\\-0-9]+\\.)+[a-zA-Z]{2,}))$',
+);
 
 const emailValue = (message?: string): IValidator => {
   return function emailValue(val: string, label = THIS_FIELD) {
     message = message || `${label} is not a valid email address.`;
-    return val && !/^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$/i.test(val) && message;
+    return val && !VALID_EMAIL_REGEX.test(val) && message;
   };
 };
 

package/src/projects/dashboard/cluster/projectCluster.directive.spec.js

@@ -7,13 +7,6 @@ describe('Directives: projectCluster', function () {
 
   var $compile, $scope;
 
-  // https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$compile
-  beforeEach(
-    window.module(($compileProvider) => {
-      $compileProvider.preAssignBindingsEnabled(true);
-    }),
-  );
-
   beforeEach(
     window.inject(function ($rootScope, _$compile_) {
       $scope = $rootScope.$new();