@spinnaker/core 0.14.2 → 0.16.1

package/src/pipeline/details/StageFailureMessage.tsx

@@ -71,18 +71,33 @@ export class StageFailureMessage extends React.Component<IStageFailureMessagePro
   }
 
   public render() {
-    const { message, messages } = this.props;
+    const { message, messages, stage } = this.props;
     const { isFailed, failedTask, failedExecutionId, failedStageName, failedStageId } = this.state;
-    if (isFailed || failedTask || message || messages.length) {
+
+    let stageMessages = message || !messages.length ? [message] : messages;
+    if (stageMessages.length > 0) {
       const exceptionTitle = isFailed ? (messages.length ? 'Exceptions' : 'Exception') : 'Warning';
-      const displayMessages =
-        message || !messages.length ? (
-          <Markdown message={message || StageFailureMessages.NO_REASON_PROVIDED} className="break-word" />
-        ) : (
-          messages.map((m, i) => (
-            <Markdown key={i} message={m || StageFailureMessages.NO_REASON_PROVIDED} className="break-word" />
-          ))
-        );
+
+      // expression evaluation warnings can get really long and hide actual failure messages, source
+      // filter out expression evaluation failure messages if either:
+      // - there was a stage failure (and failed expressions don't fail the stage)
+      // - expression evaluation was explicitly disabled for the stage(as Orca still processes expressions and populates
+      //   warnings when evaluation is disabled disabled)
+      const shouldFilterExpressionFailures =
+        (isFailed && !stage.context?.failOnFailedExpressions) || stage.context?.skipExpressionEvaluation;
+
+      if (shouldFilterExpressionFailures) {
+        stageMessages = stageMessages.filter((m) => !m.startsWith('Failed to evaluate'));
+
+        if (stageMessages.length === 0) {
+          // no messages to be displayed after filtering
+          return null;
+        }
+      }
+
+      const displayMessages = stageMessages.map((m, i) => (
+        <Markdown key={i} message={m || StageFailureMessages.NO_REASON_PROVIDED} className="break-word" />
+      ));
 
       if (displayMessages) {
         return (

package/src/pipeline/details/executionDetailsSection.service.spec.ts

@@ -1,7 +1,8 @@
+import type { StateParams, StateService } from '@uirouter/angularjs';
 import { mock, noop } from 'angular';
-import { StateParams, StateService } from '@uirouter/angularjs';
 
-import { EXECUTION_DETAILS_SECTION_SERVICE, ExecutionDetailsSectionService } from './executionDetailsSection.service';
+import type { ExecutionDetailsSectionService } from './executionDetailsSection.service';
+import { EXECUTION_DETAILS_SECTION_SERVICE } from './executionDetailsSection.service';
 
 describe('executionDetailsSectionService', function () {
   let $state: StateService,

package/src/pipeline/executions/Executions.spec.tsx

@@ -1,15 +1,18 @@
-import React from 'react';
-import { ReactWrapper, mount } from 'enzyme';
+import type { IScope } from 'angular';
+import { mock, noop } from 'angular';
+import type { ReactWrapper } from 'enzyme';
+import { mount } from 'enzyme';
 import { set } from 'lodash';
-import { IScope, mock, noop } from 'angular';
+import React from 'react';
 
-import { Application } from '../../application';
+import type { IExecutionsProps, IExecutionsState } from './Executions';
+import { Executions } from './Executions';
+import type { Application } from '../../application';
 import { ApplicationModelBuilder } from '../../application/applicationModel.builder';
 import { INSIGHT_FILTER_STATE_MODEL } from '../../insight/insightFilterState.model';
-import { REACT_MODULE } from '../../reactShims';
 import { OVERRIDE_REGISTRY } from '../../overrideRegistry';
+import { REACT_MODULE } from '../../reactShims';
 import * as State from '../../state';
-import { IExecutionsProps, IExecutionsState, Executions } from './Executions';
 import { Spinner } from '../../widgets/spinners/Spinner';
 
 describe('<Executions/>', () => {

package/src/pipeline/executions/executionAction/ExecutionAction.spec.tsx

@@ -1,5 +1,5 @@
+import { mount, shallow } from 'enzyme';
 import React from 'react';
-import { shallow, mount } from 'enzyme';
 
 import { ExecutionAction } from './ExecutionAction';
 

package/src/pipeline/executions/executionGroup/ExecutionGroup.tsx

@@ -9,6 +9,7 @@ import { MigrationTag } from './MigrationTag';
 import { AccountTag } from '../../../account';
 import type { Application } from '../../../application/application.model';
 import { CollapsibleSectionStateCache } from '../../../cache';
+import { SETTINGS } from '../../../config/settings';
 import { PipelineTemplateReader, PipelineTemplateV2Service } from '../../config/templates';
 import type {
   IExecution,
@@ -36,7 +37,7 @@ import { Spinner } from '../../../widgets/spinners/Spinner';
 
 import './executionGroup.less';
 
-const ACCOUNT_TAG_OVERFLOW_LIMIT = 1;
+const ACCOUNT_TAG_OVERFLOW_LIMIT = SETTINGS.accountTagLimit ?? 1;
 
 export interface IExecutionGroupProps {
   group: IExecutionGroup;

package/src/pipeline/filter/executionFilter.service.spec.ts

@@ -1,5 +1,5 @@
+import type { ExecutionFilterModel } from './ExecutionFilterModel';
 import { ExecutionFilterService } from './executionFilter.service';
-import { ExecutionFilterModel } from './ExecutionFilterModel';
 import { ExecutionState } from '../../state';
 
 describe('ExecutionFilterService', function () {

package/src/pipeline/pipeline.dataSource.spec.ts

@@ -1,10 +1,11 @@
-import { IQProvider, mock } from 'angular';
+import type { IQProvider } from 'angular';
+import { mock } from 'angular';
 
-import { Application } from '../application/application.model';
+import type { Application } from '../application/application.model';
 import { ApplicationModelBuilder } from '../application/applicationModel.builder';
 import { ApplicationDataSourceRegistry } from '../application/service/ApplicationDataSourceRegistry';
-import { EXECUTION_SERVICE } from './service/execution.service';
 import { PipelineConfigService } from './config/services/PipelineConfigService';
+import { EXECUTION_SERVICE } from './service/execution.service';
 
 describe('Pipeline Data Source', function () {
   let application: Application, executionService: any, $scope: ng.IScope, $q: ng.IQService;
@@ -93,8 +94,8 @@ describe('Pipeline Data Source', function () {
 
     it('sets appropriate flags when executions reload fails; subscriber is responsible for error checking', function () {
       spyOn(executionService, 'getExecutions').and.returnValue($q.reject(null));
-      let errorsHandled = 0,
-        successesHandled = 0;
+      let errorsHandled = 0;
+      let successesHandled = 0;
       configureApplication();
       application.getDataSource('executions').activate();
 
@@ -141,8 +142,8 @@ describe('Pipeline Data Source', function () {
     it('sets appropriate flags when pipeline config reload fails; subscriber is responsible for error checking', function () {
       spyOn(PipelineConfigService, 'getPipelinesForApplication').and.returnValue($q.when([]));
       spyOn(PipelineConfigService, 'getStrategiesForApplication').and.returnValue($q.reject([]));
-      let errorsHandled = 0,
-        successesHandled = 0;
+      let errorsHandled = 0;
+      let successesHandled = 0;
       configureApplication();
       application.getDataSource('pipelineConfigs').activate();
 

package/src/pipeline/service/ExecutionsTransformer.spec.ts

@@ -1,8 +1,8 @@
 import { map } from 'lodash';
 
-import { Application } from '../../application';
 import { ExecutionsTransformer } from './ExecutionsTransformer';
-import { IExecution } from '../../domain';
+import type { Application } from '../../application';
+import type { IExecution } from '../../domain';
 
 describe('ExecutionTransformerService', function () {
   describe('transformExecution', () => {

package/src/pipeline/service/execution.service.spec.ts

@@ -1,10 +1,12 @@
+import type { IQProvider, IQService, ITimeoutService } from 'angular';
+import { mock, noop } from 'angular';
+
 import { mockHttpClient } from '../../api/mock/jasmine';
-import { IQProvider, IQService, ITimeoutService, mock, noop } from 'angular';
+import type { Application } from '../../application';
+import type { IExecution } from '../../domain';
+import type { ExecutionService } from './execution.service';
+import { EXECUTION_SERVICE } from './execution.service';
 import { REACT_MODULE } from '../../reactShims';
-
-import { EXECUTION_SERVICE, ExecutionService } from './execution.service';
-import { IExecution } from '../../domain';
-import { Application } from '../../application';
 import * as State from '../../state';
 
 describe('Service: executionService', () => {

package/src/pipeline/status/Artifact.spec.tsx

@@ -1,11 +1,12 @@
-import React from 'react';
-import { ShallowWrapper, shallow } from 'enzyme';
 import { mock } from 'angular';
-import { REACT_MODULE } from '../../reactShims';
-
-import { IArtifact } from '../../domain';
+import type { ShallowWrapper } from 'enzyme';
+import { shallow } from 'enzyme';
+import React from 'react';
 
-import { Artifact, IArtifactProps } from './Artifact';
+import type { IArtifactProps } from './Artifact';
+import { Artifact } from './Artifact';
+import type { IArtifact } from '../../domain';
+import { REACT_MODULE } from '../../reactShims';
 
 const ARTIFACT_TYPE = 'docker/image';
 const ARTIFACT_NAME = 'example.com/container';

package/src/pipeline/status/ArtifactList.spec.tsx

@@ -1,12 +1,13 @@
-import React from 'react';
-import { ShallowWrapper, shallow } from 'enzyme';
 import { mock } from 'angular';
-import { REACT_MODULE } from '../../reactShims';
-
-import { IArtifact } from '../../domain';
+import type { ShallowWrapper } from 'enzyme';
+import { shallow } from 'enzyme';
+import React from 'react';
 
 import { Artifact } from './Artifact';
-import { ArtifactList, IArtifactListProps } from './ArtifactList';
+import type { IArtifactListProps } from './ArtifactList';
+import { ArtifactList } from './ArtifactList';
+import type { IArtifact } from '../../domain';
+import { REACT_MODULE } from '../../reactShims';
 
 const ARTIFACT_TYPE = 'docker/image';
 const ARTIFACT_NAME = 'example.com/container';

package/src/pipeline/status/ExecutionParameters.spec.tsx

@@ -1,11 +1,12 @@
-import React from 'react';
-import { ShallowWrapper, shallow } from 'enzyme';
 import { mock } from 'angular';
+import type { ShallowWrapper } from 'enzyme';
+import { shallow } from 'enzyme';
+import React from 'react';
 
+import type { IDisplayableParameter, IExecutionParametersProps } from './ExecutionParameters';
+import { ExecutionParameters } from './ExecutionParameters';
 import { REACT_MODULE } from '../../reactShims';
 
-import { IExecutionParametersProps, ExecutionParameters, IDisplayableParameter } from './ExecutionParameters';
-
 describe('<ExecutionParameters/>', () => {
   let component: ShallowWrapper<IExecutionParametersProps>;
 

package/src/pipeline/status/ResolvedArtifactList.spec.tsx

@@ -1,12 +1,13 @@
-import React from 'react';
-import { ShallowWrapper, shallow } from 'enzyme';
 import { mock } from 'angular';
-import { REACT_MODULE } from '../../reactShims';
+import type { ShallowWrapper } from 'enzyme';
+import { shallow } from 'enzyme';
+import React from 'react';
 
-import { IArtifact, IExpectedArtifact } from '../../domain';
 import { Artifact } from './Artifact';
-
-import { ResolvedArtifactList, IResolvedArtifactListProps } from './ResolvedArtifactList';
+import type { IResolvedArtifactListProps } from './ResolvedArtifactList';
+import { ResolvedArtifactList } from './ResolvedArtifactList';
+import type { IArtifact, IExpectedArtifact } from '../../domain';
+import { REACT_MODULE } from '../../reactShims';
 
 const ARTIFACT_TYPE = 'docker/image';
 const ARTIFACT_NAME = 'example.com/container';

package/src/plugins/deck.plugin.spec.ts

@@ -1,7 +1,9 @@
-import { SearchResultType, searchResultTypeRegistry } from '../search/searchResult';
-import { IDeckPlugin, registerPluginExtensions } from './deck.plugin';
+import type { IDeckPlugin } from './deck.plugin';
+import { registerPluginExtensions } from './deck.plugin';
 import { HelpContentsRegistry } from '../help';
 import { Registry } from '../registry';
+import type { SearchResultType } from '../search/searchResult';
+import { searchResultTypeRegistry } from '../search/searchResult';
 
 describe('deck plugin registerPluginExtensions', () => {
   it('returns a promise', async () => {

package/src/plugins/plugin.registry.spec.ts

@@ -1,9 +1,11 @@
-import { IStageTypeConfig } from '../domain';
-import { IDeckPlugin } from './deck.plugin';
+import { mock } from 'angular';
+
 import { RequestBuilder } from '../api';
-import { IPluginMetaData, PluginRegistry } from './plugin.registry';
+import type { IDeckPlugin } from './deck.plugin';
+import type { IStageTypeConfig } from '../domain';
+import type { IPluginMetaData } from './plugin.registry';
+import { PluginRegistry } from './plugin.registry';
 import { Registry } from '../registry';
-import { mock } from 'angular';
 
 const fakePromise = (result: any = undefined) => () => new Promise((resolve) => resolve(result));
 

package/src/presentation/forms/SpinFormik.spec.tsx

@@ -1,6 +1,7 @@
-import React from 'react';
 import { mount } from 'enzyme';
-import { FormikProps } from 'formik';
+import type { FormikProps } from 'formik';
+import React from 'react';
+
 import { SpinFormik } from './SpinFormik';
 
 describe('SpinFormik', () => {

package/src/presentation/forms/fields/FormikFormField.spec.tsx

@@ -1,11 +1,11 @@
-import { FormikProps } from 'formik/dist/types';
-import React from 'react';
 import { mount } from 'enzyme';
+import type { FormikProps } from 'formik/dist/types';
+import React from 'react';
 
+import type { IFormInputProps } from '../..';
 import {
   FormikFormField,
   FormikSpelContextProvider,
-  IFormInputProps,
   ReactSelectInput,
   SpelToggle,
   SpinFormik,

package/src/presentation/forms/hooks/useSaveRestoreMutuallyExclusiveFields.hook.spec.tsx

@@ -1,10 +1,11 @@
 import { mount } from 'enzyme';
-import { useSaveRestoreMutuallyExclusiveFields } from './useSaveRestoreMutuallyExclusiveFields.hook';
-import { Formik, FormikProps } from 'formik';
+import type { Formik, FormikProps } from 'formik';
 import React from 'react';
+
+import { SpinFormik } from '../SpinFormik';
 import { FormikFormField } from '../fields';
 import { SelectInput } from '../inputs';
-import { SpinFormik } from '../SpinFormik';
+import { useSaveRestoreMutuallyExclusiveFields } from './useSaveRestoreMutuallyExclusiveFields.hook';
 
 function PizzaComponent() {
   return (

package/src/presentation/forms/inputs/ChecklistInput.spec.tsx

@@ -1,5 +1,5 @@
-import React from 'react';
 import { mount } from 'enzyme';
+import React from 'react';
 
 import { ChecklistInput } from './ChecklistInput';
 

package/src/presentation/forms/inputs/RadioButtonInput.spec.tsx

@@ -1,5 +1,6 @@
-import React from 'react';
 import { mount } from 'enzyme';
+import React from 'react';
+
 import { RadioButtonInput } from './RadioButtonInput';
 
 const noop = () => {};

package/src/presentation/forms/inputs/SelectInput.spec.tsx

@@ -1,5 +1,6 @@
-import React from 'react';
 import { mount } from 'enzyme';
+import React from 'react';
+
 import { SelectInput } from './SelectInput';
 
 const noop = () => {};

package/src/presentation/forms/inputs/hooks/useInternalValidator.hook.spec.tsx

@@ -1,7 +1,8 @@
-import React from 'react';
 import { mount } from 'enzyme';
-import { IValidator } from '../../../forms/validation';
-import { IFormInputProps, IFormInputValidation } from '../interface';
+import React from 'react';
+
+import type { IValidator } from '../../../forms/validation';
+import type { IFormInputProps, IFormInputValidation } from '../interface';
 import { useInternalValidator } from './useInternalValidator.hook';
 
 function TestInputComponent(props: IFormInputProps & { validator?: IValidator; revalidateDeps?: any[] }) {

package/src/presentation/forms/validation/FormValidator.spec.ts

@@ -1,6 +1,6 @@
-import { Validators } from './validators';
 import { FormValidator } from './FormValidator';
-import { IValidator, IArrayItemValidator } from './validation';
+import type { IArrayItemValidator, IValidator } from './validation';
+import { Validators } from './validators';
 
 const { maxValue, arrayNotEmpty } = Validators;
 

package/src/presentation/forms/validation/useValidationData.spec.tsx

@@ -1,8 +1,9 @@
-import { asyncMessage, errorMessage, infoMessage, messageMessage, successMessage, warningMessage } from './categories';
+import { mount } from 'enzyme';
 import React from 'react';
 
-import { mount } from 'enzyme';
-import { IValidationData, useValidationData } from './useValidationData';
+import { asyncMessage, errorMessage, infoMessage, messageMessage, successMessage, warningMessage } from './categories';
+import type { IValidationData } from './useValidationData';
+import { useValidationData } from './useValidationData';
 
 interface IComponentProps {
   validationMessage: React.ReactNode;

package/src/presentation/hooks/useContainerClassNames.hook.spec.tsx

@@ -1,5 +1,6 @@
-import React from 'react';
 import { mount } from 'enzyme';
+import React from 'react';
+
 import { useContainerClassNames } from './useContainerClassNames.hook';
 
 const TestComponent = ({ classNames }: { classNames: string[] }) => {

package/src/presentation/hooks/useData.hook.spec.tsx

@@ -1,7 +1,8 @@
-import React from 'react';
 import { mount } from 'enzyme';
-import { IUseLatestPromiseResult } from './useLatestPromise.hook';
+import React from 'react';
+
 import { useData } from './useData.hook';
+import type { IUseLatestPromiseResult } from './useLatestPromise.hook';
 
 describe('useData hook', () => {
   function TestComponent(props: any) {

package/src/presentation/hooks/useDebouncedValue.hook.spec.tsx

@@ -1,7 +1,7 @@
+import { mount } from 'enzyme';
 import React from 'react';
 
 import { useDebouncedValue } from './useDebouncedValue.hook';
-import { mount } from 'enzyme';
 
 describe('useDebouncedValue hook', () => {
   beforeEach(() => jasmine.clock().install());

package/src/presentation/hooks/useDeepObjectDiff.hook.spec.tsx

@@ -1,5 +1,6 @@
-import React from 'react';
 import { mount } from 'enzyme';
+import React from 'react';
+
 import { useDeepObjectDiff } from './useDeepObjectDiff.hook';
 
 const { useEffect } = React;

package/src/presentation/hooks/useEventListener.hook.spec.tsx

@@ -1,5 +1,6 @@
-import React from 'react';
 import { mount } from 'enzyme';
+import React from 'react';
+
 import { useEventListener } from './useEventListener.hook';
 
 const TestComponent = ({

package/src/presentation/hooks/useForceUpdate.hook.spec.tsx

@@ -1,6 +1,7 @@
-import React from 'react';
 import { mount } from 'enzyme';
+import React from 'react';
 import { Subject } from 'rxjs';
+
 import { useForceUpdate } from '..';
 
 describe('useForceUpdate', () => {

package/src/presentation/hooks/useInterval.hook.spec.tsx

@@ -1,5 +1,6 @@
-import React from 'react';
 import { mount } from 'enzyme';
+import React from 'react';
+
 import { useInterval } from './useInterval.hook';
 
 describe('useInterval hook', () => {

package/src/presentation/hooks/useIsMountedRef.hook.spec.tsx

@@ -1,7 +1,7 @@
+import { mount } from 'enzyme';
 import React from 'react';
 
 import { useIsMountedRef } from '..';
-import { mount } from 'enzyme';
 
 describe('useIsMountedRef hook', () => {
   let useIsMountedRefSpy: jasmine.Spy;

package/src/presentation/hooks/useLatestCallback.hook.spec.tsx

@@ -1,5 +1,6 @@
-import React from 'react';
 import { mount } from 'enzyme';
+import React from 'react';
+
 import { useLatestCallback } from './useLatestCallback.hook';
 
 const TestComponent = ({

package/src/presentation/hooks/useLatestPromise.hook.spec.tsx

@@ -1,6 +1,8 @@
-import React from 'react';
 import { mount } from 'enzyme';
-import { IUseLatestPromiseResult, useLatestPromise } from './useLatestPromise.hook';
+import React from 'react';
+
+import type { IUseLatestPromiseResult } from './useLatestPromise.hook';
+import { useLatestPromise } from './useLatestPromise.hook';
 
 describe('useLatestPromise hook', () => {
   // Remove the the refresh function for .isEqual assertions
@@ -68,9 +70,13 @@ describe('useLatestPromise hook', () => {
     expect(spy).toHaveBeenCalledTimes(2);
 
     deferred.reject('error');
+    let caught = false;
     try {
       await deferred.promise;
-    } catch (error) {}
+    } catch (error) {
+      caught = true;
+    }
+    expect(caught).toBe(true);
     component.setProps({});
 
     expect(spy).toHaveBeenCalledTimes(3);

package/src/presentation/hooks/useMountStatusRef.hook.spec.tsx

@@ -1,5 +1,7 @@
-import React, { RefObject } from 'react';
 import { mount } from 'enzyme';
+import type { RefObject } from 'react';
+import React from 'react';
+
 import { useMountStatusRef } from './useMountStatusRef.hook';
 
 describe('useMountStatusRef', () => {

package/src/presentation/hooks/usePollingData.hook.spec.tsx

@@ -1,6 +1,7 @@
-import React, { useEffect } from 'react';
 import { mount } from 'enzyme';
-import { IUseLatestPromiseResult } from './useLatestPromise.hook';
+import React, { useEffect } from 'react';
+
+import type { IUseLatestPromiseResult } from './useLatestPromise.hook';
 import { usePollingData } from './usePollingData.hook';
 
 describe('usePollingData hook', () => {

package/src/presentation/hooks/usePrevious.hook.spec.tsx

@@ -1,5 +1,6 @@
-import React from 'react';
 import { mount } from 'enzyme';
+import React from 'react';
+
 import { usePrevious } from './usePrevious.hook';
 
 const TestComponent = ({ value, valueCallback }: { value: any; valueCallback: (value: any) => any }) => {

package/src/presentation/navigation/pageNavigator.component.spec.ts

@@ -1,10 +1,10 @@
-import $ from 'jquery';
+import UI_ROUTER from '@uirouter/angularjs';
 import { mock } from 'angular';
+import $ from 'jquery';
 
+import type { INavigationPage } from './PageNavigationState';
 import { PAGE_NAVIGATOR_COMPONENT } from './pageNavigator.component';
-import { INavigationPage } from './PageNavigationState';
 import { ScrollToService } from '../../utils/scrollTo/scrollTo.service';
-import UI_ROUTER from '@uirouter/angularjs';
 
 describe('Component: Page Navigator', () => {
   let $compile: ng.ICompileService, $scope: ng.IScope, $timeout: ng.ITimeoutService, elem: JQuery;

package/src/presentation/spel/SpelInput.spec.tsx

@@ -1,8 +1,9 @@
-import React from 'react';
 import { mount } from 'enzyme';
-import { IFormInputProps, IStageForSpelPreview, IValidator } from '..';
-import { SpelService } from './SpelService';
+import React from 'react';
+
+import type { IFormInputProps, IStageForSpelPreview, IValidator } from '..';
 import { SpelInput } from './SpelInput';
+import { SpelService } from './SpelService';
 
 function defer() {
   let resolve: Function, reject: Function;
@@ -208,10 +209,14 @@ describe('<SpelInput/>', () => {
       expect(mockValidate).toHaveBeenCalledTimes(1);
       expect(mockValidate.calls.mostRecent().returnValue).toMatch('Async: ');
 
+      let caught = false;
       deferred.reject('something bad happened');
       try {
         await deferred.promise;
-      } catch (error) {}
+      } catch (error) {
+        caught = true;
+      }
+      expect(caught).toBe(true);
       component.setProps({});
 
       expect(mockValidate).toHaveBeenCalledTimes(2);

package/src/presentation/spel/SpelService.spec.ts

@@ -1,5 +1,5 @@
-import { RequestBuilder } from '../../api';
 import { SpelService } from './SpelService';
+import { RequestBuilder } from '../../api';
 
 describe('SpelService', () => {
   it('extracts "result" from the payload', async () => {

package/src/scheduler/SchedulerFactory.spec.ts

@@ -1,5 +1,6 @@
 import * as angular from 'angular';
-import { ITimeoutService, mock } from 'angular';
+import type { ITimeoutService } from 'angular';
+import { mock } from 'angular';
 import { SchedulerFactory } from './SchedulerFactory';
 
 describe('scheduler', function () {

package/src/search/infrastructure/infrastructure.controller.js

@@ -136,6 +136,9 @@ angular
               'createApplicationModal',
               require('../../application/modal/newapplication.html'),
             ),
+            resolve: {
+              name: () => '',
+            },
             controller: overrideRegistry.getController('CreateApplicationModalCtrl'),
             controllerAs: 'newAppModal',
           })