@spinnaker/core 0.14.1 → 0.16.0

package/src/pipeline/config/PipelineRegistry.spec.ts

@@ -2,13 +2,14 @@ import { mock } from 'angular';
 import { map } from 'lodash';
 import React from 'react';
 
+import { PipelineRegistry } from './PipelineRegistry';
+import type { IRegion } from '../../account/AccountService';
 import { SETTINGS } from '../../config';
-import { IStage, ITriggerTypeConfig, IStageTypeConfig } from '../../domain';
-import { IRegion } from '../../account/AccountService';
-import { Registry } from '../../registry';
+import type { IStage, IStageTypeConfig, ITriggerTypeConfig } from '../../domain';
 import { ITriggerTemplateComponentProps } from '../manualExecution/TriggerTemplate';
-import { PipelineRegistry } from './PipelineRegistry';
-import { IPreconfiguredJob, makePreconfiguredJobStage, PreconfiguredJobReader } from './stages/preconfiguredJob';
+import { Registry } from '../../registry';
+import type { IPreconfiguredJob } from './stages/preconfiguredJob';
+import { makePreconfiguredJobStage, PreconfiguredJobReader } from './stages/preconfiguredJob';
 
 const mockProviderAccount = {
   accountId: 'abc',
@@ -111,35 +112,35 @@ describe('PipelineRegistry: API', function () {
     it(
       'augments provider stages with parent keys, labels, manualExecutionComponents, and descriptions',
       mock.inject(function () {
-        const CompA = ({}: ITriggerTemplateComponentProps) => React.createElement('a');
+        const CompA = () => React.createElement('a');
         const baseStage = {
-            key: 'c',
-            useBaseProvider: true,
-            description: 'c description',
-            label: 'the c',
-            manualExecutionComponent: CompA,
-          },
-          augmentedA = {
-            key: 'd',
-            provides: 'c',
-            description: 'c description',
-            label: 'the c',
-            manualExecutionComponent: CompA,
-          } as any,
-          augmentedB = {
-            key: 'e',
-            provides: 'c',
-            description: 'c description',
-            label: 'the c',
-            manualExecutionComponent: CompA,
-          },
-          augmentedC = {
-            key: 'c',
-            provides: 'c',
-            description: 'c description',
-            label: 'the c',
-            manualExecutionComponent: CompA,
-          };
+          key: 'c',
+          useBaseProvider: true,
+          description: 'c description',
+          label: 'the c',
+          manualExecutionComponent: CompA,
+        };
+        const augmentedA = {
+          key: 'd',
+          provides: 'c',
+          description: 'c description',
+          label: 'the c',
+          manualExecutionComponent: CompA,
+        } as any;
+        const augmentedB = {
+          key: 'e',
+          provides: 'c',
+          description: 'c description',
+          label: 'the c',
+          manualExecutionComponent: CompA,
+        };
+        const augmentedC = {
+          key: 'c',
+          provides: 'c',
+          description: 'c description',
+          label: 'the c',
+          manualExecutionComponent: CompA,
+        };
         Registry.pipeline.registerStage(baseStage as IStageTypeConfig);
         Registry.pipeline.registerStage({ key: 'd', provides: 'c' } as IStageTypeConfig);
         Registry.pipeline.registerStage({ key: 'e', provides: 'c' } as IStageTypeConfig);
@@ -153,8 +154,8 @@ describe('PipelineRegistry: API', function () {
     it(
       'allows provider stages to override of label, description, manualExecutionComponent',
       mock.inject(function () {
-        const CompA = ({}: ITriggerTemplateComponentProps) => React.createElement('a');
-        const CompB = ({}: ITriggerTemplateComponentProps) => React.createElement('b');
+        const CompA = () => React.createElement('a');
+        const CompB = () => React.createElement('b');
         Registry.pipeline.registerStage({
           key: 'a',
           useBaseProvider: true,
@@ -467,7 +468,7 @@ describe('PipelineRegistry: API', function () {
     });
 
     it('hasManualExecutionComponentForTriggerType returns true if declared and available', function () {
-      const CompA = ({}: ITriggerTemplateComponentProps) => React.createElement('a');
+      const CompA = () => React.createElement('a');
       Registry.pipeline.registerTrigger({ key: 'cron', manualExecutionComponent: CompA } as ITriggerTypeConfig);
       expect(Registry.pipeline.hasManualExecutionComponentForTriggerType('cron')).toBe(true);
     });
@@ -479,7 +480,7 @@ describe('PipelineRegistry: API', function () {
     });
 
     it('hasManualExecutionComponentForTriggerType returns handler if declared and available', function () {
-      const CompA = ({}: ITriggerTemplateComponentProps) => React.createElement('a');
+      const CompA = () => React.createElement('a');
       Registry.pipeline.registerTrigger({ key: 'cron', manualExecutionComponent: CompA } as ITriggerTypeConfig);
       expect(Registry.pipeline.getManualExecutionComponentForTriggerType('cron')).toEqual(CompA);
     });

package/src/pipeline/config/actions/templateJson/ShowPipelineTemplateJsonModal.spec.tsx

@@ -1,9 +1,9 @@
-import React from 'react';
 import { mount } from 'enzyme';
+import React from 'react';
 
-import { IPipeline, IPipelineTemplateV2 } from '../../../../domain';
-import { PipelineTemplateV2Service } from '../../templates/v2/pipelineTemplateV2.service';
 import { ShowPipelineTemplateJsonModal } from './ShowPipelineTemplateJsonModal';
+import type { IPipeline, IPipelineTemplateV2 } from '../../../../domain';
+import { PipelineTemplateV2Service } from '../../templates/v2/pipelineTemplateV2.service';
 
 describe('<ShowPipelineTemplateJsonModal />', () => {
   const mockPipeline: Partial<IPipeline> = {

package/src/pipeline/config/pipelineConfigurer.controller.spec.ts

@@ -1,8 +1,7 @@
-import { IController, IControllerService, IQService, IRootScopeService, IScope, IWindowService } from 'angular';
+import type { IController, IControllerService, IQService, IRootScopeService, IScope, IWindowService } from 'angular';
 
 import { ApplicationModelBuilder } from '../../application/applicationModel.builder';
-import { PipelineConfigService } from './services/PipelineConfigService';
-import {
+import type {
   IDockerTrigger,
   IGitTrigger,
   INotification,
@@ -10,6 +9,7 @@ import {
   IPipelineTemplateConfigV2,
   IPipelineTemplatePlanV2,
 } from '../../domain';
+import { PipelineConfigService } from './services/PipelineConfigService';
 
 const githubTrigger: IGitTrigger = {
   branch: 'master',

package/src/pipeline/config/services/PipelineConfigService.spec.ts

@@ -1,8 +1,9 @@
-import { mockHttpClient } from '../../../api/mock/jasmine';
 import { mock } from 'angular';
-import { IStage } from '../../../domain/IStage';
-import { IPipeline } from '../../../domain/IPipeline';
+
 import { PipelineConfigService } from './PipelineConfigService';
+import { mockHttpClient } from '../../../api/mock/jasmine';
+import type { IPipeline } from '../../../domain/IPipeline';
+import type { IStage } from '../../../domain/IStage';
 
 describe('PipelineConfigService', () => {
   let $scope: ng.IScope;

package/src/pipeline/config/stages/bakeManifest/helm/BakeHelmConfigForm.spec.tsx

@@ -1,16 +1,15 @@
-import React from 'react';
-import { mount } from 'enzyme';
-import { IStage } from '../../../../../domain';
-import { REACT_MODULE } from '../../../../../reactShims';
 import { mock } from 'angular';
-
-import { ApplicationModelBuilder } from '../../../../../application';
-
-import { AccountService } from '../../../../../account';
+import { mount } from 'enzyme';
+import React from 'react';
 
 import { StageConfigField } from '../../../..';
 import { BakeHelmConfigForm } from './BakeHelmConfigForm';
+import { AccountService } from '../../../../../account';
+import { ApplicationModelBuilder } from '../../../../../application';
+import { ExpectedArtifactService } from '../../../../../artifact';
+import type { IExpectedArtifact, IStage } from '../../../../../domain';
 import { SpinFormik } from '../../../../../presentation';
+import { REACT_MODULE } from '../../../../../reactShims';
 
 describe('<BakeHelmConfigForm />', () => {
   beforeEach(mock.module(REACT_MODULE));
@@ -86,4 +85,48 @@ describe('<BakeHelmConfigForm />', () => {
 
     expect(component.find(StageConfigField).findWhere((x) => x.text() === helmChartFilePathFieldName).length).toBe(0);
   });
+
+  it('render the helm chart file path if the id of the git artifact is given but the account value does not exist', async () => {
+    const expectedArtifactDisplayName = 'test-artifact';
+    const expectedArtifactId = 'test-artifact-id';
+    const expectedGitArtifact: IExpectedArtifact = {
+      defaultArtifact: {
+        customKind: true,
+        id: 'defaultArtifact-id',
+      },
+      displayName: expectedArtifactDisplayName,
+      id: expectedArtifactId,
+      matchArtifact: {
+        artifactAccount: 'gitrepo',
+        id: expectedArtifactId,
+        reference: 'git repo',
+        type: 'git/repo',
+        version: 'master',
+      },
+      useDefaultArtifact: false,
+      usePriorArtifact: false,
+    };
+    const stage = ({
+      inputArtifacts: [{ id: expectedArtifactId }],
+    } as unknown) as IStage;
+
+    spyOn(ExpectedArtifactService, 'getExpectedArtifactsAvailableToStage').and.returnValue([expectedGitArtifact]);
+
+    const props = getProps();
+
+    const component = mount(
+      <SpinFormik
+        initialValues={stage}
+        onSubmit={() => null}
+        validate={() => null}
+        render={(formik) => <BakeHelmConfigForm {...props} formik={formik} />}
+      />,
+    );
+
+    await new Promise((resolve) => setTimeout(resolve)); // wait one js tick for promise to resolve
+    component.setProps({}); // force a re-render
+
+    expect(component.find('.Select-value-label > span').text().includes(expectedArtifactDisplayName)).toBe(true);
+    expect(component.find(StageConfigField).findWhere((x) => x.text() === helmChartFilePathFieldName).length).toBe(1);
+  });
 });

package/src/pipeline/config/stages/bakeManifest/helm/BakeHelmConfigForm.tsx

@@ -2,7 +2,12 @@ import React from 'react';
 
 import type { IFormikStageConfigInjectedProps } from '../../FormikStageConfig';
 import { AccountService } from '../../../../../account';
-import { ArtifactTypePatterns, excludeAllTypesExcept, StageArtifactSelectorDelegate } from '../../../../../artifact';
+import {
+  ArtifactTypePatterns,
+  excludeAllTypesExcept,
+  ExpectedArtifactService,
+  StageArtifactSelectorDelegate,
+} from '../../../../../artifact';
 import { StageConfigField } from '../../common/stageConfigField/StageConfigField';
 import type { IArtifact, IExpectedArtifact } from '../../../../../domain';
 import { MapEditor } from '../../../../../forms';
@@ -41,6 +46,25 @@ export class BakeHelmConfigForm extends React.Component<IFormikStageConfigInject
         },
       ]);
     }
+
+    // If the Expected Artifact id is provided but the account is not, then attempt to find the artifact from
+    // upstream stages and set the account value.
+    // This is needed because helm chart file path field will need to be rendered if the artifact has a git repo account type
+    const expectedArtifact = this.getInputArtifact(stage, 0);
+    if (expectedArtifact.id && !expectedArtifact.account) {
+      const availableArtifacts = ExpectedArtifactService.getExpectedArtifactsAvailableToStage(
+        stage,
+        this.props.pipeline,
+      );
+      const expectedMatchedArtifact = availableArtifacts.find((a) => a.id === expectedArtifact.id);
+      if (expectedMatchedArtifact && expectedMatchedArtifact.matchArtifact) {
+        this.props.formik.setFieldValue(
+          `inputArtifacts[0].account`,
+          expectedMatchedArtifact.matchArtifact.artifactAccount,
+        );
+      }
+    }
+
     AccountService.getArtifactAccounts().then((artifactAccounts) => {
       this.setState({
         gitRepoArtifactAccountNames: artifactAccounts
@@ -56,9 +80,16 @@ export class BakeHelmConfigForm extends React.Component<IFormikStageConfigInject
     this.props.formik.setFieldValue(`inputArtifacts[${index}].account`, artifact.artifactAccount);
   };
 
-  private onTemplateArtifactSelected = (id: string, index: number) => {
-    this.props.formik.setFieldValue(`inputArtifacts[${index}].id`, id);
+  private onTemplateArtifactSelected = (artifact: IExpectedArtifact, index: number) => {
+    this.props.formik.setFieldValue(`inputArtifacts[${index}].id`, artifact.id);
     this.props.formik.setFieldValue(`inputArtifacts[${index}].artifact`, null);
+    // Set the account to matchArtifact.artifactAccount if it exists.
+    // This account value will be used to determine if the Helm Chart File Path should be displayed.
+    if (artifact.matchArtifact) {
+      this.props.formik.setFieldValue(`inputArtifacts[${index}].account`, artifact.matchArtifact.artifactAccount);
+    } else {
+      this.props.formik.setFieldValue(`inputArtifacts[${index}].account`, null);
+    }
   };
 
   private addInputArtifact = () => {
@@ -119,7 +150,6 @@ export class BakeHelmConfigForm extends React.Component<IFormikStageConfigInject
 
   public render() {
     const stage = this.props.formik.values;
-
     return (
       <>
         <h4>Helm Options</h4>
@@ -150,7 +180,7 @@ export class BakeHelmConfigForm extends React.Component<IFormikStageConfigInject
           onArtifactEdited={(artifact) => {
             this.onTemplateArtifactEdited(artifact, 0);
           }}
-          onExpectedArtifactSelected={(artifact: IExpectedArtifact) => this.onTemplateArtifactSelected(artifact.id, 0)}
+          onExpectedArtifactSelected={(artifact: IExpectedArtifact) => this.onTemplateArtifactSelected(artifact, 0)}
           pipeline={this.props.pipeline}
           stage={stage}
         />
@@ -180,7 +210,7 @@ export class BakeHelmConfigForm extends React.Component<IFormikStageConfigInject
                         this.onTemplateArtifactEdited(artifact, index + 1);
                       }}
                       onExpectedArtifactSelected={(artifact: IExpectedArtifact) =>
-                        this.onTemplateArtifactSelected(artifact.id, index + 1)
+                        this.onTemplateArtifactSelected(artifact, index + 1)
                       }
                       pipeline={this.props.pipeline}
                       stage={stage}

package/src/pipeline/config/stages/findArtifactFromExecution/findArtifactFromExecution.controller.spec.ts

@@ -1,6 +1,7 @@
 'use strict';
 
-import { IScope, mock } from 'angular';
+import type { IScope } from 'angular';
+import { mock } from 'angular';
 import { FindArtifactFromExecutionCtrl } from './findArtifactFromExecution.controller';
 
 describe('Find Artifact From Execution Controller:', function () {

package/src/pipeline/config/stages/manualJudgment/manualJudgment.service.spec.ts

@@ -1,9 +1,11 @@
+import type { IDeferred, IQService, IRootScopeService, IScope } from 'angular';
+import { mock } from 'angular';
+
 import { mockHttpClient } from '../../../../api/mock/jasmine';
 import { tick } from '../../../../api/mock/mockHttpUtils';
-import { IDeferred, IQService, IRootScopeService, IScope, mock } from 'angular';
-
-import { MANUAL_JUDGMENT_SERVICE, ManualJudgmentService } from './manualJudgment.service';
-import { ExecutionService } from '../../../service/execution.service';
+import type { ManualJudgmentService } from './manualJudgment.service';
+import { MANUAL_JUDGMENT_SERVICE } from './manualJudgment.service';
+import type { ExecutionService } from '../../../service/execution.service';
 
 describe('Service: manualJudgment', () => {
   let $scope: IScope, service: ManualJudgmentService, $q: IQService, executionService: ExecutionService;

package/src/pipeline/config/stages/travis/travisExecutionDetails.controller.spec.ts

@@ -1,4 +1,5 @@
-import { IScope, IControllerService, IRootScopeService, mock } from 'angular';
+import type { IControllerService, IRootScopeService, IScope } from 'angular';
+import { mock } from 'angular';
 
 import { TRAVIS_EXECUTION_DETAILS_CONTROLLER, TravisExecutionDetailsCtrl } from './travisExecutionDetails.controller';
 
@@ -18,7 +19,9 @@ describe('Travis Execution Details Controller:', () => {
     $scope.stage = stage;
     return $ctrl(TravisExecutionDetailsCtrl, {
       $scope,
-      executionDetailsSectionService: { synchronizeSection: ({}, fn: () => any) => fn() },
+      executionDetailsSectionService: {
+        synchronizeSection: (_availableSections: string[], fn: () => any) => fn(),
+      },
     });
   };
 

package/src/pipeline/config/stages/travis/travisStage.controller.spec.ts

@@ -1,8 +1,9 @@
 import Spy = jasmine.Spy;
-import { mock, IScope, IQService, IControllerService, IRootScopeService } from 'angular';
+import type { IControllerService, IQService, IRootScopeService, IScope } from 'angular';
+import { mock } from 'angular';
 
 import { IgorService } from '../../../../ci/igor.service';
-import { IJobConfig, IParameterDefinitionList } from '../../../../domain';
+import type { IJobConfig, IParameterDefinitionList } from '../../../../domain';
 import { TRAVIS_STAGE, TravisStage } from './travisStage';
 
 describe('Travis Stage Controller', () => {

package/src/pipeline/config/stages/unmatchedStageTypeStage/unmatchedStageTypeStage.controller.spec.ts

@@ -1,6 +1,7 @@
 import { mock } from 'angular';
 
-import { UNMATCHED_STAGE_TYPE_STAGE_CTRL, UnmatchedStageTypeStageCtrl } from './unmatchedStageTypeStage.controller';
+import type { UnmatchedStageTypeStageCtrl } from './unmatchedStageTypeStage.controller';
+import { UNMATCHED_STAGE_TYPE_STAGE_CTRL } from './unmatchedStageTypeStage.controller';
 
 describe('Controller: UnmatchedStageTypeStageCtrl', () => {
   let ctrl: UnmatchedStageTypeStageCtrl;

package/src/pipeline/config/stages/wait/SkipWait.tsx

@@ -66,11 +66,13 @@ export class SkipWait extends React.Component<ISkipWaitProps, ISkipWaitState> {
 
   public render() {
     const stage = this.props.stage;
+    const waitMs = stage.context.waitTime * 1000;
+
     return (
       <div>
         <div>
           <b>Wait time: </b>
-          {stage.context.waitTime} seconds
+          {stage.context.waitTime > 3600 ? duration(waitMs) : `${stage.context.waitTime} seconds`}
           {stage.context.skipRemainingWait && <span>(skipped after {duration(stage.runningTimeInMs)})</span>}
         </div>
         {stage.isRunning && (

package/src/pipeline/config/stages/wercker/werckerExecutionDetails.controller.spec.ts

@@ -1,4 +1,5 @@
-import { IScope, IControllerService, IRootScopeService, mock } from 'angular';
+import type { IControllerService, IRootScopeService, IScope } from 'angular';
+import { mock } from 'angular';
 
 import {
   WERCKER_EXECUTION_DETAILS_CONTROLLER,
@@ -21,7 +22,9 @@ describe('Wercker Execution Details Controller:', () => {
     $scope.stage = stage;
     return $ctrl(WerckerExecutionDetailsCtrl, {
       $scope,
-      executionDetailsSectionService: { synchronizeSection: ({}, fn: () => any) => fn() },
+      executionDetailsSectionService: {
+        synchronizeSection: (_availableSections: string[], fn: () => any) => fn(),
+      },
     });
   };
 

package/src/pipeline/config/stages/wercker/werckerStage.controller.spec.ts

@@ -1,8 +1,9 @@
 import Spy = jasmine.Spy;
-import { mock, IScope, IQService, IControllerService, IRootScopeService } from 'angular';
+import type { IControllerService, IQService, IRootScopeService, IScope } from 'angular';
+import { mock } from 'angular';
 
 import { IgorService } from '../../../../ci/igor.service';
-import { IJobConfig, IParameterDefinitionList } from '../../../../domain';
+import type { IJobConfig, IParameterDefinitionList } from '../../../../domain';
 import { WERCKER_STAGE, WerckerStage } from './werckerStage';
 
 describe('Wercker Stage Controller', () => {

package/src/pipeline/config/templates/Variable.spec.tsx

@@ -1,12 +1,13 @@
 import { mock } from 'angular';
+import type { ReactWrapper } from 'enzyme';
+import { mount } from 'enzyme';
 import React from 'react';
-import { mount, ReactWrapper } from 'enzyme';
 
-import { REACT_MODULE } from '../../../reactShims/react.module';
-import { PIPELINE_TEMPLATE_MODULE } from './pipelineTemplate.module';
+import type { VariableType } from './PipelineTemplateReader';
 import { Variable } from './Variable';
-import { IVariableError, IVariableProps } from './inputs/variableInput.service';
-import { VariableType } from './PipelineTemplateReader';
+import type { IVariableError, IVariableProps } from './inputs/variableInput.service';
+import { PIPELINE_TEMPLATE_MODULE } from './pipelineTemplate.module';
+import { REACT_MODULE } from '../../../reactShims/react.module';
 
 describe('Variable component', () => {
   const generateProps = (type: VariableType, value: any) => {

package/src/pipeline/config/templates/configurePipelineTemplateModal.controller.spec.ts

@@ -1,14 +1,13 @@
-import { mock, IScope, IQService } from 'angular';
+import type { IQService, IScope } from 'angular';
+import { mock } from 'angular';
 
-import {
-  CONFIGURE_PIPELINE_TEMPLATE_MODAL_CTRL,
-  ConfigurePipelineTemplateModalController,
-} from './configurePipelineTemplateModal.controller';
-import { IVariable } from './inputs/variableInput.service';
+import { PipelineTemplateReader } from './PipelineTemplateReader';
+import type { Application } from '../../../application/application.model';
 import { ApplicationModelBuilder } from '../../../application/applicationModel.builder';
-import { Application } from '../../../application/application.model';
+import type { ConfigurePipelineTemplateModalController } from './configurePipelineTemplateModal.controller';
+import { CONFIGURE_PIPELINE_TEMPLATE_MODAL_CTRL } from './configurePipelineTemplateModal.controller';
+import type { IVariable } from './inputs/variableInput.service';
 import { PIPELINE_TEMPLATE_MODULE } from './pipelineTemplate.module';
-import { PipelineTemplateReader } from './PipelineTemplateReader';
 
 describe('Controller: ConfigurePipelineTemplateModalCtrl', () => {
   let ctrl: ConfigurePipelineTemplateModalController, $scope: IScope, $q: IQService, application: Application;

package/src/pipeline/config/templates/v2/configurePipelineTemplateModalV2.controller.spec.ts

@@ -1,14 +1,13 @@
-import { mock, IScope, IQService } from 'angular';
+import type { IQService, IScope } from 'angular';
+import { mock } from 'angular';
 
-import {
-  CONFIGURE_PIPELINE_TEMPLATE_MODAL_V2_CTRL,
-  ConfigurePipelineTemplateModalV2Controller,
-} from './configurePipelineTemplateModalV2.controller';
-import { IVariable } from '../inputs/variableInput.service';
+import { PipelineTemplateReader } from '../PipelineTemplateReader';
+import type { Application } from '../../../../application/application.model';
 import { ApplicationModelBuilder } from '../../../../application/applicationModel.builder';
-import { Application } from '../../../../application/application.model';
+import type { ConfigurePipelineTemplateModalV2Controller } from './configurePipelineTemplateModalV2.controller';
+import { CONFIGURE_PIPELINE_TEMPLATE_MODAL_V2_CTRL } from './configurePipelineTemplateModalV2.controller';
+import type { IVariable } from '../inputs/variableInput.service';
 import { PIPELINE_TEMPLATE_MODULE } from '../pipelineTemplate.module';
-import { PipelineTemplateReader } from '../PipelineTemplateReader';
 
 describe('Controller: ConfigurePipelineTemplateModalV2Ctrl', () => {
   let ctrl: ConfigurePipelineTemplateModalV2Controller, $scope: IScope, $q: IQService, application: Application;

package/src/pipeline/config/templates/v2/pipelineTemplateV2.service.spec.ts

@@ -1,6 +1,6 @@
 import { hri as HumanReadableIds } from 'human-readable-ids';
 
-import { IPipeline, IPipelineTemplateV2 } from '../../../../domain';
+import type { IPipeline, IPipelineTemplateV2 } from '../../../../domain';
 import { PipelineTemplateV2Service } from './pipelineTemplateV2.service';
 import { UUIDGenerator } from '../../../../utils';
 

package/src/pipeline/config/triggers/TriggersPageContent.spec.tsx

@@ -1,13 +1,13 @@
-import React from 'react';
 import { mount } from 'enzyme';
+import React from 'react';
 
+import type { ITriggersPageContentProps } from './TriggersPageContent';
+import { TriggersPageContent } from './TriggersPageContent';
 import { ApplicationModelBuilder } from '../../../application';
 import { ArtifactReferenceService } from '../../../artifact/ArtifactReferenceService';
-import { IExpectedArtifact, ITrigger } from '../../../domain';
+import type { IExpectedArtifact, ITrigger } from '../../../domain';
 import { Registry } from '../../../registry';
 
-import { ITriggersPageContentProps, TriggersPageContent } from './TriggersPageContent';
-
 describe('<TriggersPageContent />', () => {
   let removeReferencesFromStagesSpy: jasmine.Spy;
   let updatePipelineSpy: jasmine.Spy;

package/src/pipeline/config/triggers/TriggersPageContent.tsx

@@ -164,8 +164,7 @@ export function TriggersPageContent(props: ITriggersPageContentProps) {
                               {...inputProps}
                               text={
                                 <>
-                                  Disable automated triggers during quiet period (
-                                  <strong>does not affect Pipeline triggers</strong>).
+                                  Disable automated triggers during quiet period.
                                   <HelpField id="pipeline.config.triggers.respectQuietPeriod" />
                                 </>
                               }

package/src/pipeline/config/triggers/artifacts/docker/defaultDocker.artifact.spec.ts

@@ -1,6 +1,5 @@
-import { IArtifact } from '../../../../../domain';
-
 import { setNameAndVersionFromReference } from './DockerArtifactEditor';
+import type { IArtifact } from '../../../../../domain';
 
 describe('defaultDocker.artifact', () => {
   it('parses Docker image references correctly', () => {

package/src/pipeline/config/validation/pipelineConfig.validator.spec.ts

@@ -1,23 +1,22 @@
 import { mock } from 'angular';
-import Spy = jasmine.Spy;
-import { SETTINGS } from '../../../config/settings';
 
-import { IPipeline, IStage, IStageTypeConfig } from '../../../domain';
+import type { ICustomValidator, IPipelineValidationResults, IValidatorConfig } from './PipelineConfigValidator';
+import { PipelineConfigValidator } from './PipelineConfigValidator';
+import { SETTINGS } from '../../../config/settings';
+import type { IPipeline, IStage, IStageTypeConfig } from '../../../domain';
+import { Registry } from '../../../registry';
+import type { IRequiredFieldValidationConfig } from './requiredField.validator';
 import { ServiceAccountReader } from '../../../serviceAccount/ServiceAccountReader';
+import type {
+  IServiceAccountAccessValidationConfig,
+  ITriggerWithServiceAccount,
+} from './serviceAccountAccess.validator';
 import { PipelineConfigService } from '../services/PipelineConfigService';
-import { Registry } from '../../../registry';
+import type { IStageBeforeTypeValidationConfig } from './stageBeforeType.validator';
+import type { IStageOrTriggerBeforeTypeValidationConfig } from './stageOrTriggerBeforeType.validator';
+import type { ITargetImpedanceValidationConfig } from './targetImpedance.validator';
 
-import {
-  ICustomValidator,
-  IPipelineValidationResults,
-  IValidatorConfig,
-  PipelineConfigValidator,
-} from './PipelineConfigValidator';
-import { IRequiredFieldValidationConfig } from './requiredField.validator';
-import { IServiceAccountAccessValidationConfig, ITriggerWithServiceAccount } from './serviceAccountAccess.validator';
-import { IStageBeforeTypeValidationConfig } from './stageBeforeType.validator';
-import { IStageOrTriggerBeforeTypeValidationConfig } from './stageOrTriggerBeforeType.validator';
-import { ITargetImpedanceValidationConfig } from './targetImpedance.validator';
+import Spy = jasmine.Spy;
 
 describe('pipelineConfigValidator', () => {
   let pipeline: IPipeline, validate: () => void, validationResults: IPipelineValidationResults, $q: ng.IQService;

package/src/pipeline/create/CreatePipelineModal.spec.tsx

@@ -1,14 +1,16 @@
-import { mock, IQService, IScope } from 'angular';
-import React from 'react';
+import type { IQService, IScope } from 'angular';
+import { mock } from 'angular';
 import { shallow } from 'enzyme';
+import React from 'react';
 
-import { CreatePipelineModal, ICreatePipelineModalProps } from './CreatePipelineModal';
-import { PipelineTemplateReader } from '../config/templates/PipelineTemplateReader';
-import { Application } from '../../application/application.model';
+import type { ICreatePipelineModalProps } from './CreatePipelineModal';
+import { CreatePipelineModal } from './CreatePipelineModal';
+import type { Application } from '../../application/application.model';
 import { ApplicationModelBuilder } from '../../application/applicationModel.builder';
-import { IPipeline } from '../../domain';
-import { SETTINGS } from '../../config/settings';
 import { PipelineConfigService } from '../config/services/PipelineConfigService';
+import { SETTINGS } from '../../config/settings';
+import { PipelineTemplateReader } from '../config/templates/PipelineTemplateReader';
+import type { IPipeline } from '../../domain';
 
 // Disable CreatePipelineModal tests until enzyme supports React 16 https://github.com/airbnb/enzyme/issues/1553
 // CreatePipelineModal uses Overridable() which uses React.forwardRef

package/src/pipeline/details/executionDetailsSection.service.spec.ts

@@ -1,7 +1,8 @@
+import type { StateParams, StateService } from '@uirouter/angularjs';
 import { mock, noop } from 'angular';
-import { StateParams, StateService } from '@uirouter/angularjs';
 
-import { EXECUTION_DETAILS_SECTION_SERVICE, ExecutionDetailsSectionService } from './executionDetailsSection.service';
+import type { ExecutionDetailsSectionService } from './executionDetailsSection.service';
+import { EXECUTION_DETAILS_SECTION_SERVICE } from './executionDetailsSection.service';
 
 describe('executionDetailsSectionService', function () {
   let $state: StateService,