@spinnaker/core 0.12.0 → 0.15.0

package/src/application/application.model.spec.ts

@@ -1,14 +1,13 @@
 import { mock } from 'angular';
 
-import { Application } from './application.model';
+import type { Application } from './application.model';
 import { ApplicationModelBuilder } from './applicationModel.builder';
-import { ApplicationDataSourceRegistry } from './service/ApplicationDataSourceRegistry';
+import type { IEntityTag, IEntityTags, IInstanceCounts, ILoadBalancer, IServerGroup } from '../domain';
 import { LOAD_BALANCER_DATA_SOURCE } from '../loadBalancer/loadBalancer.dataSource';
-import { SecurityGroupReader } from '../securityGroup/securityGroupReader.service';
-import { SERVER_GROUP_DATA_SOURCE } from '../serverGroup/serverGroup.dataSource';
 import { SECURITY_GROUP_DATA_SOURCE } from '../securityGroup/securityGroup.dataSource';
-
-import { IEntityTag, IEntityTags, IServerGroup, IInstanceCounts, ILoadBalancer } from '../domain';
+import type { SecurityGroupReader } from '../securityGroup/securityGroupReader.service';
+import { SERVER_GROUP_DATA_SOURCE } from '../serverGroup/serverGroup.dataSource';
+import { ApplicationDataSourceRegistry } from './service/ApplicationDataSourceRegistry';
 
 describe('Application Model', function () {
   let application: Application,
@@ -187,19 +186,19 @@ describe('Application Model', function () {
   describe('setting default credentials and regions', function () {
     it('sets default credentials and region from server group when only one account/region found', function () {
       const serverGroups: IServerGroup[] = [
-          {
-            name: 'deck-test-v001',
-            cluster: 'deck-test',
-            account: 'test',
-            region: 'us-west-2',
-            type: 'aws',
-            cloudProvider: 'aws',
-            instances: [],
-            instanceCounts: {} as IInstanceCounts,
-          },
-        ],
-        loadBalancers: ILoadBalancer[] = [],
-        securityGroupsByApplicationName: any[] = [];
+        {
+          name: 'deck-test-v001',
+          cluster: 'deck-test',
+          account: 'test',
+          region: 'us-west-2',
+          type: 'aws',
+          cloudProvider: 'aws',
+          instances: [],
+          instanceCounts: {} as IInstanceCounts,
+        },
+      ];
+      const loadBalancers: ILoadBalancer[] = [];
+      const securityGroupsByApplicationName: any[] = [];
 
       configureApplication(serverGroups, loadBalancers, securityGroupsByApplicationName);
       expect(application.defaultCredentials.aws).toBe('test');
@@ -207,11 +206,11 @@ describe('Application Model', function () {
     });
 
     it('sets default credentials and region from load balancer when only one account/region found', function () {
-      const serverGroups: IServerGroup[] = [],
-        loadBalancers: ILoadBalancer[] = [
-          { name: 'deck-frontend', cloudProvider: 'gce', vpcId: 'vpc0', region: 'us-central-1', account: 'prod' },
-        ],
-        securityGroupsByApplicationName: any[] = [];
+      const serverGroups: IServerGroup[] = [];
+      const loadBalancers: ILoadBalancer[] = [
+        { name: 'deck-frontend', cloudProvider: 'gce', vpcId: 'vpc0', region: 'us-central-1', account: 'prod' },
+      ];
+      const securityGroupsByApplicationName: any[] = [];
 
       configureApplication(serverGroups, loadBalancers, securityGroupsByApplicationName);
       expect(application.defaultCredentials.gce).toBe('prod');
@@ -219,11 +218,11 @@ describe('Application Model', function () {
     });
 
     it('sets default credentials and region from firewall', function () {
-      const serverGroups: any[] = [],
-        loadBalancers: ILoadBalancer[] = [],
-        securityGroupsByApplicationName: any[] = [
-          { name: 'deck-test', provider: 'cf', accountName: 'test', region: 'us-south-7' },
-        ];
+      const serverGroups: any[] = [];
+      const loadBalancers: ILoadBalancer[] = [];
+      const securityGroupsByApplicationName: any[] = [
+        { name: 'deck-test', provider: 'cf', accountName: 'test', region: 'us-south-7' },
+      ];
 
       configureApplication(serverGroups, loadBalancers, securityGroupsByApplicationName);
       expect(application.defaultCredentials.cf).toBe('test');
@@ -231,13 +230,13 @@ describe('Application Model', function () {
     });
 
     it('does not set defaults when multiple values found for the same provider', function () {
-      const serverGroups: IServerGroup[] = [],
-        loadBalancers: ILoadBalancer[] = [
-          { name: 'deck-frontend', cloudProvider: 'aws', vpcId: 'vpcId', region: 'us-west-1', account: 'prod' },
-        ],
-        securityGroupsByApplicationName: any[] = [
-          { name: 'deck-test', provider: 'aws', accountName: 'test', region: 'us-east-1' },
-        ];
+      const serverGroups: IServerGroup[] = [];
+      const loadBalancers: ILoadBalancer[] = [
+        { name: 'deck-frontend', cloudProvider: 'aws', vpcId: 'vpcId', region: 'us-west-1', account: 'prod' },
+      ];
+      const securityGroupsByApplicationName: any[] = [
+        { name: 'deck-test', provider: 'aws', accountName: 'test', region: 'us-east-1' },
+      ];
 
       configureApplication(serverGroups, loadBalancers, securityGroupsByApplicationName);
       expect(application.defaultCredentials.aws).toBeUndefined();
@@ -245,13 +244,13 @@ describe('Application Model', function () {
     });
 
     it('sets default region or default credentials if possible', function () {
-      const serverGroups: IServerGroup[] = [],
-        loadBalancers: ILoadBalancer[] = [
-          { name: 'deck-frontend', cloudProvider: 'aws', vpcId: 'vpcId', region: 'us-east-1', account: 'prod' },
-        ],
-        securityGroupsByApplicationName: any[] = [
-          { name: 'deck-test', provider: 'aws', accountName: 'test', region: 'us-east-1' },
-        ];
+      const serverGroups: IServerGroup[] = [];
+      const loadBalancers: ILoadBalancer[] = [
+        { name: 'deck-frontend', cloudProvider: 'aws', vpcId: 'vpcId', region: 'us-east-1', account: 'prod' },
+      ];
+      const securityGroupsByApplicationName: any[] = [
+        { name: 'deck-test', provider: 'aws', accountName: 'test', region: 'us-east-1' },
+      ];
 
       configureApplication(serverGroups, loadBalancers, securityGroupsByApplicationName);
       expect(application.defaultCredentials.aws).toBeUndefined();
@@ -259,13 +258,13 @@ describe('Application Model', function () {
     });
 
     it('sets default credentials, even if region cannot be set', function () {
-      const serverGroups: IServerGroup[] = [],
-        loadBalancers: ILoadBalancer[] = [
-          { name: 'deck-frontend', cloudProvider: 'aws', vpcId: 'vpc0', region: 'us-east-1', account: 'test' },
-        ],
-        securityGroupsByApplicationName: any[] = [
-          { name: 'deck-test', provider: 'aws', accountName: 'test', region: 'us-west-1' },
-        ];
+      const serverGroups: IServerGroup[] = [];
+      const loadBalancers: ILoadBalancer[] = [
+        { name: 'deck-frontend', cloudProvider: 'aws', vpcId: 'vpc0', region: 'us-east-1', account: 'test' },
+      ];
+      const securityGroupsByApplicationName: any[] = [
+        { name: 'deck-test', provider: 'aws', accountName: 'test', region: 'us-west-1' },
+      ];
 
       configureApplication(serverGroups, loadBalancers, securityGroupsByApplicationName);
       expect(application.defaultCredentials.aws).toBe('test');
@@ -274,35 +273,35 @@ describe('Application Model', function () {
 
     it('should set defaults for multiple providers', function () {
       const serverGroups: any[] = [
-          {
-            name: 'deck-test-v001',
-            account: 'test',
-            region: 'us-west-2',
-            provider: 'aws',
-            instances: [],
-            instanceCounts: { up: 0, down: 0, starting: 0, unknown: 0, outOfService: 0 },
-          },
-          {
-            name: 'deck-gce-v001',
-            account: 'gce-test',
-            region: 'us-central-1',
-            provider: 'gce',
-            instances: [],
-            instanceCounts: { up: 0, down: 0, starting: 0, unknown: 0, outOfService: 0 },
-          },
-        ],
-        loadBalancers: ILoadBalancer[] = [
-          {
-            name: 'deck-frontend',
-            account: 'gce-test',
-            cloudProvider: 'gce',
-            region: 'us-central-1',
-            serverGroups: [],
-          },
-        ],
-        securityGroupsByApplicationName: any[] = [
-          { name: 'deck-test', provider: 'aws', accountName: 'test', region: 'us-west-2' },
-        ];
+        {
+          name: 'deck-test-v001',
+          account: 'test',
+          region: 'us-west-2',
+          provider: 'aws',
+          instances: [],
+          instanceCounts: { up: 0, down: 0, starting: 0, unknown: 0, outOfService: 0 },
+        },
+        {
+          name: 'deck-gce-v001',
+          account: 'gce-test',
+          region: 'us-central-1',
+          provider: 'gce',
+          instances: [],
+          instanceCounts: { up: 0, down: 0, starting: 0, unknown: 0, outOfService: 0 },
+        },
+      ];
+      const loadBalancers: ILoadBalancer[] = [
+        {
+          name: 'deck-frontend',
+          account: 'gce-test',
+          cloudProvider: 'gce',
+          region: 'us-central-1',
+          serverGroups: [],
+        },
+      ];
+      const securityGroupsByApplicationName: any[] = [
+        { name: 'deck-test', provider: 'aws', accountName: 'test', region: 'us-west-2' },
+      ];
 
       configureApplication(serverGroups, loadBalancers, securityGroupsByApplicationName);
       expect(application.defaultCredentials.aws).toBe('test');

package/src/application/application.model.ts

@@ -1,11 +1,13 @@
-import { IScope } from 'angular';
+import type { IScope } from 'angular';
 import { map, union, uniq } from 'lodash';
 import { $log, $q } from 'ngimport';
-import { combineLatest as observableCombineLatest, Observable, ReplaySubject, Subject, Subscription } from 'rxjs';
+import type { Observable, Subscription } from 'rxjs';
+import { combineLatest as observableCombineLatest, ReplaySubject, Subject } from 'rxjs';
 import { map as rxMap } from 'rxjs/operators';
 
-import { ICluster } from '../domain/ICluster';
-import { ApplicationDataSource, IDataSourceConfig, IFetchStatus } from './service/applicationDataSource';
+import type { ICluster } from '../domain/ICluster';
+import type { IDataSourceConfig, IFetchStatus } from './service/applicationDataSource';
+import { ApplicationDataSource } from './service/applicationDataSource';
 
 export class Application {
   [k: string]: any;

package/src/application/application.state.provider.ts

@@ -1,11 +1,13 @@
-import { StateParams } from '@uirouter/angularjs';
-import { IServiceProvider, module } from 'angular';
+import type { StateParams } from '@uirouter/angularjs';
+import type { IServiceProvider } from 'angular';
+import { module } from 'angular';
 
 import { ApplicationComponent } from './ApplicationComponent';
-import { Application } from './application.model';
+import type { Application } from './application.model';
 import { ApplicationModelBuilder } from './applicationModel.builder';
 import { InsightLayout } from '../insight/InsightLayout';
-import { INestedState, STATE_CONFIG_PROVIDER, StateConfigProvider } from '../navigation/state.provider';
+import type { INestedState, StateConfigProvider } from '../navigation/state.provider';
+import { STATE_CONFIG_PROVIDER } from '../navigation/state.provider';
 import { ApplicationReader } from './service/ApplicationReader';
 import { InferredApplicationWarningService } from './service/InferredApplicationWarningService';
 

package/src/application/applicationModel.builder.ts

@@ -1,7 +1,7 @@
 import { Application } from './application.model';
-import { IServerGroup } from '../domain';
+import type { IServerGroup } from '../domain';
 import { SchedulerFactory } from '../scheduler/SchedulerFactory';
-import { IDataSourceConfig } from './service/applicationDataSource';
+import type { IDataSourceConfig } from './service/applicationDataSource';
 
 export class ApplicationModelBuilder {
   /** This is mostly used in tests */

package/src/application/applicationSearchResultType.tsx

@@ -1,14 +1,12 @@
 import React from 'react';
 
+import type { ISearchColumn, ISearchResult, ISearchResultSet } from '../search';
 import {
   AccountCell,
   BasicCell,
   DefaultSearchResultTab,
   HeaderCell,
   HrefCell,
-  ISearchColumn,
-  ISearchResult,
-  ISearchResultSet,
   SearchResultType,
   searchResultTypeRegistry,
   SearchTableBody,

package/src/application/applications.state.provider.ts

@@ -1,7 +1,9 @@
 import { module } from 'angular';
 
-import { APPLICATION_STATE_PROVIDER, ApplicationStateProvider } from './application.state.provider';
-import { INestedState, STATE_CONFIG_PROVIDER, StateConfigProvider } from '../navigation/state.provider';
+import type { ApplicationStateProvider } from './application.state.provider';
+import { APPLICATION_STATE_PROVIDER } from './application.state.provider';
+import type { INestedState, StateConfigProvider } from '../navigation/state.provider';
+import { STATE_CONFIG_PROVIDER } from '../navigation/state.provider';
 import { Applications } from './search/Applications';
 
 export const APPLICATIONS_STATE_PROVIDER = 'spinnaker.core.application.applications.state';

package/src/application/config/ApplicationConfig.tsx

@@ -1,6 +1,7 @@
 import React from 'react';
 
-import { IOverridableProps, Overridable } from '../../overrideRegistry';
+import type { IOverridableProps } from '../../overrideRegistry';
+import { Overridable } from '../../overrideRegistry';
 import { AngularJSAdapter } from '../../reactShims';
 
 export interface IApplicationConfigDetailsProps extends IOverridableProps {}

package/src/application/config/DeleteApplicationSection.tsx

@@ -1,6 +1,6 @@
 import React from 'react';
 
-import { Application } from '../application.model';
+import type { Application } from '../application.model';
 import { ConfirmationModalService } from '../../confirmationModal';
 import { ReactInjector } from '../../reactShims';
 import { FirewallLabel } from '../../securityGroup/label';

package/src/application/config/appConfig.states.ts

@@ -1,8 +1,9 @@
 import { module } from 'angular';
 
 import { ApplicationConfig } from './ApplicationConfig';
-import { APPLICATION_STATE_PROVIDER, ApplicationStateProvider } from '../application.state.provider';
-import { INestedState } from '../../navigation';
+import type { ApplicationStateProvider } from '../application.state.provider';
+import { APPLICATION_STATE_PROVIDER } from '../application.state.provider';
+import type { INestedState } from '../../navigation';
 
 export const APP_CONFIG_STATES = 'spinnaker.core.application.states';
 module(APP_CONFIG_STATES, [APPLICATION_STATE_PROVIDER]).config([

package/src/application/config/applicationAttributes.directive.html

@@ -1,4 +1,4 @@
-<dl class="dl-horizontal">
+<dl class="dl-horizontal" ng-if="(config.application.attributes && config.application.attributes.email)">
   <dt>Owner</dt>
   <dd>{{vm.application.attributes.email}}</dd>
   <dt ng-if="vm.application.attributes.appGroup">App Group <help-field key="application.group"></help-field></dt>
@@ -55,7 +55,11 @@
     <dd>{{vm.permissions}}</dd>
   </render-if-feature>
 </dl>
+<p ng-if="(!config.application.attributes || !config.application.attributes.email)">
+  This application has not been configured.
+</p>
 <button class="btn btn-link" ng-click="vm.editApplication()">
   <span class="glyphicon glyphicon-cog"></span>
-  Edit Application Attributes
+  {{ (!config.application.attributes || !config.application.attributes.email) ? "Create Application" : "Edit Application
+  Attributes"}}
 </button>

package/src/application/config/applicationAttributes.directive.js

@@ -110,6 +110,10 @@ module(CORE_APPLICATION_CONFIG_APPLICATIONATTRIBUTES_DIRECTIVE, [
           .catch(() => {});
       };
 
+      if (this.application && (!this.application.attributes || !this.application.attributes.email)) {
+        this.editApplication();
+      }
+
       this.slackBaseUrl = get(SETTINGS, 'slack.baseUrl', '');
     },
   ]);

package/src/application/config/applicationConfig.view.html

@@ -1,5 +1,18 @@
 <div style="overflow-y: auto" sticky-headers>
-  <page-navigator scrollable-container="[sticky-headers]" deep-link-param="section">
+  <page-navigator
+    scrollable-container="[sticky-headers]"
+    deep-link-param="section"
+    ng-if="(!config.application.attributes || !config.application.attributes.email)"
+  >
+    <page-section key="location" label="Application Attributes">
+      <application-attributes application="config.application"></application-attributes>
+    </page-section>
+  </page-navigator>
+  <page-navigator
+    scrollable-container="[sticky-headers]"
+    deep-link-param="section"
+    ng-if="(config.application.attributes && config.application.attributes.email)"
+  >
     <page-section key="location" label="Application Attributes">
       <application-attributes application="config.application"></application-attributes>
     </page-section>

package/src/application/config/customBanner/CustomBannerConfig.spec.tsx

@@ -1,10 +1,10 @@
-import React from 'react';
 import { shallow } from 'enzyme';
+import React from 'react';
 
+import type { ICustomBannerConfig } from './CustomBannerConfig';
+import { CustomBannerConfig } from './CustomBannerConfig';
 import { noop } from '../../../utils';
 
-import { CustomBannerConfig, ICustomBannerConfig } from './CustomBannerConfig';
-
 describe('<CustomBannerConfig />', () => {
   let bannerConfigs: ICustomBannerConfig[];
   let wrapper: any;

package/src/application/config/customBanner/CustomBannerConfig.tsx

@@ -1,6 +1,7 @@
 import { isEqual } from 'lodash';
 import React from 'react';
-import Select, { Option } from 'react-select';
+import type { Option } from 'react-select';
+import Select from 'react-select';
 
 import { bannerBackgroundColorOptions, bannerTextColorOptions } from './customBannerColors';
 import { ConfigSectionFooter } from '../footer/ConfigSectionFooter';

package/src/application/config/customBanner/customBannerColors.ts

@@ -1,4 +1,4 @@
-import { Option } from 'react-select';
+import type { Option } from 'react-select';
 
 export const bannerBackgroundColorOptions: Array<Option<string>> = [
   {

package/src/application/config/dataSources/applicationDataSourceEditor.component.spec.ts

@@ -1,10 +1,11 @@
 import { mock } from 'angular';
 
-import { Application } from '../../application.model';
+import type { Application } from '../../application.model';
+import type { DataSourceEditorController } from './applicationDataSourceEditor.component';
+import { APPLICATION_DATA_SOURCE_EDITOR } from './applicationDataSourceEditor.component';
 import { ApplicationModelBuilder } from '../../applicationModel.builder';
-import { APPLICATION_DATA_SOURCE_EDITOR, DataSourceEditorController } from './applicationDataSourceEditor.component';
-import { ApplicationWriter } from '../../service/ApplicationWriter';
 import { TaskReader } from '../../../index';
+import { ApplicationWriter } from '../../service/ApplicationWriter';
 
 describe('Component: Application Data Source Editor', () => {
   let application: Application,

package/src/application/config/dataSources/applicationDataSourceEditor.component.ts

@@ -1,9 +1,10 @@
-import { IController, module } from 'angular';
+import type { IController } from 'angular';
+import { module } from 'angular';
 
-import { Application } from '../../application.model';
+import type { Application } from '../../application.model';
 import { ApplicationReader } from '../../service/ApplicationReader';
 import { ApplicationWriter } from '../../service/ApplicationWriter';
-import { ApplicationDataSource } from '../../service/applicationDataSource';
+import type { ApplicationDataSource } from '../../service/applicationDataSource';
 import { TaskReader } from '../../../task';
 
 import './applicationDataSourceEditor.component.less';

package/src/application/config/footer/configSectionFooter.component.spec.ts

@@ -1,7 +1,8 @@
 import { mock } from 'angular';
 
+import type { ConfigSectionFooterController } from './configSectionFooter.component';
+import { CONFIG_SECTION_FOOTER } from './configSectionFooter.component';
 import { ApplicationWriter } from '../../service/ApplicationWriter';
-import { CONFIG_SECTION_FOOTER, ConfigSectionFooterController } from './configSectionFooter.component';
 
 describe('Component: ConfigSectionFooter', () => {
   let $componentController: ng.IComponentControllerService,

package/src/application/config/footer/configSectionFooter.component.ts

@@ -1,7 +1,8 @@
-import { copy, IComponentOptions, IController, module, toJson } from 'angular';
+import type { IComponentOptions, IController } from 'angular';
+import { copy, module, toJson } from 'angular';
 import { cloneDeep } from 'lodash';
 
-import { Application } from '../../application.model';
+import type { Application } from '../../application.model';
 import { ApplicationWriter } from '../../service/ApplicationWriter';
 
 export interface IConfigSectionFooterViewState {

package/src/application/config/trafficGuard/trafficGuardConfig.component.ts

@@ -1,12 +1,16 @@
-import { ILogService, module, toJson } from 'angular';
+import type { ILogService } from 'angular';
+import { module, toJson } from 'angular';
 import { cloneDeep, uniq } from 'lodash';
 
-import { AccountService, IAccountDetails, IAggregatedAccounts, IRegion } from '../../../account/AccountService';
-import { Application } from '../../application.model';
-import { ClusterMatcher, IClusterMatchRule } from '../../../cluster/ClusterRuleMatcher';
-import { IConfigSectionFooterViewState } from '../footer/configSectionFooter.component';
+import type { IAccountDetails, IAggregatedAccounts, IRegion } from '../../../account/AccountService';
+import { AccountService } from '../../../account/AccountService';
+import type { Application } from '../../application.model';
+import type { IClusterMatchRule } from '../../../cluster/ClusterRuleMatcher';
+import { ClusterMatcher } from '../../../cluster/ClusterRuleMatcher';
+import type { IConfigSectionFooterViewState } from '../footer/configSectionFooter.component';
 import './trafficGuardConfig.help';
-import { CLUSTER_MATCHES_COMPONENT, IClusterMatch } from '../../../widgets/cluster/clusterMatches.component';
+import type { IClusterMatch } from '../../../widgets/cluster/clusterMatches.component';
+import { CLUSTER_MATCHES_COMPONENT } from '../../../widgets/cluster/clusterMatches.component';
 
 export interface ITrafficGuardRule extends IClusterMatchRule {
   enabled: boolean;

package/src/application/listExtractor/AppListExtractor.spec.ts

@@ -1,8 +1,8 @@
-import { IInstance, IServerGroup } from '../../domain';
-import { Application } from '../application.model';
-import { ApplicationModelBuilder } from '../applicationModel.builder';
 import { AppListExtractor } from './AppListExtractor';
-import { IMoniker } from '../../naming/IMoniker';
+import type { Application } from '../application.model';
+import { ApplicationModelBuilder } from '../applicationModel.builder';
+import type { IInstance, IServerGroup } from '../../domain';
+import type { IMoniker } from '../../naming/IMoniker';
 
 describe('AppListExtractor', function () {
   const buildApplication = (serverGroups: any[] = []): Application => {

package/src/application/listExtractor/AppListExtractor.ts

@@ -1,8 +1,8 @@
 import { compact, flatten, uniq } from 'lodash';
 
-import { Application } from '../application.model';
-import { IInstance, IServerGroup } from '../../domain';
-import { IMoniker } from '../../naming/IMoniker';
+import type { Application } from '../application.model';
+import type { IInstance, IServerGroup } from '../../domain';
+import type { IMoniker } from '../../naming/IMoniker';
 
 export type IServerGroupFilter = (s: IServerGroup) => boolean;
 

package/src/application/modal/PermissionsConfigurer.spec.tsx

@@ -1,10 +1,11 @@
-import React from 'react';
 import { mock } from 'angular';
 import { mount } from 'enzyme';
+import React from 'react';
 
+import type { IPermissions, IPermissionsConfigurerProps } from './PermissionsConfigurer';
+import { PermissionsConfigurer } from './PermissionsConfigurer';
 import { AuthenticationService } from '../../authentication';
 import { REACT_MODULE } from '../../reactShims';
-import { IPermissions, IPermissionsConfigurerProps, PermissionsConfigurer } from './PermissionsConfigurer';
 
 describe('PermissionsConfigurer', () => {
   const createComponent = (props: IPermissionsConfigurerProps) => {

package/src/application/modal/PermissionsConfigurer.tsx

@@ -1,7 +1,8 @@
 import { cloneDeep, compact, intersection, uniq, without } from 'lodash';
 import React from 'react';
 import { Button } from 'react-bootstrap';
-import Select, { Creatable, Option } from 'react-select';
+import type { Option } from 'react-select';
+import Select, { Creatable } from 'react-select';
 
 import { AuthenticationService } from '../../authentication';
 

package/src/application/modal/PlatformHealthOverride.tsx

@@ -2,7 +2,8 @@ import { isEqual } from 'lodash';
 import React from 'react';
 
 import { HelpField } from '../../help/HelpField';
-import { createFakeReactSyntheticEvent, IFormInputProps } from '../../presentation';
+import type { IFormInputProps } from '../../presentation';
+import { createFakeReactSyntheticEvent } from '../../presentation';
 
 export interface IPlatformHealthOverrideProps {
   interestingHealthProviderNames: string[];

package/src/application/modal/editApplication.controller.modal.js

@@ -32,6 +32,7 @@ angular
       };
       vm.errorMsgs = [];
       vm.application = application;
+      vm.isNew = !application.attributes || !application.attributes.email;
       vm.applicationAttributes = _.cloneDeep(application.attributes);
 
       AccountService.listProviders().then((providers) => (vm.data.cloudProviders = providers));

package/src/application/modal/editApplication.html

@@ -1,7 +1,7 @@
 <div class="modal-page">
   <modal-close dismiss="$dismiss()"></modal-close>
   <div class="modal-header">
-    <h4 class="modal-title">Edit Application</h4>
+    <h4 class="modal-title">{{editApp.isNew ? "Create" : "Edit"}} Application</h4>
   </div>
 
   <form role="form" class="container-fluid" novalidate name="editApplicationForm">
@@ -252,7 +252,7 @@
     <div class="modal-footer">
       <a href class="btn btn-default" ng-click="$dismiss()">Cancel</a>
       <submit-button
-        is-new="false"
+        is-new="editApp.isNew"
         is-disabled="!editApplicationForm.$valid || editApp.state.submitting || editApp.data.showOverrideWarning || editApp.state.permissionsInvalid"
         submitting="editApp.state.submitting"
         on-click="editApp.submit()"

package/src/application/modal/validation/ApplicationNameValidator.spec.ts

@@ -1,6 +1,7 @@
 import { mock } from 'angular';
 
-import { ApplicationNameValidator, IApplicationNameValidationResult } from './ApplicationNameValidator';
+import type { IApplicationNameValidationResult } from './ApplicationNameValidator';
+import { ApplicationNameValidator } from './ApplicationNameValidator';
 import { ExampleApplicationNameValidator, ExampleApplicationNameValidator2 } from './ExampleApplicationNameValidator';
 import { AccountService } from '../../../account/AccountService';
 

package/src/application/modal/validation/ExampleApplicationNameValidator.ts

@@ -1,4 +1,5 @@
-import { ApplicationNameValidator, IApplicationNameValidator, IValidationResult } from './ApplicationNameValidator';
+import type { IApplicationNameValidator, IValidationResult } from './ApplicationNameValidator';
+import { ApplicationNameValidator } from './ApplicationNameValidator';
 import { CloudProviderRegistry } from '../../../cloudProvider';
 import { SETTINGS } from '../../../config/settings';
 

package/src/application/modal/validation/applicationNameValidationMessages.component.ts

@@ -1,5 +1,7 @@
-import { IController, module } from 'angular';
-import { ApplicationNameValidator, IApplicationNameValidationResult } from './ApplicationNameValidator';
+import type { IController } from 'angular';
+import { module } from 'angular';
+import type { IApplicationNameValidationResult } from './ApplicationNameValidator';
+import { ApplicationNameValidator } from './ApplicationNameValidator';
 
 /**
  * This directive is responsible for rendering error and warning messages to the screen when creating a new application.

package/src/application/modal/validation/validateApplicationName.directive.spec.ts

@@ -1,8 +1,9 @@
-import { ICompileService, IQService, IRootScopeService, mock } from 'angular';
+import type { ICompileService, IQService, IRootScopeService } from 'angular';
+import { mock } from 'angular';
 
 import { ExampleApplicationNameValidator, ExampleApplicationNameValidator2 } from './ExampleApplicationNameValidator';
-import { VALIDATE_APPLICATION_NAME } from './validateApplicationName.directive';
 import { AccountService } from '../../../account/AccountService';
+import { VALIDATE_APPLICATION_NAME } from './validateApplicationName.directive';
 
 describe('Validator: validateApplicationName', function () {
   const validator1 = new ExampleApplicationNameValidator();