@spinnaker/azure 2026.2.2 → 2026.3.0

package/src/securityGroup/clone/cloneSecurityGroup.controller.js

@@ -1,162 +0,0 @@
-'use strict';
-
-import { module } from 'angular';
-import _ from 'lodash';
-
-import { AccountService, FirewallLabels, TaskMonitor } from '@spinnaker/core';
-
-import { AZURE_SECURITYGROUP_CONFIGURE_CREATESECURITYGROUPCTRL } from '../configure/CreateSecurityGroupCtrl';
-import { AZURE_SECURITYGROUP_SECURITYGROUP_WRITE_SERVICE } from '../securityGroup.write.service';
-
-export const AZURE_SECURITYGROUP_CLONE_CLONESECURITYGROUP_CONTROLLER = 'spinnaker.azure.securityGroup.clone.controller';
-export const name = AZURE_SECURITYGROUP_CLONE_CLONESECURITYGROUP_CONTROLLER; // for backwards compatibility
-module(AZURE_SECURITYGROUP_CLONE_CLONESECURITYGROUP_CONTROLLER, [
-  AZURE_SECURITYGROUP_SECURITYGROUP_WRITE_SERVICE,
-  AZURE_SECURITYGROUP_CONFIGURE_CREATESECURITYGROUPCTRL,
-]).controller('azureCloneSecurityGroupController', [
-  '$scope',
-  '$uibModalInstance',
-  '$controller',
-  '$state',
-  'azureSecurityGroupWriter',
-  'securityGroup',
-  'application',
-  function ($scope, $uibModalInstance, $controller, $state, azureSecurityGroupWriter, securityGroup, application) {
-    const ctrl = this;
-
-    $scope.firewallLabel = FirewallLabels.get('Firewall');
-
-    $scope.pages = {
-      location: require('../configure/createSecurityGroupProperties.html'),
-      ingress: require('../configure/createSecurityGroupIngress.html'),
-    };
-
-    securityGroup.securityRules = _.map(securityGroup.securityRules, function (rule) {
-      const temp = rule.destinationPortRange.split('-');
-      rule.startPort = Number(temp[0]);
-      rule.endPort = Number(temp[1]);
-      return rule;
-    });
-
-    ctrl.accountUpdated = function () {
-      AccountService.getRegionsForAccount($scope.securityGroup.credentials).then(function (regions) {
-        $scope.regions = regions;
-        $scope.securityGroup.regions = regions;
-        ctrl.updateName();
-      });
-    };
-
-    ctrl.cancel = function () {
-      $uibModalInstance.dismiss();
-    };
-
-    ctrl.updateName = function () {
-      const securityGroup = $scope.securityGroup;
-      let name = application.name;
-      if (securityGroup.detail) {
-        name += '-' + securityGroup.detail;
-      }
-      securityGroup.name = name;
-      $scope.namePreview = name;
-    };
-
-    $scope.securityGroup = securityGroup;
-
-    $scope.state = {
-      refreshingSecurityGroups: false,
-    };
-
-    $scope.taskMonitor = new TaskMonitor({
-      application: application,
-      title: `Updating your ${FirewallLabels.get('firewall')}`,
-      modalInstance: $uibModalInstance,
-      onTaskComplete: onTaskComplete,
-    });
-
-    AccountService.listAccounts('azure').then(function (accounts) {
-      $scope.accounts = accounts;
-      ctrl.accountUpdated();
-    });
-
-    ctrl.addRule = function (ruleset) {
-      ruleset.push({
-        name: $scope.securityGroup.name + '-Rule' + ruleset.length,
-        priority: ruleset.length === 0 ? 100 : 100 * (ruleset.length + 1),
-        protocol: 'tcp',
-        access: 'Allow',
-        direction: 'InBound',
-        sourceAddressPrefix: '*',
-        sourcePortRange: '*',
-        destinationAddressPrefix: '*',
-        destinationPortRange: '7001-7001',
-        startPort: 7001,
-        endPort: 7001,
-      });
-    };
-
-    function onApplicationRefresh() {
-      // If the user has already closed the modal, do not navigate to the new details view
-      if ($scope.$$destroyed) {
-        return;
-      }
-      $uibModalInstance.close();
-      const newStateParams = {
-        name: $scope.securityGroup.name,
-        accountId: $scope.securityGroup.credentials || $scope.securityGroup.accountName,
-        region: $scope.securityGroup.region,
-        provider: 'azure',
-      };
-      if (!$state.includes('**.firewallDetails')) {
-        $state.go('.firewallDetails', newStateParams);
-      } else {
-        $state.go('^.firewallDetails', newStateParams);
-      }
-    }
-
-    function onTaskComplete() {
-      application.securityGroups.refresh();
-      application.securityGroups.onNextRefresh($scope, onApplicationRefresh);
-    }
-
-    ctrl.portUpdated = function (ruleset, index) {
-      ruleset[index].destinationPortRange = ruleset[index].startPort + '-' + ruleset[index].endPort;
-    };
-    ctrl.removeRule = function (ruleset, index) {
-      ruleset.splice(index, 1);
-    };
-    ctrl.moveUp = function (ruleset, index) {
-      if (index === 0) return;
-      swapRules(ruleset, index, index - 1);
-    };
-    ctrl.moveDown = function (ruleset, index) {
-      if (index === ruleset.length - 1) return;
-      swapRules(ruleset, index, index + 1);
-    };
-    function swapRules(ruleset, a, b) {
-      const temp = ruleset[b];
-      const priorityA = ruleset[a].priority;
-      const priorityB = ruleset[b].priority;
-      //swap elements
-      ruleset[b] = ruleset[a];
-      ruleset[a] = temp;
-      //swap priorities
-      ruleset[a].priority = priorityA;
-      ruleset[b].priority = priorityB;
-    }
-
-    ctrl.upsert = function () {
-      $scope.taskMonitor.submit(function () {
-        const params = {
-          cloudProvider: 'azure',
-          appName: application.name,
-          region: $scope.securityGroup.region,
-          subnet: 'none',
-          vpcId: 'null',
-        };
-        $scope.securityGroup.type = 'upsertSecurityGroup';
-
-        return azureSecurityGroupWriter.upsertSecurityGroup($scope.securityGroup, application, 'Clone', params);
-      });
-    };
-  },
-]);

package/src/securityGroup/clone/cloneSecurityGroup.html

@@ -1,8 +0,0 @@
-<v2-modal-wizard heading="Clone {{firewallLabel}}">
-  <v2-wizard-page key="Location" label="Location">
-    <ng-include src="pages.location"></ng-include>
-  </v2-wizard-page>
-  <v2-wizard-page key="Ingress" label="Ingress" done="true">
-    <ng-include src="pages.ingress"></ng-include>
-  </v2-wizard-page>
-</v2-modal-wizard>

package/src/securityGroup/configure/CreateSecurityGroup.controller.spec.js

@@ -1,78 +0,0 @@
-'use strict';
-import { mockHttpClient } from 'core/api/mock/jasmine';
-import { AccountService, SECURITY_GROUP_READER } from '@spinnaker/core';
-
-describe('Controller: Azure.CreateSecurityGroup', function () {
-  beforeEach(window.module(SECURITY_GROUP_READER, require('./CreateSecurityGroupCtrl').name));
-
-  describe('filtering', function () {
-    // Initialize the controller and a mock scope
-    beforeEach(
-      window.inject(function ($controller, $rootScope, $q, securityGroupReader, azureSecurityGroupWriter) {
-        this.$scope = $rootScope.$new();
-        this.$q = $q;
-        this.securityGroupReader = securityGroupReader;
-        this.securityGroupWriter = azureSecurityGroupWriter;
-
-        spyOn(AccountService, 'listAccounts').and.returnValue($q.when(['prod', 'test']));
-
-        spyOn(AccountService, 'getRegionsForAccount').and.returnValue($q.when(['us-east-1', 'us-west-1']));
-
-        spyOn(this.securityGroupReader, 'getAllSecurityGroups').and.returnValue(
-          $q.when({
-            prod: {
-              azure: {
-                'us-east-1': [
-                  { name: 'group1', vpcId: null, id: '1' },
-                  { name: 'group2', vpcId: null, id: '2' },
-                  { name: 'group3', vpcId: 'vpc1-pe', id: '3' },
-                ],
-                'us-west-1': [
-                  { name: 'group1', vpcId: null, id: '1' },
-                  { name: 'group3', vpcId: 'vpc2-pw', id: '3' },
-                ],
-              },
-            },
-            test: {
-              azure: {
-                'us-east-1': [
-                  { name: 'group1', vpcId: null, id: '1' },
-                  { name: 'group2', vpcId: 'vpc1-te', id: '2' },
-                  { name: 'group3', vpcId: 'vpc1-te', id: '3' },
-                  { name: 'group4', vpcId: 'vpc2-te', id: '4' },
-                ],
-                'us-west-1': [
-                  { name: 'group1', vpcId: null, id: '1' },
-                  { name: 'group3', vpcId: 'vpc1-tw', id: '3' },
-                  { name: 'group3', vpcId: 'vpc2-tw', id: '3' },
-                  { name: 'group5', vpcId: 'vpc2-tw', id: '5' },
-                ],
-              },
-            },
-          }),
-        );
-
-        this.initializeCtrl = function () {
-          this.ctrl = $controller('azureCreateSecurityGroupCtrl', {
-            $scope: this.$scope,
-            $uibModalInstance: { result: this.$q.when(null) },
-            securityGroupReader: this.securityGroupReader,
-            securityGroupWriter: this.securityGroupWriter,
-            application: {},
-            securityGroup: { regions: [], securityGroupIngress: [] },
-          });
-
-          this.$scope.$digest();
-        };
-      }),
-    );
-
-    it('initializes with no firewalls available for ingress permissions', async function () {
-      const http = mockHttpClient();
-      http.expectGET('/networks').respond(200, []);
-      this.initializeCtrl();
-      await http.flush();
-      expect(this.$scope.securityGroup.securityRules.length).toBe(0);
-    });
-  });
-});

package/src/securityGroup/configure/CreateSecurityGroupCtrl.js

@@ -1,265 +0,0 @@
-'use strict';
-
-import UIROUTER_ANGULARJS from '@uirouter/angularjs';
-import { module } from 'angular';
-import _ from 'lodash';
-
-import { AccountService, FirewallLabels, NetworkReader, TaskMonitor } from '@spinnaker/core';
-
-import { AZURE_SECURITYGROUP_SECURITYGROUP_WRITE_SERVICE } from '../securityGroup.write.service';
-
-export const AZURE_SECURITYGROUP_CONFIGURE_CREATESECURITYGROUPCTRL = 'spinnaker.azure.securityGroup.create.controller';
-export const name = AZURE_SECURITYGROUP_CONFIGURE_CREATESECURITYGROUPCTRL; // for backwards compatibility
-module(AZURE_SECURITYGROUP_CONFIGURE_CREATESECURITYGROUPCTRL, [
-  UIROUTER_ANGULARJS,
-  AZURE_SECURITYGROUP_SECURITYGROUP_WRITE_SERVICE,
-]).controller('azureCreateSecurityGroupCtrl', [
-  '$scope',
-  '$uibModalInstance',
-  '$state',
-  '$controller',
-  'application',
-  'securityGroup',
-  'azureSecurityGroupWriter',
-  function ($scope, $uibModalInstance, $state, $controller, application, securityGroup, azureSecurityGroupWriter) {
-    $scope.pages = {
-      location: require('./createSecurityGroupProperties.html'),
-      ingress: require('./createSecurityGroupIngress.html'),
-    };
-
-    $scope.regions = [];
-
-    $scope.firewallLabel = FirewallLabels.get('Firewall');
-
-    const ctrl = this;
-    $scope.isNew = true;
-    $scope.state = {
-      submitting: false,
-      infiniteScroll: {
-        numToAdd: 20,
-        currentItems: 20,
-      },
-    };
-
-    AccountService.listAccounts('azure').then(function (accounts) {
-      $scope.accounts = accounts;
-      ctrl.accountUpdated();
-    });
-
-    ctrl.addMoreItems = function () {
-      $scope.state.infiniteScroll.currentItems += $scope.state.infiniteScroll.numToAdd;
-    };
-
-    function onApplicationRefresh() {
-      // If the user has already closed the modal, do not navigate to the new details view
-      if ($scope.$$destroyed) {
-        return;
-      }
-      $uibModalInstance.close();
-      const newStateParams = {
-        name: $scope.securityGroup.name,
-        accountId: $scope.securityGroup.credentials || $scope.securityGroup.accountName,
-        region: $scope.securityGroup.regions[0],
-        provider: 'azure',
-      };
-      if (!$state.includes('**.firewallDetails')) {
-        $state.go('.firewallDetails', newStateParams);
-      } else {
-        $state.go('^.firewallDetails', newStateParams);
-      }
-    }
-
-    function onTaskComplete() {
-      application.securityGroups.refresh();
-      application.securityGroups.onNextRefresh($scope, onApplicationRefresh);
-    }
-
-    $scope.taskMonitor = new TaskMonitor({
-      application: application,
-      title: `Creating your ${FirewallLabels.get('firewall')}`,
-      modalInstance: $uibModalInstance,
-      onTaskComplete: onTaskComplete,
-    });
-
-    $scope.securityGroup = securityGroup;
-
-    ctrl.accountUpdated = function () {
-      AccountService.getRegionsForAccount($scope.securityGroup.credentials).then(function (regions) {
-        $scope.regions = regions;
-        $scope.securityGroup.regions = regions;
-        ctrl.updateName();
-        ctrl.regionUpdated();
-      });
-    };
-
-    this.regionUpdated = function () {
-      ctrl.vnetUpdated();
-    };
-
-    this.vnetUpdated = function () {
-      const account = $scope.securityGroup.credentials;
-      const region = $scope.securityGroup.region;
-      $scope.securityGroup.selectedVnet = null;
-      $scope.securityGroup.vnet = null;
-      $scope.securityGroup.vnetResourceGroup = null;
-
-      ctrl.selectedVnets = [];
-
-      NetworkReader.listNetworks().then(function (vnets) {
-        if (vnets.azure) {
-          vnets.azure.forEach((vnet) => {
-            if (vnet.account === account && vnet.region === region) {
-              ctrl.selectedVnets.push(vnet);
-            }
-          });
-        }
-      });
-
-      ctrl.subnetUpdated();
-    };
-
-    this.subnetUpdated = function () {
-      $scope.securityGroup.selectedSubnet = null;
-      $scope.securityGroup.subnet = null;
-      ctrl.selectedSubnets = [];
-    };
-
-    this.selectedVnetChanged = function (item) {
-      $scope.securityGroup.vnet = item.name;
-      $scope.securityGroup.vnetResourceGroup = item.resourceGroup;
-      $scope.securityGroup.selectedSubnet = null;
-      $scope.securityGroup.subnet = null;
-      ctrl.selectedSubnets = [];
-      if (item.subnets) {
-        item.subnets.map(function (subnet) {
-          ctrl.selectedSubnets.push(subnet);
-        });
-      }
-    };
-
-    ctrl.cancel = function () {
-      $uibModalInstance.dismiss();
-    };
-
-    ctrl.updateName = function () {
-      const securityGroup = $scope.securityGroup;
-      let name = application.name;
-      if (securityGroup.detail) {
-        name += '-' + securityGroup.detail;
-      }
-      securityGroup.name = name;
-      $scope.namePreview = name;
-    };
-
-    ctrl.upsert = function () {
-      $scope.taskMonitor.submit(function () {
-        const params = {
-          cloudProvider: 'azure',
-          appName: application.name,
-          region: $scope.securityGroup.region,
-          vpcId: 'null',
-        };
-
-        if ($scope.securityGroup.selectedVnet) {
-          $scope.securityGroup.vnet = $scope.securityGroup.selectedVnet.name;
-          $scope.securityGroup.vnetResourceGroup = $scope.securityGroup.selectedVnet.resourceGroup;
-        }
-
-        if ($scope.securityGroup.selectedSubnet) {
-          $scope.securityGroup.subnet = $scope.securityGroup.selectedSubnet.name;
-        }
-
-        $scope.securityGroup.type = 'upsertSecurityGroup';
-
-        return azureSecurityGroupWriter.upsertSecurityGroup($scope.securityGroup, application, 'Create', params);
-      });
-    };
-
-    ctrl.addRule = function (ruleset) {
-      ruleset.push({
-        name: $scope.securityGroup.name + '-Rule' + ruleset.length,
-        priority: ruleset.length == 0 ? 100 : 100 * (ruleset.length + 1),
-        protocolUI: 'tcp',
-        protocol: 'tcp',
-        access: 'Allow',
-        direction: 'InBound',
-        sourceAddressPrefix: '*',
-        sourceAddressPrefixes: [],
-        sourcePortRange: '*',
-        destinationAddressPrefix: '*',
-        destinationPortRange: '*',
-        destinationPortRanges: [],
-        destPortRanges: '*',
-        sourceIPCIDRRanges: '*',
-      });
-    };
-
-    ctrl.portUpdated = function (ruleset, index) {
-      if (!_.isEmpty(ruleset[index].destPortRanges)) {
-        const ruleRanges = ruleset[index].destPortRanges.split(',');
-
-        if (ruleRanges.length > 1) {
-          ruleset[index].destinationPortRanges = [];
-          ruleRanges.forEach((v) => ruleset[index].destinationPortRanges.push(v));
-
-          // If there are multiple port ranges then set null to the single port parameter otherwise ARM template will fail in validation.
-          ruleset[index].destinationPortRange = null;
-        } else {
-          ruleset[index].destinationPortRange = ruleset[index].destPortRanges;
-
-          // If there is a single port range then set null to the port array otherwise ARM template will fail in validation.
-          ruleset[index].destinationPortRanges = [];
-        }
-      }
-    };
-
-    ctrl.sourceIPCIDRUpdated = function (ruleset, index) {
-      if (!_.isEmpty(ruleset[index].destPortRanges)) {
-        const ruleRanges = ruleset[index].sourceIPCIDRRanges.split(',');
-        if (ruleRanges.length > 1) {
-          ruleset[index].sourceAddressPrefixes = [];
-          ruleRanges.forEach((v) => ruleset[index].sourceAddressPrefixes.push(v));
-
-          // If there are multiple IP/CIDR ranges then set null to the single sourceAddressPrefix parameter otherwise ARM template will fail in validation
-          ruleset[index].sourceAddressPrefix = null;
-        } else {
-          ruleset[index].sourceAddressPrefix = ruleset[index].sourceIPCIDRRanges;
-
-          // If there is a single IP/CIDR then set null to the IP/CIDR array otherwise ARM template will fail in validation.
-          ruleset[index].sourceAddressPrefixes = [];
-        }
-      }
-    };
-
-    ctrl.protocolUpdated = function (ruleset, index) {
-      ruleset[index].protocol = ruleset[index].protocolUI;
-    };
-
-    ctrl.removeRule = function (ruleset, index) {
-      ruleset.splice(index, 1);
-    };
-
-    ctrl.moveUp = function (ruleset, index) {
-      if (index === 0) return;
-      swapRules(ruleset, index, index - 1);
-    };
-    ctrl.moveDown = function (ruleset, index) {
-      if (index === ruleset.length - 1) return;
-      swapRules(ruleset, index, index + 1);
-    };
-
-    function swapRules(ruleset, a, b) {
-      const temp = ruleset[b];
-      const priorityA = ruleset[a].priority;
-      const priorityB = ruleset[b].priority;
-      //swap elements
-      ruleset[b] = ruleset[a];
-      ruleset[a] = temp;
-      //swap priorities
-      ruleset[a].priority = priorityA;
-      ruleset[b].priority = priorityB;
-    }
-
-    $scope.securityGroup.securityRules = [];
-  },
-]);