@spinnaker/amazon 2026.3.2 → 2026.4.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (202) hide show
  1. package/dist/common/AwsModalFooter.d.ts +1 -1
  2. package/dist/deploymentStrategy/AdditionalFields.d.ts +1 -1
  3. package/dist/function/CreateLambdaFunction.d.ts +1 -1
  4. package/dist/function/configure/ExecutionRole.d.ts +1 -1
  5. package/dist/function/configure/FunctionBasicInformation.d.ts +1 -1
  6. package/dist/function/configure/FunctionDebugAndErrorHandling.d.ts +1 -1
  7. package/dist/function/configure/FunctionEnvironmentVariables.d.ts +1 -1
  8. package/dist/function/configure/FunctionSettings.d.ts +1 -1
  9. package/dist/function/configure/FunctionTags.d.ts +1 -1
  10. package/dist/function/configure/Network.d.ts +1 -1
  11. package/dist/function/details/AmazonFunctionDetails.d.ts +1 -1
  12. package/dist/function/details/FunctionActions.d.ts +1 -1
  13. package/dist/index.js +279 -1
  14. package/dist/index.js.map +1 -1
  15. package/dist/instance/details/AmazonInstanceInformation.d.ts +2 -2
  16. package/dist/instance/details/CostFactor.d.ts +2 -2
  17. package/dist/instance/details/InstanceDns.d.ts +2 -2
  18. package/dist/instance/details/InstanceInformation.d.ts +2 -2
  19. package/dist/instance/details/InstanceSecurityGroups.d.ts +2 -2
  20. package/dist/instance/details/InstanceStatus.d.ts +2 -2
  21. package/dist/instance/details/InstanceTags.d.ts +2 -2
  22. package/dist/loadBalancer/configure/AmazonLoadBalancerChoiceModal.d.ts +1 -1
  23. package/dist/loadBalancer/configure/application/ALBListeners.d.ts +1 -1
  24. package/dist/loadBalancer/configure/application/ConfigureOidcConfigModal.d.ts +1 -1
  25. package/dist/loadBalancer/configure/application/ConfigureRedirectConfigModal.d.ts +1 -1
  26. package/dist/loadBalancer/configure/application/CreateApplicationLoadBalancer.d.ts +1 -1
  27. package/dist/loadBalancer/configure/application/TargetGroups.d.ts +1 -1
  28. package/dist/loadBalancer/configure/classic/AdvancedSettings.d.ts +1 -1
  29. package/dist/loadBalancer/configure/classic/HealthCheck.d.ts +1 -1
  30. package/dist/loadBalancer/configure/classic/Listeners.d.ts +1 -1
  31. package/dist/loadBalancer/configure/common/AmazonCertificateSelectField.d.ts +1 -1
  32. package/dist/loadBalancer/configure/common/LoadBalancerLocation.d.ts +1 -1
  33. package/dist/loadBalancer/configure/common/SecurityGroups.d.ts +1 -1
  34. package/dist/loadBalancer/configure/network/CertificateSelectors.d.ts +2 -2
  35. package/dist/loadBalancer/configure/network/NLBListeners.d.ts +1 -1
  36. package/dist/loadBalancer/configure/network/TargetGroups.d.ts +1 -1
  37. package/dist/loadBalancer/details/LoadBalancerActions.d.ts +1 -1
  38. package/dist/pipeline/stages/AmazonStageConfig.d.ts +2 -2
  39. package/dist/pipeline/stages/bake/AwsBakeStageConfig.d.ts +2 -2
  40. package/dist/pipeline/stages/cloneServerGroup/AwsCloneServerGroupStageConfig.d.ts +2 -2
  41. package/dist/pipeline/stages/deleteLambda/DeleteLambdaFunctionStageForm.d.ts +2 -2
  42. package/dist/pipeline/stages/deleteLambda/LambdaDeleteStage.d.ts +2 -2
  43. package/dist/pipeline/stages/deleteLambda/constants/deleteVersion.picker.d.ts +1 -1
  44. package/dist/pipeline/stages/deployCloudFormation/CloudFormationChangeSetInfo.d.ts +2 -2
  45. package/dist/pipeline/stages/deployCloudFormation/DeployCloudFormationStackStageConfig.d.ts +2 -2
  46. package/dist/pipeline/stages/deployCloudFormation/deployCloudFormationExecutionDetails.d.ts +1 -1
  47. package/dist/pipeline/stages/deployCloudFormation/evaluateCloudFormationChangeSetExecutionApproval.d.ts +2 -2
  48. package/dist/pipeline/stages/deployCloudFormation/evaluateCloudFormationChangeSetExecutionDetails.d.ts +1 -1
  49. package/dist/pipeline/stages/deployCloudFormation/evaluateCloudFormationChangeSetExecutionLabel.d.ts +1 -1
  50. package/dist/pipeline/stages/deployCloudFormation/evaluateCloudFormationChangeSetExecutionMarkerIcon.d.ts +1 -1
  51. package/dist/pipeline/stages/deployLambda/components/AwsLambdaFunctionStageForm.d.ts +2 -2
  52. package/dist/pipeline/stages/deployLambda/components/BasicSettingsForm.d.ts +2 -2
  53. package/dist/pipeline/stages/deployLambda/components/EnvironmentForm.d.ts +2 -2
  54. package/dist/pipeline/stages/deployLambda/components/ExecutionRoleForm.d.ts +2 -2
  55. package/dist/pipeline/stages/deployLambda/components/LambdaAtEdgeForm.d.ts +2 -2
  56. package/dist/pipeline/stages/deployLambda/components/NetworkForm.d.ts +2 -2
  57. package/dist/pipeline/stages/deployLambda/components/TriggerEventsForm.d.ts +2 -2
  58. package/dist/pipeline/stages/deployLambda/config/LambdaDeploymentStageConfig.d.ts +2 -2
  59. package/dist/pipeline/stages/deployLambda/config/LambdaDeploymentStageExecutionDetails.d.ts +2 -2
  60. package/dist/pipeline/stages/disableAsg/AwsDisableAsgStageConfig.d.ts +2 -2
  61. package/dist/pipeline/stages/disableCluster/AwsDisableClusterStageConfig.d.ts +2 -2
  62. package/dist/pipeline/stages/enableAsg/AwsEnableAsgStageConfig.d.ts +2 -2
  63. package/dist/pipeline/stages/findImageFromTags/AwsFindImageFromTagsStageConfig.d.ts +2 -2
  64. package/dist/pipeline/stages/invokeLambda/InvokeLambdaFunctionStageForm.d.ts +2 -2
  65. package/dist/pipeline/stages/invokeLambda/LambdaInvokeStage.d.ts +2 -2
  66. package/dist/pipeline/stages/invokeLambda/components/InvokeLambdaOperation.d.ts +2 -2
  67. package/dist/pipeline/stages/modifyScalingProcess/ModifyScalingProcessStageConfig.d.ts +2 -2
  68. package/dist/pipeline/stages/modifyWarmPool/ModifyWarmPoolStageConfig.d.ts +2 -2
  69. package/dist/pipeline/stages/resizeAsg/AwsResizeAsgStageConfig.d.ts +2 -2
  70. package/dist/pipeline/stages/rollbackCluster/AwsRollbackClusterStageConfig.d.ts +2 -2
  71. package/dist/pipeline/stages/routeLambda/LambdaRouteStage.d.ts +2 -2
  72. package/dist/pipeline/stages/routeLambda/RouteLambdaFunctionStageForm.d.ts +2 -2
  73. package/dist/pipeline/stages/routeLambda/TriggerEventsForm.d.ts +2 -2
  74. package/dist/pipeline/stages/routeLambda/components/BlueGreenDeployment/BlueGreenDeploymentForm.d.ts +2 -2
  75. package/dist/pipeline/stages/routeLambda/components/BlueGreenDeployment/HealthCheckStrategy.d.ts +2 -2
  76. package/dist/pipeline/stages/routeLambda/components/BlueGreenDeployment/InvocationHealthCheck.d.ts +2 -2
  77. package/dist/pipeline/stages/routeLambda/components/DeploymentStrategyForm.d.ts +2 -2
  78. package/dist/pipeline/stages/routeLambda/components/RenderStrategy.d.ts +2 -2
  79. package/dist/pipeline/stages/routeLambda/components/SimpleDeploymentForm.d.ts +2 -2
  80. package/dist/pipeline/stages/routeLambda/components/VersionPicker.d.ts +1 -1
  81. package/dist/pipeline/stages/routeLambda/components/WeightedDeploymentForm.d.ts +2 -2
  82. package/dist/pipeline/stages/routeLambda/constants/strategy.picker.d.ts +1 -1
  83. package/dist/pipeline/stages/scaleDownCluster/AwsScaleDownClusterStageConfig.d.ts +2 -2
  84. package/dist/pipeline/stages/shrinkCluster/AwsShrinkClusterStageConfig.d.ts +2 -2
  85. package/dist/pipeline/stages/tagImage/awsTagImageStage.d.ts +2 -2
  86. package/dist/pipeline/stages/updateCodeLambda/LambdaUpdateCodeStageConfig.d.ts +2 -2
  87. package/dist/pipeline/stages/updateCodeLambda/LambdaUpdateCodeStageExecutionDetails.d.ts +2 -2
  88. package/dist/pipeline/stages/updateCodeLambda/components/UpdateCodeStageForm.d.ts +2 -2
  89. package/dist/securityGroup/details/IPRangeRules.d.ts +1 -1
  90. package/dist/serverGroup/configure/AmazonImageSelectInput.d.ts +1 -1
  91. package/dist/serverGroup/configure/wizard/AmazonCloneServerGroupModal.d.ts +1 -1
  92. package/dist/serverGroup/configure/wizard/ServerGroupTemplateSelection.d.ts +1 -1
  93. package/dist/serverGroup/configure/wizard/capacity/CapacitySelector.d.ts +1 -1
  94. package/dist/serverGroup/configure/wizard/capacity/MinMaxDesired.d.ts +1 -1
  95. package/dist/serverGroup/configure/wizard/instanceType/CpuCreditsToggle.d.ts +2 -2
  96. package/dist/serverGroup/configure/wizard/instanceType/InstanceTypeSelector.d.ts +2 -2
  97. package/dist/serverGroup/configure/wizard/instanceType/InstanceTypeWarning.d.ts +2 -2
  98. package/dist/serverGroup/configure/wizard/instanceType/advancedMode/AdvancedModeSelector.d.ts +2 -2
  99. package/dist/serverGroup/configure/wizard/instanceType/advancedMode/AmazonInstanceTypeInfoRenderer.d.ts +2 -2
  100. package/dist/serverGroup/configure/wizard/instanceType/advancedMode/InstanceProfileSelector.d.ts +2 -2
  101. package/dist/serverGroup/configure/wizard/instanceType/advancedMode/InstanceTypeRow.d.ts +2 -2
  102. package/dist/serverGroup/configure/wizard/instanceType/advancedMode/InstanceTypeSelect.d.ts +2 -2
  103. package/dist/serverGroup/configure/wizard/instanceType/advancedMode/InstanceTypeTable.d.ts +2 -2
  104. package/dist/serverGroup/configure/wizard/instanceType/advancedMode/InstanceTypeTableBody.d.ts +2 -2
  105. package/dist/serverGroup/configure/wizard/instanceType/advancedMode/InstanceTypeTableParts.d.ts +4 -4
  106. package/dist/serverGroup/configure/wizard/instanceType/advancedMode/InstancesDistribution.d.ts +2 -2
  107. package/dist/serverGroup/configure/wizard/instanceType/simpleMode/SimpleModeSelector.d.ts +2 -2
  108. package/dist/serverGroup/configure/wizard/pages/ServerGroupBasicSettings.d.ts +1 -1
  109. package/dist/serverGroup/configure/wizard/pages/ServerGroupCapacity.d.ts +1 -1
  110. package/dist/serverGroup/configure/wizard/pages/ServerGroupInstanceType.d.ts +1 -1
  111. package/dist/serverGroup/configure/wizard/pages/ServerGroupLoadBalancers.d.ts +1 -1
  112. package/dist/serverGroup/configure/wizard/pages/ServerGroupSecurityGroups.d.ts +1 -1
  113. package/dist/serverGroup/configure/wizard/pages/ServerGroupZones.d.ts +1 -1
  114. package/dist/serverGroup/configure/wizard/pages/advancedSettings/ServerGroupAdvancedSettings.d.ts +1 -1
  115. package/dist/serverGroup/configure/wizard/pages/advancedSettings/ServerGroupAdvancedSettingsCommon.d.ts +1 -1
  116. package/dist/serverGroup/configure/wizard/pages/advancedSettings/ServerGroupAdvancedSettingsInner.d.ts +1 -1
  117. package/dist/serverGroup/configure/wizard/securityGroups/SecurityGroupSelector.d.ts +1 -1
  118. package/dist/serverGroup/configure/wizard/securityGroups/ServerGroupSecurityGroupsRemoved.d.ts +1 -1
  119. package/dist/serverGroup/details/advancedSettings/EditAsgAdvancedSettingsModal.d.ts +2 -1
  120. package/dist/serverGroup/details/resize/AmazonResizeServerGroupModal.d.ts +1 -1
  121. package/dist/serverGroup/details/scalingPolicy/CreateScalingPolicyButton.d.ts +1 -1
  122. package/dist/serverGroup/details/scalingPolicy/ScalingPolicySummary.d.ts +2 -2
  123. package/dist/serverGroup/details/scalingPolicy/StepPolicySummary.d.ts +2 -2
  124. package/dist/serverGroup/details/scalingPolicy/chart/DateLineChart.d.ts +2 -2
  125. package/dist/serverGroup/details/scalingPolicy/chart/MetricAlarmChart.d.ts +3 -3
  126. package/dist/serverGroup/details/scalingPolicy/popover/AlarmSummary.d.ts +2 -2
  127. package/dist/serverGroup/details/scalingPolicy/popover/StepPolicyPopoverContent.d.ts +2 -2
  128. package/dist/serverGroup/details/scalingPolicy/targetTracking/TargetMetricFields.d.ts +2 -2
  129. package/dist/serverGroup/details/scalingPolicy/targetTracking/TargetTrackingAdditionalSettings.d.ts +2 -3
  130. package/dist/serverGroup/details/scalingPolicy/targetTracking/TargetTrackingChart.d.ts +2 -2
  131. package/dist/serverGroup/details/scalingPolicy/targetTracking/TargetTrackingSummary.d.ts +2 -2
  132. package/dist/serverGroup/details/scalingPolicy/targetTracking/UpsertTargetTrackingModal.d.ts +2 -2
  133. package/dist/serverGroup/details/scalingPolicy/upsert/PolicyTypeSelectionModal.d.ts +2 -2
  134. package/dist/serverGroup/details/scalingPolicy/upsert/ScalingPolicyAdditionalSettings.d.ts +2 -2
  135. package/dist/serverGroup/details/scalingPolicy/upsert/UpsertScalingPolicyModal.d.ts +2 -2
  136. package/dist/serverGroup/details/scalingPolicy/upsert/alarm/AlarmConfigurer.d.ts +2 -2
  137. package/dist/serverGroup/details/scalingPolicy/upsert/alarm/DimensionsEditor.d.ts +2 -2
  138. package/dist/serverGroup/details/scalingPolicy/upsert/alarm/MetricSelector.d.ts +2 -2
  139. package/dist/serverGroup/details/scalingPolicy/upsert/simple/SimplePolicyAction.d.ts +2 -2
  140. package/dist/serverGroup/details/scalingPolicy/upsert/step/StepPolicyAction.d.ts +2 -2
  141. package/dist/serverGroup/details/scalingProcesses/ModifyScalingProcessesModal.d.ts +1 -1
  142. package/dist/serverGroup/details/scheduledAction/ScheduledAction.d.ts +1 -1
  143. package/dist/serverGroup/details/scheduledActions/EditScheduledActionsModal.d.ts +1 -1
  144. package/dist/serverGroup/details/sections/InstancesDistributionDetailsSection.d.ts +2 -2
  145. package/dist/serverGroup/details/sections/LaunchTemplateDetailsSection.d.ts +2 -2
  146. package/dist/serverGroup/details/sections/MultipleInstanceTypesSubSection.d.ts +2 -2
  147. package/dist/serverGroup/details/securityGroups/EditSecurityGroupsModal.d.ts +1 -1
  148. package/dist/serverGroup/details/warmPool/ModifyWarmPoolModal.d.ts +1 -1
  149. package/dist/subnet/SubnetSelectField.d.ts +1 -1
  150. package/dist/subnet/SubnetSelectInput.d.ts +1 -1
  151. package/dist/vpc/VpcTag.d.ts +2 -2
  152. package/package.json +5 -7
  153. package/src/aws.module.spec.ts +20 -21
  154. package/src/function/details/AmazonFunctionDetails.tsx +1 -1
  155. package/src/function/details/FunctionActions.spec.tsx +56 -36
  156. package/src/instance/awsInstanceType.service.spec.js +24 -22
  157. package/src/instance/details/AmazonInstanceDetails.spec.tsx +7 -7
  158. package/src/instance/details/InstanceInformation.spec.tsx +44 -24
  159. package/src/loadBalancer/AmazonLoadBalancersTag.spec.tsx +1 -1
  160. package/src/loadBalancer/TargetGroupDetails.spec.tsx +5 -5
  161. package/src/loadBalancer/configure/application/TargetGroups.tsx +1 -1
  162. package/src/loadBalancer/configure/common/SecurityGroups.spec.tsx +4 -4
  163. package/src/loadBalancer/configure/network/TargetGroups.tsx +1 -1
  164. package/src/loadBalancer/details/amazonLoadBalancerDetails.spec.tsx +31 -53
  165. package/src/pipeline/stages/AmazonStageConfig.spec.tsx +37 -46
  166. package/src/pipeline/stages/deployCloudFormation/DeployCloudFormationStackStageConfig.tsx +1 -0
  167. package/src/pipeline/stages/deployCloudFormation/deployCloudFormationStackStage.spec.tsx +316 -279
  168. package/src/pipeline/stages/findImageFromTags/AwsFindImageFromTagsStageConfig.spec.tsx +70 -90
  169. package/src/pipeline/stages/modifyScalingProcess/modifyScalingProcessStage.spec.tsx +198 -130
  170. package/src/pipeline/stages/modifyWarmPool/modifyWarmPoolStage.spec.tsx +49 -40
  171. package/src/pipeline/stages/resizeAsg/AwsResizeAsgStageConfig.spec.tsx +341 -427
  172. package/src/pipeline/stages/resizeAsg/AwsResizeAsgStageConfig.tsx +7 -0
  173. package/src/pipeline/stages/tagImage/awsTagImageStage.spec.tsx +62 -107
  174. package/src/routerConsumers.spec.tsx +23 -23
  175. package/src/securityGroup/configure/AmazonSecurityGroupModal.spec.tsx +38 -47
  176. package/src/securityGroup/details/AmazonSecurityGroupDetails.spec.tsx +7 -6
  177. package/src/serverGroup/configure/AmazonImageSelectInput.spec.tsx +47 -65
  178. package/src/serverGroup/configure/AmazonImageSelectInput.tsx +1 -1
  179. package/src/serverGroup/configure/serverGroupCommandBuilder.aws.service.spec.js +18 -19
  180. package/src/serverGroup/configure/serverGroupCommandBuilder.spec.js +41 -26
  181. package/src/serverGroup/configure/wizard/instanceType/simpleMode/SimpleModeSelector.spec.tsx +52 -75
  182. package/src/serverGroup/configure/wizard/pages/ServerGroupBasicSettings.spec.tsx +1 -1
  183. package/src/serverGroup/configure/wizard/pages/advancedSettings/ServerGroupAdvancedSettingsCommon.spec.tsx +36 -33
  184. package/src/serverGroup/configure/wizard/pages/advancedSettings/ServerGroupAdvancedSettingsCommon.tsx +7 -1
  185. package/src/serverGroup/configure/wizard/securityGroups/SecurityGroupSelector.spec.tsx +2 -2
  186. package/src/serverGroup/details/AmazonServerGroupActions.spec.tsx +79 -67
  187. package/src/serverGroup/details/advancedSettings/EditAsgAdvancedSettingsModal.spec.tsx +78 -66
  188. package/src/serverGroup/details/advancedSettings/EditAsgAdvancedSettingsModal.tsx +23 -6
  189. package/src/serverGroup/details/rollback/AmazonRollbackServerGroupModal.spec.tsx +86 -94
  190. package/src/serverGroup/details/rollback/AmazonRollbackServerGroupModal.tsx +3 -0
  191. package/src/serverGroup/details/scalingPolicy/targetTracking/TargetTrackingAdditionalSettings.tsx +1 -39
  192. package/src/serverGroup/details/scalingPolicy/targetTracking/UpsertTargetTrackingModal.tsx +0 -1
  193. package/src/serverGroup/details/scalingProcesses/ModifyScalingProcessesModal.spec.tsx +5 -5
  194. package/src/serverGroup/details/scheduledActions/EditScheduledActionsModal.spec.tsx +8 -8
  195. package/src/serverGroup/details/sections/AmazonServerGroupMaintenanceActions.spec.tsx +71 -60
  196. package/src/serverGroup/details/sections/InstancesDistributionDetailsSection.spec.tsx +21 -39
  197. package/src/serverGroup/details/sections/LaunchTemplateDetailsSection.spec.tsx +56 -97
  198. package/src/serverGroup/details/securityGroups/EditSecurityGroupsModal.spec.tsx +48 -77
  199. package/src/serverGroup/details/warmPool/ModifyWarmPoolModal.spec.tsx +5 -5
  200. package/src/vpc/VpcReader.spec.ts +1 -1
  201. package/src/vpc/VpcTag.spec.tsx +11 -15
  202. /package/dist/{amazon.logo352d4e042476837f.svg → amazon.logoBzC5E-3F.svg} +0 -0
@@ -1,122 +1,102 @@
1
- import { mount, shallow } from 'enzyme';
1
+ import { fireEvent, render, screen, waitFor, within } from '@testing-library/react';
2
2
  import React from 'react';
3
3
 
4
- import { BakeryReader, ChecklistInput, MapEditor } from '@spinnaker/core';
4
+ import { BakeryReader } from '@spinnaker/core';
5
+ import { getFormGroupByLabel } from '../../../../../core/src/utils/testUtils/rtl';
5
6
 
6
7
  import { AmazonStageConfig } from '../AmazonStageConfig';
7
8
  import { AwsFindImageFromTagsStageConfig } from './AwsFindImageFromTagsStageConfig';
8
9
  import { awsFindImageFromTagsStage } from './awsFindImageFromTagsStage';
9
10
 
10
11
  describe('AWS Find Image from Tags stage', () => {
11
- function renderEditor(stage: any) {
12
- const updateStageField = jasmine.createSpy('updateStageField');
13
- const wrapper = shallow(
14
- <AwsFindImageFromTagsStageConfig
15
- application={{ defaultRegions: { aws: 'eu-west-1' } } as any}
16
- pipeline={{} as any}
17
- stage={stage}
18
- updateStageField={updateStageField}
19
- />,
20
- );
21
- return { updateStageField, wrapper };
12
+ function renderEditor(initialStage: any) {
13
+ const updateStageField = vi.fn();
14
+ function StageHarness() {
15
+ const [stage, setStage] = React.useState(initialStage);
16
+ const update = (changes: any) => {
17
+ updateStageField(changes);
18
+ setStage((current: any) => ({ ...current, ...changes }));
19
+ };
20
+ return (
21
+ <AwsFindImageFromTagsStageConfig
22
+ application={{ defaultRegions: { aws: 'eu-west-1' } } as any}
23
+ pipeline={{} as any}
24
+ stage={stage}
25
+ updateStageField={update}
26
+ />
27
+ );
28
+ }
29
+ return { updateStageField, ...render(<StageHarness />) };
22
30
  }
23
31
 
24
32
  it('registers a dedicated stage editor', () => {
25
33
  expect(awsFindImageFromTagsStage.component).not.toBe(AmazonStageConfig);
26
34
  });
27
35
 
28
- it('renders explicit persisted values without changing them on mount', () => {
29
- spyOn(BakeryReader, 'getRegions').and.returnValue(Promise.resolve([]) as any);
30
- const tags = { Environment: 'production', EmptyValue: '' };
31
- const updateStageField = jasmine.createSpy('updateStageField');
32
- const wrapper = mount(
33
- <AwsFindImageFromTagsStageConfig
34
- application={{ defaultRegions: { aws: 'eu-west-1' } } as any}
35
- pipeline={{} as any}
36
- stage={{ cloudProvider: '', packageName: 'payments', regions: [], tags }}
37
- updateStageField={updateStageField}
38
- />,
39
- );
36
+ it('renders explicit persisted values without changing them on mount', async () => {
37
+ vi.spyOn(BakeryReader, 'getRegions').mockResolvedValue([] as any);
38
+ const rendered = renderEditor({ cloudProvider: '', packageName: 'payments', regions: [], tags: { Owner: '' } });
40
39
 
41
- expect(wrapper.find('input[name="packageName"]').prop('value')).toBe('payments');
42
- expect(wrapper.find(ChecklistInput).prop('value')).toEqual([]);
43
- expect(wrapper.find(MapEditor).prop('model')).toBe(tags);
44
- expect(wrapper.find(MapEditor).prop('allowEmpty')).toBe(true);
45
- expect(updateStageField).not.toHaveBeenCalled();
46
- wrapper.unmount();
40
+ expect(within(getFormGroupByLabel('Package')).getByRole('textbox')).toHaveValue('payments');
41
+ expect(within(getFormGroupByLabel('Tags')).getByLabelText('Key')).toHaveValue('Owner');
42
+ await waitFor(() => expect(BakeryReader.getRegions).toHaveBeenCalledWith('aws'));
43
+ expect(rendered.updateStageField).not.toHaveBeenCalled();
47
44
  });
48
45
 
49
- it('defaults only undefined stage fields on mount', () => {
50
- spyOn(BakeryReader, 'getRegions').and.returnValue(Promise.resolve([]) as any);
51
- const updateStageField = jasmine.createSpy('updateStageField');
52
-
53
- const wrapper = mount(
54
- <AwsFindImageFromTagsStageConfig
55
- application={{ defaultRegions: { aws: 'eu-west-1' } } as any}
56
- pipeline={{} as any}
57
- stage={{ cloudProvider: undefined, regions: undefined, tags: undefined }}
58
- updateStageField={updateStageField}
59
- />,
60
- );
61
-
62
- expect(updateStageField).toHaveBeenCalledOnceWith({ cloudProvider: 'aws', regions: ['eu-west-1'], tags: {} });
63
- wrapper.unmount();
64
- });
46
+ it('defaults only undefined stage fields on mount', async () => {
47
+ vi.spyOn(BakeryReader, 'getRegions').mockResolvedValue([] as any);
48
+ const rendered = renderEditor({ cloudProvider: undefined, regions: undefined, tags: undefined });
65
49
 
66
- it('loads AWS regions while retaining persisted selections as options', async () => {
67
- spyOn(BakeryReader, 'getRegions').and.returnValue(Promise.resolve(['eu-west-1', 'us-east-1']) as any);
68
- const updateStageField = jasmine.createSpy('updateStageField');
69
- const wrapper = mount(
70
- <AwsFindImageFromTagsStageConfig
71
- application={{} as any}
72
- pipeline={{} as any}
73
- stage={{ cloudProvider: 'aws', packageName: 'payments', regions: ['persisted-region'], tags: {} }}
74
- updateStageField={updateStageField}
75
- />,
50
+ await waitFor(() =>
51
+ expect(rendered.updateStageField).toHaveBeenCalledExactlyOnceWith({
52
+ cloudProvider: 'aws',
53
+ regions: ['eu-west-1'],
54
+ tags: {},
55
+ }),
76
56
  );
77
-
78
- await Promise.resolve();
79
- await Promise.resolve();
80
- wrapper.update();
81
-
82
- expect(BakeryReader.getRegions).toHaveBeenCalledWith('aws');
83
- expect(wrapper.find(ChecklistInput).prop('stringOptions')).toEqual(['persisted-region', 'eu-west-1', 'us-east-1']);
84
- expect(updateStageField).not.toHaveBeenCalled();
85
- wrapper.unmount();
86
57
  });
87
58
 
88
- it('updates the package through the stage config callback', () => {
89
- const { updateStageField, wrapper } = renderEditor({ packageName: 'payments', regions: [], tags: {} });
90
-
91
- wrapper.find('input[name="packageName"]').simulate('change', { target: { value: 'transfers' } });
59
+ it('loads AWS regions while retaining persisted selections as options', async () => {
60
+ vi.spyOn(BakeryReader, 'getRegions').mockResolvedValue(['eu-west-1', 'us-east-1'] as any);
61
+ const rendered = renderEditor({
62
+ cloudProvider: 'aws',
63
+ packageName: 'payments',
64
+ regions: ['persisted-region'],
65
+ tags: {},
66
+ });
92
67
 
93
- expect(updateStageField).toHaveBeenCalledWith({ packageName: 'transfers' });
68
+ expect(await screen.findByRole('checkbox', { name: 'persisted-region' })).toBeChecked();
69
+ expect(await screen.findByRole('checkbox', { name: 'eu-west-1' })).not.toBeChecked();
70
+ expect(await screen.findByRole('checkbox', { name: 'us-east-1' })).not.toBeChecked();
71
+ expect(rendered.updateStageField).not.toHaveBeenCalled();
94
72
  });
95
73
 
96
- it('updates regions through the stage config callback', () => {
97
- const { updateStageField, wrapper } = renderEditor({ packageName: 'payments', regions: [], tags: {} });
74
+ it('updates package, regions, and map-valued tags through the controlled stage contract', async () => {
75
+ vi.spyOn(BakeryReader, 'getRegions').mockResolvedValue(['eu-west-1'] as any);
76
+ const rendered = renderEditor({ packageName: 'payments', regions: [], tags: { Environment: 'production' } });
77
+ rendered.updateStageField.mockClear();
98
78
 
99
- wrapper.find(ChecklistInput).prop('onChange')({ target: { value: ['eu-west-1', 'us-east-1'] } } as any);
79
+ fireEvent.change(within(getFormGroupByLabel('Package')).getByRole('textbox'), { target: { value: 'transfers' } });
80
+ fireEvent.click(await screen.findByRole('checkbox', { name: 'eu-west-1' }));
81
+ fireEvent.change(within(getFormGroupByLabel('Tags')).getByLabelText('Value'), { target: { value: 'staging' } });
82
+ fireEvent.click(within(getFormGroupByLabel('Tags')).getByRole('button', { name: 'Remove field' }));
100
83
 
101
- expect(updateStageField).toHaveBeenCalledWith({ regions: ['eu-west-1', 'us-east-1'] });
84
+ expect(rendered.updateStageField.mock.calls).toEqual([
85
+ [{ packageName: 'transfers' }],
86
+ [{ regions: ['eu-west-1'] }],
87
+ [{ tags: { Environment: 'staging' } }],
88
+ [{ tags: {} }],
89
+ ]);
102
90
  });
103
91
 
104
- it('persists map-valued tag additions, edits, and removals through the stage config callback', () => {
105
- const { updateStageField, wrapper } = renderEditor({
106
- packageName: 'payments',
107
- regions: [],
108
- tags: { Environment: 'production' },
109
- });
110
- const onChange = wrapper.find(MapEditor).prop('onChange');
92
+ it('reports a newly added tag field through the controlled stage contract', () => {
93
+ vi.spyOn(BakeryReader, 'getRegions').mockResolvedValue([] as any);
94
+ const rendered = renderEditor({ packageName: 'payments', regions: [], tags: {} });
95
+ rendered.updateStageField.mockClear();
111
96
 
112
- onChange({ Environment: 'production', Team: '' }, false);
113
- onChange({ Environment: 'staging' }, false);
114
- onChange({}, false);
97
+ fireEvent.click(within(getFormGroupByLabel('Tags')).getByRole('button', { name: 'Add Field' }));
115
98
 
116
- expect(updateStageField.calls.allArgs()).toEqual([
117
- [{ tags: { Environment: 'production', Team: '' } }],
118
- [{ tags: { Environment: 'staging' } }],
119
- [{ tags: {} }],
120
- ]);
99
+ expect(rendered.updateStageField).toHaveBeenCalledWith({ tags: { '': '' } });
100
+ expect(within(getFormGroupByLabel('Tags')).getByLabelText('Key')).toHaveValue('');
121
101
  });
122
102
  });
@@ -1,167 +1,235 @@
1
- import { mount, shallow } from 'enzyme';
1
+ import { fireEvent, render, screen, waitFor, within } from '@testing-library/react';
2
2
  import React from 'react';
3
3
 
4
- import { AccountRegionClusterSelector, AccountService, ChecklistInput, StageConstants } from '@spinnaker/core';
4
+ import { AccountService, StageConstants } from '@spinnaker/core';
5
+ import { getFormGroupByLabel } from '../../../../../core/src/utils/testUtils/rtl';
5
6
 
6
7
  import { AmazonStageConfig } from '../AmazonStageConfig';
7
8
  import { awsModifyScalingProcessStage } from './modifyScalingProcessStage';
8
9
 
9
10
  describe('AWS Modify Scaling Process stage', () => {
10
- function renderEditor(stage: any = {}, pipeline: any = {}) {
11
- const updateStageField = jasmine.createSpy('updateStageField');
12
- const updateStage = jasmine.createSpy('updateStage');
13
- const StageConfig = awsModifyScalingProcessStage.component;
14
- const stageModel = { type: 'modifyAwsScalingProcess', cloudProviderType: 'aws', ...stage };
15
- const wrapper = shallow(
16
- <StageConfig
17
- {...({
18
- application: { defaultCredentials: {}, defaultRegions: {}, getDataSource: () => ({ data: [] }) },
19
- pipeline,
20
- stage: stageModel,
21
- updateStage,
22
- updateStageField,
23
- } as any)}
24
- />,
25
- );
11
+ beforeEach(() => {
12
+ vi.spyOn(AccountService, 'listAccounts').mockResolvedValue([]);
13
+ vi.spyOn(AccountService, 'getUniqueAttributeForAllAccounts').mockResolvedValue([]);
14
+ });
15
+
16
+ function renderEditor(stageOverrides: any = {}, pipeline: any = {}, applicationOverrides: any = {}) {
17
+ const initialStage = { type: 'modifyAwsScalingProcess', cloudProviderType: 'aws', ...stageOverrides };
18
+ const updateStage = vi.fn();
19
+ const updateStageField = vi.fn();
20
+ const StageConfig = awsModifyScalingProcessStage.component as React.ComponentType<any>;
21
+
22
+ function StageHarness() {
23
+ const [stage, setStage] = React.useState(initialStage);
24
+ const update = (changes: any) => {
25
+ updateStage(changes);
26
+ setStage((current: any) => ({ ...current, ...changes }));
27
+ };
28
+ const updateField = (changes: any) => {
29
+ updateStageField(changes);
30
+ setStage((current: any) => ({ ...current, ...changes }));
31
+ };
32
+ return (
33
+ <StageConfig
34
+ application={{
35
+ defaultCredentials: {},
36
+ defaultRegions: {},
37
+ getDataSource: () => ({ data: [] }),
38
+ ...applicationOverrides,
39
+ }}
40
+ pipeline={pipeline}
41
+ stage={stage}
42
+ updateStage={update}
43
+ updateStageField={updateField}
44
+ />
45
+ );
46
+ }
26
47
 
27
- return { stage: stageModel, updateStage, updateStageField, wrapper };
48
+ return { initialStage, updateStage, updateStageField, ...render(<StageHarness />) };
28
49
  }
29
50
 
30
51
  it('registers a dedicated stage editor', () => {
31
52
  expect(awsModifyScalingProcessStage.component).not.toBe(AmazonStageConfig);
32
53
  });
33
54
 
34
- it('renders the AWS server group selectors for a pipeline stage', () => {
35
- const { wrapper } = renderEditor({ target: 'current_asg' });
36
- const target = wrapper.find('select[name="target"]');
37
-
38
- expect(wrapper.find(AccountRegionClusterSelector).exists()).toBe(true);
39
- expect(target.exists()).toBe(true);
40
- if (!wrapper.find(AccountRegionClusterSelector).exists() || !target.exists()) {
41
- return;
42
- }
43
- expect(target.find('option').map((option) => option.prop('value'))).toEqual(
44
- StageConstants.TARGET_LIST.map((option) => option.val),
45
- );
46
- expect(target.prop('value')).toBe('current_asg');
55
+ it('renders AWS target, action, and scaling process controls', () => {
56
+ renderEditor({ target: 'current_asg', action: 'suspend', processes: ['Launch'] }, { strategy: true });
57
+
58
+ const target = within(getFormGroupByLabel('Target')).getByRole('combobox');
59
+ expect(
60
+ within(target)
61
+ .getAllByRole('option')
62
+ .map((option) => (option as HTMLOptionElement).value),
63
+ ).toEqual(StageConstants.TARGET_LIST.map((option) => option.val));
64
+ expect(target).toHaveValue('current_asg');
65
+ expect(within(getFormGroupByLabel('Action')).getByRole('combobox')).toHaveValue('suspend');
66
+ expect(screen.getByRole('checkbox', { name: 'Launch' })).toBeChecked();
67
+ expect(screen.getByRole('checkbox', { name: 'Terminate' })).not.toBeChecked();
47
68
  });
48
69
 
49
- it('reports account, region, and cluster changes from an unmutated stage', () => {
50
- const { stage, updateStage, updateStageField, wrapper } = renderEditor({
51
- credentials: 'test',
52
- regions: ['eu-west-1'],
53
- cluster: 'app-main',
54
- });
55
- const selector = wrapper.find(AccountRegionClusterSelector);
56
- const selectorStage = selector.prop('component');
70
+ it('reports process selections through the controlled stage contract', () => {
71
+ const rendered = renderEditor({ action: 'suspend', processes: ['Launch'] }, { strategy: true });
72
+ rendered.updateStageField.mockClear();
57
73
 
58
- expect(selectorStage).not.toBe(stage);
59
- selectorStage.credentials = 'prod';
60
- selectorStage.regions = ['us-east-1'];
61
- selectorStage.cluster = 'app-prod';
62
- selector.prop('onComponentUpdate')(selectorStage);
74
+ fireEvent.click(screen.getByRole('checkbox', { name: 'Terminate' }));
63
75
 
64
- expect(stage).toEqual(
65
- jasmine.objectContaining({ credentials: 'test', regions: ['eu-west-1'], cluster: 'app-main' }),
76
+ expect(rendered.updateStageField).toHaveBeenCalledWith({ processes: ['Launch', 'Terminate'] });
77
+ expect(screen.getByRole('checkbox', { name: 'Terminate' })).toBeChecked();
78
+ });
79
+
80
+ it('reports normal selector changes through updateStage without mutating the stage prop', async () => {
81
+ vi.spyOn(AccountService, 'listAccounts').mockResolvedValue([{ name: 'test' }, { name: 'prod' }] as any);
82
+ vi.spyOn(AccountService, 'getUniqueAttributeForAllAccounts').mockResolvedValue(['eu-west-1', 'us-east-1'] as any);
83
+ const application = {
84
+ getDataSource: () => ({
85
+ data: [
86
+ { account: 'test', region: 'eu-west-1', cluster: 'app-main', moniker: { app: 'app', cluster: 'app-main' } },
87
+ { account: 'prod', region: 'us-east-1', cluster: 'app-prod', moniker: { app: 'app', cluster: 'app-prod' } },
88
+ ],
89
+ }),
90
+ };
91
+ const accountRendered = renderEditor(
92
+ {
93
+ action: 'suspend',
94
+ cloudProvider: 'aws',
95
+ credentials: 'test',
96
+ processes: [],
97
+ regions: ['eu-west-1'],
98
+ cluster: 'app-main',
99
+ target: 'current_asg_dynamic',
100
+ },
101
+ { strategy: false },
102
+ application,
66
103
  );
67
- expect(updateStage).toHaveBeenCalledWith(
68
- jasmine.objectContaining({ credentials: 'prod', regions: ['us-east-1'], cluster: 'app-prod' }),
104
+ const originalAccountStage = {
105
+ ...accountRendered.initialStage,
106
+ regions: [...accountRendered.initialStage.regions],
107
+ };
108
+ accountRendered.updateStage.mockClear();
109
+
110
+ const account = within(getFormGroupByLabel('Account')).getByRole('combobox');
111
+ await screen.findByRole('option', { name: 'prod' });
112
+ fireEvent.change(account, { target: { value: 'prod' } });
113
+
114
+ expect(accountRendered.initialStage).toEqual(originalAccountStage);
115
+ expect(accountRendered.updateStage).toHaveBeenCalledExactlyOnceWith({
116
+ type: 'modifyAwsScalingProcess',
117
+ cloudProviderType: 'aws',
118
+ cloudProvider: 'aws',
119
+ credentials: 'prod',
120
+ regions: ['eu-west-1'],
121
+ cluster: undefined,
122
+ processes: [],
123
+ action: 'suspend',
124
+ target: 'current_asg_dynamic',
125
+ });
126
+ accountRendered.unmount();
127
+
128
+ const regionRendered = renderEditor(
129
+ {
130
+ action: 'suspend',
131
+ cloudProvider: 'aws',
132
+ credentials: 'test',
133
+ processes: [],
134
+ regions: ['eu-west-1'],
135
+ cluster: 'app-main',
136
+ target: 'current_asg_dynamic',
137
+ },
138
+ { strategy: false },
139
+ application,
69
140
  );
70
- expect(updateStageField).not.toHaveBeenCalled();
71
- });
141
+ const originalRegionStage = { ...regionRendered.initialStage, regions: [...regionRendered.initialStage.regions] };
142
+ regionRendered.updateStage.mockClear();
143
+ fireEvent.click(await screen.findByRole('checkbox', { name: 'eu-west-1' }));
72
144
 
73
- it('uses the AWS scaling process names and preserves process arrays', () => {
74
- const processes = ['Launch', 'AZRebalance'];
75
- const nextProcesses = ['Terminate', 'ScheduledActions'];
76
- const { updateStageField, wrapper } = renderEditor({ processes });
77
- const checklist = wrapper.find(ChecklistInput).filterWhere((input) => input.prop('name') === 'processes');
145
+ expect(regionRendered.initialStage).toEqual(originalRegionStage);
146
+ expect(regionRendered.updateStage).toHaveBeenCalledExactlyOnceWith({
147
+ type: 'modifyAwsScalingProcess',
148
+ cloudProviderType: 'aws',
149
+ cloudProvider: 'aws',
150
+ credentials: 'test',
151
+ regions: [],
152
+ cluster: undefined,
153
+ processes: [],
154
+ action: 'suspend',
155
+ target: 'current_asg_dynamic',
156
+ });
157
+ regionRendered.unmount();
158
+
159
+ const clusterRendered = renderEditor(
160
+ {
161
+ action: 'suspend',
162
+ cloudProvider: 'aws',
163
+ credentials: 'test',
164
+ processes: [],
165
+ regions: ['eu-west-1'],
166
+ cluster: 'app-main',
167
+ target: 'current_asg_dynamic',
168
+ },
169
+ { strategy: false },
170
+ application,
171
+ );
172
+ const originalClusterStage = {
173
+ ...clusterRendered.initialStage,
174
+ regions: [...clusterRendered.initialStage.regions],
175
+ };
176
+ clusterRendered.updateStage.mockClear();
177
+ fireEvent.change(within(getFormGroupByLabel('Cluster')).getByRole('combobox'), { target: { value: '' } });
78
178
 
79
- expect(checklist.exists()).toBe(true);
80
- if (!checklist.exists()) {
81
- return;
82
- }
83
- expect(checklist.prop('stringOptions')).toEqual([
84
- 'Launch',
85
- 'Terminate',
86
- 'AddToLoadBalancer',
87
- 'AlarmNotification',
88
- 'AZRebalance',
89
- 'HealthCheck',
90
- 'ReplaceUnhealthy',
91
- 'ScheduledActions',
92
- ]);
93
- expect(checklist.prop('value')).toBe(processes);
94
-
95
- checklist.prop('onChange')({ target: { value: nextProcesses } } as any);
96
-
97
- expect(updateStageField).toHaveBeenCalledWith({ processes: nextProcesses });
179
+ expect(clusterRendered.initialStage).toEqual(originalClusterStage);
180
+ expect(clusterRendered.updateStage).toHaveBeenCalledExactlyOnceWith({
181
+ type: 'modifyAwsScalingProcess',
182
+ cloudProviderType: 'aws',
183
+ cloudProvider: 'aws',
184
+ credentials: 'test',
185
+ regions: ['eu-west-1'],
186
+ cluster: undefined,
187
+ moniker: undefined,
188
+ processes: [],
189
+ action: 'suspend',
190
+ target: 'current_asg_dynamic',
191
+ });
98
192
  });
99
193
 
100
194
  it('supports suspend and resume while clearing only legacy action fields', () => {
101
195
  const processes = ['Launch', 'HealthCheck'];
102
- const stage = {
103
- action: 'suspend',
104
- processes,
105
- suspendProcesses: ['Terminate'],
106
- resumeProcesses: ['AZRebalance'],
107
- };
108
- const { updateStageField, wrapper } = renderEditor(stage);
109
- const action = wrapper.find('select[name="action"]');
110
-
111
- expect(action.exists()).toBe(true);
112
- if (!action.exists()) {
113
- return;
114
- }
115
- expect(action.find('option').map((option) => [option.prop('value'), option.text()])).toEqual([
116
- ['suspend', 'Suspend'],
117
- ['resume', 'Resume'],
118
- ]);
196
+ const rendered = renderEditor(
197
+ { action: 'suspend', processes, suspendProcesses: ['Terminate'], resumeProcesses: ['AZRebalance'] },
198
+ { strategy: true },
199
+ );
200
+ rendered.updateStageField.mockClear();
119
201
 
120
- action.simulate('change', { target: { value: 'resume' } });
202
+ fireEvent.change(within(getFormGroupByLabel('Action')).getByRole('combobox'), { target: { value: 'resume' } });
121
203
 
122
- const changes = updateStageField.calls.mostRecent().args[0];
204
+ const changes = rendered.updateStageField.mock.lastCall[0];
123
205
  expect(changes).toEqual({ action: 'resume', suspendProcesses: undefined, resumeProcesses: undefined });
124
206
  expect(Object.prototype.hasOwnProperty.call(changes, 'processes')).toBe(false);
125
- expect(stage.processes).toBe(processes);
207
+ expect(rendered.initialStage.processes).toBe(processes);
126
208
  });
127
209
 
128
- it('normalizes legacy process fields when reopening without changing action', () => {
129
- spyOn(AccountService, 'listAccounts').and.returnValue(Promise.resolve([]));
210
+ it('normalizes legacy process fields when reopening without changing action', async () => {
130
211
  const processes = ['Launch', 'ScheduledActions'];
131
- const stage = {
132
- type: 'modifyAwsScalingProcess',
133
- cloudProvider: 'aws',
134
- cloudProviderType: 'aws',
135
- credentials: 'test',
136
- regions: ['eu-west-1'],
137
- cluster: 'app-main',
138
- target: 'current_asg',
139
- action: 'suspend',
140
- processes,
141
- suspendProcesses: ['Terminate'],
142
- resumeProcesses: ['AZRebalance'],
143
- };
144
- const updateStageField = jasmine.createSpy('updateStageField');
145
- const StageConfig = awsModifyScalingProcessStage.component;
146
- const wrapper = mount(
147
- <StageConfig
148
- {...({
149
- application: { defaultCredentials: {}, defaultRegions: {} },
150
- pipeline: { strategy: true },
151
- stage,
152
- updateStage: jasmine.createSpy('updateStage'),
153
- updateStageField,
154
- } as any)}
155
- />,
212
+ const rendered = renderEditor(
213
+ {
214
+ cloudProvider: 'aws',
215
+ credentials: 'test',
216
+ regions: ['eu-west-1'],
217
+ cluster: 'app-main',
218
+ target: 'current_asg',
219
+ action: 'suspend',
220
+ processes,
221
+ suspendProcesses: ['Terminate'],
222
+ resumeProcesses: ['AZRebalance'],
223
+ },
224
+ { strategy: true },
156
225
  );
157
226
 
158
- expect(updateStageField).toHaveBeenCalledWith({
159
- suspendProcesses: undefined,
160
- resumeProcesses: undefined,
161
- });
162
- expect(Object.prototype.hasOwnProperty.call(updateStageField.calls.mostRecent().args[0], 'processes')).toBe(false);
163
- expect(stage.processes).toBe(processes);
164
-
165
- wrapper.unmount();
227
+ await waitFor(() =>
228
+ expect(rendered.updateStageField).toHaveBeenCalledWith({
229
+ suspendProcesses: undefined,
230
+ resumeProcesses: undefined,
231
+ }),
232
+ );
233
+ expect(rendered.initialStage.processes).toBe(processes);
166
234
  });
167
235
  });