@spider-analyzer/timeline 5.0.2 → 5.0.4

package/CHANGELOG.md

@@ -1,3 +1,27 @@
+## 5.0.4
+
+- Fix: memoize the moment-typed props built by the outer TimeLine
+  wrapper. Previously `histo`, `quality`, `timeSpan`, `maxDomain`,
+  duration props, and the xAxis/margin defaults were rebuilt on every
+  wrapper render. The inner component's "did this reference change?"
+  effects (`histo !== prevHisto`, width/margin, etc.) fired on every
+  render, each calling `setState` and forcing another render — an
+  infinite loop that pegged CPU, kept the loader visible forever, and
+  left the x-axis ticks empty. Stabilizing the references with
+  `useMemo` (keyed on the raw consumer references) breaks the loop.
+
+## 5.0.3
+
+- Fix: preserve `undefined` at the Date-→-Moment boundary. Optional
+  fields like `maxDomain.min`, `maxDomain.max`, or a partially-populated
+  `timeSpan` were silently turning into `moment()` (= now) because
+  `moment(undefined)` returns the current time. That turned
+  `maxDomain.min = undefined` (the common "no lower bound" case) into an
+  active minimum of *now*, which made every visible window appear to be
+  before the minimum — triggering `minTime`/`minDomainMsg` on zoom-out,
+  blocking pan, and causing constant cursor flicker from re-emitted
+  corrections.
+
 ## 5.0.2
 
 - Fix: apply the `xAxis` / `yAxis` / `margin` defaults inside the outer

package/dist/index.js

@@ -1956,15 +1956,19 @@ function toMoment(x, zone) {
   const m = zone ? moment_shim_default.tz(x, zone) : moment_shim_default(x);
   return m;
 }
+function toMomentOpt(x, zone) {
+  if (x == null) return void 0;
+  return toMoment(x, zone);
+}
 function toDuration(x) {
   if (moment_shim_default.isDuration(x)) return x;
   return moment_shim_default.duration(x);
 }
 function domainToMoments(d, zone) {
-  return { min: toMoment(d.min, zone), max: toMoment(d.max, zone) };
+  return { min: toMomentOpt(d.min, zone), max: toMomentOpt(d.max, zone) };
 }
 function timeSpanToMoments(t, zone) {
-  return { start: toMoment(t.start, zone), stop: toMoment(t.stop, zone) };
+  return { start: toMomentOpt(t.start, zone), stop: toMomentOpt(t.stop, zone) };
 }
 var Cursor2 = Cursor;
 var Histogram2 = Histogram;
@@ -2758,8 +2762,9 @@ var TimeLine2 = react.forwardRef(function TimeLineWrapper(props, ref) {
   const handleLoadDefault = react.useCallback(() => {
     const ret = props.onLoadDefaultDomain?.();
     const apply = (d) => {
-      if (!d) return;
+      if (!d || !d.min || !d.max) return;
       const m = domainToMoments(d, zone);
+      if (!m.min || !m.max) return;
       setStack([m]);
       if (props.onDomainChange) {
         props.onDomainChange({ min: m.min.toDate(), max: m.max.toDate() });
@@ -2768,19 +2773,55 @@ var TimeLine2 = react.forwardRef(function TimeLineWrapper(props, ref) {
     if (ret && typeof ret.then === "function") ret.then(apply);
     else if (ret) apply(ret);
   }, [props.onLoadDefaultDomain, props.onDomainChange, zone]);
+  const timeSpanMoments = react.useMemo(
+    () => props.timeSpan ? timeSpanToMoments(props.timeSpan, zone) : void 0,
+    [props.timeSpan, zone]
+  );
+  const maxDomainMoments = react.useMemo(
+    () => props.maxDomain ? domainToMoments(props.maxDomain, zone) : void 0,
+    [props.maxDomain, zone]
+  );
+  const histoMoments = react.useMemo(
+    () => props.histo?.items ? { ...props.histo, items: props.histo.items.map((it) => ({ ...it, time: toMoment(it.time, zone) })) } : props.histo,
+    [props.histo, zone]
+  );
+  const qualityMoments = react.useMemo(
+    () => props.quality?.items ? { ...props.quality, items: props.quality.items.map((it) => ({ ...it, time: toMoment(it.time, zone) })) } : props.quality,
+    [props.quality, zone]
+  );
+  const biggestVisibleDomainDur = react.useMemo(
+    () => props.biggestVisibleDomain != null ? toDuration(props.biggestVisibleDomain) : void 0,
+    [props.biggestVisibleDomain]
+  );
+  const biggestTimeSpanDur = react.useMemo(
+    () => props.biggestTimeSpan != null ? toDuration(props.biggestTimeSpan) : void 0,
+    [props.biggestTimeSpan]
+  );
+  const smallestResolutionDur = react.useMemo(
+    () => props.smallestResolution != null ? toDuration(props.smallestResolution) : void 0,
+    [props.smallestResolution]
+  );
+  const xAxisMerged = react.useMemo(
+    () => ({ ...xAxisDefault, ...props.xAxis ?? {} }),
+    [props.xAxis]
+  );
+  const marginMerged = react.useMemo(
+    () => ({ ...marginDefault, ...props.margin ?? {} }),
+    [props.margin]
+  );
   const innerProps = {
     ...props,
-    xAxis: { ...xAxisDefault, ...props.xAxis ?? {} },
+    xAxis: xAxisMerged,
     yAxis: props.yAxis ?? {},
-    margin: { ...marginDefault, ...props.margin ?? {} },
+    margin: marginMerged,
     domains: stack,
-    timeSpan: props.timeSpan ? timeSpanToMoments(props.timeSpan, zone) : void 0,
-    maxDomain: props.maxDomain ? domainToMoments(props.maxDomain, zone) : void 0,
-    histo: props.histo?.items ? { ...props.histo, items: props.histo.items.map((it) => ({ ...it, time: toMoment(it.time, zone) })) } : props.histo,
-    quality: props.quality?.items ? { ...props.quality, items: props.quality.items.map((it) => ({ ...it, time: toMoment(it.time, zone) })) } : props.quality,
-    biggestVisibleDomain: props.biggestVisibleDomain != null ? toDuration(props.biggestVisibleDomain) : void 0,
-    biggestTimeSpan: props.biggestTimeSpan != null ? toDuration(props.biggestTimeSpan) : void 0,
-    smallestResolution: props.smallestResolution != null ? toDuration(props.smallestResolution) : void 0,
+    timeSpan: timeSpanMoments,
+    maxDomain: maxDomainMoments,
+    histo: histoMoments,
+    quality: qualityMoments,
+    biggestVisibleDomain: biggestVisibleDomainDur,
+    biggestTimeSpan: biggestTimeSpanDur,
+    smallestResolution: smallestResolutionDur,
     onUpdateDomains: handleUpdateDomains,
     onLoadDefaultDomain: handleLoadDefault,
     // onLoadHisto: object shape + Date instants