@spider-analyzer/timeline 5.0.1 → 5.0.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@spider-analyzer/timeline",
-  "version": "5.0.1",
+  "version": "5.0.3",
   "description": "React graphical component to display metric over time with a time selection feature.",
   "author": "Thibaut Raballand <spider.analyzer@gmail.com> (https://spider-analyzer.io)",
   "license": "MIT",

package/src/TimeLine.tsx

@@ -875,8 +875,9 @@ const TimeLine = forwardRef<TimeLineHandle, any>(function TimeLineWrapper(props,
     const handleLoadDefault = useCallback(() => {
         const ret = props.onLoadDefaultDomain?.();
         const apply = (d: any) => {
-            if (!d) return;
+            if (!d || !d.min || !d.max) return;
             const m = domainToMoments(d, zone);
+            if (!m.min || !m.max) return;
             setStack([m]);
             if (props.onDomainChange) {
                 props.onDomainChange({ min: m.min.toDate(), max: m.max.toDate() });
@@ -886,9 +887,15 @@ const TimeLine = forwardRef<TimeLineHandle, any>(function TimeLineWrapper(props,
         else if (ret) apply(ret);
     }, [props.onLoadDefaultDomain, props.onDomainChange, zone]);
 
-    // Build the moment-typed props the inner expects.
+    // Build the moment-typed props the inner expects. Apply the same
+    // defaults the inner destructures locally so that ref-path accesses
+    // (propsRef.current.xAxis.spaceBetweenTicks etc.) never trip on an
+    // undefined consumer prop.
     const innerProps: any = {
         ...props,
+        xAxis: { ...xAxisDefault, ...(props.xAxis ?? {}) },
+        yAxis: props.yAxis ?? {},
+        margin: { ...marginDefault, ...(props.margin ?? {}) },
         domains: stack,
         timeSpan: props.timeSpan ? timeSpanToMoments(props.timeSpan, zone) : undefined,
         maxDomain: props.maxDomain ? domainToMoments(props.maxDomain, zone) : undefined,

package/src/time.ts

@@ -23,6 +23,14 @@ export function toMoment(x: Instant, zone?: string): Moment {
     return m;
 }
 
+// Null-preserving variant: undefined/null stay undefined instead of
+// becoming `moment()` (= now). Optional domain bounds like maxDomain.min
+// rely on this to remain "unset".
+function toMomentOpt(x: Instant | null | undefined, zone?: string): Moment | undefined {
+    if (x == null) return undefined;
+    return toMoment(x, zone);
+}
+
 export function toDuration(x: Millis): Duration {
     if (moment.isDuration(x)) return x as Duration;
     return moment.duration(x as number);
@@ -35,12 +43,12 @@ export function fromMoment(m: Moment | null | undefined): Date | null {
 export interface DateDomain { min: Date; max: Date; }
 export interface DateTimeSpan { start: Date; stop: Date; }
 
-export function domainToMoments(d: { min: Instant; max: Instant }, zone?: string) {
-    return { min: toMoment(d.min, zone), max: toMoment(d.max, zone) };
+export function domainToMoments(d: { min?: Instant | null; max?: Instant | null }, zone?: string) {
+    return { min: toMomentOpt(d.min, zone), max: toMomentOpt(d.max, zone) };
 }
 
-export function timeSpanToMoments(t: { start: Instant; stop: Instant }, zone?: string) {
-    return { start: toMoment(t.start, zone), stop: toMoment(t.stop, zone) };
+export function timeSpanToMoments(t: { start?: Instant | null; stop?: Instant | null }, zone?: string) {
+    return { start: toMomentOpt(t.start, zone), stop: toMomentOpt(t.stop, zone) };
 }
 
 export function domainToDates(d: { min: Moment; max: Moment }): DateDomain {