@sphereon/ssi-sdk.oid4vci-holder 0.34.1-fix.117 → 0.34.1-fix.143

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sphereon/ssi-sdk.oid4vci-holder",
-  "version": "0.34.1-fix.117+6f692cf3",
+  "version": "0.34.1-fix.143+663555b2",
   "source": "src/index.ts",
   "type": "module",
   "main": "./dist/index.cjs",
@@ -30,23 +30,23 @@
     "@sphereon/kmp-mdoc-core": "0.2.0-SNAPSHOT.26",
     "@sphereon/oid4vci-client": "0.19.1-feature.DIIPv4.106",
     "@sphereon/oid4vci-common": "0.19.1-feature.DIIPv4.106",
-    "@sphereon/ssi-sdk-ext.did-utils": "0.34.1-fix.117+6f692cf3",
-    "@sphereon/ssi-sdk-ext.identifier-resolution": "0.34.1-fix.117+6f692cf3",
-    "@sphereon/ssi-sdk-ext.jwt-service": "0.34.1-fix.117+6f692cf3",
-    "@sphereon/ssi-sdk-ext.key-utils": "0.34.1-fix.117+6f692cf3",
-    "@sphereon/ssi-sdk.contact-manager": "0.34.1-fix.117+6f692cf3",
-    "@sphereon/ssi-sdk.core": "0.34.1-fix.117+6f692cf3",
-    "@sphereon/ssi-sdk.credential-store": "0.34.1-fix.117+6f692cf3",
-    "@sphereon/ssi-sdk.credential-validation": "0.34.1-fix.117+6f692cf3",
-    "@sphereon/ssi-sdk.data-store": "0.34.1-fix.117+6f692cf3",
-    "@sphereon/ssi-sdk.issuance-branding": "0.34.1-fix.117+6f692cf3",
-    "@sphereon/ssi-sdk.mdl-mdoc": "0.34.1-fix.117+6f692cf3",
-    "@sphereon/ssi-sdk.oidf-client": "0.34.1-fix.117+6f692cf3",
-    "@sphereon/ssi-sdk.sd-jwt": "0.34.1-fix.117+6f692cf3",
-    "@sphereon/ssi-sdk.siopv2-oid4vp-common": "0.34.1-fix.117+6f692cf3",
-    "@sphereon/ssi-sdk.siopv2-oid4vp-op-auth": "0.34.1-fix.117+6f692cf3",
-    "@sphereon/ssi-sdk.xstate-machine-persistence": "0.34.1-fix.117+6f692cf3",
-    "@sphereon/ssi-types": "0.34.1-fix.117+6f692cf3",
+    "@sphereon/ssi-sdk-ext.did-utils": "0.34.1-fix.143+663555b2",
+    "@sphereon/ssi-sdk-ext.identifier-resolution": "0.34.1-fix.143+663555b2",
+    "@sphereon/ssi-sdk-ext.jwt-service": "0.34.1-fix.143+663555b2",
+    "@sphereon/ssi-sdk-ext.key-utils": "0.34.1-fix.143+663555b2",
+    "@sphereon/ssi-sdk.contact-manager": "0.34.1-fix.143+663555b2",
+    "@sphereon/ssi-sdk.core": "0.34.1-fix.143+663555b2",
+    "@sphereon/ssi-sdk.credential-store": "0.34.1-fix.143+663555b2",
+    "@sphereon/ssi-sdk.credential-validation": "0.34.1-fix.143+663555b2",
+    "@sphereon/ssi-sdk.data-store": "0.34.1-fix.143+663555b2",
+    "@sphereon/ssi-sdk.issuance-branding": "0.34.1-fix.143+663555b2",
+    "@sphereon/ssi-sdk.mdl-mdoc": "0.34.1-fix.143+663555b2",
+    "@sphereon/ssi-sdk.oidf-client": "0.34.1-fix.143+663555b2",
+    "@sphereon/ssi-sdk.sd-jwt": "0.34.1-fix.143+663555b2",
+    "@sphereon/ssi-sdk.siopv2-oid4vp-common": "0.34.1-fix.143+663555b2",
+    "@sphereon/ssi-sdk.siopv2-oid4vp-op-auth": "0.34.1-fix.143+663555b2",
+    "@sphereon/ssi-sdk.xstate-machine-persistence": "0.34.1-fix.143+663555b2",
+    "@sphereon/ssi-types": "0.34.1-fix.143+663555b2",
     "@veramo/core": "4.2.0",
     "@veramo/data-store": "4.2.0",
     "@veramo/utils": "4.2.0",
@@ -60,7 +60,7 @@
   },
   "devDependencies": {
     "@sphereon/oid4vc-common": "0.19.1-feature.DIIPv4.106",
-    "@sphereon/ssi-sdk-ext.did-resolver-jwk": "0.34.1-fix.117+6f692cf3",
+    "@sphereon/ssi-sdk-ext.did-resolver-jwk": "0.34.1-fix.143+663555b2",
     "@sphereon/ssi-sdk.siopv2-oid4vp-common": "workspace:*",
     "@types/i18n-js": "^3.8.9",
     "@types/lodash.memoize": "^4.1.9",
@@ -90,5 +90,5 @@
     "OID4VCI",
     "State Machine"
   ],
-  "gitHead": "6f692cf3d1fdd6a52c757b80010d830c3daf6799"
+  "gitHead": "663555b236defd6dd41c316274baee44683c6935"
 }

package/src/agent/OID4VCIHolder.ts

@@ -36,7 +36,6 @@ import {
   ConnectionType,
   CorrelationIdentifierType,
   CredentialCorrelationType,
-  CredentialRole,
   ensureRawDocument,
   FindPartyArgs,
   IBasicCredentialLocaleBranding,
@@ -59,6 +58,7 @@ import {
   parseDid,
   SdJwtDecodedVerifiableCredentialPayload,
   WrappedW3CVerifiableCredential,
+  CredentialRole,
 } from '@sphereon/ssi-types'
 import {
   CredentialPayload,
@@ -230,7 +230,7 @@ export class OID4VCIHolder implements IAgentPlugin {
     oid4vciHolderStoreIssuerBranding: this.oid4vciHolderStoreIssuerBranding.bind(this),
   }
 
-  private readonly vcFormatPreferences: Array<string> = ['dc+sd-jwt', 'vc+sd-jwt', 'mso_mdoc', 'jwt_vc_json', 'jwt_vc', 'ldp_vc']
+  private readonly vcFormatPreferences: Array<string> = ['dc+sd-jwt', 'vc+sd-jwt', 'mso_mdoc', 'jwt_vc_json', 'jwt_vc', 'ldp_vc'] // TODO see SSISDK-52 concerning vc+sd-jwt
   private readonly jsonldCryptographicSuitePreferences: Array<string> = [
     'Ed25519Signature2018',
     'EcdsaSecp256k1Signature2019',

package/src/services/OID4VCIHolderService.ts

@@ -384,6 +384,9 @@ export const getCredentialConfigsSupportedBySingleTypeOrId = async (
   }
 
   if (configurationId) {
+    if (!format) {
+      return Promise.reject(Error('format parameter missing from input'))
+    }
     const allSupported = client.getCredentialsSupported(format)
     return Object.fromEntries(
       Object.entries(allSupported).filter(
@@ -580,7 +583,7 @@ export const getIssuanceCryptoSuite = async (opts: GetIssuanceCryptoSuiteArgs):
     case 'jwt':
     case 'jwt_vc_json':
     case 'jwt_vc':
-    //case 'vc+sd-jwt':  FIXME re-enable for vcdm2
+    //case 'vc+sd-jwt': // TODO see SSISDK-52 concerning vc+sd-jwt
     case 'dc+sd-jwt':
     case 'mso_mdoc': {
       const supportedPreferences: Array<JoseSignatureAlgorithm | JoseSignatureAlgorithmString> = jwtCryptographicSuitePreferences.filter(