@sphereon/ssi-sdk.kms-rest-client 0.34.1-feature.IDK.11.53 → 0.34.1-next.299

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@sphereon/ssi-sdk.kms-rest-client",
   "description": "contains the client side to call REST endpoints of a KMS server",
-  "version": "0.34.1-feature.IDK.11.53+3230e8fb",
+  "version": "0.34.1-next.299+9e9f5a50",
   "source": "src/index.ts",
   "type": "module",
   "main": "./dist/index.cjs",
@@ -28,7 +28,7 @@
     "generate-plugin-schema": "tsx ../../packages/dev/bin/sphereon.js dev generate-plugin-schema"
   },
   "dependencies": {
-    "@sphereon/ssi-types": "0.34.1-feature.IDK.11.53+3230e8fb",
+    "@sphereon/ssi-types": "0.34.1-next.299+9e9f5a50",
     "cross-fetch": "^3.1.8"
   },
   "devDependencies": {
@@ -56,5 +56,5 @@
     "KMS",
     "REST"
   ],
-  "gitHead": "3230e8fbac34ec3e88c8907fbf55cdc95c696ed3"
+  "gitHead": "9e9f5a50ead9373a078cb5291cbc4fb1e7865dc2"
 }

package/src/agent/KmsRestClient.ts

@@ -115,11 +115,11 @@ export class KmsRestClient implements IAgentPlugin {
     })
     logger.debug(`get resolver response: ${response}`)
 
-    try {
-      return ResolverFromJSONTyped(await response.json(), false)
-    } catch (error) {
-      return Promise.reject(Error(`request to ${url} returned ${error}`))
+    if (!response.ok) {
+      return this.handleHttpError(url, response)
     }
+
+    return ResolverFromJSONTyped(await response.json(), false)
   }
 
   /** {@inheritDoc IKmsRestClient.kmsListResolvers} */
@@ -132,11 +132,11 @@ export class KmsRestClient implements IAgentPlugin {
     })
     logger.debug(`list resolvers response: ${response}`)
 
-    try {
-      return ListResolversResponseFromJSONTyped(await response.json(), false)
-    } catch (error) {
-      return Promise.reject(Error(`request to ${url} returned ${error}`))
+    if (!response.ok) {
+      return this.handleHttpError(url, response)
     }
+
+    return ListResolversResponseFromJSONTyped(await response.json(), false)
   }
 
   /** {@inheritDoc IKmsRestClient.kmsResolveKey} */
@@ -157,11 +157,11 @@ export class KmsRestClient implements IAgentPlugin {
     })
     logger.debug(`resolve key response: ${response}`)
 
-    try {
-      return ResolvedKeyInfoFromJSONTyped(await response.json(), false)
-    } catch (error) {
-      return Promise.reject(Error(`request to ${url} returned ${error}`))
+    if (!response.ok) {
+      return this.handleHttpError(url, response)
     }
+
+    return ResolvedKeyInfoFromJSONTyped(await response.json(), false)
   }
 
   /** {@inheritDoc IKmsRestClient.kmsCreateRawSignature} */
@@ -180,11 +180,11 @@ export class KmsRestClient implements IAgentPlugin {
     })
     logger.debug(`create raw signature response: ${response}`)
 
-    try {
-      return CreateRawSignatureResponseFromJSONTyped(await response.json(), false)
-    } catch (error) {
-      return Promise.reject(Error(`request to ${url} returned ${error}`))
+    if (!response.ok) {
+      return this.handleHttpError(url, response)
     }
+
+    return CreateRawSignatureResponseFromJSONTyped(await response.json(), false)
   }
 
   /** {@inheritDoc IKmsRestClient.kmsIsValidRawSignature} */
@@ -204,11 +204,11 @@ export class KmsRestClient implements IAgentPlugin {
     })
     logger.debug(`verify raw signature response: ${response}`)
 
-    try {
-      return VerifyRawSignatureResponseFromJSONTyped(await response.json(), false)
-    } catch (error) {
-      return Promise.reject(Error(`request to ${url} returned ${error}`))
+    if (!response.ok) {
+      return this.handleHttpError(url, response)
     }
+
+    return VerifyRawSignatureResponseFromJSONTyped(await response.json(), false)
   }
 
   /** {@inheritDoc IKmsRestClient.kmsGetKey} */
@@ -221,11 +221,11 @@ export class KmsRestClient implements IAgentPlugin {
     })
     logger.debug(`get key response: ${response}`)
 
-    try {
-      return GetKeyResponseFromJSONTyped(await response.json(), false)
-    } catch (error) {
-      return Promise.reject(Error(`request to ${url} returned ${error}`))
+    if (!response.ok) {
+      return this.handleHttpError(url, response)
     }
+
+    return GetKeyResponseFromJSONTyped(await response.json(), false)
   }
 
   /** {@inheritDoc IKmsRestClient.kmsListKeys} */
@@ -237,11 +237,11 @@ export class KmsRestClient implements IAgentPlugin {
     })
     logger.debug(`list keys response: ${response}`)
 
-    try {
-      return ListKeysResponseFromJSONTyped(await response.json(), false)
-    } catch (error) {
-      return Promise.reject(Error(`request to ${url} returned ${error}`))
+    if (!response.ok) {
+      return this.handleHttpError(url.toString(), response)
     }
+
+    return ListKeysResponseFromJSONTyped(await response.json(), false)
   }
 
   /** {@inheritDoc IKmsRestClient.kmsStoreKey} */
@@ -260,11 +260,11 @@ export class KmsRestClient implements IAgentPlugin {
     })
     logger.debug(`store key response: ${response}`)
 
-    try {
-      return StoreKeyResponseFromJSONTyped(await response.json(), false)
-    } catch (error) {
-      return Promise.reject(Error(`request to ${url} returned ${error}`))
+    if (!response.ok) {
+      return this.handleHttpError(url, response)
     }
+
+    return StoreKeyResponseFromJSONTyped(await response.json(), false)
   }
 
   /** {@inheritDoc IKmsRestClient.kmsGenerateKey} */
@@ -285,11 +285,11 @@ export class KmsRestClient implements IAgentPlugin {
     })
     logger.debug(`generate key response: ${response}`)
 
-    try {
-      return GenerateKeyResponseFromJSONTyped(await response.json(), false)
-    } catch (error) {
-      return Promise.reject(Error(`request to ${url} returned ${error}`))
+    if (!response.ok) {
+      return this.handleHttpError(url, response)
     }
+
+    return GenerateKeyResponseFromJSONTyped(await response.json(), false)
   }
 
   /** {@inheritDoc IKmsRestClient.kmsDeleteKey} */
@@ -297,9 +297,14 @@ export class KmsRestClient implements IAgentPlugin {
     const baseUrl = this.assertedAgentBaseUrl(args.baseUrl)
     const url = KmsRestClient.urlWithBase(`/keys/${args.aliasOrKid}`, baseUrl)
 
-    await fetch(url, {
+    const response = await fetch(url, {
       method: 'DELETE',
     })
+    logger.debug(`delete key response: ${response}`)
+
+    if (!response.ok) {
+      return this.handleHttpError(url, response)
+    }
 
     return true
   }
@@ -314,11 +319,11 @@ export class KmsRestClient implements IAgentPlugin {
     })
     logger.debug(`get provider response: ${response}`)
 
-    try {
-      return KeyProviderResponseFromJSONTyped(await response.json(), false)
-    } catch (error) {
-      return Promise.reject(Error(`request to ${url} returned ${error}`))
+    if (!response.ok) {
+      return this.handleHttpError(url, response)
     }
+
+    return KeyProviderResponseFromJSONTyped(await response.json(), false)
   }
 
   /** {@inheritDoc IKmsRestClient.kmsListKeyProviders} */
@@ -331,11 +336,11 @@ export class KmsRestClient implements IAgentPlugin {
     })
     logger.debug(`list providers response: ${response}`)
 
-    try {
-      return ListKeyProvidersResponseFromJSONTyped(await response.json(), false)
-    } catch (error) {
-      return Promise.reject(Error(`request to ${url} returned ${error}`))
+    if (!response.ok) {
+      return this.handleHttpError(url, response)
     }
+
+    return ListKeyProvidersResponseFromJSONTyped(await response.json(), false)
   }
 
   /** {@inheritDoc IKmsRestClient.kmsProviderListKeys} */
@@ -348,11 +353,11 @@ export class KmsRestClient implements IAgentPlugin {
     })
     logger.debug(`list provider keys response: ${response}`)
 
-    try {
-      return ListKeysResponseFromJSONTyped(await response.json(), false)
-    } catch (error) {
-      return Promise.reject(Error(`request to ${url} returned ${error}`))
+    if (!response.ok) {
+      return this.handleHttpError(url, response)
     }
+
+    return ListKeysResponseFromJSONTyped(await response.json(), false)
   }
 
   /** {@inheritDoc IKmsRestClient.kmsProviderStoreKey} */
@@ -371,11 +376,11 @@ export class KmsRestClient implements IAgentPlugin {
     })
     logger.debug(`provider store key response: ${response}`)
 
-    try {
-      return StoreKeyResponseFromJSONTyped(await response.json(), false)
-    } catch (error) {
-      return Promise.reject(Error(`request to ${url} returned ${error}`))
+    if (!response.ok) {
+      return this.handleHttpError(url, response)
     }
+
+    return StoreKeyResponseFromJSONTyped(await response.json(), false)
   }
 
   /** {@inheritDoc IKmsRestClient.kmsProviderGenerateKey} */
@@ -395,11 +400,11 @@ export class KmsRestClient implements IAgentPlugin {
     })
     logger.debug(`provider generate key response: ${response}`)
 
-    try {
-      return GenerateKeyResponseFromJSONTyped(await response.json(), false)
-    } catch (error) {
-      return Promise.reject(Error(`request to ${url} returned ${error}`))
+    if (!response.ok) {
+      return this.handleHttpError(url, response)
     }
+
+    return GenerateKeyResponseFromJSONTyped(await response.json(), false)
   }
 
   /** {@inheritDoc IKmsRestClient.kmsProviderGetKey} */
@@ -412,11 +417,11 @@ export class KmsRestClient implements IAgentPlugin {
     })
     logger.debug(`get provider key response: ${response}`)
 
-    try {
-      return GetKeyResponseFromJSONTyped(await response.json(), false)
-    } catch (error) {
-      return Promise.reject(Error(`request to ${url} returned ${error}`))
+    if (!response.ok) {
+      return this.handleHttpError(url, response)
     }
+
+    return GetKeyResponseFromJSONTyped(await response.json(), false)
   }
 
   /** {@inheritDoc IKmsRestClient.kmsProviderDeleteKey} */
@@ -424,9 +429,14 @@ export class KmsRestClient implements IAgentPlugin {
     const baseUrl = this.assertedAgentBaseUrl(args.baseUrl)
     const url = KmsRestClient.urlWithBase(`providers/${args.providerId}/keys/${args.aliasOrKid}`, baseUrl)
 
-    await fetch(url, {
+    const response = await fetch(url, {
       method: 'DELETE',
     })
+    logger.debug(`delete key response: ${response}`)
+
+    if (!response.ok) {
+      return this.handleHttpError(url, response)
+    }
 
     return true
   }
@@ -465,4 +475,14 @@ export class KmsRestClient implements IAgentPlugin {
 
     return url
   }
+
+  private async handleHttpError(url: string, response: Response): Promise<never> {
+    const contentType = response.headers.get("content-type")
+    const isJson = contentType?.includes("application/json")
+    const responseBody = isJson
+      ? JSON.stringify(await response.json())
+      : await response.text()
+
+    return Promise.reject(Error(`request to ${url} returned http error ${response.status} - ${responseBody}`))
+  }
 }