@speedkit/cli 3.4.1 → 3.4.2

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [3.4.2](https://gitlab.orestes.info/baqend/speed-kit-cli/compare/v3.4.1...v3.4.2) (2025-08-19)
+
+
+### Bug Fixes
+
+* **onboarding:** set universal fix for whiteSpacePaths for chromeExecutable ([fa3c743](https://gitlab.orestes.info/baqend/speed-kit-cli/commit/fa3c7433161b4d1f0a184e31afe1d74b17f535b5))
+
 ## [3.4.1](https://gitlab.orestes.info/baqend/speed-kit-cli/compare/v3.4.0...v3.4.1) (2025-08-19)
 
 

package/README.md

@@ -21,7 +21,7 @@ $ npm install -g @speedkit/cli
 $ sk COMMAND
 running command...
 $ sk (--version)
-@speedkit/cli/3.4.1 linux-x64 node-v20.19.4
+@speedkit/cli/3.4.2 linux-x64 node-v20.19.4
 $ sk --help [COMMAND]
 USAGE
   $ sk COMMAND

package/dist/services/cli/cli-service-model.d.ts

@@ -35,4 +35,5 @@ export interface CliServiceInterface {
     writeError(message: string, buffered?: boolean): void;
     writeSuccess(message: string, buffered?: boolean): void;
     writeWarning(message: string, buffered?: boolean): void;
+    execSync(command: string, arguments_: string[]): string;
 }

package/dist/services/cli/cli-service.d.ts

@@ -30,5 +30,6 @@ export declare class CliService implements CliServiceInterface {
     writeError(message: string, buffered?: boolean): void;
     writeSuccess(message: string, buffered?: boolean): void;
     writeWarning(message: string, buffered?: boolean): void;
+    execSync(command: string, arguments_?: string[]): string;
     private getFormattedMessage;
 }

package/dist/services/cli/cli-service.js

@@ -6,6 +6,9 @@ const prompts_1 = require("@inquirer/prompts");
 const chalk_1 = tslib_1.__importDefault(require("chalk")); // interactive prompts
 const core_1 = require("@oclif/core");
 const cli_service_model_1 = require("./cli-service-model");
+const safe_1 = require("../../helpers/safe");
+const node_child_process_1 = require("node:child_process");
+const application_error_1 = tslib_1.__importDefault(require("../error-handling/error/application-error"));
 class CliService {
     quiet;
     style = chalk_1.default;
@@ -158,6 +161,18 @@ class CliService {
         }
         this.write(this.style.yellow(message));
     }
+    execSync(command, arguments_) {
+        const result = (0, safe_1.safe)(() => {
+            return (0, node_child_process_1.execSync)(`"${command}" ${arguments_.join(" ")}`).toString();
+        });
+        if (result.success !== true) {
+            throw new application_error_1.default(result.error, [
+                `running ${command}`,
+                `with arguments ${arguments_.join(" ")}`,
+            ]);
+        }
+        return result.data;
+    }
     getFormattedMessage(questionText) {
         return `${this.style.bold(questionText)}`;
     }

package/dist/services/onboarding/browser/executable/executable-validator.d.ts

@@ -4,9 +4,9 @@ export declare class ExecutableValidator {
     readonly userConfig: UserCliConfig;
     private cli;
     constructor(userConfig: UserCliConfig, cli: CliServiceInterface);
-    validateOrInstall(): Promise<void>;
+    validateOrInstall(): Promise<string>;
+    private getCurrentBrowserVersion;
     private getExecutablePathFromPuppeteer;
     private isValidBrowserExecutable;
-    private cleanPath;
     installBrowser(): Promise<void>;
 }

package/dist/services/onboarding/browser/executable/executable-validator.js

@@ -19,9 +19,8 @@ class ExecutableValidator {
     async validateOrInstall() {
         // check if a valid browserExecutablePath is configured
         const userChromePath = this.userConfig?.chromePath;
-        if (userChromePath.length > 0 &&
-            this.isValidBrowserExecutable(userChromePath)) {
-            return;
+        if (this.isValidBrowserExecutable()) {
+            return this.getCurrentBrowserVersion();
         }
         // write error if configured path is not executable
         if (userChromePath.length > 0) {
@@ -33,7 +32,7 @@ class ExecutableValidator {
         if (installedBrowsers.length > 0) {
             // found an installed browser, set path to this
             this.userConfig.chromePath = installedBrowsers[0].executablePath;
-            return;
+            return this.getCurrentBrowserVersion();
         }
         // write warning that no browser is configured
         if (userChromePath.length === 0) {
@@ -53,17 +52,19 @@ class ExecutableValidator {
         await this.installBrowser();
         // set path to freshly installed chrome
         this.userConfig.chromePath = this.getExecutablePathFromPuppeteer();
+        return this.getCurrentBrowserVersion();
+    }
+    getCurrentBrowserVersion() {
+        return this.cli.execSync(`"${this.userConfig.chromePath}"`, ["--version"]);
     }
     getExecutablePathFromPuppeteer() {
         const puppeteerCache = new browsers_2.Cache(this.userConfig.tempFolder);
         const installedBrowsers = puppeteerCache.getInstalledBrowsers();
         return installedBrowsers[0].executablePath;
     }
-    isValidBrowserExecutable(chromePath) {
-        return (0, node_fs_1.existsSync)(this.cleanPath((0, node_path_1.resolve)(chromePath)));
-    }
-    cleanPath(path) {
-        return path.trim().replaceAll(" ", "\\ ");
+    isValidBrowserExecutable() {
+        return (this.userConfig?.chromePath.length > 0 &&
+            (0, node_fs_1.existsSync)((0, node_path_1.resolve)(this.userConfig?.chromePath.trim())));
     }
     async installBrowser() {
         const puppeteerCli = new browsers_1.CLI({

package/dist/services/onboarding/onboarding-model.d.ts

@@ -32,15 +32,13 @@ export declare const CDP_SESSION: {
 };
 export declare class BrowserContext {
     readonly domain: string;
+    readonly browserVersionString: string;
     readonly chromeFlags?: string[];
     readonly userConfig?: UserCliConfig;
     userAgent?: string;
     readonly browserArgs: string[];
     readonly chromePath: string;
-    readonly browserDetails: string;
-    constructor(domain: string, chromeFlags?: string[], userConfig?: UserCliConfig, userAgent?: string);
-    private cleanPath;
-    private checkBrowserDetails;
+    constructor(domain: string, browserVersionString: string, chromeFlags?: string[], userConfig?: UserCliConfig, userAgent?: string);
     private isChromeBrowser;
     private getBrowserExtensionPath;
     getPuppeteerLaunchOptions(): Parameters<VanillaPuppeteer["launch"]>[0];

package/dist/services/onboarding/onboarding-model.js

@@ -1,14 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.SpeedKitInstallRegex = exports.USER_AGENT = exports.OnboardingContext = exports.BrowserContext = exports.CDP_SESSION = exports.BROWSER_EVENTS = void 0;
-const tslib_1 = require("tslib");
 const core_1 = require("@oclif/core");
 const cli_parameters_1 = require("../../models/cli-parameters");
 const browser_config_1 = require("./browser/config/browser-config");
-const node_child_process_1 = require("node:child_process");
-const safe_1 = require("../../helpers/safe");
-const application_error_1 = tslib_1.__importDefault(require("../error-handling/error/application-error"));
-const node_fs_1 = require("node:fs");
 const node_path_1 = require("node:path");
 const DEFAULT_BROWSER_ARGS = [
     "--enable-features=Translate,NetworkService",
@@ -45,14 +40,15 @@ exports.CDP_SESSION = {
 };
 class BrowserContext {
     domain;
+    browserVersionString;
     chromeFlags;
     userConfig;
     userAgent;
     browserArgs;
     chromePath;
-    browserDetails;
-    constructor(domain, chromeFlags, userConfig, userAgent) {
+    constructor(domain, browserVersionString, chromeFlags, userConfig, userAgent) {
         this.domain = domain;
+        this.browserVersionString = browserVersionString;
         this.chromeFlags = chromeFlags;
         this.userConfig = userConfig;
         this.userAgent = userAgent;
@@ -60,7 +56,6 @@ class BrowserContext {
         this.chromeFlags = chromeFlags || [];
         this.chromePath = (0, node_path_1.resolve)(userConfig.chromePath);
         const browserArguments = DEFAULT_BROWSER_ARGS;
-        this.browserDetails = this.checkBrowserDetails(this.chromePath);
         if (userConfig?.chromeUserProfilePath) {
             browserArguments.push(`--user-data-dir=${userConfig?.chromeUserProfilePath}`);
         }
@@ -75,31 +70,8 @@ class BrowserContext {
             ...this.chromeFlags,
         ];
     }
-    cleanPath(path) {
-        return path.trim().replaceAll(" ", "\\ ");
-    }
-    checkBrowserDetails(browserExecutablePath) {
-        if (!(0, node_fs_1.existsSync)(browserExecutablePath)) {
-            throw new application_error_1.default(`No executable found in ${browserExecutablePath}`, [
-                "Check your configured browserExecutablePath",
-                "in envVar CHROME_PATH",
-                "or ~/.config/speed-kit-cli/config.json {chromePath:}",
-            ]);
-        }
-        const result = (0, safe_1.safe)(() => {
-            return (0, node_child_process_1.execSync)(`${this.cleanPath(browserExecutablePath)} --version`).toString();
-        });
-        if (result.success === false) {
-            throw new application_error_1.default(result.error, [
-                "Check your configured browserExecutablePath",
-                `No executable found in ${browserExecutablePath}`,
-            ]);
-        }
-        return result.data.trim().replaceAll("\n", "");
-    }
     isChromeBrowser() {
-        return (!!/chrome/i.test(this.browserDetails) &&
-            !!/google/i.test(this.browserDetails));
+        return !!/chrome/i.test(this.browserVersionString);
     }
     getBrowserExtensionPath() {
         if (this.userConfig?.chromeExtensionPaths) {

package/dist/services/onboarding/onboarding-service-factory.js

@@ -72,8 +72,8 @@ class OnboardingServiceFactory {
         const extensionPaths = await new extension_validator_1.ExtensionValidator(extensionDownloader, this.cliConfig, cli).getValidBrowserExtensionPaths();
         this.cliConfig.chromeExtensionPaths = extensionPaths.join(",");
         const browserValidator = new executable_validator_1.ExecutableValidator(this.cliConfig, cli);
-        await browserValidator.validateOrInstall();
-        const browserContext = new onboarding_model_1.BrowserContext(domainToStart, customerConfig.chromeFlags || [], this.cliConfig);
+        const browserVersionString = await browserValidator.validateOrInstall();
+        const browserContext = new onboarding_model_1.BrowserContext(domainToStart, browserVersionString, customerConfig.chromeFlags || [], this.cliConfig);
         const fileWatcher = new file_watcher_1.FileWatcher(cli, customerConfig, files, documentHandler, browserContext, cache);
         const athenaClient = (await this.getAthenaClient()) || null;
         const fetchHandler = await this.getFetchEventHandler(files, customerConfig, documentHandler, cache, cli, browserContext, athenaClient);

package/dist/services/onboarding/onboarding-service.js

@@ -29,7 +29,7 @@ class OnboardingService {
      * prepare puppeteerBrowser, add eventListeners and start
      */
     async run() {
-        this.cli.startAction(`prepare browser ${this.cli.style.bold(this.browserContext.browserDetails)}`);
+        this.cli.startAction(`prepare browser ${this.cli.style.bold(this.browserContext.browserVersionString)}`);
         const browser = await this.prepareBrowser();
         const page = await this.preparePage(browser);
         this.cli.endAction(cli_1.CliActionStatus.COMPLETED);

package/oclif.manifest.json

@@ -732,5 +732,5 @@
       ]
     }
   },
-  "version": "3.4.1"
+  "version": "3.4.2"
 }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@speedkit/cli",
   "description": "Speed Kit CLI",
-  "version": "3.4.1",
+  "version": "3.4.2",
   "author": {
     "name": "Baqend.com",
     "email": "info@baqend.com"