@specship/specship-win32-arm64 0.24.0 → 0.25.0

package/lib/dist/ui/index.html

@@ -8,7 +8,7 @@
     <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32.png" />
     <link rel="icon" type="image/png" sizes="16x16" href="/favicon-16.png" />
     <link rel="apple-touch-icon" sizes="180x180" href="/favicon-180.png" />
-    <script type="module" crossorigin src="/assets/index-CjjaftDw.js"></script>
+    <script type="module" crossorigin src="/assets/index-BzuUWUAE.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-ezwX2EfG.css">
   </head>
   <body>

package/lib/dist/verify/report-ingest.d.ts

@@ -0,0 +1,88 @@
+/**
+ * Test-report ingestion (REQ-VSTATE-004).
+ *
+ * `verified` used to mean "an LLM read a test log and said it passed". This
+ * module replaces that with a deterministic mapping: parse a real test report,
+ * match each reported case to the `tests` links that claim it, and move those
+ * links — passed → `verified`, failed → `broken` — recording the run itself as
+ * the evidence.
+ *
+ * Parsing is total before any write happens, so a malformed report exits with a
+ * parse error having changed no state (A4).
+ */
+import type { SpecLink } from '../types';
+import type { SpecQueries } from '../db/spec-queries';
+/** Thrown for an unreadable / unparseable / shapeless report (REQ-VSTATE-004.A4). */
+export declare class TestReportParseError extends Error {
+    constructor(message: string);
+}
+/** One test case as reported by the runner. */
+export interface ReportedTestCase {
+    /** Project-relative POSIX path of the test file. */
+    file: string;
+    /** The `it()` title, without ancestor describe titles. */
+    title: string;
+    /** Ancestors + title joined, as the runner reported it. */
+    fullName: string;
+    status: 'passed' | 'failed' | 'skipped';
+    failureMessage?: string;
+}
+/** What one link's state move was, for reporting. */
+export interface LinkOutcome {
+    linkId: number;
+    specId: string;
+    file: string;
+    /** The matched test titles the verdict rests on. */
+    titles: string[];
+    from: SpecLink['state'];
+    to: SpecLink['state'];
+}
+export interface VerifyReportResult {
+    runId: string;
+    reportPath: string;
+    /** Total cases read out of the report. */
+    cases: number;
+    promoted: LinkOutcome[];
+    demoted: LinkOutcome[];
+    /** Links matched whose state didn't move (already there, or only skips). */
+    unchanged: number;
+    /** Reported cases that matched no `tests` link at all (A3). */
+    unmatched: number;
+    /** A bounded sample of the unmatched cases, for the operator (A3). */
+    unmatchedSample: string[];
+}
+/**
+ * Parse a vitest / jest JSON report (`vitest run --reporter=json`).
+ *
+ * Shape: `{ testResults: [{ name, assertionResults: [{ title, fullName,
+ * ancestorTitles, status, failureMessages }] }] }`. Anything else — invalid
+ * JSON, a non-object, a missing/!array `testResults` — is a parse error rather
+ * than an empty result, so a report written by a crashed runner can never read
+ * as "nothing to verify" (A4).
+ */
+export declare function parseVitestJsonReport(raw: string, projectRoot: string): ReportedTestCase[];
+/**
+ * Does `testCase` prove `link`? Matching is by FILE first — a link's evidence
+ * must live in the file it points at — then by title, in descending precision:
+ *
+ *   1. the link's recorded `metadata.testTitles` (written by the test-title pass,
+ *      REQ-VSTATE-002) contains the case's title or full name;
+ *   2. the case's full name mentions the link's spec id (the `(REQ-X.A1)` title
+ *      convention, for links that predate the recorded titles);
+ *   3. the case's full name mentions the link's target symbol (a `verifies:`
+ *      block naming a hoisted test function).
+ */
+export declare function caseMatchesLink(testCase: ReportedTestCase, link: SpecLink): boolean;
+/**
+ * Read a report and apply it to the DB (REQ-VSTATE-004).
+ *
+ * Per matched link: any failed case → `broken`; otherwise at least one passed
+ * case → `verified`; only-skipped → left alone (a skipped test proves nothing
+ * either way). The verification record persisted on the link carries the run id,
+ * the report path, the ISO timestamp and the exact test names the verdict rests
+ * on, so `verified` is auditable back to a specific run.
+ */
+export declare function ingestTestReport(sq: SpecQueries, projectRoot: string, reportPath: string, options?: {
+    runId?: string;
+}): VerifyReportResult;
+//# sourceMappingURL=report-ingest.d.ts.map

package/lib/dist/verify/report-ingest.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"report-ingest.d.ts","sourceRoot":"","sources":["../../src/verify/report-ingest.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;GAWG;AAIH,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,UAAU,CAAC;AACzC,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAC;AAEtD,qFAAqF;AACrF,qBAAa,oBAAqB,SAAQ,KAAK;gBACjC,OAAO,EAAE,MAAM;CAI5B;AAED,+CAA+C;AAC/C,MAAM,WAAW,gBAAgB;IAC/B,oDAAoD;IACpD,IAAI,EAAE,MAAM,CAAC;IACb,0DAA0D;IAC1D,KAAK,EAAE,MAAM,CAAC;IACd,2DAA2D;IAC3D,QAAQ,EAAE,MAAM,CAAC;IACjB,MAAM,EAAE,QAAQ,GAAG,QAAQ,GAAG,SAAS,CAAC;IACxC,cAAc,CAAC,EAAE,MAAM,CAAC;CACzB;AAED,qDAAqD;AACrD,MAAM,WAAW,WAAW;IAC1B,MAAM,EAAE,MAAM,CAAC;IACf,MAAM,EAAE,MAAM,CAAC;IACf,IAAI,EAAE,MAAM,CAAC;IACb,oDAAoD;IACpD,MAAM,EAAE,MAAM,EAAE,CAAC;IACjB,IAAI,EAAE,QAAQ,CAAC,OAAO,CAAC,CAAC;IACxB,EAAE,EAAE,QAAQ,CAAC,OAAO,CAAC,CAAC;CACvB;AAED,MAAM,WAAW,kBAAkB;IACjC,KAAK,EAAE,MAAM,CAAC;IACd,UAAU,EAAE,MAAM,CAAC;IACnB,0CAA0C;IAC1C,KAAK,EAAE,MAAM,CAAC;IACd,QAAQ,EAAE,WAAW,EAAE,CAAC;IACxB,OAAO,EAAE,WAAW,EAAE,CAAC;IACvB,4EAA4E;IAC5E,SAAS,EAAE,MAAM,CAAC;IAClB,+DAA+D;IAC/D,SAAS,EAAE,MAAM,CAAC;IAClB,sEAAsE;IACtE,eAAe,EAAE,MAAM,EAAE,CAAC;CAC3B;AAyBD;;;;;;;;GAQG;AACH,wBAAgB,qBAAqB,CAAC,GAAG,EAAE,MAAM,EAAE,WAAW,EAAE,MAAM,GAAG,gBAAgB,EAAE,CAiE1F;AAED;;;;;;;;;;GAUG;AACH,wBAAgB,eAAe,CAAC,QAAQ,EAAE,gBAAgB,EAAE,IAAI,EAAE,QAAQ,GAAG,OAAO,CAkBnF;AAED;;;;;;;;GAQG;AACH,wBAAgB,gBAAgB,CAC9B,EAAE,EAAE,WAAW,EACf,WAAW,EAAE,MAAM,EACnB,UAAU,EAAE,MAAM,EAClB,OAAO,GAAE;IAAE,KAAK,CAAC,EAAE,MAAM,CAAA;CAAO,GAC/B,kBAAkB,CAqFpB"}

package/lib/dist/verify/report-ingest.js

@@ -0,0 +1,269 @@
+"use strict";
+/**
+ * Test-report ingestion (REQ-VSTATE-004).
+ *
+ * `verified` used to mean "an LLM read a test log and said it passed". This
+ * module replaces that with a deterministic mapping: parse a real test report,
+ * match each reported case to the `tests` links that claim it, and move those
+ * links — passed → `verified`, failed → `broken` — recording the run itself as
+ * the evidence.
+ *
+ * Parsing is total before any write happens, so a malformed report exits with a
+ * parse error having changed no state (A4).
+ */
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.TestReportParseError = void 0;
+exports.parseVitestJsonReport = parseVitestJsonReport;
+exports.caseMatchesLink = caseMatchesLink;
+exports.ingestTestReport = ingestTestReport;
+const fs = __importStar(require("fs"));
+const path = __importStar(require("path"));
+/** Thrown for an unreadable / unparseable / shapeless report (REQ-VSTATE-004.A4). */
+class TestReportParseError extends Error {
+    constructor(message) {
+        super(message);
+        this.name = 'TestReportParseError';
+    }
+}
+exports.TestReportParseError = TestReportParseError;
+/** Normalize an absolute or relative path to a project-relative POSIX path. */
+function toProjectRelative(projectRoot, filePath) {
+    const normalized = filePath.replace(/\\/g, '/');
+    const abs = path.isAbsolute(normalized)
+        ? normalized
+        : path.resolve(projectRoot, normalized);
+    const rel = path.relative(projectRoot, abs).replace(/\\/g, '/');
+    return rel.startsWith('..') ? normalized.replace(/^\.\//, '') : rel;
+}
+/**
+ * Parse a vitest / jest JSON report (`vitest run --reporter=json`).
+ *
+ * Shape: `{ testResults: [{ name, assertionResults: [{ title, fullName,
+ * ancestorTitles, status, failureMessages }] }] }`. Anything else — invalid
+ * JSON, a non-object, a missing/!array `testResults` — is a parse error rather
+ * than an empty result, so a report written by a crashed runner can never read
+ * as "nothing to verify" (A4).
+ */
+function parseVitestJsonReport(raw, projectRoot) {
+    const trimmed = raw.trim();
+    if (trimmed.length === 0) {
+        throw new TestReportParseError('report file is empty');
+    }
+    let parsed;
+    try {
+        parsed = JSON.parse(trimmed);
+    }
+    catch (err) {
+        throw new TestReportParseError(`report is not valid JSON: ${err instanceof Error ? err.message : String(err)}`);
+    }
+    if (typeof parsed !== 'object' || parsed === null || Array.isArray(parsed)) {
+        throw new TestReportParseError('report is not a JSON object');
+    }
+    const results = parsed.testResults;
+    if (!Array.isArray(results)) {
+        throw new TestReportParseError('report has no `testResults` array — expected `vitest run --reporter=json` output');
+    }
+    const cases = [];
+    for (const entry of results) {
+        if (typeof entry !== 'object' || entry === null)
+            continue;
+        const fileResult = entry;
+        const name = typeof fileResult.name === 'string' ? fileResult.name : '';
+        if (!name)
+            continue;
+        const file = toProjectRelative(projectRoot, name);
+        const assertions = Array.isArray(fileResult.assertionResults)
+            ? fileResult.assertionResults
+            : [];
+        for (const a of assertions) {
+            if (typeof a !== 'object' || a === null)
+                continue;
+            const ar = a;
+            const title = typeof ar.title === 'string' ? ar.title : '';
+            if (!title)
+                continue;
+            const ancestors = Array.isArray(ar.ancestorTitles)
+                ? ar.ancestorTitles.filter((t) => typeof t === 'string')
+                : [];
+            const fullName = typeof ar.fullName === 'string' && ar.fullName.length > 0
+                ? ar.fullName
+                : [...ancestors, title].join(' > ');
+            const rawStatus = typeof ar.status === 'string' ? ar.status : 'skipped';
+            const status = rawStatus === 'passed'
+                ? 'passed'
+                : rawStatus === 'failed'
+                    ? 'failed'
+                    : 'skipped';
+            const failures = Array.isArray(ar.failureMessages)
+                ? ar.failureMessages.filter((m) => typeof m === 'string')
+                : [];
+            cases.push({
+                file,
+                title,
+                fullName,
+                status,
+                failureMessage: failures[0],
+            });
+        }
+    }
+    return cases;
+}
+/**
+ * Does `testCase` prove `link`? Matching is by FILE first — a link's evidence
+ * must live in the file it points at — then by title, in descending precision:
+ *
+ *   1. the link's recorded `metadata.testTitles` (written by the test-title pass,
+ *      REQ-VSTATE-002) contains the case's title or full name;
+ *   2. the case's full name mentions the link's spec id (the `(REQ-X.A1)` title
+ *      convention, for links that predate the recorded titles);
+ *   3. the case's full name mentions the link's target symbol (a `verifies:`
+ *      block naming a hoisted test function).
+ */
+function caseMatchesLink(testCase, link) {
+    const linkFile = link.targetFilePath.replace(/\\/g, '/');
+    if (linkFile !== testCase.file)
+        return false;
+    const recorded = link.metadata?.testTitles;
+    if (Array.isArray(recorded)) {
+        for (const t of recorded) {
+            if (typeof t !== 'string')
+                continue;
+            if (t === testCase.title || t === testCase.fullName)
+                return true;
+        }
+    }
+    if (testCase.fullName.includes(link.specId))
+        return true;
+    // A file-targeted link (the test-title pass) has no symbol to match on — its
+    // qualified name IS the path, whose extension would match almost any title.
+    if (link.targetNodeKind === 'file')
+        return false;
+    const symbol = link.targetQualifiedName.split('.').pop() ?? '';
+    if (symbol.length >= 3 && testCase.fullName.includes(symbol))
+        return true;
+    return false;
+}
+/**
+ * Read a report and apply it to the DB (REQ-VSTATE-004).
+ *
+ * Per matched link: any failed case → `broken`; otherwise at least one passed
+ * case → `verified`; only-skipped → left alone (a skipped test proves nothing
+ * either way). The verification record persisted on the link carries the run id,
+ * the report path, the ISO timestamp and the exact test names the verdict rests
+ * on, so `verified` is auditable back to a specific run.
+ */
+function ingestTestReport(sq, projectRoot, reportPath, options = {}) {
+    let raw;
+    try {
+        raw = fs.readFileSync(path.resolve(projectRoot, reportPath), 'utf-8');
+    }
+    catch (err) {
+        throw new TestReportParseError(`cannot read report ${reportPath}: ${err instanceof Error ? err.message : String(err)}`);
+    }
+    // Parse EVERYTHING before the first write (A4).
+    const cases = parseVitestJsonReport(raw, projectRoot);
+    const runId = options.runId ?? `run-${Date.now()}`;
+    const verifiedAt = new Date().toISOString();
+    const testsLinks = sq.getAllLinks().filter((l) => l.kind === 'tests');
+    // Bucket the cases per link, and track which cases matched something.
+    const perLink = new Map();
+    const matchedCases = new Set();
+    for (const link of testsLinks) {
+        for (const c of cases) {
+            if (!caseMatchesLink(c, link))
+                continue;
+            const bucket = perLink.get(link.id) ?? { link, cases: [] };
+            bucket.cases.push(c);
+            perLink.set(link.id, bucket);
+            matchedCases.add(c);
+        }
+    }
+    const promoted = [];
+    const demoted = [];
+    let unchanged = 0;
+    for (const { link, cases: linkCases } of perLink.values()) {
+        const failed = linkCases.filter((c) => c.status === 'failed');
+        const passed = linkCases.filter((c) => c.status === 'passed');
+        if (failed.length === 0 && passed.length === 0) {
+            unchanged++;
+            continue;
+        }
+        const pass = failed.length === 0;
+        const relevant = pass ? passed : failed;
+        const titles = relevant.map((c) => c.fullName);
+        const now = Date.now();
+        const metadata = {
+            ...(link.metadata ?? {}),
+            verification: {
+                result: pass ? 'pass' : 'fail',
+                verifiedAt,
+                reason: pass
+                    ? `${passed.length} test(s) passed in ${path.basename(reportPath)}`
+                    : (failed[0]?.failureMessage?.split('\n')[0] ??
+                        `${failed.length} test(s) failed in ${path.basename(reportPath)}`),
+                evidence: relevant.map((c) => `${c.file}:${c.fullName}`),
+                run: { id: runId, report: reportPath, source: 'vitest-json', ranAt: verifiedAt },
+            },
+        };
+        const to = pass ? 'verified' : 'broken';
+        sq.updateSpecLinkState(link.id, to, null, now);
+        sq.updateSpecLinkMetadata(link.id, metadata, now);
+        const outcome = {
+            linkId: link.id,
+            specId: link.specId,
+            file: link.targetFilePath,
+            titles,
+            from: link.state,
+            to,
+        };
+        if (pass)
+            promoted.push(outcome);
+        else
+            demoted.push(outcome);
+    }
+    const unmatchedCases = cases.filter((c) => !matchedCases.has(c));
+    return {
+        runId,
+        reportPath,
+        cases: cases.length,
+        promoted,
+        demoted,
+        unchanged,
+        unmatched: unmatchedCases.length,
+        unmatchedSample: unmatchedCases.slice(0, 10).map((c) => `${c.file}:${c.fullName}`),
+    };
+}
+//# sourceMappingURL=report-ingest.js.map

package/lib/dist/verify/report-ingest.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"report-ingest.js","sourceRoot":"","sources":["../../src/verify/report-ingest.ts"],"names":[],"mappings":";AAAA;;;;;;;;;;;GAWG;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAqFH,sDAiEC;AAaD,0CAkBC;AAWD,4CA0FC;AAxRD,uCAAyB;AACzB,2CAA6B;AAI7B,qFAAqF;AACrF,MAAa,oBAAqB,SAAQ,KAAK;IAC7C,YAAY,OAAe;QACzB,KAAK,CAAC,OAAO,CAAC,CAAC;QACf,IAAI,CAAC,IAAI,GAAG,sBAAsB,CAAC;IACrC,CAAC;CACF;AALD,oDAKC;AAqDD,+EAA+E;AAC/E,SAAS,iBAAiB,CAAC,WAAmB,EAAE,QAAgB;IAC9D,MAAM,UAAU,GAAG,QAAQ,CAAC,OAAO,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC;IAChD,MAAM,GAAG,GAAG,IAAI,CAAC,UAAU,CAAC,UAAU,CAAC;QACrC,CAAC,CAAC,UAAU;QACZ,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,WAAW,EAAE,UAAU,CAAC,CAAC;IAC1C,MAAM,GAAG,GAAG,IAAI,CAAC,QAAQ,CAAC,WAAW,EAAE,GAAG,CAAC,CAAC,OAAO,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC;IAChE,OAAO,GAAG,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,OAAO,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC;AACtE,CAAC;AAED;;;;;;;;GAQG;AACH,SAAgB,qBAAqB,CAAC,GAAW,EAAE,WAAmB;IACpE,MAAM,OAAO,GAAG,GAAG,CAAC,IAAI,EAAE,CAAC;IAC3B,IAAI,OAAO,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QACzB,MAAM,IAAI,oBAAoB,CAAC,sBAAsB,CAAC,CAAC;IACzD,CAAC;IACD,IAAI,MAAe,CAAC;IACpB,IAAI,CAAC;QACH,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC;IAC/B,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,MAAM,IAAI,oBAAoB,CAC5B,6BAA6B,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,EAAE,CAChF,CAAC;IACJ,CAAC;IACD,IAAI,OAAO,MAAM,KAAK,QAAQ,IAAI,MAAM,KAAK,IAAI,IAAI,KAAK,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CAAC;QAC3E,MAAM,IAAI,oBAAoB,CAAC,6BAA6B,CAAC,CAAC;IAChE,CAAC;IACD,MAAM,OAAO,GAAI,MAAoC,CAAC,WAAW,CAAC;IAClE,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,OAAO,CAAC,EAAE,CAAC;QAC5B,MAAM,IAAI,oBAAoB,CAC5B,kFAAkF,CACnF,CAAC;IACJ,CAAC;IAED,MAAM,KAAK,GAAuB,EAAE,CAAC;IACrC,KAAK,MAAM,KAAK,IAAI,OAAO,EAAE,CAAC;QAC5B,IAAI,OAAO,KAAK,KAAK,QAAQ,IAAI,KAAK,KAAK,IAAI;YAAE,SAAS;QAC1D,MAAM,UAAU,GAAG,KAAsB,CAAC;QAC1C,MAAM,IAAI,GAAG,OAAO,UAAU,CAAC,IAAI,KAAK,QAAQ,CAAC,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC;QACxE,IAAI,CAAC,IAAI;YAAE,SAAS;QACpB,MAAM,IAAI,GAAG,iBAAiB,CAAC,WAAW,EAAE,IAAI,CAAC,CAAC;QAClD,MAAM,UAAU,GAAG,KAAK,CAAC,OAAO,CAAC,UAAU,CAAC,gBAAgB,CAAC;YAC3D,CAAC,CAAC,UAAU,CAAC,gBAAgB;YAC7B,CAAC,CAAC,EAAE,CAAC;QACP,KAAK,MAAM,CAAC,IAAI,UAAU,EAAE,CAAC;YAC3B,IAAI,OAAO,CAAC,KAAK,QAAQ,IAAI,CAAC,KAAK,IAAI;gBAAE,SAAS;YAClD,MAAM,EAAE,GAAG,CAAiB,CAAC;YAC7B,MAAM,KAAK,GAAG,OAAO,EAAE,CAAC,KAAK,KAAK,QAAQ,CAAC,CAAC,CAAC,EAAE,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,CAAC;YAC3D,IAAI,CAAC,KAAK;gBAAE,SAAS;YACrB,MAAM,SAAS,GAAG,KAAK,CAAC,OAAO,CAAC,EAAE,CAAC,cAAc,CAAC;gBAChD,CAAC,CAAC,EAAE,CAAC,cAAc,CAAC,MAAM,CAAC,CAAC,CAAC,EAAe,EAAE,CAAC,OAAO,CAAC,KAAK,QAAQ,CAAC;gBACrE,CAAC,CAAC,EAAE,CAAC;YACP,MAAM,QAAQ,GACZ,OAAO,EAAE,CAAC,QAAQ,KAAK,QAAQ,IAAI,EAAE,CAAC,QAAQ,CAAC,MAAM,GAAG,CAAC;gBACvD,CAAC,CAAC,EAAE,CAAC,QAAQ;gBACb,CAAC,CAAC,CAAC,GAAG,SAAS,EAAE,KAAK,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YACxC,MAAM,SAAS,GAAG,OAAO,EAAE,CAAC,MAAM,KAAK,QAAQ,CAAC,CAAC,CAAC,EAAE,CAAC,MAAM,CAAC,CAAC,CAAC,SAAS,CAAC;YACxE,MAAM,MAAM,GACV,SAAS,KAAK,QAAQ;gBACpB,CAAC,CAAC,QAAQ;gBACV,CAAC,CAAC,SAAS,KAAK,QAAQ;oBACtB,CAAC,CAAC,QAAQ;oBACV,CAAC,CAAC,SAAS,CAAC;YAClB,MAAM,QAAQ,GAAG,KAAK,CAAC,OAAO,CAAC,EAAE,CAAC,eAAe,CAAC;gBAChD,CAAC,CAAC,EAAE,CAAC,eAAe,CAAC,MAAM,CAAC,CAAC,CAAC,EAAe,EAAE,CAAC,OAAO,CAAC,KAAK,QAAQ,CAAC;gBACtE,CAAC,CAAC,EAAE,CAAC;YACP,KAAK,CAAC,IAAI,CAAC;gBACT,IAAI;gBACJ,KAAK;gBACL,QAAQ;gBACR,MAAM;gBACN,cAAc,EAAE,QAAQ,CAAC,CAAC,CAAC;aAC5B,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IACD,OAAO,KAAK,CAAC;AACf,CAAC;AAED;;;;;;;;;;GAUG;AACH,SAAgB,eAAe,CAAC,QAA0B,EAAE,IAAc;IACxE,MAAM,QAAQ,GAAG,IAAI,CAAC,cAAc,CAAC,OAAO,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC;IACzD,IAAI,QAAQ,KAAK,QAAQ,CAAC,IAAI;QAAE,OAAO,KAAK,CAAC;IAE7C,MAAM,QAAQ,GAAG,IAAI,CAAC,QAAQ,EAAE,UAAU,CAAC;IAC3C,IAAI,KAAK,CAAC,OAAO,CAAC,QAAQ,CAAC,EAAE,CAAC;QAC5B,KAAK,MAAM,CAAC,IAAI,QAAQ,EAAE,CAAC;YACzB,IAAI,OAAO,CAAC,KAAK,QAAQ;gBAAE,SAAS;YACpC,IAAI,CAAC,KAAK,QAAQ,CAAC,KAAK,IAAI,CAAC,KAAK,QAAQ,CAAC,QAAQ;gBAAE,OAAO,IAAI,CAAC;QACnE,CAAC;IACH,CAAC;IACD,IAAI,QAAQ,CAAC,QAAQ,CAAC,QAAQ,CAAC,IAAI,CAAC,MAAM,CAAC;QAAE,OAAO,IAAI,CAAC;IACzD,6EAA6E;IAC7E,4EAA4E;IAC5E,IAAI,IAAI,CAAC,cAAc,KAAK,MAAM;QAAE,OAAO,KAAK,CAAC;IACjD,MAAM,MAAM,GAAG,IAAI,CAAC,mBAAmB,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,GAAG,EAAE,IAAI,EAAE,CAAC;IAC/D,IAAI,MAAM,CAAC,MAAM,IAAI,CAAC,IAAI,QAAQ,CAAC,QAAQ,CAAC,QAAQ,CAAC,MAAM,CAAC;QAAE,OAAO,IAAI,CAAC;IAC1E,OAAO,KAAK,CAAC;AACf,CAAC;AAED;;;;;;;;GAQG;AACH,SAAgB,gBAAgB,CAC9B,EAAe,EACf,WAAmB,EACnB,UAAkB,EAClB,UAA8B,EAAE;IAEhC,IAAI,GAAW,CAAC;IAChB,IAAI,CAAC;QACH,GAAG,GAAG,EAAE,CAAC,YAAY,CAAC,IAAI,CAAC,OAAO,CAAC,WAAW,EAAE,UAAU,CAAC,EAAE,OAAO,CAAC,CAAC;IACxE,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACb,MAAM,IAAI,oBAAoB,CAC5B,sBAAsB,UAAU,KAAK,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,MAAM,CAAC,GAAG,CAAC,EAAE,CACxF,CAAC;IACJ,CAAC;IACD,gDAAgD;IAChD,MAAM,KAAK,GAAG,qBAAqB,CAAC,GAAG,EAAE,WAAW,CAAC,CAAC;IAEtD,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,IAAI,OAAO,IAAI,CAAC,GAAG,EAAE,EAAE,CAAC;IACnD,MAAM,UAAU,GAAG,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC;IAC5C,MAAM,UAAU,GAAG,EAAE,CAAC,WAAW,EAAE,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,OAAO,CAAC,CAAC;IAEtE,sEAAsE;IACtE,MAAM,OAAO,GAAG,IAAI,GAAG,EAAyD,CAAC;IACjF,MAAM,YAAY,GAAG,IAAI,GAAG,EAAoB,CAAC;IACjD,KAAK,MAAM,IAAI,IAAI,UAAU,EAAE,CAAC;QAC9B,KAAK,MAAM,CAAC,IAAI,KAAK,EAAE,CAAC;YACtB,IAAI,CAAC,eAAe,CAAC,CAAC,EAAE,IAAI,CAAC;gBAAE,SAAS;YACxC,MAAM,MAAM,GAAG,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,EAAE,IAAI,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC;YAC3D,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;YACrB,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,EAAE,MAAM,CAAC,CAAC;YAC7B,YAAY,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC;QACtB,CAAC;IACH,CAAC;IAED,MAAM,QAAQ,GAAkB,EAAE,CAAC;IACnC,MAAM,OAAO,GAAkB,EAAE,CAAC;IAClC,IAAI,SAAS,GAAG,CAAC,CAAC;IAElB,KAAK,MAAM,EAAE,IAAI,EAAE,KAAK,EAAE,SAAS,EAAE,IAAI,OAAO,CAAC,MAAM,EAAE,EAAE,CAAC;QAC1D,MAAM,MAAM,GAAG,SAAS,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,QAAQ,CAAC,CAAC;QAC9D,MAAM,MAAM,GAAG,SAAS,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,QAAQ,CAAC,CAAC;QAC9D,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC/C,SAAS,EAAE,CAAC;YACZ,SAAS;QACX,CAAC;QACD,MAAM,IAAI,GAAG,MAAM,CAAC,MAAM,KAAK,CAAC,CAAC;QACjC,MAAM,QAAQ,GAAG,IAAI,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,MAAM,CAAC;QACxC,MAAM,MAAM,GAAG,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC;QAC/C,MAAM,GAAG,GAAG,IAAI,CAAC,GAAG,EAAE,CAAC;QAEvB,MAAM,QAAQ,GAA4B;YACxC,GAAG,CAAC,IAAI,CAAC,QAAQ,IAAI,EAAE,CAAC;YACxB,YAAY,EAAE;gBACZ,MAAM,EAAE,IAAI,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,MAAM;gBAC9B,UAAU;gBACV,MAAM,EAAE,IAAI;oBACV,CAAC,CAAC,GAAG,MAAM,CAAC,MAAM,sBAAsB,IAAI,CAAC,QAAQ,CAAC,UAAU,CAAC,EAAE;oBACnE,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,cAAc,EAAE,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;wBACzC,GAAG,MAAM,CAAC,MAAM,sBAAsB,IAAI,CAAC,QAAQ,CAAC,UAAU,CAAC,EAAE,CAAC;gBACvE,QAAQ,EAAE,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,GAAG,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,QAAQ,EAAE,CAAC;gBACxD,GAAG,EAAE,EAAE,EAAE,EAAE,KAAK,EAAE,MAAM,EAAE,UAAU,EAAE,MAAM,EAAE,aAAa,EAAE,KAAK,EAAE,UAAU,EAAE;aACjF;SACF,CAAC;QAEF,MAAM,EAAE,GAAsB,IAAI,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,QAAQ,CAAC;QAC3D,EAAE,CAAC,mBAAmB,CAAC,IAAI,CAAC,EAAE,EAAE,EAAE,EAAE,IAAI,EAAE,GAAG,CAAC,CAAC;QAC/C,EAAE,CAAC,sBAAsB,CAAC,IAAI,CAAC,EAAE,EAAE,QAAQ,EAAE,GAAG,CAAC,CAAC;QAClD,MAAM,OAAO,GAAgB;YAC3B,MAAM,EAAE,IAAI,CAAC,EAAE;YACf,MAAM,EAAE,IAAI,CAAC,MAAM;YACnB,IAAI,EAAE,IAAI,CAAC,cAAc;YACzB,MAAM;YACN,IAAI,EAAE,IAAI,CAAC,KAAK;YAChB,EAAE;SACH,CAAC;QACF,IAAI,IAAI;YAAE,QAAQ,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;;YAC5B,OAAO,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IAC7B,CAAC;IAED,MAAM,cAAc,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,YAAY,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC;IACjE,OAAO;QACL,KAAK;QACL,UAAU;QACV,KAAK,EAAE,KAAK,CAAC,MAAM;QACnB,QAAQ;QACR,OAAO;QACP,SAAS;QACT,SAAS,EAAE,cAAc,CAAC,MAAM;QAChC,eAAe,EAAE,cAAc,CAAC,KAAK,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,GAAG,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,QAAQ,EAAE,CAAC;KACnF,CAAC;AACJ,CAAC"}

package/lib/dist/workflows/defaults/spec-fix.yaml

@@ -14,8 +14,10 @@ inputs:
 systemPromptAppend: |
   You are fixing code so a spec's link returns to "verified" state.
   Call specship_spec($INPUT.SPEC_ID) first to see the current state and
-  drift_axis. After fixing, call specship_link_verify({result: "pass"})
-  on each affected link before reporting done.
+  drift_axis. Link state changes only in the link_verify node, only after
+  the reviewer's approval, and only as the run's VERIFY_RESULT marker
+  allows — a verify leg that was skipped or never got past install/build
+  proves nothing and promotes nothing (REQ-REVINT-006).
 
 nodes:
   - id: diagnose
@@ -78,33 +80,122 @@ nodes:
     output_type: test_results
     timeout: 600000
     bash: |
+      # Same VERIFY_RESULT marker contract as spec-implement
+      # (REQ-REVINT-006.A2): the link_verify node routes on the marker, so a
+      # skipped run can never be mistaken for a passing one, and an
+      # environment or build failure is never attributed to the tests.
       if [ -f package.json ]; then
-        npm test
+        # A fresh worktree has no node_modules/ or build output.
+        if [ ! -d node_modules ]; then
+          if ! { npm ci --no-audit --no-fund || npm install --no-audit --no-fund; }; then
+            echo "VERIFY_RESULT=env-failed"; exit 1
+          fi
+        fi
+        if ! npm run build --if-present; then echo "VERIFY_RESULT=build-failed"; exit 1; fi
+        if npm test; then echo "VERIFY_RESULT=ran-and-passed"; else echo "VERIFY_RESULT=ran-and-failed"; exit 1; fi
       elif [ -f Cargo.toml ]; then
-        cargo test
+        if ! cargo build; then echo "VERIFY_RESULT=build-failed"; exit 1; fi
+        if cargo test; then echo "VERIFY_RESULT=ran-and-passed"; else echo "VERIFY_RESULT=ran-and-failed"; exit 1; fi
       elif [ -f pyproject.toml ] || [ -f requirements.txt ]; then
-        python -m pytest
+        if ! python -c 'import pytest' 2>/dev/null; then echo "VERIFY_RESULT=env-failed"; exit 1; fi
+        if python -m pytest; then echo "VERIFY_RESULT=ran-and-passed"; else echo "VERIFY_RESULT=ran-and-failed"; exit 1; fi
       else
-        echo "no recognised test framework; skipping"
+        echo "no recognised test framework; tests did NOT run"
+        echo "VERIFY_RESULT=skipped"
       fi
 
+  - id: route_verify
+    kind: bash
+    depends_on: [verify]
+    output_type: verify_route
+    bash: |
+      # Deterministic verify routing (REQ-VSTATE-005.A1): code parses the
+      # VERIFY_RESULT marker and emits the LINK_ACTION the link node obeys, so
+      # the decision that governs link promotion isn't a prompt's reading of a
+      # test log. env-failed / build-failed halt here, before the approval gate
+      # and before any link mutation, naming the cause (REQ-VSTATE-005.A3).
+      VERIFY_OUT=$verify.output
+      MARKER=$(printf '%s' "$VERIFY_OUT" | grep -oE 'VERIFY_RESULT=[a-z-]+' | tail -n 1 | cut -d= -f2)
+      [ -n "$MARKER" ] || MARKER=missing
+      echo "VERIFY_RESULT=$MARKER"
+      case "$MARKER" in
+        ran-and-passed)
+          echo "LINK_ACTION=verify-pass" ;;
+        ran-and-failed)
+          echo "LINK_ACTION=verify-fail" ;;
+        skipped)
+          echo "LINK_ACTION=no-verify" ;;
+        env-failed)
+          echo "HALT_CAUSE=environment setup failed (dependency install) — nothing is known about the tests"
+          exit 1 ;;
+        build-failed)
+          echo "HALT_CAUSE=build failed — nothing is known about the tests"
+          exit 1 ;;
+        *)
+          echo "HALT_CAUSE=no VERIFY_RESULT marker found in the verify output — an unknown result is never a pass"
+          exit 1 ;;
+      esac
+
+  - id: approve_links
+    kind: approval
+    depends_on: [route_verify]
+    message: |
+      Fix applied for $INPUT.SPEC_ID — approve before any link changes state
+      (REQ-REVINT-006.A4).
+
+      Files changed:
+      $apply.output
+
+      Verify routing (computed in code, REQ-VSTATE-005.A1 — `no-verify`
+      means no test ran, so nothing here can reach `verified`):
+      $route_verify.output
+
+      Test results:
+      $verify.output
+
+      Approve to let the link states be updated, or reject to leave every
+      link exactly as it is.
+    capture_response: true
+
   - id: link_verify
     kind: prompt
-    depends_on: [verify]
+    depends_on: [approve_links]
     output_type: link_summary
     allowed_tools:
       - mcp__specship__specship_spec
       - mcp__specship__specship_link_assert
       - mcp__specship__specship_link_verify
     prompt: |
-      For each link that was drifted/broken on $INPUT.SPEC_ID, now that
-      the fix has been applied and tests pass, call specship_link_verify
-      with result="pass" (or "fail" if a test failed for that link).
+      The reviewer has approved updating link state for $INPUT.SPEC_ID.
+
+      Act on LINK_ACTION — a bash node already derived it from the
+      VERIFY_RESULT marker (REQ-VSTATE-005.A1). Do NOT re-derive it from the
+      test log; read it here:
+
+      $route_verify.output
+
+      - LINK_ACTION=verify-pass → for each link that was drifted/broken, call
+        specship_link_verify with result="pass" (or "fail" if a test failed
+        for that link specifically).
+      - LINK_ACTION=verify-fail → call specship_link_verify with
+        result="fail" for the affected links. Never "pass".
+      - LINK_ACTION=no-verify → no test ran, so nothing is proven. Do NOT
+        call specship_link_verify at all; no link may reach `verified`
+        (REQ-REVINT-006.A3). Report that verification was skipped.
+
+      A run whose environment or build broke never reaches this node — the
+      routing step halts it first (REQ-VSTATE-005.A3).
 
       If a link is orphaned because the symbol moved, call
-      specship_link_assert at the new location.
+      specship_link_assert at the new location. Never pass kind: 'tests' —
+      test evidence is file-derived (`verifies:` block or an `@verifies`
+      comment), never minted by this workflow (REQ-REVINT-005.A1).
+
+      Reviewer feedback (if any):
+      $approve_links.output
 
       Test results:
       $verify.output
 
-      Output: one line per link with the new state.
+      Output: one line per link with the new state, ending with one line
+      stating whether verification ran, failed, or was skipped.