@specsage/cli 0.1.12 → 0.1.13

package/lib/client_errors.rb

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+
+# Shared base error type for step clients (StepClient, DirectStepClient).
+# Runner can rescue this base type to handle errors from either client.
+# Each client defines its own StepError subclass for API stability.
+class StepClientError < StandardError; end

package/lib/runner.rb

@@ -11,6 +11,7 @@ require 'fileutils'
 # Determine SpecSage home directory for locating resources
 SPECSAGE_HOME ||= File.expand_path('..', __dir__)
 
+require_relative 'client_errors'
 require_relative 'step_client'
 
 class Runner
@@ -25,7 +26,8 @@ class Runner
 
   # Initialize runner with scenario data from server
   # @param all_scenarios [Hash] optional map of scenario_id => scenario_data for pre-scenario lookup
-  def initialize(scenario_data, visible: false, record: false, publisher: nil, server_run_id: nil, all_scenarios: nil)
+  # @param step_client [StepClient, DirectStepClient] optional pre-configured client for step processing
+  def initialize(scenario_data, visible: false, record: false, publisher: nil, server_run_id: nil, all_scenarios: nil, step_client: nil)
     @scenario = normalize_scenario_data(scenario_data)
     @scenario_id = @scenario['id']
     @scenario_name = @scenario['name'] || @scenario['id'] || 'unnamed'
@@ -38,7 +40,7 @@ class Runner
     @next_request_id = 1
     @node_channel_poisoned = false
     @publisher = publisher
-    @step_client = nil
+    @step_client = step_client # Accept pre-configured client (nil = create StepClient in run())
     @server_run_id = server_run_id
     @credentials = {} # Credentials received from server { "NAME" => "value" }
     @max_steps = nil # Max browser actions allowed, received from server on first step
@@ -51,7 +53,10 @@ class Runner
 
     raise ArgumentError, 'server_run_id is required' unless @server_run_id
 
-    @step_client = StepClient.new(
+    # Only create StepClient if not injected (CLI path uses HTTP, Sidekiq injects DirectStepClient)
+    # TODO: Validate publisher presence here when step_client is nil. Currently crashes with
+    # NoMethodError on @publisher.base_url if caller omits both step_client and publisher.
+    @step_client ||= StepClient.new(
       base_url: @publisher.base_url,
       server_run_id: @server_run_id,
       api_key: @publisher.api_key
@@ -124,7 +129,7 @@ class Runner
     cleanup_temp_dir
 
     result[:verdict]
-  rescue StepClient::StepError => e
+  rescue StepClientError => e
     send_client_verdict_if_needed('ERROR', "Server error: #{e.message}")
     stop_node_process
     upload_video
@@ -245,7 +250,7 @@ class Runner
       status: status,
       reason: reason
     )
-  rescue StepClient::StepError => e
+  rescue StepClientError => e
     log "Warning: Failed to send main scenario verdict: #{e.message}"
   end
 
@@ -587,7 +592,7 @@ class Runner
     log "Uploading video (#{@video_data.bytesize} bytes)..."
     @step_client.upload_video(scenario_id: @scenario_id, video_data: @video_data)
     log "Video uploaded successfully."
-  rescue StepClient::StepError => e
+  rescue StepClientError => e
     log "Warning: Failed to upload video: #{e.message}"
   end
 
@@ -641,7 +646,7 @@ class Runner
       status: status,
       reason: reason
     )
-  rescue StepClient::StepError => e
+  rescue StepClientError => e
     log "Warning: Failed to send verdict to server: #{e.message}"
   end
 

package/lib/step_client.rb

@@ -7,9 +7,12 @@ require "net/http"
 require "uri"
 require "json"
 require "base64"
+require_relative "client_errors"
 
 class StepClient
-  class StepError < StandardError; end
+  # Subclass shared error for API stability (supports subclassing, .class checks, .name)
+  # Runner can rescue either StepClient::StepError or the base StepClientError
+  class StepError < StepClientError; end
 
   attr_reader :server_run_id
 
@@ -59,6 +62,10 @@ class StepClient
 
     response = post("/api/runs/#{@server_run_id}/step", body)
 
+    # TODO: Credentials defaulted to {} may change semantics. Server returns nil when no
+    # credentials are present (after first step). Returning {} instead of nil may cause
+    # downstream code to branch incorrectly (`if credentials` is always truthy). Consider
+    # returning nil when server returns nil, or document this as intentional contract.
     {
       action: response["action"],
       step_number: response["step_number"],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@specsage/cli",
-  "version": "0.1.12",
+  "version": "0.1.13",
   "description": "SpecSage CLI - AI-powered end-to-end testing automation (Node wrapper for Ruby CLI)",
   "type": "module",
   "bin": {