@specs-feup/clava-misra 1.0.2 → 1.0.3

package/dist/rules/Section17_Functions/Rule_17_3_ImplicitFunction.js

@@ -0,0 +1,209 @@
+import { Call, Program } from "@specs-feup/clava/api/Joinpoints.js";
+import { AnalysisType, MISRATransformationReport, MISRATransformationType } from "../../MISRA.js";
+import { findFunctionDef } from "../../utils/FunctionUtils.js";
+import { getCallIndex, isCallToImplicitFunction } from "../../utils/CallUtils.js";
+import Query from "@specs-feup/lara/api/weaver/Query.js";
+import { addExternFunctionDecl, getFilesWithCallToImplicitFunction, getIncludesOfFile, isValidFileWithExplicitCall, removeIncludeFromFile } from "../../utils/FileUtils.js";
+import UserConfigurableRule from "../UserConfigurableRule.js";
+/**
+ * MISRA-C Rule 17.3: A function shall not be declared implicitly
+ */
+export default class Rule_17_3_ImplicitFunction extends UserConfigurableRule {
+    /**
+     * A positive integer starting from 1 that indicates the rule's priority, determining the order in which rules are applied.
+     */
+    priority = 1;
+    /**
+     * Scope of analysis
+     */
+    analysisType = AnalysisType.SINGLE_TRANSLATION_UNIT;
+    /**
+     * Standards to which this rule applies to
+     */
+    appliesTo = new Set(["c90"]);
+    /**
+     * @returns Rule identifier according to MISRA-C:2012
+     */
+    get name() {
+        return "17.3";
+    }
+    /**
+     * Returns the prefix to be used for error messages related to the given joinpoint
+     *
+     * @param $jp - Joinpoint where the violation was detected
+     * @returns Returns a prefix to prepend to error messages if no configuration is specified or if the configuration does not contain a fix for this violation
+     */
+    getErrorMsgPrefix(callJp) {
+        return `Function '${callJp.name}' is declared implicitly.`;
+    }
+    /**
+     * Retrieves the fix for a implicit call specified on the config file (.h or .c)
+     * @param callJp
+     * @param errorMsgPrefix
+     * @returns
+     */
+    getFixFromConfig(callJp) {
+        const errorMsgPrefix = this.getErrorMsgPrefix(callJp);
+        if (!this.context.config) {
+            this.logMISRAError(callJp, `${errorMsgPrefix} Include or extern not added due to missing config file.`);
+            return undefined;
+        }
+        let configFix;
+        try {
+            configFix = this.context.config.get("implicitCalls")[callJp.name];
+        }
+        catch {
+            this.logMISRAError(callJp, `${errorMsgPrefix} Include or extern was not added as \'implicitCalls\' is not defined in the configuration file.`);
+            return undefined;
+        }
+        if (configFix === undefined) {
+            this.logMISRAError(callJp, `${errorMsgPrefix} Couldn't add include or extern due to missing configuration for function '${callJp.name}'.`);
+            return undefined;
+        }
+        if (!(configFix.endsWith(".h") || configFix.endsWith(".c"))) {
+            this.logMISRAError(callJp, `${errorMsgPrefix} Cannot add include or extern without a .h or .c reference.`);
+            return undefined;
+        }
+        return configFix;
+    }
+    /**
+     * Checks if the given joinpoint represents a call to an implicit function.
+     *
+     * @param $jp - Joinpoint to analyze
+     * @param logErrors - [logErrors=false] - Whether to log errors if a violation is detected
+     * @returns Returns true if the joinpoint violates the rule, false otherwise
+     */
+    match($jp, logErrors = false) {
+        if (!($jp instanceof Program && this.appliesToCurrentStandard()))
+            return false;
+        const implicitCalls = Query.searchFrom($jp, Call, (callJp) => isCallToImplicitFunction(callJp)).get();
+        if (logErrors) {
+            for (const callJp of implicitCalls) {
+                this.logMISRAError(callJp, this.getErrorMsgPrefix(callJp));
+            }
+        }
+        return implicitCalls.length > 0;
+    }
+    /**
+     * Transforms every implicit call by adding a missing include directive or extern statement specified on the config file.
+     *
+     * - If the configuration is missing or the specified fix is invalid (i.e., not a '.h' or '.c' file), no transformation is performed and the call is left unchanged.
+     * - The fix is applied only if it successfully resolves the issue (i.e., makes the call explicit and the file compiles with no error).
+     * - Otherwise, the fix is removed.
+     *
+     * @param $jp - Joinpoint to transform
+     * @returns Report detailing the transformation result
+     */
+    apply($jp) {
+        if (!this.match($jp))
+            return new MISRATransformationReport(MISRATransformationType.NoChange);
+        const filesWithImplicitCall = getFilesWithCallToImplicitFunction($jp);
+        let changedDescendant = false;
+        for (const fileJp of filesWithImplicitCall) {
+            if (this.solveImplicitCalls(fileJp)) {
+                changedDescendant = true;
+            }
+        }
+        if (changedDescendant) {
+            this.rebuildProgram();
+            return new MISRATransformationReport(MISRATransformationType.Replacement, Query.root());
+        }
+        else {
+            return new MISRATransformationReport(MISRATransformationType.NoChange);
+        }
+    }
+    /**
+     * Attempts to resolve implicit function calls in a file by adding missing includes or extern statements based on the configuration file.
+     * @param fileJp The file to analyze
+     * @returns `true` if any changes were made to the file, otherwise `false`.
+     */
+    solveImplicitCalls(fileJp) {
+        const implicitCalls = Query.searchFrom(fileJp, Call, (callJp) => (isCallToImplicitFunction(callJp))).get();
+        const originalIncludes = getIncludesOfFile(fileJp);
+        let solvedCalls = new Set();
+        let addedIncludes = new Set();
+        let changedFile = false;
+        for (const callJp of implicitCalls) {
+            if (this.context.getRuleResult(this.ruleID, callJp) === MISRATransformationType.NoChange) {
+                continue;
+            }
+            if (solvedCalls.has(callJp.name)) {
+                continue;
+            }
+            const configFix = this.getFixFromConfig(callJp);
+            if (configFix === undefined) {
+                this.context.addRuleResult(this.ruleID, callJp, MISRATransformationType.NoChange);
+                continue;
+            }
+            const callIndex = getCallIndex(fileJp, callJp);
+            const isInclude = configFix.endsWith(".h");
+            const success = isInclude ?
+                this.solveWithInclude(fileJp, callJp, configFix, originalIncludes, addedIncludes, callIndex) :
+                this.solveWithExtern(fileJp, callJp, configFix, callIndex);
+            if (success) {
+                solvedCalls.add(callJp.name);
+                changedFile = true;
+                if (isInclude) {
+                    addedIncludes.add(configFix);
+                }
+            }
+            else {
+                this.context.addRuleResult(this.ruleID, callJp, MISRATransformationType.NoChange);
+            }
+        }
+        return changedFile;
+    }
+    solveWithInclude(fileJp, callJp, includePath, originalIncludes, addedIncludes, callIndex) {
+        const errorMsgPrefix = this.getErrorMsgPrefix(callJp);
+        let success = false;
+        if (originalIncludes.has(includePath)) {
+            this.logMISRAError(callJp, `${errorMsgPrefix} Provided include \'${includePath}\' does not fix the violation.`);
+        }
+        else if (addedIncludes.has(includePath)) {
+            if (isValidFileWithExplicitCall(fileJp, callJp.name, callIndex)) {
+                success = true;
+            }
+            else {
+                this.logMISRAError(callJp, `${errorMsgPrefix} Provided include \'${includePath}\' does not fix the violation.`);
+            }
+        }
+        else {
+            fileJp.addInclude(includePath);
+            const fileCompiles = isValidFileWithExplicitCall(fileJp, callJp.name, callIndex);
+            if (fileCompiles) {
+                success = true;
+            }
+            else {
+                removeIncludeFromFile(includePath, fileJp);
+                this.logMISRAError(callJp, `${errorMsgPrefix} Provided include \'${includePath}\' does not fix the violation.`);
+            }
+        }
+        return success;
+    }
+    solveWithExtern(fileJp, callJp, functionLocation, callIndex) {
+        const errorMsgPrefix = this.getErrorMsgPrefix(callJp);
+        const functionDef = findFunctionDef(callJp.name, functionLocation);
+        let success = false;
+        if (!functionDef) {
+            this.logMISRAError(callJp, `${errorMsgPrefix} Provided file \'${functionLocation}\' does not have function definition.`);
+        }
+        else {
+            const externDecl = addExternFunctionDecl(fileJp, functionDef);
+            if (!externDecl) {
+                this.logMISRAError(callJp, `${errorMsgPrefix} Provided definition at \'${functionLocation}\' does not have external linkage.`);
+            }
+            else {
+                const fileCompiles = isValidFileWithExplicitCall(fileJp, callJp.name, callIndex, true);
+                if (fileCompiles) {
+                    success = true;
+                }
+                else {
+                    externDecl.detach();
+                    this.logMISRAError(callJp, `${errorMsgPrefix} Provided definition at \'${functionLocation}\' does not fix the violation.`);
+                }
+            }
+        }
+        return success;
+    }
+}
+//# sourceMappingURL=Rule_17_3_ImplicitFunction.js.map

package/dist/rules/Section17_Functions/Rule_17_3_ImplicitFunction.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"Rule_17_3_ImplicitFunction.js","sourceRoot":"","sources":["../../../src/rules/Section17_Functions/Rule_17_3_ImplicitFunction.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,IAAI,EAAqB,OAAO,EAAE,MAAM,qCAAqC,CAAC;AACvF,OAAO,EAAE,YAAY,EAAE,yBAAyB,EAAE,uBAAuB,EAAE,MAAM,gBAAgB,CAAC;AAClG,OAAO,EAAE,eAAe,EAAE,MAAM,8BAA8B,CAAC;AAC/D,OAAO,EAAE,YAAY,EAAE,wBAAwB,EAAE,MAAM,0BAA0B,CAAC;AAClF,OAAO,KAAK,MAAM,sCAAsC,CAAC;AACzD,OAAO,EAAE,qBAAqB,EAAE,kCAAkC,EAAE,iBAAiB,EAAE,2BAA2B,EAAE,qBAAqB,EAAE,MAAM,0BAA0B,CAAC;AAC5K,OAAO,oBAAoB,MAAM,4BAA4B,CAAC;AAE9D;;GAEG;AACH,MAAM,CAAC,OAAO,OAAO,0BAA2B,SAAQ,oBAAoB;IACxE;;OAEG;IACM,QAAQ,GAAG,CAAC,CAAC;IAEtB;;OAEG;IACM,YAAY,GAAG,YAAY,CAAC,uBAAuB,CAAC;IAE7D;;OAEG;IACyB,SAAS,GAAG,IAAI,GAAG,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC;IAEzD;;OAEG;IACH,IAAa,IAAI;QACb,OAAO,MAAM,CAAC;IAClB,CAAC;IAED;;;;;OAKG;IACH,iBAAiB,CAAC,MAAY;QAC1B,OAAO,aAAa,MAAM,CAAC,IAAI,2BAA2B,CAAC;IAC/D,CAAC;IAED;;;;;OAKG;IACH,gBAAgB,CAAC,MAAY;QACzB,MAAM,cAAc,GAAG,IAAI,CAAC,iBAAiB,CAAC,MAAM,CAAC,CAAC;QAEtD,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC;YACvB,IAAI,CAAC,aAAa,CAAC,MAAM,EAAE,GAAG,cAAc,0DAA0D,CAAC,CAAC;YACxG,OAAO,SAAS,CAAC;QACrB,CAAC;QAED,IAAI,SAA6B,CAAC;QAClC,IAAI,CAAC;YACD,SAAS,GAAG,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,GAAG,CAAC,eAAe,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;QACtE,CAAC;QAAC,MAAM,CAAC;YACL,IAAI,CAAC,aAAa,CAAC,MAAM,EAAE,GAAG,cAAc,iGAAiG,CAAC,CAAC;YAC/I,OAAO,SAAS,CAAC;QACrB,CAAC;QAED,IAAI,SAAS,KAAK,SAAS,EAAE,CAAC;YAC1B,IAAI,CAAC,aAAa,CAAC,MAAM,EAAE,GAAG,cAAc,8EAA8E,MAAM,CAAC,IAAI,IAAI,CAAC,CAAC;YAC3I,OAAO,SAAS,CAAC;QACrB,CAAC;QAED,IAAI,CAAC,CAAC,SAAS,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,SAAS,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,EAAE,CAAC;YAC1D,IAAI,CAAC,aAAa,CAAC,MAAM,EAAE,GAAG,cAAc,6DAA6D,CAAC,CAAC;YAC3G,OAAO,SAAS,CAAC;QACrB,CAAC;QACD,OAAO,SAAS,CAAC;IACrB,CAAC;IAED;;;;;;OAMG;IACH,KAAK,CAAC,GAAc,EAAE,YAAqB,KAAK;QAC5C,IAAI,CAAC,CAAC,GAAG,YAAY,OAAO,IAAI,IAAI,CAAC,wBAAwB,EAAE,CAAC;YAAE,OAAO,KAAK,CAAC;QAE/E,MAAM,aAAa,GAAG,KAAK,CAAC,UAAU,CAAC,GAAG,EAAE,IAAI,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,wBAAwB,CAAC,MAAM,CAAC,CAAC,CAAE,GAAG,EAAE,CAAC;QACvG,IAAI,SAAS,EAAE,CAAC;YACZ,KAAK,MAAM,MAAM,IAAI,aAAa,EAAE,CAAC;gBACjC,IAAI,CAAC,aAAa,CAAC,MAAM,EAAE,IAAI,CAAC,iBAAiB,CAAC,MAAM,CAAC,CAAC,CAAC;YAC/D,CAAC;QACL,CAAC;QAED,OAAO,aAAa,CAAC,MAAM,GAAG,CAAC,CAAC;IACpC,CAAC;IAED;;;;;;;;;OASG;IACH,KAAK,CAAC,GAAc;QAChB,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC;YAChB,OAAO,IAAI,yBAAyB,CAAC,uBAAuB,CAAC,QAAQ,CAAC,CAAC;QAE3E,MAAM,qBAAqB,GAAG,kCAAkC,CAAC,GAAc,CAAC,CAAC;QACjF,IAAI,iBAAiB,GAAG,KAAK,CAAC;QAE9B,KAAK,MAAM,MAAM,IAAI,qBAAqB,EAAE,CAAC;YACzC,IAAI,IAAI,CAAC,kBAAkB,CAAC,MAAM,CAAC,EAAE,CAAC;gBAClC,iBAAiB,GAAG,IAAI,CAAC;YAC7B,CAAC;QACL,CAAC;QAED,IAAI,iBAAiB,EAAE,CAAC;YACpB,IAAI,CAAC,cAAc,EAAE,CAAC;YACtB,OAAO,IAAI,yBAAyB,CAAC,uBAAuB,CAAC,WAAW,EAAE,KAAK,CAAC,IAAI,EAAa,CAAC,CAAC;QACvG,CAAC;aAAM,CAAC;YACJ,OAAO,IAAI,yBAAyB,CAAC,uBAAuB,CAAC,QAAQ,CAAC,CAAC;QAC3E,CAAC;IACL,CAAC;IAED;;;;OAIG;IACK,kBAAkB,CAAC,MAAc;QACrC,MAAM,aAAa,GAAG,KAAK,CAAC,UAAU,CAAC,MAAM,EAAE,IAAI,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC,wBAAwB,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,GAAG,EAAE,CAAC;QAC3G,MAAM,gBAAgB,GAAG,iBAAiB,CAAC,MAAM,CAAC,CAAC;QACnD,IAAI,WAAW,GAAG,IAAI,GAAG,EAAU,CAAC;QACpC,IAAI,aAAa,GAAG,IAAI,GAAG,EAAU,CAAC;QACtC,IAAI,WAAW,GAAG,KAAK,CAAC;QAExB,KAAK,MAAM,MAAM,IAAI,aAAa,EAAE,CAAC;YACjC,IAAI,IAAI,CAAC,OAAO,CAAC,aAAa,CAAC,IAAI,CAAC,MAAM,EAAE,MAAM,CAAC,KAAK,uBAAuB,CAAC,QAAQ,EAAE,CAAC;gBACvF,SAAS;YACb,CAAC;YAED,IAAI,WAAW,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC;gBAC/B,SAAS;YACb,CAAC;YAED,MAAM,SAAS,GAAG,IAAI,CAAC,gBAAgB,CAAC,MAAM,CAAC,CAAC;YAChD,IAAI,SAAS,KAAK,SAAS,EAAE,CAAC;gBAC1B,IAAI,CAAC,OAAO,CAAC,aAAa,CAAC,IAAI,CAAC,MAAM,EAAE,MAAM,EAAE,uBAAuB,CAAC,QAAQ,CAAC,CAAC;gBAClF,SAAS;YACb,CAAC;YAED,MAAM,SAAS,GAAG,YAAY,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;YAC/C,MAAM,SAAS,GAAG,SAAS,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;YAC3C,MAAM,OAAO,GAAG,SAAS,CAAC,CAAC;gBACvB,IAAI,CAAC,gBAAgB,CAAC,MAAM,EAAE,MAAM,EAAE,SAAS,EAAE,gBAAgB,EAAE,aAAa,EAAE,SAAS,CAAC,CAAC,CAAC;gBAC9F,IAAI,CAAC,eAAe,CAAC,MAAM,EAAE,MAAM,EAAE,SAAS,EAAE,SAAS,CAAC,CAAC;YAE/D,IAAI,OAAO,EAAE,CAAC;gBACV,WAAW,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;gBAC7B,WAAW,GAAG,IAAI,CAAC;gBACnB,IAAI,SAAS,EAAE,CAAC;oBACZ,aAAa,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;gBACjC,CAAC;YACL,CAAC;iBAAM,CAAC;gBACJ,IAAI,CAAC,OAAO,CAAC,aAAa,CAAC,IAAI,CAAC,MAAM,EAAE,MAAM,EAAE,uBAAuB,CAAC,QAAQ,CAAC,CAAC;YACtF,CAAC;QACL,CAAC;QACD,OAAO,WAAW,CAAC;IACvB,CAAC;IAEO,gBAAgB,CAAC,MAAc,EAAE,MAAY,EAAE,WAAmB,EAAE,gBAA6B,EAAE,aAA0B,EAAE,SAAiB;QACpJ,MAAM,cAAc,GAAG,IAAI,CAAC,iBAAiB,CAAC,MAAM,CAAC,CAAC;QACtD,IAAI,OAAO,GAAG,KAAK,CAAC;QAEpB,IAAI,gBAAgB,CAAC,GAAG,CAAC,WAAW,CAAC,EAAE,CAAC;YACpC,IAAI,CAAC,aAAa,CAAC,MAAM,EAAE,GAAG,cAAc,uBAAuB,WAAW,gCAAgC,CAAC,CAAC;QACpH,CAAC;aACI,IAAI,aAAa,CAAC,GAAG,CAAC,WAAW,CAAC,EAAE,CAAC;YAEtC,IAAI,2BAA2B,CAAC,MAAM,EAAE,MAAM,CAAC,IAAI,EAAE,SAAS,CAAC,EAAE,CAAC;gBAC9D,OAAO,GAAG,IAAI,CAAC;YACnB,CAAC;iBAAM,CAAC;gBACJ,IAAI,CAAC,aAAa,CAAC,MAAM,EAAE,GAAG,cAAc,uBAAuB,WAAW,gCAAgC,CAAC,CAAC;YACpH,CAAC;QACL,CAAC;aACI,CAAC;YACF,MAAM,CAAC,UAAU,CAAC,WAAW,CAAC,CAAC;YAC/B,MAAM,YAAY,GAAG,2BAA2B,CAAC,MAAM,EAAE,MAAM,CAAC,IAAI,EAAE,SAAS,CAAC,CAAC;YAEjF,IAAI,YAAY,EAAE,CAAC;gBACf,OAAO,GAAG,IAAI,CAAC;YACnB,CAAC;iBAAM,CAAC;gBACJ,qBAAqB,CAAC,WAAW,EAAE,MAAM,CAAC,CAAC;gBAC3C,IAAI,CAAC,aAAa,CAAC,MAAM,EAAE,GAAG,cAAc,uBAAuB,WAAW,gCAAgC,CAAC,CAAC;YACpH,CAAC;QACL,CAAC;QACD,OAAO,OAAO,CAAC;IACnB,CAAC;IAEO,eAAe,CAAC,MAAc,EAAE,MAAY,EAAE,gBAAwB,EAAE,SAAiB;QAC7F,MAAM,cAAc,GAAG,IAAI,CAAC,iBAAiB,CAAC,MAAM,CAAC,CAAC;QACtD,MAAM,WAAW,GAAG,eAAe,CAAC,MAAM,CAAC,IAAI,EAAE,gBAAgB,CAAC,CAAC;QACnE,IAAI,OAAO,GAAG,KAAK,CAAC;QAEpB,IAAI,CAAC,WAAW,EAAE,CAAC;YACf,IAAI,CAAC,aAAa,CAAC,MAAM,EAAE,GAAG,cAAc,oBAAoB,gBAAgB,uCAAuC,CAAC,CAAC;QAC7H,CAAC;aAAM,CAAC;YACJ,MAAM,UAAU,GAAG,qBAAqB,CAAC,MAAM,EAAE,WAAW,CAAC,CAAC;YAE9D,IAAI,CAAC,UAAU,EAAE,CAAC;gBACd,IAAI,CAAC,aAAa,CAAC,MAAM,EAAE,GAAG,cAAc,6BAA6B,gBAAgB,oCAAoC,CAAC,CAAC;YACnI,CAAC;iBAAM,CAAC;gBACJ,MAAM,YAAY,GAAG,2BAA2B,CAAC,MAAM,EAAE,MAAM,CAAC,IAAI,EAAE,SAAS,EAAE,IAAI,CAAC,CAAC;gBACvF,IAAI,YAAY,EAAE,CAAC;oBACf,OAAO,GAAG,IAAI,CAAC;gBACnB,CAAC;qBAAM,CAAC;oBACJ,UAAU,CAAC,MAAM,EAAE,CAAC;oBACpB,IAAI,CAAC,aAAa,CAAC,MAAM,EAAE,GAAG,cAAc,6BAA6B,gBAAgB,gCAAgC,CAAC,CAAC;gBAC/H,CAAC;YACL,CAAC;QACL,CAAC;QACD,OAAO,OAAO,CAAC;IACnB,CAAC;CACJ"}

package/dist/rules/Section17_Functions/Rule_17_4_NonVoidReturn.d.ts

@@ -1,15 +1,20 @@
-import { Joinpoint } from "@specs-feup/clava/api/Joinpoints.js";
-import MISRARule from "../../MISRARule.js";
-import MISRAContext from "../../MISRAContext.js";
-import { MISRATransformationReport } from "../../MISRA.js";
+import { FunctionJp, Joinpoint } from "@specs-feup/clava/api/Joinpoints.js";
+import { AnalysisType, MISRATransformationReport } from "../../MISRA.js";
+import UserConfigurableRule from "../UserConfigurableRule.js";
 /**
- * MISRA Rule 17.4: All exit paths from a function with non-void return type shall have an
-explicit return statement with an expression. In a non-void function:
-- Every return statement has an expression, and a
-- Control cannot reach the end of the function without encountering a return statement
+* MISRA-C Rule 17.4: All exit paths from a function with non-void return type shall have an explicit return statement with an expression. In a non-void function:
+*   - Every return statement has an expression, and
+*   - Control cannot reach the end of the function without encountering a return statement
  */
-export default class Rule_17_4_NonVoidReturn extends MISRARule {
-    constructor(context: MISRAContext);
+export default class Rule_17_4_NonVoidReturn extends UserConfigurableRule {
+    /**
+     * Scope of analysis
+     */
+    readonly analysisType = AnalysisType.SINGLE_TRANSLATION_UNIT;
+    /**
+     * @returns Rule identifier according to MISRA-C:2012
+     */
+    get name(): string;
     /**
      * Checks if the given joinpoint represents a non-void function that lacks an explicit return statement with an expression.
      *
@@ -18,14 +23,34 @@ export default class Rule_17_4_NonVoidReturn extends MISRARule {
      * @returns Returns true if the joinpoint violates the rule, false otherwise
      */
     match($jp: Joinpoint, logErrors?: boolean): boolean;
+    /**
+     * Performs a depth.first search on the function's control flow graph (CFG) to check if all exit paths in the function have a return statement
+     *
+     * @param functionJp  The function to analyze
+     * @returns Returns true if all exit paths in the function have an explicit return statement, otherwise returns false.
+     */
+    private allControlPathsReturn;
     /**
      * Transforms a non-void function joinpoint that has no return statement at the end, by adding a default return value based on the config file.
-     * - If the configuration file is is missing or invalid, no transformation is performed.
+     * - If the configuration file is missing/invalid or the specified default value is invalid, no transformation is performed and the function is left unchanged.
      * - Otherwise, a return statement is inserted as the last statement of the function.
      *
      * @param $jp - Joinpoint to transform
      * @returns Report detailing the transformation result
      */
-    transform($jp: Joinpoint): MISRATransformationReport;
+    apply($jp: Joinpoint): MISRATransformationReport;
+    /**
+     * Returns the prefix to be used for error messages related to the given joinpoint
+     *
+     * @param $jp - Joinpoint where the violation was detected
+     * @returns Returns a prefix to prepend to error messages if no configuration is specified or if the configuration does not contain a fix for this violation
+     */
+    getErrorMsgPrefix(functionJp: FunctionJp): string;
+    /**
+     * Retrieves a fix for the given joinpoint using the provided configuration file
+     * @param $jp - Joinpoint where the violation was detected
+     * @return The fix retrieved from the configuration for the violation, or `undefined` if no applicable fix is found.
+     */
+    getFixFromConfig(functionJp: FunctionJp): string | undefined;
 }
 //# sourceMappingURL=Rule_17_4_NonVoidReturn.d.ts.map

package/dist/rules/Section17_Functions/Rule_17_4_NonVoidReturn.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"Rule_17_4_NonVoidReturn.d.ts","sourceRoot":"","sources":["../../../src/rules/Section17_Functions/Rule_17_4_NonVoidReturn.ts"],"names":[],"mappings":"AAAA,OAAO,EAAqD,SAAS,EAAc,MAAM,qCAAqC,CAAC;AAC/H,OAAO,SAAS,MAAM,oBAAoB,CAAC;AAC3C,OAAO,YAAY,MAAM,uBAAuB,CAAC;AAEjD,OAAO,EAAE,yBAAyB,EAA2B,MAAM,gBAAgB,CAAC;AAGpF;;;;;GAKG;AACH,MAAM,CAAC,OAAO,OAAO,uBAAwB,SAAQ,SAAS;gBAC9C,OAAO,EAAE,YAAY;IAIjC;;;;;;OAMG;IACH,KAAK,CAAC,GAAG,EAAE,SAAS,EAAE,SAAS,GAAE,OAAe,GAAG,OAAO;IAkB1D;;;;;;;OAOG;IACH,SAAS,CAAC,GAAG,EAAE,SAAS,GAAG,yBAAyB;CA0BvD"}
+{"version":3,"file":"Rule_17_4_NonVoidReturn.d.ts","sourceRoot":"","sources":["../../../src/rules/Section17_Functions/Rule_17_4_NonVoidReturn.ts"],"names":[],"mappings":"AAAA,OAAO,EAA6B,UAAU,EAAE,SAAS,EAAc,MAAM,qCAAqC,CAAC;AAEnH,OAAO,EAAE,YAAY,EAAE,yBAAyB,EAA2B,MAAM,gBAAgB,CAAC;AAElG,OAAO,oBAAoB,MAAM,4BAA4B,CAAC;AAQ9D;;;;GAIG;AACH,MAAM,CAAC,OAAO,OAAO,uBAAwB,SAAQ,oBAAoB;IACrE;;OAEG;IACH,QAAQ,CAAC,YAAY,wCAAwC;IAE7D;;OAEG;IACH,IAAa,IAAI,IAAI,MAAM,CAE1B;IAED;;;;;;OAMG;IACH,KAAK,CAAC,GAAG,EAAE,SAAS,EAAE,SAAS,GAAE,OAAe,GAAG,OAAO;IAa1D;;;;;OAKG;IACH,OAAO,CAAC,qBAAqB;IA2B7B;;;;;;;OAOG;IACH,KAAK,CAAC,GAAG,EAAE,SAAS,GAAG,yBAAyB;IAgChD;;;;;OAKG;IACH,iBAAiB,CAAC,UAAU,EAAE,UAAU,GAAG,MAAM;IAIjD;;;;OAIG;IACH,gBAAgB,CAAC,UAAU,EAAE,UAAU,GAAG,MAAM,GAAG,SAAS;CAsB/D"}

package/dist/rules/Section17_Functions/Rule_17_4_NonVoidReturn.js

@@ -1,17 +1,29 @@
-import { BuiltinType, FunctionJp, ReturnStmt } from "@specs-feup/clava/api/Joinpoints.js";
-import MISRARule from "../../MISRARule.js";
+import { Body, BuiltinType, FunctionJp, ReturnStmt } from "@specs-feup/clava/api/Joinpoints.js";
 import ClavaJoinPoints from "@specs-feup/clava/api/clava/ClavaJoinPoints.js";
-import { MISRATransformationReport, MISRATransformationType } from "../../MISRA.js";
-import Query from "@specs-feup/lara/api/weaver/Query.js";
+import { AnalysisType, MISRATransformationReport, MISRATransformationType } from "../../MISRA.js";
+import { isValidFile } from "../../utils/FileUtils.js";
+import UserConfigurableRule from "../UserConfigurableRule.js";
+import ClavaNode from "@specs-feup/clava-flow/ClavaNode";
+import ReturnNode from "@specs-feup/clava-flow/cfg/node/ReturnNode";
+import ClavaCfgGenerator from "@specs-feup/clava-flow/transformation/ClavaCfgGenerator";
+import BaseNode from "@specs-feup/flow/graph/BaseNode";
+import Graph from "@specs-feup/flow/graph/Graph";
+import ControlFlowEdge from "@specs-feup/flow/flow/ControlFlowEdge";
 /**
- * MISRA Rule 17.4: All exit paths from a function with non-void return type shall have an
-explicit return statement with an expression. In a non-void function:
-- Every return statement has an expression, and a
-- Control cannot reach the end of the function without encountering a return statement
+* MISRA-C Rule 17.4: All exit paths from a function with non-void return type shall have an explicit return statement with an expression. In a non-void function:
+*   - Every return statement has an expression, and
+*   - Control cannot reach the end of the function without encountering a return statement
  */
-export default class Rule_17_4_NonVoidReturn extends MISRARule {
-    constructor(context) {
-        super("17.4", context);
+export default class Rule_17_4_NonVoidReturn extends UserConfigurableRule {
+    /**
+     * Scope of analysis
+     */
+    analysisType = AnalysisType.SINGLE_TRANSLATION_UNIT;
+    /**
+     * @returns Rule identifier according to MISRA-C:2012
+     */
+    get name() {
+        return "17.4";
     }
     /**
      * Checks if the given joinpoint represents a non-void function that lacks an explicit return statement with an expression.
@@ -25,47 +37,108 @@ export default class Rule_17_4_NonVoidReturn extends MISRARule {
             return false;
         if ($jp.returnType instanceof BuiltinType && $jp.returnType.isVoid)
             return false;
-        const emptyReturnStms = Query.searchFrom($jp, ReturnStmt, { returnExpr: undefined }).get();
-        const exitReturn = $jp.body.children.filter(child => child instanceof ReturnStmt && !emptyReturnStms.includes(child))[0];
-        if (logErrors) {
-            emptyReturnStms?.forEach(emptyReturn => this.logMISRAError(emptyReturn, "Every return statement in a non-void function must include an expression."));
-            if (exitReturn === undefined) {
-                this.logMISRAError($jp, `Function '${$jp.name}' reaches the end without a return statement.`);
-            }
+        if ($jp.body.children.some(childJp => childJp instanceof ReturnStmt))
+            return false;
+        const nonCompliant = !this.allControlPathsReturn($jp);
+        if (logErrors && nonCompliant) {
+            this.logMISRAError($jp, `Function '${$jp.name}' reaches the end without a return statement.`);
+        }
+        return nonCompliant;
+    }
+    /**
+     * Performs a depth.first search on the function's control flow graph (CFG) to check if all exit paths in the function have a return statement
+     *
+     * @param functionJp  The function to analyze
+     * @returns Returns true if all exit paths in the function have an explicit return statement, otherwise returns false.
+     */
+    allControlPathsReturn(functionJp) {
+        // Generate control flow graph 
+        const cfg = Graph.create().apply(new ClavaCfgGenerator(functionJp));
+        const startNode = cfg.nodes.filterIs(ClavaNode).filter(node => node.jp instanceof Body)[0];
+        cfg.edges.filter(edge => edge.is(ControlFlowEdge) && edge.as(ControlFlowEdge).isFake).forEach((edge) => {
+            edge.remove();
+        });
+        const stack = [startNode];
+        const visited = new Set();
+        while (stack.length > 0) {
+            const node = stack.pop();
+            if (visited.has(node) || node?.is(ReturnNode))
+                continue;
+            let children = Array.from(node.outgoers).map(edge => edge.target);
+            if (!children || children.length === 0)
+                return false; // Reached the end of the graph without finding a single return statement
+            children = children.filter(child => !visited.has(child));
+            children.forEach(child => stack.push(child.as(BaseNode)));
         }
-        return emptyReturnStms.length > 0 || exitReturn === undefined;
+        return true;
     }
     /**
      * Transforms a non-void function joinpoint that has no return statement at the end, by adding a default return value based on the config file.
-     * - If the configuration file is is missing or invalid, no transformation is performed.
+     * - If the configuration file is missing/invalid or the specified default value is invalid, no transformation is performed and the function is left unchanged.
      * - Otherwise, a return statement is inserted as the last statement of the function.
      *
      * @param $jp - Joinpoint to transform
      * @returns Report detailing the transformation result
      */
-    transform($jp) {
-        if (!this.match($jp))
+    apply($jp) {
+        const previousResult = $jp instanceof FunctionJp ? this.context.getRuleResult(this.ruleID, $jp) : undefined;
+        if (previousResult === MISRATransformationType.NoChange || !this.match($jp)) {
             return new MISRATransformationReport(MISRATransformationType.NoChange);
+        }
         const functionJp = $jp;
-        if (this.context.config) {
-            try {
-                const returnType = functionJp.type.code;
-                const defaultValueReturn = this.context.config.get("defaultValues")[returnType];
-                if (defaultValueReturn === undefined) {
-                    this.logMISRAError($jp, `Function '${functionJp.name}' reaches the end without a return statement. Default value return not added due to missing default value configuration for type '${returnType}'.`);
-                    return new MISRATransformationReport(MISRATransformationType.NoChange);
-                }
-                const newJp = ClavaJoinPoints.returnStmt(ClavaJoinPoints.exprLiteral(String(defaultValueReturn), functionJp.returnType));
-                functionJp.body.lastChild ? functionJp.body.lastChild.insertAfter(newJp) : functionJp.body.setFirstChild(newJp);
-                return new MISRATransformationReport(MISRATransformationType.DescendantChange);
-            }
-            catch (error) {
-                this.logMISRAError($jp, `Function '${functionJp.name}' reaches the end without a return statement. Default value return not added due to invalid structure of configuration file.`);
-                return new MISRATransformationReport(MISRATransformationType.NoChange);
-            }
+        const fileJp = functionJp.getAncestor("file");
+        const errorMsgPrefix = this.getErrorMsgPrefix(functionJp);
+        const defaultValueReturn = this.getFixFromConfig(functionJp);
+        if (defaultValueReturn === undefined) {
+            this.context.addRuleResult(this.ruleID, $jp, MISRATransformationType.NoChange);
+            return new MISRATransformationReport(MISRATransformationType.NoChange);
         }
-        this.logMISRAError($jp, `Function '${functionJp.name}' reaches the end without a return statement. Default value return not added due to missing config file.`);
+        // Insert return statement and validate it
+        const returnStmt = ClavaJoinPoints.returnStmt(ClavaJoinPoints.exprLiteral(String(defaultValueReturn), functionJp.returnType));
+        functionJp.body.lastChild ? functionJp.body.lastChild.insertAfter(returnStmt) : functionJp.body.setFirstChild(returnStmt);
+        // Validate the provided default value
+        if (isValidFile(fileJp)) {
+            return new MISRATransformationReport(MISRATransformationType.DescendantChange);
+        }
+        // If the default value is invalid, the return stmt is removed
+        returnStmt.detach();
+        this.logMISRAError($jp, `${errorMsgPrefix} Provided default value for type '${functionJp.type.code}' is invalid and was therefore not inserted.`);
+        this.context.addRuleResult(this.ruleID, $jp, MISRATransformationType.NoChange);
         return new MISRATransformationReport(MISRATransformationType.NoChange);
     }
+    /**
+     * Returns the prefix to be used for error messages related to the given joinpoint
+     *
+     * @param $jp - Joinpoint where the violation was detected
+     * @returns Returns a prefix to prepend to error messages if no configuration is specified or if the configuration does not contain a fix for this violation
+     */
+    getErrorMsgPrefix(functionJp) {
+        return `Function '${functionJp.name}' reaches the end without a return statement.`;
+    }
+    /**
+     * Retrieves a fix for the given joinpoint using the provided configuration file
+     * @param $jp - Joinpoint where the violation was detected
+     * @return The fix retrieved from the configuration for the violation, or `undefined` if no applicable fix is found.
+     */
+    getFixFromConfig(functionJp) {
+        const errorMsgPrefix = this.getErrorMsgPrefix(functionJp);
+        if (!this.context.config) {
+            this.logMISRAError(functionJp, `${errorMsgPrefix} Default value return not added due to missing config file.`);
+            return undefined;
+        }
+        let defaultValueReturn = undefined;
+        const returnType = functionJp.type.code;
+        try {
+            defaultValueReturn = this.context.config.get("defaultValues")[returnType];
+        }
+        catch (error) {
+            this.logMISRAError(functionJp, `${errorMsgPrefix} Default value return was not added as \'defaultValues\' is not defined in the configuration file.`);
+            return undefined;
+        }
+        if (defaultValueReturn === undefined) {
+            this.logMISRAError(functionJp, `${errorMsgPrefix} Default value return not added due to missing default value configuration for type '${returnType}'.`);
+        }
+        return defaultValueReturn;
+    }
 }
 //# sourceMappingURL=Rule_17_4_NonVoidReturn.js.map

package/dist/rules/Section17_Functions/Rule_17_4_NonVoidReturn.js.map

@@ -1 +1 @@
-{"version":3,"file":"Rule_17_4_NonVoidReturn.js","sourceRoot":"","sources":["../../../src/rules/Section17_Functions/Rule_17_4_NonVoidReturn.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,WAAW,EAA4B,UAAU,EAAa,UAAU,EAAE,MAAM,qCAAqC,CAAC;AAC/H,OAAO,SAAS,MAAM,oBAAoB,CAAC;AAE3C,OAAO,eAAe,MAAM,gDAAgD,CAAC;AAC7E,OAAO,EAAE,yBAAyB,EAAE,uBAAuB,EAAE,MAAM,gBAAgB,CAAC;AACpF,OAAO,KAAK,MAAM,sCAAsC,CAAC;AAEzD;;;;;GAKG;AACH,MAAM,CAAC,OAAO,OAAO,uBAAwB,SAAQ,SAAS;IAC1D,YAAY,OAAqB;QAC7B,KAAK,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;IAC3B,CAAC;IAED;;;;;;OAMG;IACH,KAAK,CAAC,GAAc,EAAE,YAAqB,KAAK;QAC5C,IAAI,CAAC,CAAC,GAAG,YAAY,UAAU,IAAI,GAAG,CAAC,gBAAgB,CAAC;YAAE,OAAO,KAAK,CAAC;QAEvE,IAAI,GAAG,CAAC,UAAU,YAAY,WAAW,IAAI,GAAG,CAAC,UAAU,CAAC,MAAM;YAAE,OAAO,KAAK,CAAC;QAEjF,MAAM,eAAe,GAAG,KAAK,CAAC,UAAU,CAAC,GAAG,EAAE,UAAU,EAAE,EAAC,UAAU,EAAE,SAAS,EAAC,CAAC,CAAC,GAAG,EAAE,CAAC;QACzF,MAAM,UAAU,GAAG,GAAG,CAAC,IAAI,CAAC,QAAQ,CAAC,MAAM,CAAC,KAAK,CAAC,EAAE,CAAC,KAAK,YAAY,UAAU,IAAI,CAAC,eAAe,CAAC,QAAQ,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;QACzH,IAAI,SAAS,EAAE,CAAC;YACZ,eAAe,EAAE,OAAO,CAAC,WAAW,CAAC,EAAE,CACnC,IAAI,CAAC,aAAa,CAAC,WAAW,EAAE,2EAA2E,CAAC,CAC/G,CAAA;YACD,IAAI,UAAU,KAAK,SAAS,EAAE,CAAC;gBAC3B,IAAI,CAAC,aAAa,CAAC,GAAG,EAAE,aAAa,GAAG,CAAC,IAAI,+CAA+C,CAAC,CAAA;YACjG,CAAC;QACL,CAAC;QACD,OAAO,eAAe,CAAC,MAAM,GAAG,CAAC,IAAI,UAAU,KAAK,SAAS,CAAC;IAClE,CAAC;IAED;;;;;;;OAOG;IACH,SAAS,CAAC,GAAc;QACpB,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC;YAAE,OAAO,IAAI,yBAAyB,CAAC,uBAAuB,CAAC,QAAQ,CAAC,CAAC;QAE7F,MAAM,UAAU,GAAG,GAAiB,CAAC;QACrC,IAAI,IAAI,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC;YACtB,IAAI,CAAC;gBACD,MAAM,UAAU,GAAG,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC;gBACxC,MAAM,kBAAkB,GAAG,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,GAAG,CAAC,eAAe,CAAC,CAAC,UAAU,CAAC,CAAC;gBAEhF,IAAI,kBAAkB,KAAK,SAAS,EAAE,CAAC;oBACnC,IAAI,CAAC,aAAa,CAAC,GAAG,EAAE,aAAa,UAAU,CAAC,IAAI,qIAAqI,UAAU,IAAI,CAAC,CAAC;oBACzM,OAAO,IAAI,yBAAyB,CAAC,uBAAuB,CAAC,QAAQ,CAAC,CAAC;gBAC3E,CAAC;gBACD,MAAM,KAAK,GAAG,eAAe,CAAC,UAAU,CAAC,eAAe,CAAC,WAAW,CAAC,MAAM,CAAC,kBAAkB,CAAC,EAAE,UAAU,CAAC,UAAU,CAAC,CAAe,CAAC;gBACvI,UAAU,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,SAAS,CAAC,WAAW,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,aAAa,CAAC,KAAK,CAAC,CAAC;gBAEhH,OAAO,IAAI,yBAAyB,CAAC,uBAAuB,CAAC,gBAAgB,CAAC,CAAC;YAEnF,CAAC;YAAC,OAAO,KAAK,EAAE,CAAC;gBACb,IAAI,CAAC,aAAa,CAAC,GAAG,EAAE,aAAa,UAAU,CAAC,IAAI,8HAA8H,CAAC,CAAC;gBACpL,OAAO,IAAI,yBAAyB,CAAC,uBAAuB,CAAC,QAAQ,CAAC,CAAC;YAC3E,CAAC;QACL,CAAC;QACD,IAAI,CAAC,aAAa,CAAC,GAAG,EAAE,aAAa,UAAU,CAAC,IAAI,0GAA0G,CAAC,CAAA;QAC/J,OAAO,IAAI,yBAAyB,CAAC,uBAAuB,CAAC,QAAQ,CAAC,CAAC;IAC3E,CAAC;CACJ"}
+{"version":3,"file":"Rule_17_4_NonVoidReturn.js","sourceRoot":"","sources":["../../../src/rules/Section17_Functions/Rule_17_4_NonVoidReturn.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,IAAI,EAAE,WAAW,EAAU,UAAU,EAAa,UAAU,EAAE,MAAM,qCAAqC,CAAC;AACnH,OAAO,eAAe,MAAM,gDAAgD,CAAC;AAC7E,OAAO,EAAE,YAAY,EAAE,yBAAyB,EAAE,uBAAuB,EAAE,MAAM,gBAAgB,CAAC;AAClG,OAAO,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAC;AACvD,OAAO,oBAAoB,MAAM,4BAA4B,CAAC;AAC9D,OAAO,SAAS,MAAM,kCAAkC,CAAC;AACzD,OAAO,UAAU,MAAM,4CAA4C,CAAC;AACpE,OAAO,iBAAiB,MAAM,yDAAyD,CAAC;AACxF,OAAO,QAAQ,MAAM,iCAAiC,CAAC;AACvD,OAAO,KAAK,MAAM,8BAA8B,CAAC;AACjD,OAAO,eAAe,MAAM,uCAAuC,CAAC;AAEpE;;;;GAIG;AACH,MAAM,CAAC,OAAO,OAAO,uBAAwB,SAAQ,oBAAoB;IACrE;;OAEG;IACM,YAAY,GAAG,YAAY,CAAC,uBAAuB,CAAC;IAE7D;;OAEG;IACH,IAAa,IAAI;QACb,OAAO,MAAM,CAAC;IAClB,CAAC;IAED;;;;;;OAMG;IACH,KAAK,CAAC,GAAc,EAAE,YAAqB,KAAK;QAC5C,IAAI,CAAC,CAAC,GAAG,YAAY,UAAU,IAAI,GAAG,CAAC,gBAAgB,CAAC;YAAE,OAAO,KAAK,CAAC;QACvE,IAAI,GAAG,CAAC,UAAU,YAAY,WAAW,IAAI,GAAG,CAAC,UAAU,CAAC,MAAM;YAAE,OAAO,KAAK,CAAC;QACjF,IAAI,GAAG,CAAC,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,OAAO,CAAC,EAAE,CAAC,OAAO,YAAY,UAAU,CAAC;YAAE,OAAO,KAAK,CAAC;QAEnF,MAAM,YAAY,GAAG,CAAC,IAAI,CAAC,qBAAqB,CAAC,GAAG,CAAC,CAAC;QAEtD,IAAI,SAAS,IAAI,YAAY,EAAE,CAAC;YAC5B,IAAI,CAAC,aAAa,CAAC,GAAG,EAAE,aAAa,GAAG,CAAC,IAAI,+CAA+C,CAAC,CAAA;QACjG,CAAC;QACD,OAAO,YAAY,CAAC;IACxB,CAAC;IAED;;;;;OAKG;IACK,qBAAqB,CAAC,UAAsB;QAChD,+BAA+B;QAC/B,MAAM,GAAG,GAAG,KAAK,CAAC,MAAM,EAAE,CAAC,KAAK,CAAC,IAAI,iBAAiB,CAAC,UAAU,CAAC,CAAC,CAAC;QACpE,MAAM,SAAS,GAAmB,GAAG,CAAC,KAAK,CAAC,QAAQ,CAAC,SAAS,CAAC,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,CAAC,EAAE,YAAY,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC;QAC3G,GAAG,CAAC,KAAK,CAAC,MAAM,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC,eAAe,CAAC,IAAI,IAAI,CAAC,EAAE,CAAC,eAAe,CAAC,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE;YACnG,IAAI,CAAC,MAAM,EAAE,CAAC;QAClB,CAAC,CAAC,CAAA;QAEF,MAAM,KAAK,GAAG,CAAC,SAAS,CAAC,CAAC;QAC1B,MAAM,OAAO,GAAG,IAAI,GAAG,EAAE,CAAC;QAE1B,OAAO,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACtB,MAAM,IAAI,GAAG,KAAK,CAAC,GAAG,EAAG,CAAC;YAE1B,IAAI,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,IAAI,EAAE,EAAE,CAAC,UAAU,CAAC;gBACzC,SAAS;YAEb,IAAI,QAAQ,GAAG,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;YAClE,IAAI,CAAC,QAAQ,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC;gBAClC,OAAO,KAAK,CAAC,CAAC,yEAAyE;YAE3F,QAAQ,GAAG,QAAQ,CAAC,MAAM,CAAC,KAAK,CAAC,EAAE,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC,CAAC;YACzD,QAAQ,CAAC,OAAO,CAAC,KAAK,CAAC,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,EAAE,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC;QAC9D,CAAC;QACD,OAAO,IAAI,CAAC;IAChB,CAAC;IAED;;;;;;;OAOG;IACH,KAAK,CAAC,GAAc;QAChB,MAAM,cAAc,GAAG,GAAG,YAAY,UAAU,CAAC,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,aAAa,CAAC,IAAI,CAAC,MAAM,EAAE,GAAG,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC;QAC5G,IAAI,cAAc,KAAK,uBAAuB,CAAC,QAAQ,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,EAAE,CAAC;YAC1E,OAAO,IAAI,yBAAyB,CAAC,uBAAuB,CAAC,QAAQ,CAAC,CAAC;QAC3E,CAAC;QAED,MAAM,UAAU,GAAG,GAAiB,CAAC;QACrC,MAAM,MAAM,GAAG,UAAU,CAAC,WAAW,CAAC,MAAM,CAAW,CAAC;QACxD,MAAM,cAAc,GAAG,IAAI,CAAC,iBAAiB,CAAC,UAAU,CAAC,CAAC;QAE1D,MAAM,kBAAkB,GAAG,IAAI,CAAC,gBAAgB,CAAC,UAAU,CAAC,CAAC;QAC7D,IAAI,kBAAkB,KAAK,SAAS,EAAE,CAAC;YACnC,IAAI,CAAC,OAAO,CAAC,aAAa,CAAC,IAAI,CAAC,MAAM,EAAE,GAAG,EAAE,uBAAuB,CAAC,QAAQ,CAAC,CAAC;YAC/E,OAAO,IAAI,yBAAyB,CAAC,uBAAuB,CAAC,QAAQ,CAAC,CAAC;QAC3E,CAAC;QAED,0CAA0C;QAC1C,MAAM,UAAU,GAAG,eAAe,CAAC,UAAU,CAAC,eAAe,CAAC,WAAW,CAAC,MAAM,CAAC,kBAAkB,CAAC,EAAE,UAAU,CAAC,UAAU,CAAC,CAAe,CAAC;QAC5I,UAAU,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,SAAS,CAAC,WAAW,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,aAAa,CAAC,UAAU,CAAC,CAAC;QAE1H,sCAAsC;QACtC,IAAI,WAAW,CAAC,MAAM,CAAC,EAAE,CAAC;YACtB,OAAO,IAAI,yBAAyB,CAAC,uBAAuB,CAAC,gBAAgB,CAAC,CAAC;QACnF,CAAC;QAED,8DAA8D;QAC9D,UAAU,CAAC,MAAM,EAAE,CAAC;QACpB,IAAI,CAAC,aAAa,CAAC,GAAG,EAAE,GAAG,cAAc,qCAAqC,UAAU,CAAC,IAAI,CAAC,IAAI,8CAA8C,CAAC,CAAC;QAClJ,IAAI,CAAC,OAAO,CAAC,aAAa,CAAC,IAAI,CAAC,MAAM,EAAE,GAAG,EAAE,uBAAuB,CAAC,QAAQ,CAAC,CAAC;QAC/E,OAAO,IAAI,yBAAyB,CAAC,uBAAuB,CAAC,QAAQ,CAAC,CAAC;IAC3E,CAAC;IAED;;;;;OAKG;IACH,iBAAiB,CAAC,UAAsB;QACpC,OAAO,aAAa,UAAU,CAAC,IAAI,+CAA+C,CAAC;IACvF,CAAC;IAED;;;;OAIG;IACH,gBAAgB,CAAC,UAAsB;QACnC,MAAM,cAAc,GAAG,IAAI,CAAC,iBAAiB,CAAC,UAAU,CAAC,CAAC;QAE1D,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC;YACvB,IAAI,CAAC,aAAa,CAAC,UAAU,EAAE,GAAG,cAAc,6DAA6D,CAAC,CAAA;YAC9G,OAAO,SAAS,CAAC;QACrB,CAAC;QAED,IAAI,kBAAkB,GAAuB,SAAS,CAAC;QACvD,MAAM,UAAU,GAAG,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC;QACxC,IAAI,CAAC;YACD,kBAAkB,GAAG,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,GAAG,CAAC,eAAe,CAAC,CAAC,UAAU,CAAC,CAAC;QAC9E,CAAC;QAAC,OAAO,KAAK,EAAE,CAAC;YACb,IAAI,CAAC,aAAa,CAAC,UAAU,EAAE,GAAG,cAAc,oGAAoG,CAAC,CAAC;YACtJ,OAAO,SAAS,CAAC;QACrB,CAAC;QAED,IAAI,kBAAkB,KAAK,SAAS,EAAE,CAAC;YACnC,IAAI,CAAC,aAAa,CAAC,UAAU,EAAE,GAAG,cAAc,wFAAwF,UAAU,IAAI,CAAC,CAAC;QAC5J,CAAC;QACD,OAAO,kBAAkB,CAAC;IAC9B,CAAC;CACJ"}

package/dist/rules/Section17_Functions/Rule_17_6_StaticArraySizeParam.d.ts

@@ -1,13 +1,23 @@
 import { Joinpoint } from "@specs-feup/clava/api/Joinpoints.js";
 import MISRARule from "../../MISRARule.js";
-import MISRAContext from "../../MISRAContext.js";
-import { MISRATransformationReport } from "../../MISRA.js";
+import { AnalysisType, MISRATransformationReport } from "../../MISRA.js";
 /**
- * MISRA Rule 17.6: The declaration of an array parameter shall not contain the static keyword between the [ ]
+ * MISRA-C Rule 17.6: The declaration of an array parameter shall not contain the static keyword between the [ ]
  */
 export default class Rule_17_6_StaticArraySizeParam extends MISRARule {
     #private;
-    constructor(context: MISRAContext);
+    /**
+     * Scope of analysis
+     */
+    readonly analysisType = AnalysisType.SINGLE_TRANSLATION_UNIT;
+    /**
+     * Standards to which this rule applies to
+     */
+    protected readonly appliesTo: Set<string>;
+    /**
+     * @returns Rule identifier according to MISRA-C:2012
+     */
+    get name(): string;
     /**
      * Checks if the given joinpoint represents a function with any array parameter containing the 'static' keyword between the [ ].
      *
@@ -22,6 +32,6 @@ export default class Rule_17_6_StaticArraySizeParam extends MISRARule {
      * @param $jp - Joinpoint to transform
      * @returns Report detailing the transformation result
      */
-    transform($jp: Joinpoint): MISRATransformationReport;
+    apply($jp: Joinpoint): MISRATransformationReport;
 }
 //# sourceMappingURL=Rule_17_6_StaticArraySizeParam.d.ts.map

package/dist/rules/Section17_Functions/Rule_17_6_StaticArraySizeParam.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"Rule_17_6_StaticArraySizeParam.d.ts","sourceRoot":"","sources":["../../../src/rules/Section17_Functions/Rule_17_6_StaticArraySizeParam.ts"],"names":[],"mappings":"AAAA,OAAO,EAAuC,SAAS,EAAS,MAAM,qCAAqC,CAAC;AAC5G,OAAO,SAAS,MAAM,oBAAoB,CAAC;AAC3C,OAAO,YAAY,MAAM,uBAAuB,CAAC;AAEjD,OAAO,EAAE,yBAAyB,EAA2B,MAAM,gBAAgB,CAAC;AAGpF;;GAEG;AACH,MAAM,CAAC,OAAO,OAAO,8BAA+B,SAAQ,SAAS;;gBAErD,OAAO,EAAE,YAAY;IAIjC;;;;;;OAMG;IACH,KAAK,CAAC,GAAG,EAAE,SAAS,EAAE,SAAS,GAAE,OAAe,GAAG,OAAO;IAiB1D;;;;;OAKG;IACH,SAAS,CAAC,GAAG,EAAE,SAAS,GAAG,yBAAyB;CAqBvD"}
+{"version":3,"file":"Rule_17_6_StaticArraySizeParam.d.ts","sourceRoot":"","sources":["../../../src/rules/Section17_Functions/Rule_17_6_StaticArraySizeParam.ts"],"names":[],"mappings":"AAAA,OAAO,EAAuC,SAAS,EAAS,MAAM,qCAAqC,CAAC;AAC5G,OAAO,SAAS,MAAM,oBAAoB,CAAC;AAE3C,OAAO,EAAE,YAAY,EAAE,yBAAyB,EAA2B,MAAM,gBAAgB,CAAC;AAGlG;;GAEG;AACH,MAAM,CAAC,OAAO,OAAO,8BAA+B,SAAQ,SAAS;;IACjE;;OAEG;IACH,QAAQ,CAAC,YAAY,wCAAwC;IAE7D;;OAEG;IACH,mBAA4B,SAAS,cAA2B;IAOhE;;OAEG;IACH,IAAa,IAAI,IAAI,MAAM,CAE1B;IAED;;;;;;OAMG;IACH,KAAK,CAAC,GAAG,EAAE,SAAS,EAAE,SAAS,GAAE,OAAe,GAAG,OAAO;IAiB1D;;;;;OAKG;IACH,KAAK,CAAC,GAAG,EAAE,SAAS,GAAG,yBAAyB;CAsBnD"}

package/dist/rules/Section17_Functions/Rule_17_6_StaticArraySizeParam.js

@@ -1,15 +1,29 @@
 import { AdjustedType, ArrayType, FunctionJp } from "@specs-feup/clava/api/Joinpoints.js";
 import MISRARule from "../../MISRARule.js";
 import ClavaJoinPoints from "@specs-feup/clava/api/clava/ClavaJoinPoints.js";
-import { MISRATransformationReport, MISRATransformationType } from "../../MISRA.js";
-import { getParamReferences } from "../../utils/utils.js";
+import { AnalysisType, MISRATransformationReport, MISRATransformationType } from "../../MISRA.js";
+import { getParamReferences } from "../../utils/FunctionUtils.js";
 /**
- * MISRA Rule 17.6: The declaration of an array parameter shall not contain the static keyword between the [ ]
+ * MISRA-C Rule 17.6: The declaration of an array parameter shall not contain the static keyword between the [ ]
  */
 export default class Rule_17_6_StaticArraySizeParam extends MISRARule {
+    /**
+     * Scope of analysis
+     */
+    analysisType = AnalysisType.SINGLE_TRANSLATION_UNIT;
+    /**
+     * Standards to which this rule applies to
+     */
+    appliesTo = new Set(["c99", "c11"]);
+    /**
+     * List of static array size params
+     */
     #invalidParams = [];
-    constructor(context) {
-        super("17.6", context);
+    /**
+     * @returns Rule identifier according to MISRA-C:2012
+     */
+    get name() {
+        return "17.6";
     }
     /**
      * Checks if the given joinpoint represents a function with any array parameter containing the 'static' keyword between the [ ].
@@ -19,7 +33,7 @@ export default class Rule_17_6_StaticArraySizeParam extends MISRARule {
      * @returns Returns true if the joinpoint violates the rule, false otherwise
      */
     match($jp, logErrors = false) {
-        if (!($jp instanceof FunctionJp) || $jp.root.standard === "c90")
+        if (!($jp instanceof FunctionJp && this.appliesToCurrentStandard()))
             return false;
         this.#invalidParams = $jp.params.filter(paramJp => paramJp.type instanceof AdjustedType &&
             paramJp.type.originalType instanceof ArrayType &&
@@ -38,7 +52,7 @@ export default class Rule_17_6_StaticArraySizeParam extends MISRARule {
      * @param $jp - Joinpoint to transform
      * @returns Report detailing the transformation result
      */
-    transform($jp) {
+    apply($jp) {
         if (!this.match($jp))
             return new MISRATransformationReport(MISRATransformationType.NoChange);
         for (const invalidParam of this.#invalidParams) {

package/dist/rules/Section17_Functions/Rule_17_6_StaticArraySizeParam.js.map

@@ -1 +1 @@
-{"version":3,"file":"Rule_17_6_StaticArraySizeParam.js","sourceRoot":"","sources":["../../../src/rules/Section17_Functions/Rule_17_6_StaticArraySizeParam.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,YAAY,EAAE,SAAS,EAAE,UAAU,EAAoB,MAAM,qCAAqC,CAAC;AAC5G,OAAO,SAAS,MAAM,oBAAoB,CAAC;AAE3C,OAAO,eAAe,MAAM,gDAAgD,CAAC;AAC7E,OAAO,EAAE,yBAAyB,EAAE,uBAAuB,EAAE,MAAM,gBAAgB,CAAC;AACpF,OAAO,EAAE,kBAAkB,EAAE,MAAM,sBAAsB,CAAC;AAE1D;;GAEG;AACH,MAAM,CAAC,OAAO,OAAO,8BAA+B,SAAQ,SAAS;IACjE,cAAc,GAAY,EAAE,CAAC;IAC7B,YAAY,OAAqB;QAC7B,KAAK,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;IAC3B,CAAC;IAED;;;;;;OAMG;IACH,KAAK,CAAC,GAAc,EAAE,YAAqB,KAAK;QAC5C,IAAI,CAAC,CAAC,GAAG,YAAY,UAAU,CAAC,IAAI,GAAG,CAAC,IAAI,CAAC,QAAQ,KAAK,KAAK;YAAE,OAAO,KAAK,CAAC;QAE9E,IAAI,CAAC,cAAc,GAAG,GAAG,CAAC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,EAAE,CAAC,OAAO,CAAC,IAAI,YAAY,YAAY;YACnF,OAAO,CAAC,IAAI,CAAC,YAAY,YAAY,SAAS;YAC9C,OAAO,CAAC,IAAI,CAAC,YAAY,CAAC,SAAS,KAAK,CAAC,CAAC;YAC1C,wBAAwB,CAAC,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,CAC9C,CAAC;QAEF,IAAI,SAAS,EAAE,CAAC;YACZ,KAAK,MAAM,YAAY,IAAI,IAAI,CAAC,cAAc,EAAE,CAAC;gBAC7C,IAAI,CAAC,aAAa,CAAC,YAAY,EAAE,uGAAuG,CAAC,CAAA;YAC7I,CAAC;QACL,CAAC;QACD,OAAO,IAAI,CAAC,cAAc,CAAC,MAAM,GAAG,CAAC,CAAC;IAC1C,CAAC;IAED;;;;;OAKG;IACH,SAAS,CAAC,GAAc;QACpB,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC;YAAE,OAAO,IAAI,yBAAyB,CAAC,uBAAuB,CAAC,QAAQ,CAAC,CAAC;QAE7F,KAAK,MAAM,YAAY,IAAI,IAAI,CAAC,cAAc,EAAE,CAAC;YAC7C,MAAM,SAAS,GAAG,kBAAkB,CAAC,YAAY,EAAE,GAAG,CAAC,CAAC;YAExD,yEAAyE;YACzE,MAAM,YAAY,GAAI,YAAY,CAAC,IAAqB,CAAC,YAAY,CAAC;YACtE,MAAM,KAAK,GAAG,eAAe,CAAC,KAAK,CAC/B,YAAY,CAAC,IAAI,EACjB,eAAe,CAAC,mBAAmB,CAAE,YAA0B,CAAC,WAAW,CAAC,CAC/E,CAAC;YACF,MAAM,QAAQ,GAAG,YAAY,CAAC,WAAW,CAAC,KAAK,CAAU,CAAC;YAE1D,mEAAmE;YACnE,KAAK,MAAM,GAAG,IAAI,SAAS,EAAE,CAAC;gBAC1B,GAAG,CAAC,WAAW,CAAC,QAAQ,CAAC,MAAM,EAAE,CAAC,CAAC;YACvC,CAAC;QACL,CAAC;QACD,OAAO,IAAI,yBAAyB,CAAC,uBAAuB,CAAC,gBAAgB,CAAC,CAAC;IACnF,CAAC;CACJ"}
+{"version":3,"file":"Rule_17_6_StaticArraySizeParam.js","sourceRoot":"","sources":["../../../src/rules/Section17_Functions/Rule_17_6_StaticArraySizeParam.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,YAAY,EAAE,SAAS,EAAE,UAAU,EAAoB,MAAM,qCAAqC,CAAC;AAC5G,OAAO,SAAS,MAAM,oBAAoB,CAAC;AAC3C,OAAO,eAAe,MAAM,gDAAgD,CAAC;AAC7E,OAAO,EAAE,YAAY,EAAE,yBAAyB,EAAE,uBAAuB,EAAE,MAAM,gBAAgB,CAAC;AAClG,OAAO,EAAE,kBAAkB,EAAE,MAAM,8BAA8B,CAAC;AAElE;;GAEG;AACH,MAAM,CAAC,OAAO,OAAO,8BAA+B,SAAQ,SAAS;IACjE;;OAEG;IACM,YAAY,GAAG,YAAY,CAAC,uBAAuB,CAAC;IAE7D;;OAEG;IACyB,SAAS,GAAG,IAAI,GAAG,CAAC,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC,CAAC;IAEhE;;OAEG;IACH,cAAc,GAAY,EAAE,CAAC;IAE7B;;OAEG;IACH,IAAa,IAAI;QACb,OAAO,MAAM,CAAC;IAClB,CAAC;IAED;;;;;;OAMG;IACH,KAAK,CAAC,GAAc,EAAE,YAAqB,KAAK;QAC5C,IAAI,CAAC,CAAC,GAAG,YAAY,UAAU,IAAI,IAAI,CAAC,wBAAwB,EAAE,CAAC;YAAE,OAAO,KAAK,CAAC;QAElF,IAAI,CAAC,cAAc,GAAG,GAAG,CAAC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,EAAE,CAAC,OAAO,CAAC,IAAI,YAAY,YAAY;YACnF,OAAO,CAAC,IAAI,CAAC,YAAY,YAAY,SAAS;YAC9C,OAAO,CAAC,IAAI,CAAC,YAAY,CAAC,SAAS,KAAK,CAAC,CAAC;YAC1C,wBAAwB,CAAC,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,CAC9C,CAAC;QAEF,IAAI,SAAS,EAAE,CAAC;YACZ,KAAK,MAAM,YAAY,IAAI,IAAI,CAAC,cAAc,EAAE,CAAC;gBAC7C,IAAI,CAAC,aAAa,CAAC,YAAY,EAAE,uGAAuG,CAAC,CAAA;YAC7I,CAAC;QACL,CAAC;QACD,OAAO,IAAI,CAAC,cAAc,CAAC,MAAM,GAAG,CAAC,CAAC;IAC1C,CAAC;IAED;;;;;OAKG;IACH,KAAK,CAAC,GAAc;QAChB,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC;YAChB,OAAO,IAAI,yBAAyB,CAAC,uBAAuB,CAAC,QAAQ,CAAC,CAAC;QAE3E,KAAK,MAAM,YAAY,IAAI,IAAI,CAAC,cAAc,EAAE,CAAC;YAC7C,MAAM,SAAS,GAAG,kBAAkB,CAAC,YAAY,EAAE,GAAiB,CAAC,CAAC;YAEtE,yEAAyE;YACzE,MAAM,YAAY,GAAI,YAAY,CAAC,IAAqB,CAAC,YAAY,CAAC;YACtE,MAAM,KAAK,GAAG,eAAe,CAAC,KAAK,CAC/B,YAAY,CAAC,IAAI,EACjB,eAAe,CAAC,mBAAmB,CAAE,YAA0B,CAAC,WAAW,CAAC,CAC/E,CAAC;YACF,MAAM,QAAQ,GAAG,YAAY,CAAC,WAAW,CAAC,KAAK,CAAU,CAAC;YAE1D,mEAAmE;YACnE,KAAK,MAAM,GAAG,IAAI,SAAS,EAAE,CAAC;gBAC1B,GAAG,CAAC,WAAW,CAAC,QAAQ,CAAC,MAAM,EAAE,CAAC,CAAC;YACvC,CAAC;QACL,CAAC;QACD,OAAO,IAAI,yBAAyB,CAAC,uBAAuB,CAAC,gBAAgB,CAAC,CAAC;IACnF,CAAC;CACJ"}