@specs-feup/clava-misra 1.0.0 → 1.0.2

package/src/misra/passes/S16_SwitchStatementPass.ts

@@ -1,168 +0,0 @@
-import { LaraJoinPoint } from "@specs-feup/lara/api/LaraJoinPoint.js";
-import MISRAPass from "../MISRAPass.js";
-import { PreprocessingReqs } from "../MISRAReporter.js";
-import { BinaryOp, Break, BuiltinType, Case, Expression, Joinpoint, Switch } from "@specs-feup/clava/api/Joinpoints.js";
-import Fix from "@specs-feup/clava/api/clava/analysis/Fix.js";
-import ClavaJoinPoints from "@specs-feup/clava/api/clava/ClavaJoinPoints.js";
-
-export default class S16_SwitchStatementPass extends MISRAPass {
-    protected _preprocessingReqs: PreprocessingReqs[] = [];
-    private _wellFormedSwitch: boolean = false;
-
-    initRuleMapper(): void {
-        this._ruleMapper = new Map([
-            [1, this.r16_1_16_3_wellFormedSwitch.bind(this)],
-            [2, this.r16_2_topLevelSwitchLabels.bind(this)],
-            [4, this.r16_4_switchHasDefault.bind(this)],
-            [5, this.r16_5_defaultFirstOrLast.bind(this)],
-            [6, this.r16_6_noTwoClauses.bind(this)],
-            [7, this.r16_7_noEssentialBooleanInSwitch.bind(this)]
-        ]);
-    }
-    
-    matchJoinpoint($jp: LaraJoinPoint): boolean {
-        return $jp instanceof Switch || $jp instanceof Case;
-    }
-
-    private r16_1_16_3_wellFormedSwitch($startNode: Joinpoint) {
-        if (!($startNode instanceof Switch)) return;
-        this._wellFormedSwitch = true;
-
-        let foundStmt = false;
-        let first = true;
-        for (const child of $startNode.children[1].children) {
-            if (child instanceof Break) {;
-                foundStmt = false;
-            }
-            else if (child instanceof Case) {
-                first = false;
-            }
-            else {
-                foundStmt = true;
-            }
-
-            if (foundStmt && child instanceof Case) {
-                this.logMISRAError(`A break is missing before ${child.code}`);
-                this._wellFormedSwitch = false;
-            }
-        }
-        if (!($startNode.children[1].lastChild instanceof Break)) {
-            this.logMISRAError("A break is missing at the end of the switch statement.");
-            this._wellFormedSwitch = false;
-        }  
-    }
-
-    private r16_2_topLevelSwitchLabels($startNode: Joinpoint) {
-        if (!($startNode instanceof Case)) return;
-
-        if (!($startNode.currentRegion instanceof Switch)) {
-            this.logMISRAError("A switch label can only be used if its enclosing compound statement is the switch statement itself.");
-        }
-    }
-
-    private r16_4_switchHasDefault($startNode: Joinpoint) {
-        if (!($startNode instanceof Switch && !$startNode.hasDefaultCase)) return;
-
-        this.logMISRAError("Switch statement is missing a default case.");
-    }
-    
-
-    private r16_5_defaultFirstOrLast($startNode: Joinpoint) {
-        if (!($startNode instanceof Switch)) return;
-
-        for (let i = 0; i < $startNode.cases.length; i++) {
-            if ($startNode.cases[i].isDefault && (i == 0 || i == $startNode.cases.length-1)) {
-                return;
-            }
-            else if ($startNode.cases[i].isDefault) {
-                this.logMISRAError("The default case of a switch statement must be the first or last label.");
-                return;
-            }
-        }
-    }
-
-    private r16_6_noTwoClauses($startNode: Joinpoint) {
-        if (!($startNode instanceof Switch)) return;
-        this.dependsOn(1, $startNode);
-        if (this._wellFormedSwitch === false) return; 
-
-        let clauses = 0;
-        for (const child of $startNode.children[1].children) {
-            if (child instanceof Break) {
-                clauses++;
-            }
-        }
-
-        if (clauses <= 2) {
-            this.logMISRAError("Switch statements should have more than two clauses.", new Fix(
-                $startNode,
-                (switchStmt: Joinpoint) => {
-                    const switchJp = switchStmt as Switch;
-                    let firstClauseExpr: Expression | undefined = undefined;
-                    let secondClauseExpr: Expression | undefined = undefined;
-                    let firstClause: Joinpoint[] = [];
-                    let secondClause: Joinpoint[] = [];
-                    let currClauseExpr: Expression | undefined = undefined;
-                    let currClause: Joinpoint[] = [];
-                    let clauseHasDefault: boolean = false;
-                    let filledFirstClause: boolean = false;
-                    const newVar = ClavaJoinPoints.varDecl("switchToIf_" + switchJp.astId, switchJp.condition);
-                    switchJp.insertBefore(newVar.stmt);
-                    for (const child of switchStmt.children[1].children) {
-                            if (child instanceof Case) {
-                                let tempOp: BinaryOp;
-                                if (child.isDefault) {
-                                    clauseHasDefault = true;
-                                    continue;
-                                }
-                                else if (child.values.length === 1) {
-                                    tempOp = ClavaJoinPoints.binaryOp("eq", newVar.varref(), child.values[0]);
-                                }
-                                else {
-                                    tempOp = ClavaJoinPoints.binaryOp("l_or", ClavaJoinPoints.binaryOp("ge", newVar.varref(), child.values[0]), ClavaJoinPoints.binaryOp("le", newVar.varref(), child.values[1]));
-                                }
-                                currClauseExpr = currClauseExpr ? ClavaJoinPoints.binaryOp("l_or", currClauseExpr, tempOp) : tempOp;
-                            }
-                            else if (child instanceof Break) {
-                                if (clauseHasDefault) {
-                                    secondClause = currClause;
-                                    secondClauseExpr = undefined;
-                                }
-                                else if (filledFirstClause) {
-                                    secondClause = currClause;
-                                    secondClauseExpr = currClauseExpr;
-                                }
-                                else {
-                                    firstClause = currClause;
-                                    firstClauseExpr = currClauseExpr;
-                                    filledFirstClause = true;
-                                }
-                                clauseHasDefault = false;
-                                currClause = [];
-                                currClauseExpr = undefined;
-                            }
-                            else {
-                                currClause.push(child);
-                            }
-                    }
-
-                    const elseStmt = secondClauseExpr ? ClavaJoinPoints.ifStmt(secondClauseExpr, ClavaJoinPoints.scope(...secondClause)) : ClavaJoinPoints.scope(...secondClause);
-                    switchJp.replaceWith(ClavaJoinPoints.ifStmt(firstClauseExpr ?? "", ClavaJoinPoints.scope(...firstClause), elseStmt));
-                }
-            ));
-        }
-    }
-
-    private r16_7_noEssentialBooleanInSwitch($startNode: Joinpoint) { //UNFINISHED, can have transformation
-        if (!($startNode instanceof Switch)) return;
-        this.dependsOn(1, $startNode);
-        if (this._wellFormedSwitch === false) return;
-
-        if ($startNode.condition.type.desugarAll instanceof BuiltinType && $startNode.condition.type.desugarAll.builtinKind === "Bool") {
-            this.logMISRAError("The controlling expression of a switch statement must not have essentially boolean type.");
-        }
-    }
-
-    protected _name: string = "Switch statements";
-
-}

package/src/misra/passes/S3_CommentPass.ts

@@ -1,40 +0,0 @@
-import { LaraJoinPoint } from "@specs-feup/lara/api/LaraJoinPoint.js";
-import MISRAPass from "../MISRAPass.js";
-import { PreprocessingReqs } from "../MISRAReporter.js";
-import { Comment, Joinpoint } from "@specs-feup/clava/api/Joinpoints.js";
-import Fix from "@specs-feup/clava/api/clava/analysis/Fix.js";
-
-export default class S3_CommentPass extends MISRAPass {
-    protected _preprocessingReqs: PreprocessingReqs[] = [];
-
-    initRuleMapper(): void {
-        this._ruleMapper = new Map([
-            [3, this.r3_1_fixComments.bind(this)]
-        ]);
-    }
-
-    matchJoinpoint($jp: LaraJoinPoint): boolean {
-        return true;
-    }
-
-    private static removeCommentSequences(str: string) {
-        return str.replace(/(\/\/|\/\*)/g, '');
-    }
-    
-    private r3_1_fixComments($startNode: Joinpoint) { //inlines
-        if ($startNode instanceof Comment && /(\/\/|\/\*)/g.test($startNode.text)) {
-            this.logMISRAError(`Comment ${$startNode.text} contains invalid character sequences.`, new Fix(
-                $startNode,
-                $jp => ($jp as Comment).setText(S3_CommentPass.removeCommentSequences($startNode.text))
-            ));
-        } 
-        $startNode.inlineComments.filter(comment => /(\/\/|\/\*)/g.test(comment.text)).forEach(comment => {
-            this.logMISRAError(`Comment ${comment.text} contains invalid character sequences.`, new Fix(
-                $startNode,
-                $jp => ($jp as Comment).setText(S3_CommentPass.removeCommentSequences(comment.text))
-            ));
-        });
-    }
-
-    protected _name: string = "Comments";
-}

package/src/misra/sections/Section21_StandardLibraries.ts

@@ -1,65 +0,0 @@
-import Query from "@specs-feup/lara/api/weaver/Query.js";
-import { Call, FileJp, Include, Joinpoint, Program } from "@specs-feup/clava/api/Joinpoints.js";
-import MISRAAnalyser from "../MISRAAnalyser.js";
-
-export default class Section21_StandardLibraries extends MISRAAnalyser {
-    ruleMapper: Map<number, (jp: FileJp | Program) => void>;
-
-    constructor(rules: number[]) {
-        super(rules);
-        this.ruleMapper = new Map([
-            [3, this.r21_3_noDynamicAllocation.bind(this)],
-            [4, this.r21_4_noSetjmpUsage.bind(this)],
-            [5, this.r21_5_noSignalUsage.bind(this)],
-            [6, this.r21_6_noStandardIO.bind(this)],
-            [7, this.r21_7_noStringFunctions.bind(this)],
-            [8, this.r21_8_noSysFunctions.bind(this)],
-            [9, this.r21_9_noStdAlgos.bind(this)],
-            [10, this.r21_10_noDateUsage.bind(this)],
-            [11, this.r21_11_noTgmathUsage.bind(this)],
-            [12, this.r21_12_noFenvExceptions.bind(this)]
-        ]);
-    }
-
-    private r21_3_noDynamicAllocation($startNode: Joinpoint) {
-        Query.searchFrom($startNode, Call, {name: /(malloc|realloc|calloc|free)/}).get().forEach(call => this.logMISRAError(call, "Use of memory allocation functions provided by <stdlib.h> is not allowed."), this);
-    }
-
-    private r21_4_noSetjmpUsage($startNode: Joinpoint) {
-        Query.searchFrom($startNode, Include, {name: "setjmp.h", isAngled: true}).get().forEach(include => this.logMISRAError(include, "Use of <setjmp.h> is not allowed."), this);
-    }
-    
-    private r21_5_noSignalUsage($startNode: Joinpoint) {
-        Query.searchFrom($startNode, Include, {name: "signal.h", isAngled: true}).get().forEach(include => this.logMISRAError(include, "Use of <setjmp.h> is not allowed."), this);
-    }
-
-    private r21_6_noStandardIO($startNode: Joinpoint) {
-        Query.searchFrom($startNode, Include, {name: /(stdio.h|wchar.h)/}).get().forEach(include => this.logMISRAError(include, "Use of the standard library I/O functions provided by <stdio.h> and <wchar.h> is not allowed."), this);
-    }
-
-    //how to avoid triggering errors for functions with the same name?
-    private r21_7_noStringFunctions($startNode: Joinpoint) {
-        Query.searchFrom($startNode, Call, {name: /(atoi|atof|atol|atoll)/}).get().forEach(call => this.logMISRAError(call, `Use of function ${call.signature} is not allowed.`), this);
-    }
-
-    private r21_8_noSysFunctions($startNode: Joinpoint) {
-        Query.searchFrom($startNode, Call, {name: /(system|abort|exit|getenv)/}).get().forEach(call => this.logMISRAError(call, `Use of function ${call.signature} is not allowed.`), this);
-    }
-
-    private r21_9_noStdAlgos($startNode: Joinpoint) {
-        Query.searchFrom($startNode, Call, {name: /(qsort|bsearch)/}).get().forEach(call => this.logMISRAError(call, `Use of function ${call.signature} is not allowed.`), this);
-    }
-
-    private r21_10_noDateUsage($startNode: Joinpoint) {
-        Query.searchFrom($startNode, Include, {name: "time.h", isAngled: true}).get().forEach(include => this.logMISRAError(include, "Use of <time.h> is not allowed."), this);
-        Query.searchFrom($startNode, Call, {name: "wcsftime"}).get().forEach(call => this.logMISRAError(call, "Identifier 'wcsftime' shall not be used."), this);
-    }
-    
-    private r21_11_noTgmathUsage($startNode: Joinpoint) {
-        Query.searchFrom($startNode, Include, {name: "tgmath.h", isAngled: true}).get().forEach(include => this.logMISRAError(include, "Use of <tgmath.h> is not allowed."), this);
-    }
-
-    private r21_12_noFenvExceptions($startNode: Joinpoint) {
-        Query.searchFrom($startNode, Call, {name : /(feclearexcept|fegetexceptflag|feraiseexcept|fesetexceptflag|fetestexcept)/}).get().forEach(call => this.logMISRAError(call, `Use of function ${call.signature} is not allowed`), this);
-    }
-}

package/src/misra/tests/S10_EssentialTypes.test.ts

@@ -1,253 +0,0 @@
-import MISRAReporter from "../MISRAReporter.js";
-import S10_EssentialTypePass from "../passes/S10_EssentialTypePass.js";
-import Query from "@specs-feup/lara/api/weaver/Query.js";
-import { FileJp, Joinpoint } from "@specs-feup/clava/api/Joinpoints.js";
-import { expectNumberOfErrors, registerSourceCode, TestFile } from "./utils.js";
-
-const passingOperands = `void goodOperands() {
-    bool bla, blb;
-    unsigned u8a, u8b, u16b;
-    char cha, chb;
-    enum ena {R,G,B} ena;
-    enum {K1=5}; 
-    int a1,s8a,s16b,s8b;
-    float f32a, f32b;
-
-    bla && blb;
-    bla ? u8a : u8b;
-    cha - chb;
-    cha > chb;
-    ena > a1;
-    K1 * s8a; /* Compliant as K1 from anonymous enum */
-    s8a + s16b;
-    -( s8a ) * s8b;
-    s8a > 0;
-    --s16b;
-    u8a + u16b;
-    u8a & 2U;
-    u8a > 0U;
-    u8a << 2U;
-    u8a << 1; /* Compliant by exception */
-    f32a + f32b;
-    f32a > 0.0;
-
-    '0' + u8a; /* Convert u8a to digit */
-    s8a + '0'; /* Convert s8a to digit */
-    cha - '0'; /* Convert cha to ordinal */
-    '0' - s8a; /* Convert -s8a to digit */
-}`;
-
-const failingOperands = `void badOperands() {
-    char cha, chb;
-    enum ena {R,G,B} ena;
-    bool bla, blb;
-    int a1,a2,s8a;
-    unsigned u8a;
-    float f32a;
-
-    cha && bla ; /* Rationale 2 - char type used as a Boolean value */
-    ena ? a1 : a2 ; /* Rationale 2 - enum type used as a Boolean value */
-    s8a && bla ; /* Rationale 2 - signed type used as a Boolean value */
-    u8a ? a1 : a2 ; /* Rationale 2 - unsigned type used as a Boolean value */
-    f32a && bla ; /* Rationale 2 - floating type used as a Boolean value */
-    bla * blb ; /* Rationale 3 - Boolean used as a numeric value */
-    bla > blb ; /* Rationale 3 - Boolean used as a numeric value */
-    cha & chb ; /* Rationale 4 - char type used as a numeric value */
-    cha << 1 ;  /* Rationale 4 - char type used as a numeric value */
-    ena * a1 ; /* Rationale 5 - enum type used in arithmetic operation */
-    s8a & 2 ; /* Rationale 6 - bitwise operation on signed type */
-    50 << 3U ;  /* Rationale 6 - shift operation on signed type */
-    u8a << s8a ;  /* Rationale 7 - shift magnitude uses signed type */
-    u8a << -1 ;  /* Rationale 7 - shift magnitude uses signed type */
-    -u8a ; /* Rationale 8 - unary minus on unsigned type */
-
-    int s16a;
-    s16a - 'a';
-    '0' + f32a;
-    cha + ':';
-    cha - ena;
-}`;
-
-const operandFiles: TestFile[] = [
-    {name: "badoperands.cpp", code: failingOperands},
-    {name: "goodoperands.cpp", code: passingOperands},
-];
-
-const passingAssignments = `void use_uint16(unsigned int a) {
-    return;
-}
-
-void goodAssignments() {
-    unsigned char u8b, u8c, u8d;
-    enum ena {R,G,B} ena;
-    enum {A1, K1};
-    int s8a;
-    char cha;
-
-    unsigned int u8a = 0; /* By exception */
-    bool flag = ( bool ) 0;
-    bool set = true; /* true is essentially Boolean */
-    bool get = ( u8b > u8c );
-    s8a = K1; /* Constant value fits */
-    u8a = 2; /* By exception */
-    //u8a = 2 * 24; /* By exception */ <-- DO THIS WHEN ISINTEGERCONSTANTEXPR IS AVAILABLE
-    u8a = ( unsigned int ) s8a; /* Cast gives same essential type */
-
-    unsigned int u32a;
-    unsigned char u16a, u16b;
-    u32a = u16a; /* Assignment to a wider essential type */
-    u32a = 2U + 125U; /* Assignment to a wider essential type */
-    use_uint16 ( u8a ); /* Assignment to a wider essential type */
-    use_uint16 ( u8a + u16b ); /* Assignment to same essential type */
-}`;
-
-const failingAssignments = `void use_uint32(unsigned int a) {
-    return;
-}
-
-void use_uint16(unsigned short a) {
-    return;
-}
-
-unsigned char foo1 ( unsigned int x )
-{
-return x; /* uint16_t to uint8_t */
-}
-
-void badAssignments() {
-    char cha;
-    unsigned u8b, u8c;
-    int s32a;
-    short u16a;
-    long u32a;
-
-    unsigned u8a = 1.0f; /* unsigned and floating */
-    bool bla = 0; /* boolean and signed */
-    cha = 7; /* character and signed */
-    u8a = 'a'; /* unsigned and character */
-    u8b = 1 - 2; /* unsigned and signed */
-    //u8c += 'a'; /* u8c = u8c + 'a' assigns character to unsigned */
-    use_uint32 ( s32a ); /* signed and unsigned */
-    //s8a = K2; /* Constant value does not fit */
-    u16a = u32a; /* uint32_t to uint16_t */
-    use_uint16 ( u32a ); /* uint32_t to uint16_t */
-}`;
-
-const assignmentFiles: TestFile[] = [
-    {name: "badassignments.cpp", code: failingAssignments},
-    {name: "goodassignments.cpp", code: passingAssignments}
-];
-
-const failingCasts = `void badCasts() {
-    enum enuma {R,G,B} ena;
-    enum enumc {C,M,Y} enc;
-
-    //( bool ) false; /* Compliant - 'false' is essentially Boolean */
-    //( int ) 3U; /* Compliant */
-    //( bool ) 0; /* Compliant - by exception */
-    ( bool ) 3U; /* Non-compliant */
-    //( int ) ena; /* Compliant */
-    ( enum enuma ) 3; /* Non-compliant */
-    //( char ) enc; /* Compliant */
-}`;
-
-const passingCasts = `void goodCasts() {
-    enum enuma {R,G,B} ena;
-    enum enumc {C,M,Y} enc;
-
-    ( bool ) false; /* Compliant - 'false' is essentially Boolean */
-    ( int ) 3U; /* Compliant */
-    ( bool ) 0; /* Compliant - by exception */
-    //( bool ) 3U; /* Non-compliant */
-    ( int ) ena; /* Compliant */
-    //( enum enuma ) 3; /* Non-compliant */
-    ( char ) enc; /* Compliant */
-}`;
-
-const castFiles: TestFile[] = [
-    {name: "goodcasts.cpp", code: passingCasts},
-    {name: "badcasts.cpp", code: failingCasts}
-];
-
-const passingComposites = `void goodComposites() {
-    unsigned short u16a,u16b,u16c;
-    unsigned long u32a,u32b;
-    signed long s32a;
-
-    u16c = u16a + u16b; /* Same essential type */
-    u32a = ( unsigned long ) u16a + u16b; /* Cast causes addition in uint32_t */
-
-    ( unsigned short ) ( u32a + u32b ); /* Compliant */
-    ( unsigned long ) s32a; /* Compliant - s32a is not composite */
-}`;
-
-const failingComposites = `void badComposites() {
-    unsigned short u16a,u16b,u16c;
-    unsigned long u32a,u32b;
-    signed long s32a,s32b;
-
-    u32a = u16a + u16b; /* Implicit conversion on assignment */
-    ( unsigned short ) ( s32a + s32b );
-    //( unsigned long ) ( u16a + u16b ); WIDTH PROBLEMS
-}`;
-
-const compositeFiles: TestFile[] = [
-    {name: "goodcomposites.cpp", code: passingComposites},
-    {name: "badcomposites.cpp", code: failingComposites}
-]
-
-describe("Essential type model: operands", () => {
-    const reporter = new MISRAReporter();
-    const pass = new S10_EssentialTypePass(true, [1, 2]);
-    registerSourceCode(operandFiles);
-
-    it("should pass", () => {
-        expectNumberOfErrors(reporter, pass, 0, Query.search(FileJp, {name: "goodoperands.cpp"}).first() as Joinpoint);
-    });
-    
-    it("should fail", () => {
-        expectNumberOfErrors(reporter, pass, 24, Query.search(FileJp, {name: "badoperands.cpp"}).first() as Joinpoint);
-    });
-});
-
-describe("Essential type model: assignments", () => {
-    const reporter = new MISRAReporter();
-    const pass = new S10_EssentialTypePass(true, [3]);
-    registerSourceCode(assignmentFiles);
-
-    it("should pass", () => {
-        expectNumberOfErrors(reporter, pass, 0, Query.search(FileJp, {name: "goodassignments.cpp"}).first() as Joinpoint);
-    });
-    
-    it("should fail", () => { //SHOULD BE 9 BUT DOESNT WORK FOR RETURN STMTS
-        expectNumberOfErrors(reporter, pass, 8, Query.search(FileJp, {name: "badassignments.cpp"}).first() as Joinpoint);
-    });
-});
-
-describe("Essential type model: casts", () => {
-    const reporter = new MISRAReporter();
-    const pass = new S10_EssentialTypePass(true, [5]);
-    registerSourceCode(castFiles);
-
-    it("should pass", () => {
-        expectNumberOfErrors(reporter, pass, 0, Query.search(FileJp, {name: "goodcasts.cpp"}).first() as Joinpoint);
-    });
-    
-    it("should fail", () => { //SHOULD BE 9 BUT DOESNT WORK FOR RETURN STMTS
-        expectNumberOfErrors(reporter, pass, 2, Query.search(FileJp, {name: "badcasts.cpp"}).first() as Joinpoint);
-    });
-});
-
-describe("Essential type model: composite expressions", () => {
-    const reporter = new MISRAReporter();
-    const pass = new S10_EssentialTypePass(true, [6,8]);
-    registerSourceCode(compositeFiles);
-
-    it("should pass", () => {
-        expectNumberOfErrors(reporter, pass, 0, Query.search(FileJp, {name: "goodcomposites.cpp"}).first() as Joinpoint);
-    });
-    
-    it("should fail", () => { //SHOULD BE 9 BUT DOESNT WORK FOR RETURN STMTS
-        expectNumberOfErrors(reporter, pass, 2, Query.search(FileJp, {name: "badcomposites.cpp"}).first() as Joinpoint);
-    });
-});

package/src/misra/tests/S12_Expressions.test.ts

@@ -1,43 +0,0 @@
-import MISRAReporter from "../MISRAReporter.js";
-import S12_ExpressionPass from "../passes/S12_ExpressionPass.js";
-import Query from "@specs-feup/lara/api/weaver/Query.js";
-import { FileJp, Joinpoint } from "@specs-feup/clava/api/Joinpoints.js";
-import { expectNumberOfErrors, registerSourceCode, TestFile } from "./utils.js";
-
-const passingCode = `int main(int argc, char *argv[]) {
-    int x, y, z;
-   x = 2;
-   y = 3;
-
-   x = x + (y * z);
-
-    return 0;
-}`;
-
-const failingCode = `int test(int argc, char *argv[]) {
-    int x, y, z;
-   x = 2, y = 3;
-
-   x = x + y * z;
-
-    return 0;
-}`;
-
-const files: TestFile[] = [
-    {name: "bad.cpp", code: failingCode},
-    {name: "good.cpp", code: passingCode}
-]
-
-describe("Expressions", () => {
-    const reporter = new MISRAReporter();
-    const pass = new S12_ExpressionPass(true, [1, 3]);
-    registerSourceCode(files);
-
-    it("should pass", () => {
-        expectNumberOfErrors(reporter, pass, 0, Query.search(FileJp, {name: "good.cpp"}).first() as Joinpoint);
-    });
-    
-    it("should fail", () => {
-        expectNumberOfErrors(reporter, pass, 2, Query.search(FileJp, {name: "bad.cpp"}).first() as Joinpoint);
-    });
-});

package/src/misra/tests/S13_SideEffects.test.ts

@@ -1,77 +0,0 @@
-import MISRAReporter from "../MISRAReporter.js";
-import S13_SideEffectPass from "../passes/S13_SideEffectPass.js";
-import Query from "@specs-feup/lara/api/weaver/Query.js";
-import { FileJp, Joinpoint } from "@specs-feup/clava/api/Joinpoints.js";
-import { expectNumberOfErrors, registerSourceCode, TestFile } from "./utils.js";
-
-const passingCode = `int v1;
-void f1 ( void )
-{
-int a[ 2 ] = { v1, 0 };
-}
-int x = 0u;
-extern void p ( int a[ 2 ] );
-void h1 ( void )
-{
-/* Non-compliant - two side effects */
-p ( ( int[ 2 ] ) { x, x } );
-}
-
-void foo1() {
-    unsigned u8a, u8b;
-    int a[4], x, y, s;
-    u8a = ( 1u == 1u ) ? 0u : u8b;
-    u8b++;
-    s = sizeof ( 5 ); 
-    if ( ( x == 0u ) || ( v1 == 1u ) )
-{
-}
-}`;
-
-const failingCode = `volatile int v1;
-void f ( void )
-{
-/* Non-compliant - volatile access is persistent side effect */
-int a[ 2 ] = { v1, 0 };
-}
-int x = 0u;
-extern void p ( int a[ 2 ] );
-void h ( void )
-{
-/* Non-compliant - two side effects */
-p ( ( int[ 2 ] ) { x++, x++ } );
-}
-
-int bar() {
-    return 5;
-}
-
-void foo() {
-    unsigned u8a, u8b;
-    int a[4], x, y, s;
-    u8a = ( 1u == 1u ) ? 0u : u8b++;
-    s = sizeof ( bar() ); /* Non-compliant */
-    a[ x ] = a[ x = y ];
-    if ( ( x == 0u ) || ( v1 == 1u ) )
-{
-}
-}`;
-
-const files: TestFile[] = [
-    {name: "bad.cpp", code: failingCode},
-    {name: "good.cpp", code: passingCode}
-]
-
-describe("Expressions", () => {
-    const reporter = new MISRAReporter();
-    const pass = new S13_SideEffectPass(true, [1, 3, 4, 5, 6]);
-    registerSourceCode(files);
-
-    it("should pass", () => {
-        expectNumberOfErrors(reporter, pass, 0, Query.search(FileJp, {name: "good.cpp"}).first() as Joinpoint);
-    });
-    
-    it("should fail", () => {
-        expectNumberOfErrors(reporter, pass, 8, Query.search(FileJp, {name: "bad.cpp"}).first() as Joinpoint);
-    });
-});