@specmarket/cli 0.0.4 → 0.0.6

package/src/commands/validate.test.ts

@@ -4,6 +4,18 @@ import { join } from 'path';
 import { tmpdir } from 'os';
 import { randomUUID } from 'crypto';
 import { validateSpec, detectCircularReferences } from './validate.js';
+import { SIDECAR_FILENAME } from '@specmarket/shared';
+
+const VALID_SPECMARKET_YAML = `spec_format: specmarket
+display_name: "Test Spec"
+description: "A valid test spec with enough description length to pass."
+output_type: web-app
+primary_stack: nextjs-typescript
+tags: []
+estimated_tokens: 50000
+estimated_cost_usd: 2.50
+estimated_time_minutes: 30
+`;
 
 const VALID_SPEC_YAML = `name: test-spec
 display_name: "Test Spec"
@@ -11,7 +23,7 @@ description: "A valid test spec with enough description length to pass."
 output_type: web-app
 primary_stack: nextjs-typescript
 version: "1.0.0"
-runner: claude-code
+runner: claude
 min_model: "claude-opus-4-5"
 estimated_tokens: 50000
 estimated_cost_usd: 2.50
@@ -51,6 +63,7 @@ describe('validateSpec', () => {
 
   async function writeValidSpec() {
     await Promise.all([
+      writeFile(join(tmpDir, SIDECAR_FILENAME), VALID_SPECMARKET_YAML),
       writeFile(join(tmpDir, 'spec.yaml'), VALID_SPEC_YAML),
       writeFile(join(tmpDir, 'PROMPT.md'), VALID_PROMPT_MD),
       writeFile(join(tmpDir, 'SPEC.md'), VALID_SPEC_MD),
@@ -84,6 +97,15 @@ describe('validateSpec', () => {
     expect(result.errors.some((e) => e.includes('PROMPT.md'))).toBe(true);
   });
 
+  it('reports error when specmarket.yaml is missing', async () => {
+    await writeValidSpec();
+    const { unlink } = await import('fs/promises');
+    await unlink(join(tmpDir, SIDECAR_FILENAME));
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(false);
+    expect(result.errors.some((e) => e.includes(SIDECAR_FILENAME) && e.includes('required'))).toBe(true);
+  });
+
   it('reports error for missing SUCCESS_CRITERIA.md', async () => {
     await writeValidSpec();
     const { unlink } = await import('fs/promises');
@@ -105,7 +127,7 @@ describe('validateSpec', () => {
     await writeValidSpec();
     await writeFile(
       join(tmpDir, 'spec.yaml'),
-      'name: Invalid Name With Spaces\ndisplay_name: "Test"\ndescription: "short"\noutput_type: invalid\nprimary_stack: nextjs-typescript\nversion: "1.0.0"\nrunner: claude-code\nmin_model: "model"\nestimated_tokens: 100\nestimated_cost_usd: 0.01\nestimated_time_minutes: 1\n'
+      'name: Invalid Name With Spaces\ndisplay_name: "Test"\ndescription: "short"\noutput_type: invalid\nprimary_stack: nextjs-typescript\nversion: "1.0.0"\nrunner: claude\nmin_model: "model"\nestimated_tokens: 100\nestimated_cost_usd: 0.01\nestimated_time_minutes: 1\n'
     );
     const result = await validateSpec(tmpDir);
     expect(result.valid).toBe(false);
@@ -276,3 +298,185 @@ describe('detectCircularReferences', () => {
     expect(cycles).toHaveLength(0);
   });
 });
+
+describe('validateSpec format-aware', () => {
+  let tmpDir: string;
+
+  beforeEach(async () => {
+    tmpDir = join(tmpdir(), `spec-format-${randomUUID()}`);
+    await mkdir(tmpDir, { recursive: true });
+  });
+
+  afterEach(async () => {
+    await rm(tmpDir, { recursive: true, force: true });
+  });
+
+  it('reports format from sidecar for specmarket spec', async () => {
+    await mkdir(join(tmpDir, 'stdlib'), { recursive: true });
+    await writeFile(join(tmpDir, SIDECAR_FILENAME), VALID_SPECMARKET_YAML);
+    await writeFile(join(tmpDir, 'spec.yaml'), VALID_SPEC_YAML);
+    await writeFile(join(tmpDir, 'PROMPT.md'), VALID_PROMPT_MD);
+    await writeFile(join(tmpDir, 'SPEC.md'), VALID_SPEC_MD);
+    await writeFile(join(tmpDir, 'SUCCESS_CRITERIA.md'), VALID_SUCCESS_CRITERIA);
+    await writeFile(join(tmpDir, 'stdlib', 'STACK.md'), VALID_STACK_MD);
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(true);
+    expect(result.format).toBe('specmarket');
+    expect(result.formatDetectedBy).toBe('sidecar');
+  });
+
+  const SIDECAR_SPECKIT = `spec_format: speckit
+display_name: My Spec
+description: A long enough description for the sidecar schema.
+output_type: web-app
+primary_stack: nextjs-typescript
+`;
+
+  it('speckit dir validates successfully', async () => {
+    await writeFile(join(tmpDir, SIDECAR_FILENAME), SIDECAR_SPECKIT);
+    await writeFile(join(tmpDir, 'spec.md'), '# Spec\nContent here.');
+    await writeFile(join(tmpDir, 'tasks.md'), '# Tasks');
+    await mkdir(join(tmpDir, '.specify'), { recursive: true });
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(true);
+    expect(result.format).toBe('speckit');
+  });
+
+  it('speckit missing tasks.md and plan.md returns error', async () => {
+    await writeFile(join(tmpDir, SIDECAR_FILENAME), SIDECAR_SPECKIT);
+    await writeFile(join(tmpDir, 'spec.md'), '# Spec');
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(false);
+    expect(result.errors.some((e) => e.includes('tasks.md') || e.includes('plan.md'))).toBe(true);
+  });
+
+  it('bmad dir validates successfully', async () => {
+    await writeFile(
+      join(tmpDir, SIDECAR_FILENAME),
+      `spec_format: bmad
+display_name: PRD Spec
+description: A long enough description for the sidecar schema.
+output_type: web-app
+primary_stack: nextjs-typescript
+`
+    );
+    await writeFile(join(tmpDir, 'prd.md'), '# PRD\nProduct requirements.');
+    await writeFile(join(tmpDir, 'story-1.md'), '# Story 1');
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(true);
+    expect(result.format).toBe('bmad');
+  });
+
+  it('ralph dir validates successfully', async () => {
+    await writeFile(
+      join(tmpDir, SIDECAR_FILENAME),
+      `spec_format: ralph
+display_name: Ralph Spec
+description: A long enough description for the sidecar schema.
+output_type: web-app
+primary_stack: nextjs-typescript
+`
+    );
+    await writeFile(
+      join(tmpDir, 'prd.json'),
+      JSON.stringify({ userStories: [{ title: 'As a user I want X' }] })
+    );
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(true);
+    expect(result.format).toBe('ralph');
+  });
+
+  it('ralph prd.json missing userStories returns error', async () => {
+    await writeFile(
+      join(tmpDir, SIDECAR_FILENAME),
+      `spec_format: ralph
+display_name: Ralph Spec
+description: A long enough description for the sidecar schema.
+output_type: web-app
+primary_stack: nextjs-typescript
+`
+    );
+    await writeFile(join(tmpDir, 'prd.json'), JSON.stringify({ other: true }));
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(false);
+    expect(result.errors.some((e) => e.includes('userStories'))).toBe(true);
+  });
+
+  it('custom dir with sufficient .md validates', async () => {
+    await writeFile(
+      join(tmpDir, SIDECAR_FILENAME),
+      `spec_format: custom
+display_name: Custom Spec
+description: A long enough description for the sidecar schema.
+output_type: web-app
+primary_stack: nextjs-typescript
+`
+    );
+    const content =
+      '# Readme\n\nThis is a spec with enough content to pass the 100-byte minimum for custom format. Extra text here.';
+    expect(content.length).toBeGreaterThan(100);
+    await writeFile(join(tmpDir, 'readme.md'), content);
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(true);
+    expect(result.format).toBe('custom');
+  });
+
+  it('custom dir with only tiny .md files fails', async () => {
+    await writeFile(
+      join(tmpDir, SIDECAR_FILENAME),
+      `spec_format: custom
+display_name: Custom Spec
+description: A long enough description for the sidecar schema.
+output_type: web-app
+primary_stack: nextjs-typescript
+`
+    );
+    await writeFile(join(tmpDir, 'tiny.md'), 'x');
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(false);
+    expect(result.errors.some((e) => e.includes('100 bytes'))).toBe(true);
+  });
+
+  it('sidecar with invalid schema returns validation error', async () => {
+    await writeFile(join(tmpDir, 'spec.md'), '# Spec');
+    await writeFile(join(tmpDir, 'tasks.md'), '# Tasks');
+    await writeFile(
+      join(tmpDir, SIDECAR_FILENAME),
+      'spec_format: speckit\ndisplay_name: X\ndescription: short'
+    );
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(false);
+    expect(result.errors.some((e) => e.includes(SIDECAR_FILENAME))).toBe(true);
+  });
+
+  it('sidecar with valid schema passes and format is from sidecar', async () => {
+    await writeFile(join(tmpDir, 'spec.md'), '# Spec');
+    await writeFile(join(tmpDir, 'tasks.md'), '# Tasks');
+    await writeFile(
+      join(tmpDir, SIDECAR_FILENAME),
+      `spec_format: speckit
+display_name: My Spec
+description: A long enough description for the sidecar schema.
+output_type: web-app
+primary_stack: nextjs-typescript
+`
+    );
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(true);
+    expect(result.format).toBe('speckit');
+    expect(result.formatDetectedBy).toBe('sidecar');
+  });
+
+  it('empty directory fails with universal check', async () => {
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(false);
+    expect(result.errors.some((e) => e.includes('empty') || e.includes('unreadable'))).toBe(true);
+  });
+
+  it('directory with only subdir and no files fails', async () => {
+    await mkdir(join(tmpDir, 'sub'), { recursive: true });
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(false);
+    expect(result.errors.some((e) => e.includes('empty') || e.includes('readable'))).toBe(true);
+  });
+});