@specmarket/cli 0.0.4 → 0.0.5

package/src/commands/search.test.ts

@@ -0,0 +1,147 @@
+import { describe, it, expect, vi, beforeEach } from 'vitest';
+
+// --- Hoisted mocks ---
+
+const { mockQuery, mockClient, mockSpinner } = vi.hoisted(() => {
+  const mockQuery = vi.fn();
+  const mockClient = { query: mockQuery };
+  const mockSpinner = {
+    start: vi.fn().mockReturnThis(),
+    stop: vi.fn().mockReturnThis(),
+    succeed: vi.fn().mockReturnThis(),
+    fail: vi.fn().mockReturnThis(),
+  };
+  return { mockQuery, mockClient, mockSpinner };
+});
+
+vi.mock('../lib/convex-client.js', () => ({
+  getConvexClient: vi.fn().mockResolvedValue(mockClient),
+}));
+
+vi.mock('ora', () => ({
+  default: vi.fn().mockReturnValue(mockSpinner),
+}));
+
+vi.mock('@specmarket/convex/api', () => ({
+  api: {
+    specs: { search: 'specs.search' },
+  },
+}));
+
+const mockExit = vi.spyOn(process, 'exit').mockImplementation((() => {
+  throw new Error('process.exit called');
+}) as any);
+
+const consoleSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
+vi.spyOn(console, 'error').mockImplementation(() => {});
+
+import { handleSearch } from './search.js';
+
+// --- Test data ---
+
+const MOCK_RESULTS = [
+  {
+    scopedName: '@alice/todo-app',
+    description: 'A simple todo application with authentication and dark mode',
+    replacesSaas: 'Todoist',
+    successRate: 0.85,
+    avgCostUsd: 1.5,
+    communityRating: 4.2,
+  },
+  {
+    scopedName: '@bob/crm-tool',
+    description: 'Customer relationship manager with pipeline tracking',
+    replacesSaas: null,
+    successRate: 0,
+    avgCostUsd: 0,
+    communityRating: 0,
+  },
+];
+
+describe('handleSearch', () => {
+  beforeEach(() => {
+    vi.clearAllMocks();
+    mockExit.mockImplementation((() => {
+      throw new Error('process.exit called');
+    }) as any);
+  });
+
+  it('displays results in table format', async () => {
+    mockQuery.mockResolvedValue(MOCK_RESULTS);
+
+    await handleSearch('todo', {});
+
+    expect(mockQuery).toHaveBeenCalledWith('specs.search', {
+      query: 'todo',
+      limit: 20,
+    });
+    expect(consoleSpy).toHaveBeenCalledWith(
+      expect.stringContaining('Found 2 spec(s)')
+    );
+  });
+
+  it('shows no-results message when no specs match', async () => {
+    mockQuery.mockResolvedValue([]);
+
+    await handleSearch('nonexistent', {});
+
+    expect(consoleSpy).toHaveBeenCalledWith(
+      expect.stringContaining('No specs found')
+    );
+  });
+
+  it('passes filter options to backend query', async () => {
+    mockQuery.mockResolvedValue([]);
+
+    await handleSearch('test', {
+      outputType: 'web-app',
+      primaryStack: 'nextjs-typescript',
+      replacesSaas: 'Notion',
+      limit: '10',
+      tag: ['productivity'],
+      freeTierOnly: true,
+    });
+
+    expect(mockQuery).toHaveBeenCalledWith('specs.search', {
+      query: 'test',
+      limit: 10,
+      outputType: 'web-app',
+      primaryStack: 'nextjs-typescript',
+      replacesSaas: 'Notion',
+      tags: ['productivity'],
+      freeTierOnly: true,
+    });
+  });
+
+  it('converts min-success-rate from percentage to decimal', async () => {
+    mockQuery.mockResolvedValue([]);
+
+    await handleSearch('test', { minSuccessRate: '80' });
+
+    expect(mockQuery).toHaveBeenCalledWith('specs.search', {
+      query: 'test',
+      limit: 20,
+      minSuccessRate: 0.8,
+    });
+  });
+
+  it('exits with error for invalid min-success-rate', async () => {
+    await expect(
+      handleSearch('test', { minSuccessRate: '150' })
+    ).rejects.toThrow('process.exit called');
+
+    expect(mockSpinner.fail).toHaveBeenCalledWith(
+      expect.stringContaining('--min-success-rate must be between 0 and 100')
+    );
+  });
+
+  it('exits with error for invalid max-cost', async () => {
+    await expect(
+      handleSearch('test', { maxCost: '-5' })
+    ).rejects.toThrow('process.exit called');
+
+    expect(mockSpinner.fail).toHaveBeenCalledWith(
+      expect.stringContaining('--max-cost must be a non-negative number')
+    );
+  });
+});

package/src/commands/validate.test.ts

@@ -11,7 +11,7 @@ description: "A valid test spec with enough description length to pass."
 output_type: web-app
 primary_stack: nextjs-typescript
 version: "1.0.0"
-runner: claude-code
+runner: claude
 min_model: "claude-opus-4-5"
 estimated_tokens: 50000
 estimated_cost_usd: 2.50
@@ -105,7 +105,7 @@ describe('validateSpec', () => {
     await writeValidSpec();
     await writeFile(
       join(tmpDir, 'spec.yaml'),
-      'name: Invalid Name With Spaces\ndisplay_name: "Test"\ndescription: "short"\noutput_type: invalid\nprimary_stack: nextjs-typescript\nversion: "1.0.0"\nrunner: claude-code\nmin_model: "model"\nestimated_tokens: 100\nestimated_cost_usd: 0.01\nestimated_time_minutes: 1\n'
+      'name: Invalid Name With Spaces\ndisplay_name: "Test"\ndescription: "short"\noutput_type: invalid\nprimary_stack: nextjs-typescript\nversion: "1.0.0"\nrunner: claude\nmin_model: "model"\nestimated_tokens: 100\nestimated_cost_usd: 0.01\nestimated_time_minutes: 1\n'
     );
     const result = await validateSpec(tmpDir);
     expect(result.valid).toBe(false);
@@ -276,3 +276,130 @@ describe('detectCircularReferences', () => {
     expect(cycles).toHaveLength(0);
   });
 });
+
+describe('validateSpec format-aware', () => {
+  let tmpDir: string;
+
+  beforeEach(async () => {
+    tmpDir = join(tmpdir(), `spec-format-${randomUUID()}`);
+    await mkdir(tmpDir, { recursive: true });
+  });
+
+  afterEach(async () => {
+    await rm(tmpDir, { recursive: true, force: true });
+  });
+
+  it('reports format and formatDetectedBy in result for legacy spec', async () => {
+    await mkdir(join(tmpDir, 'stdlib'), { recursive: true });
+    await writeFile(join(tmpDir, 'spec.yaml'), VALID_SPEC_YAML);
+    await writeFile(join(tmpDir, 'PROMPT.md'), VALID_PROMPT_MD);
+    await writeFile(join(tmpDir, 'SPEC.md'), VALID_SPEC_MD);
+    await writeFile(join(tmpDir, 'SUCCESS_CRITERIA.md'), VALID_SUCCESS_CRITERIA);
+    await writeFile(join(tmpDir, 'stdlib', 'STACK.md'), VALID_STACK_MD);
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(true);
+    expect(result.format).toBe('specmarket-legacy');
+    expect(result.formatDetectedBy).toBe('heuristic');
+  });
+
+  it('speckit dir validates successfully', async () => {
+    await writeFile(join(tmpDir, 'spec.md'), '# Spec\nContent here.');
+    await writeFile(join(tmpDir, 'tasks.md'), '# Tasks');
+    await mkdir(join(tmpDir, '.specify'), { recursive: true });
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(true);
+    expect(result.format).toBe('speckit');
+  });
+
+  it('speckit missing tasks.md and plan.md returns error', async () => {
+    await writeFile(join(tmpDir, 'spec.md'), '# Spec');
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(false);
+    expect(result.errors.some((e) => e.includes('tasks.md') || e.includes('plan.md'))).toBe(true);
+  });
+
+  it('bmad dir validates successfully', async () => {
+    await writeFile(join(tmpDir, 'prd.md'), '# PRD\nProduct requirements.');
+    await writeFile(join(tmpDir, 'story-1.md'), '# Story 1');
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(true);
+    expect(result.format).toBe('bmad');
+  });
+
+  it('ralph dir validates successfully', async () => {
+    await writeFile(
+      join(tmpDir, 'prd.json'),
+      JSON.stringify({ userStories: [{ title: 'As a user I want X' }] })
+    );
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(true);
+    expect(result.format).toBe('ralph');
+  });
+
+  it('ralph prd.json missing userStories returns error', async () => {
+    await writeFile(join(tmpDir, 'prd.json'), JSON.stringify({ other: true }));
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(false);
+    expect(result.errors.some((e) => e.includes('userStories'))).toBe(true);
+  });
+
+  it('custom dir with sufficient .md validates', async () => {
+    const content =
+      '# Readme\n\nThis is a spec with enough content to pass the 100-byte minimum for custom format. Extra text here.';
+    expect(content.length).toBeGreaterThan(100);
+    await writeFile(join(tmpDir, 'readme.md'), content);
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(true);
+    expect(result.format).toBe('custom');
+  });
+
+  it('custom dir with only tiny .md files fails', async () => {
+    await writeFile(join(tmpDir, 'tiny.md'), 'x');
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(false);
+    expect(result.errors.some((e) => e.includes('100 bytes'))).toBe(true);
+  });
+
+  it('sidecar with invalid schema returns validation error', async () => {
+    await writeFile(join(tmpDir, 'spec.md'), '# Spec');
+    await writeFile(join(tmpDir, 'tasks.md'), '# Tasks');
+    await writeFile(
+      join(tmpDir, 'specmarket.yaml'),
+      'spec_format: speckit\ndisplay_name: X\ndescription: short'
+    );
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(false);
+    expect(result.errors.some((e) => e.includes('specmarket.yaml'))).toBe(true);
+  });
+
+  it('sidecar with valid schema passes and format is from sidecar', async () => {
+    await writeFile(join(tmpDir, 'spec.md'), '# Spec');
+    await writeFile(join(tmpDir, 'tasks.md'), '# Tasks');
+    await writeFile(
+      join(tmpDir, 'specmarket.yaml'),
+      `spec_format: speckit
+display_name: My Spec
+description: A long enough description for the sidecar schema.
+output_type: web-app
+primary_stack: nextjs-typescript
+`
+    );
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(true);
+    expect(result.format).toBe('speckit');
+    expect(result.formatDetectedBy).toBe('sidecar');
+  });
+
+  it('empty directory fails with universal check', async () => {
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(false);
+    expect(result.errors.some((e) => e.includes('empty') || e.includes('unreadable'))).toBe(true);
+  });
+
+  it('directory with only subdir and no files fails', async () => {
+    await mkdir(join(tmpDir, 'sub'), { recursive: true });
+    const result = await validateSpec(tmpDir);
+    expect(result.valid).toBe(false);
+    expect(result.errors.some((e) => e.includes('empty') || e.includes('readable'))).toBe(true);
+  });
+});