@specific.dev/spectest 0.81.1 → 0.83.0

package/src/daemon.ts

@@ -49,6 +49,8 @@ import {
 } from "./harness/coverage.js";
 import { configureBrowserCoverage } from "./browser-coverage.js";
 import {
+  NODE_COVERAGE_MARKERS_SUBDIR,
+  NODE_COVERAGE_SCRIPTS_SUBDIR,
   applyCoverageAdapters,
   coverageAdapters,
   coverageReportsMode,
@@ -974,10 +976,15 @@ async function ensureCoverage(svc: NamedService): Promise<string[]> {
   if (svc.coverage === undefined) return [];
   validateCoverage(svc.name, svc.coverage);
   const host = coverageHostDir(WORKSPACE, svc.name);
-  await fs.mkdir(host, { recursive: true });
-  await fs.chmod(host, 0o777);
-  // Nothing else is mounted: no conversion runs in the container (the
-  // c8 tools mount went with SDK 0.80).
+  // World-writable, the subdirectories the node() hook writes into too:
+  // the container's processes run as whatever user the image says, and
+  // a directory the first of them created would be closed to the next.
+  for (const d of [host, path.join(host, NODE_COVERAGE_SCRIPTS_SUBDIR), path.join(host, NODE_COVERAGE_MARKERS_SUBDIR)]) {
+    await fs.mkdir(d, { recursive: true });
+    await fs.chmod(d, 0o777);
+  }
+  // Nothing else is mounted: nothing runs in the container for coverage
+  // beyond the hook in the process itself.
   return [`--volume=${host}:${COVERAGE_CONTAINER_DIR}`];
 }
 
@@ -4052,21 +4059,6 @@ function coverageCaptureContext(
       await fs.rename(tmp, file);
       written.add(path.relative(reportDir, file));
     },
-    async readContainerFile(containerPath: string) {
-      // `docker cp` rather than `exec cat`: a source map can be tens of
-      // MB, and the exec path buffers stdout as a string. The copy lands
-      // in the VM's tmp, never in the coverage directory (it would ship).
-      const tmp = path.join(tmpdir(), `spectest-cov-${svc.name}-${process.pid}-${Date.now()}-${Math.random().toString(36).slice(2)}`);
-      try {
-        const r = await docker(["cp", `${svc.name}:${containerPath}`, tmp], COVERAGE_CAPTURE_TIMEOUT_MS);
-        if (r.code !== 0) return null;
-        return await fs.readFile(tmp);
-      } catch {
-        return null;
-      } finally {
-        await fs.rm(tmp, { force: true, recursive: true }).catch(() => {});
-      }
-    },
   };
 }
 

package/src/harness/coverage.ts

@@ -3,7 +3,8 @@
 // A service that opts in (`coverage: true | { command }`) gets a writable
 // directory bind-mounted at `/spectest/coverage/` in its container. The
 // service's own tool, or its coverage adapters, write reports there —
-// lcov, or the V8 coverage JSON that `NODE_V8_COVERAGE` writes. The daemon reads the
+// lcov, the V8 coverage JSON shape (what `coverage.node()`'s hook or
+// `NODE_V8_COVERAGE` write), or a node() script record. The daemon reads the
 // directory from the VM side (no `docker exec` to fetch) after bring-up
 // and after each test, and ships the reports **verbatim** to the control
 // plane as a gzipped bundle. Nothing is interpreted here beyond the one
@@ -107,17 +108,26 @@ export function isLcovShaped(text: string): boolean {
 
 /**
  * True when `text` looks like a V8 coverage JSON document — what
- * `NODE_V8_COVERAGE` / `v8.takeCoverage()` write: an object with a
- * `result` array of scripts. A cheap shape check, not a parse (a report
- * can be megabytes); the control plane parses for real.
+ * `NODE_V8_COVERAGE` / `v8.takeCoverage()` write, and the shape the
+ * `node()` hook's dumps keep: an object with a `result` array of
+ * scripts. A cheap shape check, not a parse (a report can be
+ * megabytes); the control plane parses for real.
  */
 export function isV8CoverageJson(text: string): boolean {
   return /^\s*\{/.test(text) && /"result"\s*:\s*\[/.test(text);
 }
 
-/** True when `text` is a report spectest stores: lcov or V8 JSON. */
+/** True when `text` is a script record the `node()` hook writes
+ *  (`scripts/<id>.json`: `{ "spectestScript": { url, lineLengths,
+ *  functions, sourceMap } }`), the static side of its dumps. */
+export function isSpectestScriptRecord(text: string): boolean {
+  return /^\s*\{\s*"spectestScript"\s*:/.test(text);
+}
+
+/** True when `text` is a report spectest stores: lcov, V8 JSON, or a
+ *  node() script record. */
 export function isWellFormedReport(text: string): boolean {
-  return isLcovShaped(text) || isV8CoverageJson(text);
+  return isLcovShaped(text) || isV8CoverageJson(text) || isSpectestScriptRecord(text);
 }
 
 /** True when a well-formed report names no source file at all (an lcov