@specific.dev/spectest 0.81.0 → 0.82.0

package/dist/daemon.js

@@ -24,7 +24,7 @@ import { pathToFileURL } from "node:url";
 import { assert, expect, expectRaw, lowerIngress, dnsName as makeDnsDecl, isWildcard, validateServiceImage, proxy as makeProxyDecl, } from "./index.js";
 import { COVERAGE_CONTAINER_DIR, coverageBundleRef, coverageHostDir, encodeCoverageBundle, isEmptyReport, readCoverageDir, applyCoverageDelta, } from "./harness/coverage.js";
 import { configureBrowserCoverage } from "./browser-coverage.js";
-import { applyCoverageAdapters, coverageAdapters, coverageReportsMode, validateCoverage, } from "./coverage.js";
+import { NODE_COVERAGE_MARKERS_SUBDIR, NODE_COVERAGE_SCRIPTS_SUBDIR, applyCoverageAdapters, coverageAdapters, coverageReportsMode, validateCoverage, } from "./coverage.js";
 import { serviceForHost as hostToService } from "./harness/browser-coverage.js";
 import { acquirePersistentBrowser, mobileKey } from "./browser.js";
 import { isMobileApp, openPersistentMobile } from "./mobile.js";
@@ -40,7 +40,7 @@ import { LOG_DELTA_MAX_BYTES, capMiddle, streamDelta } from "./harness/log-delta
 import { resolveHostPath as resolveVolumeHostPath, sanitizeSegment, } from "./harness/volume-paths.js";
 import { pollUntilReady } from "./harness/ready-poll.js";
 import { runWrapperRules } from "./harness/wrapper-rules.js";
-import { cpus, tmpdir } from "node:os";
+import { cpus } from "node:os";
 import { APP_DIR, WORKSPACE, resolveExistingProjectPath, resolveProjectPath } from "./project-files.js";
 import { installFetchWrapper, isTransportError } from "./harness/fetch.js";
 import { bindInstrumentationScope, createInstrumentationScope, runInstrumented, runUninstrumented, } from "./harness/instrumentation-scope.js";
@@ -688,10 +688,15 @@ async function ensureCoverage(svc) {
         return [];
     validateCoverage(svc.name, svc.coverage);
     const host = coverageHostDir(WORKSPACE, svc.name);
-    await fs.mkdir(host, { recursive: true });
-    await fs.chmod(host, 0o777);
-    // Nothing else is mounted: no conversion runs in the container (the
-    // c8 tools mount went with SDK 0.80).
+    // World-writable, the subdirectories the node() hook writes into too:
+    // the container's processes run as whatever user the image says, and
+    // a directory the first of them created would be closed to the next.
+    for (const d of [host, path.join(host, NODE_COVERAGE_SCRIPTS_SUBDIR), path.join(host, NODE_COVERAGE_MARKERS_SUBDIR)]) {
+        await fs.mkdir(d, { recursive: true });
+        await fs.chmod(d, 0o777);
+    }
+    // Nothing else is mounted: nothing runs in the container for coverage
+    // beyond the hook in the process itself.
     return [`--volume=${host}:${COVERAGE_CONTAINER_DIR}`];
 }
 /** Keyed by image ID, not tag: `spectest/<svc>:latest` is retagged onto
@@ -3392,24 +3397,6 @@ function coverageCaptureContext(svc, signal, written) {
             await fs.rename(tmp, file);
             written.add(path.relative(reportDir, file));
         },
-        async readContainerFile(containerPath) {
-            // `docker cp` rather than `exec cat`: a source map can be tens of
-            // MB, and the exec path buffers stdout as a string. The copy lands
-            // in the VM's tmp, never in the coverage directory (it would ship).
-            const tmp = path.join(tmpdir(), `spectest-cov-${svc.name}-${process.pid}-${Date.now()}-${Math.random().toString(36).slice(2)}`);
-            try {
-                const r = await docker(["cp", `${svc.name}:${containerPath}`, tmp], COVERAGE_CAPTURE_TIMEOUT_MS);
-                if (r.code !== 0)
-                    return null;
-                return await fs.readFile(tmp);
-            }
-            catch {
-                return null;
-            }
-            finally {
-                await fs.rm(tmp, { force: true, recursive: true }).catch(() => { });
-            }
-        },
     };
 }
 /** Run one service's adapters in order under one budget. Returns the

package/dist/harness/coverage.d.ts

@@ -62,7 +62,12 @@ export declare function isLcovShaped(text: string): boolean;
  * can be megabytes); the control plane parses for real.
  */
 export declare function isV8CoverageJson(text: string): boolean;
-/** True when `text` is a report spectest stores: lcov or V8 JSON. */
+/** True when `text` is a script record the `node()` hook writes
+ *  (`scripts/<id>.json`: `{ "spectestScript": { url, lineLengths,
+ *  functions, sourceMap } }`), the static side of its dumps. */
+export declare function isSpectestScriptRecord(text: string): boolean;
+/** True when `text` is a report spectest stores: lcov, V8 JSON, or a
+ *  node() script record. */
 export declare function isWellFormedReport(text: string): boolean;
 /** True when a well-formed report names no source file at all (an lcov
  *  with no `SF:`, a V8 document with an empty `result`). */

package/dist/harness/coverage.js

@@ -3,7 +3,8 @@
 // A service that opts in (`coverage: true | { command }`) gets a writable
 // directory bind-mounted at `/spectest/coverage/` in its container. The
 // service's own tool, or its coverage adapters, write reports there —
-// lcov, or the V8 coverage JSON that `NODE_V8_COVERAGE` writes. The daemon reads the
+// lcov, the V8 coverage JSON shape (what `coverage.node()`'s hook or
+// `NODE_V8_COVERAGE` write), or a node() script record. The daemon reads the
 // directory from the VM side (no `docker exec` to fetch) after bring-up
 // and after each test, and ships the reports **verbatim** to the control
 // plane as a gzipped bundle. Nothing is interpreted here beyond the one
@@ -62,9 +63,16 @@ export function isLcovShaped(text) {
 export function isV8CoverageJson(text) {
     return /^\s*\{/.test(text) && /"result"\s*:\s*\[/.test(text);
 }
-/** True when `text` is a report spectest stores: lcov or V8 JSON. */
+/** True when `text` is a script record the `node()` hook writes
+ *  (`scripts/<id>.json`: `{ "spectestScript": { url, lineLengths,
+ *  functions, sourceMap } }`), the static side of its dumps. */
+export function isSpectestScriptRecord(text) {
+    return /^\s*\{\s*"spectestScript"\s*:/.test(text);
+}
+/** True when `text` is a report spectest stores: lcov, V8 JSON, or a
+ *  node() script record. */
 export function isWellFormedReport(text) {
-    return isLcovShaped(text) || isV8CoverageJson(text);
+    return isLcovShaped(text) || isV8CoverageJson(text) || isSpectestScriptRecord(text);
 }
 /** True when a well-formed report names no source file at all (an lcov
  *  with no `SF:`, a V8 document with an empty `result`). */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@specific.dev/spectest",
-  "version": "0.81.0",
+  "version": "0.82.0",
   "description": "Spectest SDK for defining test environments in TypeScript.",
   "type": "module",
   "main": "./dist/index.js",